| === beuno_ is now known as beuno | ||
| mandel | morning all! | 07:50 |
|---|---|---|
| JamesTait | Good morning all! :) | 08:58 |
| mandel | lunch time! | 12:26 |
| * mandel lunch | 12:26 | |
| rye | alecu: bug #1021098 - how can i notice that the proxy needs authentication if user is not aware of that | 12:27 |
| ubot5 | Launchpad bug 1021098 in Ubuntu One Windows Installer "Installer 3.0.2 can't use an authenticated proxy" [High,Triaged] https://launchpad.net/bugs/1021098 | 12:27 |
| alecu | rye: authenticated proxies are not working right in the PyQt version used in our latest windows release. | 12:29 |
| alecu | rye: if the user tries to use an authenticated proxy and proxy credentials are missing or wrong, then our dialog to enter credentials should pop up. | 12:30 |
| alecu | rye: it currently does not, but our next release should. | 12:31 |
| rye | alecu: is there any way to find that out from the logs | 12:33 |
| rye | ? | 12:33 |
| * alecu looks | 12:34 | |
| alecu | rye: "how can i notice that the proxy needs authentication" -> when trying to log into the u1 account, the control panel will request the proxy credentials with a popup. In 3.0.2 on windows, due to the PyQt bug, both good or bad credentials throw our program into a loop, and it never connects. | 13:17 |
| alecu | rye: in the log in C:\Users\%USER%\AppData\Local\xdg\cache\sso\sso-client.log a line similar to this shows up: | 13:19 |
| alecu | 2012-07-31 09:49:51,118:118.999958038 - ubuntu_sso.utils.webclient.qtnetwork - INFO - auth_required None, PyQt4.QtCore.QString(u'192.168.1.10') | 13:19 |
| * mandel back from lunch | 13:30 | |
| mandel | alecu, can i have a review for https://code.launchpad.net/~mandel/ubuntuone-client/correct-namespace/+merge/116264 | 13:38 |
| mmcc | hi folks | 13:42 |
| ralsina | Looks like I forgot to say hi. Hi! | 13:51 |
| diogobaeder | Hi! :-) | 13:54 |
| mandel | hello o/ | 13:56 |
| ralsina | mandel: I may be near your town in november | 13:56 |
| mandel | ralsina, how come? | 13:56 |
| ralsina | as in "same continent" at least. So let's have a beer ;-) | 13:56 |
| mandel | ralsina, hahaha eu is small but not that small | 13:57 |
| ralsina | mandel: I am fulfilling my mom's lifelong dream of going to Paris. | 13:57 |
| mandel | ralsina, if you take here to eurodisnay you might fulfill tatos too hehe | 13:57 |
| ralsina | mandel: we are taking tato there too ;-) | 13:58 |
| ralsina | mandel: but he has bee to real disney, so gabacho disney may be a disappointment ;-) | 13:58 |
| mandel | ralsina, hahahaha | 13:58 |
| mmcc | ralsina: which disney is real disney? | 14:04 |
| ralsina | mmcc: well, I would say disneyland, but disneyworld qualifies because walt was there :-) | 14:04 |
| mmcc | heh. Yeah, I think disneyworld counts too | 14:06 |
| mmcc | lots of Californians disagree :) | 14:06 |
| ralsina | mmcc: heh, interesting... "our smaller, older and more boring disney park is more *authentic*" does sound californian :-) | 14:09 |
| * dobey prefers to just stay away from the disneyverse | 14:11 | |
| ralsina | dobey: it's more aimed at us breeders and our litters. | 14:12 |
| ralsina | I wouldn't go there by myself. Unless they opened a Phineas & Ferb ride. Then I would totally go there. | 14:12 |
| dobey | isn't that not disney? | 14:13 |
| ralsina | dobey: It's Disney. | 14:13 |
| ralsina | Like Pixar, Marvel, and everything else ;-) | 14:14 |
| mmcc | I'd go to Club 33 without the kid… | 14:14 |
| ralsina | mmcc: couldn't go to the grownup parts because, well, the kid. :-) | 14:15 |
| dobey | pixar didn't used to be disney | 14:17 |
| === mmcc_ is now known as mmcc | ||
| joshuahoover | ralsina: any ideas what might cause this error on precise? CredentialsError DBusException(dbus.String(u'Process /usr/lib/ubuntu-sso-client/ubuntu-sso-login exited with status 1'),) | 14:34 |
| dobey | joshuahoover: have to look at sso logs | 14:36 |
| ralsina | joshuahoover: logs | 14:36 |
| joshuahoover | dobey: ok | 14:36 |
| === mmcc_ is now known as mmcc | ||
| briancurtin | me | 15:01 |
| alecu | me | 15:02 |
| dobey | meh | 15:03 |
| mmcc | me | 15:03 |
| mandel | me | 15:06 |
| alecu | ralsina, thisfred, standup! | 15:06 |
| thisfred | me | 15:06 |
| ralsina | me (nonotes) | 15:07 |
| briancurtin | shall i? | 15:07 |
| ralsina | so thisfred is last, go briancurtin | 15:07 |
| briancurtin | DONE: wrapped up and submitted py3-unicode-part-2 | 15:08 |
| briancurtin | TODO: fix test failures in py3-unicode-part-3, continue it | 15:08 |
| briancurtin | HELP: if anyone has time, i could use a second review on https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/py3-unicode/+merge/112856 -- it's 470 lines, not very complicated, just needs a good look | 15:08 |
| briancurtin | NEXT: alecu | 15:08 |
| alecu | DONE: started with a branch series to make u1client run with python2 -3 | 15:08 |
| alecu | TODO: more py3k, do reviews for mandel | 15:08 |
| alecu | BLOCKED: no | 15:08 |
| alecu | NEXT: dobey | 15:08 |
| dobey | DONE: releases | 15:09 |
| dobey | TODO: finish releases/uploads, fix review issues in refactor branch, reorg to drop ubuntuone-installer for good, SRUs for lucid/natty/oneiric | 15:09 |
| dobey | BLCK: None. | 15:09 |
| dobey | mmcc: go | 15:09 |
| ralsina | @ping | 15:11 |
| mandel | ralsina, yes, you are here.. | 15:11 |
| briancurtin | mmcc: you there? | 15:11 |
| ralsina | thanks mandelbot! | 15:11 |
| mandel | ralsina, there is no @ping here AFAIK :P | 15:12 |
| ralsina | mandel: ha, ok | 15:12 |
| briancurtin | mandel is next since mmcc is gone | 15:12 |
| mandel | DONE: More refactoring for code reuse for the jenkins test daemon. Fixed a nmber of MPs | 15:12 |
| mandel | TODO: more work on the jenkins daemon. | 15:12 |
| mandel | BLOCKED: no | 15:12 |
| mandel | thisfred, please | 15:12 |
| thisfred | DONE: u1db example app, Bug #1030947 TODO: Bug #1030947, u1db example app, release 0.0.5 BLOCKED: no NEXT: ralsina | 15:12 |
| ubot5 | Launchpad bug 1030947 in U1DB "documents should not be stored multiple times with the same value under the same index key" [High,In progress] https://launchpad.net/bugs/1030947 | 15:12 |
| ralsina | DONE: drafted contractor contract, couple of reviews, got disconnected most of the afternoon, minor things. TODO: debug quantal bugs, objectives, other stuff BLOCKED: no NEXT noone | 15:12 |
| mmcc | i'm here now, sorrry | 15:13 |
| mmcc | DONE: test for reactor regressions, darwin dirspec, wrote mac cert_location | 15:13 |
| mmcc | TODO: review day, test mac cert_location, first-run code | 15:13 |
| mmcc | BLCK: none | 15:13 |
| ralsina | so, NEXT mmcc | 15:13 |
| ralsina | ok, comments? | 15:14 |
| mmcc | briancurtin: I'll look at that py3-unicode branch | 15:14 |
| briancurtin | mmcc: cool, thanks! | 15:15 |
| dobey | ok, need to get lunch | 15:19 |
| dobey | bbiab | 15:20 |
| === salgado is now known as salgado-lunch | ||
| ralsina | ♫♪♬♩ Oh what a fun, it is to write, a ten page legal docume-ent! ♫♪♬♩ | 16:00 |
| mmcc | ralsina: if you'd like a break, can you tell me if PyQt on python3 will return unicode when I access the value of a QLineEdit widget? | 16:08 |
| ralsina | mmcc: it will return either a QString (which you can unicode() safely) or a unicode object, depending on the API level | 16:09 |
| mmcc | not sure if I'm asking that exactly right, but I'm looking at a test for the email verification page that checks essentially isinstance(self.ui.verification_code, str) , which might not be right for py3…? | 16:09 |
| mmcc | so on py3 will it return a str? | 16:10 |
| ralsina | that looks wrong | 16:10 |
| ralsina | currently the UI returns a QString, and we are converting it to "something", but I don't remember *what*. | 16:11 |
| ralsina | you would have to find where we are setting verification_code | 16:11 |
| mmcc | the code is in ubuntu_sso/qt/tests/test_email_verification.py:55 | 16:11 |
| mmcc | in this test, it's being set on line 52 with self.ui.ui.verification_code_edit.setText('asd123') | 16:12 |
| ralsina | mmcc: hmmm let me look | 16:12 |
| ralsina | mmcc: because that doesn't set what you are reading :) | 16:12 |
| mmcc | hrm | 16:13 |
| ralsina | I mean, it surely sets it as a side effect | 16:13 |
| ralsina | but there is probably some type casting in the middle | 16:13 |
| === beuno is now known as beuno-lunch | ||
| === beuno-lunch is now known as beuno | ||
| mmcc | yeah, looks like it's getting set as str(self.ui.verification_code_edit.text()) in ubuntu_sso/qt/email_verification_page.py | 16:16 |
| ralsina | yep | 16:16 |
| ralsina | so that's a str. good thing our verification codes have no weird characters. | 16:16 |
| ralsina | brb | 16:17 |
| ralsina | back | 16:22 |
| ralsina | mmcc: so, in short, that looks more correct in the py3 world than in the py2 world, where it mainly works by accident. | 16:22 |
| mmcc | yeah, that's what I was thinking | 16:25 |
| mmcc | so I'll leave that one alone | 16:25 |
| ralsina | maybe a note saying "this can be safely converted to string because verification codes are ASCII" | 16:26 |
| mandel | ok, EOD in spain, catch you all tom | 16:26 |
| ralsina | "in python 2" | 16:26 |
| mandel | please take a look at my MPs :) | 16:26 |
| ralsina | gack, forget it, that note is awful | 16:26 |
| ralsina | bye mandel! | 16:26 |
| mmcc | bye mandel, I've got your merges on my list | 16:34 |
| mmcc | oh, I'm looking at stuff briancurtin hasn't gotten to yet, whoops | 16:37 |
| briancurtin | mmcc: yeah that branch you are looking at is 1/3, so if you stray from what's in the py3-unicode branch, it might be covered in part-2 (which is available) or part-3 (still working) | 16:38 |
| mmcc | briancurtin: are you converting tests in a later branch? | 16:38 |
| briancurtin | mmcc: some tests are covered in part-2 | 16:39 |
| mmcc | briancurtin: ok, thanks | 16:39 |
| briancurtin | mmcc: i tried to break them up by size so they're manageable to review, and they're somewhat grouped by package | 16:40 |
| briancurtin | mmcc: it may make it a bit hard to do because of that, but i didnt want to have one huge 5000 line change to cover it all | 16:40 |
| mmcc | briancurtin: ok, I'll check the other branches before complaining about anything :) | 16:43 |
| mmcc | briancurtin: +1 on part 1 | 16:48 |
| briancurtin | mmcc: awesome, thanks | 16:48 |
| dobey | hmm | 16:49 |
| mmcc | alecu, when testing the unicode branch, did you get stuck on displaying the captcha? | 17:19 |
| alecu | mmcc: yes. And it seems to get stuck while running trunk too, so it's not because of this branch. | 17:21 |
| alecu | mmcc: yestarday I thought it might be my setup, or something on the servers, but it seems to be something on trunk we should fix. | 17:22 |
| mmcc | yes, it's the StringIO vs. BytesIO bug. | 17:22 |
| mmcc | I found it a couple of weeks ago and I thought we fixed it. I guess we just talked about it | 17:22 |
| mmcc | should we fix it in this branch, since it is an encoding issue related to earlier py3 changes? | 17:22 |
| mmcc | well, a string type issue | 17:22 |
| dobey | i'd say fix it in a separate, smaller branch | 17:23 |
| alecu | +1 | 17:24 |
| mmcc | ok | 17:24 |
| mmcc | ok then briancurtin2, +1 on part 2 | 17:25 |
| dobey | https://code.launchpad.net/~dobey/ubuntuone-client/update-4-0/+merge/117497 needs a review or two | 17:26 |
| briancurtin2 | mmcc: excellent, thank you very much! | 17:28 |
| === salgado-lunch is now known as salgado | ||
| * briancurtin2 lunch+taking GF to doctor | 17:34 | |
| mmcc | here's the merge for the smaller branch fixing the captcha hang with stringio: https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1031437-PIL-exception/+merge/117504 | 17:57 |
| alecu | mmcc: great, I'll review it. | 18:12 |
| mmcc | thanks alecu | 18:14 |
| * mmcc lunches | 18:14 | |
| dobey | thisfred: care to review https://code.launchpad.net/~dobey/ubuntuone-client/update-4-0/+merge/117497 ? | 18:19 |
| joshuahoover | ralsina: will bug #1021098 be getting fixed in our next win update? | 18:25 |
| ubot5 | Launchpad bug 1021098 in Ubuntu One Windows Installer "Installer 3.0.2 can't use an authenticated proxy" [High,Triaged] https://launchpad.net/bugs/1021098 | 18:25 |
| alecu | joshuahoover: yes. It gets fixed by replacing the pyqt version, so it should be fixed on our next windows update. | 18:36 |
| joshuahoover | alecu: very good, thanks! | 18:36 |
| * alecu makes a note to IRL check that this bug is fixed on the next installer. | 18:37 | |
| alecu | and I should also ping briancurtin2 about replacing pyqt too. | 18:37 |
| ralsina | alecu: it should be fixed in the jenkins-generated bundles | 19:32 |
| ralsina | alecu: or else, we need to update Qt there too | 19:32 |
| dobey | gotta run a few errands. bbiab | 19:40 |
| briancurtin2 | back... | 19:44 |
| alecu | ralsina: it seems that the version built by jenkins uses the old pyqt. | 20:22 |
| alecu | ralsina: also, it opens the console window, meaning that it's lacking the twisted fix for http://twistedmatrix.com/trac/ticket/5726 | 20:24 |
| briancurtin2 | alecu: i haven't changed what pyqt is on the jenkins machine | 20:24 |
| briancurtin2 | alecu: i can add that twisted patch, but it will still have the console windows for other things because it will have SHOW_CMD=True in the conf.py. we only set that to False when releasing | 20:25 |
| briancurtin2 | alecu: is there a good PyQt version we can upgrade to? | 20:25 |
| alecu | briancurtin2: I think we should be using pyqt 4.9 (that includes Qt 4.8) | 20:26 |
| alecu | briancurtin2: jenkins is using pyqt 4.8 (that includes Qt 4.7) on the windows builds | 20:26 |
| briancurtin2 | which is what i have on my machine and what we are releasing from | 20:27 |
| dobey | back | 20:27 |
| briancurtin2 | alecu: we're releasing with PyQt 4.8.4/Qt 4.7.2. if PyQt 4.9.4 contains good fixes i can upgrade everything to it | 20:28 |
| alecu | briancurtin2: I verified that pyqt 4.9.something fixed the issue with proxy credentials. But I also recall that 4.9.something had issues showing the errors in ssl verification failures, and since we were hitting a lot of those, that's why we moved back to pyqt 4.8. | 20:30 |
| ralsina | alecu: yes, but we fixed those by including the certificate, right? | 20:30 |
| alecu | ralsina: right | 20:31 |
| alecu | ralsina: I mean, we fixed the ssl verification failures. I don't know if "showing the errors from ssl failures" is fixed in pyqt > 4.9.0 | 20:31 |
| alecu | mmcc: is there a way to add a unit test that shows the bug in this branch? https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1031437-PIL-exception/+merge/117504 | 20:39 |
| mmcc | alecu, yes I'm working on that now | 20:39 |
| mmcc | I can at least write a test that will show the exception we're seeing. Looking to see if there's a way to test more | 20:40 |
| mmcc | I'd also like to just remove that PIL stuff and use Qt's PNG plugin, since that should work on OSX, but I'm not sure how to make it work on windows, where the original issue was. I suspect it's the same problem though | 20:43 |
| dobey | grr. | 20:53 |
| dobey | tar: ubuntuone-client-3.99.2/ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_daemon.py: file name is too long (max 99); not dumped | 20:53 |
| dobey | tar: ubuntuone-client-3.99.2/ubuntuone/platform/filesystem_notifications/monitor/darwin/fsevents_client.py: file name is too long (max 99); not dumped | 20:53 |
| mmcc | max 99? yow | 20:56 |
| dobey | filesystem_notifications is an insane name for a python module anyway. requires way too much typing for Python | 20:57 |
| dobey | i'm surprised the branch that created those files, landed, though | 20:58 |
| mmcc | dobey: it just squeaked by the lint line length limit: "from ubuntuone.platform.filesystem_notifications.pyinotify_agnostic import (" | 21:07 |
| mmcc | aside from lint & style issues though, why are you surprised? is there other stuff like tar we need to worry about? | 21:09 |
| mmcc | alecu: I've added a test to https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1031437-PIL-exception/+merge/117504 that'll catch the regression, and should also be useful if we end up removing PIL, since it only tests the resulting QPixmap. | 21:19 |
| dobey | mmcc: i'm surprised it landed because we do make dist, and tar should have complained | 21:20 |
| mmcc | dobey: ah. | 21:20 |
| dobey | GLib (gthread-posix.c): Unexpected error from C library during 'malloc': Cannot allocate memory. Aborting. | 21:21 |
| dobey | but am also seeing this for some reason, and tests are getting aborted :( | 21:21 |
| dobey | sigh | 21:32 |
| dobey | alright all, gotta go. have a good night | 21:51 |
| briancurtin2 | see ya dobey | 21:51 |
| mmcc | bye, dobey | 21:54 |
| briancurtin2 | i'm out. time to go watch the cubs get beat by the pirates. | 22:39 |
| mmcc | OK, I'm done now too. bye | 23:00 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!