/srv/irclogs.ubuntu.com/2012/08/01/#ubuntuone.txt

diogobaederAnyone there could give me a hand with a branch for ~ubuntuone-hackers ?00:44
ralsinadiogobaeder: sure00:51
ralsinadiogobaeder: what do you need?00:51
diogobaederralsina, I created this branch to act as a sourcedep: https://code.launchpad.net/~diogobaeder/ubuntuone-servers/coverage00:52
diogobaederralsina, not sure if this is what I need to do, but I want to include it as a Python module for ubuntuone-servers, in one of my branches ( https://code.launchpad.net/~diogobaeder/ubuntuone-servers/coverage-optimization )00:53
diogobaederralsina, am I doing this right, so far?00:53
ralsinadiogobaeder: I'm afraid I am not very familiar with that code00:53
ralsinadiogobaeder: sorry :-(00:53
diogobaederralsina, it's just the "coverage.py" module (can be found at the cheeseshop)00:54
ralsinalooking anyway, just in case :-)00:54
diogobaederhttp://pypi.python.org/pypi/coverage00:54
diogobaederI want it to be included as a dependency in the second branch I wrote here, so that I can use this external module00:54
ralsinaok00:54
ralsinalet me check the second branch...00:55
diogobaederok00:56
ralsinais there a missing commit in the coverage-optimization branch? I don't see where you added the sourcedep00:56
diogobaederralsina, I didn't add it yet. How should I do it?00:56
ralsinadiogobaeder: and that's where my ignorance means I can't help you :-/00:56
diogobaederralsina, I mean, shouldn't I push the "coverage" branch to be available from ~ubuntuone-hackers first?00:57
ralsinayes00:57
ralsinadiogobaeder: also, server code needs to be discussed on u1-internal so let's switch ;)00:58
diogobaederralsina, ok00:58
psychok7hi there01:46
psychok7i am having trouble sync a bunch of large files to a ubuntu one shared folder01:47
psychok7i click on the disconnect and connect button and it says its synced but its not01:48
shuerhaakenhello all. I started rhythmbox with ubuntuone music store plugin from the terminal. I get the following output: http://pastebin.com/C03pL9ym ; Is there an issue with ubuntuone-client?07:56
shuerhaakenThis is on precise07:57
=== muffinresearch_ is now known as muffinresearch
mandelmorning all!08:08
shuerhaakenmorning!08:15
shuerhaakenI started rhythmbox with ubuntuone music store plugin from the terminal. I get the following output: http://pastebin.com/C03pL9ym ; Is there an issue with ubuntuone-client?08:15
JamesTaitGood morning all! :)08:16
mandelpsychok7, hm.. weird10:58
gatoxgood morning!! :D11:03
=== yofel_ is now known as yofel
alecugood morning to everyone!11:56
gatoxalecu, hi!11:58
shuerhaakenin this channel nobody says anything but good morning.11:58
alecuprobably because everybody was sleeping...12:05
gatoxalecu, he left12:06
alecumandel: you've seen this branch that tarmac is bouncing, right? https://code.launchpad.net/~mandel/ubuntuone-client/correct-namespace/+merge/11626412:06
alecumandel: any ideas?12:06
mandelalecu, let me look12:07
gatoxmandel, hi12:07
mandelshuerhaaken: clearly depends on the time zone you are, maybe most people in this channel are in a +5 UTC and you have been asking questions when no-one was here ;)12:07
mandelgatox, hello hello12:07
mandelalecu, yes, I have seen that before in a previous branch, retrying the merge work, what worries me is a possible change in Q regarding the reader.. because tarmac is in Q, right?12:08
alecumandel: probably not. But we should ask dobey.12:09
mandelalecu, also, that is happening  because I fixed the tests and ask the monitor to shutdown in a cleanup call.. so the problem might have been there all along but we have just started noticing12:10
gatoxalecu, i fixed the merge problems in the tests-refactoring branch, i'm running the tests now in all the platforms to see if everything is ok12:10
mandelalecu, we can either ignore that on linux (ugly) or try to reproduce it, in my P machine it does not happen at all12:10
alecumandel: do you have a Q vm? I need to install one.12:11
alecugatox: great!12:11
mandelalecu, I have to set up one too.. I'll set up one after lunch and will test, lets try to set it to merge again and see if it works12:12
mandellast time it did12:12
mandelalecu, by the way, I updated the to MP which you reviewed, UNIX_PATH_MAX is not defined on Mac OS X AFAIK12:13
ralsinamorning!12:16
gatoxralsina, hi!12:16
ralsinawelcome back gatox!12:17
gatoxralsina, thx! :D12:17
mandelralsina, morning ralsina!12:19
ralsinagood morning mandel12:22
mandelwell, I'm off to have lunch I'm starving and writing all that objective-c takes all my energy away.. god that bloody lang is verbose!12:26
* mandel lunch12:27
mandelalecu, FYI the branch that was bouncing just got merged: https://code.launchpad.net/~mandel/ubuntuone-client/correct-namespace/+merge/11626412:27
mandelalecu, looks like our cleanups have a bug somewhere that might be async and might not be that easy to reproduce :(12:28
alecumandel: :-/12:30
mandelalecu, yes.. that is the more children safe expression you can use12:30
mandelok, really going now, stomach is making funny noises12:31
alecumandel: buen provecho!12:31
dobeyhrmm13:02
dobeyalecu, mandel: q has twisted 12.0.0, so maybe there is a racing regression in it, or maybe the patch to add the gireactor got refreshed wrong13:04
alecudobey: is tarmac running on Q?13:05
dobeytrunk and stable-4-0 branches do, yes; though separate instances of q. trunk will always land on the development version of ubuntu13:06
alecudobey: great, thanks.13:07
ralsinaOh, quantal VM, why do you hate me so.13:16
* ralsina presses the virtual reboot button13:16
lamalexU1 got rid of notes????13:25
dobeyonly the web ui13:25
dobeyyou can still sync tomboy if that's what you are wondering13:25
lamalexno not really i really only used the web ui, but i guess i need to install tomboy13:27
* mandel back13:39
dobeybrb13:39
ralsinayay, I know what's wrong with our folders and devices list on Q!13:44
ralsinaNo idea how to *fix* it but I know what's wrong13:44
ralsinathey are constantly getting resized to 100x30 for some reason13:44
ralsinaAnd the items inside them probably have a similar problem13:46
alecuralsina: likely the gtk theme renderer for qt. Or the scrollbar thingie.13:47
alecuralsina: what if you switch qt to a standard theme?13:47
ralsinaalecu: trying13:47
alecu(by scrollbar thingie I mean the custom unity scrollbars)13:48
ralsinaalecu: works great with -style windows13:48
alecuralsina: there you go. Let's ship with that syle!13:48
alecu*style!13:48
alecuralsina: can you try with "-style Metro"?13:49
ralsinaalecu: there isn't one AFAIK :-)13:49
alecuralsina: guessed so. And there's no much love right now in the Qt trenches for Melop... I mean Metro.13:52
ralsinayeah13:52
ralsinaso, I have to find a way to have the items not resized to 0x0 and we should be ok-ish13:53
alecuralsina: shouldn't we be asking the qt on gtk guys to fix this?13:53
ralsinaalecu: yes13:53
ralsinaalecu: but I need to ask with a description of the problem13:54
ralsinaalecu: also, we are doing strange things in those lists13:54
alecuoh, I see.13:54
ralsinaalecu: we have custom delegates, which is unusual13:54
ralsinabummer, the items have the right sizes, they are just not drawn, totally a style bug14:06
alecuralsina: awesome?14:07
mmcchi people14:07
ralsinaalecu: well... it depends. Means we depend on others fixing it :-/14:08
alecuhi mmcc!14:08
ralsinahi mmxx14:08
mandelalecu, ralsina, FYI I have the jenkins testing daemon working and copying the events to named pipes, what is left is to adapt the real daemon to take a new arg stating that  we are testing and which named pipe to use + a python test case14:08
ralsinammcc I meant14:08
gatoxmmcc, hi14:08
ralsinamandel: cool14:08
alecumandel: that's great!14:09
alecumandel, mmcc, ralsina: perhaps we should do a mumble to talk about the status of the macport and to discuss pending things.14:09
mandelalecu, +100 specially because I need to talk with mmcc on how to deploy the daemon14:10
alecumandel, ralsina, mmcc: shall we do it after today's standup?14:10
ralsinaalecu: yes14:11
ralsinaand the bug is in overlay-scrollbar-gtk214:11
mandelok14:11
ralsinaremoving that makes everything work14:11
ralsinadobey: is there a way to disable a gtk module for a single app?14:13
dobeyGLib (gthread-posix.c): Unexpected error from C library during 'malloc': Cannot allocate memory.  Aborting.14:13
dobeyagain14:13
dobeyralsina: run it with empty GTK_MODULES env var?14:14
dobeyralsina: there's no good way to disable a single module though14:14
mmccmandel, alecu, mumble after standup sounds fine.14:14
dobeyyou'd have to parse the variable to strip the one you want to remove14:15
ralsinadobey: yep that works14:15
ralsinadobey: thanks14:16
dobeywhy the heck is this memory error happening on quantal14:16
ralsinadobey: I am getting tons of weird crashes on q today14:16
ralsinadobey: since overlay-scrollbar is the only gtk module enabled on Q by default, would it be awful if we cleaned that when launching u1cp?14:17
alecummcc: while running tests for your branch I get this: http://pastebin.ubuntu.com/1123448/14:17
alecummcc: any ideas?14:17
mmccalecu: looking14:17
dobeyralsina: we should get cimi to fix it i guess14:18
ralsinadobey: yes, I am asking him14:18
dobeyor whoever is working on that14:18
ralsinadobey: I just like having plan B in mind ;-)14:18
dobeyi think plan B should be have them make the overlay scrollbar not get used in qt apps, because i doubt our app is the only one it breaks14:19
* alecu just read "Plan 8", and thought we were doing a port to a previous version of Plan914:19
dobeyalso, why the heck does tar complain about file name length in one instance of quantal, but not the other14:20
ralsinadobey: could be locale? One UTF8 one not?14:20
dobeyboth are utf-814:20
dobeyboth are en_US.UTF-8 even14:21
ralsinadobey: then no14:21
gatoxalecu, the conflicts has been resolved, and the tests has been updated using the new package structure for the imports, all the tests passing in all the platforms: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/11328914:26
alecugatox: great. I'm branching it14:27
mmccalecu - you need lp:testtools in your PYTHONPATH.14:27
gatoxalecu, thx14:27
mmccalecu, you need testools in your PYTHONPATH to run dirspec's tests14:27
alecummcc: thanks!14:27
ralsinaoh great, playing with the overlay scrollbars broke my quantal :-(14:36
dobey?14:36
ralsinaand by "playing" I mean 'uninstalling and reinstalling' and now my session crashes14:36
dobeygrr14:38
dobeythis makes absolutely no sense at all14:39
gatoxdobey, welcome to my world :P14:39
* dobey puts that song on14:40
dobeyi set ulimit for RSS to 384M but process used more than that when I ran it14:41
dobeyand it's getting killed due to ulimit, when run in tarmac14:41
dobeybut for some reason, trunk is landing fine14:41
dobeyand it's also on quantal14:42
dobeyalso, trunk lander is not complaining about the file name lengths in tar during the make dist14:42
dobeyso wtf.14:42
ralsinadobey: versions/implementations of tar?14:43
dobeyralsina: they would different between quantal and quantal?14:43
ralsinadobey: yes, there are like 4 tars in the repos :-)14:43
dobeyeh?14:43
ralsinadobey: or maybe a missing update got them out of sync14:43
dobeythere is only 1 tar14:43
ralsinadobey: gtar, star are the first two that come to mind14:44
ralsinathen there is bsd tar but surely we are not using that ;-)14:44
dobeythere is only 1 tar though, and they are the same version on both14:44
dobeyand we don't depend on gtar or star so they wouldn't be installed (and they aren't)14:44
ralsinadobey: then the answer is midichlorians.14:45
dobeyactually there is no gtar in the archives14:45
ralsinadobey: on ubuntu tar is gtar14:45
dobeynor is star in the archives14:46
dobey:)14:46
dobeystarfighter and starplot are though14:46
ralsinadobey: use cpio, it's more standard!14:46
ralsinadobey: http://cdrecord.berlios.de/private/star.html14:46
dobeywe'll us rar14:46
dobeyyeah i know what star is14:47
dobeythere's also "guitar"14:47
* ralsina starts project patbena-tar14:47
alecuthat's one of the best names ever14:47
briancurtinhahah14:47
alecuI mean "gui-tar".14:47
dobeybut the tar issue isn't what's blocking the landing14:48
dobeyit's the OOM issue that is14:48
alecupatbena-tar is good too ;-)14:48
ralsinadobey: could it be it's OOMing globally (the instance) and not via ulimit?14:48
dobeyi'm pretty sure it's due to ulimit14:49
dobeyi just ran the tests in the instance a few times, all successful14:49
dobeyeven when i set ulimit for myself to the same as for tarmac14:50
dobeywhich is weird; it should have OOMed :(14:50
alecumandel: why did you land this?14:51
alecumandel: https://code.launchpad.net/~mandel/ubuntuone-client/correct-namespace/+merge/11626414:51
alecumandel: oh, crap, it's the branch from this morning.14:52
alecumandel: it should not have landed, because it depends on this other branch: https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/correct-namespace/+merge/11626314:52
alecuhmmm....14:53
dobeyshould be fine, except osx is broken until the fsevents on lands i guess?14:53
alecudobey: right.14:53
alecudobey: but doing darwin reviews is even harder now.14:53
alecus/harder/more annoying/14:54
alecuannoyingerester14:54
dobeywell, you already +1ed the fsevents branch it looks like. maybe ralsina or someone can review it quick?14:55
ralsinalooking...14:55
ralsinamandel: why are MPs private when trunk is public? Makes no sense! :-)14:56
dobeyit's not14:56
ralsinaoh, not in that project14:56
ralsinaack14:56
ralsinawill +1 as soon as I run tests14:57
dobeywe should get someone to make them public by default i guess14:57
gatoxme15:00
ralsiname15:00
mmccme15:01
briancurtinme15:01
dobeymeh15:01
alecume15:01
dobeythisfred: ?15:02
thisfredme15:02
dobeygatox: go15:02
gatoxDONE:15:02
gatoxVacation and relax :D. Update tests-refactoring branch fixing some conflicts with another branches that landed. System Tray menu almost completely functional, investigating a little bit about progress bar in the menu that cause conflicts with some ubuntu menus.15:02
gatoxTODO:15:02
gatoxAdd tests to the u1-cp and u1-client menu branches and propose them.15:02
gatoxBLOCKED:15:02
gatoxNo15:02
gatoxralsina, go15:02
ralsinaDONE: confirmed root cause of quantal issues, talking with cimi about it, drafted and negotiating twisted contract,  booooring stuff. TODO:  get an exception in scrollbar-overlay for u1cp (or something else) fix some buglet, finish negotiation NEXT: mmcc15:02
mmccDONE: py3-unicode reviews, fixed PIL bug, py2app on 10.7 works now15:02
mmccTODO: reviews for mandel, test mac certs in package, first-run code15:02
mmccBLCK: none15:02
mmccNEXT: briancurtin15:02
briancurtinDONE: walking back through py3-unicode-part-3 now that 1&2 are merged15:02
briancurtinTODO: debug a test failure in this part-3 before i propose it15:02
briancurtinNEXT: dobey15:02
dobeyDONE: releases/uploads15:03
dobeyTODO: client release/upload, fix review issues in refactor branch, reorg to drop ubuntuone-installer for good, SRUs for lucid/natty/oneiric15:03
dobeyBLCK: OOM landing update-4-0 branch for client. :-/15:03
dobeyalecu: go15:03
alecuDONE: pushed forward the review queue. We need more hands there! Started a 3k cleanup branch for storage protocol15:03
alecuTODO: more reviews, work on a bug list of py3k for u1c and u1sp, mumble re mac port15:03
alecuBLOCKED: no15:03
alecuNEXT: thisfred15:03
thisfredDONE: u1db example app, Bug #1030947 TODO: example app | package 0.0.5 | documentation BLOCKED: no NEXT: no15:03
ubot5Launchpad bug 1030947 in U1DB "documents should not be stored multiple times with the same value under the same index key" [High,In progress] https://launchpad.net/bugs/103094715:03
gatoxTODO: 1-1 with ralsina.... 14:30 is ok?15:04
ralsinagatox: sure15:06
mandelso, I got disconnected, sorry15:08
mandelmy turn?15:09
mandelDONE: More work on the jenkins daemon. Got the daemon running an copying the events to a set of namedpipes.15:09
mandelTODO: mumble with ralsina, alecu and mmcc. Adapt real daemon to read from namedpipes in test mode. Canonical admin to get a few days off.15:09
mandelBLOCKED: no15:09
mandelralsina, I think we can make the project public to be honest15:09
mandel@ping15:10
alecumandel: @pong15:11
alecuso, before EOM: we need more eyes on the review queue.15:11
mandelalecu, thx.. I though i was still off15:11
mandelalecu, you guys saw my standup stuff?15:12
dobeyyes15:12
mandel:)15:12
dobeyalecu: today is you/ralsina, is that not enough?15:12
mandelalecu, are you in mumble already?15:12
ralsinadobey: I have been doing other stuff and neglecting reviews15:12
ralsinadobey: so I need some backup15:13
alecudobey: there are a lot of darwin branches by mandel still, and it's not trivial to get everything up to speed to review them.15:13
dobeyalecu: maybe gatox and mmcc can help out with those then?15:13
alecudobey: right.15:14
mmccI'll be doing some darwin reviews, today, yeah15:14
ralsinamandel: +1 on ubuntuone-fsevents-daemon/correct-namespace15:14
mandelralsina, awesome15:14
gatoxalecu, yes..... should i just start reviewing mandel's branches or do you have sometihng specific in mind?15:14
alecumandel: btw: a few of those branches have a needs fixing, so before you move forward with other branches, please fix them and annoy people to have the current ones land.15:14
mandelalecu, they are all fixed from my morning work AFAIK15:15
mandelalecu, unless there are new comments15:15
mmccno, you just need to annoy me to look at them again15:15
alecumandel: ok15:15
mandelmmcc, feel annoyed :-)15:16
mmccmandel: done!15:16
* mmcc is downloading mumble15:16
mmccI'm on 3g today, so cross your fingers about mumble quality15:17
gatoxmandel, can you please tell me which branches do you need review? i see a lot..... or should i pick randomly? :P15:18
dobeyok, need to get lunch. bbiab; am starving15:18
mmcctomorrow afternoon: fiber to the home :)15:18
mandelgatox, pick randomly :)15:18
gatoxmandel, ack15:18
alecummcc: let us know if you prefer a hangout15:19
alecuralsina: can you join us on the mumble?15:20
ralsinaalecu: going15:20
mmccalecu: let's try mumble and I'll let you know :)15:20
alecugatox: I've some ideas regarding the progressbars on menues. Perhaps we can discuss about them after the osx mumble?15:21
gatoxalecu, ok...... i've been looking at that.... and now i realize what is going on..... so i can tell you that too15:22
mmcclogging in to mumble, sorry this is taking so long15:22
gatoxalecu, the mumble about the menu is going to be soon? or i can go to have lunch?15:27
=== JanC_ is now known as JanC
mandelalecu, ralsina bug #103181515:28
ubot5Launchpad bug 1031815 in Ubuntu One Client "Intermitent tests failing on tarmac" [Undecided,New] https://launchpad.net/bugs/103181515:28
alecugatox: go have, lunch.15:29
gatoxalecu, ack15:29
=== gatox is now known as gatox_lunch
=== salgado is now known as salgado-lunch
mmccbrb16:11
ralsinalunchtime for me16:23
=== gatox_lunch is now known as gatox
gatoxalecu, let me know when you want to mumble16:29
alecugatox: can we do it in an hour or so? I'm about to leave for lunch.16:35
gatoxalecu, yes, no problem....... i'm reviewing mandel's branches right now16:35
mandelalecu, gatox I love you! a number of branches landed, thx!!! and also thx to mmcc who was the first!16:38
alecumandel: this is not about loving... this is about using you as a mule for board games from spain :-)16:39
gatoxjajajaja true story16:39
dobeyGRRRRRRR16:40
alecuwhen dobey grrrrs, everybody whistles away in fear....16:41
alecudobey: what happened?16:41
mandelalecu, lol16:41
dobeyalecu: the OOM in the -quantal tarmac instance. i can't figure out why it's not also happening on the -trunk instance (which is also quantal)16:42
dobeyrunning tests for both my branch, and trunk, in the -quantal instance, and u1trial goes up to about 428M RSS. which is well over the 384M RSS max set with u1limit :-/16:43
alecudobey: do both VMs have the same amount of memory and swap?16:43
dobeyappear to yes16:43
dobeyboth have 0 swap and 2G total mem shown in 'top'16:43
dobeyof course doesn't tell me why it's using so much RSS to run the tests now either16:44
=== salgado-lunch is now known as salgado
mandelwell, EOD here, catch you all tom!16:58
gatoxmandel, bye!16:58
mmccbye mandel16:58
dobeyhmm17:04
dobeymaybe i should just land this by hand for now17:08
dobeytoo bad i can't tweak the summary output for the test runner easily17:12
gatoxralsina, 1-1 in 5min? irc or mumble?17:26
dobeynot a hangout?17:26
dobeydisappoint17:26
briancurtinargh, i still need to figure out that reocurring hangout meeting invite thing17:27
gatoxok, alecu and ralsina let me know when you have some time to mumble (i need a mumble with each of you :P)17:31
* gatox goes back to the menu17:31
ralsinagatox: is now good?17:40
gatoxralsina, yap...... irc or mumble?17:41
ralsinagatox: mumbles17:41
dobeyralsina: should i just merge my update-4-0 branch into stable-4-0 by hand? the constant OOM from tarmac is getting annoying, especially since i can't seem to isolate why it's not happening in the other instance, or why u1client is using so much RSS to run the tests now18:04
ralsinadobey: YES18:05
ralsinaoops, sorry for shouting18:05
ralsinadobey: maybe we can reset that instance later?18:05
dobeyit was recently, afaik18:05
ralsinadobey: after you merge, I mean18:05
dobeyi don't think the instance is the problem18:05
ralsinadobey: maybe even redeploy it18:05
ralsinadobey: there comes a time when fiddling to fix is just not worth it if deployment is automatic18:06
dobeyit's clear why the OOM is happening. just not clear why the mem usage shot up in the tests, or why it's not happening on trunk18:06
ralsinadobey: yes, but we are having two apparently disconnected strange symptoms only on that instance (OOM and tar)18:06
ralsinadobey: Gregory House would raise an eyebrow18:07
ralsinadobey: and pop a pill or two18:07
dobeywell, the tar thing is odd, but not fatal18:07
dobeyand easy enough to fix18:07
ralsinadobey: ok, so yes to merging manually, trust you on what to do next, ping me if you don't :-)18:08
mmccralsina: are you doing reviews today? this one is short: https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1031437-PIL-exception/+merge/11750418:11
ralsinammcc: sure18:11
ralsinadobey, alecu: up to a very simple review that needs quantal? https://code.launchpad.net/~ralsina/ubuntuone-control-panel/no-scroll-overlay/+merge/11775718:23
ralsinadobey: that's a workaround to disable the overlay. Alternative is to find out what our  g_get_prgname is by patching the gtk module and asking Cimi to add an exception in the module, which sounds like a lot more work for the same thing.18:25
alecuralsina: I don't like that we are removing this for all of nightlies on other releases other than Q18:25
ralsinaalecu: there is no overlay-scrollbar module in any other ubuntu that's not Q18:26
dobeyalecu: other versions of ubuntu don't have overlay scrollbars in qt anyway18:26
alecuack then18:26
ralsinadobey: the bugno is there in the branch and in the commit message18:27
ralsinadobey: will add the comment though18:28
dobeyralsina: right, but that's only helpful if you know which commit added it :)18:28
ralsinadobey: don't understand18:28
dobeyand figuring that out 500 commits later, can be troublesome18:28
dobeymuch easier to just see in the comment18:28
ralsinaOh, add the bugno in the comment! Gotcha18:29
alecuralsina: also: TDD :-)18:29
ralsinaalecu: there are no tests for main, because we can't have no tests for main :-(18:29
dobeyralsina: oh, yes. sorry if that wasn't clear :)18:29
alecuralsina: please move that code inside the main module, then!18:29
ralsinaalecu: ok, sounds logical. Will do.18:29
dobeyi thought about mentioning the lack of a test, but you really can't test it18:30
alecudobey: you can certainly test that whatever comes in GTK_MODULES does not break the parsing18:30
ralsinadobey: I can set GTK_MODULES and test that after calling main the overlay-scrolbar is gone from it18:30
dobeya unit test for this is basically a very expensive no-op18:30
alecudobey: and that overlay-scrollbar is actually removed if it's there...18:31
alecuand, etc, etc.18:31
ralsinawell, it's accidental-deletion prevention mostly18:31
dobeyalecu: GTK_MDOULES is not set outside of the user session; and setting it in the test with a custom list of modules, means the test will always pass unless someone makes a really stupid mistake :)18:32
alecugatox: let me know when you want to mumble18:38
gatoxalecu, we can do it now if you want18:38
dobeywell, i have a fix for the tar issue anyway18:39
alecucoming...18:39
ralsinagrmbl trial should have a "run only the last test that failed" option18:40
dobey?18:40
ralsinadobey: as you would say "sigh" ;-)18:41
dobeynot in this case. it's certainly something that could be added to dev tools, but it's not entirely clear to me at the moment how you'd expect that to work18:42
dobeyon the other hand18:42
ralsinadobey: when I am trying to ix a test, I would run that to know if the fix worked, and then run the whole suite18:42
dobeyalecu, ralsina: trivial review please: https://code.launchpad.net/~dobey/ubuntuone-client/tar-ustar/+merge/11776118:43
dobeyralsina: right. i think the annoying bit there is all the ignoring of other files/paths we do, rather than having things just get skipped18:44
ralsinadobey: could be just reordering of the tests18:44
dobeyat least, running all the tests in only a single file is easy18:45
ralsinadobey: although the change there looks much harder of course :-)18:45
mmccis it a bug to have multiple linked devices listed for the same device? my devices list has two entries for my iPhone and two for my macbook...18:45
dobeywhat i'd really like is some memory summarization18:45
dobeymmcc: not necessarily, though it is annoying; depends on how you deleted the previous token, or how you managed to log in twice18:46
dobeybrb18:47
mmccok, thanks dobey. I figured I was tweaking some edges, but wondered if I had broken anything in doing so18:49
mmccsounds like not18:49
ralsinagrrrr python's os.putenv doesn't change what os.getenv returns18:51
mmccralsina: and remember os.environ is not a real dict, if you need a copy, call environ.copy()18:58
ralsinammcc: yeah, the thing is, I can't test it because I am modifying the "real" environment, but later in the test I am gettin the values from the fake never-updated one!18:58
ralsinammcc: and the suggested solution is to use ctypes' gentev!!!!!18:58
ralsinaOr, I can patch os.putenv to act like a decent function :-(18:59
mmccralsina: if you just set os.environ['foo'] that should work- getenv will read that correctly18:59
ralsinammcc: but the real code uses a real putenv because it has to be seen from C19:00
ralsinammcc: does setting os.environ work that way?19:00
mmccthe docs say os.environ calls putenv() on systems where it exists…19:01
ralsinammcc: ok then, thanks!19:01
* mmcc is curious to see if that works:)19:02
ralsinammcc: will let you know ;-)19:02
ralsinadobey: global +1 on tar-ustar19:03
ralsinammcc: +1 on the PIL branch19:21
mmccthanks!19:21
ralsinaalecu, dobey: re-review when you have a minute please https://code.launchpad.net/~ralsina/ubuntuone-control-panel/no-scroll-overlay/+merge/11775719:23
dobeyralsina: +119:26
ralsinadobey: thanks19:27
ralsinammcc: it did work19:27
mmccralsina: hooray19:27
ralsinammcc: somehow the whole os.environ[]/putenv/getenv thing feels just wrong19:27
mmccralsina: only somehow?19:27
ralsinammcc: ok, it feels really wrong19:28
mmccyeah it's unfortunate. I saw a historical explanation about why it's weird somewhere but I forget where19:29
alecubreaking news: amelia loves "synergy" as much as I do.19:31
alecushe was just amazed moving the mouse between screens19:31
ralsinaalecu: hahaha19:34
ralsinaalecu: beware my son now expects all TVs everywhere to have netflix and all phones to have plants vs zombies19:36
ralsinaalecu: so amelia will expecto to be able to move pointers to all screens in the house :-)19:37
dobeyalecu: i'm just amazed synergy hasn't crashed for you :)19:38
alecuralsina: thanks for adding tests to that branch. One tiny thing: since test customs suggest one assertion per test, would you mind making three tests out of it? Even one _test method that gets called with the content to put in GTK_MODULES, and the expected result.19:38
=== mmcc_ is now known as mmcc
dobeyok, brb again19:38
ralsinaalecu: sure, no problem, the only thing I don't like about that is triplicating the cleanup function19:38
ralsinaSo a _test it is19:39
alecuralsina: right: a _test that receives two params, and that's called by three test_xxx methods.19:40
alecuralsina: the cleanup can be in _test19:40
=== zyga is now known as zyga-afk
ralsinaalecu: right thanks19:41
alecudobey: I'm using the unstable release of synergy; the server is Precise, the client is osx 10.819:41
alecudobey: and if it crashes I don't notice, since I've got a script that restarts the client and its ssh tunnel whenever it breaks.19:43
alecu(for instance, after unsuspending the laptop)19:43
mmccalecu: test style question - why use a _test helper function instead of making a separate TestCase subclass and using setUp (and tearDown for the cleanup)?19:44
alecummcc: we tend not to use tearDown: addCleanup is much nicer, since you can put the cleanup right next to the thing being setup19:46
ralsinadobey: did you already do the quantal release?19:46
ralsinadobey: because I am thinking this branch really should go in it19:47
alecummcc: even when doing setup stuff in setUp, it's much nicer to put the cleanup code in addCleanups right after setting something up.19:47
alecummcc: also, for these kind of tests, we would still need a _test helper if we want to parametrize the tests... right?19:48
alecummcc: I don't have anything against setUp though, and for this might make sense.19:48
alecummcc: anyway, I'm just a journeyer on these matters; we can find an expert at a ping notice.19:49
mmccalecu: your point about addCleanup makes sense. and yeah, the helper is good if you want to avoid writing "main.main(blah) three times ;)19:49
alecummcc: in this case it would be setting the environ, calling main and doing the assert...19:50
mmccalecu, thanks for explaining. I don't really have an opinion, just curious19:51
mmccalecu: right.19:51
alecummcc: it's considered bad form to do asserts in the cleanup.19:51
mmccalecu: yes, that makes good sense19:51
ralsinaalecu: re-re-review please?19:57
alecusure!19:57
mmccok, lunchtime here.20:01
gatoxok..... eod for me!! bye people! :D20:06
ralsinabye gatox!20:08
gatoxralsina, see you20:08
dobeyralsina: which branch?20:09
alecuralsina, dobey: is GTK_MODULES set when running on tarmac?20:09
alecuif not, then the tests will probably break.20:10
dobeyalecu: no; there's no user session.20:10
ralsinaalecu: hmmm let me check20:14
dobeyalecu: if the tests depend on the user's environment being a certain way, then the tests are broken anyway :)20:14
ralsinadobey: it's the restoring that may break20:15
alecuralsina: I think it's "old_modules = os.environ['GTK_MODULES']" that will break if there's no GTK_MODULES set20:17
ralsinaalecu: yes, I am replacing that with a get('GTK_MODULES', '')20:17
dobeythat should use os.environ.get()20:17
ralsinaalecu: that may change the variable from None to '' though20:17
dobeybut good catch :)20:17
ralsinawhich should make no difference20:18
ralsinaalecu: there, done using get()20:21
dobeyralsina: so, which branch should go in quantal?20:22
dobeyralsina: this gtk_modules hack?20:22
ralsinadobey: lp:~ralsina/ubuntuone-control-panel/no-scroll-overlay20:22
ralsinadobey: yes20:22
ralsinadobey: without it u1cp i completely broken20:22
dobeyi'll do another upload with it as a patch after it lands20:22
ralsinadobey: awesome, thanks20:22
thisfredralsina, been googling but I can't find how to do this: I have a treewidget, with editable items (yay!) but any time I start editing an item, its text is cleared. That seems like a strange default.20:32
thisfredI found something about openPersistentEditor which may be related, but I can't find how to hook that up either20:33
ralsinathisfred: haven't actually done that before :-)20:33
thisfredah20:33
ralsinathisfred: so, if you push, I'll pull ;-)20:33
thisfredwill do20:33
dobeythisfred: it clears the text before you start typing, or when you type?20:33
thisfreddobey, when you double click the item, before it "turns editable"20:34
dobeythat sounds horribly broken, yeah20:34
thisfredralsina: lp:~thisfred/u1db/u1todo-design-120:35
ralsinathisfred: getting20:35
thisfredthen cd into that, and do PYTHONPATH=. python cosas/ui.py20:35
ralsinathisfred: ack. Will have an answer in ... [shakes magic 8-ball] 12 minutes20:35
thisfredoutlook not so good20:36
thisfredthat's what mine says. And yesterday's Microsoft announcement hasn't changed its mind.20:36
alecuthisfred: your ball might have bad taste!20:37
ralsinaalecu: stop licking your magic ball!20:37
ralsinasorry couldn't help myself20:37
thisfredhey, you're the manager, if that's the standard you want to set... :P20:38
ralsinathisfred: got a fix forya20:38
thisfredwow20:38
ralsinathisfred: https://pastebin.canonical.com/71337/20:39
ralsinathisfred: this is the stuff I am **good** at, remember ;-)20:39
alecuralsina: +120:39
thisfredah so I was screwing it up because of the order of tests20:39
ralsinathisfred: it looks like it was returning None for editRole20:40
ralsinanot that I actually *tried* to see what it was returning20:40
ralsinaalecu: awesome, thanks!20:40
thisfredralsina, I should have just returned from super there, maybe20:40
ralsinathisfred: could be20:40
ralsinathisfred: this fix is explicit and trivial though20:41
thisfredralsina, yeah, and super doesn't work20:42
thisfredralsina, thanks!20:42
ralsinathisfred: you're welcome!20:42
ralsinaEOD for me20:51
ralsinaI will, as usual, pop up at night, feel free to mail me if you need anything20:52
thisfredralsina, good night, and when you're bored (or tomorrow) I'd appreciate a review on https://code.launchpad.net/~thisfred/u1db/u1todo-design-1/+merge/11779621:00
dobeyalright, gotta run. later21:02
alecuit's EOD for me too. Bye all!21:04
briancurtinalrighty, well enough unsuccessful debugging for the afternoon. EOD.22:35
mmcchrm, I guess we all have 64-bit macs. fsevents daemon doesn't run on old 32-bit objc runtime...22:58
mmcchooray for keeping "old" (2010) hardware around22:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!