| Kilos | morning all | 05:58 |
|---|---|---|
| Kilos | can someone please tell me how to get the last 200 meg of an upload to ubuntuone to update or sync with the folder on my desktop | 05:59 |
| Kilos | if i right click the file on my destop syncronise is greyed out so cannot sync it. please help | 06:28 |
| Kilos | ubuntuone seems to be syncing to my pc but not from my pc back | 06:32 |
| Kilos | im a newbie and still learning so please try help me | 06:33 |
| === JanC_ is now known as JanC | ||
| gatox | good morning! | 11:25 |
| gatox | mandel, hi, could you review this one? https://code.launchpad.net/~diegosarmentero/ubuntuone-client/menu/+merge/118117 | 12:03 |
| === yofel_ is now known as yofel | ||
| alecu | gatox: mandel is on vacation! | 12:40 |
| alecu | gatox: and good morning btw :-) | 12:40 |
| gatox | alecu, ahhhh i forgoy about that..... and good morning to you sir! | 12:40 |
| ralsina | good morning! | 12:47 |
| gatox | ralsina, hi | 12:49 |
| ralsina | alecu: what do you think about bug #1033488 beyond "please don't do that!" ? | 13:01 |
| ubot5 | Launchpad bug 1033488 in ubuntuone-client (Ubuntu) "UbuntuOne fails to synchronise folder when invalid symlink with same name as cloud folder is present" [Undecided,New] https://launchpad.net/bugs/1033488 | 13:01 |
| ralsina | alecu: also, another twist of the SSL bug in comment in bug #1031009 | 13:02 |
| ubot5 | Launchpad bug 1031009 in Ubuntu One Client "Cannot auth, register, reset password" [Undecided,New] https://launchpad.net/bugs/1031009 | 13:02 |
| alecu | ralsina: I think we should treat 1033488 as a feature request... SD should handle this cases in a gentler way... | 13:03 |
| alecu | ralsina: also, that's something we could figure out in the control panel | 13:03 |
| ralsina | alecu: hmmmm yes, some sort of warning about that being unsyncable | 13:03 |
| alecu | ralsina: if the u1cp finds a symlink it should warn, in a similar way to when if finds a folder there | 13:03 |
| alecu | right | 13:04 |
| ralsina | alecu: we have the same problem if it's a file or a library, IIRC | 13:04 |
| alecu | exactly | 13:04 |
| ralsina | and it looks easy enough to do | 13:04 |
| ralsina | since we already have a test there | 13:04 |
| alecu | ralsina: it's nice that we discussed about this. I saw the bug earlier and had no clue on if we wanted to solve it... | 13:05 |
| alecu | ralsina: since I was thinking about it from the perspective of SD | 13:05 |
| ralsina | from SD it's not solvable, I think | 13:06 |
| ralsina | it's just a conflict | 13:06 |
| ralsina | which needs handling though | 13:06 |
| alecu | ralsina: right. But should SD show a notification, or an error in our menu for this case? | 13:07 |
| ralsina | no, because it's a "it shouldn't happen" | 13:07 |
| alecu | ralsina: this happens when creating a UDF, so it's not right to rename the symlink or... | 13:07 |
| ralsina | alecu: if u1cp doesn't let you set it to sync, it should never go far enough that SD sees it | 13:07 |
| alecu | ralsina: right, and if the user is playing with u1sdtool, let him figure that out... | 13:08 |
| alecu | ralsina: hmmm | 13:08 |
| alecu | ralsina: even u1sdtool could figure out if there's a symlink there and warn in that case. | 13:08 |
| ralsina | alecu: yes | 13:08 |
| ralsina | alecu: there is a "check if this is a valid UDF" method u1sdtol and u1cp should use | 13:09 |
| ralsina | alecu: so, it's a fix in sd, I think | 13:09 |
| alecu | ralsina: awesome. | 13:10 |
| alecu | hmmm... there's sand under my desk! | 13:10 |
| ralsina | alecu: on u1cp it's ackend.validate_path_for_folder | 13:11 |
| alecu | either amelia played here on friday after kinder.... or one of my vm sandboxes is leaking. | 13:11 |
| ralsina | alecu: which calls something in sd :-) | 13:12 |
| ralsina | alecu: it should already fail if it's a symlink | 13:14 |
| ralsina | alecu: :-( | 13:14 |
| ralsina | alecu: ubuntuone/syncdaemon/volume_manager.py in validate_path | 13:14 |
| alecu | ralsina: in validate_path_for_folder ? | 13:15 |
| ralsina | alecu: yes, sorry | 13:15 |
| ralsina | Ohhhh I know | 13:16 |
| ralsina | It's not when CREATING the folder, it's when setting it to sync | 13:16 |
| alecu | ralsina: but this is not "create udf", this is "subscribe udf" | 13:16 |
| alecu | right | 13:16 |
| ralsina | so, we just need to validate the path when subscribing | 13:16 |
| alecu | so, it's _subscribe_volume | 13:16 |
| ralsina | piece of cake | 13:16 |
| alecu | we should do the check in _create_volume_dir, and fail if it's a link | 13:17 |
| ralsina | alecu: cool, I'll give it a shot | 13:17 |
| gatox | alecu, ping.... do you have a minute? i'm kind of stuck with a test | 13:23 |
| alecu | gatox: sure | 13:26 |
| gatox | alecu, i'm working on this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu | 13:26 |
| gatox | and when i run: u1trial -t test_sync_menu tests/platform/ipc/test_external_interface.py | 13:26 |
| gatox | it fails in tests/platform/ipc/test_linux.py line 181 | 13:27 |
| gatox | and i'm not following very well all the black magic that is there :P | 13:27 |
| alecu | gatox: how are you running the tests? | 13:30 |
| gatox | alecu, u1trial -t test_sync_menu tests/platform/ipc/test_external_interface.py | 13:30 |
| gatox | it seems that the fakedobject is not being called, so it doesn't register the info in _called.... but i'm not quite sure from where it should be called | 13:34 |
| alecu | gatox: the difference I see is in ubuntuone/platform/ipc/linux.py | 13:39 |
| alecu | gatox: in sync_menu() | 13:39 |
| alecu | gatox: sync_menu there builds the status array, and returns it | 13:39 |
| gatox | alecu, ohhhhhh right | 13:40 |
| gatox | alecu, stupid mistake for testing stuff | 13:40 |
| alecu | gatox: but the other methods (for example, waiting_content) call self.service.status.... | 13:40 |
| gatox | alecu, thx... i was fighting so long with that, that i couldn't see it | 13:40 |
| alecu | gatox: so, I think the patching is done there, no? | 13:41 |
| alecu | gatox: no problem! | 13:41 |
| gatox | alecu, also when you have some time, a small review please: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/menu/+merge/118117 | 13:57 |
| alecu | gatox: "class FixedQueue(Queue.Queue, object):" | 14:03 |
| alecu | gatox: why do you inherit from object? | 14:03 |
| gatox | alecu, ahhhhh yes, we discuss that on pyar.... the thing is: | 14:03 |
| === teknico_ is now known as teknico | ||
| gatox | alecu, Queue.Queue is an old-style object, so i can't use super... but if i inherit from object, i can't use super without any problems.... and is nicer than Queue.Queue.whatever() | 14:04 |
| gatox | sorry...... if i inherit from object too, i CAN use super | 14:04 |
| alecu | gatox: is there a restriction on why to use Queue? | 14:04 |
| gatox | alecu, sorry.. didn't understand that | 14:05 |
| alecu | gatox: I mean... do we need to use Queue.Queue for some reason, or a different struct can work too? | 14:06 |
| alecu | and by "struct" I really meant data type. | 14:06 |
| gatox | alecu, i can use a different data type... i used Queue because it seems that the obvious choice.... i need a queue... but with the restriction i implement there | 14:07 |
| * alecu looks for the collections module | 14:07 | |
| alecu | gatox: for instance, collections.deque | 14:08 |
| ralsina | alecu: when you have 2' I think I ran into a larger problem :-/ | 14:08 |
| gatox | alecu, yap | 14:09 |
| mmcc | hi people, happy monday | 14:09 |
| ralsina | hi mmcc! | 14:09 |
| gatox | alecu, deque it is | 14:09 |
| gatox | mmcc, hi | 14:09 |
| alecu | gatox: wait! let's give this a minute thought | 14:09 |
| alecu | gatox: deque is an option, Queue is an option, list is another, still. | 14:10 |
| gatox | alecu, it makes sense, and the doc says that it does what i need | 14:10 |
| ralsina | alecu: subscribe_volume pushes errors back through IPC but all that arrives at the other side is "IPCError()" | 14:10 |
| gatox | alecu, i only need to use the proper append and popleft in the right places | 14:10 |
| ralsina | alecu: which makes error messages impossible. We never noticed because the only possible failure is "UDF desn't exist" which just doesn't happen IRL | 14:10 |
| alecu | ralsina: so we don't know the exact reason for it, right? | 14:10 |
| gatox | alecu, i prefer deque rather than list | 14:11 |
| ralsina | alecu: exactly | 14:11 |
| alecu | mmcc: good morning. And a late Happy Birthday btw! | 14:11 |
| gatox | mmcc, hey! happy birthday! :D | 14:11 |
| ralsina | alecu: and the solution looks a heck of a lot more complicated (to my little twisted) than just checking for a symlink on u1cp's side | 14:12 |
| gatox | alecu, so.... do you agree on deque? | 14:12 |
| mmcc | thanks guys :) | 14:12 |
| === teknico_ is now known as teknico | ||
| ralsina | mmcc: didn't know, so happy birthday from me too | 14:12 |
| mmcc | thanks ralsina - yeah I don't usually make a big deal out of it anymore. Mostly just an excuse to overeat :) | 14:13 |
| gatox | mmcc, i share that feeling :P | 14:13 |
| alecu | gatox: oh, deque has a maxlen | 14:15 |
| gatox | alecu, right | 14:15 |
| alecu | Once a bounded length deque is full, when new items are added, a corresponding number of items are discarded from the opposite end. | 14:15 |
| alecu | awesome! | 14:15 |
| gatox | alecu, just what i needed.... | 14:16 |
| alecu | gatox: so, there you go. That sounds like the best | 14:16 |
| ralsina | alecu: that's why it's a deque ;-) | 14:16 |
| alecu | ralsina: nahhh | 14:16 |
| alecu | ralsina: it was a deque (in 2.4) before having the maxlen (added in 2.6) | 14:17 |
| ralsina | interesting | 14:17 |
| ralsina | I had never seen a deque with infinite size | 14:17 |
| * ralsina goes read Knuth volume 1 again | 14:17 | |
| alecu | probably "unbounded" in this context in fact means "until your swap explodes" | 14:20 |
| ralsina | alecu: so, for that symlink bug, I have a 2-line solution in u1cp on one hand, and no idea how to fix it on sd on the other ;-) | 14:22 |
| gatox | alecu, branch updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/menu/+merge/118117 | 14:25 |
| alecu | ralsina: btw: this looks like something we should recommending for users running u1 on xp: http://www.microsoft.com/en-us/download/details.aspx?id=29434 | 14:28 |
| alecu | *should be | 14:28 |
| ralsina | alecu: that should be autoinstalled | 14:28 |
| ralsina | alecu: the only ones who don't have that are those who have not validated their copy | 14:29 |
| ralsina | alecu: and those are avoiding updates intentionally if you know what I mean | 14:29 |
| alecu | lol | 14:29 |
| alecu | ralsina: or not connected to the internet. | 14:30 |
| alecu | ralsina: and those are not our users either :-) | 14:30 |
| ralsina | alecu: and in that case, they are not using u1 to their fullet extent ;-) | 14:30 |
| ralsina | alecu: so, would it be very awful of me to just check for the symlink on u1cp instead of tweaking all the way up and down our IPC(s) how to pass an error? | 14:41 |
| alecu | ralsina: I guess not. But what about other similar errors? | 14:43 |
| ralsina | alecu: AFAIK there are no other similar errors | 14:44 |
| alecu | ralsina: like, a file named like the folder... or a folder already existing... | 14:44 |
| ralsina | alecu: you are right | 14:44 |
| ralsina | alecu: I had a moment of weakness | 14:44 |
| ralsina | alecu: but there is already a check for merging, isn't there? | 14:45 |
| alecu | ralsina: yes, for merging folders there is, you are right. | 14:45 |
| alecu | ralsina: but wait, I'm not saying that the doing the ipc dance is the right route | 14:45 |
| ralsina | but how does that even work? | 14:45 |
| ralsina | the check for merging there is u1cp-side | 14:46 |
| ralsina | sigh | 14:46 |
| ralsina | and on _creating_ a UD is sd-side | 14:46 |
| ralsina | UDF* | 14:46 |
| rye | ralsina: or here | 14:47 |
| alecu | ralsina: so, if the user decides to merge, SD goes ahead and merges, right? | 14:48 |
| ralsina | rye: we have a similar error but not on that function, that sounds like a bug | 14:48 |
| ralsina | alecu: yes | 14:48 |
| rye | ralsina: okay | 14:48 |
| ralsina | alecu: easier solution, use validate_path_for_folder also on subscription | 14:54 |
| ralsina | alecu: and i it fails with "is nested" go ahead anyway ;-) | 14:54 |
| gatox | me | 15:01 |
| briancurtin | me | 15:03 |
| gatox | ralsina, alecu thisfred mmcc dobey | 15:03 |
| ralsina | me | 15:03 |
| ralsina | no notes yet | 15:03 |
| thisfred | me | 15:03 |
| mmcc | me | 15:03 |
| * mmcc writes | 15:03 | |
| ralsina | alecu? | 15:04 |
| alecu | me | 15:05 |
| * alecu writes notes! | 15:05 | |
| ralsina | gatox: go | 15:05 |
| gatox | DONE: | 15:05 |
| gatox | Propose and fix u1-client menu branch. Finishing ipc part of the implementation to propose today. | 15:05 |
| gatox | TODO: | 15:05 |
| gatox | Move on to u1-cp menu implementation. | 15:05 |
| gatox | BLOCKED: | 15:05 |
| gatox | No | 15:05 |
| gatox | briancurtin, go | 15:05 |
| briancurtin | DONE: installer with PyQt 4.9.4 | 15:05 |
| briancurtin | TODO: make installer identifiable as 3.0.2b or something, fix SyncTimestampChecker | 15:05 |
| briancurtin | NEXT: ralsina (or thisfred if notes aren't ready) | 15:05 |
| ralsina | DONE: twisted contract negotiation, but it's stuck because of a typo (in the date sigh) reviews, team call, 1-1s canonicaladmin cleanup random minor things TODO: fix a bug or two, fix that contract problem, bug triaging, misc BLOCKED no NEXT thisfred | 15:05 |
| thisfred | DONE: cosas background sync TODO: cosas background sync BLOCKED: no NEXT: mmcc | 15:05 |
| ralsina | dobey is on holiday | 15:05 |
| mmcc | DONE: first-run code, forgetting something | 15:06 |
| mmcc | TODO: propose first-run code, fix u1cp test.bat to ignore darwin, | 15:06 |
| mmcc | BLCK: none | 15:06 |
| mmcc | NEXT: none? | 15:06 |
| ralsina | mmcc: alecu | 15:07 |
| alecu | DONE: a bunch of mumbles, some reviews, debugging of bug #1031197 | 15:07 |
| alecu | TODO: fix said bug | 15:07 |
| alecu | BLOCKED: no | 15:07 |
| ubot5 | Launchpad bug 1031197 in ubuntuone-client (Ubuntu) "DownloadFinished signal triggers when file has not yet completed writing" [Undecided,Confirmed] https://launchpad.net/bugs/1031197 | 15:07 |
| alecu | NEXT: None | 15:07 |
| ralsina | Comments? | 15:07 |
| alecu | No comments | 15:07 |
| briancurtin | did we come to a consensus on what the new 3.0.2 release will be named? is 3.0.2b it? | 15:07 |
| briancurtin | this is the one with the new PyQt | 15:08 |
| mmcc | alecu, gatox, are there any further branches pending for the macfsevents part of u1-client? | 15:08 |
| ralsina | briancurtin: no consensus. I don't quite care about naming ;-) | 15:08 |
| ralsina | briancurtin: 3.0.2b looks good to me | 15:08 |
| alecu | mmcc: I think only a fixup branch for the tests, that's bouncing in tarmac | 15:08 |
| ralsina | 3.0.2-1 i what it would be calledin ubuntu, IIRC | 15:08 |
| alecu | mmcc: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/darwin-tests-refactoring/+merge/113289 | 15:08 |
| gatox | mmcc, ohh i need to fix the refactoring tests one..... it has some issues when trying to land..... doing that right now | 15:09 |
| mmcc | ok, thanks. What are we going to do with the code from macfsevents? Right now it's in gatox's lp +junk, right? | 15:10 |
| gatox | alecu, ^ | 15:13 |
| alecu | gatox: do I have to answer that? :-) | 15:14 |
| gatox | alecu, i don't know.... maybe :P | 15:14 |
| alecu | mmcc: we should first try to get those fixes upstream | 15:14 |
| gatox | what we should do we that?? | 15:14 |
| gatox | fork it, or propose the changes to the author | 15:14 |
| alecu | gatox: first we should try proposing | 15:15 |
| alecu | gatox: do you have the url of your junk branch? | 15:15 |
| mmcc | gatox: where is the upstream hosted? | 15:15 |
| gatox | alecu, lp:~diegosarmentero/+junk/python-macfsevents | 15:15 |
| gatox | mmcc, don't know.... need to check | 15:15 |
| alecu | mmcc: http://pypi.python.org/pypi/MacFSEvents/ | 15:15 |
| alecu | mmcc: I'm not sure if there's even a repo for it. | 15:16 |
| gatox | alecu, i'll email the author to ask where the repo is | 15:16 |
| gatox | the repo is not listed anywhere | 15:17 |
| gatox | not even in the code | 15:17 |
| alecu | gatox: perhaps it's https://github.com/malthe/macfsevents ? | 15:17 |
| mmcc | alecu, yeah, I just found that too :) | 15:18 |
| gatox | seems like it | 15:18 |
| gatox | alecu, ok, i'll fork that one, and propose the changes | 15:18 |
| alecu | gatox: so, how intrusive or specific is your code? | 15:18 |
| gatox | alecu, is not a big change.... but it changes the way it works, in the sense that i think for some reason the lib works first adding the folders, and then starting the observer | 15:20 |
| gatox | but that is not what we need | 15:21 |
| * gatox lunch! | 15:35 | |
| === gatox is now known as gatox_lunch | ||
| mmcc | brb | 15:46 |
| ralsina | briancurtin: is there any peculiarity about window's is_dr? | 15:54 |
| ralsina | briancurtin: I meant isdir()? | 15:54 |
| ralsina | briancurtin: as in, it returns true for links or libraries or other evil stuff | 15:55 |
| briancurtin | ralsina: for os.path.isdir? if so, none that i'm familiar with off the top of my head. i'll take a look | 15:55 |
| ralsina | briancurtin: thanks | 15:55 |
| briancurtin | ralsina: it returns false for symlinks and hardlinks. i'm not sure how you isdir a library - as far as i know that's just a GUI thing in explorer that aggregates multiple directories (e.g., "Documents" library pulls your user's documents and public all-user documents) | 16:00 |
| ralsina | briancurtin: cool then | 16:00 |
| briancurtin | ralsina: but the C:\Users\brian\Documents folder and/or library returns True on isdir, which would be correct | 16:00 |
| ralsina | briancurtin: ok, not doing a platform-specific isdir then :-) | 16:01 |
| alecu | ralsina, all: my spouse has skipped work today because she's feeling ill. I might be away for some time at times while tending her, so ping me or sms me if I'm needed. | 16:30 |
| ralsina | alecu: ack | 16:30 |
| ralsina | gargl are the u1-client tests slow or are they very very very slow? | 16:31 |
| briancurtin | alecu, ralsina: http://ubuntuone.com/7O01iFMjvTQSFWtZIKdcaI is a 3.0.2 installer now set with "3.0.2b" as the version reported in the SD log, plus PyQt 4.9.4 | 16:33 |
| ralsina | briancurtin: awesome | 16:34 |
| briancurtin | im working on a way to automate that version updating for the log. i just set it manually in clientdefs.py for now | 16:34 |
| ralsina | briancurtin: did you also raise the build number for the auto updater? | 16:34 |
| briancurtin | ralsina: ah, crap i didn't change that. i will update the build number for autoupdate, but will leave it identified as 3.0.2 for anything else | 16:34 |
| ralsina | briancurtin: cool, thanks | 16:34 |
| ralsina | briancurtin: it shouldn't really matter really, but just to be neat :-) | 16:35 |
| === gatox_lunch is now known as gatox | ||
| briancurtin | ralsina: the link i sent now has an updated installer with the right build number and such. when alecu is available and can confirm that the PyQt/Qt pairing does what we need, i'll send it off for signing | 16:57 |
| ralsina | briancurtin: awesome | 16:57 |
| thisfred | mandel, ralsina https://code.launchpad.net/~thisfred/u1db/cosas-bg-sync/+merge/118398 | 17:06 |
| thisfred | not very big or complicated | 17:06 |
| ralsina | thisfred: I'll do it, mandel is off | 17:07 |
| thisfred | thanks! | 17:07 |
| thisfred | it's qt and twisted | 17:07 |
| thisfred | but not a lot of either | 17:07 |
| ralsina | thisfred: all you use twisted for is to use a callLater? | 17:10 |
| ralsina | thisfred: or was it in use before already? | 17:10 |
| thisfred | ralsina, well I used deferreds already | 17:10 |
| thisfred | not the reactor though | 17:10 |
| ralsina | thisfred: because now you are adding a dependency on qt4reactor which is unmaintained | 17:10 |
| thisfred | ralsina, so I should look at the qt way of scheduling? | 17:11 |
| ralsina | thisfred: 'fraid so | 17:11 |
| thisfred | np, will do | 17:11 |
| ralsina | QTimer.singleshot(timeout, callable) | 17:11 |
| ralsina | correct case as needed | 17:11 |
| ralsina | thisfred: let me get you a tip though | 17:11 |
| ralsina | thisfred: http://lateral.netmanagers.com.ar/tr/es/weblog/posts/BB974.html | 17:12 |
| thisfred | thx | 17:12 |
| thisfred | tipping is encouraged ;) | 17:12 |
| ralsina | Or, if you prefer english: http://lateral.netmanagers.com.ar/weblog/posts/BB974.html | 17:12 |
| thisfred | yay, I get to use my level 11 spanish skill | 17:12 |
| ralsina | is level 11 the one where you get the magic spanish wand? | 17:14 |
| thisfred | It's where you learn the "mañana" spell :P | 17:14 |
| thisfred | and "tengo una bomba" | 17:15 |
| thisfred | I kid you not | 17:15 |
| thisfred | why would you teach anyone that | 17:15 |
| ralsina | hahaha | 17:15 |
| ralsina | let me show you a good reason... | 17:16 |
| ralsina | thisfred: http://tinyurl.com/cr7klus | 17:17 |
| thisfred | ralsina, ooooh | 17:17 |
| thisfred | the english translation was definitely the one you wouldn't want to use out loud in public though | 17:18 |
| thisfred | ralsina, now I wonder if that is derived from a Berliner (the pastry, obviously not the name) or if it's just coevolution to fill a similar niche :) | 17:18 |
| ralsina | thisfred: Berliners are called Berlinesas | 17:20 |
| ralsina | thisfred: these are more like profiteroles | 17:20 |
| ralsina | although Berlinesas are da bomb | 17:20 |
| ralsina | also, they are known are friar's balls (pun very very intended) | 17:20 |
| ralsina | Can I get a simple review https://code.launchpad.net/~ralsina/ubuntuone-client/verify-harder/+merge/118399 ? | 17:21 |
| thisfred | well repay in kind | 17:21 |
| * ralsina will someday write his monography about the origin of pastry names in argentina | 17:21 | |
| ralsina | they mostly have anti-clerical anti-militaristic anti-police names because the bakery union was formed by italian anarchists | 17:22 |
| mmcc | from the pun very intended dept: http://www.twitpic.com/6hmjct | 17:22 |
| thisfred | mmcc, have you tried their schweddy balls? :) | 17:23 |
| ralsina | hahahahaha | 17:23 |
| mmcc | thisfred: you know, I haven't… | 17:23 |
| ralsina | also, the "polite" name for friar balls is "nun sighs" | 17:23 |
| thisfred | I also like clusterfluff | 17:23 |
| ralsina | which is hardly an improvement, if you ask me | 17:24 |
| thisfred | mmcc, it's actually pretty good | 17:24 |
| mmcc | ralsina: that's hilarious | 17:24 |
| thisfred | but I think it's already out of rotation | 17:24 |
| ralsina | mmcc: the name for a small ham&cheese sandwich is "little kid" | 17:24 |
| mmcc | thisfred: yeah I think it was a special edition. | 17:25 |
| * ralsina looks for the south park chef balls song | 17:25 | |
| ralsina | ok, too much. u1cp | 17:25 |
| * ralsina tries to look serious | 17:25 | |
| thisfred | ralsina, that branch sets my spidey sense atingle. I may be misunderstanding, but it seems a bit yagni, to have the same platform independent implementation called from platform specific functions? | 17:26 |
| ralsina | thisfred: could just use os.path.isdir in os_helper | 17:27 |
| thisfred | or why does it even need to be in os_helper, if it works everywhere? | 17:27 |
| ralsina | thisfred: what I don't want is to use it in our code and then have to search for it when we inevitably find out it's not all that crossplatorm ;-) | 17:27 |
| thisfred | it's meant to be | 17:27 |
| ralsina | thisfred: been there, had to change that ;-) | 17:27 |
| ralsina | thisfred: so is everything in os_helper | 17:28 |
| * briancurtin lunch | 17:28 | |
| thisfred | It's very defensive | 17:28 |
| ralsina | thisfred: also, the windows_path decorator protects us against calling it with the wrong kind of thing | 17:28 |
| thisfred | as in, it makes all your code hard to read, for the dubious benefit of being able to fix it in one place. | 17:29 |
| thisfred | ralsina, why would we do that? :) | 17:29 |
| ralsina | thisfred: because once is_dir exists we will use it somewhere without looking | 17:29 |
| ralsina | thisfred: but yes, it's fairly paranoid | 17:29 |
| ralsina | thisfred: I can dial it down | 17:30 |
| thisfred | ralsina, then just fire the people who do :D | 17:30 |
| thisfred | jk | 17:30 |
| ralsina | I'll remove the per-platform implementation | 17:30 |
| thisfred | anyhow, it's a matter of taste, but I'd prefer that yeah | 17:30 |
| thisfred | at least until we find out that it doesn't work everywhere | 17:30 |
| ralsina | oh, wait, we are using isdir everywhere. | 17:32 |
| ralsina | what's one more spot in the leopard | 17:32 |
| ralsina | thisfred: re-running tests and will ping you when the branch is updated | 17:33 |
| thisfred | cool | 17:33 |
| ralsina | I am going to have lunch while tests run. That can't be right. | 17:46 |
| thisfred | ralsina, when you get | 17:46 |
| thisfred | back I pushed my fixes | 17:46 |
| ralsina | thisfred: looking now | 17:46 |
| thisfred | not I keep a reference to the qtimer to be able to stop it | 17:47 |
| thisfred | note | 17:47 |
| thisfred | not because of gc | 17:47 |
| ralsina | hmmmm | 17:48 |
| ralsina | makes sense | 17:48 |
| ralsina | thisfred: but singleShot doesn't return a timer | 17:49 |
| ralsina | thisfred: you will have to instantiate a QTimer and call instance.singleShot | 17:49 |
| thisfred | ah | 17:50 |
| thisfred | fixing | 17:50 |
| mmcc | ralsina: when you get back from lunch, https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1024623-install-confs/+merge/118404 | 17:50 |
| ralsina | mmcc: looking | 17:51 |
| * briancurtin back | 17:51 | |
| ralsina | damn launchpad branch-scanning delay :-( | 17:51 |
| mmcc | ralsina: with that branch, Double-clicking on "UbuntuOne.app" works without tossing up error boxes. (Assuming you have SSO creds already) | 17:52 |
| ralsina | whoohoo | 17:52 |
| thisfred | ralsina, pushed again | 17:52 |
| ralsina | thisfred: looking | 17:53 |
| ralsina | mmcc: looks good to me, get a second review from alecu though | 17:54 |
| ralsina | thisfred: you could create the QTimer on __init__ and keep it, just start/stop it as needed | 17:56 |
| ralsina | thisfred: it's not as if it's expensive to have one. But that's a nitpick | 17:56 |
| ralsina | thisfred: so +1 | 17:57 |
| gatox | ralsina, sorry, didn't read the whole conversation..... but if you are using something that extends from qobject, you can just use the startTimer method without the qtimer | 17:57 |
| ralsina | gatox: really? Didn't know that one :-) | 17:57 |
| thisfred | ralsina, I'll change that, seems tidier. | 17:58 |
| alecu | thisfred: "tengo una bomba" reminds me of: http://media.nowpublic.net/images//39/2/392ad9a1977af8f4df757c0778beb126.jpg | 17:58 |
| gatox | ralsina, every qobject has a startTimer(int interval), and that calls the timerEvent(event) from the qobject | 17:58 |
| ralsina | gatox: but you can have stacked calls with that | 17:58 |
| ralsina | gatox: which is a very very bad thing to have | 17:59 |
| ralsina | or rather something I really dislike ;-) | 17:59 |
| gatox | well...... i didn't say it was perfect jeje | 17:59 |
| thisfred | hehe | 17:59 |
| ralsina | thisfred: I think having a single timer is nicer | 18:00 |
| ralsina | and more explicit (you would still need to have something holding the int that is the timer reference anyway) | 18:00 |
| thisfred | ralsina, so if I have a single timer object, will t.singleShot(TIMEOUT, foo) ... t.stop() ... t.singleShot(TIMEOUT, foo) just work, or do I need to do more resetting than that? | 18:01 |
| ralsina | thisfred: just that | 18:01 |
| thisfred | kcool | 18:01 |
| ralsina | thisfred: oh, wait | 18:01 |
| ralsina | thisfred: let me check the docs ;-) | 18:01 |
| ralsina | thisfred: the docs are inconclusive but I bet it does stop it ;-) | 18:02 |
| thisfred | will test :) | 18:02 |
| ralsina | sadly it's not something that can be tested in the python prompt since it needs an event loop running | 18:03 |
| ralsina | ok, now really lunch because u1-client tests are still running :-( | 18:04 |
| thisfred | hmm, stop does not actually seem to stop anymore | 18:06 |
| thisfred | I might as well not use the singleshot, since I keep the timer around anyway | 18:07 |
| gatox | ralsina, back! | 18:08 |
| gatox | ralsina, i don't know if you read my sms..... maybe i get back before you read it jeje | 18:08 |
| thisfred | ralsina, going back to multiple singleshots, since that seems to behave more predictably | 18:10 |
| thisfred | ralsina, actually no. stop seems to have no effect on singleShots. Or more likely: I'm doing it wrong | 18:14 |
| thisfred | thouf | 18:15 |
| thisfred | though I don't see how. ralsina: pushed a version with a 10 sync period, and a debug print that shows stop() is called. It does not stop the singleShot though. To test: PYTHONPATH=. cosas/ui.py and then open File/Sync, and then activate and deactivate the checkbox... | 18:17 |
| thisfred | hmmm | 18:17 |
| thisfred | I think I know | 18:17 |
| thisfred | maybe | 18:17 |
| thisfred | nope, no idea | 18:18 |
| mmcc | thisfred: (and ralsina ) - ui.py will pull in twisted anyway from ubuntuone.platform.credentials | 18:25 |
| mmcc | but I guess not reactor… just deferred, so that won't pull in qt4reactor? | 18:26 |
| mmcc | well, nothing in platform/credentials should import reactor, but how does a twisted deferred work without a reactor? | 18:28 |
| alecu | mmcc: the deferreds do not depend at all on the reactor | 18:29 |
| alecu | mmcc: the deferred is just an object that has a list of callbacks and a list of errbacks attached. | 18:29 |
| alecu | mmcc: and it calls one or the other when the deferred's callback or errback method is called. | 18:30 |
| alecu | mmcc: so, a deferred is just a way to encapsulate a series of callbacks. I tend to explain it as a kind of control structure. | 18:31 |
| alecu | mmcc: the other stuff in the defer module do not depend on the reactor either (for instance, the inlineCallbacks decorator). | 18:32 |
| alecu | mmcc: that is why we can use the defer module with other main loops, like the qt main loop or the gobject one, without using the twisted reactor. | 18:32 |
| mmcc | alecu: ok, I follow that. still a little fuzzy on how defer interacts with a main loop, but I can go look | 18:33 |
| alecu | mmcc: a defer does not interact directly with a main loop. | 18:34 |
| mmcc | also thisfred - does your code work if you use setSingleShot and start instead of just singleShot? | 18:34 |
| mmcc | thisfred: (from http://qt-project.org/forums/viewthread/4852) | 18:34 |
| alecu | mmcc: you may use the deferred's callback or errback method as a callback function for a given main loop. But the deferred module does not need to depend on any given main loop. | 18:35 |
| alecu | mmcc: also: the twisted.python.defer module is very well commented and pretty understandable if you want to understand how it works. | 18:37 |
| mmcc | alecu: ok, thanks | 18:37 |
| thisfred | mmcc, that may work. Then I need to hook up the event handler some other way though, I think | 18:38 |
| thisfred | since start doesn't take a callback | 18:38 |
| mmcc | thisfred, yeah it looks like you need to do the PyQt equivalent of connect(), which I don't know :) | 18:40 |
| thisfred | mmcc, connect, so that's simple enough | 18:41 |
| thisfred | the thing that I don't know is, is how this affects setting the timer in the timeout itself. One way to find out :) | 18:41 |
| thisfred | maybe this is just | 18:42 |
| thisfred | a case where we actually don't want a singleshot at all | 18:42 |
| thisfred | mmcc, that fixed it, thx. pushed new version, for the curious | 18:49 |
| mmcc | thisfred: great! | 18:50 |
| alecu | ralsina: I've been testing the latest installer that briancurtin built, and I've found some issue with the proxy credentials. | 18:57 |
| alecu | ralsina: it seems that if the user types the credentials wrong, then those are saved to the windows keyring and are retried forever. | 18:58 |
| alecu | ralsina: everything else I tried seems to be working ok, though. For instance, I can login and sync successfully with the right proxy credentials. | 18:59 |
| alecu | but if I get them wrong, then the only solution is to manually stop evey process and remove the creds from "Credentials Manager" | 19:00 |
| mmcc | alecu, when you get a chance, could you look at this mp: https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1024623-install-confs/+merge/118404 (it already has tests) | 19:00 |
| alecu | briancurtin2: [15:57] <alecu> ralsina: I've been testing the latest installer that briancurtin built, and I've found some issue with the proxy credentials. | 19:05 |
| alecu | [15:58] <alecu> ralsina: it seems that if the user types the credentials wrong, then those are saved to the windows keyring and are retried forever. | 19:05 |
| alecu | [15:59] <alecu> ralsina: everything else I tried seems to be working ok, though. For instance, I can login and sync successfully with the right proxy credentials. | 19:05 |
| briancurtin2 | alecu: is that new? | 19:05 |
| alecu | mmcc: I have that tab opened, didn't get to it yet, sorry :P | 19:06 |
| mmcc | alecu, no worries | 19:06 |
| alecu | briancurtin2: I think mandel mentioned something similar while working on it. I don't recall if it was with pyqt 4.9 or 4.8. | 19:07 |
| mmcc | anyone: how do I poke tarmac to pick up an approved branch? I approved too many at once last week, and now this one is still stuck at "Approved": https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/fix-1032290/+merge/117960 | 19:07 |
| alecu | mmcc: try moving it to "needs review" and back. | 19:11 |
| alecu | ok, it's kinder time. TTYAL | 19:11 |
| ralsina | alecu: that looks like something we may have had since ever | 19:12 |
| mmcc | thanks & bye alecu | 19:12 |
| ralsina | thisfred: re-review of https://code.launchpad.net/~ralsina/ubuntuone-client/verify-harder/+merge/118399 please? | 19:19 |
| thisfred | ralsina, on it | 19:19 |
| thisfred | mine is fixed and pushed too | 19:19 |
| thisfred | ralsina, +n for n > 0 | 19:23 |
| mmcc | interesting error loading the SSL certs for me - http://paste.ubuntu.com/1133087/ | 19:24 |
| mmcc | taken from how we load them in storageprotocol's context.py | 19:25 |
| mmcc | which is where I first saw the error | 19:25 |
| thisfred | mmcc, does getIssuer maybe return a special object instead of raising exceptions when something goes wrong? | 19:26 |
| thisfred | oh wow, that's twisted itself erroring right? | 19:28 |
| mmcc | thisfred: yes… it's erring in __repr__ | 19:28 |
| thisfred | mmcc, so it's probably never been tested in the console | 19:30 |
| mmcc | well, I just looked and we never use the actual twisted Certificate, we use the .original… looking now to see where that gets set | 19:30 |
| mmcc | ok, no errors unless I try to print the Certificate. uh, hooray? | 19:31 |
| ralsina | mmcc: yike | 19:36 |
| ralsina | s | 19:36 |
| ralsina | mmcc: that sounds like "it totally fails, but if you don't look the issuer seems valid" | 19:36 |
| mmcc | ralsina: if you print the Certificate.original, the underlying X509 object seems fine (to me) | 19:37 |
| mmcc | and that's what our code actually uses… | 19:37 |
| ralsina | mmcc: ok then :-) | 19:37 |
| mmcc | hrm, although - what kind of object does verify_server_hostname get passed as 'cert'… | 19:39 |
| mmcc | (I'm looking) | 19:39 |
| mmcc | ok, it's expecting the 'original' object. weird that twisted's twisted.internet.ssl.CertificateOptions class doesn't accept twisted.internet.ssl.Certificate objects for its 'caCerts' constructor argument… | 19:44 |
| mmcc | no wonder Certificate() isn't well tested | 19:45 |
| ralsina | mmcc: that's one way to put it | 19:50 |
| ralsina | mmcc: twisted is a maze of twisted little passages, some alike, some different. | 19:50 |
| mmcc | ralsina: so I'm learning. Its quirks are not endearing | 19:51 |
| briancurtin2 | i need some fresh air. brb - quick walk around the neighborhood | 19:55 |
| mmcc | lunchtime now | 19:58 |
| thisfred | Sabemos dónde vive su familia. | 20:02 |
| thisfred | another interesting choice of phrase to teach new speakers | 20:02 |
| ralsina | could it be we don't have tarmac running for u1-client? | 20:02 |
| ralsina | thisfred: are you following a "Spanish for criminals" course? | 20:03 |
| thisfred | I think I may inadvertently be | 20:03 |
| ralsina | thisfred: because if those quotes are real, I am sure you can become semi-famouse by submitting it to gawker or something | 20:03 |
| thisfred | ralsina, they are. I am of course cherry picking out of hundreds of phrases, but still | 20:04 |
| ralsina | briancurtin, thisfred: small review? https://code.launchpad.net/~ralsina/ubuntuone-control-panel/check_subscribe_errors/+merge/118420 | 20:05 |
| thisfred | check | 20:06 |
| ralsina | "¡Yo soy el ratón más rápido de todo Mexico!" | 20:06 |
| thisfred | ralsina, could you also lift the needs fixing from mine, if you feel it's ok now? :) | 20:06 |
| gatox | speedy gonzalez? | 20:06 |
| ralsina | gatox: yep :-) | 20:07 |
| ralsina | thisfred: looking! | 20:07 |
| gatox | ok..... eod here!! see you tomorrow!! byeeeeeee | 20:07 |
| thisfred | ralsina, de este lado del Río Grande | 20:07 |
| ralsina | bye gatox! | 20:08 |
| thisfred | por lo menos | 20:08 |
| ralsina | thisfred: you're getting good at this! | 20:08 |
| thisfred | gracias :) | 20:08 |
| * ralsina considers meetings in spanish starting this thursday | 20:08 | |
| thisfred | ralsina, and then in Dutch the week after? :P | 20:09 |
| ralsina | thisfred: your branch is a bit confusing | 20:09 |
| ralsina | thisfred: you are using start() which makes it a recurring timer | 20:09 |
| thisfred | ralsina, it is a recurring timer now | 20:09 |
| ralsina | thisfred: and you are doing it on every lap | 20:09 |
| thisfred | I stop it in the signal handler | 20:09 |
| ralsina | oh, right! | 20:10 |
| ralsina | +1 then :-) | 20:10 |
| thisfred | ralsina, the singleshot one didn't really listen to stop() | 20:10 |
| thisfred | much like my dog | 20:10 |
| ralsina | thisfred: pity | 20:10 |
| thisfred | ralsina, well, we were mildly abusing the single shot to get around issues where the actual call would be so slow that the timer would trigger again, etc. | 20:11 |
| ralsina | thisfred: yes | 20:12 |
| ralsina | thisfred: timers are surprisingly easy to get a bit wrong | 20:12 |
| thisfred | if you stop the timer as the first thing in the handler, I don't think you need to worry about that, so the workaround is no longer necessary | 20:12 |
| thisfred | but yeah | 20:12 |
| ralsina | 1 hour until the USA men's basketball team starts beating the .ar one | 20:13 |
| * ralsina is so not jinxing it | 20:13 | |
| thisfred | ralsina, I would say "folder X already exists *on* your device" | 20:14 |
| ralsina | thisfred: I really need to get copy approval for this | 20:14 |
| ralsina | but yes "on" sounds better. | 20:15 |
| thisfred | prepositions are tricky :) | 20:17 |
| thisfred | subtly different in every language | 20:17 |
| ralsina | I can still say all the spanish prepositions (useless thing we learn in school) | 20:18 |
| ralsina | a ante bajo cabe con contra de dede en entre hasta hacia para por según sin so sobre tras | 20:18 |
| thisfred | I can do the german ones that take the 3rd case | 20:18 |
| thisfred | aus bei mit nach zeit von zu \ bis durch für gegen ohne um entlang | 20:19 |
| ralsina | OMG there is a different "non traditional list" that adds durante, mediante vía! | 20:19 |
| ralsina | mediante is so totally an adverb, you silly royal spanish academy! | 20:20 |
| ralsina | *fist to the sky* | 20:20 |
| thisfred | heh | 20:20 |
| ralsina | ugh, crazy bad headache coming | 20:26 |
| * briancurtin back, doing ralsina's review | 20:30 | |
| ralsina | thanks briancurtin! | 20:30 |
| ralsina | briancurtin: just don't set it to approved :-) | 20:30 |
| briancurtin | was just reading that, slapping my hand to not set it yet | 20:30 |
| ralsina | hahaha | 20:31 |
| briancurtin | if i set it, you can call the police...they are down the street arresting a house full of people | 20:32 |
| briancurtin | was a pleasant end to my walk | 20:32 |
| ralsina | briancurtin: whoa | 20:33 |
| thisfred | Los individuos viven aquí | 20:34 |
| alecu | lol! | 20:35 |
| ralsina | thisfred: "hay unos individuos sospechosos cerca de la casa de brian, oficial!" | 20:35 |
| thisfred | heh | 20:36 |
| alecu | mmcc: that ssl issue looks like the twisted repr code is expecting the commonName to be always present on the certificate, but it surely is not. | 20:36 |
| thisfred | but surely the attribute should be there? | 20:40 |
| thisfred | otherwise it's pretty unpythonic. (shock! horror!) | 20:41 |
| ralsina | is that repr our code or is it in twisted? | 20:42 |
| thisfred | it's in twisted | 20:42 |
| thisfred | it looked like | 20:43 |
| alecu | thisfred: those attributes show up on OpenSSL objects when the corresponding fields in the certificate are present. | 20:43 |
| alecu | thisfred, ralsina: it's twisted code | 20:44 |
| thisfred | alecu, that's what I mean by unpythonic :P | 20:44 |
| ralsina | alecu: then that looks like a bug | 20:44 |
| ralsina | having a repr that fails is just yucky | 20:44 |
| thisfred | properties should not magically appear | 20:44 |
| alecu | right and right | 20:44 |
| ralsina | so, mmcc you get to file a twisted upstream bug ;-) | 20:45 |
| alecu | the thing is that *our* certificate is pretty weird in not including a Common Name field. | 20:45 |
| alecu | but that's a case that twisted should handle more gracefully | 20:46 |
| ralsina | I am going to EOD a bit early today because my head is exploding | 20:46 |
| thisfred | either that, or not allow it | 20:46 |
| ralsina | will be back late, mail me for reviews | 20:47 |
| ralsina | thisfred: certs without common name are valid AFAIK, just weird | 20:47 |
| thisfred | right | 20:47 |
| thisfred | so twisted is wrong | 20:47 |
| thisfred | but it would be better if it refused them, instead of failing in some specific cases, because now I don't trust that it actually doesn't do the wrong thing elsewhere | 20:48 |
| ralsina | although reading ssl.com it seems that it can't be empty. Would have to read the RFC and won't | 20:48 |
| ralsina | http://info.ssl.com/Article.aspx?id=10048 | 20:48 |
| thisfred | regardless, there is a bug in twisted: it allows a case that it can't properly handle | 20:49 |
| ralsina | and googling for "missing certificate CN" gives me a ton of results on CNN about obama's birth certificate | 20:50 |
| thisfred | HAHA | 20:51 |
| thisfred | the UN really should take away our rights to be a country for a few decades | 20:51 |
| alecu | certificates without commonName (which is the hostname that the certificate is valid for) use a different field so they can hold a list of hostnames, and this usually replaces commonNames. | 20:52 |
| thisfred | boolean trap | 20:52 |
| alecu | so it's ok for a cert to have an empty or non existing commonName | 20:52 |
| thisfred | achievement unlocked | 20:52 |
| alecu | so, the only thing we should fix is twisted trying to repr them. | 20:53 |
| thisfred | http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html | 20:53 |
| thisfred | well, not exactly, but | 20:54 |
| thisfred | close. | 20:54 |
| thisfred | nullean trap | 20:54 |
| ralsina | haha now with bootstrap all sites look the same: compare ariya's site to http://nikola.ralsina.com.ar | 20:57 |
| thisfred | :) | 20:59 |
| alecu | ralsina: if you have a symlink pointing to a folder, then os.path.isdir returns True | 21:11 |
| alecu | ralsina: that may break some of the newer branches, won't it? | 21:12 |
| ralsina | alecu: we test for symlinks first | 21:12 |
| alecu | oh, right! | 21:13 |
| ralsina | really off to see olympic basketball now. Have fun1 | 21:13 |
| ralsina | ! | 21:13 |
| alecu | ralsina: when you get back: the isdir issue affects the control-panel branch; I've added some comments to it now. | 21:37 |
| ralsina | ralsina: thanks | 21:38 |
| ralsina | ralsina: I'll fix them tonight | 21:39 |
| mmcc | Hi guys, sorry I missed the discussion above - all the certificates have a commonName field, which you can get to using the .original property of twisted.internet.ssl.Certificate, which gives you a X509 object that behaves correctly: http://paste.ubuntu.com/1133292/ | 21:39 |
| mmcc | the twisted code that *should* wrap .original is not obviously broken, how much time should I spend on this? | 21:42 |
| mmcc | I mean, it's broken, it's just not obvious how | 21:42 |
| mmcc | OK, that paste was broken too. It looks like our go_daddy_class_2 cert has no commonName: http://paste.ubuntu.com/1133308/ | 21:49 |
| alecu | mmcc: exactly | 21:49 |
| alecu | mmcc: our certificate has the domain name in the field named "Certificate Subject Alt Name", instead of having it in the Common Name. | 21:52 |
| alecu | mmcc: so: I would suggest filling a bug in twisted, and not using repr for the time being. | 21:52 |
| alecu | mmcc: and I think we should not worry anymore about this | 21:53 |
| mmcc | alecu: done. we don't actually use their repr - I ran into this while debugging | 21:59 |
| alecu | mmcc: right | 22:00 |
| alecu | mmcc: I'm reviewing fix-1024623-install-confs | 22:10 |
| alecu | mmcc: I can't find run-mac-tests.sh | 22:11 |
| mmcc | alecu: ok, I'm around if you have comments | 22:11 |
| alecu | mmcc: should I be running run-tests.sh ? | 22:11 |
| mmcc | alecu: yes | 22:11 |
| mmcc | as it should be | 22:11 |
| alecu | oh, ok. I see that it's using the devtools from the eggs, so I probably have something broken there. | 22:12 |
| alecu | mmcc: I might have something broken... have you seen an error like this? http://pastebin.ubuntu.com/1133346/ | 22:14 |
| mmcc | alecu: no, that's not familiar… let me look | 22:15 |
| alecu | oh, it seems that u1trial considers "test_windows.py, test_linux" to be ONE module name. | 22:18 |
| mmcc | alecu, I'm puzzled. it looks like it's setting IGNORE_FILES correctly but then that's getting interpreted as one module name | 22:18 |
| mmcc | right | 22:18 |
| mmcc | maybe add a set echo to the script to see what's going on? do you have a dev-tools that parses arguments differently or something? | 22:19 |
| mmcc | checking now to see if mine is out of date | 22:20 |
| alecu | mmcc: probably! I think that dobey did some changes to the way dev-tools parsed the cmdline args | 22:20 |
| mmcc | I bet you have rev 77. I don't have it :) | 22:20 |
| alecu | mmcc: 77 it is! | 22:21 |
| mmcc | hrm, but I just updated to 77 and my control panel tests are still working | 22:21 |
| alecu | I just did "bzr switch -r 76", and I got a bzr stacktrace. | 22:22 |
| mmcc | arg | 22:22 |
| alecu | And now every bzr command that touches the disk dies with the same backtrace. | 22:22 |
| alecu | awesome! | 22:22 |
| mmcc | any good strategies for testing things that are set at import level? move them into a function? I'm looking at ubuntuone-storage-protocol/ubuntuone/storageprotocol/context.py -- where it sets ssl_cert_location at the top of the file | 22:38 |
| alecu | mmcc: I don't know what's a good global strategy, but for specifically this, it makes a lot of sense to move that to a function or three | 22:43 |
| alecu | mmcc: and also, we should probably be saving (in a singleton, or something similar) the value returned by get_certificates()... | 22:45 |
| alecu | hmmm... | 22:45 |
| alecu | well, it's not so expensive anyway. | 22:45 |
| mmcc | alecu: agreed (on moving to function). already started doing that. I'll add tests for the windows part too. | 22:45 |
| mmcc | yeah, I'm not sure it's called that often | 22:46 |
| mmcc | how many times do we create an ssl context? | 22:46 |
| alecu | the thing is that the 3 ssl certificates are loaded every time a "webclient" is created in SD. | 22:46 |
| alecu | that happens only when getting the list of published files, or publishing a new file, or some other thing I can't remember right now, but that is done as often. | 22:47 |
| alecu | so yes, this won't be a speed issue anytime soon. | 22:47 |
| mmcc | ok | 22:49 |
| mmcc | ok, have to go - I'll be back later to clean that up | 23:12 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
