| cjwatson | Sorry, could we please do this on the bug? This is a 4.5 year old sprawling bug with months-long hiatuses; switching back and forward between bug mail and IRC increases the probability of us forgetting stuff; plus I have to go to bed now and can't really spend the time to give a proper answer to these questions right now. | 00:07 |
|---|---|---|
| cjwatson | And you may be right that it's unnecessary but if so I'd really like both the question and the answer - i.e. answer including motivation for it - to be recorded | 00:10 |
| wgrant | Hm | 01:58 |
| wgrant | I wonder if I can mangle format-imports into a generic import mover | 01:58 |
| wgrant | (BugTaskSearchParams is moving out of bugtask.py) | 01:58 |
| michaelh | Hey, I'm getting a corruption error from zlib while doing an export | 01:59 |
| michaelh | Should two packs with the same hash have the same content? | 01:59 |
| wgrant | From bzr? | 01:59 |
| wgrant | That's probably more of a #bzr question | 01:59 |
| michaelh | Heh, wrong Canonical-ish channel, sorry | 02:00 |
| lifeless | wgrant: michaelh: yes, same hash - same content. | 02:00 |
| === michaelh is now known as michaelh|away | ||
| === michaelh|away is now known as michaelh | ||
| StevenK | OMGWTFBBQ | 02:03 |
| StevenK | structural subscriptions model is under bugs, but the JS for it is in registry? | 02:03 |
| wgrant | StevenK: It was all initially in Registry | 02:03 |
| wgrant | StevenK: Then the bug subscriptions work moved it into Bugs | 02:04 |
| wgrant | For reasons unclear | 02:04 |
| StevenK | Maybe they were going to impact branches too | 02:04 |
| wgrant | I mean the reason for the move was unclear | 02:05 |
| wgrant | They were going to work for blueprints etc. in the initial design | 02:05 |
| StevenK | Ah | 02:05 |
| lifeless | shiny | 02:16 |
| lifeless | https://status.heroku.com/ | 02:16 |
| === beuno_ is now known as beuno | ||
| === michaelh is now known as michaelh|away | ||
| === michaelh|away is now known as michaelh | ||
| === michaelh is now known as michaelh|away | ||
| === michaelh|away is now known as michaelh | ||
| === michaelh is now known as michaelh|away | ||
| * StevenK stabs the SS JS | 04:55 | |
| StevenK | wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/bugsubscriptionfilter-itype-ui/+merge/118472 | 05:39 |
| wallyworld_ | StevenK: i'm just about to run and and get the kid (i'm a bit late), i can look when i get back | 05:40 |
| wallyworld_ | StevenK: the _english_condition() method could be improved - you could pass in the list to extend as a parameter | 06:31 |
| wallyworld_ | it would avoid the unnecessary list creation | 06:31 |
| wgrant | Also, Proprietary isn't spelt like that. | 06:33 |
| StevenK | Bleh | 06:34 |
| StevenK | Those JS tests suck | 06:35 |
| wallyworld_ | StevenK: will this actually hook up to the back end and do something? | 06:37 |
| wallyworld_ | 342+ 'are of information type: '+filter.information_types.join(', '))); <-- you need a space around the + operator | 06:38 |
| StevenK | wallyworld_: Notice the existing pattern above, shall I fix those too? | 06:40 |
| wallyworld_ | yes please | 06:40 |
| wallyworld_ | while you are there | 06:40 |
| StevenK | wallyworld_: And yes, it hooks up to the model | 06:42 |
| wallyworld_ | cool, and it works? ie you tried it out? | 06:42 |
| wallyworld_ | normally i'd ask for a screenshot to be attached to the mp | 06:43 |
| StevenK | Yeah, I have tried it out. | 06:44 |
| StevenK | I can make a few screenshots, if you wish | 06:44 |
| StevenK | wallyworld_: ^ | 06:46 |
| wallyworld_ | StevenK: just one really - to show the new rendering of the info types in the popup, ie the expanded accordian | 06:47 |
| StevenK | Ah | 06:47 |
| wallyworld_ | it's hard to visualise | 06:47 |
| StevenK | Let me do that | 06:47 |
| wallyworld_ | thanks :-) | 06:48 |
| wallyworld_ | if there's anything else you fell would add value, feel free to include it :-) | 06:48 |
| StevenK | wallyworld_: MP description changed to include screenshot | 06:51 |
| wallyworld_ | .me looks | 06:51 |
| StevenK | Might change the 4 columns to 3. Not sure. | 06:51 |
| wallyworld_ | StevenK: looks good. i think 3 columns is better. it's on my todo list to get rid of those godaweful little lazr buttons from formoverlays | 06:53 |
| StevenK | wallyworld_: http://people.canonical.com/~stevenk/information_type_filter_3.jpg | 06:54 |
| wallyworld_ | much nicer! | 06:54 |
| StevenK | wallyworld_: http://pastebin.ubuntu.com/1133830/ | 06:55 |
| wgrant | wallyworld_: But those buttons are so nice and fiddly to click :( | 06:58 |
| wallyworld_ | StevenK: i'd rename the _english_condition method to _add_english_condition or something. my personal preference would be for the conditions list to go as the first argument but i'm not sure if we have a standard for that | 06:58 |
| StevenK | wallyworld_: You say as I push those changes .... | 06:59 |
| wallyworld_ | sorry :-( | 06:59 |
| wallyworld_ | wgrant: i'll do the change so that if the traversed path of the current content includes wgrant, you'll still get the little buttons | 07:00 |
| StevenK | Hahaha | 07:00 |
| StevenK | wallyworld_: http://pastebin.ubuntu.com/1133836/ | 07:01 |
| wallyworld_ | StevenK: looks, good, thanks. i'm surprised lint didn't pick up the spaces around the + in the js. you should include a == Lint == section in your mp | 07:03 |
| StevenK | I always check for lint before proposing | 07:04 |
| wallyworld_ | maybe the linter needs updating. i can't recall if it complains at me when I forget the spcaes. i know curtis picks it up. maybe we should hook him up as the linter to use | 07:06 |
| StevenK | wallyworld_: Sounds like https://wiki.canonical.com/Quotes/2011 -- search for 'Automation and Service Status' | 07:07 |
| wallyworld_ | lol | 07:08 |
| wgrant | StevenK: dogfood's running the fixed code, and seems pretty fast | 07:20 |
| wgrant | I've only specifically profiled the structsub queries, trying to track down the others now. | 07:20 |
| wgrant | But please throw rocks at it. | 07:20 |
| adeuring | good morning | 07:30 |
| bigjools | StevenK: I'm glad that most of my humour is too foul to get Quoted | 07:32 |
| === michaelh|away is now known as michaelh | ||
| === jpds_ is now known as jpds | ||
| === jamestunnicliff_ is now known as jamestunnicliffe | ||
| === michaelh is now known as michaelh|away | ||
| mgz | so... there are no tests for debbugs import, but I'm not allowed to say that right? | 11:52 |
| wgrant | mgz: You care about the debbugs externalbugtracker, not debbugs-import. | 11:53 |
| mgz | I'm looking at bug 1029294 which is tripping in lp.bugs.scripts.debbugs | 11:55 |
| mgz | fix looks trivial but I don't want to break the world. | 11:55 |
| wgrant | Ah | 11:56 |
| wgrant | Yeah | 11:57 |
| wgrant | That code is a bit old | 11:57 |
| wgrant | It may even be from Mark's original stuff in 2004. | 11:57 |
| wgrant | Not sure how much it's evolved, but looking at the code... probably not much | 11:57 |
| wgrant | Yeah, was introduced in Nov 2004, largely untouched since. | 11:58 |
| cjwatson | mgz: Have you checked the debbugs source to see what other changes are associated with summary version 3? | 11:59 |
| cjwatson | When I looked at that I couldn't actually find a record of such a version ... | 11:59 |
| cjwatson | So I was going to look on the master system when I got a chance | 11:59 |
| mgz | I have, the only one is a set of fields are no longer rfc 1522 encoded | 12:00 |
| cjwatson | That's summary version 2. | 12:01 |
| cjwatson | Isn't it? | 12:01 |
| mgz | summary version 2 encodes subject and so on | 12:01 |
| mgz | summary version 3 does not | 12:01 |
| cjwatson | Oh, yeah, I see it now. OK. | 12:02 |
| mgz | the launchpad code doesn't seem to handle any encoding regardless | 12:02 |
| mgz | so, we might get byte/unicode mix exceptions rather than harmless =?manging? without some extra handling | 12:05 |
| wgrant | mgz: We only do bugwatches nowadays, not imports. So we really only care about status/importance, probably. | 12:10 |
| mgz | that would simplify things, will grep around a bit | 12:13 |
| mgz | what is this nonsense... | 12:41 |
| mgz | ImportError: No module named auditorclient.client | 12:41 |
| mgz | why does launchpad want to import whatever that is when it's not in deps or pulled in by rocketfuel... | 12:43 |
| mgz | will branch the darn thing for now, but this seems borked | 12:45 |
| wgrant | mgz: Have you rerun buildout? | 12:55 |
| wgrant | 'make build' will do it | 12:55 |
| mgz | I ran 'make run' which depends on build.... | 12:58 |
| mgz | it's possible I hit a window where I somehow got the code change but not the dep update, but that seems backwards | 12:59 |
| wgrant | mgz: Possibly it didn't automatically buildout because of some timestamp thing. But the code and dep changes were in the same rev. | 13:03 |
| mgz | so, rerunning build picks it up... but this really screws up my nice automation when launchpad periodically needs manual intervention to fix things | 13:03 |
| mgz | especially as the fallout is non-obvious | 13:03 |
| wgrant | It's pretty obvious | 13:03 |
| wgrant | Missing dep | 13:03 |
| wgrant | => deps are probably out of date | 13:03 |
| wgrant | => buildout is out of date, since buildout manages deps | 13:04 |
| mgz | wgrant: so, I have the log from the original update, and that pulls in the source, but left lp in a borked state, want to take a quick look? | 13:06 |
| wgrant | mgz: Sure | 13:06 |
| mgz | okay, pastebin was a bad idea, slow for big things... | 13:13 |
| mgz | ...and then it timed out anyway | 13:16 |
| mgz | wgrant: on devpad.canonical.com:/home/gz/lp.log | 13:17 |
| mgz | so, that succeeded, but when I then went to run the tests later, auditorclient wasn't importable | 13:19 |
| wgrant | mgz: Looking | 13:23 |
| wgrant | mgz: Are you sure you were running the tests from the same tree? | 13:24 |
| wgrant | Because the webapp is unlikely to start in the situation that you described. | 13:25 |
| wgrant | And buildout was clearly run | 13:25 |
| mgz | wgrant: doh, yup, that's it, rocketfuel not getting lightweight checkouts paining me again | 13:27 |
| rick_h_ | adeuring: ping, you get the email on the skype call? | 13:31 |
| adeuring | rick_h_saw it a minute ago, online on skyke in a minute... | 13:32 |
| rick_h_ | jcsackett: stand up is over whenever you're ready to chat | 13:50 |
| abentley | abel: Since rick is busy, do you mind reviewing this? https://code.launchpad.net/~abentley/launchpad/same-queue-query-fmr/+merge/118428 | 13:51 |
| sinzui | jcsackett: rick_h_: While I know we are in an awkward be-ready-to-blue-sky sharing phase there are a few bugs in the current UI that would be nice to fix/avoid bug 1023427 | 14:33 |
| _mup_ | Bug #1023427: Sharing implies you can edit <disclosure> <javascript> <sharing> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1023427 > | 14:33 |
| rick_h_ | sinzui: thanks, will check it out | 14:34 |
| cjwatson | Any chance of a review of https://code.launchpad.net/~cjwatson/launchpad/report-pcj-oops/+merge/117601? I'll need to get that QAed before pushing up the fix for the second of that pair of critical bugs. | 14:45 |
| abentley | adeuring: Since rick is busy, do you mind reviewing this? https://code.launchpad.net/~abentley/launchpad/same-queue-query-fmr/+merge/118428 | 14:55 |
| adeuring | abentley: sure, I' | 14:55 |
| adeuring | ll look | 14:55 |
| abentley | adeuring: thanks. | 14:55 |
| abentley | cjwatson: I'll review it if you promise to update sampledata next time you land a DB patch :-) | 14:59 |
| cjwatson | Did I screw something up before? | 15:00 |
| abentley | cjwatson: You didn't update the sampledata to include distroseries on archivepermission. | 15:01 |
| cjwatson | Oops. Sorry about that. Duly promised. | 15:01 |
| cjwatson | Has that been done now? | 15:01 |
| cjwatson | (I mean, does it need me to do a follow-up branch?) | 15:02 |
| abentley | cjwatson: Yes, I landed it as part of my db patch. | 15:02 |
| cjwatson | Good, thanks. | 15:02 |
| abentley | cjwatson: r=me. | 15:04 |
| cjwatson | thank you. | 15:05 |
| abentley | cjwatson: np | 15:06 |
| adeuring | abentley: r=me, but I find it still scary that this fix is necessary... | 15:11 |
| abentley | adeuring: Thanks. | 15:12 |
| cjwatson | Oh, since you two are around: is celery in a state where new jobs could reasonably be deployed using it? | 15:12 |
| cjwatson | PackageCopyJobs might benefit. (Also, I was wondering if either of you knew if there's a reason why PlainPackageCopyJob.createMultiple doesn't poke celery.) | 15:13 |
| abentley | cjwatson: No, not yet. There was a problem with queues accumulating that we believe is now fixed, but is related to this branch I'm landing. | 15:13 |
| cjwatson | OK. Useful to know to calibrate my expectations ... | 15:14 |
| abentley | cjwatson: Yeah, hopefully with this landed, we can try to deploy celery job handling again. | 15:16 |
| jcsackett | sinzui: i can grab bug 1023427; this is just the on production w/o write enabled issue, correct? | 15:34 |
| _mup_ | Bug #1023427: Sharing implies you can edit <disclosure> <javascript> <sharing> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1023427 > | 15:34 |
| sinzui | no | 15:34 |
| sinzui | jcsackett: the choicesource widget adds the action/edit link to both the value and the EDITICON. +sharing's UI knows to hide the EDITICON node so we do not render an icon that claims you can edit, but the values are still linked. | 15:36 |
| sinzui | jcsackett: I think we need to consider changing choicesource to not linkify values as we need, or we rethink how +sharing renders all the choices | 15:37 |
| sinzui | jcsackett: The issue relates to https://bugs.launchpad.net/launchpad/+bug/568768 which has a lovely picture showing that Lp's inconsistency with what activates a choice causes madness in 8 out of 10 people | 15:39 |
| _mup_ | Bug #568768: Bug UI Inconsistancy <confusing-ui> <javascript> <lp-bugs> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/568768 > | 15:39 |
| sinzui | jcsackett: I think wallyworld_ had pondered a flag to choicesource config to no link the value. That might solve my immediate concern. I still hope to stop linking the bug status and importance to the popup | 15:42 |
| jcsackett | sinzui: bug status/importance? you mean on the bugs page instead of on the +sharing page? | 15:49 |
| sinzui | jcsackett: yes. A good plan will allow us to fix both pages | 15:50 |
| sinzui | jcsackett: on this picture: https://launchpadlibrarian.net/45059419/bug-incon.png the bug status and importance were linked to the popup. They should not be linked, or if they are, they are linked to search for more bugs of that status or importance | 15:51 |
| jcsackett | sinzui: got it. | 15:51 |
| jcsackett | sinzui: ok, i got you. was just confused as i was thinking in terms of +sharing, not in terms of choicesource. | 15:52 |
| sinzui | jcsackett: I am not asking for you to fix the bug page, I just want to you to check that a fix for +sharing could be reused on the other page to verify the design is good | 15:52 |
| jcsackett | sinzui: dig. | 15:53 |
| sinzui | Sorry for writing in cryptic curtisese | 15:53 |
| jcsackett | sinzui: all good, i can usually translate.:-P | 15:53 |
| === deryck is now known as deryck[lunch] | ||
| === gary is now known as Guest67056 | ||
| === Guest67056 is now known as garyposter | ||
| === garyposter is now known as gary_poster | ||
| === deryck[lunch] is now known as deryck | ||
| deryck | rick_h_, you reviewing at all now, or still UI-pairing? | 18:44 |
| rick_h_ | deryck: just losing all my UI work atm :/ | 18:46 |
| rick_h_ | deryck: what's up? Need a review? | 18:46 |
| deryck | rick_h_, that doesn't sound fun. And yeah, if you have the bandwidth. | 18:46 |
| rick_h_ | deryck: sure thing, linky please and I'll take a break being angry at the service | 18:46 |
| deryck | rick_h_, thanks! https://code.launchpad.net/~deryck/launchpad/reauth-for-email-363916/+merge/118612 | 18:47 |
| lifeless | o/ | 18:53 |
| rick_h_ | deryck: r=me with couple comments | 19:04 |
| deryck | rick_h_, thanks! | 19:05 |
| === michaelh|away is now known as michaelh | ||
| Ergo^ | evening | 21:42 |
| lifeless | hi | 21:46 |
| Ergo^ | gary_poster, hi just replied to your email | 22:02 |
| rick_h_ | man missed him | 22:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
