/srv/irclogs.ubuntu.com/2012/08/08/#ubuntuone.txt

=== mmcc_ is now known as mmcc
mptWhere do I report bugs in the U1 music store?09:54
mptoh, https://bugs.launchpad.net/ubuntuone-music-store09:54
gatoxgood morning!11:11
alecugood morning!11:49
gatoxalecu, good morning to you sir!11:51
=== zyga is now known as zyga-food
gatoxalecu, i have a branch stuck in approved since yesterday.... it has a commit message, and i didn't see any reason why it doesn't land...... but it's stuck there....11:53
alecugatox: I'm sure you've already tried putting it as "needs review" and back to "Approved", right?12:04
gatoxalecu, no..... i didn't know that trick..... trying...12:05
ralsinagood late morning!12:49
=== zyga-food is now known as zyga
mmccgood morning everyone.13:46
gatoxbrb13:46
ralsinamorning mmcc!13:50
gatoxback13:53
mmccAny opinions on the version number for the mac app? For test builds, should we have some per-build number, or include the date in it somewhere? There's both a numerical version number and a localizable string that we can put things like "build 20120808-12" into14:37
gatoxback..... i'm having some issues with my internet connection14:38
ralsinaeither tests are getting slower every day or I am getting more impatient every time I run them14:45
ralsinammcc: is there a separate version and build number?14:45
ralsinammcc: trunk is supposed to be 3.99.x but something like a date is a better idea at this moment14:47
gatoxralsina, i don't know which one it is.... but i'm having the same problem14:48
ralsinagatox: it seems to happen every few months, then someone wastes a week making them go fast again14:49
mmccsorry, had to step away for a sec.14:51
mmccralsina: there's a version number that has to be period-separated digits, then a "version string" that shows up in finder's get info box, that can be anything - convention is that it includes the version number14:52
mmccI just now made it throw the contents of revnos.txt into that version string, so it looks like this: "3.0.0 (ubuntu-sso-client: 988, ubuntuone-client: 1289, ubuntuone-control-panel: 343, ubuntuone-storage-protocol: 159)"14:53
mmccA little messy for distribution but seems handy for testing14:54
gatoxralsina, do you know how to run specific qt tests for u1-cp?? i forgot something..... or something change.... i'm trying to do: u1trial --reactor=qt4 path/to/test.py14:59
briancurtinme15:02
alecume15:02
gatoxme15:02
ralsiname15:04
ralsinathisfred, mmcc: say me15:04
mmccme15:04
thisfredni15:04
ralsinagatox: --gui ?15:04
gatoxralsina, don't know.... will try15:04
mmccralsina, gatox it's both - --gui and --reactor=qt415:05
briancurtinDONE: installer upgrade testing, 1-1, installer sent for testing15:05
briancurtinTODO: metaclass/next porting, 2to3 runs to see what else is left15:05
briancurtinNEXT: alecu15:05
gatoxmmmm it's failing with boths.....15:05
alecuDONE: reviews, finished a branch for bug #1031197, needing reviews itself15:06
alecuTODO: more tests of the ported protobuf with python3, catch up with py3k and briancurtin15:06
alecuBLOCKED: no15:06
alecuNOTE: I'm taking off this friday15:06
alecuNEXT: gatox15:06
ubot5`Launchpad bug 1031197 in ubuntuone-client (Ubuntu) "DownloadFinished signal triggers when file has not yet completed writing" [Undecided,Confirmed] https://launchpad.net/bugs/103119715:06
ralsinagatox: I'll help you after the standup15:06
gatoxDONE:15:06
gatoxPropose u1-client branches for sync menu (need reviews on this one: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu/+merge/118621)15:06
gatoxTODO:15:06
gatoxKeep working on u1-cp implementation.15:06
gatoxBLOCKED:15:06
gatoxNo15:06
gatoxralsina, go15:06
ralsinaDONE: calls calls calls (to the tune of Motley Crue's girls girls girls) reviews, some bug triaging, finished contract wrangling (twisted port on the way!)  TODO: fix a bug or two, reviews BLOCKED: no NEXT mmcc15:06
gatoxTODO: 1-1 with ralsina15:06
mmccDONE: cert loc code, reviews, looking at filemonitor bug15:06
mmccTODO: package for test builds, bug filing15:06
mmccBLCK: none15:06
mmccNEXT: thisfred15:06
thisfredDONE: cosas conflict resolution TODO: same BLOCKED: 1/2 (API decisions need to be made that I don't feel comfortable making all by myself, but I can continue on other aspects)15:06
alecuralsina: "(twisted port on the way!)" yay!15:07
ralsinathisfred: happy to give biased unfounded opinions on API matters15:07
thisfredralsina, in that case see the backlog in the internal u1db channel ;)15:07
ralsinathisfred: will do15:08
ralsinathisfred: it's LONG though15:08
thisfredyep :)15:09
alecummcc: did you find anything in the filemonitor bug?15:11
mmccalecu, well, I noticed that if you kill and restart syncdaemon, the files get uploaded. Still looking at what might be going wrong. I am suspicious of the RPC errors about on_upload_finished.15:12
ralsinathisfred: the idea of the extra argument in query calls feels natural, but it also feels strange in that, when would the user *not* want to know of conflicts?15:12
ralsinathisfred: although I am probably misunderstanding because I read it quickly15:13
gatoxcan anyone try this on u1-cp: u1trial --gui ubuntuone/controlpanel/gui/qt/tests/test_filesyncstatus.py ??? and tell me if that works for you?15:13
gatoxi'm probably doing something wrong.... but i don't know what15:13
gatoxi thought that should work15:13
ralsinagatox: --gui without reactor is not going to wrk for qt tests15:14
gatoxohhhhhhh long time without using both!!!!15:14
gatoxralsina, thx!!!15:14
gatoxthat's why you are the manager!!!! \o/ jeje15:15
ralsinagatox: jeje15:15
ralsinagatox: besides, alecu already told you that a ew minutes ago ;-)15:15
gatoxoh.... totally miss that meesage.... sorry alecu15:16
ralsinaAny pending reviews?15:16
gatoxralsina, yes please15:16
thisfredralsina, right. Problem is we can't do the extra argument, because the queries have a *arg parameter15:16
gatoxralsina, this one: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu/+merge/11862115:16
thisfredwhich means no keyword args allowed15:16
ralsinathisfred: ugh15:16
ralsinathisfred: ok, no good suggestions then15:17
alecugatox: ralsina, it was mmcc that said it, not me :-)15:17
thisfredralsina, discussing with aq now, but I think we're steering towards just always including the information on whether there are conflicts15:17
gatoxsorry mmcc then :P15:17
ralsinathisfred: that makes more sense15:17
ralsinathisfred: like I said, why would the caller not want to know that? :-)15:17
alecummcc: hmmm... if sd finds the files after being restarted, it sounds like some events were missed the first time.15:18
* gatox lunch15:18
=== gatox is now known as gatox_lunch
mmccgatox :) no prob15:18
ralsinaalecu, mmcc: could be that argument error is making it drop some events?15:18
thisfredralsina, I agree. The only reason it might not want to know if the app never syncs. Then why use u1db ;)15:18
ralsinathisfred: and willful ignorance is easy to achieve, just ignore the data ;-)15:19
alecummcc: that happesn because after the restart sd has a chance to rescan the filesystem.15:19
thisfredand it's easy to ignore, you'd just pay a tiny performance price15:19
thisfredright15:19
mmccalecu: on the first run,  it sees the file create, it generates a MakeFile, but no corresponding Upload log entry ever shows up.15:19
alecuralsina: which "argument error" ?15:19
mmccalecu, right- the restarted daemon sees the files in the local rescan15:19
alecummcc: oh, ok. Were you able to reproduce that consistently?15:20
ralsinaalecu: the "requires 2 arguments, received 3" ior something, it was in mmcc's log15:20
ralsinaalecu: it was on on_upload_finished, IIRC15:20
* alecu needs fosfovita15:20
mmccalecu, ralsina: 2012-08-07 12:12:46,689 - ubuntuone.SyncDaemon.Pb - WARNING - Could not emit signal 'on_upload_finished' to <twisted.spread.pb.RemoteReference instance at 0x10512ad40> due to 'on_upload_finished() takes exactly 2 arguments (3 given)'15:20
ralsinaOMG *my* fosfovita worked :-)15:21
ralsinatranslation: fosfovita is a minerals/vitamins pill that claims to improve memory because it has phosphorus15:21
* ralsina would rather lick a matchbox15:21
mmccmmmmmm phosphorus15:22
alecuralsina: remember to lick the matches, not the box!15:22
ralsinaalecu: all the phosphorus on safety matches is in the box :-)15:22
ralsinaalecu: that's why you can't light them in your boot like a cowboy15:22
alecuralsina: then why do we still call them "fósforos" ?15:23
ralsinaalecu: tradition15:23
* alecu tries licking a lighter15:23
ralsinaalecu: and because "little sticks with some thing that burns on the tip but is not phosphorus" is not marketable15:23
mmccralsina: you've heard of "I can't believe it's not butter," right?15:24
ralsinammcc: I even tried it!15:24
ralsinammcc: I totally believed it!15:24
alecummcc: I don't think that error has anything to do with the missed events problem.15:24
ralsinammcc: http://boingboing.net/2012/07/04/walmarts-i-cant-believe.html15:25
mmccalecu - ok, so it just gets logged and ignored, and doesn't leave anything wedged?15:25
ralsinaalecu: the other possibility that comes to mind is a semantic difference or out-of-order events15:26
ralsinaalecu: which is scary15:26
alecummcc, ralsina: right15:26
alecuralsina: remember that macfsevents does not get events for individual files, but for some changes in a folder15:27
ralsinaalecu: then maybe there is a bug in the code to figure out the diff15:27
alecuralsina: and it's synthezising (wow, that was hard) some events from the changes it sees.15:27
ralsinaright15:27
alecuhmmm\15:28
alecubut, mmcc says that the event was received. And it's just the Upload that's missing....15:29
mmccalecu - well, I'm not sure it's just the upload missing - I don't know what *should* be there. here's the log: https://pastebin.canonical.com/71687/15:29
ralsinaif there is a makefile, and no upload, maybe it thinks it's still open15:29
mmccI'm going to go log in to my u1 account in ubuntu and try the same thing and see what log messages I get so I know what's up15:30
ralsinaand/or the nanny is preventing the upload15:30
mmccralsina: if the nanny was blocking it, would there be a log message? there's no 'nanny' string in the log paste15:30
ralsinammcc: no15:30
briancurtinalecu: if you have a chance, would you mind running the tests on lp:~brian.curtin/ubuntu-sso-client/py3-unicode-part-3 to see what you get. this is that SyncTimestampChecker that is failing15:33
mmccIIRC you guys did a sprint a while back with presentations on syncdaemon, right? are those presentations around anywhere for me to refer to?15:33
alecummcc, it was more like a workshop, and there were no slides, sorry.15:35
mmccalecu: ok.15:36
alecuwe should definitely record it next time15:36
briancurtinmmcc: i have the hand-written posters and diagrams if you want them, but like alecu said, it was more of a workshop. there was a lot of talk going along with reading code15:36
mmccbriancurtin: hand-written posters and diagrams sounds great, got to be better than nothing15:36
briancurtinmmcc: i'll see if i can take good pictures of them or something15:37
mmccbriancurtin: oh, I thought you already had pics :) ok, but take your time - and don't worry too much about quality15:38
alecubriancurtin: here, right? test_server_date_sends_nocache_headers16:17
briancurtinalecu: yep, that's the one16:17
alecubriancurtin: I get the same 500. I'll take a further look.16:17
briancurtinalecu: the odd thing is that i do what that test does in the interpreter just fine. i can also use urllib to hit that URL just fine. it only seems to fail when run in the test suite :/16:18
alecubriancurtin: what is the url?16:18
ralsinalunchtime16:19
briancurtinalecu: "http://one.ubuntu.com/api/time"16:19
alecubriancurtin: I think we should not be hitting that from the tests. We should be using a mock webserver if needed.16:20
briancurtinalecu: i don't disagree, but this should work. it works fine on trunk16:20
alecubriancurtin:         self.patch(SyncTimestampChecker, "SERVER_URL", self.ws.get_iri())16:21
briancurtinit also works if you just open up an interpreter, import that, and call get_server_time just fine16:21
alecubriancurtin: so, we are not using that url in the test, as it's being patched.16:21
briancurtinalecu: ah16:22
alecubriancurtin: one more thing: I *think* this code is not used anymore.16:25
alecubriancurtin: oauth_headers and the timestamp_checker module instance of SyncTimestampChecker16:26
alecubriancurtin: right. I think I forgot to get rid of the SyncTimestampChecker when it was no longer needed. I surely seem to have gotten rid of the AsyncTimestampChecker.16:27
briancurtinalecu: ah, well then that makes this easier. im doing a double check that we dont need it. i think you're right16:28
alecubriancurtin: I've done a quick grep in u1-client and u1cp and they are not used either.16:29
=== gatox_lunch is now known as gatox
briancurtinalecu: cool16:29
alecubriancurtin: I think we should do a branch to delete both, and see if anything breaks. And if it breaks, it should be using the new webclient anyway.16:30
briancurtinalecu: i'll go that route and take SyncTimestampChecker out outside of the unicode branch16:31
alecuthis netsplitting is just awesome.16:46
alecubriancurtin: don't know if this reached you:16:46
alecu<alecu> briancurtin: I think we should do a branch to delete both, and see if anything breaks. And if it breaks, it should be using the new webclient anyway.16:46
alecu<alecu> briancurtin: would you mind creating a bug for this and assigning it to me?16:46
alecu<alecu> briancurtin: you can skip those fixes in this branch. Thanks for finding it!16:46
briancurtinalecu: now i got it, and i'll create the bug shortly16:47
alecuthanks :-)16:47
gatoxalecu, dobey is on vacation?16:48
alecugatox: calendar says he returns tomorrow16:49
alecuhey! it's joshuahoover's birthday today!16:49
gatoxalecu, ok..... usually he knows with the branches are not landing :P16:49
alecugatox: we should probably ping sidnei about tarmac when dobey is not around16:50
aleculunch time for me.16:53
ralsinagatox: 1-1?17:32
gatoxralsina, right!17:32
gatoxmumble or irc?17:33
ralsinamumble17:33
gatoxralsina, ack17:33
mmccok, early lunch here. back in a bit17:39
ralsinammcc, briancurtin, gatox, alecu: any reviews pending?18:08
gatoxralsina, nop18:09
briancurtinnone at the moment18:09
alecuralsina: https://code.launchpad.net/ubuntuone/+activereviews18:09
gatoxralsina, ahhhh yes, tihs one: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu/+merge/11862118:09
ralsinaalecu: prefiero el human touch ;-)18:09
gatoxralsina, i thought you already approve it18:09
alecuralsina: https://code.launchpad.net/~alecu/ubuntuone-client/fix-download-finished/+merge/11875918:09
briancurtinalecu: i created bug #1034528 for that SyncTimestampChecker. working on it right now18:09
ubot5`Launchpad bug 1034528 in Ubuntu Single Sign On Client "Remove SyncTimestampChecker" [Undecided,New] https://launchpad.net/bugs/103452818:09
ralsinagatox: no, seen it but not reviewed it entirely yet18:09
ralsinaalecu: got it18:10
gatoxralsina, ahh ok18:10
alecubriancurtin: ok, great. I can work on that if you want to keep going over the unicode branches.18:10
ralsinagatox: will +1 as soon as I run the tests18:10
gatoxralsina, ack18:10
* alecu has just conflated py3 and unicode.18:10
alecuI wonder how much of that is true :P18:11
briancurtinalecu: it seems easy enough. i just started on it a few mins ago18:11
alecubriancurtin: great then.18:11
ralsinaalecu: unicode in python2 is gatox, so you can conflate them only in some cases ;-)18:12
ralsinagrrrr I have to check the assertIn argument order every time I run into it18:19
ralsinayes, it's arg1 in arg2 but then that reads "assertIn needle, haystack" which makes my eyes stumble18:19
alecuralsina: I always remember that bit (thanks fosfovita), but I never type it right.18:28
ralsinagatox: +118:29
gatoxralsina, thx18:30
ralsinaalecu: have to love a 5-line patch with 55 lines of tests, right? :-)18:31
aleculol18:31
alecuI had to refactor one of the tests, that's why :-)18:32
alecuand yes... 11:1 is too high. Usually it's 3:1 or 4:118:33
ralsinaat least the problem seems well contained :-)18:35
ralsinaalecu: +1 ran tests only on linux though18:35
alecuthanks18:36
mmccralsina: I have another high test-to-code branch for you: https://code.launchpad.net/~mikemc/ubuntuone-storage-protocol/fix-1025950-cert-locs/+merge/11860318:50
mmcc(because there weren't tests before)18:50
ralsinammcc: got it18:50
ralsinammcc: he18:50
ralsinammcc: storage protocol is mostly very old code before we got religion18:50
gatoxralsina, as some parts of u1-client.......18:53
ralsinagatox: on some parts of u1-client I expect to see *mold*18:54
gatoxjeje18:54
* mmcc just wrote "import tracebacon". 19:06
beunommcc, did it work?19:08
alecuit's just a whiff away19:11
mmccsadly, no… it did not work.19:16
briancurtinalecu: so i'm looking at this SyncTimestampChecker removal...it doesn't look like TimestampChecker is intended to be used by itself, so it doesnt seem as easy as just replacing its use19:26
briancurtinunless im misunderstanding it19:27
briancurtinit looks like its consumed by BaseWebClient, but i dont think the places which used a timestamp checker want a BaseWebClient (or other web client)19:27
mterryAre U1 oauth credentials stored in my home directory?19:28
mterryAh, in the keyring I bet19:30
gatoxalecu, when you have a moment:  https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/refactor-sync-status/+merge/118809  -  https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu/+merge/11862119:33
alecuhey all, ralsina has just smsd me: his house ran out of power19:43
briancurtinthat sucks19:43
gatox:S19:44
alecubriancurtin: afaik SyncTimestampChecker is not used anymore.19:45
alecubriancurtin: only TimestampChecker is used nowadays.19:45
briancurtinalecu: there were a few things that seem to have been using SyncTimestampChecker this whole time. they were getting it from utils.timestamp_checker, which pointed to an instance of SyncTimestampChcker19:46
alecubriancurtin: I can't find any usage of that timestamp_checker other than the tests for it19:54
alecubriancurtin: in ussoc, in u1c nor in u1cp19:54
alecuand u1sp19:54
alecubriancurtin: in which module did you find that usage?19:55
briancurtinalecu: maybe i'll post the branch in a minute. i removed STC and its tests, but things are still depending on utils.timestamp_checker19:55
alecuack19:55
briancurtinalecu: i guess it's just line 207 in ubuntu_sso/utils/tests/test_common.py - it patches that utils.timestamp_checker (which would be SyncTimestampChecker)19:58
briancurtinalecu: and the oauth stuff in ubuntu_sso.utils then uses timestamp_checker, which is the SyncTimestampChecker19:59
alecubriancurtin: right. And that oauth_headers method is not used anymore either.20:01
alecubriancurtin: I rolled up both into the new webclient.20:02
briancurtinalecu: alright, i'll remove that then see what happens20:02
alecubriancurtin: previously every webclient user would check the timestamp and would sign oauth.20:02
alecubriancurtin: with the new one, this is done automatically by the webclient.20:03
briancurtinalecu: so i should then remove the entire SignWithCredentialsTestCase? because that was still using oauth_headers20:04
alecubriancurtin: it looks like it should be gone, yes.20:11
briancurtinalecu: ah there we go, i think it's good now20:13
alecugreat20:13
briancurtini guess that was easier than i thought...it seemed like a whole bunch of important stuff to just be ripping out20:14
gatoxeod here!!! bye all!20:16
ralsinahello again, sorry, was out of power & internet20:20
=== mbarnett` is now known as mbarnett
alecuhello back there, boss.20:28
briancurtinalecu: when you have a minute: https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/remove-SyncTimestampChecker/+merge/11882620:49
alecubriancurtin: looking20:55
alecubriancurtin: small needsfixing20:57
alecubriancurtin: we should also remove the unused imports20:57
alecuok, EOD here.21:00
alecucheers, all!21:00
ralsinabye alecu!21:12
ralsinaEOD for me as well. bye!21:22
mmccok, I'm done for today. see you all tomorrow22:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!