/srv/irclogs.ubuntu.com/2012/08/13/#ubuntuone.txt

dpmhey all, good morning!08:13
dpmI bought a bunch of songs on the U1 store in Rhythmbox last night. Some of them were downloaded with a size of 0 bytes, and are obviously unplayable. Is there a way to retrigger the downloads? Or else, how can I fix this?08:13
mandeldpm, hm.. I've heard about a similar problem..09:02
dpmmandel, do you know whether the downloads can be retriggered, or the best person I should talk to?09:04
mandeldpm, how big is you u1account?09:04
mandeldpm, one possible way, although is brute force, would be to stop syncdaemon, then remove the metadata and de 0byte files and then start it again09:05
mandeldpm, but wait and we can talk with rye09:05
mandeldpm, he is the persona that is good at this type of weird problems09:05
dpmmandel, thanks. Yeah, I've got about 30GB on my account, and I'm on a relatively slow connection, so I'd rather prefer avoiding re-syncing everything for just 4 or 5 songs :)09:07
mandeldpm, if you just delete the bad songs and not the rest it wont have to download it, it will check that you have files in the machine compare the hashes and not download them09:08
mandeldpm, but before that deleting the metadata09:08
mandeldpm, let me see if there is a more obvious way to do it..09:08
dpmok, thanks mandel!09:10
mandeldpm, no problem, I might take a little to get back to you, I just got back from holidays and I'm dealing with a crazy inbox :-/09:11
dpmmandel, no worries, did you have a good holiday?09:13
mandeldpm, yes, going to mallorca is always great :)09:14
dpmah, back home, right? Nice :)09:14
mandeldpm, yes, it was great, maybe too short hehe09:14
dpm:)09:14
ryedpm: i joined a bit late..09:15
dpmrye, no worries, there's no rush09:15
ryedpm: so, can you PM me your e-mail so that I look your account up and ask the vendor to process the refund for these broken songs09:16
dpmrye, sure, but is there no way to re-download the songs? If possible, I'd prefer that over a refund09:16
brendandanyone know why the files client is crashing on iOS 5?09:24
mandelbrendand, the developers that know about the ios app are in the usa, you will have to wait a little longer to get their help09:43
=== __chip__ is now known as Chipaca
=== yofel_ is now known as yofel
gatoxgood morning!11:14
mandelgatox, morning!11:14
gatoxmandel, hi!11:14
mandelgatox, have I missed anything interesting these days?11:14
gatoxmandel, yes, you were fired..... nobody told you?11:15
gatoxjeje11:15
gatoxmandel, mmmmm let me think11:16
mandelgatox, I still get the email.. so I guess I still have the bad part of the work ;)11:16
gatoxmandel, things are moving into the python3 direction..... and we have feature freeze on the 24th11:16
mandelgatox, ok, and mac, any news?11:17
gatoxmandel, mmm nothing new as far as i remember11:18
gatoxmandel, i have the feeling that you want to do a review :P please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-status-actions/+merge/11917011:30
mandelgatox, sure!11:30
gatoxalecu, PING.... (when you are here please!!)11:30
mandelgatox, in line 103 of the diff, what happens if the backed does not have the backend methods, should you be adding None as the default result to avoid the attr error?11:49
gatoxmandel, later i do: if self._backend_method is not None:11:50
gatoxmandel, or what do you mean?11:52
mandelgatox, no, that is not the problem, if you do self._backend_method = getattr(self.backend, data['backend_method']) and data['backend_method'] is 'paquito' and there is not method no attr named paquito you will get a AttributeError11:52
gatoxah yes11:52
mandelgatox, you should do getattr(self.backend, data['backend_method'], None) so that if the method is not there you get None :)11:52
gatoxahhhhh roger that11:52
mandelgatox, adding it to a comment so that we have history of the review :)11:53
gatoxmandel, fixed11:55
mandelack11:56
mandelgatox, when running the tests, do you get lots of tray icons?11:57
gatoxnop11:57
gatoxlinux, windows?11:58
gatoxahhhhh yes11:58
gatoxdidn't notice that before11:58
gatoxbut they get close at the end11:59
mandelgatox, yes, is no a major pita11:59
mandelgatox, probably means that the code that does the x11 buffering does not do it for the tray icon11:59
mandelgatox, also I added a comment, I'm getting a lint issue in P11:59
gatoxmandel, no....... the lint issue is because you didnn't read the description :P12:00
mandelgatox, uh, there is code in u1client too.. ok12:01
mandelgatox, other question, what is happening here: http://paste.ubuntu.com/1144725/12:05
mandelgatox, icon is never going to be none unless  QtGui.QIcon() returns None, is that possible?12:05
gatoxahh right.... that is something that ended that way because of some previous code i was doing12:07
gatoxthe right way is: if icon_name is not None12:08
gatoxmandel, pushed12:08
mandelgatox, awesome, one last question, is you do QLabel.setText(None) what happens, it works ok, right?12:09
gatoxyes12:10
mandelok12:11
gatoxbecause it takes the none as the parent arg12:11
gatoxbut we are assigning the parent later always anyway12:11
mandelok12:13
mandelapproving then12:13
mandelgatox, I'm off to go for lunch, will take a little longer since I have not food at home after the holidays..12:33
gatoxmandel, hehe ok12:33
gatoxmandel, don't go to eat sushi please :P12:33
ralsina_good morning!12:44
gatoxralsina_, hi12:46
thisfredralsina_, buenos! I have added the itemClicked handler and pushed, that works great12:53
ralsina_thisfred: cool, I'll take a look ASAP12:54
thisfredthx!12:54
ralsina_thisfred: +113:04
thisfredgracias13:04
dobeyhmm13:09
gatoxralsina_, already file the swap from october 8 to december 28 correctly...13:11
ralsina_gatox: awesome13:12
=== m_conley_away is now known as m_conley
* mandel back13:23
mandelralsina_, 1-1 when ever you please, AFAIK we have it today :)13:24
mandeldobey, may I have a re-review for: https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/long-domain-socket/+merge/11626913:24
dobeymandel: you didn't fix my issue :)13:27
dobeyoh13:27
mandeldobey, there is not just constant present in darwin13:28
dobeyi meant the path == NULL13:28
dobeyoverlooked that comment, sorry :)13:28
mandeldobey, no problem, I do that all the time :)13:28
mandeldobey, I'm not the one that should ever complain about not reading comments or typos :P13:28
dobeyheh13:30
dobeyanyway, gave it +1 now13:30
mandelthx!13:30
mandelalecu, gatox, ralsina_, briancurtin, you guys noticed that the windows port is broken on jenkins as from friday?13:31
gatoxmandel, nop13:32
ralsina_mandel: noticed very late on friday13:32
mandel:(13:32
mandelI wonder what happened..13:32
brendandhas anyone had problems with the iOS files application recently?13:42
brendandfor me i open it and it crashes after a few seconds13:42
mandelurbanape, ^13:43
mandelbrendand, urbanape can give you a hand with it13:44
urbanapebrendand: hi, here to help13:44
urbanapeDo you have the latest version from the App Store?13:45
brendandurbanape, yep. first thing i did was to uninstall and reinstall13:45
dobeydoh; have to remember to call and arrange shipping for this thing today13:47
urbanapebrendand: do you have a Mac or Windows machine running iTunes? We have yet to add some in-app diagnostics so we can pull crash logs directly.13:48
brendandurbanape, yeah give me a few minutes. i'll ping back when i'm ready13:48
urbanapethanks13:48
alecuhello, all!13:49
dobeyholas alecu13:51
gatoxalecu, hi!!!! i was waiting for you!!!!13:51
mandelalecu, buenas!13:51
gatoxalecu, could you please re-review this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu13:51
gatoxalecu, this one is avoiding my u1-cp  branches to land cause of lint issues13:52
gatoxthat depends on that branch13:52
ralsina_alecu: you missed a call. Don't worry too much though.13:52
alecuralsina_: ouch. I had to run some errands downtown, and it took a loong while to get there and back. :-(13:53
alecuralsina_: sorry all13:53
ralsina_alecu: like I said, no problem, really13:54
=== ralsina_ is now known as ralsina
alecugatox: small needs fixing14:13
gatoxalecu, ack14:13
brendandurbanape, i'm ready to go. sorry it took a while14:41
ralsinaalecu: so, bad news about the windows build testing from elopio, it looks like we still have some bits that don't use the proxy14:43
urbanapebrendand: that's okay. Do you normally sync your phone to this iTunes?14:43
alecuralsina: ugh14:43
ralsinaalecu: my exact guttural noise14:44
alecuralsina: is there a mail about that?14:44
ralsinaalecu: yes, you are probably not on it, let me forward14:44
ralsinaalecu: sent14:45
alecuthanks14:45
brendandurbanape, yeah14:46
urbanapeokay, if you have time, go ahead and sync it with iTunes now (unless it did automatically when you connected it)14:46
ralsinaalecu, dobey, gatox, mmcc, thisfred, briancurtin, mandel: standup in 7'14:54
mandelack14:54
gatoxack14:54
thisfredyak14:54
briancurtini'll be there14:54
gatoxme15:00
dobeyme15:00
thisfredme15:00
briancurtinme15:00
ralsiname15:01
dobeymandel, alecu:15:02
mandelme15:02
alecume15:02
mandelmmcc seems not to be here15:02
dobeyralsina: you mentioned mmcc, but he's not here (on holiday today)15:02
dobeymandel: right, he's on holiday today15:02
dobeygatox: go?15:03
gatoxDONE:15:03
gatoxFixed u1-client menu branch. Propose a couple of branches for u1-cp menu feature. Finishing another one.15:03
gatoxTODO:15:03
gatoxFinish with u1-cp menu branches. Propose a branch for macfsevents in github.15:03
gatoxBLOCKED:15:03
gatoxNo15:03
gatoxdobey, go15:03
dobeyDONE: reviews, proposed u1db in universe15:03
dobeyTODO: poke about u1db package, rush to get everything done for feature freeze, reorg to drop ubuntuone-installer for good, SRUs for lucid/natty/oneiric15:03
dobeyBLCK: None.15:03
dobeythisfred: go15:03
ralsinaforgot about mmcc's day off15:03
ralsinaTHISFRED! ;-)15:04
thisfredDONE: conflict resolution in cosas TODO: u1db documentation. Lots of it. BLOCKED: no NEXT: dobey15:04
briancurtinDONE: holiday15:04
briancurtinTODO: catch up with a few comments on thursday's last Python 3 merge proposals, start actually running SSO on Python 315:04
briancurtinNEXT: ralsina15:04
ralsinaDONE: 1-1s, canonicaladmin, reviews, helped around, some bug triaging, extra dash call, misc. TODO: tech leads, reviews, fix a bug hopefully BLOCKED: no  NEXT mandel15:04
mandelDONE: Holidays. Catched up with email after days off. Reviews. Upgraded to montain lion. Cry because Xocde 4.4 set all the project targets to 10.8 (stupid apple!!)15:05
mandelTODO: Fix the state of the daemon project after update. Go after people for reviews. 1-1 with ralsina. Is my review day.15:05
mandelBLOCKED: no (although considering no to use getoptlong for testability reasons).15:05
mandelalecu, please15:05
alecuDONE: small vacation at GualeguaychĂș15:05
alecuTODO: catch up with mail, help briancurtin get sso running on py315:05
alecuBLOCKED: no15:05
mandelralsina, 1-1 now before you have other meetings?15:05
ralsinaalecu: tech leads is now15:05
ralsinamandel: I am busy for about 1 hour15:06
mandelralsina, ping me when done I should still be here :)15:06
ralsinamandel: thanks15:06
mandelralsina, no problem :)15:06
brendandurbanape, it's all synced15:13
urbanapeokay, is this Mac or Windows?15:13
briancurtinalecu: for that py3-callable branch, you're totally right. as for the branch, should i reject the MP and then set the branch status to abandoned...or just delete the branch all together?15:14
brendandurbanape, to be exact a windows xp vm15:14
urbanapebrendand: You can use this document to find the pertinent crash logs: http://aplus.rs/apple/how-to-find-crash-logs-for-iphone-applications-on-mac-vista-and-xp/15:14
urbanapeif you can zip those up and send them to me (zachery.bir@canonical.com), I'll take a look, thanks!15:15
alecubriancurtin: rejected+abandoned for this sounds right, since it serves as a reminder of what bits we should be changing (or not) next cycle when we port the other u1 projects.15:23
briancurtincool, done15:24
gatoxalecu, this branch is fixed: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu/+merge/11862115:25
gatoxalecu, and i also have 2 more branches for review..... i don't know if you want to review them, or do you prefer that i ask someone else...15:25
alecugatox: I'm otp right now... you don't mind if I review them later, right?15:26
alecugatox: try forcing mandel to do them, since he's back from vacations, and he loves doing reviews!15:26
gatoxalecu, no..... if you want i can ask someone else for the control panel branches... the important one for me is the u1-client that is blocking the others15:27
ralsinaalecu, gatox: and it's his review day ;-)15:27
mandeland is my review day.. although I don't love them alecu15:27
gatoxralsina, if you have a moment (mandel already review that one): https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-status-actions/+merge/11917015:27
alecuoh, this reminds me I should find some way to send money to mandel, so he can get me the "game of thrones board game" when he comes for pycon!!!!!15:27
ralsinagatox: not immediately, but in a while15:27
mandelalecu, haha I need to ask for a place to stay :P15:27
gatoxralsina, yes, no problem! thankx15:27
alecumandel: but we love you!15:27
gatoxthanks15:28
urbanapebrendand: received. I'll let you know15:28
mandelgatox, any review do send them my way :)15:28
ralsinamandel: I would offer you my couch, but I live right across the universe from pycon15:28
alecumandel: I have rented the flat with cold water you used last time... I'll try to find some other place, though!15:28
urbanapebrendand: you said it crashes immediately on launch?15:28
gatoxmandel, i have this one: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/119370 but i was expecting for launchpad to end updating the diff to review it myself first15:28
brendandurbanape, no15:29
mandelralsina, hehe worst case scenario I can take the sofa :)15:29
urbanapepauses for about 10 seconds and then crashes?15:29
mandelalecu, don't worry too much hehe15:29
ralsinamandel: mi casa es tu casa15:29
dobeymandel: i hope he has insurance15:29
brendandurbanape, yes15:29
gatoxmandel, you can stay here..... but you will need to take a flight everyday :P15:29
mandeldobey, I'm not that badly behaved!15:30
mandelgatox, thx for the offer.. but I pass :P15:30
urbanapebrendand: I'm assuming you enabled auto-upload, yeah?15:30
gatoxmandel, jeje15:30
brendandurbanape, yes15:30
urbanapeit's probably consuming too much time trying to walk your camera roll (guessing you have over 1,000 items in the camera roll?)15:30
brendand52015:31
urbanapewhat device?15:31
brendand4s15:31
urbanapethat's really weird.15:31
urbanape520 is nothing. I have 5,000 items in my camera roll, and don't get the 10s crash. Lemme think on it.15:32
ralsinamandel: there's a bunch of cheap places in airbnb15:32
mandelralsina, it should not be a huge problem, is a matter of looking :)15:36
dobeyalecu: for bug #1032336 i'm wondering how much of the code i need to write tests for. for example, having tests for the OptionParser class, I wonder if the derived classes which simply define options to use, actually need a test for exery single option? and i'm kind of curious as to what the best way to test the test runners whil running the tests with the test runners, would be exactly :)15:45
ubot5`Launchpad bug 1032336 in ubuntuone-dev-tools "New options parsing needs more test coverage" [Undecided,Triaged] https://launchpad.net/bugs/103233615:45
gatoxmandel, just in case, i've made some changes in the docstrings of this brnach: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/11937015:45
gatoxnow is up to date15:45
mandelok15:46
* gatox lunch/15:46
=== gatox is now known as gatox_lunch
mandelgatox_lunch, how do you feel about this: http://paste.ubuntu.com/1145069/15:58
mandelI'm just very lazy15:58
gatox_lunchmandel, mmmm i can be wrong... but for me... that adds more confusion than clarity to the code16:01
mandelgatox_lunch, I prefer it, but is a personal thing, I don't like lots of line that are exactly the same is more error prone for me16:05
mandelgatox_lunch, with the loop way I know I have to make sure the couples are right, in the other I have to read all the call to do it, but again, is a personal thing16:06
ralsinamandel: mumble?16:11
mandelralsina, sure16:12
ryemandel: bug #1036270 goes to?..16:12
ubot5`Launchpad bug 1036270 in Ubuntu Single Sign On Client "[nightlies] SSL errors crash ubuntu-sso-client" [Undecided,New] https://launchpad.net/bugs/103627016:12
mandelrye, no idea, desktop+ and we will sort it out later16:13
dobeyok, i'm off to get lunch. bbiab16:29
mandelgatox_lunch, review done, some needs fixing there16:30
ralsinagatox_lunch: +1 on menu-status-actions16:30
mandelgatox_lunch, looks like there is some code duplication, because I already mentioned those errors, right?16:31
czajkowskimandel: boo :)16:32
mandelczajkowski, lol16:32
mandelgatox_lunch, if it is the same code I think a base class sounds like a logical thing to do16:40
ralsinalunch time for me.16:51
=== gatox_lunch is now known as gatox
gatoxmandel, checking....16:56
gatoxmandel, it wasn't code duplication..... i forgot to merge with that branch after the changes17:06
gatoxdone17:06
gatoxchecking the other comments17:06
mandelgatox, the removal of the inlineCallbacks makes sense, right?17:08
gatoxmandel, i thought that i remove that tests.... (i need to learn bzr pipeline)..... that test shouldn't be there17:10
gatoxis not doing anything useful17:11
mandelgatox, is that an older pipe?17:11
chaselivingstonHi folks, just wanted to introduce myself. I'm the new support person for U1, getting acclimated and introduced to the community as much as I can17:11
mandelgatox, did you do a pump so that changes from earlier branches are push to later ones?17:11
gatoxmandel, the problem is that is not a pipe..... i'm doing independent branches17:11
mandelgatox, ah, then I cannot help you :)17:12
mandelchaselivingston, hola, bienvenido! (that is welcome to the land of the spanish speakers :P )17:12
chaselivingstonmandel: Thanks!17:12
gatoxmandel, ok.... everything is fixed now..... except the "personal thing".... maybe we can ask alecu for his opinion.... but i personally prefer to leave it as it is... i think is more clear and easier to check looking at the code that everything is properly connected, etc17:13
mandelgatox, so we need a third vote :)17:15
gatoxmandel, or maybe ralsina if alecu is busy17:15
gatoxi don't want to get block for that17:15
gatoxthe rest of the changes are already pushed17:16
mandelgatox, or briancurtin2 I'm sure he writes more pythonic code than we do :)17:16
gatoxmandel, yes, but i was thinking from the ui eye too17:16
gatoxto see the code and identify stuff17:16
mandelbriancurtin2, can you look at the last part of my needs fixing: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/119370 and vote :)17:16
briancurtin2mandel: sure17:17
mandelgatox, well, the problem I have with that is since I'm a little dislexic I wont see an error at all when there are some many char repeated in the lines :P17:17
alecugatox: what is the "personal thing" you mentioned? I'm lacking context!17:26
alecuchaselivingston: hey, welcome to the team!17:27
gatoxalecu, here: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/11937017:27
mandelalecu, last comment from me here:  https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/11937017:27
mandelalecu, I prefer the loop because my eyes go nuts when I see that much text and I assume that everything is ok17:28
gatoxalecu, sorry for being annoying..... but when you have a moment, please review this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-client/ipcmenu/+merge/118621  is blocking me 3 branches17:31
alecugatox, mandel: Both ways look readable. I like the first one more, because I like "data as code"; but it's more verbose, so I really don't have an opinion.17:31
alecugatox: yes, I reviewed that other branch... three hours ago! I'll get to re-review it soon, have some patience!!!! :-)17:32
mandelalecu, gatox I won't block for that, so +1. did you check why is there duplicated code gatox ?17:32
gatoxalecu, jeje ok, sorry17:32
gatoxmandel, it wasn't duplicated..... i forgot to merge with the previous branch..... already done17:32
mandelgatox, ok :)17:33
mandelthen, EOD here, is to hot and madrid is empty17:33
gatoxmandel, ok..... bye mandel!17:33
mandelralsina, have fun with the spaniard, he seems weak :P17:33
=== briancurtin2 is now known as briancurtin
chaselivingstonalecu: Thanks!17:42
dobeyalecu: hey. did you see my question earlier re: dev-tools tests?17:52
alecudobey: oh, I'm looking now, sorry.17:54
dobeyalecu: no worries. thanks17:55
* briancurtin lunch18:01
ralsinaalecu SMSd me that his internet is down18:23
ralsinaunless he's back of course ;-)18:23
dobeyi guess that's why he hasn't said anything else to me :P18:24
dobeyhrmm18:33
ralsinabriancurtin: I am really undecided about whether we should release 3.0.2b or not18:37
ralsinabriancurtin: it doesn't fix syncing but it does make u1cp work behind a proxy :-/18:37
briancurtinralsina: i don't know nearly enough about proxies to know if that's good enough for what people want out of it. sounds like it's probably not good18:38
ralsinabriancurtin: yep, and it triggers a big download for everyone18:38
ralsinabriancurtin: please kill the RT :-(18:38
ralsinajoshuahoover: we are not going to release 3.0.2b will try to do a real bugfix and do a real release then18:39
joshuahooverralsina: ok, can you update the rt ticket then?18:39
briancurtini'm commenting now18:40
ralsinajoshuahoover: asked briancurtin to do it18:40
dobeybriancurtin, ralsina: what are the remaining issues that we need to get in for doing a 3.0.3 release? next monday is 3.99.x release day btw, as feature freeze is next week18:40
joshuahooverralsina: does he have someone he get ask to do it so we can get a giant chain of "delegation" going? ;)18:40
ralsinajoshuahoover: I think he has a dog :-)18:40
joshuahooverralsina: perfect!18:41
ralsinadobey, joshuahoover, gatox: we are going to need a FFE for the "publish files" tab.18:41
ralsinaand perhaps one for the sync menu stuff in some form or another18:42
dobeywe have a publish files tab?18:42
ralsinadobey: we have a design for one, and it's easy-ish to do18:42
dobeysweet18:42
ralsinadobey: and solves the classic "what files am I sharing?" issue18:42
dobeythen we can just remove the nautilus extension18:42
ralsinadobey: that's the secret plan18:42
dobeyand nautilus18:42
ralsinadobey: tell noone18:43
dobeyralsina: i've been trying to get rid of the file 'manager' for years :)18:43
ralsinadobey: I like the new ideas for Nautilus in Gnome 3 quite a bit18:44
ralsinadobey: specially concepts like "make it useful by default"18:44
dobeyalso, i am sad that there has been no time to deal with that stuff :-/18:44
ralsinayeah18:44
ralsinabut then again, we declared it a rewrite candidate for two cycles already :-(18:45
dobeyralsina: eh, i think maybe you misunderstand the designs for 'files' in gnome 3. 'files' is not nautilus, though it might start out based on the nautilus code18:45
ralsinadobey: trust you on that18:45
dobeyyeah; and i'm quickly wanting to move it to 'DIAF candidate'18:45
ralsinadobey: anyway, maybe we can try to set aside some time for that rewrite *early* in next cycle, but considering the fluidity of the nautilus-in-ubuntu situation...18:46
dobeywell, we need to rewrite the libsyncdaemon part, even if we just end up dropping the nautilus extension. we *do* need some stuff for music store and other things18:47
ralsinayes18:47
dobeymaybe i should try to move the assets today18:48
alecuhello, I'm back.19:45
alecudobey: sorry I didn't reply;19:45
dobeyalecu: welcome back to the land of the living!19:46
dobeyor... zombie!19:46
alecudobey: so, I see your point now. Most of the code that would make a lot of sense to be tested was in TestRunner and got moved to BaseTestRunner19:46
aleculol19:47
alecudobey: did you end up watching some of the "Plaga Zombie" films? :P19:47
dobeyi haven't actually watched it yet. was having trouble with totem/handbrake picking the right language19:48
dobeyit kept wanting to play the commentary track for some reason :(19:48
alecudobey: so, most of the code that could use some tests was just moved (say, _collect_tests, or get_suite).19:50
alecudobey: I think we should retitle the bug to affect those functions needing tests, while lowering the bug priority, since it's code that afaik works fine.19:52
dobeyalecu: well, i do agree the OptionsParser code needs tested. and i have tests for that in a branch19:55
alecudobey: awesome then. Should I invalidate this bug then?19:56
dobeyit is new code, and i've already found/fixed one issue in it last week19:56
alecugatox: approved.19:56
dobeyalecu: well, this branch fixes that bug, so i don't think so19:56
gatoxalecu, awesome!!!!19:56
* gatox starts landing branches19:56
gatoxbriancurtin, do you have time for a review?19:57
briancurtingatox: sure, where at?19:57
dobeyalecu: should i just propose that, and not try to write a complex series of tunnels to test the old code that we've been using for years any more than we are testing it by actually running thet tests?19:57
gatoxbriancurtin, thx..... here: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/11937019:57
gatoxeod here!! see you tomorrow people!20:13
dobeyalecu: lose the internets again? :)20:14
alecu@ping20:25
briancurtinpong20:25
alecudobey: yes, my isp is acting strangely, yet again.20:25
alecubriancurtin: @thanks!20:25
alecudobey: again: "test by running" is a non-starter to me :-)20:26
alecudobey: I agree we have more interesting bits to build than tests for existing code, so yes: propose what you have and don't worry about complex series of twisty passages.20:28
dobeyok, yeah21:05
dobeytrying to load a test suite, within a test, is not working out so well :(21:05
dobeyalecu, ralsina: if you could, https://code.launchpad.net/~dobey/ubuntuone-dev-tools/runner-tests/+merge/11943621:10
ralsinadobey: looking21:10
ralsinadobey: I'll have it tomorrow, I am EODing very soon21:11
=== m_conley is now known as m_conley_away
dobeyalright, i'm off as well. later all21:56
=== zyga is now known as zyga-afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!