/srv/irclogs.ubuntu.com/2012/08/14/#launchpad-dev.txt

lifelesswgrant: Care to do me a favour ?00:33
lifelesswgrant: see #isd scrollback and guess what it is.00:33
wallyworld_wgrant: i expect we will eventually make bug/branch sharing policy required=True, so for now i should default to PUBLIC if null01:56
wgrantwallyworld_: All projects will start with them unconfigured when we turn this on.01:57
wallyworld_so unconfigured = PUBLIC, right? i need to determine what to show in the ui if not set01:58
wgrantunconfigured = public or private, with a different meaning to any of the existing enum values01:58
wgrantunconfigured means that private_bugs and BranchVisibilityPolicy are respected01:59
wgrantWhich have more complicated meanings than *_sharing_policy01:59
wallyworld_oh joy. ok, so that makes things a little more complicated on the ui.01:59
wgrantYeah, indeed, sorry. Forgot about that02:00
wallyworld_np, it's all fun02:00
wgrantPerhaps makes it similar to the milestone widget02:01
wgrantI don't think it needs to be settable back to null02:01
wgrantThat can always be done through the API if someone makes a mistake and needs to revert.02:01
StevenKPerhaps we should add it to the "Configuration options" on the project page02:02
StevenK"Configure sharing options"02:02
wgrantThat's not "Configuration options"02:02
wgrantThat's "UI trainwreck"02:02
StevenKSame same02:03
wallyworld_so i was working on adding it to the +sharing page as discussed this morning02:03
wgrant(but yes, it's possible that the "(!) Sharing" link should become "(!) Configure sharing" down there, but that's not relevant here)02:03
wgrantThe sharing config clearly belongs on +sharing02:03
StevenKwallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/drop-enhanced_choice_popup/+merge/11946103:17
wallyworld_StevenK: the test case needs to be renamed now there are more tests added03:19
StevenKwallyworld_: Sorry, was noming. http://pastebin.ubuntu.com/1146190/03:51
wallyworld_np03:51
wallyworld_that'll do, i already +103:52
lifelessggrrrr iso-testing.04:08
lifelessGRRRRGRGRGR04:08
StevenKlifeless: Hm?04:09
lifelessbug 6.04:09
lifelessAgain.04:09
lifelessI will bet a large (say 1000) amount of money that there is a doc or some other thing in the iso-testing system that folk are following.04:10
StevenKwgrant: Do you want to help me bash my head against this testbrowser upgrade branch, or do you have something more productive for me to do?04:21
StevenKWith hopefully less pain and suffering.04:21
wgrantStevenK: What's still broken?04:21
StevenKwgrant: Still the four from yesterday.04:22
StevenKxx-person-subscriptions has been nailed shut04:22
StevenKErrr05:05
StevenKcp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui205:06
StevenKcp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui205:06
StevenKcp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui205:06
StevenKRepeat a lot05:06
wgrantStevenK: That's been around for a while.05:06
lifelessbigjools: want to do that call from last week ?05:07
StevenKwgrant: Bah05:07
bigjoolslifeless: can do - and I'll explain why I missed it :)05:07
bigjoolslifeless: call me when ready05:08
lifelessbigjools: ok, be a couple of minutes05:08
StevenKwgrant: Why are recipes so terrible? Do you think that its plausible that OOPS-71b883b1dbbd619339e84b662eca301a is related to bug 893576?05:12
lifelesshttps://code.launchpad.net/~lifeless/python-oops-timeline/lgpl/+merge/11946805:16
lifelesswgrant: did you do that favour for me btw?05:16
wgrantStevenK: That OOPS doesn't appear to exist anywhere05:17
StevenKOh, you have to kidding me.05:17
wgrantUnless we have an OOPS storm somewhere05:17
wgrantlifeless: No05:17
StevenKOOPS: OOPS-dabad1c5d11797cefc608105ae54d21805:17
StevenKFilename: /srv/oops.canonical.com/oops-amqp/launchpad/production/2012-08-13/OOPS-71b883b1dbbd619339e84b662eca301a05:17
StevenK*FACEPALM*05:17
wgrantAh05:17
wgrantYes05:18
wgrantAnd no, they're unrelated05:18
wgrantThere's a separate bug for that one05:18
StevenKEasiest fix is to error out say "Remove the obsolete distro from your recipe." Slightly harder is to filter out the obsolete distro05:19
StevenKwgrant: What's your opinion?05:20
wgrantNot sure :)05:21
StevenKlifeless: ^ You're pretty opinated. :-)05:21
StevenKAnything at all is better than an OOPS05:22
lifelessStevenK: oops filenames != oops ids05:31
StevenKlifeless: Why display them at all?05:31
lifelessso that if you want to look at custom fields you can05:32
wgrantwallyworld_: Did you try putting the fields in the main body? They would probably fit well, particularly as it doesn't really make sense for them to be in the sidebar.05:35
wgrant(and that huge warning won't usually be there)05:36
wallyworld_wgrant: it didn't look so good - too much text and vertical space used05:36
wallyworld_i hate reading lots of text without it being somehow grouped05:37
wallyworld_plus we have wasted white space on the right of the page i thought it may be nice to use, similar to the bug privacy portlet05:39
wallyworld_but, all just my opinion05:39
wgrantwallyworld_: Yeah, indeed. But I think it could work well to just simply split the page into two sections: the first declares which artifacts are which type, the second declares who can see which type.05:40
wgrantIt's difficult to say05:40
wallyworld_yeah, need user feedback i guess. maybe we can through it out there and see what feedback we get; it's beta after all05:41
wallyworld_and the layout can be changed quickly to suit05:41
wgrantIndeed05:41
* wallyworld_ has run out of coffee, situation critical, need to go buy some more05:42
wgrantUhoh05:42
StevenKHm, I thought the feature flags around SPRecipes were long dead05:50
wgrantThey should be. Why?05:50
StevenK    def setUp(self):05:50
StevenK        super(TestSourcePackageRecipe, self).setUp()05:50
StevenK        self.useContext(feature_flags())05:50
lifelessStevenK: can I have a review of https://code.launchpad.net/~lifeless/python-oops-timeline/lgpl/+merge/119468 ?06:28
lifelesswgrant: any chance you can review that ppr thing ?06:29
StevenKlifeless: I glanced at it. TBH, I thought were going to self-review.06:29
lifelesshmm, perhaps I should. But I've interrupted you already, so meg.06:30
lifelessStevenK: wgrant: I can't find the bug (but I know it exists) for recipes w/obsolete series.06:30
StevenK890-# GNU Affero General Public License version 3 (see the file LICENSE).06:30
StevenK891+# GNU General Public License version 3 (see the file LICENSE).06:30
StevenKTis bug 100649306:31
wgrantlifeless, StevenK: Bug #100649306:31
wgrantYeah06:31
wgrantThat06:31
lifelessgrah. thanks, apparently I fail at simple search and replace.06:31
StevenKlifeless: That's buildout.cfg. GPLv3? Really?06:31
StevenKlifeless: That's the only thing that belts me in the face. I'd prefer the copyright years updated to include this year, but I'll leave it up to you.06:32
lifelessStevenK: no other changes to the file - copyright doesn't accrure.06:33
StevenKlifeless: "but I'll leave it up to you." :-)06:34
lifelesssure, thanks.06:34
StevenKlifeless: And approved.06:35
lifelessStevenK: I replied because it would be wrong to update the copyright, as opposed to merely a preference :)06:35
lifelessStevenK: thank you!06:35
wallyworld_wgrant: do you know if one can call via a web service named_operation a method that has been declared as a property mutator?06:36
wgrantwallyworld_: No. You have to use PATCH for that06:36
wallyworld_bollocks :-(06:36
wgrantWhy?06:37
wallyworld_patch sucks because it returns an entry resource and not what one might really want06:37
wallyworld_whereas a named op you can return arbitrary json data or html or whatever suits your needs06:38
bigjoolsit'd sure be nice if the "workitems_text: Unknown status XXX" was accompanied by a list of valid statuses07:12
adeuringgood moorning07:48
=== almaisan-away is now known as al-maisan
lifelessare there any undeployed DB patches ?08:42
wgrantNo08:44
wgrantcjwatson will hopefully have one soon08:44
wgrantIt's in review now, I believe.08:44
wgrantWhich means we can apply the new downtime schedule now :)08:44
czajkowskiwgrant: has that been blogged/annouced yet ?08:45
wgrantstakeholders have been told, and I imagine it will be blogged soonish08:46
cjwatsonhttps://code.launchpad.net/~cjwatson/launchpad/db-process-accepted-bugs-job/+merge/119320 awaiting review, yes08:58
mgzcan feature flags be set in advance of them actually existing?09:11
mgzor should I put a note in the NDT for the land that includes this change for the l-osa to set the flag after?09:12
wgrantmgz: 'If true, load posts from the launchpad for display on the root page.' ← do you mean "Launchpad blog"?09:12
wgrantmgz: And yeah, you can set beforehand if you need09:12
mgzdammit09:13
wgrantHaving unknown ones isn't a problem09:13
mgzliterally just sent that to be merged09:13
mgzcan I sneak in another rev with ec2 land?09:14
wgrantmgz: ec2 land doesn't ask PQM to merge a specific revno. It'll submit whatever's in the branch when the run finishes.09:15
wgrantSo you can push up a rev now while it's running, as long as you promise it won't break the test suite :)09:15
mgzwoho! :)09:15
lifelessczajkowski: it has now09:24
czajkowskilifeless: sweet :)09:25
czajkowskilifeless: would you like me to to A) copy that onto the blog and circulate everywhere, or B) just post that link to other places?09:25
wgrantIf you do copy it elsewhere, might want to s/5 seconds/5 minutes/09:26
lifelessczajkowski: Thanks for offering. I'll do an announcement to the main LP blog myself.09:26
lifelesswgrant: did I typo ?09:26
wgrant"This schedule will give us a max of 30 seconds downtime per day, a09:26
wgrantsignificant reduction from the current maximum of 5 seconds,"09:26
wgrant:)09:26
lifelessDOHFUCK09:26
lifelesswgrant: please follow up to my mail and correct it ;)09:26
wgrantSure09:27
czajkowskilifeless: np, I know it's late you side of the world :)09:27
lifelessYou are as late as you feel.09:28
mgzczajkowski: also there's a s/slow/slot/ to fix when reposting09:43
lifelessczajkowski: blog post done; feel free to edit if you wish :).09:44
czajkowskilifeless: cheers09:49
Glifeless: czajkowski: s/at once of these times/at one of these times/ ?10:03
=== al-maisan is now known as almaisan-away
czajkowskiG: fixed10:18
wgrantcjwatson: " * even the API for accepting unapproved uploads to a PPA is cumbersome; while it is (I think) possible, it requires explicitly granting oneself a queue admin permission on one's own PPA"11:03
wgrantcjwatson: I don't believe it's possible to create queue admin permissions on a PPA11:03
wgrantIt's not meant to be, at least.11:03
cjwatsonwgrant: What's there to prevent it?11:08
cjwatsonThe archive owner has launchpad.Edit on IArchive, and I don't see any other restrictions on newQueueAdmin.11:08
cjwatsonNot saying it's sane.11:08
wgrant:(11:09
wgrantIndeed11:09
cjwatsonObviously the answer is to not get into that situation in the first place.11:10
wgrantYeah11:11
=== Beret- is now known as Beret
czajkowskicjwatson: you've been busy this morning, :)11:42
czajkowskibug queue is busy :)11:43
=== almaisan-away is now known as al-maisan
cjwatsonczajkowski: only four :)12:20
mgz17477 tests run in 4:12:35.906462, 1 failures, 0 errors13:42
mgzdammit... there was a doctest13:43
mgzwhy are you testing html output in doctests launchpad ;_;13:43
cjwatsonThink of it as a reserve of LoC.13:44
mgzha, a good tip, just found a couple of hundred to lose13:48
deryckrick_h_, I'm qa-ok on that edit emails thing.13:51
rick_h_deryck: ok cool thanks13:53
=== deryck is now known as deryck[afk]
mgz...is this google web service stuff actually used any more?13:56
mgzah, it's on the main page only?13:57
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: rick_h | Firefighting: - | Critical bugs: 4.0*10^2
mgzactually, I'll be conservative for now...14:31
mgzdeleting too much junk would make this more annoying to land.14:31
=== deryck[afk] is now known as deryck
rick_h_cjwatson: ping14:45
cjwatsonrick_h_: yes?  (you have 15 minutes until my screen session goes unattended)14:45
rick_h_cjwatson: just wanting to say that I'm looking at your branches for review, but man their a bit out of my wheel house and lots of corner cases it seems14:46
rick_h_cjwatson: so I think I'll punt to the more build-side heavy folks, but don't want you to think I'm ignoring you14:46
cjwatsonthat's fine, I'm offline from 15 minutes from now until Thursday anyway14:46
rick_h_cjwatson: ok, sorry for the delay14:47
cjwatson(I've done my pending QA on dogfood and should be able to qa-ok those changes from my phone once they hit qastaging)14:47
rick_h_thanks cjwatson14:48
czajkowskicjwatson: off anywhere nice14:54
czajkowskior just taking a break from lp :)14:54
cjwatsonfamily funeral14:55
deryckrick_h_, fantastic work, sir, on the wireframes!15:14
deryckrick_h_, can you spare 5 minutes for a video chat about it?  Just next steps, no corrections or comments from me.15:15
rick_h_deryck: sure thing15:16
deryckrick_h_, standup hangout.... joinging now....15:17
czajkowskicjwatson: oh I'm sorry to hear that.15:20
=== al-maisan is now known as almaisan-away
rick_h_deryck: should I attach a pdf you think or just refer to the U1 link?15:32
deryckrick_h_, refer to the U1 link15:33
rick_h_k15:33
rick_h_deryck: ok, email sent, I'll be hiding under this desk for the rest of the day :P15:45
deryckrick_h_, heh, no fear!15:46
rick_h_deryck: woot, and ndt is complete so once I fix these 3.5 bugs I we can flip the feature flag for orange!15:46
derycknice!15:46
czajkowskideryck: is https://bugs.launchpad.net/launchpad/+bug/1036267 rolling out soon ?15:46
deryckczajkowski, just deployed.15:47
deryckrick_h_, don't forget to mark the bugs fix released.15:47
czajkowskioh good, before I hop my phone of a wall!15:47
czajkowskistupid 2 fctor auth!15:47
czajkowski*factor15:47
rick_h_deryck: ah, it won't auto do that?15:47
deryckrick_h_, no, sorry15:47
czajkowskirick_h_: no bugs are lazy that way!15:47
* rick_h_ has messed that up several times then doh15:47
rick_h_thanks for the heads up/reminder then15:48
=== salgado is now known as salgado-lunch
=== salgado-lunch is now known as salgado
cgoldbergis anyone here familiar with PPR (Launchpad Page Performance Reports)?  It's a zserver tracelog parser that creates html reports (pageperformancereport.py).  lifeless recently moved the code from launchpad codebase into lp-dev-utils... and I'm doing some work on it now.  We want to re-use it for parsing Apache Access logs (for SSO and other projects).16:48
cgoldberganyone up for a code review of a lp-dev-utils branch? :)16:48
czajkowskicgoldberg: the on call reviewer is in the topic, currently it is rick_h_ so he'd have to see how busy his queue is16:52
* deryck goes offline for lunch, back soon16:58
cgoldbergczajkowski, thanks17:02
rick_h_cgoldberg: linky to the MP?17:25
rick_h_sorry, just back from lunch17:25
cgoldbergrick_h_,  https://code.launchpad.net/~coreygoldberg/lp-dev-utils/ppr-access-parser/+merge/11940917:28
rick_h_cgoldberg: k, loading up17:29
cgoldbergrick_h_, k thanks!   lifeless was sorta guiding me.. but got too busy to review an MP.  If he has time today, i'd like him to look also before merging17:30
rick_h_cgoldberg: ok, if he's online before I EOD I'll prod him17:31
lifeless_science, it works.18:16
rick_h_says you :P18:17
sinzuirick_h_: are you aware of a yui function/library that we could trivially reuse to set the deactivated attribute of subordinate fields. eg checkbox/radiobutton must be checked for input field to accept input?18:23
rick_h_sinzui: not off the top of my head no. I'd htink it's be just an event on a form handling object with a list of disable/enable based on some attrChange event18:29
sinzuimaybe we want to add an attr to all subordinate fields that cannot have input without the another field's state being checked. eg, data-leader="membership-can-expire" on the field that asks for the expiration days. A common script could look for that attr, from the leader field from add a handler to toggle deactivated based on the state of leader.checked18:32
rick_h_sinzui: wallyworld_ jcsackett just a heads up, updating the JS tests to pass in 3.5.1. Some broke since last fix up. https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/11960318:33
rick_h_so just reminder on the quotes on attrs and such, orange is going to start running with the 3.5.1 feature flag soon and I'll see if I can find a chance to figure out a way to run our JS tests on multiple versions somehow18:33
rick_h_sinzui: ah, gotcha. Yea, nothing I know of off the top of my head. Is this on some widget out there?18:35
sinzuisorry rick. I reviewed some of those tests you fixed18:35
rick_h_sinzui: np, it's going to happen until the tests actual fail for everyone18:35
sinzuiis the leap to 3.6 harder? should we target that now instead on 3.5?18:36
rick_h_sinzui: so two parts18:36
rick_h_1) 3.6. is new and I don't tend to trust new and I don't think we *need* anything in there atm18:36
rick_h_2) I'm working on making it easier to test/upgrade versions and going from 3.5.1 to 3.6 will make a good test run of that process18:37
sinzuifab18:37
rick_h_sinzui: plus we can't do anything still until we get everyone on the combo loader so it'll be some time yet I'm sure :/18:37
sinzuiI thought the loader was on for everyone. I thought I was the last person to switch, and I hacked my env to work with combo-loader and ie8 a few weeks ago18:38
rick_h_sinzui: if your form needs are a current widget maybe we can do some sort of extension that adds a .submit event binder and runs through a list of 'fields xxx require yyy enabled else set xxx.value(undefined)18:39
rick_h_sinzui: well, it's on for up through beta-testers18:39
rick_h_but not on full production18:39
sinzuiokay. understood and agreed we need it on default first18:39
rick_h_we're waiting on an RT to setup squid caching of JS combo load files for that18:39
sinzuirick_h_: I think I want two data attrs to define two different behaviours. One ensure the subordinate field cannot be used without first checking the master...to prevent users from entering unneeded information. I want the opposite where entering a value in the input checks the master checkbox/radiobutton so that my entry is not ignored by some forms.18:41
rick_h_sinzui: yea, I think we'd have to have a base starting widget that was a 'form container'18:42
sinzuiWe have about 5 bugs where form input fails because the form does not do that the user implies, or the form implies the user should do something.18:42
rick_h_sounds perfect for something like a yui 3.5 View base class18:43
rick_h_*sigh*18:43
rick_h_deryck: ok, so since these are just test fixes, going to ask for the feature flag to 3.5.1 to be set on orange. Any last hesitations?18:44
deryckrick_h_, none, I laugh in the face of orange squad js risk.  do it!18:45
rick_h_lol, ok your the approval person :P18:46
lifeless_rick_h_: how would you invalidate the hypothesis that science does not work ?18:48
rick_h_you mention 'social science' and laugh and run away? :P18:48
sinzuiIt's all in your head. Like the ending of the Lath of Heaven, we are dying, dreaming of life18:49
lifeless_rick_h_: you should read 'thinking, fast and slow'.18:51
lifeless_rick_h_: not the social science you think you know.18:51
=== lifeless_ is now known as lifeless
rick_h_lifeless_: sorry, now approaching hour 7 in a car dealership and getting YUI 3.5.1 going into testing 7 months after the sprint to enable the change so I'm frisky today :P18:52
lifelessrick_h_: oh la la :P18:52
rick_h_deryck: ok, you've got 3.5.1 enjoy18:58
deryckI will!18:58
rick_h_I'll write up an email to the -dev list saying it's alive and kicking18:58
sinzuijcsackett: do you have time to discuss my next actions to make quick team registration sane19:04
jcsackettsinzui: sure, just one sec.19:05
jcsackettsinzui: i just missed your invite, calling back.19:08
sinzuijcsackett: haha. teams have two descriptions and the page hides the screw up. I may need to do some work on Bug #5283 just to keep the LoC count down20:33
_mup_Bug #5283: "Home page" vs. "Description" is misleading <bad-commit-11051> <easy> <lp-registry> <qa-ok> <teams> <tech-debt> <ui> <users> <Launchpad itself:In Progress by nigelbabu> < https://launchpad.net/bugs/5283 >20:33
jcsackettsinzui: fantastic. :-P20:34
=== salgado is now known as salgado-afk
cgoldberglifeless, i'm gonna EOD in a bit.. not sure if rick_h_ got anywhere on my code review :)  could you have a look today?21:53
cgoldberghttps://code.launchpad.net/~coreygoldberg/lp-dev-utils/ppr-access-parser/+merge/11940921:53
rick_h_cgoldberg: sorry, lifeless popped in and he was assigned on the review so passed since it involves amking some config stuff mandatory/etc and I'm not sure where this is used22:06
rick_h_so lifeless  ^^22:06
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 4.0*10^2
cgoldbergrick_h_, np22:07
=== salgado-afk is now known as salgado
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/format-imports-and-again/+merge/119645 when you have a spare moment. sinzui caused most of the fallout, but oh well23:33
sinzuiStevenK: you don't need a review of mechanical changes made by a script....particularly when the changes were made by mechanical scripts to begin with23:34
StevenKsinzui: Oh yes I do. format-imports has made some bad calls over the six or seven times I've run it over the full tree.23:35
wgrantYeah23:35
wgrantI catch an issue about half the time23:35
sinzuifix the script23:36
wgrantAdding "# FIRST" fixes most files, but not all of them23:36
wgrantAnyway, this case is all good.23:36
StevenKYeah, some of the files require manual fixing if they have imports that are between the copyright header and __metaclass__23:37
wgrantlint should probably be taught to complain about that23:37
StevenKIndeed23:37
StevenKwgrant: Thanks, lp-landing23:38

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!