[00:33] <lifeless> wgrant: Care to do me a favour ?
[00:33] <lifeless> wgrant: see #isd scrollback and guess what it is.
[01:56] <wallyworld_> wgrant: i expect we will eventually make bug/branch sharing policy required=True, so for now i should default to PUBLIC if null
[01:57] <wgrant> wallyworld_: All projects will start with them unconfigured when we turn this on.
[01:58] <wallyworld_> so unconfigured = PUBLIC, right? i need to determine what to show in the ui if not set
[01:58] <wgrant> unconfigured = public or private, with a different meaning to any of the existing enum values
[01:59] <wgrant> unconfigured means that private_bugs and BranchVisibilityPolicy are respected
[01:59] <wgrant> Which have more complicated meanings than *_sharing_policy
[01:59] <wallyworld_> oh joy. ok, so that makes things a little more complicated on the ui.
[02:00] <wgrant> Yeah, indeed, sorry. Forgot about that
[02:00] <wallyworld_> np, it's all fun
[02:01] <wgrant> Perhaps makes it similar to the milestone widget
[02:01] <wgrant> I don't think it needs to be settable back to null
[02:01] <wgrant> That can always be done through the API if someone makes a mistake and needs to revert.
[02:02] <StevenK> Perhaps we should add it to the "Configuration options" on the project page
[02:02] <StevenK> "Configure sharing options"
[02:02] <wgrant> That's not "Configuration options"
[02:02] <wgrant> That's "UI trainwreck"
[02:03] <StevenK> Same same
[02:03] <wallyworld_> so i was working on adding it to the +sharing page as discussed this morning
[02:03] <wgrant> (but yes, it's possible that the "(!) Sharing" link should become "(!) Configure sharing" down there, but that's not relevant here)
[02:03] <wgrant> The sharing config clearly belongs on +sharing
[03:17] <StevenK> wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/drop-enhanced_choice_popup/+merge/119461
[03:19] <wallyworld_> StevenK: the test case needs to be renamed now there are more tests added
[03:51] <StevenK> wallyworld_: Sorry, was noming. http://pastebin.ubuntu.com/1146190/
[03:51] <wallyworld_> np
[03:52] <wallyworld_> that'll do, i already +1
[04:08] <lifeless> ggrrrr iso-testing.
[04:08] <lifeless> GRRRRGRGRGR
[04:09] <StevenK> lifeless: Hm?
[04:09] <lifeless> bug 6.
[04:09] <lifeless> Again.
[04:10] <lifeless> I will bet a large (say 1000) amount of money that there is a doc or some other thing in the iso-testing system that folk are following.
[04:21] <StevenK> wgrant: Do you want to help me bash my head against this testbrowser upgrade branch, or do you have something more productive for me to do?
[04:21] <StevenK> With hopefully less pain and suffering.
[04:21] <wgrant> StevenK: What's still broken?
[04:22] <StevenK> wgrant: Still the four from yesterday.
[04:22] <StevenK> xx-person-subscriptions has been nailed shut
[05:05] <StevenK> Errr
[05:06] <StevenK> cp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui2
[05:06] <StevenK> cp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui2
[05:06] <StevenK> cp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui2
[05:06] <StevenK> Repeat a lot
[05:06] <wgrant> StevenK: That's been around for a while.
[05:07] <lifeless> bigjools: want to do that call from last week ?
[05:07] <StevenK> wgrant: Bah
[05:07] <bigjools> lifeless: can do - and I'll explain why I missed it :)
[05:08] <bigjools> lifeless: call me when ready
[05:08] <lifeless> bigjools: ok, be a couple of minutes
[05:12] <StevenK> wgrant: Why are recipes so terrible? Do you think that its plausible that OOPS-71b883b1dbbd619339e84b662eca301a is related to bug 893576?
[05:16] <lifeless> https://code.launchpad.net/~lifeless/python-oops-timeline/lgpl/+merge/119468
[05:16] <lifeless> wgrant: did you do that favour for me btw?
[05:17] <wgrant> StevenK: That OOPS doesn't appear to exist anywhere
[05:17] <StevenK> Oh, you have to kidding me.
[05:17] <wgrant> Unless we have an OOPS storm somewhere
[05:17] <wgrant> lifeless: No
[05:17] <StevenK> OOPS: OOPS-dabad1c5d11797cefc608105ae54d218
[05:17] <StevenK> Filename: /srv/oops.canonical.com/oops-amqp/launchpad/production/2012-08-13/OOPS-71b883b1dbbd619339e84b662eca301a
[05:17] <StevenK> *FACEPALM*
[05:17] <wgrant> Ah
[05:18] <wgrant> Yes
[05:18] <wgrant> And no, they're unrelated
[05:18] <wgrant> There's a separate bug for that one
[05:19] <StevenK> Easiest fix is to error out say "Remove the obsolete distro from your recipe." Slightly harder is to filter out the obsolete distro
[05:20] <StevenK> wgrant: What's your opinion?
[05:21] <wgrant> Not sure :)
[05:21] <StevenK> lifeless: ^ You're pretty opinated. :-)
[05:22] <StevenK> Anything at all is better than an OOPS
[05:31] <lifeless> StevenK: oops filenames != oops ids
[05:31] <StevenK> lifeless: Why display them at all?
[05:32] <lifeless> so that if you want to look at custom fields you can
[05:35] <wgrant> wallyworld_: Did you try putting the fields in the main body? They would probably fit well, particularly as it doesn't really make sense for them to be in the sidebar.
[05:36] <wgrant> (and that huge warning won't usually be there)
[05:36] <wallyworld_> wgrant: it didn't look so good - too much text and vertical space used
[05:37] <wallyworld_> i hate reading lots of text without it being somehow grouped
[05:39] <wallyworld_> plus we have wasted white space on the right of the page i thought it may be nice to use, similar to the bug privacy portlet
[05:39] <wallyworld_> but, all just my opinion
[05:40] <wgrant> wallyworld_: Yeah, indeed. But I think it could work well to just simply split the page into two sections: the first declares which artifacts are which type, the second declares who can see which type.
[05:40] <wgrant> It's difficult to say
[05:41] <wallyworld_> yeah, need user feedback i guess. maybe we can through it out there and see what feedback we get; it's beta after all
[05:41] <wallyworld_> and the layout can be changed quickly to suit
[05:41] <wgrant> Indeed
[05:42]  * wallyworld_ has run out of coffee, situation critical, need to go buy some more
[05:42] <wgrant> Uhoh
[05:50] <StevenK> Hm, I thought the feature flags around SPRecipes were long dead
[05:50] <wgrant> They should be. Why?
[05:50] <StevenK>     def setUp(self):
[05:50] <StevenK>         super(TestSourcePackageRecipe, self).setUp()
[05:50] <StevenK>         self.useContext(feature_flags())
[06:28] <lifeless> StevenK: can I have a review of https://code.launchpad.net/~lifeless/python-oops-timeline/lgpl/+merge/119468 ?
[06:29] <lifeless> wgrant: any chance you can review that ppr thing ?
[06:29] <StevenK> lifeless: I glanced at it. TBH, I thought were going to self-review.
[06:30] <lifeless> hmm, perhaps I should. But I've interrupted you already, so meg.
[06:30] <lifeless> StevenK: wgrant: I can't find the bug (but I know it exists) for recipes w/obsolete series.
[06:30] <StevenK> 890	-# GNU Affero General Public License version 3 (see the file LICENSE).
[06:30] <StevenK> 891	+# GNU General Public License version 3 (see the file LICENSE).
[06:31] <StevenK> Tis bug 1006493
[06:31] <wgrant> lifeless, StevenK: Bug #1006493
[06:31] <wgrant> Yeah
[06:31] <wgrant> That
[06:31] <lifeless> grah. thanks, apparently I fail at simple search and replace.
[06:31] <StevenK> lifeless: That's buildout.cfg. GPLv3? Really?
[06:32] <StevenK> lifeless: That's the only thing that belts me in the face. I'd prefer the copyright years updated to include this year, but I'll leave it up to you.
[06:33] <lifeless> StevenK: no other changes to the file - copyright doesn't accrure.
[06:34] <StevenK> lifeless: "but I'll leave it up to you." :-)
[06:34] <lifeless> sure, thanks.
[06:35] <StevenK> lifeless: And approved.
[06:35] <lifeless> StevenK: I replied because it would be wrong to update the copyright, as opposed to merely a preference :)
[06:35] <lifeless> StevenK: thank you!
[06:36] <wallyworld_> wgrant: do you know if one can call via a web service named_operation a method that has been declared as a property mutator?
[06:36] <wgrant> wallyworld_: No. You have to use PATCH for that
[06:36] <wallyworld_> bollocks :-(
[06:37] <wgrant> Why?
[06:37] <wallyworld_> patch sucks because it returns an entry resource and not what one might really want
[06:38] <wallyworld_> whereas a named op you can return arbitrary json data or html or whatever suits your needs
[07:12] <bigjools> it'd sure be nice if the "workitems_text: Unknown status XXX" was accompanied by a list of valid statuses
[07:48] <adeuring> good moorning
[08:42] <lifeless> are there any undeployed DB patches ?
[08:44] <wgrant> No
[08:44] <wgrant> cjwatson will hopefully have one soon
[08:44] <wgrant> It's in review now, I believe.
[08:44] <wgrant> Which means we can apply the new downtime schedule now :)
[08:45] <czajkowski> wgrant: has that been blogged/annouced yet ?
[08:46] <wgrant> stakeholders have been told, and I imagine it will be blogged soonish
[08:58] <cjwatson> https://code.launchpad.net/~cjwatson/launchpad/db-process-accepted-bugs-job/+merge/119320 awaiting review, yes
[09:11] <mgz> can feature flags be set in advance of them actually existing?
[09:12] <mgz> or should I put a note in the NDT for the land that includes this change for the l-osa to set the flag after?
[09:12] <wgrant> mgz: 'If true, load posts from the launchpad for display on the root page.' ← do you mean "Launchpad blog"?
[09:12] <wgrant> mgz: And yeah, you can set beforehand if you need
[09:13] <mgz> dammit
[09:13] <wgrant> Having unknown ones isn't a problem
[09:13] <mgz> literally just sent that to be merged
[09:14] <mgz> can I sneak in another rev with ec2 land?
[09:15] <wgrant> mgz: ec2 land doesn't ask PQM to merge a specific revno. It'll submit whatever's in the branch when the run finishes.
[09:15] <wgrant> So you can push up a rev now while it's running, as long as you promise it won't break the test suite :)
[09:15] <mgz> woho! :)
[09:24] <lifeless> czajkowski: it has now
[09:25] <czajkowski> lifeless: sweet :)
[09:25] <czajkowski> lifeless: would you like me to to A) copy that onto the blog and circulate everywhere, or B) just post that link to other places?
[09:26] <wgrant> If you do copy it elsewhere, might want to s/5 seconds/5 minutes/
[09:26] <lifeless> czajkowski: Thanks for offering. I'll do an announcement to the main LP blog myself.
[09:26] <lifeless> wgrant: did I typo ?
[09:26] <wgrant> "This schedule will give us a max of 30 seconds downtime per day, a
[09:26] <wgrant> significant reduction from the current maximum of 5 seconds,"
[09:26] <wgrant> :)
[09:26] <lifeless> DOHFUCK
[09:26] <lifeless> wgrant: please follow up to my mail and correct it ;)
[09:27] <wgrant> Sure
[09:27] <czajkowski> lifeless: np, I know it's late you side of the world :)
[09:28] <lifeless> You are as late as you feel.
[09:43] <mgz> czajkowski: also there's a s/slow/slot/ to fix when reposting
[09:44] <lifeless> czajkowski: blog post done; feel free to edit if you wish :).
[09:49] <czajkowski> lifeless: cheers
[10:03] <G> lifeless: czajkowski: s/at once of these times/at one of these times/ ?
[10:18] <czajkowski> G: fixed
[11:03] <wgrant> cjwatson: " * even the API for accepting unapproved uploads to a PPA is cumbersome; while it is (I think) possible, it requires explicitly granting oneself a queue admin permission on one's own PPA"
[11:03] <wgrant> cjwatson: I don't believe it's possible to create queue admin permissions on a PPA
[11:03] <wgrant> It's not meant to be, at least.
[11:08] <cjwatson> wgrant: What's there to prevent it?
[11:08] <cjwatson> The archive owner has launchpad.Edit on IArchive, and I don't see any other restrictions on newQueueAdmin.
[11:08] <cjwatson> Not saying it's sane.
[11:09] <wgrant> :(
[11:09] <wgrant> Indeed
[11:10] <cjwatson> Obviously the answer is to not get into that situation in the first place.
[11:11] <wgrant> Yeah
[11:42] <czajkowski> cjwatson: you've been busy this morning, :)
[11:43] <czajkowski> bug queue is busy :)
[12:20] <cjwatson> czajkowski: only four :)
[13:42] <mgz> 17477 tests run in 4:12:35.906462, 1 failures, 0 errors
[13:43] <mgz> dammit... there was a doctest
[13:43] <mgz> why are you testing html output in doctests launchpad ;_;
[13:44] <cjwatson> Think of it as a reserve of LoC.
[13:48] <mgz> ha, a good tip, just found a couple of hundred to lose
[13:51] <deryck> rick_h_, I'm qa-ok on that edit emails thing.
[13:53] <rick_h_> deryck: ok cool thanks
[13:56] <mgz> ...is this google web service stuff actually used any more?
[13:57] <mgz> ah, it's on the main page only?
[14:31] <mgz> actually, I'll be conservative for now...
[14:31] <mgz> deleting too much junk would make this more annoying to land.
[14:45] <rick_h_> cjwatson: ping
[14:45] <cjwatson> rick_h_: yes?  (you have 15 minutes until my screen session goes unattended)
[14:46] <rick_h_> cjwatson: just wanting to say that I'm looking at your branches for review, but man their a bit out of my wheel house and lots of corner cases it seems
[14:46] <rick_h_> cjwatson: so I think I'll punt to the more build-side heavy folks, but don't want you to think I'm ignoring you
[14:46] <cjwatson> that's fine, I'm offline from 15 minutes from now until Thursday anyway
[14:47] <rick_h_> cjwatson: ok, sorry for the delay
[14:47] <cjwatson> (I've done my pending QA on dogfood and should be able to qa-ok those changes from my phone once they hit qastaging)
[14:48] <rick_h_> thanks cjwatson
[14:54] <czajkowski> cjwatson: off anywhere nice
[14:54] <czajkowski> or just taking a break from lp :)
[14:55] <cjwatson> family funeral
[15:14] <deryck> rick_h_, fantastic work, sir, on the wireframes!
[15:15] <deryck> rick_h_, can you spare 5 minutes for a video chat about it?  Just next steps, no corrections or comments from me.
[15:16] <rick_h_> deryck: sure thing
[15:17] <deryck> rick_h_, standup hangout.... joinging now....
[15:20] <czajkowski> cjwatson: oh I'm sorry to hear that.
[15:32] <rick_h_> deryck: should I attach a pdf you think or just refer to the U1 link?
[15:33] <deryck> rick_h_, refer to the U1 link
[15:33] <rick_h_> k
[15:45] <rick_h_> deryck: ok, email sent, I'll be hiding under this desk for the rest of the day :P
[15:46] <deryck> rick_h_, heh, no fear!
[15:46] <rick_h_> deryck: woot, and ndt is complete so once I fix these 3.5 bugs I we can flip the feature flag for orange!
[15:46] <deryck> nice!
[15:46] <czajkowski> deryck: is https://bugs.launchpad.net/launchpad/+bug/1036267 rolling out soon ?
[15:47] <deryck> czajkowski, just deployed.
[15:47] <deryck> rick_h_, don't forget to mark the bugs fix released.
[15:47] <czajkowski> oh good, before I hop my phone of a wall!
[15:47] <czajkowski> stupid 2 fctor auth!
[15:47] <czajkowski> *factor
[15:47] <rick_h_> deryck: ah, it won't auto do that?
[15:47] <deryck> rick_h_, no, sorry
[15:47] <czajkowski> rick_h_: no bugs are lazy that way!
[15:47]  * rick_h_ has messed that up several times then doh
[15:48] <rick_h_> thanks for the heads up/reminder then
[16:48] <cgoldberg> is anyone here familiar with PPR (Launchpad Page Performance Reports)?  It's a zserver tracelog parser that creates html reports (pageperformancereport.py).  lifeless recently moved the code from launchpad codebase into lp-dev-utils... and I'm doing some work on it now.  We want to re-use it for parsing Apache Access logs (for SSO and other projects).
[16:48] <cgoldberg> anyone up for a code review of a lp-dev-utils branch? :)
[16:52] <czajkowski> cgoldberg: the on call reviewer is in the topic, currently it is rick_h_ so he'd have to see how busy his queue is
[16:58]  * deryck goes offline for lunch, back soon
[17:02] <cgoldberg> czajkowski, thanks
[17:25] <rick_h_> cgoldberg: linky to the MP?
[17:25] <rick_h_> sorry, just back from lunch
[17:28] <cgoldberg> rick_h_,  https://code.launchpad.net/~coreygoldberg/lp-dev-utils/ppr-access-parser/+merge/119409
[17:29] <rick_h_> cgoldberg: k, loading up
[17:30] <cgoldberg> rick_h_, k thanks!   lifeless was sorta guiding me.. but got too busy to review an MP.  If he has time today, i'd like him to look also before merging
[17:31] <rick_h_> cgoldberg: ok, if he's online before I EOD I'll prod him
[18:16] <lifeless_> science, it works.
[18:17] <rick_h_> says you :P
[18:23] <sinzui> rick_h_: are you aware of a yui function/library that we could trivially reuse to set the deactivated attribute of subordinate fields. eg checkbox/radiobutton must be checked for input field to accept input?
[18:29] <rick_h_> sinzui: not off the top of my head no. I'd htink it's be just an event on a form handling object with a list of disable/enable based on some attrChange event
[18:32] <sinzui> maybe we want to add an attr to all subordinate fields that cannot have input without the another field's state being checked. eg, data-leader="membership-can-expire" on the field that asks for the expiration days. A common script could look for that attr, from the leader field from add a handler to toggle deactivated based on the state of leader.checked
[18:33] <rick_h_> sinzui: wallyworld_ jcsackett just a heads up, updating the JS tests to pass in 3.5.1. Some broke since last fix up. https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/119603
[18:33] <rick_h_> so just reminder on the quotes on attrs and such, orange is going to start running with the 3.5.1 feature flag soon and I'll see if I can find a chance to figure out a way to run our JS tests on multiple versions somehow
[18:35] <rick_h_> sinzui: ah, gotcha. Yea, nothing I know of off the top of my head. Is this on some widget out there?
[18:35] <sinzui> sorry rick. I reviewed some of those tests you fixed
[18:35] <rick_h_> sinzui: np, it's going to happen until the tests actual fail for everyone
[18:36] <sinzui> is the leap to 3.6 harder? should we target that now instead on 3.5?
[18:36] <rick_h_> sinzui: so two parts
[18:36] <rick_h_> 1) 3.6. is new and I don't tend to trust new and I don't think we *need* anything in there atm
[18:37] <rick_h_> 2) I'm working on making it easier to test/upgrade versions and going from 3.5.1 to 3.6 will make a good test run of that process
[18:37] <sinzui> fab
[18:37] <rick_h_> sinzui: plus we can't do anything still until we get everyone on the combo loader so it'll be some time yet I'm sure :/
[18:38] <sinzui> I thought the loader was on for everyone. I thought I was the last person to switch, and I hacked my env to work with combo-loader and ie8 a few weeks ago
[18:39] <rick_h_> sinzui: if your form needs are a current widget maybe we can do some sort of extension that adds a .submit event binder and runs through a list of 'fields xxx require yyy enabled else set xxx.value(undefined)
[18:39] <rick_h_> sinzui: well, it's on for up through beta-testers
[18:39] <rick_h_> but not on full production
[18:39] <sinzui> okay. understood and agreed we need it on default first
[18:39] <rick_h_> we're waiting on an RT to setup squid caching of JS combo load files for that
[18:41] <sinzui> rick_h_: I think I want two data attrs to define two different behaviours. One ensure the subordinate field cannot be used without first checking the master...to prevent users from entering unneeded information. I want the opposite where entering a value in the input checks the master checkbox/radiobutton so that my entry is not ignored by some forms.
[18:42] <rick_h_> sinzui: yea, I think we'd have to have a base starting widget that was a 'form container'
[18:42] <sinzui> We have about 5 bugs where form input fails because the form does not do that the user implies, or the form implies the user should do something.
[18:43] <rick_h_> sounds perfect for something like a yui 3.5 View base class
[18:43] <rick_h_> *sigh*
[18:44] <rick_h_> deryck: ok, so since these are just test fixes, going to ask for the feature flag to 3.5.1 to be set on orange. Any last hesitations?
[18:45] <deryck> rick_h_, none, I laugh in the face of orange squad js risk.  do it!
[18:46] <rick_h_> lol, ok your the approval person :P
[18:48] <lifeless_> rick_h_: how would you invalidate the hypothesis that science does not work ?
[18:48] <rick_h_> you mention 'social science' and laugh and run away? :P
[18:49] <sinzui> It's all in your head. Like the ending of the Lath of Heaven, we are dying, dreaming of life
[18:51] <lifeless_> rick_h_: you should read 'thinking, fast and slow'.
[18:51] <lifeless_> rick_h_: not the social science you think you know.
[18:52] <rick_h_> lifeless_: sorry, now approaching hour 7 in a car dealership and getting YUI 3.5.1 going into testing 7 months after the sprint to enable the change so I'm frisky today :P
[18:52] <lifeless> rick_h_: oh la la :P
[18:58] <rick_h_> deryck: ok, you've got 3.5.1 enjoy
[18:58] <deryck> I will!
[18:58] <rick_h_> I'll write up an email to the -dev list saying it's alive and kicking
[19:04] <sinzui> jcsackett: do you have time to discuss my next actions to make quick team registration sane
[19:05] <jcsackett> sinzui: sure, just one sec.
[19:08] <jcsackett> sinzui: i just missed your invite, calling back.
[20:33] <sinzui> jcsackett: haha. teams have two descriptions and the page hides the screw up. I may need to do some work on Bug #5283 just to keep the LoC count down
[20:33] <_mup_> Bug #5283: "Home page" vs. "Description" is misleading <bad-commit-11051> <easy> <lp-registry> <qa-ok> <teams> <tech-debt> <ui> <users> <Launchpad itself:In Progress by nigelbabu> < https://launchpad.net/bugs/5283 >
[20:34] <jcsackett> sinzui: fantastic. :-P
[21:53] <cgoldberg> lifeless, i'm gonna EOD in a bit.. not sure if rick_h_ got anywhere on my code review :)  could you have a look today?
[21:53] <cgoldberg> https://code.launchpad.net/~coreygoldberg/lp-dev-utils/ppr-access-parser/+merge/119409
[22:06] <rick_h_> cgoldberg: sorry, lifeless popped in and he was assigned on the review so passed since it involves amking some config stuff mandatory/etc and I'm not sure where this is used
[22:06] <rick_h_> so lifeless  ^^
[22:07] <cgoldberg> rick_h_, np
[23:33] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/format-imports-and-again/+merge/119645 when you have a spare moment. sinzui caused most of the fallout, but oh well
[23:34] <sinzui> StevenK: you don't need a review of mechanical changes made by a script....particularly when the changes were made by mechanical scripts to begin with
[23:35] <StevenK> sinzui: Oh yes I do. format-imports has made some bad calls over the six or seven times I've run it over the full tree.
[23:35] <wgrant> Yeah
[23:35] <wgrant> I catch an issue about half the time
[23:36] <sinzui> fix the script
[23:36] <wgrant> Adding "# FIRST" fixes most files, but not all of them
[23:36] <wgrant> Anyway, this case is all good.
[23:37] <StevenK> Yeah, some of the files require manual fixing if they have imports that are between the copyright header and __metaclass__
[23:37] <wgrant> lint should probably be taught to complain about that
[23:37] <StevenK> Indeed
[23:38] <StevenK> wgrant: Thanks, lp-landing