[00:33] wgrant: Care to do me a favour ? [00:33] wgrant: see #isd scrollback and guess what it is. [01:56] wgrant: i expect we will eventually make bug/branch sharing policy required=True, so for now i should default to PUBLIC if null [01:57] wallyworld_: All projects will start with them unconfigured when we turn this on. [01:58] so unconfigured = PUBLIC, right? i need to determine what to show in the ui if not set [01:58] unconfigured = public or private, with a different meaning to any of the existing enum values [01:59] unconfigured means that private_bugs and BranchVisibilityPolicy are respected [01:59] Which have more complicated meanings than *_sharing_policy [01:59] oh joy. ok, so that makes things a little more complicated on the ui. [02:00] Yeah, indeed, sorry. Forgot about that [02:00] np, it's all fun [02:01] Perhaps makes it similar to the milestone widget [02:01] I don't think it needs to be settable back to null [02:01] That can always be done through the API if someone makes a mistake and needs to revert. [02:02] Perhaps we should add it to the "Configuration options" on the project page [02:02] "Configure sharing options" [02:02] That's not "Configuration options" [02:02] That's "UI trainwreck" [02:03] Same same [02:03] so i was working on adding it to the +sharing page as discussed this morning [02:03] (but yes, it's possible that the "(!) Sharing" link should become "(!) Configure sharing" down there, but that's not relevant here) [02:03] The sharing config clearly belongs on +sharing [03:17] wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/drop-enhanced_choice_popup/+merge/119461 [03:19] StevenK: the test case needs to be renamed now there are more tests added [03:51] wallyworld_: Sorry, was noming. http://pastebin.ubuntu.com/1146190/ [03:51] np [03:52] that'll do, i already +1 [04:08] ggrrrr iso-testing. [04:08] GRRRRGRGRGR [04:09] lifeless: Hm? [04:09] bug 6. [04:09] Again. [04:10] I will bet a large (say 1000) amount of money that there is a doc or some other thing in the iso-testing system that folk are following. [04:21] wgrant: Do you want to help me bash my head against this testbrowser upgrade branch, or do you have something more productive for me to do? [04:21] With hopefully less pain and suffering. [04:21] StevenK: What's still broken? [04:22] wgrant: Still the four from yesterday. [04:22] xx-person-subscriptions has been nailed shut [05:05] Errr [05:06] cp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui2 [05:06] cp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui2 [05:06] cp -a lib/canonical/launchpad/icing/yui_2.7.0b/build build/js/yui2 [05:06] Repeat a lot [05:06] StevenK: That's been around for a while. [05:07] bigjools: want to do that call from last week ? [05:07] wgrant: Bah [05:07] lifeless: can do - and I'll explain why I missed it :) [05:08] lifeless: call me when ready [05:08] bigjools: ok, be a couple of minutes [05:12] wgrant: Why are recipes so terrible? Do you think that its plausible that OOPS-71b883b1dbbd619339e84b662eca301a is related to bug 893576? [05:16] https://code.launchpad.net/~lifeless/python-oops-timeline/lgpl/+merge/119468 [05:16] wgrant: did you do that favour for me btw? [05:17] StevenK: That OOPS doesn't appear to exist anywhere [05:17] Oh, you have to kidding me. [05:17] Unless we have an OOPS storm somewhere [05:17] lifeless: No [05:17] OOPS: OOPS-dabad1c5d11797cefc608105ae54d218 [05:17] Filename: /srv/oops.canonical.com/oops-amqp/launchpad/production/2012-08-13/OOPS-71b883b1dbbd619339e84b662eca301a [05:17] *FACEPALM* [05:17] Ah [05:18] Yes [05:18] And no, they're unrelated [05:18] There's a separate bug for that one [05:19] Easiest fix is to error out say "Remove the obsolete distro from your recipe." Slightly harder is to filter out the obsolete distro [05:20] wgrant: What's your opinion? [05:21] Not sure :) [05:21] lifeless: ^ You're pretty opinated. :-) [05:22] Anything at all is better than an OOPS [05:31] StevenK: oops filenames != oops ids [05:31] lifeless: Why display them at all? [05:32] so that if you want to look at custom fields you can [05:35] wallyworld_: Did you try putting the fields in the main body? They would probably fit well, particularly as it doesn't really make sense for them to be in the sidebar. [05:36] (and that huge warning won't usually be there) [05:36] wgrant: it didn't look so good - too much text and vertical space used [05:37] i hate reading lots of text without it being somehow grouped [05:39] plus we have wasted white space on the right of the page i thought it may be nice to use, similar to the bug privacy portlet [05:39] but, all just my opinion [05:40] wallyworld_: Yeah, indeed. But I think it could work well to just simply split the page into two sections: the first declares which artifacts are which type, the second declares who can see which type. [05:40] It's difficult to say [05:41] yeah, need user feedback i guess. maybe we can through it out there and see what feedback we get; it's beta after all [05:41] and the layout can be changed quickly to suit [05:41] Indeed [05:42] * wallyworld_ has run out of coffee, situation critical, need to go buy some more [05:42] Uhoh [05:50] Hm, I thought the feature flags around SPRecipes were long dead [05:50] They should be. Why? [05:50] def setUp(self): [05:50] super(TestSourcePackageRecipe, self).setUp() [05:50] self.useContext(feature_flags()) [06:28] StevenK: can I have a review of https://code.launchpad.net/~lifeless/python-oops-timeline/lgpl/+merge/119468 ? [06:29] wgrant: any chance you can review that ppr thing ? [06:29] lifeless: I glanced at it. TBH, I thought were going to self-review. [06:30] hmm, perhaps I should. But I've interrupted you already, so meg. [06:30] StevenK: wgrant: I can't find the bug (but I know it exists) for recipes w/obsolete series. [06:30] 890 -# GNU Affero General Public License version 3 (see the file LICENSE). [06:30] 891 +# GNU General Public License version 3 (see the file LICENSE). [06:31] Tis bug 1006493 [06:31] lifeless, StevenK: Bug #1006493 [06:31] Yeah [06:31] That [06:31] grah. thanks, apparently I fail at simple search and replace. [06:31] lifeless: That's buildout.cfg. GPLv3? Really? [06:32] lifeless: That's the only thing that belts me in the face. I'd prefer the copyright years updated to include this year, but I'll leave it up to you. [06:33] StevenK: no other changes to the file - copyright doesn't accrure. [06:34] lifeless: "but I'll leave it up to you." :-) [06:34] sure, thanks. [06:35] lifeless: And approved. [06:35] StevenK: I replied because it would be wrong to update the copyright, as opposed to merely a preference :) [06:35] StevenK: thank you! [06:36] wgrant: do you know if one can call via a web service named_operation a method that has been declared as a property mutator? [06:36] wallyworld_: No. You have to use PATCH for that [06:36] bollocks :-( [06:37] Why? [06:37] patch sucks because it returns an entry resource and not what one might really want [06:38] whereas a named op you can return arbitrary json data or html or whatever suits your needs [07:12] it'd sure be nice if the "workitems_text: Unknown status XXX" was accompanied by a list of valid statuses [07:48] good moorning === almaisan-away is now known as al-maisan [08:42] are there any undeployed DB patches ? [08:44] No [08:44] cjwatson will hopefully have one soon [08:44] It's in review now, I believe. [08:44] Which means we can apply the new downtime schedule now :) [08:45] wgrant: has that been blogged/annouced yet ? [08:46] stakeholders have been told, and I imagine it will be blogged soonish [08:58] https://code.launchpad.net/~cjwatson/launchpad/db-process-accepted-bugs-job/+merge/119320 awaiting review, yes [09:11] can feature flags be set in advance of them actually existing? [09:12] or should I put a note in the NDT for the land that includes this change for the l-osa to set the flag after? [09:12] mgz: 'If true, load posts from the launchpad for display on the root page.' ← do you mean "Launchpad blog"? [09:12] mgz: And yeah, you can set beforehand if you need [09:13] dammit [09:13] Having unknown ones isn't a problem [09:13] literally just sent that to be merged [09:14] can I sneak in another rev with ec2 land? [09:15] mgz: ec2 land doesn't ask PQM to merge a specific revno. It'll submit whatever's in the branch when the run finishes. [09:15] So you can push up a rev now while it's running, as long as you promise it won't break the test suite :) [09:15] woho! :) [09:24] czajkowski: it has now [09:25] lifeless: sweet :) [09:25] lifeless: would you like me to to A) copy that onto the blog and circulate everywhere, or B) just post that link to other places? [09:26] If you do copy it elsewhere, might want to s/5 seconds/5 minutes/ [09:26] czajkowski: Thanks for offering. I'll do an announcement to the main LP blog myself. [09:26] wgrant: did I typo ? [09:26] "This schedule will give us a max of 30 seconds downtime per day, a [09:26] significant reduction from the current maximum of 5 seconds," [09:26] :) [09:26] DOHFUCK [09:26] wgrant: please follow up to my mail and correct it ;) [09:27] Sure [09:27] lifeless: np, I know it's late you side of the world :) [09:28] You are as late as you feel. [09:43] czajkowski: also there's a s/slow/slot/ to fix when reposting [09:44] czajkowski: blog post done; feel free to edit if you wish :). [09:49] lifeless: cheers [10:03] lifeless: czajkowski: s/at once of these times/at one of these times/ ? === al-maisan is now known as almaisan-away [10:18] G: fixed [11:03] cjwatson: " * even the API for accepting unapproved uploads to a PPA is cumbersome; while it is (I think) possible, it requires explicitly granting oneself a queue admin permission on one's own PPA" [11:03] cjwatson: I don't believe it's possible to create queue admin permissions on a PPA [11:03] It's not meant to be, at least. [11:08] wgrant: What's there to prevent it? [11:08] The archive owner has launchpad.Edit on IArchive, and I don't see any other restrictions on newQueueAdmin. [11:08] Not saying it's sane. [11:09] :( [11:09] Indeed [11:10] Obviously the answer is to not get into that situation in the first place. [11:11] Yeah === Beret- is now known as Beret [11:42] cjwatson: you've been busy this morning, :) [11:43] bug queue is busy :) === almaisan-away is now known as al-maisan [12:20] czajkowski: only four :) [13:42] 17477 tests run in 4:12:35.906462, 1 failures, 0 errors [13:43] dammit... there was a doctest [13:43] why are you testing html output in doctests launchpad ;_; [13:44] Think of it as a reserve of LoC. [13:48] ha, a good tip, just found a couple of hundred to lose [13:51] rick_h_, I'm qa-ok on that edit emails thing. [13:53] deryck: ok cool thanks === deryck is now known as deryck[afk] [13:56] ...is this google web service stuff actually used any more? [13:57] ah, it's on the main page only? === rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: rick_h | Firefighting: - | Critical bugs: 4.0*10^2 [14:31] actually, I'll be conservative for now... [14:31] deleting too much junk would make this more annoying to land. === deryck[afk] is now known as deryck [14:45] cjwatson: ping [14:45] rick_h_: yes? (you have 15 minutes until my screen session goes unattended) [14:46] cjwatson: just wanting to say that I'm looking at your branches for review, but man their a bit out of my wheel house and lots of corner cases it seems [14:46] cjwatson: so I think I'll punt to the more build-side heavy folks, but don't want you to think I'm ignoring you [14:46] that's fine, I'm offline from 15 minutes from now until Thursday anyway [14:47] cjwatson: ok, sorry for the delay [14:47] (I've done my pending QA on dogfood and should be able to qa-ok those changes from my phone once they hit qastaging) [14:48] thanks cjwatson [14:54] cjwatson: off anywhere nice [14:54] or just taking a break from lp :) [14:55] family funeral [15:14] rick_h_, fantastic work, sir, on the wireframes! [15:15] rick_h_, can you spare 5 minutes for a video chat about it? Just next steps, no corrections or comments from me. [15:16] deryck: sure thing [15:17] rick_h_, standup hangout.... joinging now.... [15:20] cjwatson: oh I'm sorry to hear that. === al-maisan is now known as almaisan-away [15:32] deryck: should I attach a pdf you think or just refer to the U1 link? [15:33] rick_h_, refer to the U1 link [15:33] k [15:45] deryck: ok, email sent, I'll be hiding under this desk for the rest of the day :P [15:46] rick_h_, heh, no fear! [15:46] deryck: woot, and ndt is complete so once I fix these 3.5 bugs I we can flip the feature flag for orange! [15:46] nice! [15:46] deryck: is https://bugs.launchpad.net/launchpad/+bug/1036267 rolling out soon ? [15:47] czajkowski, just deployed. [15:47] rick_h_, don't forget to mark the bugs fix released. [15:47] oh good, before I hop my phone of a wall! [15:47] stupid 2 fctor auth! [15:47] *factor [15:47] deryck: ah, it won't auto do that? [15:47] rick_h_, no, sorry [15:47] rick_h_: no bugs are lazy that way! [15:47] * rick_h_ has messed that up several times then doh [15:48] thanks for the heads up/reminder then === salgado is now known as salgado-lunch === salgado-lunch is now known as salgado [16:48] is anyone here familiar with PPR (Launchpad Page Performance Reports)? It's a zserver tracelog parser that creates html reports (pageperformancereport.py). lifeless recently moved the code from launchpad codebase into lp-dev-utils... and I'm doing some work on it now. We want to re-use it for parsing Apache Access logs (for SSO and other projects). [16:48] anyone up for a code review of a lp-dev-utils branch? :) [16:52] cgoldberg: the on call reviewer is in the topic, currently it is rick_h_ so he'd have to see how busy his queue is [16:58] * deryck goes offline for lunch, back soon [17:02] czajkowski, thanks [17:25] cgoldberg: linky to the MP? [17:25] sorry, just back from lunch [17:28] rick_h_, https://code.launchpad.net/~coreygoldberg/lp-dev-utils/ppr-access-parser/+merge/119409 [17:29] cgoldberg: k, loading up [17:30] rick_h_, k thanks! lifeless was sorta guiding me.. but got too busy to review an MP. If he has time today, i'd like him to look also before merging [17:31] cgoldberg: ok, if he's online before I EOD I'll prod him [18:16] science, it works. [18:17] says you :P [18:23] rick_h_: are you aware of a yui function/library that we could trivially reuse to set the deactivated attribute of subordinate fields. eg checkbox/radiobutton must be checked for input field to accept input? [18:29] sinzui: not off the top of my head no. I'd htink it's be just an event on a form handling object with a list of disable/enable based on some attrChange event [18:32] maybe we want to add an attr to all subordinate fields that cannot have input without the another field's state being checked. eg, data-leader="membership-can-expire" on the field that asks for the expiration days. A common script could look for that attr, from the leader field from add a handler to toggle deactivated based on the state of leader.checked [18:33] sinzui: wallyworld_ jcsackett just a heads up, updating the JS tests to pass in 3.5.1. Some broke since last fix up. https://code.launchpad.net/~rharding/launchpad/yui35_test_fix2/+merge/119603 [18:33] so just reminder on the quotes on attrs and such, orange is going to start running with the 3.5.1 feature flag soon and I'll see if I can find a chance to figure out a way to run our JS tests on multiple versions somehow [18:35] sinzui: ah, gotcha. Yea, nothing I know of off the top of my head. Is this on some widget out there? [18:35] sorry rick. I reviewed some of those tests you fixed [18:35] sinzui: np, it's going to happen until the tests actual fail for everyone [18:36] is the leap to 3.6 harder? should we target that now instead on 3.5? [18:36] sinzui: so two parts [18:36] 1) 3.6. is new and I don't tend to trust new and I don't think we *need* anything in there atm [18:37] 2) I'm working on making it easier to test/upgrade versions and going from 3.5.1 to 3.6 will make a good test run of that process [18:37] fab [18:37] sinzui: plus we can't do anything still until we get everyone on the combo loader so it'll be some time yet I'm sure :/ [18:38] I thought the loader was on for everyone. I thought I was the last person to switch, and I hacked my env to work with combo-loader and ie8 a few weeks ago [18:39] sinzui: if your form needs are a current widget maybe we can do some sort of extension that adds a .submit event binder and runs through a list of 'fields xxx require yyy enabled else set xxx.value(undefined) [18:39] sinzui: well, it's on for up through beta-testers [18:39] but not on full production [18:39] okay. understood and agreed we need it on default first [18:39] we're waiting on an RT to setup squid caching of JS combo load files for that [18:41] rick_h_: I think I want two data attrs to define two different behaviours. One ensure the subordinate field cannot be used without first checking the master...to prevent users from entering unneeded information. I want the opposite where entering a value in the input checks the master checkbox/radiobutton so that my entry is not ignored by some forms. [18:42] sinzui: yea, I think we'd have to have a base starting widget that was a 'form container' [18:42] We have about 5 bugs where form input fails because the form does not do that the user implies, or the form implies the user should do something. [18:43] sounds perfect for something like a yui 3.5 View base class [18:43] *sigh* [18:44] deryck: ok, so since these are just test fixes, going to ask for the feature flag to 3.5.1 to be set on orange. Any last hesitations? [18:45] rick_h_, none, I laugh in the face of orange squad js risk. do it! [18:46] lol, ok your the approval person :P [18:48] rick_h_: how would you invalidate the hypothesis that science does not work ? [18:48] you mention 'social science' and laugh and run away? :P [18:49] It's all in your head. Like the ending of the Lath of Heaven, we are dying, dreaming of life [18:51] rick_h_: you should read 'thinking, fast and slow'. [18:51] rick_h_: not the social science you think you know. === lifeless_ is now known as lifeless [18:52] lifeless_: sorry, now approaching hour 7 in a car dealership and getting YUI 3.5.1 going into testing 7 months after the sprint to enable the change so I'm frisky today :P [18:52] rick_h_: oh la la :P [18:58] deryck: ok, you've got 3.5.1 enjoy [18:58] I will! [18:58] I'll write up an email to the -dev list saying it's alive and kicking [19:04] jcsackett: do you have time to discuss my next actions to make quick team registration sane [19:05] sinzui: sure, just one sec. [19:08] sinzui: i just missed your invite, calling back. [20:33] jcsackett: haha. teams have two descriptions and the page hides the screw up. I may need to do some work on Bug #5283 just to keep the LoC count down [20:33] <_mup_> Bug #5283: "Home page" vs. "Description" is misleading

< https://launchpad.net/bugs/5283 > [20:34] sinzui: fantastic. :-P === salgado is now known as salgado-afk [21:53] lifeless, i'm gonna EOD in a bit.. not sure if rick_h_ got anywhere on my code review :) could you have a look today? [21:53] https://code.launchpad.net/~coreygoldberg/lp-dev-utils/ppr-access-parser/+merge/119409 [22:06] cgoldberg: sorry, lifeless popped in and he was assigned on the review so passed since it involves amking some config stuff mandatory/etc and I'm not sure where this is used [22:06] so lifeless ^^ === rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 4.0*10^2 [22:07] rick_h_, np === salgado-afk is now known as salgado [23:33] wgrant: https://code.launchpad.net/~stevenk/launchpad/format-imports-and-again/+merge/119645 when you have a spare moment. sinzui caused most of the fallout, but oh well [23:34] StevenK: you don't need a review of mechanical changes made by a script....particularly when the changes were made by mechanical scripts to begin with [23:35] sinzui: Oh yes I do. format-imports has made some bad calls over the six or seven times I've run it over the full tree. [23:35] Yeah [23:35] I catch an issue about half the time [23:36] fix the script [23:36] Adding "# FIRST" fixes most files, but not all of them [23:36] Anyway, this case is all good. [23:37] Yeah, some of the files require manual fixing if they have imports that are between the copyright header and __metaclass__ [23:37] lint should probably be taught to complain about that [23:37] Indeed [23:38] wgrant: Thanks, lp-landing