| mandel | morning all! | 07:40 |
|---|---|---|
| rye | mornings | 09:01 |
| rye | mandel: do you happen to have some code snippet that performs the same SSL verification as the SSO using Qt libraries? | 10:47 |
| mandel | rye, yes, give me a sec | 11:01 |
| mandel | rye, try with this: lp:~alecu/+junk/qt-ssl-error | 11:02 |
| mandel | gatox, buenos dias! | 11:02 |
| gatox | mandel, buenas | 11:02 |
| === yofel_ is now known as yofel | ||
| rye | erm | 11:14 |
| rye | mandel: are we using qt4reactor in precise? | 11:15 |
| rye | mandel: i see import qt4reactor in proxy dialog but found that my machine has no python-qt4reactor package installed at all | 11:15 |
| mandel | hm.. no, there we use the qt main loop | 11:15 |
| rye | mandel: ah | 11:16 |
| rye | mandel: but proxy dialog? | 11:16 |
| mandel | rye, we should not, let me check | 11:16 |
| mandel | rye, which file are you exactly looking at? | 11:17 |
| rye | mandel: ah, if platform is win32, ok | 11:18 |
| mandel | rye, :) | 11:18 |
| mandel | lunch time here :) | 12:04 |
| * mandel lunch | 12:04 | |
| gatox | brb.... need to do some errands | 12:29 |
| === gatox is now known as gatox_brb | ||
| thisfred | ralsina, could use a small review of https://code.launchpad.net/~thisfred/u1db/colored-squares/+merge/119376 por favor (we decided to not make the tag colors be the background color for the whole row, to increase readability, and reduce angry fruit salad, as aquarius puts it) | 12:50 |
| thisfred | with thanks to rodney for the solution :) | 12:50 |
| dobey | heh | 12:51 |
| alecu | morning all! | 12:51 |
| thisfred | beunos días alecu | 12:51 |
| alecu | damn, he's even putting the accents over the I's. We'll have to invite him to #ar soon... | 12:53 |
| thisfred | alecu, unless #es makes me a better offer :P | 12:53 |
| alecu | :-) | 12:54 |
| thisfred | I was going very fast for a while, and then I hit the past tense, and now I slowed down considerably, since it gets a little more irregular there | 12:55 |
| === gatox_brb is now known as gatox | ||
| ralsina | thisfred: will look! | 13:02 |
| thisfred | muchas gracias | 13:02 |
| ralsina | thisfred: noone cares about the past,even if it's tense | 13:02 |
| gatox | alecu, i have a u1-cp branch that keeps bouncing because of a lint issue that it says that a u1-client class doesn't has a"sync_menu" attribute.... but the u1-client branch that adds that already merge yesterday..... do you know what might be happening? | 13:03 |
| ralsina | thisfred: also, one way to reduce angry fruit salad is to use a pastel color palette | 13:03 |
| thisfred | ralsina, which is what I tried to do, but not to aquarius' liking | 13:03 |
| alecu | gatox: try branching trunk, and then merging that branch. And see if lint complains. | 13:03 |
| ralsina | thisfred: fair enough | 13:04 |
| ralsina | thisfred: BTW, pastel in spanish means pie. Just to avoid further confusion ;-) | 13:04 |
| dobey | gatox: merged != installed | 13:04 |
| gatox | dobey, ahhhhhhh that's the problem then! | 13:05 |
| gatox | dobey, is that going to take a lot? | 13:05 |
| dobey | gatox: should have happened automagically really. not sure why it isn't. not that familiar with jenkins/puppet oddities | 13:06 |
| gatox | ok..... i'll wait | 13:06 |
| dobey | gatox: it's updated now, so should work | 13:06 |
| gatox | trying again... | 13:06 |
| ralsina | thisfred: can I ask you to do something that is really not branch-related? | 13:07 |
| thisfred | ralsina, claro | 13:07 |
| ralsina | thisfred: please get rid of simplejson or at least try to import json first, since it's in the stdlib | 13:07 |
| dobey | we need to get rid of simplejson | 13:08 |
| ralsina | dobey: yes | 13:08 |
| thisfred | ralsina, I have tried to do so, but to great resistance, since jam bookmarked them, and simplejson was still faster | 13:08 |
| ralsina | dobey: but eliot promised to do a branch himself in the bug we have for that | 13:08 |
| ralsina | thisfred: hmmmmm | 13:08 |
| thisfred | ehm | 13:08 |
| thisfred | benchmarked | 13:08 |
| ralsina | thisfred: understood as that :-) | 13:09 |
| dobey | ralsina: eliot? | 13:09 |
| ralsina | dobey: it's early ;-) | 13:09 |
| ralsina | dobey: let me find the bug | 13:09 |
| ralsina | Barry | 13:09 |
| dobey | thisfred: the problem is that there is no simplejson for py3; and we will have to support it soon with u1db as well | 13:09 |
| ralsina | https://bugs.launchpad.net/ubuntuone-control-panel/+bug/1029094 | 13:09 |
| ubot5 | Ubuntu bug 1029094 in Ubuntu One Control Panel "Replace simplejson with json" [Undecided,New] | 13:09 |
| dobey | ah | 13:10 |
| ralsina | thisfred: so, if you want, import simplejson first, but don't require it | 13:10 |
| thisfred | dobey, oh well, that settles it, I guess :) | 13:10 |
| ralsina | thisfred: consider it py3k prep work | 13:10 |
| thisfred | ralsina, I'd much rather just have one, and I'm sure it wasn't a difference that will kill us. | 13:10 |
| ralsina | thisfred: unless the user has like 200000000 todo items... | 13:11 |
| thisfred | I will discuss with the u1db peeps first though | 13:11 |
| ralsina | thisfred: and a celeron | 13:11 |
| ralsina | thisfred: and is impatient | 13:11 |
| thisfred | ralsina, well, it's not just cosas | 13:11 |
| ralsina | thisfred: and on fire | 13:11 |
| thisfred | users on fire are probably a use case we don't have to support | 13:11 |
| thisfred | they don't tend to file a lot of bugs | 13:12 |
| ralsina | thisfred: todo: lay down , roll | 13:12 |
| thisfred | GTDOF | 13:13 |
| dobey | GDRAOF | 13:14 |
| ralsina | thisfred: those squares look not pretty | 13:15 |
| ralsina | thisfred: I have an idea to make them pretty but it will suck for an example app, so +1ing | 13:15 |
| thisfred | ralsina, I'm doing the simplest thing first, and aquarius will tell me what's not acceptable. He's going to use it as an example for dev week. | 13:16 |
| ralsina | thisfred: ack | 13:17 |
| dobey | alecu: btw, could you review https://code.launchpad.net/~dobey/ubuntuone-dev-tools/runner-tests/+merge/119436 please? :) | 13:22 |
| alecu | dobey: sure | 13:22 |
| * mandel back | 13:22 | |
| mandel | alecu, gatox or ralsina, may I have an osx review for https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/sbjson-link | 13:24 |
| ralsina | mandel: queued but it's like 4th | 13:26 |
| mandel | ralsina, sure, not in a huge hurry | 13:26 |
| gatox | cool.... i thought i will need to reassamble my mac jeje | 13:26 |
| ralsina | dobey: runner-tests looks good to me | 13:27 |
| dobey | thanks | 13:27 |
| mandel | gatox, what happened to your mac? | 13:51 |
| gatox | mandel, jeje nothing serious.... but i have mini mac in this room..... and the keyboards, mouse, monitor in other room.... because i was using that to play | 13:52 |
| mandel | ah, ok :) | 13:52 |
| dobey | i hope alecu isn't having more problems with his isp again today :-/ | 13:56 |
| * alecu knocks on wood | 13:56 | |
| mandel | dobey, ralsina any problem if I add an MIT licensed lib in the daemon project? and it seems that the recomended way is via copying the file :( | 14:26 |
| ralsina | mandel: link to the thing? | 14:26 |
| mandel | ralsina, I can link to it, yes | 14:27 |
| ralsina | mandel: as in "give me a link" sorry ;-) | 14:27 |
| mandel | ralsina, oh, ok, let me get that for you, one sec | 14:27 |
| mandel | ralsina, http://www.dribin.org/dave/blog/archives/2008/04/29/ddcli/ | 14:28 |
| mandel | ralsina, and a link to the code: http://www.dribin.org/dave/software/#ddcli | 14:28 |
| ralsina | mandel: let me go back to work n my ray to SMITE ALL THOSE WHO LINK TO THE MIT LICENSE WITHOUT PUTTING THEIR NAMES ON IT | 14:29 |
| ralsina | darn | 14:30 |
| mandel | ralsina, that is why I asked.. | 14:30 |
| ralsina | Copyright 2007 __MyCompanyName__ | 14:30 |
| ralsina | dadadadadarn | 14:30 |
| ralsina | mandel: please ask the guy to include the license, with his name, in the sources :-( | 14:32 |
| mandel | ralsina, sure | 14:32 |
| dobey | lol | 14:33 |
| dobey | i love how /doc/ in the tarball just contains more code | 14:33 |
| thisfred | ralsina, since you asked: https://code.launchpad.net/~thisfred/u1db/deprecate-simplejson/+merge/119555 | 14:33 |
| ralsina | thisfred: cool, thanks | 14:33 |
| mandel | ralsina, the lib does have his name in the headers | 14:34 |
| ralsina | mandel: that license needs to be edited to have his name in it | 14:34 |
| ralsina | mandel: it also says the copyright holder is "__MyCmpanyName__" | 14:35 |
| ralsina | unless his name is "copyright holder" ;-) | 14:35 |
| mandel | ralsina, in which file did you see that? | 14:35 |
| ralsina | mandel: there is no license file in the sources. He just has a link to the generic MIT license | 14:35 |
| mandel | ralsina, so not only he has to add the license per file but also add a a license file in the soruces? | 14:36 |
| ralsina | mandel: yes | 14:36 |
| ralsina | mandel: or at least the license itself | 14:37 |
| mandel | ralsina, ok, I hate license problems.. | 14:37 |
| ralsina | mandel: wait | 14:37 |
| ralsina | mandel: is this ddcli? | 14:37 |
| mandel | ralsina, yes | 14:37 |
| ralsina | mandel: and what you need is the contents of lib/ ? | 14:37 |
| mandel | ralsina, yes | 14:38 |
| ralsina | mandel: then go ahead :-) | 14:38 |
| mandel | ralsina, I can link to the lib, right? | 14:38 |
| ralsina | mandel: just remove the rest of it, and keep only lib/ | 14:38 |
| mandel | ralsina, so, do I copy the files or do I link against the lib? I can do either | 14:38 |
| dobey | the source files really need proper license/copyright information in EACH source file, in the comment headers | 14:39 |
| ralsina | mandel: I would copy the sources | 14:39 |
| ralsina | dobey: they do, in the library | 14:39 |
| ralsina | dobey: just the example code is bad there | 14:39 |
| ralsina | thisfred: what's the meaning of "# noqa" ? | 14:40 |
| thisfred | ralsina, it tells flake8 to shut its trap | 14:40 |
| ralsina | thisfred: cool, thanks | 14:40 |
| ralsina | thisfred: good to know ;-) | 14:41 |
| thisfred | which can't accept multiple imports like this :) | 14:41 |
| thisfred | ralsina, I wish they'd made it clearer, but there you go | 14:41 |
| alecu | elopio: ping | 14:43 |
| ralsina | thisfred: +1 | 14:44 |
| thisfred | ralsina, thx | 14:44 |
| alecu | elopio: in bug #1036686, how are you checking that syncdaemon is connecting directly to the internet? | 14:44 |
| ubot5 | Launchpad bug 1036686 in Ubuntu One Client "Syncdaemon ignores the proxy for files and folders actions" [Undecided,Confirmed] https://launchpad.net/bugs/1036686 | 14:44 |
| elopio | alecu: I monitor the squid access log. | 14:46 |
| alecu | elopio: well, we are using one open connection for all the syncdaemon traffic, so you will not see many connections when you add files. | 14:48 |
| alecu | elopio: I think you should block the ip route if you want to check that the proxy is used. | 14:48 |
| alecu | elopio: for instance, in my windows vm, when I'm checking the proxy support, I do something like this: | 14:49 |
| alecu | route delete 0.0.0.0 | 14:49 |
| alecu | route add 192.168.1.0 mask 255.255.255.0 10.0.2.2 | 14:49 |
| alecu | (from a cmd.exe with administrator permissions) | 14:49 |
| elopio | alecu: I should see at least one connection, right? | 14:50 |
| elopio | I'll give a try deleting the route | 14:50 |
| alecu | elopio: the only route that should be available is to the host machine that's running squid. | 14:50 |
| gatox | briancurtin, could you re-review this one? https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/119370 i answered your need fixing | 14:51 |
| mmcc | Hi folks! | 14:51 |
| gatox | mmcc, hi | 14:51 |
| alecu | elopio: right, and you will only see one open connection from SD thru the proxy. (well, more than one for some small bits that use a different channel, like: publishing a file, getting the list of public files, and sharing a folder) | 14:51 |
| alecu | elopio: those three operations are the only operations in SD that use a non-persistent connection. | 14:52 |
| elopio | ok, will confirm. | 14:52 |
| alecu | elopio: great, thanks. | 14:52 |
| elopio | thanks to you alecu. | 14:52 |
| alecu | elopio: please let me know if I can give any hints regarding how to set up the routes. | 14:53 |
| elopio | alecu: 10.0.2.2 is your proxy, right? | 14:53 |
| briancurtin | gatox: yep, looking now | 14:56 |
| gatox | briancurtin, thx | 14:56 |
| briancurtin | gatox: ohhh, approved | 14:56 |
| gatox | briancurtin, cool! thanks | 14:57 |
| ralsina | mandel, gatox, briancurtin, mmcc, dobey, thisfred: standup in 2' do it without me, I have to be afk a little | 14:58 |
| gatox | ack | 14:58 |
| mandel | ok | 14:58 |
| thisfred | drunk standup! | 14:59 |
| mandel | thisfred, can be easily be done | 14:59 |
| * mandel grabs the gin | 14:59 | |
| mandel | thisfred, que tal va lo de aprender español? | 15:00 |
| alecu | elopio: 10.0.2.2 is the default gateway that the VirtualBox network has given to the windows vm. | 15:00 |
| briancurtin | me | 15:00 |
| mandel | me | 15:00 |
| thisfred | me | 15:00 |
| alecu | elopio: 192.168.1.0 is my local network, where my squid is running. | 15:00 |
| alecu | me (writting notes) | 15:01 |
| mmcc | me | 15:01 |
| thisfred | mandel, muy bien :) | 15:01 |
| gatox | me | 15:02 |
| alecu | mandel: le está yendo más que bien. Si hasta le pone los acentos a las íes! | 15:03 |
| briancurtin | DONE: Python3 | 15:03 |
| briancurtin | TODO: finish bug #1036270 | 15:03 |
| briancurtin | NEXT: mandel | 15:03 |
| ubot5 | Launchpad bug 1036270 in Ubuntu Single Sign On Client "[nightlies] SSL errors crash ubuntu-sso-client and ubuntuone apps" [Undecided,Triaged] https://launchpad.net/bugs/1036270 | 15:04 |
| mandel | DONE: Got project o buil in lion correctly. Moved code to use ddcli to parse command line args specially to improve the test coverage. | 15:04 |
| mandel | TODO: More work on the main file of the daemon to add tests. Ask for reviews. | 15:04 |
| mandel | BLOCKED: no | 15:04 |
| mandel | thisfred, go! | 15:04 |
| thisfred | DONE: cosas ui fixes, documentation1, simplejson dep removal TODO: documentation2...n for very large ns BLOCKED: no NEXT: alecu | 15:04 |
| mandel | alecu, thisfred, que es mucho mas de lo que hago yo, thisfred there is a missing one in mas :P | 15:04 |
| dobey | me | 15:04 |
| thisfred | mandel, dónde? | 15:05 |
| alecu | DONE: some reviews, some proxy on windows debugging, finally got defeated by isp issues | 15:05 |
| alecu | TODO: mumble with briancurtin, lend him a hand or two | 15:05 |
| alecu | BLOCKED: stiff neck | 15:05 |
| alecu | NEXT: mmcc | 15:05 |
| mandel | thisfred, in 'mas', without it it means but, with it means more | 15:05 |
| thisfred | ah | 15:06 |
| thisfred | I thought pero was but | 15:06 |
| mmcc | DONE: fixed buildout & env-mac, proposed storage-protocol branches | 15:06 |
| mmcc | TODO: catch up on email, fix branches, more debug fsevents | 15:06 |
| mmcc | BLCK: no | 15:06 |
| mmcc | NEXT: gatox | 15:06 |
| gatox | DONE: | 15:06 |
| gatox | Land several control panel branches related to the sync menu feature, start working on the progress bar in the menu for current transfers (working on windows). | 15:06 |
| gatox | TODO: | 15:06 |
| gatox | Finish with this branch and propose. Look at the Shares menu feature. | 15:06 |
| gatox | BLOCKED: | 15:06 |
| gatox | No | 15:06 |
| gatox | dobey, go | 15:06 |
| dobey | DONE: u1db package pokery, start some reorg work for dropping installer, finish up bug #1032336 | 15:06 |
| ubot5 | Launchpad bug 1032336 in ubuntuone-dev-tools "New options parsing needs more test coverage" [Undecided,Fix committed] https://launchpad.net/bugs/1032336 | 15:06 |
| dobey | TODO: rush to get everything done for feature freeze, reorg to drop ubuntuone-installer, SRUs for lucid/natty/oneiric | 15:06 |
| dobey | BLCK: None. | 15:06 |
| dobey | cest fin | 15:06 |
| mmcc | mandel, what project in lion? did you mean 10.6? | 15:06 |
| mandel | thisfred, also, mas is an old spanish thing you will probably not see it in any modern literature | 15:07 |
| * mmcc prefers numbers - large cats don't have a good ordering | 15:07 | |
| mandel | mmcc, yes and no, I updated to xcode 4.4 and it changed all the targets to point to 10.8 so I had to fix that | 15:07 |
| mmcc | mandel: ah. hooray xcode | 15:07 |
| mandel | mmcc, yes, exactly what I though | 15:07 |
| elopio | alecu: my gateway is 192.168.122.1. And squid is in 192.168.1.250. So, with this I can be sure that everything is going through the firewall? | 15:08 |
| elopio | route delete 0.0.0.0 | 15:08 |
| elopio | route add 192.168.1.0 mask 255.255.255.0 192.168.122.1 | 15:08 |
| mmcc | oh also: today is my review day. send me reviews. | 15:08 |
| thisfred | mandel, entendido | 15:09 |
| alecu | elopio: 192.168.122.1 is the gateway that "ipconfig" shows in windows, right? | 15:10 |
| elopio | alecu: yes. | 15:10 |
| mandel | mmcc, I have a few reviews for you :) | 15:10 |
| mmcc | and someone pls review this buildout fix: https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/improve-buildout/+merge/119195 -- maybe mandel, since you dislike the current buildout setup so much? | 15:10 |
| mandel | mmcc, sure! | 15:10 |
| alecu | elopio: then I think it should work. | 15:11 |
| mandel | mmcc, can you look at https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/sbjson-link (removes the lib to link it instead) | 15:11 |
| mandel | and https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/commserver-tests which adds extra tests | 15:11 |
| alecu | elopio: to make double sure, before and after running that, do a "ping 8.8.8.8" from the vm. | 15:11 |
| mmcc | mandel, yeah, I see the list of reviews on +activereviews. looks like you have 7766 lines of reviews for me :\ | 15:11 |
| mmcc | mandel: I'll get started :) | 15:11 |
| alecu | elopio: it should only work before that command. | 15:11 |
| mandel | mmcc, is mostly removing code :) | 15:12 |
| alecu | briancurtin: can we mumble for a bit? | 15:14 |
| briancurtin | alecu: sure, logging in | 15:14 |
| elopio | alecu: yes, that ping fails. | 15:14 |
| elopio | alecu: and files are still being uploaded. | 15:14 |
| elopio | So, actually tests passed. Nothing is left on the squid log. | 15:14 |
| ralsina | elopio: so, it works? | 15:18 |
| ralsina | yay! | 15:18 |
| elopio | ralsina: yes, it seems. | 15:18 |
| elopio | sorry about that. | 15:18 |
| ralsina | elopio: np, it's tricky | 15:18 |
| mmcc | oh, forgot something in standup - ralsina, the OSX Lion VM that IS set up works - I tested it out on friday. | 15:18 |
| ralsina | mmcc: how was it? | 15:20 |
| mmcc | ralsina: it was real, and it was spectacular | 15:21 |
| mmcc | seriously though, it worked fine, and seemed pretty fast to me | 15:21 |
| mmcc | the RT ticket has info on how to use it. I think they still have to set up all the accounts for it though | 15:21 |
| ralsina | mmcc: I have one, mandel, did you get account data? | 15:22 |
| mandel | ralsina, account data? | 15:22 |
| mandel | ralsina, I need a little more context :) | 15:22 |
| alecu | briancurtin: apt-get build-dep ubuntu-sso-client | 15:22 |
| mmcc | mandel for the lionvm that IS set up on that xserve. | 15:23 |
| mandel | ralsina, mmcc, oh, yes yes, for the vms, I have them | 15:23 |
| ralsina | mandel, mmcc: awesome | 15:23 |
| mandel | ralsina, I have been looking at how to correctly set jenkins on that | 15:24 |
| ralsina | alecu, briancurtin, joshuahoover: let's revive the RT for 3.0.2b :-) | 15:25 |
| alecu | elopio: awesome news! | 15:25 |
| elopio | ralsina, alecu, joshuahoover, briancurtin: I retried all the tests I marked as failed, and they passed. Changing the bug to invalid. | 15:26 |
| alecu | ralsina: we still have the issue where sd goes into a loop when the user enters his proxy credentials wrong | 15:26 |
| alecu | elopio: \o/ | 15:26 |
| ralsina | alecu: yes | 15:26 |
| joshuahoover | elopio, ralsina: that is good news :) | 15:26 |
| ralsina | alecu: but that's not a regression, so let's mark it as high and have as 1st bugix after FF when brian is done with SSO-py3 | 15:26 |
| briancurtin | ralsina: should i reuse the same RT or create a new one? | 15:27 |
| joshuahoover | briancurtin: i think you can use the same one since nothing has changed | 15:27 |
| ralsina | yeah | 15:27 |
| dobey | alright, need to get lunch. bbiab | 15:27 |
| joshuahoover | briancurtin: IS will simply think we're even more crazy than they already thought we were | 15:27 |
| briancurtin | nice | 15:27 |
| elopio | so, the only bug I got while running the smoke is bug #1000970 | 15:28 |
| ubot5 | Launchpad bug 1000970 in Ubuntu One Control Panel "AttributeError: "'NoneType' object has no attribute 'stop'" when registering an existing account" [Medium,Confirmed] https://launchpad.net/bugs/1000970 | 15:28 |
| ralsina | joshuahoover: we'll never bow to public opinion | 15:28 |
| elopio | but that's not new. | 15:28 |
| ralsina | elopio: I kinda have a fix for it in mind | 15:28 |
| ralsina | elopio: it's not difficult, but not doing it until friday, probably | 15:28 |
| elopio | friday sounds good. | 15:29 |
| elopio | alecu: I'll add a test to the smoke to enter the wrong password. I didn't know about that. | 15:30 |
| * gatox lunch | 15:36 | |
| === gatox is now known as gatox_lunch | ||
| === salgado is now known as salgado-lunch | ||
| dobey | alecu: thanks for that review | 16:07 |
| joshuahoover | dobey: is there a file that has the version number of the u1 client in ubuntu? (strange request, i know) | 16:11 |
| dobey | joshuahoover: the package itself | 16:14 |
| joshuahoover | dobey: ah, right...and since i pay no attention to such details, where might one find that :) | 16:14 |
| dobey | joshuahoover: dpkg -l $package | 16:15 |
| dobey | ubuntuone-client ubuntuone-control-panel ubuntu-sso-client python-ubuntuone-client python-ubuntuone-storageprotocol and on and on | 16:15 |
| joshuahoover | dobey: right, but i have a guy who can't run any commands, just has access to the filesystem and needs to find the version info | 16:16 |
| joshuahoover | dobey: (don't ask) | 16:16 |
| dobey | how is he going to do that if he can't run any commands? | 16:17 |
| dobey | 'vi' 'less' 'cat' are commands :) | 16:17 |
| dobey | i guess he's in windows? | 16:18 |
| dobey | and mounting the fs or something | 16:18 |
| === cheese is now known as Guest65807 | ||
| === Guest65807 is now known as DanimalCracker | ||
| joshuahoover | dobey: yeah, that's my understanding | 16:19 |
| dobey | joshuahoover: he can look for the package versions in /var/lib/dpkg/status i guess. as long as he doesn't modify that file at all | 16:21 |
| dobey | he'll have to search through it though | 16:21 |
| joshuahoover | dobey: k, thanks! he'll enjoy that | 16:21 |
| === gatox_lunch is now known as gatox | ||
| mandel | EOD for me, catch you all tom! | 16:25 |
| mmcc | bye mandel | 16:26 |
| === salgado-lunch is now known as salgado | ||
| briancurtin | mmcc: if you have time for a review, https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/remove-SyncTimestampChecker/+merge/118826 should be up to date. it's almost all -'es | 16:38 |
| mmcc | briancurtin: ok, I'll put that next in line. | 16:39 |
| mmcc | briancurtin: are you using pylint or pyflakes on that branch? | 17:17 |
| mmcc | I tested it with my new buildout, which uses pyflakes, and it had a few complaints, a couple of which might be relevant to your changes | 17:18 |
| briancurtin | mmcc: pylint but for whatever reason it doesnt pick up nearly half of what everyone else sees. i always fix the very few things that pop up, but others always see more warnings. if you have something that i havent fixed can you pastebin it? | 17:18 |
| mmcc | briancurtin here you go http://paste.ubuntu.com/1147216/ | 17:18 |
| mmcc | that's pyflakes. | 17:19 |
| briancurtin | i still need to stop and get this whole ordreal straightened out...its getting to the point where every branch i produce ends up being crap | 17:19 |
| dobey | mmcc: ubuntu-sso-client uses pylint | 17:19 |
| dobey | mmcc: afaik there's no reason it should be using pyflakes on windows or osx instead of pylint | 17:19 |
| ralsina | unless briancurtin has USE_PYFLAKES set? | 17:20 |
| briancurtin | i dont even think i have pyflakes installed. my pylint just sucks | 17:20 |
| briancurtin | or windows sucks | 17:20 |
| mmcc | dobey: hmmm | 17:20 |
| briancurtin | or something | 17:20 |
| ralsina | pylint on windows does suck a lot | 17:20 |
| mmcc | briancurtin: the fixed buildout will install pyflakes. you do have the egg, it just didn't ever get the script from it | 17:20 |
| ralsina | I never got a decent run out of it (but instead I got bazillion fake warnings) | 17:21 |
| mmcc | USE_PYFLAKES is set in run-mac-tests for sso client | 17:21 |
| mmcc | oh crap, that's only in my working tree :) | 17:21 |
| dobey | ralsina: s/on windows// | 17:22 |
| ralsina | dobey: it sucks differently ;-) | 17:22 |
| mmcc | I clearly don't understand what colo does, I thought creating a new colo branch would leave uncommitted changes in the old branch | 17:23 |
| mmcc | so dobey, we should use pylint instead of pyflakes for sso, even on mac? | 17:23 |
| mmcc | pyflakes is so much faster for me | 17:24 |
| dobey | mmcc: well, we should use the same thing on every platform, for each project. i'd like it to be pyflakes for everything, but there are still some issues with that | 17:24 |
| mmcc | so what was the reason for using pyflakes on the other project (iirc, storage-protocol was what started my buildout fixing episode) | 17:26 |
| mmcc | btw, the difference on my system is 30 sec for pylint and .9 sec for pyflakes, on sso | 17:27 |
| ralsina | mmcc: we started with pylint, so there's a lot of inertia | 17:27 |
| ralsina | mmcc: specially since pyflakes detects less and/or more depending on the wind | 17:27 |
| * gatox was happy with the progress bar in the menu... but it seems that u1-client is broken and need to go back to fix that :S.... crap! | 17:29 | |
| mmcc | ralsina: ok, well since I have a couple of branches to propose that clean up the mac test scripts, it'd be nice to know where we need to use pyflakes and where we should use pylint | 17:30 |
| mmcc | for my part, I'm always using pyflakes since it's fast enough to use with flymake in emacs | 17:30 |
| ralsina | mmcc: you'd have to check the run-tests scripts | 17:31 |
| * ralsina doesn't have that matrix in memory | 17:31 | |
| dobey | mmcc: we have to use pyflakes for protocol/client because pylint does not deal with some crazy stuff twisted/protobuf does | 17:31 |
| dobey | but really, pylint needs to diaf | 17:31 |
| mmcc | dobey: ack. so flakes for those two and lint for the others. gotcha | 17:32 |
| dobey | well, dirspec is using pyflakes too | 17:33 |
| ralsina | ok, too hungry to think | 17:33 |
| ralsina | lunch! | 17:33 |
| dobey | i should probably make dev-tools use both | 17:33 |
| mmcc | anyway, briancurtin if you want to experiment with pyflakes, take a look at https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/improve-buildout/+merge/119195 -- it includes a change to env.bat, so someone who knows bat files would be welcome | 17:37 |
| mmcc | and it installs pyflakes in the buildout/bin | 17:37 |
| briancurtin | the only people who know bat files have really, really long beards | 17:38 |
| briancurtin | but i can take a look instead | 17:38 |
| * mmcc had a suitable beard once: http://ubuntuone.com/7carFI0DvBy3GwdYCAKO3K | 17:45 | |
| briancurtin | that's not long enough to have a section of your geocities page dedicated to windows batch scripting | 17:46 |
| mmcc | ha, nope. | 17:46 |
| thisfred | briancurtin, ohai: the pycon blog post you did says pycon 2012 instead of 2013 ;) | 17:47 |
| briancurtin | crap | 17:47 |
| thisfred | especially confusing since there is also still an advertisement for pycon 2012 up on the site with different dates in March | 17:48 |
| briancurtin | yeah we need to get someone to update that image | 17:49 |
| mmcc | briancurtin, here is the pylint output from darwin for your branch: http://paste.ubuntu.com/1147273/ | 17:53 |
| mmcc | not sure why it's complaining about dirspec and devtools though, those are explicitly put on sys.path in the u1lint wrapper script :( | 17:54 |
| dobey | mmcc: that's because you have an unpatched logilab-common i think | 17:54 |
| dobey | is there a way to make buildout apply a patch when installing something? | 17:54 |
| mmcc | dobey, hrm. probably, but it might be easier to just put a patched version somewhere for buildout to grab - there are a couple of things that are doing the tnow | 17:55 |
| mmcc | doing that now | 17:55 |
| mmcc | eg, pykeyring, pycrypto, etc | 17:55 |
| mmcc | do you have a patched egg laying around somewhere we can just throw into the find-links section? | 17:56 |
| dobey | not really; just have the patched ubuntu packages | 17:56 |
| dobey | no idea how we've dealt with this on win in the past | 17:56 |
| mmcc | someone made a patched egg and ralsina put it on u1.to/ralsina/blah.egg | 17:57 |
| dobey | for the pylint stuff? | 17:58 |
| mmcc | for keyring, crypto, com types, even windows twisted apparently | 17:59 |
| dobey | right | 17:59 |
| dobey | but doesn't explain why nobody has complained about this same issue before, with pylint on win for example :) | 17:59 |
| dobey | mmcc: http://pastebin.ubuntu.com/1147294/ is the patch against logilab-common that we need; i guess you can apply it against the installed version on your buildout to test if you wish | 18:04 |
| mmcc | ok, thanks dobey | 18:04 |
| mmcc | there is a buildout patch applying recipe, works cleanly | 18:31 |
| * briancurtin lunch | 18:31 | |
| mmcc | however, after applying that patch I get a lot more spew from pylint: http://paste.ubuntu.com/1147338/ | 18:32 |
| mmcc | 2200 lines more | 18:32 |
| mmcc | yeah, that looks like it just broke lots more imports, since it still isn't finding devtools or dirspec | 18:33 |
| mmcc | hrm | 18:33 |
| dobey | mmcc: wow | 18:40 |
| dobey | that doesn't seem right | 18:41 |
| mmcc | nope… | 18:41 |
| dobey | it's failing to import pretty much everything there | 18:41 |
| mmcc | I wonder if it's having some interaction with the wrapping script that sets path | 18:42 |
| dobey | maybe | 18:44 |
| ralsina | dobey: I am about to make you a very happy man | 18:47 |
| ralsina | dobey: kill pylint | 18:47 |
| dobey | rly? | 18:47 |
| ralsina | dobey: rly | 18:47 |
| dobey | YAY! | 18:48 |
| ralsina | dobey: thought about it in my lunch, and decided we were just being too conservative | 18:48 |
| ralsina | dobey: so instead of wasting time fixing it, let's kill it | 18:48 |
| dobey | will do | 18:48 |
| ralsina | mmcc: is PATHSEP on mac ":" ? | 18:48 |
| ralsina | mmcc: because on windows pylint doesn't parse PYTHONPATH correctly | 18:49 |
| mmcc | ralsina: the wrapper script sets sys.path directly | 18:49 |
| ralsina | mmcc: ok | 18:49 |
| mmcc | but just for fun, os.path.sep == '/', and os.pathsep == ':' | 18:50 |
| ralsina | dobey: let's do something like the USE_PYFLAKES flag so that pyflakes is used by default and we can try pylint on demand | 18:50 |
| === lifeless_ is now known as lifeless | ||
| dobey | ralsina: yeah. plan is to switch everything to run u1lint with USE_PYFLAKES (or to pyflakes directly where appropriate), get all the issues fixed that pop up, then switch dev-tools to use it by default; maybe changing the env var to be something like U1_PYLINT_CMD=[pyflakes|pylint] and have it do appropriate things based on that | 18:52 |
| ralsina | dobey: cool, trust you on it | 18:52 |
| ralsina | dobey: is there something like pylint's ignore for pyflakes? | 18:54 |
| ralsina | dobey: thisfred used a # noqa today but that was for flake8 not sure if pyflakes alone gets it | 18:54 |
| mmcc | ok, so I can ignore this logilab patch that broke the world for me? | 18:55 |
| * mmcc just realized he didn't read back far enough | 18:56 | |
| thisfred | ralsina, not 100% either but I think it's just flake8 | 18:56 |
| ralsina | thisfred: which would be a great argument for flake8 ;-) | 18:57 |
| dobey | ralsina: no, there's no ignore for pyflakes | 18:57 |
| dobey | which i quite like | 18:59 |
| dobey | having # nothisreallyisok stuff all over the place is really distracting/annoying | 18:59 |
| mmcc | dobey: but so is many lines of this: | 19:00 |
| dobey | i have no idea how to fix the one sticking issue with pyflakes in that regard (the try/except import thing), but we should just get that fixed to not complain | 19:00 |
| mmcc | 45: undefined name '_' | 19:00 |
| dobey | mmcc: well, considering we've never run pyflakes on sso, it makes sense that some things might pop up the first time we do :) | 19:01 |
| mmcc | dobey: well, that one is already covered with a pylint disable... it's in ui.py, I guess it's get text? | 19:02 |
| dobey | i don't know; i'd have to look | 19:02 |
| mmcc | ubuntu_sso/utils/ui.py | 19:02 |
| ralsina | '_' is used for gettext, yes | 19:03 |
| ralsina | which in python is a bad idea :-/ | 19:03 |
| dobey | but i can see how _ might be an issue as it's an internal thing, and a gettext thing | 19:03 |
| ralsina | exactly | 19:03 |
| dobey | but # disable is still the wrong way to fix that i think | 19:03 |
| ralsina | the problem is that _ is being created by gettext.install | 19:04 |
| ralsina | so it really is undefined in a way | 19:04 |
| ralsina | maybe just a _ = None early on | 19:04 |
| ralsina | and it's of course, a known pyflakes issue: https://bugs.launchpad.net/pyflakes/+bug/844592 | 19:06 |
| ubot5 | Ubuntu bug 844592 in Pyflakes "Recognize _("text") from gettext.install(...)" [Undecided,Won't fix] | 19:06 |
| mmcc | ralsina: if I do that I get a type error that None isn't callable… and setting _ = lambda x: x causes weird test breakage | 19:07 |
| ralsina | mmcc: figures | 19:07 |
| ralsina | interesting thing is that exarkun, the pyflakes author is currently under contract porting twisted for us ;-) | 19:07 |
| ralsina | mmcc: a cleaner solution is to do _ = gettext.ugettext or whatever | 19:08 |
| ralsina | mmcc: but I am not sure that's exactly the same thing | 19:08 |
| mmcc | no gettext.ugettext | 19:11 |
| dobey | i'll look at it :) | 19:11 |
| ralsina | dobey: cool. Keep in mind that this is rather low priority though | 19:11 |
| ralsina | dobey: so subject to interruption ;-) | 19:11 |
| mmcc | that is, there's no module level convenience function ugettext. it's a method on class GnuTranslations though | 19:11 |
| dobey | ralsina: do you know how to force cmake to echo the full gcc command it uses when compiling? | 19:15 |
| ralsina | dobey: I used to | 19:15 |
| ralsina | dobey: give me 1 sec | 19:15 |
| ralsina | dobey: make VERBOSE=1 | 19:15 |
| dobey | thanks | 19:17 |
| gatox | alecu, do you have a minute please? | 19:19 |
| mmcc | briancurtin: +1 - your branch doesn't add new pyflakes complaints, so I'm calling that victory :) | 19:23 |
| briancurtin | besides doing "apt-get build-dep ubuntu-sso-client" and bzr branching the project...should i need to do anything else to get sso tests to run? | 19:25 |
| ralsina | briancurtin: AFAIR nothing | 19:28 |
| briancurtin | ralsina: No module named qtreactor.qt4reactor :( in devtools. is there any wiki page for setup? maybe i'm missing an environment variable or something? | 19:33 |
| ralsina | briancurtin: that should be in our PPA | 19:33 |
| ralsina | briancurtin: thing is it's not required to build only to test | 19:33 |
| gatox | i don't understand... here it says that this branch landed was merged with conflicts: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/menu-desktop-services-actions/+merge/119370 but if i branch that or trunk, i don't see the conflicts | 19:33 |
| briancurtin | ralsina: so just doing the build-dep and having the branch should be enough to do "./run-tests"? | 19:34 |
| ralsina | briancurtin: just install python-qt4reactor | 19:34 |
| ralsina | briancurtin: well, you may have to ^ | 19:34 |
| briancurtin | ralsina: ah, there we go. easy enough | 19:35 |
| dobey | brb, need to run an errand | 19:37 |
| ralsina | mmcc, briancurtin: while we may not care about pylint anymore, tarmac will care for a few more days still ;-) | 19:43 |
| gatox | WEIRD! | 19:45 |
| mmcc | ralsina: ack. | 19:45 |
| ralsina | gatox: ? | 19:46 |
| briancurtin | running sso trunk just gave a ridiculous amount of lint warnings | 19:46 |
| gatox | ralsina, i'm just suffering here :P | 19:46 |
| ralsina | briancurtin: on linux? | 19:46 |
| briancurtin | i ran pylint on the python standard library and it took so long that i forgot about it, minimized, then randomly opened it like 35 minutes later and it was still running | 19:46 |
| briancurtin | ralsina: yeah | 19:46 |
| ralsina | briancurtin: don't run pylint, run u1lint | 19:47 |
| briancurtin | ralsina: on a Q VM | 19:47 |
| briancurtin | ralsina: it was whatever came at the end of "./run-tests" | 19:47 |
| ralsina | briancurtin: really? | 19:47 |
| ralsina | briancurtin: ok, running myself to see what happened | 19:47 |
| mmcc | me too | 19:47 |
| mmcc | (but on precise) | 19:48 |
| briancurtin | ralsina: http://paste.ubuntu.com/1147478/ -- this is a fresh Q VM running sso trunk | 19:49 |
| ralsina | briancurtin: totally clean run on precise | 19:49 |
| ralsina | briancurtin: install devtools | 19:49 |
| ralsina | ubuntuone-dev-tools and python-ubuntuone-devtools | 19:50 |
| ralsina | but I would expect those to be part of build-deps | 19:50 |
| mmcc | yeah, on briancurtin's remove-SyncTimestampChecker branch on precise I get only two "TODO" warnings from pylint | 19:50 |
| ralsina | briancurtin: also, do you have nightlies installed? | 19:50 |
| briancurtin | ralsina: all i've done on this machine is install it, then ran "sudo apt-get build-dep ubuntu-sso-client", then bzr branch lp:ubuntu-sso-client, then the qtreactor you just told me to install | 19:51 |
| ralsina | briancurtin: ok, trunk needs nightlies of a few things | 19:52 |
| briancurtin | ralsina: it claims to already have devtools, so maybe its a part of build-deps | 19:52 |
| ralsina | briancurtin: what version? | 19:52 |
| briancurtin | ralsina: how do i tell that? | 19:52 |
| briancurtin | my apt-fu is mostly lost | 19:53 |
| ralsina | briancurtin: dpkg -l ubuntuone-dev-tools | 19:53 |
| ralsina | briancurtin: and do a sudo add-apt-repository ppa:ubuntuone/nightlies | 19:54 |
| briancurtin | ralsina: 3.99.3-0ubuntu | 19:54 |
| ralsina | then apt-get update && apt-get upgrade | 19:54 |
| ralsina | yes, trunk is too new for what you have :-) | 19:54 |
| briancurtin | cool, running now | 19:54 |
| ralsina | you need to live in the frontline! http://tinysong.com/165gV | 19:55 |
| briancurtin | ralsina: ah there we go. down to two TODO lint notices | 20:01 |
| ralsina | briancurtin: awesome :-) | 20:01 |
| ralsina | briancurtin: those are reported but are not failures, so you are ok | 20:01 |
| briancurtin | "to two TODO" | 20:01 |
| briancurtin | cool | 20:01 |
| briancurtin | now to make it work on python3. brb | 20:02 |
| gatox | eod here...... i hope to fix this tomorrow.... i kind of stuck :S | 20:04 |
| gatox | bye people! | 20:04 |
| briancurtin | ralsina: 3.0.2b binaries are uploaded to the ticket. i'll keep an eye on it | 20:04 |
| ralsina | briancurtin: yay | 20:06 |
| mmcc | lunchtime here | 20:15 |
| dobey | briancurtin: that pastebin full of lint errors is because you're missing the python-logilab-common package from ppa:ubuntuone/nightlies | 20:17 |
| briancurtin | dobey: yeah i added that and got it down to two TODOs | 20:17 |
| dobey | ah i see; you added that | 20:17 |
| dobey | i hate cmake | 20:29 |
| ralsina | dobey: need a hand with anything? | 20:31 |
| dobey | well, i added a bit to set CFLAGS so it would build with -g -O2 -Wall -Werror; which it does; because i thought that was the problem with the empty -dbg package | 20:32 |
| dobey | so now i have libu1db.so.1 with symbols; but it's not stripped in the debian/tmp/ directory | 20:33 |
| dobey | and the -dbg package is still empty, and i have no idea why | 20:33 |
| dobey | but since everything workse nice and automagic with autotools libs (libsyncdaemon); i can only imagine it's soemthing related to cmake | 20:34 |
| ralsina | dobey: probably :-/ | 20:35 |
| ralsina | dobey: did you try -DCMAKE_BUILD_TYPE ? | 20:37 |
| dobey | no, but i have no idea what that is | 20:38 |
| ralsina | dobey: you can set it to debug or release and will adjust the CFLAGS accordingly | 20:38 |
| dobey | i can't exactly run ./configure --help with cmake :( | 20:38 |
| ralsina | dobey: right | 20:38 |
| ralsina | dobey: so it would be cmake -DCMAKE_BUILD_TYPE debug | 20:38 |
| dobey | but i suppose that won't help | 20:39 |
| ralsina | dobey: http://www.cmake.org/cmake/help/v2.8.9/cmake.html#variable:CMAKE_BUILD_TYPE | 20:39 |
| dobey | wish i could -DCMAKE_STOP_BEING_SO_DIFFICULT | 20:40 |
| ralsina | dobey: I have to leave in a bit but if you mail me the details to get where you are, I can give it a try tonight or early tomorrow | 20:42 |
| alecu | briancurtin: ping | 21:37 |
| alecu | briancurtin: I get a conflict while merging this: https://code.launchpad.net/~brian.curtin/ubuntu-sso-client/py3-unicode-part-3/+merge/119586 | 21:38 |
| alecu | briancurtin: I branched trunk, merged the prerequisite lp:~brian.curtin/ubuntu-sso-client/remove-SyncTimestampChecker and then merged py3-unicode-part-3, and got the merge conflict there. | 21:39 |
| ralsina | alecu: the "we don't care about pylint" in that branch is because I have decided we are moving away from it | 21:41 |
| alecu | ralsina: awesome | 21:42 |
| ralsina | alecu: it's very broken on windows, and doesn't even seem to work right in mac | 21:42 |
| ralsina | plus we have to use patched eggs, patched debs, it's pain | 21:42 |
| alecu | ralsina: was I too sleepy when you mentioned this? | 21:43 |
| ralsina | alecu: dunno :-) | 21:43 |
| alecu | ralsina: btw: big +1 on my part | 21:43 |
| ralsina | alecu: let me find the time :-) | 21:43 |
| ralsina | alecu: 15:44 ART | 21:44 |
| ralsina | alecu: the only problem there seems to be is that gettext.install makes it throw a warning | 21:45 |
| ralsina | because it defines "_" weirdly | 21:45 |
| alecu | that's great then. I'm catching up with those bits from the backlog. | 21:46 |
| alecu | ralsina: thanks! | 21:46 |
| ralsina | alecu: sorry about not bringing you into the decision, but pylint was making the whole channel suffer at the time | 21:47 |
| === salgado is now known as salgado-afk | ||
| dobey | we'll figure out the _ thing | 21:49 |
| === JanC_ is now known as JanC | ||
| dobey | alright, have a good evening all | 21:58 |
| briancurtin | alecu: yay, yet another conflict. merging that one right now | 22:00 |
| diogobaeder | [off-topic] does anyone know how to find a memory chip by address? Because I've had a memtest error and the memory address where it happened, but have no clue how to know which chip is giving me problems so that I replace only that one | 22:16 |
| briancurtin | the two times ive had issues i just went the manual route of testing each stick until i found it | 22:17 |
| === m_conley` is now known as m_conley_away | ||
| alecu | diogobaeder: I had timing issues with some combinations of dimms, that would not show up when testing just one module... | 22:19 |
| alecu | diogobaeder: so: try playing with some of the memory settings too. | 22:20 |
| diogobaeder | alecu, ah, it might be it, then... cause I mixed different chips, with different frequencies :-) | 22:20 |
| diogobaeder | alecu, nice, thanks for the hint! :-) | 22:20 |
| diogobaeder | (I'll try running memtest with a pair, today, and run with the other pair tomorrow) | 22:21 |
| alecu | diogobaeder: that sounds more likely, yes. Though I had those issues with a set of four same brand, same model dimms bought the same day :-( | 22:21 |
| diogobaeder | alecu, that doesn't sound good :-( | 22:22 |
| alecu | strange thing was that they would work when used in pairs. | 22:23 |
| diogobaeder | I was thinking about replacing them by a 4-chip closed pack, do you think my chances to not have these issues again are high? | 22:23 |
| alecu | diogobaeder: no, I don't think the chances are high! | 22:23 |
| diogobaeder | alecu, okay... well, I'll run the tests with isolated pairs, to see if at least they work separately | 22:24 |
| alecu | diogobaeder: I did some reading on bios memory settings at the time, and even played a bit with those; but running those tests take forever, and left the computer unusable. | 22:25 |
| alecu | so at the time (say, 5 years ago) it made more sense to just use a pair than to replace the motherboard. | 22:26 |
| diogobaeder | alecu, ack | 22:27 |
| alecu | Oh, and let me know how it turned out! | 22:28 |
| diogobaeder | alecu, sure! :-) | 22:31 |
| diogobaeder | brb | 22:31 |
| alecu | briancurtin: I still got some merge conflicts in the unicode-3 branch | 22:56 |
| briancurtin | not surprised | 22:56 |
| briancurtin | so sick of lp/bzr | 22:56 |
| alecu | briancurtin: you've probably not used git much ;-) | 22:57 |
| briancurtin | i used it enough to know it's crap | 22:57 |
| briancurtin | ive used hg the most and it is awful | 22:57 |
| briancurtin | would rather just have a shared FTP some days | 22:58 |
| briancurtin | alecu: i just did a fresh branch of trunk, merged the SyncTimestampBranch, then merged py3-unicode-part-3 and got no conflicts | 23:01 |
| alecu | briancurtin: try running the tests on it | 23:02 |
| === salgado-afk is now known as salgado | ||
| briancurtin | ugh | 23:02 |
| briancurtin | there it is | 23:02 |
| alecu | briancurtin: you don't mind if I re-review it tomorrow morning, right? | 23:05 |
| briancurtin | alecu: that's perfectly fine, it's already late for you | 23:05 |
| alecu | since I'm EODing about now :-) | 23:05 |
| alecu | ok, bye all! | 23:05 |
| * mmcc eo'd | 23:33 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!