/srv/irclogs.ubuntu.com/2012/08/17/#ubuntuone.txt

=== Madkiss_ is now known as Madkiss
=== teknico_ is now known as teknico
ralsinagood morning!12:08
mandelralsina, morning!12:12
ralsinahi mandel12:13
mandelralsina, I'm setting the jenkins machine.. I hope that running the tests is faster than having brew compile qt12:13
mandelralsina, it has been compiling for several hours, is like going back in time12:14
ralsinawell, unless you run into the same issues mmcc was having with qt versions...12:14
ralsinaOTOH, it may well be too slow to test all commits12:15
mandelralsina, question, I'm updating the installation process (the google doc has missing parts), should I update that doc and post it in the RT?12:15
mandelralsina, AFAIK we have to let is know how to do it and expect them to do it next time, right?12:16
ralsinamandel: not totally sure about that12:16
ralsinamandel: ask pfibiger12:16
pfibigerralsina, mandel: anyplace you want to document is fine. wiki, google doc, etc.12:17
pfibigerand yeah, it'll get handed off to webops and they'll totally rebuild the vms themselves, using your instructions12:17
pfibigerand maintain them going forward.12:17
mandelpfibiger, ralsina, canonical or ubuntu wiki seems more reasonable right? specially because the set up is also useful for new developers12:18
ralsinamandel: ubuntu wiki should be ok12:18
ralsinamandel: like the windows one12:18
mandelralsina, ok, is the windows one up to date, buildout etc..?12:18
ralsinamandel: AFAIK yes, have not tried it lately. All changes have been inside the buildout12:19
ralsinamandel: we should have brian do a review of that one in a couple of weeks12:19
mandelralsina, yes, that would be great, is not that we are going to have lots of developers wanting to contribute for the mac and windows versions (I'm not longer going to call them ports ;) ) but is good for the house keeping12:20
mandelralsina, I'm off to have lunch bbl12:24
ralsinabye mandel!12:24
* mandel_ back14:02
alecu_hello, all!14:05
mandel_alecu_, buenas14:06
* mandel_ is over 3g :-(14:07
ralsinahola alecu!14:07
ralsinamandel_: why? Your other you seems to be alive and well :-)14:07
mandel_He is not longer, the other is a bip server14:08
=== mandel_ is now known as mandelQwerty99
=== mandelQwerty99 is now known as mandel
mandelMuch better  :-)14:10
mandelAlso, I hate how bad is setting 3g on the Mac..14:10
mandelmmcc, when you are back, while the hack works we need to consider a better approach, its not a good idea to do that for windows too14:14
dobeyhttps://launchpad.net/ubuntu/+source/u1db14:52
mmcchi everyone14:55
mmccmandel: agreed.14:55
mandelmmcc, maybe in filenotifier is a better option14:56
mandelme15:00
briancurtinme15:00
mmccme15:00
ralsiname15:01
dobeymeh15:01
ralsinagatox is not around today15:02
ralsinaalecu_: standup?15:02
ralsinathisfred: standup?15:03
ralsinamandel: go, alecu and thisfred will come around eventually15:04
mandelDONE: started Jenkins setup for Mac vm (compiling the deps takes a ridiculous time). Done with the integration of ddcli DVD the daemon, code tests are much better now.15:04
thisfredme15:05
mandelDid you get it?15:05
thisfredDONE: documentation TODO: documentation BLOCKED: no15:05
thisfrednext alecu_15:05
ralsinathisfred: eh?15:05
ralsinamandel: you didn't do a NEXT15:05
briancurtinDONE: port setup.py to python3, building out environment with all deps15:05
briancurtinTODO: skip uses of mocker, see what else needs to happen as things build out15:05
briancurtinNEXT: mmcc15:05
mmccDONE: fought pyqt, qt, u1cp test weirdness. proposed last buildout test fix15:05
mmccTODO: start on integration code for fsevents daemon, think about performance tests15:05
mmccBLCK: want to talk about u1c test weirdness15:05
mmccNEXT: ralsina15:05
mandelI did15:05
ralsinaDONE: team call, 1-1s, canonicaladmin, reviews, helped around, planning & scheming TODO: fix stuff, help around, reviews BLOCKED: no, NEXT dobey15:05
dobeyDONE: team meeting, 12.04.1 SRU poking15:05
dobeyTODO: reviews, discuss icons, FF rush15:05
dobeyBLCK: None.15:05
dobeythisfred: go15:06
ralsinadobey: did you get the icons share from lisette?15:06
thisfredralsina, oops sorry, figured we were all done...15:06
ralsinathisfred: np15:06
dobeyralsina: yes15:06
mandelralsina, it was at the end, just after the block15:06
ralsinadobey: we can probably generate everything from any of the SVGs, or we can use the separate ones in case she does res-specific tweaks later15:07
mandelBut I indeed did not say next..15:07
ralsinamandel: I only got a DONE from you15:07
alecu_oh, standup15:08
* alecu_ writes15:08
mandelralsina, let me paste the rest15:08
dobeyralsina: it's certainly possible to generate everything from SVGs15:08
ralsinasloppiest standup *ever*15:08
mandelTODO: propose MPs. Add projects to Jenkins.15:08
mandelBlocked, no15:08
ralsinadobey: yes, I am not sure if we should generate from the big svg or from each svg generate one size only15:09
* mandel hates 3g15:09
lisettteralsina, dobey: can we chat about this?15:09
dobeyralsina: no we have to have different icons for some different sizes (some are ok to scale)15:09
ralsinadobey: yes, I know that. I must be very unclear today :-)15:09
ralsinadobey: nevermind :)15:10
ralsinalisettte: dobey, mumble?15:10
lisettteralsina: yep15:10
alecu_DONE: some reviews, calls, researched piston-mini-client, and this small branch needing reviews: https://code.launchpad.net/~alecu/ubuntu-sso-client/fix-ssl-unicode/+merge/12001315:10
alecu_TODO: learn a bit more about ubuntupay15:10
alecu_BLOCKED: no15:10
dobeyok15:11
alecu_NOTE: I'm working from across the pond today, so I'm having limited conectivity15:13
=== alecu_ is now known as alecu
dobeyok, lunch time; bbiab15:24
mmccmandel, have you done any work on making your daemon 32-bit compatible? You can probably avoid it. It looks like uname -p on darwin doesn't mean what I think it should mean.15:26
mandelmmcc, no I have not done that yet, what have you found out?15:27
mmccthe man page says "-p    print the machine processor architecture name" - so you'd think that if it prints i386, then you don't have an x86_64 processor, right? well, that sounds weird so I should've double checked. it prints i386 on my new macbook, too15:28
mmccand I should've remembered that the core 2 duo in my mac mini is x86_64. it's not *that* old15:28
mmccanyway, let's compile your daemon for 64 bit only so we can avoid changing the instance variable definitions.15:29
mmccthis doesn't affect ARC though15:29
mmccstill no arc on 10.6 so that wasn't wasted effort :)15:29
mandelmmcc, ok, I'll play a little with the compiler flags to see whathappens15:30
mandelI can always try to make it run on rosseta  ;-)15:30
mmccmandel: I don't think you need to play - the flags as you've got them in the projects I've seen are 64-bit-only15:31
mmccmandel: talk about wasted effort! :)15:31
mmccso uh, did any of you mac-having guys get my email last night about the control-panel test issues?15:31
mandelLol15:32
mandelmmcc, got it, but I have not tried it yet15:32
mmccmandel: ok. you have run control-panel tests on your mac at some point right? so I'm guessing you don't see the slowdown issue15:34
mandelmmcc, not much as far as I cab remember, I'll try in the lion vm15:35
mandelcan15:35
mmccmandel: ok, cool. thanks15:35
mandelstupid fingers..15:36
mandelmmcc, no problem15:36
=== salgado is now known as salgado-lunch
mandelEOD, I'm off to the swimming pool16:13
mmccwell, anyone else have a sec to try running u1cp tests on a mac? ralsina, alecu ?16:20
ralsinammcc: leaving for a doctor appointment / lunch16:21
mmccralsina: ok, no prob. I hope those are separate things16:22
ralsinaI may have lunch with a doctor!16:22
ralsinabut yes, separate things16:22
alecummcc: I can give that a try16:24
briancurtini too am heading to lunch/doctor, also separate things16:25
* briancurtin out16:25
=== salgado-lunch is now known as salgado
mmccthanks alecu.16:28
mmccI might need to see a lunch doctor16:28
dobeymmcc: put the lime in the coconut, and mix it all up16:28
mmccdobey :)16:28
mmccdobey, should I switch control-panel run-tests to USE_PYFLAKES now? I'm changing it to remove the env vars for the new buildout…16:29
dobeymmcc: i guess not unless you want to fix all the lint warnings it will create upon doing so16:29
alecummcc: I've checked out https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/improve-buildout/+merge/11919516:32
alecummcc: to start with a clean env16:32
alecummcc: so, how should I run it?16:33
mmccdobey: hmm, so, maybe just use pyflakes on darwin now? since the need to fix the warnings is due to tarmac, right?16:33
alecupython setup-mac.py prepare --from-trunk py2app ???16:33
mmccalecu, follow the 'dev-setup' google doc instructions first16:33
dobeymmcc: the need to fix the warnings is that we haven't been using pyflakes so it probably has warnings that we haven't paid any attention to16:33
dobeymmcc: you should see them on darwin too if you use pyflakes there16:33
alecummcc: I've already have the brew packages installed in this machine16:34
mmccdobey: right, and I do, but I also see tons of pylint warnings because it's broken for me on darwin16:34
mmccalecu, right - skip to the buildout section - cd scripts/devsetup16:34
alecummcc: qt 4.8.2 and pyqt 4.9.416:34
mmccalecu, ok. interesting…16:35
mmccalecu, then python bootstrap.py --distribute, and bin/buildout install16:35
dobeymmcc: well if you want to switch to get rid of the warnings, and fix the new ones in pyflakes, then i think it's ok to switch it everywhere. whatever we do, it should be the same on all platforms16:35
mmcc(don't do "bin/buildout install development" anymore, i'll update the doc once this branch lands)16:35
mmccdobey ok I'll hold off for now because I don't know how to fix the warnings about gettext16:36
dobeyah yes, i need to poke at that16:37
dobeyi hope i don't have to do any reviews today16:44
dobeyalthough, getting this reorg stuff done/packaged/MIRed before FF is not very likely at this point :-/16:44
* mmcc was just about to ask dobey for a quick review of run-tests changes…16:46
mmccthere are actually three pending run-tests fixes but two are mac only16:46
dobeyheh16:46
mmccdobey, maybe just a visual review of https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1037904-run-tests/+merge/12005716:49
dobeyand the current launchpad builders situation isn't helping me any :)16:49
mmccand I won't bug you with the others :)16:49
dobeyand code hosting going offline in ~5 hours surely won't add to that fun16:50
dobeymmcc: so i've noticed this; why all the getting rid of the special variables for u1lint/u1trial? you fixed the buildout i guess, to not require that nonsense?16:51
mmccdobey: yes. the fixed buildout actually installs executable scripts named u1lint and u1trial in its bin/ directory16:52
dobeyawesome16:52
mmccthat's over here: https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/improve-buildout/+merge/119195 if you're curious and you like pain16:52
dobeyare they the ones from the source pull, or from the egg downlaod, or we don't do the egg download any more?16:52
mmccthey are the ones from the source pull and we don't do the egg download anymore16:52
dobeyawesome16:53
dobeyAPPROVE16:53
mmccor to be more specific, it installs wrappers that manually set sys.path to include the source dirs, and then the wrapper does the same thing as u1trial and u1lint -- it doesn't actually call the executables in bin/ because buildout is difficult16:54
mmcclet me know if you want details - the scripts will work as long as you don't add new code to the bin/u1trial script outside of main()16:55
mmccthere was so much code in bin/u1lint outside main that the wrapper script has to do imp.load_source('bin/u1lint') - but that means that changes will get picked up just fine16:56
mmccanyway16:56
mmccoh I see that wasn't the rhetorical APPROVE :) thanks16:58
dobeyheh17:03
dobeywell u1trial is all modularized now17:04
mmccyeah, there's just the one line where it inserts '.' on sys.path. I just copied that over to the wrapper script17:05
mmccbuildout lets you add code to the wrapper script, but then it strips that code of all indentation.17:06
mmccjust had to share that bit, that was fun17:06
alecummcc: after some back and forth, I managed to start the u1cp tests in your review branch17:11
alecummcc: now osx is asking me if I want to install X1117:11
alecummcc: are we using it at all?17:11
mmccalecu: well, *that* is unexpected17:11
alecummcc: (this is 10.8)17:11
mmccno, we shouldn't be17:11
alecummcc: the dialog says "X11 is no longer included with os x.... blah blah"17:11
mmccbut I haven't tried anything on 10.817:11
mmccyeah… I wonder if qt was built with x11 support or something17:12
dobeyprobably17:12
alecummcc: it sent me here: http://support.apple.com/kb/HT529317:12
mmccalecu: yeah, xquartz is great but don't get it unless you really need x11. we should not require it17:13
mmccI'm looking at the brew recipe for qt now17:13
alecummcc: anyway, I need to run to the bank now, and then catch a ferry17:14
mmccalecu: ok, i'll let you know what I figure out17:14
alecummcc: I'll probably be looking at this when I get back home.17:14
alecummcc: btw: the buildout process is a lot more streamlined now, good job!17:14
mmccalecu: thanks. it's nice to have it fixed17:15
mmccOK, apparently the homebrew recipe for Qt built in a dependency on X11 to get libpng. AFAICT that's the only dependency17:25
alecummcc: good news: after installing xquartz, all tests have passed on u1cp17:26
mmccsomeone on github has already posted a modified version the recipe that just does a direct dep on that, so I'll see how easy it is to switch over.17:26
mmccor if we don't need to, and the answer is just install xquartz on the dev machines17:27
alecuthis is using both branches mentioned in your email.17:27
mmccalecu, I'm not sure that is good news… so you saw no error dialogs?17:27
mmccand no 'counter' exceptions?17:27
alecummcc: I saw *a lot* of dialogs being opened by the tests17:28
alecummcc: but no test failed17:28
mmccalecu: that's expected, and no tests should fail in either case.17:28
alecummcc: and I think I didn't see any weird dialog but ours.17:28
mmccbut the issue I saw on 10.7 was a lot^2 of error dialogs with an exception about underlying object being deleted17:28
alecummcc: I'll give it another go when I get back17:29
alecunow, I really really really need to be going!17:29
mmccalecu: ok, ttyl17:29
mmccthanks17:29
alecubye!17:29
mmccalecu - when you get back, try 'brew uninstall qt' , 'brew update' and 'brew install qt' again... I think that ought to get the new version (21 days old) of the qt recipe that removes the X11 dependency17:46
ralsinahello again17:48
mmccwe *do* need to update to that version to build the app, because as of now the packaged app has a dependency on libpng from x11, and so won't run on 10.817:49
mmccgiiiiiit17:53
* dobey imagines Capt. Kirk screaming that17:54
dobeymmcc: does https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/fix-1037313-add-revnos/+merge/119799 include changes from that other buildout branch that just landed?17:55
ralsinammcc: I sense frustration. Want to vent?17:56
mmccdobey: apparently so, I should've set a prereq. can I do that after the fact?17:56
mmccralsina: oh, eh. homebrew uses git, and I need to update its copy of the qt recipe. but git checkout <hash> filename is complaining now when it didn't yesterday17:57
mmccI can just tell brew to install from a URL though so that'll do for now17:58
ralsinammcc: cool17:58
ralsinammcc: perhaps some tea and a 5 minute break, too :-)17:58
ralsinammcc: it would have helped kirk!17:58
mmccralsina: :) good idea. I have cookies. cooooookies > giiiiiit17:59
ralsinasee?17:59
dobeymmcc: i don't think you can; maybe in the resubmit ui it's possible, not sure18:00
dobeymmcc: or you could just merge trunk in and push back up18:00
dobeyalso18:01
dobeynow i want cooooooookies18:01
ralsinammcc: I suggest remerging trunk if the other branch already merged18:02
ralsinadamn, I want cookies too18:02
ralsina<kirk>raaaaaaaaaaaain</kirk>18:02
mmccback with cookies. will remerge trunk, good idea18:13
dobeycool, thanks18:14
dobeywill make it easier to read the diff :)18:14
mmccpushed18:20
dobeybrb18:39
mmcchomebrew calls "installing from a pre-built tarball" "pouring a bottle". It prints "=> Pouring..." to the screen. Why does that bother me so much?18:40
* mmcc is getting old or something18:40
mmccor maybe it's just that anything a package manager printed while I was waiting for a Qt install for the fourth time in two days would make me mad18:41
ralsinammcc: at least it doesn't try to a ascii-art bottle pouring18:41
ralsinammcc: I know of a program whose build message logs draw a color mandelbrot set on screen18:42
mmccralsina: hah.18:43
mmccactually i'd watch the ascii art. it'd be a nice progress bar18:45
ralsinammcc: not telling you to do it! But check out http://pypi.python.org/pypi/progressbar/2.3-dev18:46
ralsinammcc: turning that into a beer-pouring bottle is a nice experiment18:46
mmccralsina: heh, nice. I'll add it to the list of projects I'd like to do and never will :|18:47
ralsinammcc: hey, I have a list just like that!18:47
mmccI keep that list in my guitar case18:47
ralsinammcc: the one you will learn to play someday? ;-)18:47
mmccralsina: that's the one!18:48
* ralsina adds "buy a guitar" to his list18:48
ralsinathere, tight below "start a list (crossed out)"18:49
ralsinaright*18:49
mmccheh. progress!18:49
mmccalecu - when you get back, here's what will actually work (ignore what I said earlier): 'brew uninstall qt &&  brew install https://raw.github.com/mxcl/homebrew/master/Library/Formula/qt.rb'18:52
mmccthat works to remove the dependency on X11, which will leak from dev machines into the packaged app and make the app break on default 10.8 systems18:53
mmccnow to test to make sure it still does the captcha correctly despite no longer linking to libpng18:53
mmccthe homebrew committer claims that the fix is to just not link to libpng and qt will use 'internal' png mumble mumble.18:54
ralsinammcc: qt has a switch to choose internal or external libqt in its configure18:54
ralsinammcc: the recipe must set that somewhere18:54
mmccralsina: it doesn't mention it now, maybe internal is default18:56
mmccaha, yeah -- previously it specified -system-libpng for configure18:57
mmccnow it doesn't18:57
mmcchooray18:58
mmccbtw ralsina do you have a sec to brainstorm on that control-panel test issue? my hack lets me run the tests just fine, but I'm not sufficiently familiar with qt & pyqt to know if it's actually solving the problem18:58
ralsinammcc: in 5' sire18:59
ralsinasure18:59
mmcccool18:59
ralsinammcc: your hack makes all the test dependent on the previous ones18:59
ralsinaor leak memory18:59
ralsinadepending on what happens at initialization19:00
mmcchrm. I thought it'd just leak memory - I'm pretty sure it instantiates new UI classes in setUp.19:00
mmccmemory usage got to 600MB by the end of the tests with the hack, without it , it stays at ~140, but each test case takes ~6 seconds to run and shows many "sorry an error occurred" dialogs19:03
mmcchm, no, memory growing in the non-hack case now too19:05
ralsinammcc: in that case, then it doesn't matter19:07
ralsinammcc: it does seem to be reinitializing19:07
mmccwell, actually it went back down. it's tidy19:07
mmccer, the non-hack case is definitely using less memory, I mean19:08
ralsinammcc: so, if the problem is a "C++ object was deleted" in the deleteLater call, then commenting it should be ok19:08
mmccwell I don't know where the error is coming from - no backtrace… maybe I can try to get logs…19:09
mmccAHA - debug logs print out the backtrace, wish I'd thought of this sooner: http://paste.ubuntu.com/1153201/19:11
mmccit's calling update_sizes from a timer:         self.timer.timeout.connect(self.update_sizes)19:13
mmccis that happening after the test let the object get collected?19:13
ralsinayes19:15
ralsinaapparently19:15
ralsinabut why only on mac?19:15
mmccand only on 10.719:15
ralsinacould you add a self.timer.timeout.disconnect() before the deleteLater?19:15
mmccprobably. there's a lot of inheritance going on in these tests…19:17
mmcclooking for the right place to add it…19:17
dobeywell19:20
dobeyso much for reviews i guess19:20
dobeyOops! is all i get19:21
ralsinadobey: launchpad was down today too?19:22
ralsinadobey: for maintenance?19:22
dobeyralsina: for varying definitions of 'down'19:23
dobeyppa builders have been down-ish since sometime yesterday19:23
ralsinadobey: yeah19:23
ralsinaawesome timing19:23
dobeyralsina: yeah. the 12.04.1 team is *loving* it ;)19:24
ralsinaI can imagine19:24
ralsinahopefully everything will be up by monday, but having trunk nightlies to try the weekend before release is something I ... enjoy?19:25
dobeyyeah, i'm a bit upset about not having nightlies19:25
mmcclunch…20:15
briancurtini dont think i can keep using Q if it's going to waste my time constantly20:43
briancurtinnow the login screen thinks my monitor is like 10 feet wide and there's nowhere to type my password (also doesn't display my name either, just the box for it)20:43
dobeyfun20:48
ralsinabriancurtin: is that a Q daily?20:50
ralsinabriancurtin: they merged a whole pile of things yesterday (whole x11 stack update)20:51
ralsinabriancurtin: happens every cycle just before FF :-(20:51
dobeyand some unity changes20:51
dobeylike, no more unity2d20:51
ralsinaand a new llvm-whatever soft-rendering for unity-3d20:59
ralsinaEOW for me, except for a quick check tonight20:59
briancurtinralsina: yeah it's daily. it screwed up yesterday but i sort of got it working by switching to XFCE, sort of, but now nothing works. i'll just work on stuff from windows for now and keep trying back i guess21:03
ralsinabriancurtin: you could try removing lightdm and setting up some other-dm21:07
briancurtini'll see what the options are21:08
dobeysudo apt-get install gdm will give you the option to do that in the postinst21:10
dobeygdm is the upstream gnome dm21:10
briancurtinthankfully i remembered ctrl-alt-F1. havent had to do that in a long time21:11
briancurtineh, that does get me in but everything flashes like crazy. i guess that makes sense based on what seems to have been updated21:17
briancurtinXFCE seems to work, so i think i'm back in business21:22
ralsinabriancurtin: godspeed :-)21:23
dobeyhave a good weekend everyone21:48
briancurtinbye dobey21:49
* alecu peeks around.22:20
alecuhello!22:20
briancurtinjust about to head out of here, but hola alecu22:20
alecubye briancurtin, have a great weekend!22:21
briancurtinyou too22:21
mmccoh hi alecu. bye briancurtin22:29
mmccalecu, looks like there's a way to avoid that X11 dep, but for now you don't need to worry about it. Glad you caught it now, though :)22:29
alecuWarning: Your Xcode (4.4) is outdated23:05
alecuPlease install Xcode 4.4.1.23:05
alecuthanks brew!23:05
alecuwow, pouring a bottle was much faster than brewing my own qt. It makes sense :P23:23
alecummcc: in case you are still around:23:27
alecuRan 1143 tests in 39.321s23:27
alecu(control panel, qt tests)23:27
mmccok… so no speed issues. and it's on 10.8. maybe my issue is just 10.7?23:28
alecummcc: I had installed the custom qt brew formula, and uninstalled x1123:28
mmccdoes it print any exceptions as it runs?23:28
mmccgood, glad that works for someone else :)23:28
alecummcc: no exceptions at all, and no dialog boxes (other than the dialogs we are testing)23:29
mmccargh23:29
alecuargh indeed23:30
alecummcc: we should ask ralsina to run these tests on monday on his macmini, since it should still be on 10.723:30
mmccah, yeah. that'd be interesting23:30
alecummcc: also, we can posibly ask him to share it with vnc or the like so you can fidget with it.23:31
alecu(fidget? is that the real word I wanted to use?)23:31
mmccmaybe fiddle23:31
alecummcc: yeah, fiddle. thanks!23:32
alecuunless you get really nervous while fighting qt, and in that case it would be fidget all right :-)23:32
mmccI'm wondering if I've wasted enough time on this. I have a hacky workaround for my system. I guess it's worth seeing if ralsina has the issue too, but if he doesn't I'm ready to just give up - since it is only a problem with cleaning up tests…23:32
mmccand only on one platform23:33
alecummcc: I thought it was making the tests real slow for you, too.23:34
mmccI think flail, flounder and flog are all appropriate here.23:34
alecummcc: if they run in a reasonable amount of time on your machine and on our 10.7 jenkins, then yes, let's not worry.23:34
* alecu runs for the dictionary23:34
mmccit was - but if I comment out the deletelater as I mentioned in the email last night, everything runs fine. It just uses about 2-3x more memory :)23:34
alecummcc: then, as long as we don't break the jenkins vm, or your dev machine...23:36
alecu:-)23:36
mmccso, hacky - not what I'd want to commit, but trying to find a more correct fix has cost me hours today with nothing so far. The problem is that the local_folders page is instantiated every time you start a wizard, so all the tests create one, and some of them call load() which starts the timer, and others don't, and it's just a mess trying to figure out what test case superclass to poke at23:36
* alecu hates the hackiness that comes from mixing unit and integration tests :/23:39
alecummcc: what about mocking the timer all of the time?23:40
alecu(all of the time... see what I did there?)23:40
mmccheh23:40
alecummcc: or at least, not mocking it when testing the timer itself.23:40
mmccoh don't worry, the timer isn't tested23:40
alecummcc: though I don't recall if those bits of PyQt are mockeable.23:41
mmccI did try mocking the timer, but I had trouble figuring out which test case class to patch - it seemed like I would always end up trying to patch something that didn't have a timer23:41
alecummcc: I mean, patcheable.23:41
mmccalong with something that did23:42
mmccyeah, I ran into that too :)23:42
mmccso i was just going to call timer.timeout.disconnect() in setup, but again, a twisty maze of test case class hierarchies23:43
alecuyup... I know about that :P23:43
mmccI'm sure it's possible to get right, I was just wondering if it's really worth the effort to get right23:43
alecummcc: probably not23:43
alecummcc: as long as it runs decently enough for you and for our 10.7 vms, let's move forward.23:44
alecummcc: if it gets very slow or eats a lot of ram, let's fix it then.23:45
alecummcc: obviously, my opinion would be other if the problem was with production code, not with the tests...23:45
mmccdefinitely23:45
alecuok, this looks like EOW for me!23:46
alecubye all!23:47
mmccalright, thanks for sticking around - have a great weekend alecu23:47
alecuyou too, sir!23:47
mmccok, time for me to go23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!