| === lifeless_ is now known as lifeless | ||
| JamesTait | Good morning all! :) | 08:40 |
|---|---|---|
| jgdx | Good morning! | 08:48 |
| mandel` | morning all!! | 08:49 |
| === mandel` is now known as mandel | ||
| === zyga is now known as zyga-afk | ||
| gatox | good morning! | 11:10 |
| mandel | gatox, morning! | 11:35 |
| mandel | how is everything going :) | 11:36 |
| mandel | gatox, have you seen the following: | 11:36 |
| gatox | mandel, fine..... you? | 11:36 |
| mandel | http://www.omgubuntu.co.uk/2012/08/new-mac-app-brings-ubuntu-one-to-os-x | 11:36 |
| mandel | gatox, ok, got the mac vm ready to be a jenkins slave.. I was suppose to start later to day, but I ran out of things to do :P | 11:37 |
| gatox | mandel, no...... didn't see that! | 11:37 |
| gatox | mandel, are you already started your working day?? or are you going to start late today?? (i wanted to asj you for a review.... but i can wait) | 12:02 |
| gatox | s/are/have | 12:03 |
| mandel | gatox, sure, I started a few hours ago when I ran out of errands hehe | 12:03 |
| gatox | mandel, ok, this one please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/transfers/+merge/119932 | 12:03 |
| mandel | gatox, I've been done 'work work' for a few hours already :P | 12:03 |
| mandel | gatox, although, I'm in a virtual sprint with mmcc so when he is here no reviews | 12:04 |
| mandel | gatox, why not using u'' in the strings? | 12:04 |
| gatox | mandel, this string? | 12:05 |
| gatox | RECENTTRANSFERS = 'recent-transfers' | 12:05 |
| gatox | 10+UPLOADING = 'uploading' | 12:05 |
| mandel | yes, those | 12:07 |
| mandel | gatox, ^ | 12:07 |
| gatox | mandel, they are dictionary keys.... so i don't see the need to use unicode | 12:07 |
| mandel | gatox, ok, but remeber they will be unicode as soon as we move to py3 | 12:08 |
| mandel | gatox, that is the only reason I'm asking :) | 12:08 |
| gatox | mandel, yes, but.... if we use those constants is going to be the same | 12:08 |
| gatox | everything is going to be converted | 12:08 |
| gatox | and we avoid the u'' now, that is doesn't fit into py3 | 12:09 |
| mandel | gatox, sure, I was concerned that you wanted bytes and not unicode | 12:10 |
| === zyga-afk is now known as zyga | ||
| * mandel lunch | 12:31 | |
| dobey | ugh, not feeling so great today :( | 12:57 |
| ralsina_ | good morning! | 13:01 |
| gatox | ralsina_, dobey hi | 13:01 |
| === ralsina_ is now known as ralsina | ||
| dobey | hi gatox | 13:09 |
| ralsina | gatox: one of your branches failed a test | 13:13 |
| gatox | ralsina, yes, already fix it | 13:14 |
| * mandel back | 13:14 | |
| ralsina | ok, slow mail :-) | 13:14 |
| gatox | oh.... it fail again | 13:14 |
| mandel | ralsina, 1-1? | 13:14 |
| alecu | hello all! | 13:14 |
| mandel | gatox, having fun with tarmac ;) | 13:14 |
| gatox | alecu, hi | 13:14 |
| ralsina | mandel: sorry, have to talk with alecu and then I have another call | 13:14 |
| ralsina | mandel: so, maybe in 45'? | 13:14 |
| mandel | ralsina, so, np | 13:14 |
| ralsina | alecu: mumble? | 13:15 |
| gatox | mandel, ralsina i'll need to review some of the tests.... the problem is that i can't run u1-client tests locally | 13:15 |
| mandel | ralsina, I meant to say sure :) | 13:15 |
| ralsina | mandel: understood :-) | 13:15 |
| mandel | gatox, how come? | 13:15 |
| gatox | mandel, some problem that thursday..... a lot of asserts are failing | 13:15 |
| mandel | gatox, ugh | 13:15 |
| mandel | gatox, let me try and fix something with jenkins and I'll take a look | 13:16 |
| gatox | ah..... i'll run them on windows... | 13:16 |
| ralsina | gatox: was it asserting user_home to be str? | 13:17 |
| ralsina | gatox: because dobey fixed that one | 13:17 |
| alecu | ralsina: sure | 13:17 |
| gatox | ralsina, mmmm and i need to do something in particular?? i did a dist-upgrade today and it keeps failing here | 13:18 |
| gatox | ralsina, or i need to update u1-client branch? | 13:18 |
| dobey | gatox: you don't have u1-client trunk then | 13:18 |
| ralsina | gatox: merge trunk | 13:18 |
| gatox | ahhhhh ok... i'll merge that | 13:18 |
| dobey | so everything done for FF releases? :P | 13:32 |
| gatox | dobey, not yet | 13:32 |
| === m_conley_away is now known as m_conley | ||
| mandel | mmcc, morning! I ran the tests in the jenkins slave, and although they were slow things were ok | 14:10 |
| mandel | mmcc, and I'm nearly done with the jenkins setup (I started a few hours ago when I ran of things to do in the morning :P ) | 14:11 |
| gatox | mandel, this branch has been updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/transfers/+merge/119932 | 14:11 |
| gatox | ralsina, when you have a moment please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/shares/+merge/120394 | 14:12 |
| mmcc | hi mandel, so how slow were they? did they show GUI exception dialogs? | 14:13 |
| mandel | mmcc, the machine is veeeeeeery slow so I left it over night and did not see any exception dialogs when I got back | 14:13 |
| mmcc | hmm. | 14:13 |
| mmcc | well, I gave up on a clean solution on friday - the hacky fix I wrote in my email works for now | 14:14 |
| mmcc | the dialogs pop up and go away very fast, so you wouldn't have seen them after the run | 14:15 |
| mandel | mmcc, ok, I'm nearly done with the jenkins setup so that we at least have sso running on it so that we stop other team members from screwing us up, we can focus on landing the small fixes I have for the daemon and then I'#ll look at the fsevents bug | 14:17 |
| mandel | mmcc, we also need to look at how to integrate the root daemon in the bundle, right? | 14:17 |
| mmcc | right. I started looking at code signing a python app a bit on friday, I'll keep doing that now | 14:18 |
| mmcc | mandel - let me know when you're done with the jenkins setup | 14:19 |
| mandel | mmcc, superb, if I get the slave connected I'll just have to set it as a daemon process for the vm and will be done | 14:20 |
| gatox | me | 15:00 |
| gatox | ralsina, mmcc mandel dobey briancurtin thisfred standup? | 15:00 |
| briancurtin | typing now | 15:00 |
| thisfred | mr | 15:00 |
| thisfred | me | 15:00 |
| ralsina | I'm otp go on without me | 15:01 |
| briancurtin | me | 15:01 |
| mandel | me | 15:01 |
| dobey | meh | 15:01 |
| mmcc | me | 15:01 |
| gatox | DONE: | 15:02 |
| gatox | Last branch of the sync menu about New Shares proposed. Working on Share links tab for control panel. | 15:02 |
| gatox | TODO: | 15:02 |
| gatox | Finish with share links tab ui and some functionality. | 15:02 |
| gatox | BLOCKED: | 15:02 |
| gatox | No | 15:02 |
| gatox | thisfred, go | 15:02 |
| thisfred | DONE: documentation2 through 4, started on lp:gouda over the weekend TODO: documentation5 and up BLOCKED: no NEXT: briancurtin | 15:02 |
| briancurtin | DONE: removed mocker, updated and broke the VM and fiddled with it most of the afternoon | 15:02 |
| briancurtin | TODO: keep running, piecing together what's needed, removing what's not | 15:02 |
| briancurtin | NEXT: mandel | 15:02 |
| mandel | DONE: Lion VM has been setup to be able to run all the projects tests. Jenkins is setup and but connecting to the master node is timing out, no idea why. Reviews. | 15:03 |
| mandel | TODO: Finish the jenkins work if possible and add projects for the python projects, the daemon is a diff story (need an xcode plugin). Look at fsevents bug. | 15:03 |
| mandel | BLOCKED: no | 15:03 |
| mandel | dobey, please | 15:03 |
| mandel | oh, and 1-1 with ralsina | 15:03 |
| dobey | DONE: reviews, discuss icons, | 15:03 |
| dobey | TODO: releases, FF rush, icon generating magic | 15:03 |
| dobey | BLCK: None. | 15:03 |
| dobey | mmcc: go | 15:03 |
| mmcc | DONE: built a Qt with no x11 dependency, fought control-panel tests | 15:03 |
| mmcc | TODO: sprint w/mandel to integrate fsevents daemon, code signing. | 15:03 |
| mmcc | BLCK: no | 15:03 |
| gatox | eod? | 15:04 |
| gatox | comments? | 15:04 |
| thisfred | little early | 15:04 |
| thisfred | but sure :) | 15:04 |
| mmcc | mandel, what do you need an Xcode plugin for with jenkins? | 15:05 |
| gatox | eom :P | 15:05 |
| gatox | thisfred, jjeje | 15:05 |
| gatox | briancurtin, do you have time for a review? | 15:05 |
| briancurtin | gatox: sure, send it | 15:05 |
| mandel | mmcc, to run the daemon tests and get them as a subunit format so that it can be parsed by jenkins and show the test results | 15:05 |
| gatox | briancurtin, https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/shares/+merge/120394 thx! | 15:05 |
| mandel | mmcc, it exists but I don't want to waste time on that right now | 15:06 |
| mandel | mmcc, got reviews related to mac for me? | 15:06 |
| mmcc | mandel: ah, ok - not just to run them, but to post process the output… | 15:06 |
| mandel | mmcc, yes, to make the things useful we could say, it could only run them and say ok or not, but you would not get the nice results we get on the windows version | 15:07 |
| mmcc | mandel, yes: https://code.launchpad.net/~mikemc/ubuntuone-windows-installer/fix-1037313-add-revnos/+merge/119799 https://code.launchpad.net/~mikemc/ubuntu-sso-client/fix-1037395-run-mac-tests/+merge/119830 https://code.launchpad.net/~mikemc/ubuntuone-client/fix-1037432-run-mac-tests/+merge/119842 https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1037904-run-tests/+merge/120057 | 15:07 |
| mmcc | not sure if you've already looked at any of those… | 15:07 |
| mmcc | no you haven't | 15:08 |
| ralsina | mandel: 1-1? | 15:08 |
| ralsina | mmcc: at least the 1st one you could merge with 1 review | 15:08 |
| mandel | ralsina, sure, mumble? | 15:08 |
| ralsina | mandel: yes | 15:08 |
| mmcc | ralsina: ok, thanks. the other three are also trivial but I'd like someone else on a mac to try the CP test changes. (this is just the buildout change, not related to the issue I was fighting friday.) (talking about this branch: https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1037904-run-tests/+merge/120057 ) | 15:10 |
| * gatox lunch! | 15:20 | |
| === gatox is now known as gatox_lunch | ||
| mandel | mmcc, did you create a bug regarding the fsevents error? | 15:27 |
| mmcc | mandel: what error? the test running problem? no | 15:27 |
| mandel | mmcc, the one with the lack of upload in a create file | 15:28 |
| mandel | mmcc, which you wrote a quick 2 liner hack to fix | 15:28 |
| mmcc | oh that one. yes, hold on | 15:28 |
| mmcc | https://bugs.launchpad.net/ubuntuone-client/+bug/1034127 | 15:29 |
| ubot5 | Error: ubuntu bug 1034127 not found | 15:29 |
| mmcc | ubot5: put your glasses on | 15:29 |
| ubot5 | mmcc: I am only a bot, please don't think I'm intelligent :) | 15:29 |
| mmcc | :D | 15:29 |
| mandel | I have the impression we are getting close to a deadline, jenkins fails, ubot5 is stupid.. timeouts, failing tests.. | 15:30 |
| === eu is now known as Guest97966 | ||
| mandel | mmcc, can you do me a favour, in the bug report you say the following: 'folder will be uploaded and become visible in web interface' did you use a file or a folder for the test? | 15:32 |
| ralsina | mandel: you still have not been bitten by a rabid dingo... | 15:32 |
| mmcc | mandel: I tried both. either should show the bug. | 15:33 |
| mandel | mmcc, can you add a comment and let me know what happens if you do it with a file and when you do it with a folder? | 15:33 |
| mandel | mmcc, and if you can the app, can I haz an already build version? /me is lazy | 15:33 |
| * dobey hopes it stops raining soon, and dries up | 15:33 | |
| mmcc | mandel: sure, I'll need to rebuild it without the hack, just a minute :) | 15:34 |
| mandel | mmcc, awesomeness on irc o/ | 15:35 |
| mmcc | :) | 15:36 |
| briancurtin | gatox_lunch: for that review, the TODO comments are being addressed in another branch, right? just want to make sure it wasnt something you forgot for this one | 15:39 |
| briancurtin | er, comment, since there's just one | 15:39 |
| dobey | ok, need to get lunch. bbiab | 15:41 |
| === salgado is now known as salgado-lunch | ||
| mandel | mmcc, I'll be testing that bundle to see if I can reproduce it | 15:51 |
| mmcc | mandel: ok - I'm sending you another build now to make it easier to debug… | 15:53 |
| mandel | mmcc, superb, I want to see what happens to write the tests correctly | 15:57 |
| mmcc | yeah, this debug build should help, can add prints and just re-run -- just edit the code in UbuntuOne.app/Contents/Resources/lib/python2.7/ubuntuone/ | 15:59 |
| mmcc | 44% uploaded | 15:59 |
| mandel | great | 16:00 |
| mandel | ralsina, mmcc, so the jenkins slave for mac os x times out when it tries to connect to the master, sidnei if filling an RT to see what is going one since we have done all what is possible from the master side | 16:00 |
| mandel | maybe the block or connection outside some way or we have to specify a port.. they should know | 16:01 |
| mandel | mmcc, let me know when the upload is done | 16:01 |
| === beuno is now known as beuno-lunch | ||
| mmcc | mandel: ok, it's up now | 16:05 |
| mandel | mmcc, thx | 16:07 |
| mandel | mmcc, bummer, just got a nice message telling me it won't open because is from an unknown developer, do you know a work around? | 16:10 |
| mmcc | oh right, 10.8 - I know there is a workaround, don't know it off the top of my head | 16:11 |
| mmcc | right click it , and choose open | 16:12 |
| mmcc | then the warning dialog will have an 'open anyway' button or something like that | 16:12 |
| mandel | mmcc, my brain just exploded... wthf (holly) | 16:12 |
| mmcc | for permanent fix: see http://osxdaily.com/2012/07/27/app-cant-be-opened-because-it-is-from-an-unidentified-developer/ | 16:13 |
| mmcc | mandel: why the explode? | 16:13 |
| mandel | mmcc, so, double click does not work, right click open does, it does not make sense at all.. | 16:14 |
| mandel | mmcc, it looks like there are issues with the rest api, right? my username does not appear at all | 16:14 |
| mmcc | oh, heh. I guess they figured that if you're right clicking it, you really mean it :) just make it hard for people to accidentally run untrusted code … | 16:14 |
| mandel | mmcc, yes, might be yet weird | 16:15 |
| mmcc | mandel: it works for me… | 16:15 |
| mmcc | can you run it from the console as 'U1_DEBUG=1 UbuntuOne.app/Contents/MacOS/ubuntuone-control-panel-qt" ? | 16:15 |
| mandel | mmcc, I get all the info but the Hi Manuel! or whatever string goes on the top left label | 16:15 |
| mandel | mmcc, sure | 16:16 |
| mmcc | that's weird | 16:16 |
| mandel | mmcc, worked now O_o | 16:18 |
| mmcc | hrm. | 16:18 |
| mmcc | logging is also sent to ~/Library/Caches/ubuntuone/log/ , if you're curious | 16:19 |
| mandel | mmcc, will take a look, but after I fix the creation thing | 16:19 |
| mmcc | mandel: sure | 16:20 |
| mandel | mmcc, good news are, with the root daemon running and you bundle it works perfectly :) | 16:22 |
| mmcc | mandel: that's with manually starting the daemon and passing the socket name to syncdaemon somehow? remind me how that works… | 16:23 |
| mandel | mmcc, let me find the code that does that, one min | 16:24 |
| mandel | mmcc, it will pick the default monitor defined at ubuntuone/platform/filesystem_notifications/monitor/__init__.py | 16:25 |
| mandel | mmcc, and by looking at the code, it should not be using the daemon, I'm going to kill everything and try again | 16:26 |
| === gatox_lunch is now known as gatox | ||
| mandel | mmcc, ha, annoying, in order to test the app and see the behaviour you had we have to use a mkdir, if you use the finder is a mkdir 'untitled folder' + a move which does work | 16:40 |
| mmcc | mandel: not sure I understand - I was seeing the same problem with just doing "echo blah > ~/Ubuntu\ One/test.txt" | 16:41 |
| mmcc | oh, you're talking about writing tests - but I guess I still don't understand why you have to make a directory… | 16:42 |
| mandel | mmcc, is me thinking out loud.. I used the finder to make a new folder and that is the reason why it worked, is not the same events | 16:43 |
| ralsina | LUNCH | 16:45 |
| === salgado-lunch is now known as salgado | ||
| mmcc | mandel: ah, ok. | 16:48 |
| mandel | briancurtin, ping | 16:49 |
| briancurtin | mandel: what's up | 16:50 |
| mandel | briancurtin, do you have a copy of the latests u1 client running on windows? can you do a small test for me? | 16:50 |
| briancurtin | mandel: sure, what do you need? | 16:50 |
| mandel | briancurtin, can you create a 0 byte file on windows and see if it uploads, it should not | 16:51 |
| briancurtin | mandel: is there a branch for this or should i just do it manually on trunk? | 16:51 |
| mandel | briancurtin, manual test, no need for more :) | 16:52 |
| briancurtin | mandel: i'll set it up and try in a min | 16:52 |
| mandel | briancurtin, thx | 16:52 |
| mandel | mmcc, I think that the same bug is on windows but it only affects 0 byte files :P | 16:52 |
| mmcc | mandel: yeah, that could make sense, a create with no open/close because there's no data | 16:53 |
| mmcc | so it only affects 0 byte files on windows but on macs it happens for all files? | 16:54 |
| mandel | mmcc, yes, and I think rye had a bug about that long time ago which I ignored | 16:55 |
| mmcc | mandel: ah, interesting. btw, this script http://paste.ubuntu.com/1157492/ was useful to see what raw events the macfsevents python lib was sending without spinning up all of u1 | 16:55 |
| mandel | mmcc, great! | 16:56 |
| === beuno-lunch is now known as beuno | ||
| mandel | alecu, mmcc, ralsina fancy a mumble? | 17:28 |
| === JanC_ is now known as JanC | ||
| alecu | mandel: I have 15 minutes before lunch, let's do it | 17:29 |
| mmcc | mandel, I'm available | 17:29 |
| alecu | mandel: ralsina seems to be lunching right now | 17:30 |
| mandel | alecu, mmcc lets do it now, we can tell him later :) | 17:30 |
| briancurtin | mandel: 0 size files do get synched | 17:46 |
| mandel | briancurtin, great! | 17:46 |
| * briancurtin sandwich time | 17:50 | |
| dobey | hrmm, i really need to get my squid proxy working | 18:00 |
| dobey | and my RAID | 18:01 |
| dobey | mandel, ralsina: care to review https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-1037904-run-tests/+merge/120057 ? | 18:04 |
| dobey | and https://code.launchpad.net/~dobey/dirspec/update-4-0/+merge/120443 | 18:06 |
| ralsina | dobey: sure | 18:07 |
| ralsina | dobey: global +1 on both | 18:12 |
| ralsina | mandel: mumble about what? | 18:13 |
| mandel | ralsina, done, but I can update you in a sec if you want | 18:13 |
| ralsina | mandel: sure, I guess :-) | 18:14 |
| mandel | ralsina, ok, super quick mumble then :) | 18:14 |
| ralsina | mandel: starting it | 18:15 |
| === yofel_ is now known as yofel | ||
| gatox | ralsina, do you have a minute for a review? | 18:18 |
| ralsina | gatox: sure! | 18:18 |
| gatox | ralsina, 2 reviews actually if you can (the second one is just ui): https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/shares/+merge/120394 | 18:19 |
| gatox | and i'm proposing the second one right now | 18:19 |
| ralsina | gatox: ok, looking | 18:22 |
| gatox | ralsina, and this one: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tab-shares/+merge/120445 | 18:25 |
| gatox | ralsina, now i'm going to start working in the real publish and share implementation..... that was just the ui as we talked | 18:25 |
| === Guest97966 is now known as adorilson | ||
| mandel | dobey, done | 18:28 |
| dobey | mandel: thanks | 18:29 |
| ralsina | gatox: your branch bounced | 18:35 |
| ralsina | gatox: oops, sorry, not you | 18:35 |
| ralsina | mmcc: your branch bounced ;-) | 18:35 |
| mmcc | ralsina: looking… | 18:35 |
| ralsina | gatox: your shares branch has a lot of lint | 18:37 |
| gatox | ralsina, really? :S i don't get anything here...... | 18:37 |
| ralsina | gatox: http://pastebin.ubuntu.com/1157650/ | 18:38 |
| gatox | ralsina, weird..... ok, i'll fix that | 18:38 |
| ralsina | gatox:ybe you are missing a push? ma | 18:39 |
| ralsina | ok, X, why did you move that "ma" to the end there? | 18:39 |
| mmcc | mandel, I did a test with python-macfsevents where I opened a file, wrote a bit, then waited a long time, wrote some more, and closed. on the write after the wait, I got an IN_MODIFY. - even though I got no IN_MODIFY for the first writes | 18:40 |
| mmcc | mandel: and in a separate test, an immediate open(),write(), flush() gives me an IN_CREATE followed by an IN_MODIFY | 18:42 |
| mmcc | I think in my first long test, the close() triggered a flush and caused the modify event | 18:42 |
| mandel | mmcc, interesting, I need to find a good test for diff volmen tests.. | 18:44 |
| mmcc | yes. this is encouraging for things like a sqlite DB, though - since any changes are sure to be fsync'd, and should then trigger a modify event, we won't be writing inconsistent DBs | 18:46 |
| alecu | jgdx: hey, welcome to the team! | 18:48 |
| mandel | I'm off to have my gazpacho for dinner, I shall be back :) | 18:50 |
| mandel | jgdx, bienvenido! | 18:51 |
| alecu | mandel: I can't understand how people feel that cold puke is an acceptable dinner. | 18:52 |
| ralsina | alecu: "Palomitas de maíz como las hacía mi madre! Regurgitadas!" -- Skipper de los pingüinos de Madagascar | 18:53 |
| dobey | heh | 18:53 |
| mandel | alecu, well, you have not tried the right one then.. is like raw fish, not all raw fish is shusi and not all tomatoes soup is gazpacho | 18:53 |
| gatox | ralsina, lint issues fixed here: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/shares/+merge/120394 ...... for this one, you need to include u1-client trunk in the PYTHONPATH: 211: [E1101, SyncDaemonClient.sync_menu] Instance of 'SyncDaemonTool' has no 'sync_menu' member | 18:54 |
| ralsina | gatox: ack | 18:54 |
| mmcc | ok, my bouncing branch runs correctly on linux again. I missed an instance of s/$u1lint/u1lint, which was impossible to spot just looking at the diff | 18:57 |
| mmcc | ralsina: can I just re-approve it, or do we need 3 more reviews ;) | 18:57 |
| gatox | briancurtin, do you have a minute for a small review?? mostly a .ui file added | 18:58 |
| briancurtin | gatox: sure, send it | 18:58 |
| gatox | briancurtin, thanks! https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tab-shares/+merge/120445 | 18:58 |
| ralsina | mmcc: just re approve it ;=) | 18:58 |
| mmcc | hey neat, LP comments containing $words are stripped of those $words | 19:04 |
| jgdx | god kveld, mandel :) | 19:11 |
| ralsina | gatox: global +1 on shares/ | 19:27 |
| gatox | ralsina, cool.... thx | 19:27 |
| briancurtin | argh wtf. how can ubuntu_sso/main/qt.py have invalid syntax at line 265 when there arent 265 lines in that file? | 19:31 |
| * mandel back from lunch | 19:31 | |
| briancurtin | ah there we go | 19:32 |
| dobey | https://code.launchpad.net/~dobey/ubuntuone-dev-tools/update-4-0/+merge/120457 | 19:38 |
| dobey | whee | 19:38 |
| ralsina | dobey: looking | 19:42 |
| gatox | ralsina, don't forget about this poor and lonely branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/tab-shares/+merge/120445 jeje | 19:57 |
| ralsina | gatox: loooking | 20:13 |
| gatox | ralsina, thx! :D | 20:13 |
| ralsina | gatox: line 8/9 of the diff look like an artifact of you playing with designer :-) | 20:15 |
| ralsina | gatox: also, will make u1cp start on the wrong tab by default, I think | 20:15 |
| gatox | ralsina, ohhhh... i hate when the designer change that just for pressing on an item | 20:15 |
| gatox | ralsina, changing.... | 20:15 |
| ralsina | gatox: happens to me all the time :-) | 20:16 |
| gatox | ralsina, change pushed | 20:18 |
| mmcc | mandel, sleeping toddler interfered with my lunch timing - I had to wait until now, be back in a bit… | 20:21 |
| mandel | mmcc, ralsina, alecu, one of the example on how to break the events is copying a file from a smaba share to the watch file for example | 20:21 |
| ralsina | gatox: needs fixing: update the help for the switch-to option please | 20:22 |
| alecu | mandel: how so? | 20:22 |
| gatox | ralsina, checking | 20:22 |
| alecu | mandel: you only get one event in that case? | 20:22 |
| ralsina | gatox: wait, I may have ran the wrong copy of the script | 20:22 |
| mandel | alecu, I copied a large video and just got a single event | 20:22 |
| ralsina | cd .. | 20:22 |
| ralsina | darn | 20:22 |
| alecu | ralsina: stack empty! | 20:22 |
| ralsina | alecu: OMG IRC is a Lisp machine!!!! ;-) | 20:23 |
| alecu | mandel: allright. What about the root daemon? you get multiple events in that case? | 20:23 |
| mandel | alecu, one sec on the phone | 20:23 |
| ralsina | gatox: confirmed, that needs updating | 20:24 |
| alecu | mandel: so, in the case of files being copied, or video being recorded, we would very easily see the file size changing, if we set a timer to watch every 5 secs. | 20:24 |
| mandel | alecu, yes, it would work, I'm testing atm with downloading a file from the internet and stopping the network etc.. | 20:25 |
| * mandel is jumping from one machine to the other | 20:25 | |
| gatox | ralsina, mmmm i'm not sure what you mean.... can you point me to the code or something? | 20:25 |
| mandel | alecu, let me test with the root daemon | 20:25 |
| ralsina | gatox: sure | 20:25 |
| ralsina | gatox: ubuntuone/controlpanel/gui/qt/main/__init__.py look for switch-to | 20:26 |
| ralsina | gatox: you implemented the functionality in the switch_to function already | 20:26 |
| gatox | ralsina, ahhhhh i understand now | 20:27 |
| ralsina | gatox: I suspect you also have to patch the manpage | 20:27 |
| ralsina | gatox: luckily you can do it without learning *roff first :-) | 20:28 |
| mandel | alecu, with the daemon there is no problem at all, I would even say we get too many events :) | 20:28 |
| * alecu pities the poor soul that needs to review this: https://code.launchpad.net/~charlesk/indicator-sync/initial-impl | 20:28 | |
| alecu | gatox: ^ | 20:28 |
| alecu | mandel: right :-) | 20:28 |
| gatox | alecu, ohhhhhhh my god! | 20:29 |
| mandel | alecu, get get content create file, stat changed, content modified, xattr removed etc.. | 20:29 |
| gatox | ralsina, where is the manpage? :S | 20:29 |
| alecu | "The diff has been truncated for viewing"! | 20:29 |
| ralsina | gatox: docs/*.1 | 20:29 |
| gatox | thx | 20:29 |
| ralsina | alecu: ffffuuuuuu | 20:30 |
| ralsina | +18495!!!!!!!! | 20:30 |
| mmcc | alecu, I looked at that diff - lots of generated code - makefile.in, stuff from .deps… | 20:30 |
| ralsina | alecu: I assume he already had reviews in a private repo and this is just the initial code dump | 20:31 |
| mmcc | seems like it could be smaller :) | 20:31 |
| ralsina | the GPL | 20:31 |
| alecu | right :-) | 20:31 |
| gatox | ralsina, done and pushed | 20:31 |
| ralsina | gatox: cool | 20:32 |
| mandel | ralsina, alecu plus does loevely huuuuuuge tab sizes :P | 20:33 |
| mandel | ralsina, alecu, mmcc, copy operations on fsevents client code will not rase an IN_MODIFY which I would expect to be a common thing to be done by our user base | 20:36 |
| mandel | Drag & Drop has the same problem | 20:36 |
| mmcc | mandel: yep, that's what I saw too. | 20:36 |
| mmcc | same with short-duration writes like "echo foo > test.txt" | 20:37 |
| mandel | mmcc, no comes the 'holly cow how do I write a test for this!' | 20:37 |
| alecu | mandel, mmcc: those operations *do not* send a "folder modified" event? | 20:37 |
| briancurtin | dobey: what's the status of devtools on python3? | 20:37 |
| mandel | alecu, they do, but the lib understands them as a IN_CREATE and not an IN_CREATE followed by an IN_MODIFY so if is large and we are slow we have the problem | 20:38 |
| mmcc | alecu, the macfsevents.py sends just an IN_CREATE for them. It gets a folder modified event from the framework and creates the IN_CREATE from it | 20:38 |
| alecu | then I don't understand the problem | 20:38 |
| dobey | briancurtin: not there yet; still a bunch of work to do for it | 20:39 |
| mandel | alecu, that if it is done over the network we get truncated files, that is why I did the samba test | 20:39 |
| alecu | mandel: and what do you mean by "we are slow"? | 20:39 |
| mandel | alecu, takes long, I get the IN_CREATE and I hash before the file is done | 20:39 |
| briancurtin | dobey: mind if i go ahead with it? or at least the parts in my way? | 20:39 |
| mandel | alecu, well, I meant, if the system is slow writing on the file | 20:40 |
| mmcc | alecu, the problem is that for a copy or a fast write you get a single IN_CREATE event from fsevents.py , and nothing else. | 20:40 |
| dobey | briancurtin: what's in your way right now? | 20:40 |
| mmcc | s/fast write/fast create,write,close/ | 20:40 |
| alecu | mandel, mmcc: ok, as far as I can understand this, we *are* able to solve this with mandel's idea to delay sending the "modify" event | 20:41 |
| mandel | alecu, yes we are :) | 20:41 |
| alecu | aweso | 20:41 |
| alecu | me | 20:41 |
| gatox | eod here!! ralsina i'll close to the computer, so let me know if the branch needs any other fix and i'll do it today so we can land it | 20:41 |
| mandel | alecu, now the hard part is writing the tests for this hehe | 20:41 |
| * alecu was scared that we found a more huge hole. | 20:41 | |
| briancurtin | dobey: global name 'unicode' is not defined (ubuntuone/devtools/runners/__init__.py line 215). easy to fix by itself. i guess i'll just fix what it takes to get me running and propose each bit if that's ok | 20:42 |
| ralsina | gatox: so far it's looking good | 20:42 |
| briancurtin | dobey: that one would just be fixed by a simple 2/3 check to use unicode or str. i currently have that check in utils.py for the time being | 20:42 |
| dobey | briancurtin: ah, yeah. please file bugs and feel free to fix them | 20:43 |
| briancurtin | dobey: will do | 20:43 |
| ralsina | dobey: I think we have all the branches we wanted in trunk of u1cp and u1-client | 20:46 |
| mandel | mmcc, so the root daemon is safe, I need to ensure that state changed and other little events are triggered as in modify to make it more reliable, I'll focus on that first so that in the worst case scenario by the end of the week we have a bundle with the root daemon in it, sounds good? | 20:46 |
| dobey | ralsina: cool | 20:47 |
| ralsina | dobey: also, elopio will do testing of it, should he do trunk? | 20:48 |
| ralsina | dobey: or should he wait until we have the stable-4 branch packaged? | 20:48 |
| ralsina | dobey: since it will pretty much be trunk anyway | 20:48 |
| mmcc | mandel, ok, just worth noting that that's assuming that code signing and launchd integration goes faster than fixing this issue with macfsevents. | 20:50 |
| dobey | ralsina: well i guess it won't be packaged until tomorrow; but then is fine | 20:50 |
| mandel | mmcc, yes, indeed.. how is that going? | 20:50 |
| dobey | ralsina: also, not sure if builders are back up, but just testing nightlies if they're built is fine as well | 20:50 |
| mmcc | I've got the ctypes translation of the jobbless calls set up now, will be testing it in Apple's sample app next. | 20:51 |
| ralsina | dobey: thought so, I'll tell him | 20:51 |
| mmcc | haven't started code signing the apps, that'll be fast to try and not sure how fast it'll be to debug if there are issues | 20:51 |
| mmcc | mandel: have to go feed a toddler and myself, back in a bit, for real this time | 20:52 |
| ralsina | mmcc: on windows we had to sign the python27 library along with the binaries. I know it's not the same thing in mac, but just a heads up :-) | 20:52 |
| mandel | mmcc, np | 20:53 |
| mmcc | ralsina: yeah, similar issues. need to sign lots of parts | 20:55 |
| ralsina | mmcc: also, your qt is not signed, right | 20:56 |
| === m_conley is now known as m_conley_away | ||
| alecu | ralsina: I've been going thru a vala tutorial, and I like it. | 21:29 |
| alecu | ralsina: but I've been checking all the stuff we would need to implement in vala and it's not so easy as I thought | 21:29 |
| alecu | ralsina: we would need: | 21:29 |
| alecu | * oauth | 21:29 |
| alecu | * timestamp synchronization with server (for oauth) | 21:30 |
| alecu | * getting u1 credentials from the keyring | 21:30 |
| alecu | * parsing the json posibly returned by the webservice | 21:30 |
| alecu | * getting proxy credentials from the keyring | 21:31 |
| ralsina | alecu: is there vala-dbus? (I assumed yes) | 21:31 |
| alecu | ralsina: roman says yes: http://rtg.in.ua/blog/2012/02/vala-and-dbus/ | 21:31 |
| ralsina | alecu: also, the previous pages are getting lots of stuff from u1ms, so I am guessing they have the json parsing solved | 21:31 |
| mandel | ok, eod for me catch you all tom! | 21:32 |
| ralsina | alecu: ditto about the proxy (being the only page that supports proxy is useless ;-) | 21:32 |
| ralsina | bye mandel! | 21:32 |
| alecu | bye mandel! | 21:32 |
| ralsina | alecu: so, credentials, we can get via dbus | 21:32 |
| ralsina | alecu: timestamp sync is a nice-to-have | 21:32 |
| ralsina | alecu: the one that's left to consider is oauth | 21:32 |
| alecu | ralsina: yes, we can get credentials via dbus, but we have everything already implemented in python! | 21:33 |
| ralsina | alecu: the precondition for that page to appear is that the user has credentials already | 21:34 |
| alecu | ralsina: so, I think it still might be much easier to expose alll of this to dbus | 21:34 |
| alecu | ralsina: and who checks that the credentials are there? | 21:34 |
| ralsina | alecu: so, yes, we could just expose our stuff via dbus and hook from vala | 21:34 |
| ralsina | alecu: "we" should | 21:34 |
| ralsina | alecu: or at least provide a way to do it | 21:34 |
| alecu | ralsina: perfect then. | 21:35 |
| dobey | alright, have a good evening all. time to get off here | 21:50 |
| alecu | briancurtin: needsfixing here: https://code.launchpad.net/~brian.curtin/ubuntuone-dev-tools/py3-print-function/+merge/120472 | 22:13 |
| briancurtin | alecu: you beat me to it, i was just re-running tests because i noticed that i pushed before fixing some other lint warnings | 22:15 |
| briancurtin | alecu: pushed a fixed version 1 second ago | 22:16 |
| alecu | great! | 22:16 |
| alecu | EOD! | 23:19 |
| mmcc | ok, have to split for a while. will be back later. I think we can fix this fsevents bug in the macfsevents code, without poking at our own code. I'll explain more in an email once I get back in a few hours so mandel sees it before he starts tomorrow… | 23:49 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!