| === mmcc_ is now known as mmcc | ||
| === mmcc_ is now known as mmcc | ||
| mandel | morning all! | 08:58 |
|---|---|---|
| czajkowski | mandel: aloha | 09:38 |
| mandel | czajkowski, hello :) | 09:38 |
| gatox | good morning | 11:20 |
| mandel | gatox, morning, how is the tooth? | 11:23 |
| mandel | gatox, if your face look like a balloon take a pict! | 11:23 |
| gatox | mandel, painnnnn, but manageable....... but the doctor recommend me not to get surgery before my trip because soomething can go wrong... so i will need to extract it when i get back : | 11:24 |
| gatox | :S | 11:24 |
| gatox | not, my face looks normal....... well, normal......... as usual | 11:25 |
| gatox | jejee | 11:25 |
| mandel | gatox, ouch! well, I hope it does not give you any problems in NZ | 11:25 |
| gatox | mandel, i hope that too..... my major concern is not being able to speak the next sunday.... but the doctor gave a lot of painkillers just in case for my trip jeje | 11:26 |
| mandel | gatox, if not, speak via the pc :) | 11:26 |
| mandel | gatox, that and a wheelchair and you will be more than impressive hehehe | 11:27 |
| gatox | jejejjejejjejeje | 11:27 |
| gatox | mandel, espeak "hello, i'm going to talk about ninja-ide" | 11:27 |
| mandel | just like that hehehe | 11:28 |
| gatox | jejejje | 11:28 |
| mandel | gatox, if I where you I would record it just in case, at least you can be there and show a video in person :) | 11:28 |
| gatox | jeejeje | 11:28 |
| mandel | gatox, I saw that ralsina fixed lots of the ui problems in mac, right? | 11:29 |
| gatox | na..... i'm going to talk..... even with pain.... i prepare a really funny presentation http://ubuntuone.com/7fMIOKbq3xfPjwEOVghGMD | 11:29 |
| gatox | mandel, i heard something about it, but didn't see any branch | 11:29 |
| mandel | gatox, awesome, I'm in the process of fixing the dead references once and for all :) | 11:30 |
| mandel | I hate that ipc code.. | 11:30 |
| mandel | gatox, and turns out that the macfsevents guy used to work for canonical, so the changes should land in upstream :) | 11:30 |
| gatox | jeje yes, i saw your twit | 11:31 |
| mandel | small world | 11:31 |
| alecu | hello, all! | 12:07 |
| mandel | alecu, morning! | 12:08 |
| mandel | I need to get lunch or I'll die, catch you in 30/45 min | 12:09 |
| gatox | alecu, hi | 12:13 |
| ralsina | good morning! | 12:25 |
| gatox | ralsina, hi! | 12:25 |
| ralsina | mandel, gatox: yes I did and they are merged already | 12:25 |
| gatox | cool | 12:25 |
| ralsina | mandel: see why you didn't have to worry about those? ;-) | 12:25 |
| gatox | ralsina, alecu i've made some updates in my branch | 12:43 |
| alecu | gatox: ack | 12:45 |
| gatox | alecu, sorry for the long branch..... it was too late when i realize..... but a lot of parts of the branch are really trivial | 12:45 |
| gatox | alsooooo... please remember that today is my last day before the vacation.... so if you could do the reviews today, so i fix anything i need to fix, IT WOULD BE MUCH APPRECIATED! | 12:46 |
| alecu | gatox: yup, I remember! | 12:46 |
| gatox | thx! :D | 12:47 |
| * alecu is not happy reviewing long branches. | 12:47 | |
| gatox | i know.... sorry.. | 12:47 |
| * alecu reviews anyways, and makes a small note to play saboteur tonight, and kill a few ninjas. | 12:47 | |
| alecu | gatox: in ubuntuone/controlpanel/backend.py, in def get_public_files()... | 12:51 |
| alecu | gatox: I think there's a returnValue missing | 12:51 |
| gatox | alecu, mmmm that method doesn't return anything....... just trigger the action, and the informatoin is retrieved in the signal PublicFilesList | 12:52 |
| alecu | gatox: oh, right. | 12:53 |
| ralsina_ | Hello, this is me on the backup IRC client, so if you said anything I need to know since friday, please repeat ;-) | 12:58 |
| alecu | gatox: why do we set qss inside the code??? I mean btn_icon_style='''....''' for instance. | 12:59 |
| alecu | gatox: isn't there a way to just change the style by qss id name or something similar? | 13:00 |
| gatox | alecu, i did it that way..... because we use the same enhancer..... to build different line edits with buttons, and in one of them we need a special style but not in the other | 13:00 |
| alecu | gatox: I understand why we need to change the style. | 13:01 |
| gatox | alecu, i could do 2 qss styles, and let the user specify just the name | 13:01 |
| alecu | gatox: right! | 13:01 |
| gatox | do you prefer that? | 13:01 |
| alecu | gatox: that's what I was asking about. | 13:01 |
| alecu | gatox: yes: I would prefer if we keep all the styling together. | 13:01 |
| alecu | gatox: anyway: not a blocker for this branch, so please add it as a new bug. | 13:02 |
| gatox | alecu, as you wish..... i can change that in a few secs | 13:02 |
| gatox | alecu, do you mind if i do it now? | 13:03 |
| alecu | gatox: no, go ahead! | 13:03 |
| gatox | alecu, roger that | 13:03 |
| alecu | gatox: I've added a couple of comments to the branch, but I'm still reviewing it. | 13:03 |
| gatox | alecu, ack | 13:03 |
| alecu | gatox: same question regarding the <span style="..."> inside the QLabels.... can't they get the style from the QSS? | 13:10 |
| gatox | alecu, nop | 13:11 |
| gatox | alecu, we have label styling in several places | 13:11 |
| alecu | gatox: :-( | 13:11 |
| alecu | gatox: yes, I see that it's done all over our code. | 13:11 |
| gatox | alecu, that's why you can customize different parts of the same string in different ways.... as we do there | 13:11 |
| alecu | gatox: right, but perhaps QLabels have a way to do that like in html. Like <span class="qssname">, and in the qss you define the right style. | 13:13 |
| ralsina_ | alecu: no, you would have to set a CSS stylesheet for the QLabels to do that | 13:13 |
| ralsina_ | alecu: and then set the same stylesheet on each QLabel | 13:14 |
| alecu | gatox, ralsina_: if there's no option to do this, then let's move all these custom styles (colors and font sizes) into just one file. I think we should not have styles scattered everywhere. | 13:15 |
| alecu | gatox: anyway: not blocking for this branch, don't worry about fixing it here. | 13:15 |
| ralsina_ | alecu: yes, a few constants is a better idea | 13:15 |
| ralsina_ | gatox, alecu: file a bug | 13:15 |
| gatox | alecu, ralsina_ i'll file that bug | 13:15 |
| gatox | ralsina_, alecu bug created... | 13:19 |
| ralsina_ | gatox: awesome | 13:19 |
| mandel | ralsina_, yes, I saw :) | 13:23 |
| * mandel back | 13:23 | |
| mandel | ralsina_, alecu, mmcc, do you know how to reproduce the 'Stale Broker' exception in any of the platforms (Windows or Mac) ? | 13:29 |
| mandel | gatox, ^ | 13:30 |
| ralsina_ | mandel: not intentionally | 13:30 |
| gatox | mandel, nop..... | 13:30 |
| ralsina_ | mandel: on mac, apparently it's enough to just switch tabs a few times | 13:30 |
| mandel | ralsina_, ok, good to know, I wonder why it happens because that means that the object ref in the server side is not valid anymore, I want to try if re-requesting the ref is ok or the root is also funky | 13:31 |
| ralsina_ | mandel: my guess is the TCP socket for IPC reconnects and you get a new ref but that's just guessing | 13:31 |
| ralsina_ | mandel: and then the old ref is stale | 13:31 |
| mandel | ralsina_, which can only happen if the root object is gc, so in theory it should also be out | 13:33 |
| mandel | ralsina_, expecting the exception in the tools code and reconnecting if needed should fix the problem, got a solution like that I'll test it and will propose | 13:34 |
| mandel | ralsina_, should also fix the problem on windows :) | 13:34 |
| ralsina_ | mandel: awwwwwwwesome | 13:35 |
| ralsina_ | this is the "fix the stupid bugs we are dragging for a year" week! | 13:35 |
| mandel | lol | 13:36 |
| alecu | gatox: a few more comments on the branch (still reviewing) | 13:37 |
| gatox | alecu, ack | 13:37 |
| ralsina_ | Oh, sqlite, I love you but I hate you so much. | 13:39 |
| mandel | alecu, I should not be using iteritems in new code, right? what is the new method to be used called? | 13:49 |
| ralsina_ | mandel: just use items | 13:50 |
| mandel | ralsina_, but that is not an iterator, right? | 13:50 |
| ralsina_ | mandel: it's one in py3, not in py2 | 13:51 |
| mandel | ah... | 13:51 |
| ralsina_ | mandel: and yes, that means it's less efficient in py2. Unless you expect a bazillion items... | 13:51 |
| mandel | ralsina_, should not be a problem, is just the signals that has already been connected so that on reconnection we do still work correctly | 13:52 |
| ralsina_ | mandel: ok | 13:52 |
| chaselivingston | mmcc, mandel: I've been getting an error quite a bit recently from the mac app, something about "calling stale broker" | 13:53 |
| chaselivingston | any ideas? | 13:53 |
| mandel | chaselivingston, yes, is my top bug atm :) | 13:53 |
| chaselivingston | mandel: awesome, good to know :) | 13:53 |
| mandel | chaselivingston, seems that the ipc reconnects, there is a gc call and the remote objects are gone | 13:53 |
| mandel | in case you wanted to know the possible reason | 13:53 |
| chaselivingston | mandel: haha thanks | 13:54 |
| === m_conley_away is now known as m_conley | ||
| ralsina_ | chaselivingston: we probably are going to get a new build today that fixes a few f the reported issues | 13:57 |
| chaselivingston | ralsina_: awesome, looking forward to checking it out | 13:57 |
| ralsina_ | chaselivingston: may even have something useful in the "share" tab :-) | 13:57 |
| chaselivingston | ralsina_: haha, nice! | 13:58 |
| * mandel feels dirty than usual when patching __getattr__ | 14:10 | |
| ralsina_ | mandel: that doesn't feel like something that would have to be done in any sane code | 14:13 |
| mandel | ralsina_, is for a testcase because the perspective_broker implementation of sdtools uses __getattr_ to wrap any attribute call with a possible deferred call | 14:13 |
| ralsina_ | mandel: ok, if you are testing crazy code I suppose it's ok | 14:14 |
| mandel | ralsina_, yes, it is crazy code | 14:14 |
| gatox | alecu, i'm a little confuse about this: There's an extra blank line after "class ShareLinksPanel" and its docstring. ...... i was told that was the way to do it | 14:16 |
| gatox | is it wrong? | 14:17 |
| ralsina_ | gatox: Leaving an extra line between the class and the docstring if the class has more than one "block" in it is ok according to the PEP | 14:17 |
| gatox | ralsina_, more than one "block"? | 14:18 |
| gatox | multiline docstring? | 14:18 |
| ralsina_ | gatox: but there's two blanks BELOW the docstring | 14:18 |
| ralsina_ | gatox: no, if a class has, for example, two methods, which are separated by blanks, then the docstring should be separated by blanks too | 14:19 |
| ralsina_ | gatox: oh, wait. that's only one below, sorry | 14:19 |
| ralsina_ | gatox: that docstring is ok, except it's missing the final "." | 14:19 |
| gatox | ralsina_, so..... my docstrings are ok? | 14:19 |
| ralsina_ | gatox: ok, according to pep257, one-line docstrings have no blaks before or after | 14:21 |
| gatox | ok..... so deleting that.... grrrrr contradictory peps! | 14:21 |
| ralsina_ | gatox: the extra blank lines before and/or after is only for multiline docstrings | 14:21 |
| ralsina_ | gatox: and don't forget the "." :- | 14:21 |
| ralsina_ | ) | 14:21 |
| === zyga is now known as zyga-afk | ||
| dobey | oh bugger. ui freeze *is* on thursday :( | 14:35 |
| ralsina_ | dobey: I thought it was next week! | 14:35 |
| dobey | nope. next week is b1 release; ui and b1 freeze are thursday (aug 30) | 14:36 |
| ralsina_ | dobey: just checked, you are right :-/ | 14:36 |
| ralsina_ | dobey: so we need to do releases again, right? | 14:37 |
| dobey | 3.99.90 release is scheduled for today, yes :) | 14:37 |
| ralsina_ | dobey: hmmm late toay I hope ;-) | 14:38 |
| alecu | gatox: sorry, I'm feeling not quite well today, so I was afk. | 14:38 |
| gatox | alecu, no problem | 14:38 |
| ralsina_ | dobey: at least u1cp | 14:38 |
| gatox | alecu, get better! :) | 14:38 |
| alecu | gatox: re: the extra blank lines, I mean the empty lines between the class definition and the docstring | 14:38 |
| gatox | alecu, yes, ralsina already explain it to me | 14:39 |
| alecu | gatox: ah, ok. | 14:39 |
| dobey | time dilation bubble would be awesome right now | 14:39 |
| ralsina_ | dobey: yeah | 14:42 |
| ralsina_ | dobey: in any case, we don't have any UI changes pending AFAIR except for diego's and the rb stuff that was going to need exceptions anyway | 14:43 |
| ralsina_ | dobey: and all the dash stuff is in libunity and the exceptions are njpatel's to request | 14:44 |
| dobey | icons | 14:47 |
| ralsina_ | dobey: right, missed that one | 14:47 |
| mmcc | good morning everyone! | 14:49 |
| dobey | meh | 14:49 |
| ralsina_ | good morning mmcc! | 14:49 |
| ralsina_ | dobey: so, average morning? ;-) | 14:49 |
| mmcc | good news - this morning I got a response from an Apple dev relations person about the blocking issue I had on Friday :) -> no time spent waiting for help! | 14:50 |
| dobey | reminder of all the things you wanted to get done and don't have time to do, morning | 14:50 |
| ralsina_ | mmcc: awesome | 14:50 |
| mmcc | also, OS security-enforcement code that crashes when you send it a string instead of a dictionary -> yikes! | 14:50 |
| ralsina_ | mmcc: so, feeling good about another build today? | 14:51 |
| mmcc | ralsina_: right now I am. ask again in 20 minutes ;) | 14:51 |
| ralsina_ | mmcc: will do :-) | 14:51 |
| mandel | mmcc, before you do the build, let me know there is a branch I'd like you to include for testing | 14:53 |
| ralsina_ | mmcc, dobey, alecu, gatox, mandel, briancurtin, thisfred_: standup starts in 7, ends in 9 ;-) | 14:53 |
| gatox | ack | 14:53 |
| mmcc | mandel: sure. | 14:53 |
| thisfred_ | yipyip | 14:55 |
| alecu | ralsina_: do we have techleads call today_ | 14:55 |
| alecu | ? | 14:55 |
| ralsina_ | alecu: apparently not | 14:56 |
| mandel | me | 15:00 |
| gatox | me | 15:00 |
| briancurtin | me | 15:00 |
| alecu | me | 15:00 |
| ralsina_ | me | 15:01 |
| ralsina_ | dobey, thisfred_, mmcc, briancurtin: tick tock | 15:01 |
| ralsina_ | oops, not you briancurtin :-) | 15:01 |
| dobey | meh | 15:01 |
| briancurtin | yessss, i'm out of the twitter shaming | 15:01 |
| thisfred_ | me | 15:01 |
| alecu | mandel: go | 15:02 |
| mandel | DONE: Could not work on friday due to stupid telefonica changing all the network. Looked at the stale broker problem, we have reconnection problems which seem to be common on mac. Made code that will reconnect and get new remote objects with the correct python references. Talked with macfsevents to land our changes in, should be ok, also developer is an ex-canonical :) | 15:02 |
| mandel | TODO: 1-1 ralsina. Find what import is screwing up my tests. Test the code irl. Move to the next ugly bug (to be defined). | 15:02 |
| mandel | BLOCKED: No | 15:02 |
| mandel | gatox, your turn! | 15:02 |
| gatox | DONE: | 15:02 |
| gatox | Propose Share Links tab branch, with all the functionality. Start fixing the branch according some comments. | 15:02 |
| gatox | TODO: | 15:02 |
| gatox | Finish fixing the branch. Prepare for my vacations. Enjoy vacations. | 15:02 |
| gatox | BLOCKED: | 15:02 |
| gatox | No | 15:02 |
| gatox | COMMENT: | 15:02 |
| gatox | I'll be back on September 10th. | 15:02 |
| gatox | briancurtin, go | 15:02 |
| briancurtin | DONE: subprocess, read up on python-defer | 15:02 |
| briancurtin | TODO: figure out cross-version subprocess stdout/stderr once and for all... | 15:02 |
| briancurtin | NEXT: alecu | 15:02 |
| alecu | DONE: got vala doing oauth and calling webservices with libsoup (thanks rye!). reviews, more reviews. | 15:02 |
| alecu | TODO: more reviews, more vala, learn nux | 15:02 |
| alecu | BLOCKED: no | 15:02 |
| alecu | NEXT: ralsina_ | 15:02 |
| ralsina_ | DONE: redid mac env, fixed a couple of mac UI issues (yay), helped around, reviews, canonicaladmin, etc. TODO: check schedules, check exceptions, hopefully fix some other stuff, coordinate with other teams BLOCKED: the UK bankholiday is not helping NEXT dobey | 15:02 |
| dobey | DONE: reviews, py3 rb plug-in | 15:02 |
| dobey | TODO: releases, icon generating magic, music store work | 15:02 |
| dobey | BLCK: None. | 15:02 |
| dobey | thisfred_: go | 15:02 |
| thisfred_ | DONE: refactored v1 and v2 music web api to use common base.py TODO: introduce u1db to base.py BLO(CKED: no NEXT | 15:02 |
| ralsina_ | NO SHAMING TODAY! | 15:02 |
| gatox | ralsina_, yes! mmcc | 15:03 |
| ralsina_ | oops! | 15:03 |
| gatox | or he is not around? | 15:03 |
| ralsina_ | mmcc? ;-) | 15:03 |
| ralsina_ | gatox: he was a little while ago | 15:03 |
| * ralsina_ goes work on the shaming | 15:03 | |
| gatox | alecu, branch has been updated | 15:03 |
| alecu | gatox: great | 15:03 |
| ralsina_ | https://twitter.com/ralsina/status/240102457026437122 | 15:04 |
| gatox | jejejjej | 15:04 |
| mmcc | sorry, toddler emergency, back now. perfect timing… | 15:05 |
| mmcc | DONE: launchd, updated dev instructions, discussed daemon | 15:05 |
| mmcc | upgrade and versioning issues | 15:05 |
| mmcc | TODO: launchd | 15:05 |
| mmcc | BLCK: no | 15:05 |
| ralsina_ | cool, comments? | 15:06 |
| ralsina_ | mmcc: sorry, had I known it was because of toddler issues I woul have held it ;-) | 15:06 |
| mmcc | ralsina_: no prob :) | 15:07 |
| ralsina_ | I wouldn't have expected this to work, but we are having much cleaner standups lately :-) | 15:08 |
| ralsina_ | EOM | 15:09 |
| gatox | twitter shaming is a powerful weapon | 15:09 |
| gatox | jeje | 15:09 |
| alecu | gatox: double dot here: """Get the information of the shares..""" | 15:10 |
| gatox | alecu, fixed | 15:11 |
| alecu | gatox: do you have the number for the bug I asked you to create earlier today? | 15:12 |
| gatox | ah yes..... adding to the comment | 15:13 |
| gatox | alecu, done | 15:14 |
| * gatox lunch | 15:16 | |
| === gatox is now known as gatox_lunch | ||
| dobey | ok; lunch and then a lot of work. bbiab | 15:22 |
| mandel | mmcc, could you build the app bundle using lp:~mandel/ubuntuone-client/stale-broker ?? | 15:23 |
| mmcc | ok mandel - you mean right now or just when we do the next build to share? | 15:24 |
| mmcc | btw, have you tried building the app yourself? I still don't know if anyone else has done it recently | 15:24 |
| mandel | mmcc, next time :) | 15:24 |
| mmcc | mandel: k | 15:24 |
| mandel | mmcc, no I have not, if you point me to instructions I'll do it right now :) | 15:24 |
| mmcc | ubuntuone-windows-installer/scripts/README-mac.txt | 15:25 |
| gatox_lunch | alecu, i forgot to fix something.... doing it now | 15:25 |
| mmcc | mandel, probably best to be using the new buildout | 15:26 |
| mandel | mmcc, ok, I'll give it a try | 15:26 |
| mmcc | great | 15:26 |
| mmcc | mandel, one thing I just noticed in there. py2app might already be installed on your system but it's probably out of date. you will need to get py2app and its dependencies from bitbucket | 15:29 |
| mandel | mmcc, ok, so no easy_install, right? | 15:30 |
| mmcc | mandel: I don't think he's released the changes you need yet… | 15:30 |
| mandel | ack | 15:30 |
| czajkowski | dobey: you about ? | 15:32 |
| mmcc | mandel: here are the deps you need to install -- py2app last: altgraph modulegraph macholib py2app | 15:33 |
| mmcc | all from bitbucket.org/ronaldoussoren | 15:33 |
| briancurtin | czajkowski: he just went to lunch a few minutes ago | 15:33 |
| czajkowski | briancurtin: thanks | 15:33 |
| mmcc | I just did 'python setup.py develop' from each, but you could install instead of develop, if you don't need to tweak it | 15:34 |
| mmcc | and you shouldn't | 15:34 |
| czajkowski | dobey: https://launchpad.net/ubuntuone-servers-libs was registered but licience left empty can you get someone to change it please, it's in my review queue | 15:34 |
| czajkowski | thanks | 15:34 |
| mandel | mmcc, ok, I'll just be like a machine and follow each step | 15:34 |
| * mmcc is one step closer to a botnet | 15:35 | |
| ralsina | ah, back with the good IRC client :-) | 15:40 |
| mandel | ralsina, on trunk I see a funny mirroed loading widget, is this known? | 15:41 |
| ralsina | mandel: no idea what you mea | 15:41 |
| ralsina | n | 15:41 |
| mandel | ralsina, let me post a pict, I'll do it as soon as I'm done testing :) | 15:41 |
| ralsina | mandel: ok | 15:42 |
| mandel | ralsina, just happens at the very beginning of the app | 15:42 |
| ralsina | mandel: oh, wait, you see two overlays? | 15:42 |
| mandel | ralsina, yes | 15:42 |
| ralsina | mandel: one is global the other one is on the tab, no idea why that started happening | 15:42 |
| mandel | ralsina, oh, ok | 15:42 |
| mandel | ralsina, 1-1? or are you to busy right now? | 15:43 |
| ralsina | mandel: it clears up in a couple of seconds though | 15:43 |
| ralsina | mandel: in 17'? | 15:43 |
| mandel | ralsina, yes, I noticed | 15:43 |
| mandel | ralsina, 17' mins then :) | 15:43 |
| mandel | ralsina, if you use --with-icon the overlay seems to stay there | 15:53 |
| ralsina | mandel: hmmm you shoud be getting an exception somewhere in that case | 15:54 |
| mandel | ralsina, ok, I'm looking into solving the json decode issues we have which are usually error pages coming from the server ad will take a look closer to that, the stale brokers problems seems to be fixed or hard to reproduce when running from comandline | 15:55 |
| ralsina | mandel: ok | 15:56 |
| === salgado is now known as salgado-lunch | ||
| mandel | alecu, mmcc, can I have a review for the following: https://code.launchpad.net/~mandel/ubuntuone-client/stale-broker/+merge/121456 | 16:00 |
| ralsina | mandel: mumblez | 16:00 |
| mandel | ralsina, sure, launching the thing | 16:00 |
| alecu | gatox_lunch: I added one final needsfixing to the branch. I might agree to move it to a new bug, so let's discuss it when you get back. | 16:10 |
| alecu | gatox_lunch: otherwise the branch is in good shape to me. | 16:10 |
| mmcc | mandel: do you know why the PB is getting disconnected? just reconnecting seems like a band-aid to me… | 16:12 |
| mandel | mmcc, no idea, the issue does happen on widows again. Twisted will reconnect automatically, what the code does is to re-request the references of the server side objects so that we do not ask for the wrong id | 16:13 |
| mandel | mmcc, the way pb works is that it uses the python object id to point to the object that should perform the requested method, and when that objects is gc you get a stale broker error | 16:14 |
| mandel | mmcc, the main reason would be that the factory is release the root object which is the only guy that has the reference to all remote objects which then are also gc | 16:14 |
| mmcc | mandel: understood, but why is the connection getting broken in the first place? | 16:14 |
| mandel | mmcc, no idea | 16:15 |
| mandel | mmcc, will need to look deeper in twisted to know exactly why, alecu any idea? | 16:15 |
| mmcc | someone mentioned TCP timeouts earlier, but we're not using TCP, right? are we just mis-configuring the initial connection or something? | 16:15 |
| mmcc | I mean, auto-reconnecting might be useful to have anyway, and your code is logging when it happens, that's good, but I'd also like to try to fix the root problem too | 16:16 |
| mandel | mmcc, I'll look closer during the tests to catch the reason, I also want to know why :) | 16:17 |
| mandel | at least we have a way to fix the issue or better said, not expose the issue to the user | 16:17 |
| mandel | ralsina, an example of the json decode issue is shown in the image of bug 1040910 | 16:19 |
| ubot5 | Launchpad bug 1040910 in Ubuntu One Control Panel "U1 Darwin Client Crash on OSX " [Undecided,New] https://launchpad.net/bugs/1040910 | 16:19 |
| === gatox_lunch is now known as gatox | ||
| gatox | alecu, reviewing your comments | 16:19 |
| alecu | gatox: one second, I'm adding one more thing. | 16:19 |
| ralsina | mandel: ack | 16:20 |
| gatox | alecu, i've just fixed the FakeDesktopService thing that i forgot | 16:20 |
| alecu | gatox: done. Two things of notice in the comments: some tests are missing, and the UI gets unresponsive for 15 seconds on startup. | 16:21 |
| alecu | mmcc, mandel: the only time I noticed that the PB connection is dropped is when one of the two process speaking dies or finishes, or is killed. | 16:23 |
| mmcc | alecu, mandel - what was triggering the stale broker errors in the bug? I never saw them… were they with syncdaemon or some other backend process? | 16:23 |
| mandel | alecu, any idea on where to start looking on why twisted reconnects? the issues is definitely related to the refs being removed | 16:24 |
| mandel | mmcc, I have seen it via changing the tabs in control panel, chaselivingston has seen them too that way | 16:24 |
| gatox | alecu, i'll split the keyPress code..... and try to see how to avoid the blocking thing | 16:25 |
| alecu | gatox: I think we can split keypress and add tests to it on a different branch. | 16:25 |
| alecu | gatox: I'm more worried about the blocking thing | 16:25 |
| alecu | gatox: my guess is that it might get worse for people with much more files. | 16:26 |
| alecu | gatox: how many files do you have in the account you tested with? | 16:26 |
| gatox | alecu, probably...... because here is less than 15 sec | 16:26 |
| gatox | alecu, i only have 854mb | 16:26 |
| alecu | gatox: I've got 17000 files (mostly photos) | 16:28 |
| gatox | alecu, i don't have so much files | 16:29 |
| alecu | gatox: 30Gb | 16:29 |
| mmcc | mandel: so if changing tabs makes it happen, does that mean it's the control panel backend and not the syncdaemon? | 16:29 |
| alecu | gatox: so, this will get worse for people with more files. | 16:29 |
| gatox | alecu, yes | 16:29 |
| mmcc | mandel: I'm trying to find the connection between the CP backend and the code you changed in u1-client on your branch… | 16:29 |
| chaselivingston | mandel, mmcc: it seems as if uploading has stopped as a result of that stale broker issue as well | 16:29 |
| gatox | alecu, i tried to do something about it.... but it seems didn't work.... will take a deeper look at that now | 16:30 |
| mmcc | chaselivingston: ok, noted… :\ | 16:30 |
| mmcc | chaselivingston: are you observing that via the UI, or looking at the web interface? | 16:30 |
| chaselivingston | mmcc: that is assuming that the size of the u1 folder locally should match its size on the website | 16:31 |
| mandel | mmcc, so the back end uses ubuntuone/platform/tools to make the calls to the server side, I need to double check how the control panel backend and the control panel interact but AFAIK they do not use ipc | 16:31 |
| mandel | ralsina, gatox, how do the control panel and the control panel backend interact on mac, do they use IPC? | 16:31 |
| chaselivingston | mmcc: guess that answered your question :) | 16:32 |
| mandel | mmcc, if the answer to that ^ is a yes I have to add similar code for them just in case | 16:32 |
| mmcc | chaselivingston: yes… | 16:32 |
| gatox | mandel, yes | 16:32 |
| mandel | chaselivingston, I have made the changes and have not seen a problem yet | 16:32 |
| mandel | gatox, yes.. bummer or 'mierda' as you please.. | 16:32 |
| chaselivingston | mandel: meaning you're running a new build? | 16:32 |
| mmcc | gatox: it uses code in sso, though, right? | 16:32 |
| mmcc | chaselivingston: he's running from source | 16:32 |
| mandel | chaselivingston, I'm doing irl tests from source :) | 16:33 |
| gatox | mmcc, not for that.... or i'm missing something | 16:33 |
| chaselivingston | mmcc, mandel: gotcha, well good to know something is coming that should fix what I'm seeing | 16:33 |
| alecu | gatox: and here's a bug: if you scroll not using the down key (for instance with the scrollwheel), no new items are added to the list. | 16:33 |
| mmcc | gatox: well, grepping for 'ipc' gets nothing in ubuntuone-control-panel/ | 16:33 |
| alecu | gatox: also, pgdown pgup do not work. | 16:33 |
| mandel | chaselivingston, mmcc know the branch with the fix, we want to put it there for irl testing before landing | 16:33 |
| mmcc | so I figured it was getting it somewhere else | 16:33 |
| === salgado-lunch is now known as salgado | ||
| mandel | mmcc, I know that ubuntuone/platform/tools uses ipc, which is what is used to talk with sd | 16:34 |
| mandel | mmcc, I'll keep looking there to see if there is more ipc to fix | 16:34 |
| gatox | alecu, ok..... i'll try to add all of that today...... but i suggest that something like that is missing a t the end of the day, we should open bugs for that..... because that is not blocking... and i'm not going to be here for 2 weeks | 16:35 |
| mmcc | mandel: right, I see the sd tool being used in cp, but nothing else. but how is changing tabs related to our connection to SD? and SD isn't dying, right? do we have more than one connection to SD? (one per tab?!) | 16:35 |
| alecu | gatox: of course! do not waste time with pg/pgdown nor scroll: those can wait. | 16:35 |
| alecu | gatox: those are just bugs | 16:36 |
| alecu | gatox: but the delay that is added is more serious, because nightlies will have that delay for every user with many files. | 16:36 |
| mandel | mmcc, we have one sdtool per tab AFAIK, when there is a reconnect all those sdtools have old references but the update is just done when you move to the tab, we can say is lazy | 16:36 |
| mandel | mmcc, but I'd need to double check that by looking at the code, it is not an area I've spent a long time with | 16:37 |
| mmcc | mandel: ok. so I wonder if we're causing problems by reusing the same socket for multiple connections between the same two processes | 16:38 |
| mandel | mmcc, should not be a problem, twisted should deal with that | 16:38 |
| mandel | but yet again, god only knows.. | 16:38 |
| mmcc | It's not inherently wrong to connect over the same socket multiple times between two processes, but I bet twisted doesn't expect you to do that | 16:39 |
| mandel | mmcc, it does, twisted in that matter is really good, but is worth looking at the internals | 16:40 |
| alecu | gatox: I think I found inklings of the problem | 16:44 |
| gatox | alecu, shoot | 16:44 |
| alecu | gatox: trunk uses 0.8% of my 8Gb of ram. Your branch uses 5.8%!!!! | 16:44 |
| alecu | gatox: that's only second to firefox with a lots of tabs opened. | 16:45 |
| alecu | gatox: my guess is that the scanning of the files is using too much cpu on start, plus a lot of ram. | 16:46 |
| gatox | alecu, mmmmmm..... that's probably because we have the information of the files in memory.... the other solution will be to store the info with sqlite and do queries while the user type...... not so sure about this | 16:46 |
| mmcc | mandel: in my syncdaemon log just now, it looks like something's using TCP: ubuntuone.SyncDaemon.ActionQueue - INFO - Connection started to host 127.0.0.1, port 53108. | 16:46 |
| alecu | gatox: that sounds like an awful solution, using sqlite. | 16:47 |
| gatox | i agree | 16:47 |
| alecu | gatox: I would guess that there are a bunch of more elegant, and less resource intensive solutions. | 16:47 |
| mandel | mmcc, yes, but that is action q, nothing to worry about regarding this bug, that is too low within sd | 16:47 |
| mmcc | mandel: ok, but aren't we supposed to be using unix sockets for the IPC? just looking to see where we might be missing something here | 16:48 |
| alecu | gatox: I'll try to come up with one while I have lunch. | 16:48 |
| mandel | mmcc, all ipc was moved to sockets yes, we might have left out something not related with ipc but I would be surprised since we did not notice it on the windows port | 16:48 |
| mmcc | mandel btw, does the monitor code log which monitor it is using anywhere? | 16:49 |
| gatox | alecu, ok..... i'm improving the keyPressEvent method | 16:49 |
| mmcc | mandel, I'm trying to verify that i"ve actually connected to the root daemon | 16:49 |
| mandel | mmcc, lets ask in #chicharra (internal) about action q | 16:49 |
| mandel | mmcc, hm.. i might not do it, let me check | 16:49 |
| alecu | gatox: let's mumble with ralsina after I get back from lunch, and we can decide if we land it like this, or if we wait after you get back and come up with a different approach. | 16:49 |
| gatox | ok | 16:49 |
| mandel | mmcc, it does not log it | 16:50 |
| mmcc | mandel: ok, well at least that means I might be using the right one :) | 16:51 |
| mandel | mmcc, please file a bug and I'll have that fix tom morning | 16:51 |
| mmcc | mandel: ok | 16:52 |
| mandel | thx | 16:52 |
| alecu | gatox: this line may have part of the blame: | 16:55 |
| alecu | files_list += [os.path.join(root, f) for f in files] | 16:55 |
| mmcc | mandel: bug #1042336 | 16:55 |
| ubot5 | Launchpad bug 1042336 in Ubuntu One Client "platform filesystem monitor code does not log which monitor it used" [High,Confirmed] https://launchpad.net/bugs/1042336 | 16:55 |
| alecu | gatox: try it with files_list.extend(...) | 16:55 |
| mandel | mmcc, awesome, I'll do that asap | 16:55 |
| mmcc | mandel: thanks | 16:56 |
| gatox | alecu, will try | 16:56 |
| alecu | gatox: or unrolling that list comprehension | 16:56 |
| alecu | gatox: because += creates a whole new list each time | 16:56 |
| alecu | (I *think*) | 16:57 |
| ralsina | alecu: it shouldn't | 16:57 |
| * ralsina checks | 16:57 | |
| alecu | ralsina: right, it does not. | 16:57 |
| joshuahoover | ralsina, alecu: sounds like the sync indicator has landed in q now...can you take a look soon and see how much time you think it'll take for us to hook u1 up? | 16:58 |
| ralsina | alecu: it just extends() | 16:58 |
| ralsina | joshuahoover: I am guessing about a week of work but it may be we can't do it until after gatox comes back from vacation | 16:58 |
| ralsina | joshuahoover: which means Sept. 17th | 16:58 |
| alecu | joshuahoover: I'll take a look, sure. But yes, such bad timing, with gatox going on vacation :-( | 16:59 |
| ralsina | joshuahoover: we may be able to make it happen sooner but I am not promising | 16:59 |
| joshuahoover | ralsina: ah, k...would be good if you or someone else could take a look at it to see if there are any question/concerns we have about the api before gatox gets back | 16:59 |
| ralsina | joshuahoover: yes, that we can do | 17:00 |
| joshuahoover | thanks | 17:00 |
| dobey | czajkowski: hrmm | 17:00 |
| ralsina | joshuahoover: we were talking with them about APIs and how to do stuf, it's just that things got merged late and some bad timing luck. But we'll get it done. | 17:03 |
| dobey | speaking of vacations, i need to use mine at some point before the year ends | 17:08 |
| ralsina | dobey: yes you do | 17:09 |
| dobey | it's too bad i can't engineer the weather to be amiable during the holidays i take | 17:10 |
| ralsina | dobey: YET | 17:11 |
| ralsina | I'm off for lunch, will be back soonish. | 17:12 |
| dobey | yeah, i need a kickstarter for my "global weather control doomsday device" | 17:13 |
| mandel | dobey, sorry I have the patent of a 'device' of any form, color or shape that might but not may control the global weather, I have a small diagram of it too | 17:15 |
| mmcc | why does it always have to be a doomsday device? why not a "pleasantday" device. or a birthday device? we could all have cake | 17:15 |
| mandel | ralsina, mmcc, feel free to review: https://code.launchpad.net/~mandel/ubuntuone-client/fs-darwin-logging/+merge/121466 | 17:18 |
| joshuahoover | ralsina: fyi...i filed bug #1042343 for a ffe for the sync indicator work and assigned to you (for now) | 17:18 |
| ubot5 | Launchpad bug 1042343 in Ubuntu One Client "[FFE] Ubuntu One integration with Q sync indicator" [High,Triaged] https://launchpad.net/bugs/1042343 | 17:18 |
| czajkowski | dobey: indeed | 17:20 |
| dobey | czajkowski: i'll review it when i get an answer | 17:21 |
| czajkowski | dobey: cheers | 17:24 |
| dobey | brb | 17:35 |
| mandel | all, EOD for me, I need to walk the dog, see you tom! | 17:40 |
| mandel | mmcc, remember to use the stale broker branch in the bundle, I'll like to see if it fixes the issue, alecu do please review: https://code.launchpad.net/~mandel/ubuntuone-client/stale-broker/+merge/121456 | 17:41 |
| mandel | adios! o/ | 17:41 |
| mmcc | bye mandel, thanks | 17:42 |
| gatox | mandel, bye | 17:47 |
| mmcc | alecu I'd like your input on that one too - I'm wondering what the root cause is… | 17:48 |
| mmcc | brb | 17:49 |
| * briancurtin lunch | 17:58 | |
| ralsina | joshuahoover: awesome, thanks | 18:09 |
| ralsina | mmcc: if it happens switching tabs, it may be between u1cp-frontend and u1cp-backend | 18:14 |
| mmcc | ralsina: right… but those aren't actual separate processes, are they? | 18:15 |
| ralsina | mmcc: no | 18:15 |
| ralsina | mmcc: so probably not | 18:15 |
| mmcc | btw, I was disconnected for a bit there, did I miss any discussion? sorry… | 18:16 |
| ralsina | mmcc: no, I just caught up with backlog | 18:17 |
| mmcc | ralsina ok. | 18:17 |
| mmcc | arch. back again, stupid key shortcut | 18:18 |
| gatox | alecu, let me know when you want to mumble with ralsina and me | 18:22 |
| ralsina | hah! That bug is not darwin-specific. Which means I get to fix it in ubuntu. WIN! | 18:23 |
| ralsina | gatox, alecu:whenever you guys say | 18:24 |
| mmcc | ralsina: what bug? | 18:26 |
| ralsina | mmcc: bug #1040899 | 18:26 |
| ubot5 | Launchpad bug 1040899 in Ubuntu One Control Panel "“Limit upload speed” setting value not saving" [High,In progress] https://launchpad.net/bugs/1040899 | 18:26 |
| mmcc | oh right, yeah I verified it in precise | 18:26 |
| ralsina | mmcc: which is one of the bugs QA reported from the mac exploratory testing | 18:26 |
| ralsina | plus, it seems easy enough | 18:27 |
| mmcc | yes | 18:27 |
| alecu | ralsina, gatox: let's! | 18:32 |
| ralsina | starting the mumbler | 18:33 |
| briancurtin | ralsina: for run-tests scripts to support python3, is it acceptable for that to be done via a "-3" flag or does it need to be smarter than that? | 18:46 |
| ralsina | briancurtin: smart is bad | 18:46 |
| ralsina | briancurtin: ;-) | 18:47 |
| ralsina | briancurtin: at least in this specific case, -3 is awesome | 18:47 |
| briancurtin | alright, cool | 18:47 |
| dobey | briancurtin: well, ideally we'd run the test suite on both 2 and 3 | 18:49 |
| dobey | briancurtin: but given where things are at the moment, we can't really do that | 18:50 |
| briancurtin | dobey: yeah i was originally thinking that, since i end up manually running on 2 and then running on 3. do you think it's fine to go with a -3 flag for hte time being? | 18:51 |
| dobey | briancurtin: the problem with doing that is that we have to pass the full path of the script to python, since we can't do "u1trial -3" for example | 18:52 |
| dobey | briancurtin: so for OSX, it's a problem | 18:52 |
| dobey | (and windows) | 18:52 |
| mmcc | dobey: the new buildout has a python that accepts all flags | 18:53 |
| mmcc | not sure if that helps with u1trial though | 18:53 |
| briancurtin | dobey: i was doing that from within run-tests, http://bazaar.launchpad.net/~brian.curtin/ubuntuone-dev-tools/py3-run-tests/revision/92 | 18:53 |
| mmcc | oh, that's different than 'python -3' | 18:54 |
| briancurtin | (i don't really know if that's a good solution, my bash knowledge is limited, but that least lets me run the tests on 2 and 3, albeit manually) | 18:54 |
| dobey | briancurtin: oh, ick. | 18:54 |
| dobey | briancurtin: that's not the same as python -3 | 18:54 |
| briancurtin | i know | 18:54 |
| briancurtin | i want to execute tests on python2 and on python3 | 18:54 |
| dobey | so it won't catch things that break | 18:55 |
| briancurtin | if that branch is wrong, how should run-tests execute tests on python2 and python3 | 18:55 |
| dobey | i really wish we didn't have to do all this -i foo.py -p foobar/windows junk | 18:55 |
| briancurtin | i'm not (currently) worried about passing flags to the interpreter | 18:55 |
| dobey | briancurtin: i think in cases where we can run the tests on both versions, we should; if we can't, we shouldn't. understand why you want the -3 thing there though, because passing all the args around to u1trial is really annoying | 18:56 |
| gatox | alecu, i know where is being blocking!!! | 18:56 |
| gatox | easy to fix | 18:56 |
| mmcc | briancurtin: since you just want to do it manually, you could do "PYTHON=python3 ./run-tests" | 18:57 |
| alecu | gatox: I think I found it too. | 18:57 |
| alecu | gatox: it's the initial pass of load_items | 18:58 |
| mmcc | at least I think that works. If I'm wrong I'll claim I was thinking of a different shell | 18:58 |
| gatox | alecu, yes! | 18:58 |
| gatox | alecu, because i'm not loading the list by parts like the other place | 18:58 |
| gatox | and that is what is eating all the memory too | 18:58 |
| gatox | because there is a lot of qlabels | 18:58 |
| gatox | fixing | 18:59 |
| dobey | mmcc: it doesn't work if run-tests isn't doing $PYTHON u1trial... | 18:59 |
| mmcc | dobey: it is, in his r92 he linked | 18:59 |
| dobey | mmcc: only because he also added that in his branch already i presume | 18:59 |
| dobey | mmcc: also that's in ubuntuone-dev-tools, which he was pointing at as an example. and he's asking about ubuntu-sso-client, which doesn't do that :) | 19:00 |
| gatox | alecu, works like a charm now :P | 19:00 |
| dobey | i think? | 19:00 |
| alecu | gatox: yes, it should work much better now. | 19:01 |
| dobey | briancurtin: are you asking to do this in dev-tools or sso? | 19:01 |
| mmcc | dobey: aha. well, you added $PYTHON in that file, but I'm not sure about sso | 19:01 |
| briancurtin | dobey: i'd eventually need something for sso, but for now i just need dev-tools | 19:01 |
| gatox | alecu, pushed...... you can test that while i finish fixing the tests | 19:01 |
| gatox | now is fast! :D | 19:03 |
| dobey | oh right | 19:03 |
| dobey | because in dev-tools it runs the scripts from within the tree | 19:04 |
| alecu | gatox: the search is case sensitive! | 19:05 |
| gatox | alecu, shouldn? | 19:05 |
| dobey | briancurtin: need to run for a few real quick, but let me think about it while i'm doing that | 19:05 |
| briancurtin | dobey: sounds good | 19:05 |
| dobey | brb | 19:05 |
| alecu | gatox: I tried searching with "belf" for a file that's named "Belfast", and it's not being found! | 19:05 |
| ralsina | anyone: easy brach for review https://code.launchpad.net/~ralsina/ubuntuone-control-panel/keanu-in-a-bus/+merge/121475 | 19:05 |
| alecu | gatox: I think this should not be case sensitive. | 19:05 |
| gatox | alecu, ok.... i'll fix that | 19:05 |
| alecu | gatox: anyway, bugfix for later | 19:05 |
| mmcc | So - I can't reproduce the stale broker error that mandel proposed a fix for. However, while trying to understand it, I noticed that if you watch the control-panel log, sso.main calls shutdown() just after all the control-panel pages are loaded. Should it be shutting down (ref_count = 0) so early? | 19:06 |
| alecu | gatox: please just add it as a bug. | 19:06 |
| gatox | alecu, it's just: lower() to all the strings | 19:06 |
| ralsina | mmcc: sso shuts down a few seconds after it hands credentials to the last app that requested it | 19:06 |
| alecu | gatox: assuming all the files have ascii names, yes. | 19:06 |
| ralsina | mmcc: it's pretty quick | 19:06 |
| gatox | ahhhhh okok | 19:06 |
| gatox | bug it is | 19:06 |
| mmcc | ralsina: ok, so red herring. thx | 19:06 |
| alecu | gatox: but remember this word: "UNICODE" | 19:06 |
| gatox | jejejee | 19:06 |
| gatox | i know..... i still have nightmares with that | 19:07 |
| ralsina | gatox: ¡já! | 19:07 |
| alecu | gatox: I need to fetch Amelia from kinder, I'll re-review when I get back. | 19:07 |
| gatox | ack | 19:07 |
| ralsina | alecu, gatox: please don't break it for turkish where lower(upper('i')) != 'i' :-) | 19:07 |
| gatox | ralsina, that sounds like endless hours of funn...... for someone else | 19:08 |
| gatox | jejee | 19:08 |
| ralsina | or rather lower('I') != 'i' :-) | 19:08 |
| gatox | why...... why are you ignoring me patch function??!! | 19:09 |
| gatox | :P | 19:09 |
| === lifeless_ is now known as lifeless | ||
| gatox | ralsina, i don't know if you read it..... it seems that the memory and cpu issue is already fix now :P | 19:15 |
| ralsina | gatox: AWESOME | 19:16 |
| ralsina | Have to go pick up my son. Will be back in about 15' | 19:16 |
| gatox | alecu, ralsina tests fixed and pushed | 19:22 |
| alecu | gatox: looking | 19:37 |
| ralsina | back! | 19:37 |
| dobey | briancurtin: i guess the -3 is an ok stopgap in dev-tools run-tests for now, so that people who can run the tests with python3, can do so manually; but a bug saying we should always run the tests with python3 to go along with, would be nice | 19:38 |
| briancurtin | dobey: alright, i'll put that in | 19:38 |
| briancurtin | restarting, printer isn't being found | 19:41 |
| alecu | gatox: why this? self.data['cls'] = FakeDesktopService | 19:42 |
| alecu | gatox: what is it used for? | 19:42 |
| gatox | ahhhhh legacy | 19:42 |
| gatox | deleting | 19:42 |
| ralsina | gatox: starting review of it | 19:43 |
| ralsina | gatox: if you are not too busy can I get a review for https://code.launchpad.net/~ralsina/ubuntuone-control-panel/keanu-in-a-bus/+merge/121475 | 19:43 |
| gatox | ralsina, i've justttttt pushed some changes | 19:43 |
| gatox | ralsina, on it | 19:44 |
| ralsina | gatox: ok, pulling | 19:44 |
| gatox | alecu, fixed | 19:44 |
| gatox | alecu, ralsina also, there was a missing docstring that i just pushed | 19:44 |
| dobey | hrmm | 19:45 |
| gatox | ralsina, jejejeje keanu in a bus? | 19:45 |
| ralsina | gatox: it's about speed! | 19:45 |
| gatox | JAJAJAAJAJ | 19:45 |
| gatox | LOL | 19:45 |
| mmcc | is there any way we could make the twisted PB connection lost error tell us anything about *which* connection was lost? | 19:48 |
| mmcc | like setenv TWISTED_USEFUL_ERRORS=1 ? | 19:48 |
| ralsina | mmcc: YOU_WISH=1 | 19:50 |
| gatox | ralsina, +1 | 19:52 |
| ralsina | gatox: awesome | 19:52 |
| ralsina | gatox: yours is going to take a bit longer ;-) | 19:52 |
| dobey | mmcc: https://bugs.launchpad.net/ubuntuone-dev-tools/+bug/791834 <- this maybe? | 19:52 |
| ubot5 | Ubuntu bug 791834 in ubuntuone-dev-tools "Add an option to enable DelayedCall.debug" [Wishlist,New] | 19:52 |
| gatox | ralsina, i know :P | 19:53 |
| mmcc | dobey: that looks handy, thanks | 19:53 |
| ralsina | briancurtin: when you have 5 minutes for a quick review of https://code.launchpad.net/~ralsina/ubuntuone-control-panel/keanu-in-a-bus/+merge/121475 much appreciated | 19:56 |
| alecu | gatox: here's another bug, for later: "Non-subscribed UDFs are being searched" | 19:59 |
| gatox | alecu, ohhhhhh right | 19:59 |
| alecu | gatox: "The user press the * key" -> "The user pressED the space key". | 20:00 |
| alecu | gatox: why the "unicode(...)" in this line? self.setText(unicode(widget.name)) | 20:01 |
| gatox | alecu, no reason..... that and the docstrings fixed | 20:02 |
| alecu | gatox: what values can there be in "widget.name"? | 20:03 |
| gatox | alecu, unicode was for some old conversion if that was a QString, because before was being used in somewhere else.... but it not a problem there, because setText can handle QString | 20:04 |
| alecu | gatox: ok. Can it be removed then? | 20:04 |
| gatox | alecu, already did | 20:05 |
| gatox | and pushed | 20:05 |
| gatox | with the docstrings fixed too | 20:05 |
| briancurtin | ralsina: looking at that review | 20:06 |
| ralsina | briancurtin: awesome, thanks | 20:06 |
| mmcc | having one of those days where even logging isn't working like I expect | 20:06 |
| gatox | ok..... eod for me....... i need to go and buy some staff before my trip!! if you find anything in my branches, please email me at gmail and i'll fix it tonight!! See you in 2 weeks people!!! HAVE FUN!! :D | 20:07 |
| briancurtin | gatox: enjoy your trip! | 20:07 |
| gatox | briancurtin, thx! :D | 20:07 |
| gatox | first time gatox leave his country...... :P | 20:08 |
| alecu | bye gatox | 20:08 |
| mmcc | have a great trip, gatox! | 20:08 |
| ralsina | it's ok to go to NZ because you are a LOTR fan, but buying a staff seems overkill ;-0 | 20:09 |
| === salgado is now known as salgado-afk | ||
| mmcc | ok, lunchtime here… | 20:16 |
| briancurtin | ralsina: seems unrelated to your branch, but i'm seeing "AttributeError: 'Ui_Form' object has no attribute 'share_links_tab'" | 20:18 |
| ralsina | briancurtin: yes, unrelated | 20:22 |
| ralsina | briancurtin: could be you forgot to run python setup.py build ? | 20:22 |
| briancurtin | ralsina: ah | 20:23 |
| briancurtin | ralsina: approved! | 20:24 |
| ralsina | briancurtin: yay! | 20:25 |
| briancurtin | i need to run to FedEx...suddenly school won't take girlfriend's scanned docs, needs originals overnighted. be back in a bit | 20:26 |
| === salgado-afk is now known as salgado | ||
| dobey | ralsina: https://code.launchpad.net/~dobey/rhythmbox-ubuntuone/update-4-0/+merge/121493 | 20:35 |
| ralsina | dobey: looking | 20:36 |
| ralsina | dobey: global +1 | 20:37 |
| dobey | gracias | 20:38 |
| ralsina | alecu: want me to take over gatox's branch to address your needfixings? | 20:42 |
| ralsina | alecu: and then we have mandel do a review tomorrow on his morning | 20:42 |
| dobey | ick. new unity really does not like drawing things :( | 20:50 |
| * briancurtin back | 20:59 | |
| alecu | ralsina: if you want to take over gatox's branch, please warn him with some email to his gmail account, since I already pingd him about that as he requested. | 21:19 |
| ralsina | alecu: ok, if I do it, I'll do it tomorrow | 21:20 |
| ralsina | alecu: I found a unicode bug :-( | 21:20 |
| alecu | ralsina: another one? ;-) | 21:20 |
| ralsina | alecu: the branch is using os.walk which ... sucks | 21:20 |
| ralsina | alecu: there is a reason why we have a walk helper in u1-client | 21:21 |
| ralsina | mmcc: I am scheduling a test run by QA on mac for late tomorrow, early wednesday. I think it's cutting it very close for our thursday release but it's what we can do. | 21:36 |
| dobey | later all, have a good evening | 21:39 |
| ralsina | bye dobey! | 21:41 |
| mmcc | ralsina: ok - can you refresh my memory on the timeline here? I don't remember a release schedule, just the QA appointment last thursday… | 21:48 |
| ralsina | mmcc: we "alpha" release on thursday | 21:48 |
| ralsina | mmcc: so we should be closing up the code tomorrow | 21:48 |
| ralsina | mmcc: I wanted to have some testing from QA for last-minute fixes | 21:49 |
| ralsina | mmcc: other than that I am testing it myself, as I assume are you and mandel :-) | 21:49 |
| ralsina | mmcc: I have been saying "we release an alpha on August 30th" for at least three weeks now | 21:51 |
| mmcc | ok. yes, I'm testing it myself. | 21:51 |
| ralsina | mmcc: I am pretty happy with how it's working too | 21:51 |
| mmcc | ralsina: apologies for spacing it a bit there on the dates. Think we're in good shape though | 21:53 |
| ralsina | mmcc: it's ok :-) | 21:53 |
| ralsina | mmcc: keeping all the dates in my head is my job, allegedly | 21:53 |
| mmcc | anyway, I should have the daemon stuff wrapped up today. I need to do some testing, but the code signing appears to be less troublesome than I feared | 21:54 |
| * mmcc crosses fingers | 21:54 | |
| ralsina | mmcc: yay | 21:57 |
| mmcc | so, mandel's logging branch didn't work for me - to save him time I have a new merge that did work for me: https://code.launchpad.net/~mikemc/ubuntuone-client/log-monitor/+merge/121507 | 21:57 |
| ralsina | mmcc: looking... | 21:58 |
| mmcc | should be a quicky | 21:58 |
| ralsina | mmcc: yes, I can review that alone | 21:58 |
| ralsina | gatox's branch has *one* functional unicode bug that actually has a simplish fix | 21:58 |
| ralsina | and we may be feature-complete tomorrow! | 21:58 |
| mmcc | ralsina: to review - start syncdaemon however you want, look at syncdaemon.log | 21:58 |
| ralsina | mmcc: ack | 21:59 |
| ralsina | mmcc: global +1 since it's not functional code I am not asking you for tests | 22:03 |
| mmcc | ralsina: great, thanks | 22:03 |
| mmcc | so should I disapprove mandel's earlier branch? what do we do with proposals for branches that we know won't merge (I have another one of those sitting around somewhere) | 22:04 |
| ralsina | mmcc: yes, disapprove | 22:04 |
| mmcc | ok | 22:04 |
| mmcc | brb, ~10 minutes | 22:06 |
| mmcc | b, nevermind | 22:09 |
| ralsina | EOD for me | 22:11 |
| ralsina | bye people, have fun! | 22:12 |
| mmcc | ack, fun it is | 22:12 |
| mmcc | is anyone still around? briancurtin? I have a one-character typo fix merge that could use a quirky review | 22:33 |
| briancurtin | mmcc: yep, send it | 22:33 |
| mmcc | or a quicky review. https://code.launchpad.net/~mikemc/ubuntuone-client/fix-log-typo/+merge/121513 | 22:33 |
| mmcc | but if you want to go quirky I guess my autocorrect would like to see it | 22:33 |
| briancurtin | mmcc: approved | 22:34 |
| mmcc | thanks | 22:34 |
| mmcc | hrm, we can't be logging every file event in the whole system… | 23:04 |
| ralsina | mmcc: hopefully! | 23:23 |
| mmcc | ok, launchd works, squashed a couple of bugs in the daemon code, quieted those logs, still something is stopping us from getting events from the daemon… | 23:28 |
| mmcc | I have to EOD now, but I'm going to come back later and see if I can't get that figured out. | 23:29 |
| mmcc | ok I think it's a simple retain/release bug, have to go now, will try it tonight | 23:32 |
| === m_conley is now known as m_conley_away | ||
| ralsina | mmcc: great! | 23:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!