[01:49] <wgrant> StevenK: wallyworld mentioned on the call that you probably forgot to remove the feature flags from sampledata
[01:49] <StevenK> Drag
[01:49] <StevenK> *Drat
[01:53] <wallyworld_> wgrant: with the change to give all new projects default sharing policies, setPrivateBugs() become irrelevant and broken. so i think i should remove it
[01:53] <wallyworld_> or wil that break apport?
[01:53] <wgrant> wallyworld_: Things that test private_bugs behaviour (which is still important, not for apport but for all unmigrated projects) will have to setBugSharingPolicy(None) first
[01:54] <wallyworld_> there's a garbo job which has migrated all projects except a few commercial ones
[01:54] <wgrant> private_bugs/setPrivateBugs will die with BVP
[01:54] <wgrant> Sure
[01:54] <wgrant> And the commercial ones are the ones that use private_bugs :)
[01:55] <wallyworld_> hmm. ok. will set to None
[01:55] <wgrant> If it was killable already, it would be dead already :)
[01:55] <wgrant> But sadly not quite yet
[01:55] <wallyworld_> yeah, me got a lot of test failures related to all this to fix :-(
[02:03] <wgrant> wallyworld_: Not tooo many things should use setPrivateBugs
[02:04] <wallyworld_> it's more than just that
[02:04] <wgrant> wallyworld_: Most will probably be fixed by fixing makeProduct, I suspect
[02:04] <wallyworld_> bvp stuff fails too etc
[02:04] <wgrant> Ah, true
[02:14] <wgrant> StevenK: Hm, why does lib/deb822.py still exist?
[02:14] <wgrant> It's a broken symlink now
[02:14] <wgrant> Did you miss it in your cleanup?
[02:16] <StevenK> Hmm
[02:16] <StevenK> Seems I did, indeed
[02:19] <StevenK> Sigh, I bet https://code.launchpad.net/~stevenk/launchpad/feature-flags-sampledata is cursed.
[02:21] <wgrant> [2012-08-29 02:03:46,105: INFO/PoolWorker-2] Job resulted in OOPS: OOPS-f59d1eb05281222ebbe8ce921e02b2d8
[02:21] <wgrant> d
[02:21] <wgrant> cursed indeex
[02:31] <wgrant> StevenK: Well
[02:31] <wgrant> StevenK: I was going to say that was a trivial self-review
[02:31] <wgrant> But you made a mistake :P
[02:31] <StevenK> :-(
[02:31] <StevenK> I was like "Green? There's not supposed to be any green in this branch ... Oh."
[02:32] <wgrant> Ah
[02:32] <wgrant> I see the next rev
[02:32] <wgrant> heh
[02:32] <StevenK> That's better, +0, -3
[02:35] <StevenK> wgrant: So now you've made fun of me for it, are you going to review it, or shall I self-review?
[02:36] <wgrant> That's a self-review if I ever saw one
[03:44] <lifeless> jam: what tz are you now?
[03:55] <bigjools> lifeless: he's +4
[03:56] <lifeless> noice
[03:56] <lifeless> halfway to a good place  :)
[04:59] <jam> lifeless: +4
[04:59] <jam> morning, btw
[05:00] <wallyworld_> StevenK: auditor broke db_devel again :-( i need to land a branch to devel but have to wait till db devel is restarted with a testfix or completes fully?
[05:02] <wgrant> wallyworld_: Force, wait 10 minutes, land
[05:02] <wgrant> No need for a testfix or a green run
[05:03] <wallyworld_> ok, will do, ta
[05:03] <StevenK> wallyworld_: The new auditor wasn't in that db-devel run
[05:03] <wallyworld_> ah ok, explains it.
[05:03] <wallyworld_> were you going to land a testfix for it?
[05:03] <StevenK> devel finally passed, so it will be in the next build after buildbot-poller actually merges in stable.
[05:04] <wallyworld_> which will be when do we know?
[05:04] <StevenK> PQM probably rejected it due to db-devel being broken
[05:04] <StevenK> Force a build of db-devel
[05:04] <wallyworld_> ok
[05:05] <StevenK> Bleh, new auditorfixture
[05:06] <StevenK> r15871 has hit stable at least.
[05:07] <StevenK> Now to wait for the 8 revisions to be merged into db-devel
[05:07] <StevenK> Hmmmmm
[05:08] <jam> bigjools: /wave for being online
[05:09] <bigjools> hi jam
[05:09] <bigjools> gimme 5 mins and I'll grab you
[05:09] <StevenK> bigjools: Hahaha. Grab him where?
[05:13] <lifeless> jam: o/ :)
[05:15] <StevenK> Come *ON* buildbot-poller
[05:16] <lifeless> jam: its probably faster to do remote hands (tuolumne)
[05:20] <bigjools> jam: ok, hangout?
[05:28] <jam> bigjools: sure on the hangout, let me grab the camera
[05:28] <StevenK> RARGH
[05:28] <StevenK> buildbot-poller only merges if both builds worked
[05:30] <wgrant> Yes
[05:30] <jam> bigjools: https://plus.google.com/hangouts/_/70125daf3bc2bab87f46d925ed9e5fc229cdf07e?authuser=0&hl=en#
[05:31] <wallyworld_> StevenK: so pqm is ignoring my lp-land and not even sending back hate mail. is that expected?
[05:33] <StevenK> Haven't seen anything in the pqm logs
[05:33] <StevenK> But archvsync is still chewing on my request
[05:36] <wallyworld_> but lp-land should be expected to work right now i think?
[05:36] <wgrant> yes
[05:37] <wgrant> Which branch?
[05:37] <wgrant> new-project-sharing-policies-1040989
[05:37] <wgrant> ?
[05:38] <wallyworld_> no, branch-infotype-portlet2-1040999
[05:39] <wgrant> Hm
[05:39] <wgrant> No conflicts
[05:39] <wgrant> How many times have you tried to land it?
[05:39] <wallyworld_> 3 maybe
[05:39] <wgrant> :(
[05:39] <wgrant> One more time for good luck?
[05:39] <wallyworld_> once when it complained about a testfix, 2 since after forcing bb
[05:39] <wallyworld_> ok, here goes....
[05:39] <StevenK> How long after forcing buildbot?
[05:40] <wgrant> It should have been fine after the first */10 after the forcing
[05:41] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/shift-get_distroseries_pofiles/+merge/121751
[05:42] <wallyworld_> wgrant: yeah, i waited maybe 20 minutes
[05:42] <bigjools> jam: you're frozen
[05:42] <wgrant> wallyworld_: :(
[05:42] <wallyworld_> wgrant: and lestest attempt, nothing
[05:42] <wallyworld_> i gotta go get the kid, back soon
[05:43] <wgrant> wgrant@carob:~$ rsync prasé::
[05:43] <wgrant> rsync: getaddrinfo: pras\#303\#251 873: Name or service not known
[05:43] <wgrant> fail
[05:44] <wgrant> wallyworld_: Hm, it's either hung or a wallyworld-denier
[05:45] <wgrant> I see nothing in its logs from you in more than 50 minutes
[05:45] <wgrant> wallyworld_: Ah
[05:45] <wgrant> wallyworld_: Landed just now
[05:46] <StevenK> Ah ha! It was waiting for wallyworld_ to be AFK.
[06:02] <StevenK> wgrant: No review for me? :-(
[06:03] <wgrant> StevenK: Where's the cleanup?
[06:03] <wgrant> Adding more methods to DistroSeries is probably not removing tech debt.
[06:05] <StevenK> wgrant: Destroying half of a translations module doesn't do it for you?
[06:07] <StevenK> wgrant: I'd argue that they probably belonged their to begin with
[06:08] <wallyworld_> well, next time something fails, i'm going away again and it wil work
[06:08] <wgrant> StevenK: Adding app-specific stuff to registry modules when it can be avoided makes me a very sad panda
[06:09] <StevenK> Obviously, -60 doesn't make you happy either
[06:09] <wgrant> model/distroseries.py is already 1800 lines long
[06:10] <wgrant> -60 is nice
[06:10] <wgrant> But bloating (I)DistroSeries is less so
[06:10] <StevenK> wgrant: Then where?
[06:11] <wgrant> IVPOExportSet? :P
[06:12] <StevenK> Bleh
[06:12]  * StevenK deletes the MP
[06:12] <wgrant> Code reduction is nice, but Distribution/DistroSeries/Archive/Person are already huge
[06:12] <wgrant> We need a better solution than just adding every method in the application to them
[06:13] <lifeless> stop using subclassing ?
[06:13] <wgrant> lazr.restful
[06:16] <jam1> bigjools: it seems to be fairly specific to g+, do you want to try the hangout without video, or maybe mumble?
[06:16] <wallyworld_> StevenK: wgrant: did you guys find any more email addresses on dogfood?
[06:17] <bigjools> jam1: looks like your whole internets given the disconnection from irc!
[06:17] <jam> bigjools: well, hangouts triggers the disconnect.
[06:17] <bigjools> I don't have mumble set up on here.  I think we're pretty much done for now, perhaps you can try out the code and that'll generate more questions
[06:18] <bigjools> yeah I guess they don't like all the bandwidth it seems to eat
[06:19] <wgrant> wallyworld_: Wasn't there only one missing?
[06:20] <wallyworld_> wgrant: not sure. i thought there were a few but could be wrong
[07:47] <adeuring> good morning
[08:29] <jelmer> mgz: done now
[08:31] <mgz> ta.
[08:57] <bigjools> Given a base url like http://host/path and an additional path/to/thing, what would you use in Python to join them? Yes, this is a trick question.
[08:59] <wgrant> bigjools: urlparse.urljoin, as long as the first URL has a trailing /
[09:01] <bigjools> bzzzzzzzzzt
[09:01] <bigjools> wrong
[09:02] <wgrant> Oh?
[09:02] <bigjools> >>> urljoin("http://10.0.0.9/MAAS/", "/api/thing")
[09:02] <bigjools> 'http://10.0.0.9/api/thing'
[09:02] <wgrant> Well, yes, if the path is absolute :)
[09:02] <bigjools> this is the trick part :)
[09:02] <wgrant> But yours wasn't
[09:02] <nigelb> wait, what is the trick part?
[09:02] <bigjools> aha stripping the leading / from the path works
[09:02] <wgrant> >>> os.path.join('where/did/this/go', '/hello/there')
[09:02] <wgrant> '/hello/there'
[09:04] <bigjools> nigelb: the trick is that if you have a leading slash on the path part it doesn't work
[09:05] <wgrant> It trips everyone up, but it is consistent with other path handling and sort of makes sense.
[09:05] <nigelb> oh wow. I totally didn't notice that :)
[09:06] <bigjools> it's a nasty trap for URLs
[09:06] <bigjools> makes total sense for is.path though
[09:06] <bigjools> os.path, even
[10:36] <adeuring> what does this buildbot failure http://lpbuildbot.canonical.com/builders/lucid_db_lp/builds/2252 mean?
[10:41] <wgrant> adeuring: There's a new version of auditorfixture that will hopefully fix that spurious failure
[10:41] <adeuring> wgrant: thanks
[10:41] <wgrant> It should be in the next db-devel build
[10:41] <mgz> how do I unbreak my copy of launchpad today? <http://pastebin.ubuntu.com/1173583/>
[10:42] <wgrant> bin/buildout
[10:42] <wgrant> mgz: ^^
[10:42] <wgrant> Or just make
[10:42] <mgz> ta.
[10:45] <mgz> so, basically I need to run make after bzr switch before running bin/test? I will get used to this in the end...
[10:46] <wgrant> If you're changing between trees of significantly different versions, yes.
[10:46] <wgrant> You do need to rebuild :)
[10:48] <mgz> too used to either python, where you don't, or C, where the way you run tests builds as a side-effect anyway
[10:48] <wgrant> You do in Python unless you have modules installed system-wide.
[10:48] <wgrant> Which is becoming a rarity
[10:48] <wgrant> buildout and pip have this same problem
[10:48] <wgrant> and virtualenv
[11:04] <jam> mgz: any luck with the ppa updates?
[11:05] <mgz> jam: no, we need some major packaging changes
[11:06] <mgz> see the log from yesterday morning, maxb suggested a few things
[11:10] <jam> mgz: "we need major changes" means we should bring up the idea of just going to P w/ flacoste
[11:15] <mgz> jam: I think so, yes, but lifeless wasn't keen
[11:16] <jam> mgz: I'm not specifically keen, but if it is 'spend another 2 weeks sorting out py2.7 on lucid' vs, 'slowly migrate one appserver at a time to P' where the latter is where we want to be anyway...
[11:18] <jam> mgz: I really like the idea of every step being something we can easily roll back, but remember my "installing py2.7 seems tractable"
[11:18] <jam> if that part is invalidated
[11:34] <mgz> okay, lib/lp_sitecustomize.py is what made this so confusing
[11:35] <mgz> ...why is all that work being done pre-normal imports?
[11:37] <jam> mgz: bin/py does not load 'site.py' the regular python site package, instead it uses a custom site.py so that it *only* loads eggs from the buildout location.
[11:37] <jam> to promote isolation from the system.
[11:38] <mgz> sure, but that's site.py
[11:38] <mgz> this sitecustomize.py stuff is all just working around zope being weird and (failing to) silence various loggers
[11:38] <mgz> and importing a barrel of cruft in the process
[11:41] <mgz> deliberately importing bzrlib plugins before script execution seems to serve no purpose, and breaks our api version check stuff
[12:56] <Beret> wgrant, just an FYI, the landscape project wasn't changed to proprietary by SQL
[12:56] <Beret> wgrant, I did it yesterday, so I think we hit a bug
[12:56] <Beret> (I just read the backlog of your conversation with fcorrea)
[12:58] <wgrant> Beret: Around what time did you do it, do you recall?
[12:58] <wgrant> 'cause when I set it away and back to the same setting, it worked fine.
[12:58] <wgrant> Hmmm
[12:59] <Beret> I would guess around 22:00 GMT
[12:59] <wgrant> Thanks
[12:59] <Beret> I'm not certain I just knowit was later in the day
[12:59] <Beret> after the email went out
[13:04] <wgrant> Beret: Ah, found the bug
[13:04] <wgrant> A cleanup job is being a tad aggressive
[13:06] <Beret> sweet
[13:06] <wgrant> Only affects the initial setup, before there are any new bugs or branches
[13:32] <deryck> abentley, ping for standup
[13:32] <abentley> deryck: Sorry, having trouble with it on this machine.  Can you please invite me and I'll answer on my phone?
[13:32] <deryck> abentley, sure
[13:50] <rick_h_> abentley: that makefile update looks good from here. Thanks for that. Did you want to submit that?
[14:24] <wgrant> abentley: Hi, do you have a few minutes to review https://code.launchpad.net/~wgrant/launchpad/bug-1043319/+merge/121874 shortly? It's a pretty simple regression fix for the sharing migration that I'd like to get landed tonight.
[14:25] <abentley> wgrant: certainly.
[14:25] <wgrant> Bah
[14:25] <wgrant> Curtis beat you to it
[14:25] <wgrant> Even though he's not here
[14:25] <wgrant> this week
[14:25] <wgrant> Bad sinzui
[14:26] <wgrant> Thanks anyway :)
[14:26] <abentley> wgrant: np
[14:30] <abentley> rick_h_: Sure, I'll get that in.
[15:27] <abentley> rick_h_: Whenever you're ready for a review: https://code.launchpad.net/~abentley/launchpad/makefile-tweak/+merge/121885
[15:32] <rick_h_> abentley: r=me thanks for the fix
[23:13] <wgrant> StevenK: Morning
[23:13] <StevenK> wgrant: O hai
[23:13] <wgrant> StevenK: Can you QA your rev?
[23:13] <wgrant> And I will QA my fix
[23:13] <wgrant> And then we can deploy the bugfix
[23:13] <StevenK> I am in the middle of doing so
[23:14] <wgrant> thanks
[23:16] <wgrant> StevenK: Did you see the garbo bug?
[23:16] <wgrant> Quite amusing
[23:16] <StevenK> wgrant: Not I recall
[23:17] <wgrant> launchpad.net/bugs/1043319
[23:17] <wgrant> dammit firefox
[23:17] <_mup_> Bug #1043319: UnusedSharingPolicyPruner doesn't preserve permitted access policies <disclosure> <qa-needstesting> <regression> <sharing> <Launchpad itself:Fix Committed by wgrant> < https://launchpad.net/bugs/1043319 >
[23:17] <wgrant> stop pruning schemes
[23:20] <StevenK> wallyworld_: Did you cast your eyes over qas sharing?
[23:23] <wallyworld_> StevenK: yes, looks ok
[23:33] <StevenK> wgrant: Just waiting for your QA and we can deploy
[23:34] <wgrant> Great
[23:35] <StevenK> And I have a row ready to paste into LPS.