| wgrant | wallyworld_: Right, but you need to query the APs to find out the in-use stuff, and the APs include the permitted stuff | 00:00 |
|---|---|---|
| wgrant | So it can be simplified to just returning the APs | 00:00 |
| wallyworld_ | sure, i was speaking logically as to what is missing | 00:01 |
| wgrant | wallyworld_: Do you think we can Won't Fix bug #1008538 now? | 00:42 |
| _mup_ | Bug #1008538: Bug Supervisors are not notified when the project is not shared <bugs> <disclosure> <sharing> <Launchpad itself:In Progress by wallyworld> < https://launchpad.net/bugs/1008538 > | 00:42 |
| wallyworld_ | perhaps. we were waiting for everything to be migrated across i think | 00:43 |
| wallyworld_ | so can't we just leave it in open till then? | 00:44 |
| wgrant | I guess | 00:44 |
| wgrant | I just don't really think there's much we need to do in terms of it now | 00:44 |
| wgrant | Or in the future | 00:44 |
| wallyworld_ | i think we were going to create structural subscriptions | 00:46 |
| wgrant | Mmmm, possibly. | 00:48 |
| cr3 | when using launchpadlib, how can a bug_task.status == u'Triaged' and bug_task.date_triaged == None :( | 01:20 |
| wgrant | cr3: Possibly if it was created Triaged | 01:23 |
| cr3 | wgrant: interesting, so I'll fallback to date_created when any of the status related dates is None. thanks! | 01:24 |
| === bigjools-afk is now known as bigjools | ||
| StevenK | wgrant: https://oops.canonical.com/?oopsid=8dffb8ed96a390893ecaef560b7af41a | 01:56 |
| wgrant | StevenK: wallyworld's thing will fix that | 01:58 |
| wgrant | Though there is an underlying bug that should also ideally be fixed | 01:58 |
| wallyworld_ | if the branch scanner ever completes :-( | 01:59 |
| wgrant | wallyworld_: You linked the bugs before the scan completed | 01:59 |
| wgrant | It's cursed | 01:59 |
| StevenK | wgrant: What's the underlying bug? | 01:59 |
| wallyworld_ | linking bugs is ok | 01:59 |
| wallyworld_ | creating mp is not | 01:59 |
| wgrant | wallyworld_: Evidently not :/ | 01:59 |
| wallyworld_ | i've linked bugs without problems for ever | 01:59 |
| wallyworld_ | but creating mp is problematic | 01:59 |
| StevenK | Doing *anything* with a LP branch before its scanned leads to cursing. | 02:00 |
| StevenK | Even looking at it. | 02:00 |
| wallyworld_ | hmmm. not for me till now | 02:00 |
| wallyworld_ | i've tried the push -r-2 trick. what else can i try? | 02:00 |
| StevenK | Renaming the branch on LP and re-pushing | 02:00 |
| wallyworld_ | besides that :-( | 02:00 |
| wgrant | Nothing | 02:01 |
| wallyworld_ | balls | 02:01 |
| wgrant | Besides SQLing the BRs away without a timeoput | 02:01 |
| StevenK | Haha | 02:01 |
| wgrant | In general, don't touch a large branch before the initial scan completes | 02:01 |
| StevenK | Can we delete BranchRevision for being complete crap? | 02:02 |
| wgrant | [2012-09-03 02:01:54,379: INFO/PoolWorker-2] Job resulted in OOPS: OOPS-5de0a53e4be5589c2a0309cbe7f925b9 | 02:05 |
| wgrant | anyway | 02:05 |
| StevenK | PoolWorker-2 really is cursed | 02:06 |
| StevenK | Bleh | 02:06 |
| StevenK | Can't add a team to +sharing, so can't change the owner of the branch | 02:06 |
| StevenK | Or maybe this thing has a BVP, which would be quite sad | 02:07 |
| wgrant | StevenK: Oh, sorry, meant to say: you can work around that one by just setting Private and Private Security to All. | 02:08 |
| wgrant | As well as Proprietary | 02:08 |
| wgrant | the first two will do nothing | 02:08 |
| wgrant | But it should prevent the crash | 02:08 |
| * wgrant tries | 02:08 | |
| StevenK | Yeah, that worked out it | 02:08 |
| StevenK | around it, that is | 02:08 |
| StevenK | Hah | 02:09 |
| StevenK | +sharing for me states the branch is Private, when the branch itself states it is Proprietary. | 02:09 |
| wgrant | Have you refreshed? | 02:10 |
| wgrant | Where does +sharing state that it's private? | 02:10 |
| wgrant | I don't see that | 02:10 |
| wgrant | Oh | 02:10 |
| StevenK | +sharing/stevenk | 02:10 |
| wgrant | That is interesting | 02:10 |
| StevenK | Quite | 02:10 |
| wgrant | 'cause the APA is correct | 02:11 |
| StevenK | Maybe we have a bug in PersonPillarSharingView? | 02:11 |
| StevenK | However it's named. | 02:11 |
| wgrant | I assume so | 02:12 |
| wgrant | Or possibly in the sharing service, probably | 02:12 |
| StevenK | # At the moment, all branches displayed on the sharing details | 02:13 |
| StevenK | # page are private. | 02:13 |
| StevenK | information_type = InformationType.USERDATA.title | 02:13 |
| StevenK | Face. Palm. | 02:13 |
| wgrant | heh | 02:13 |
| wgrant | Sounds like an easy fix | 02:14 |
| StevenK | Yeah, I'll look at it | 02:14 |
| wallyworld_ | i think that stuff was written for the sharing details page way before information types | 02:14 |
| wgrant | Before they were implemented properly for branches, yes | 02:16 |
| * StevenK tries to work out where the tests for PillarPersonSharingView are hiding. | 02:21 | |
| StevenK | wallyworld_: I don't think PillarPersonSharingView is tested. :-( | 02:40 |
| wallyworld_ | StevenK: not sure, i didn't write it. i can look | 02:41 |
| StevenK | wallyworld_: Second set of eyes would be excellent | 02:41 |
| wallyworld_ | StevenK: PillarSharingDetailsMixin | 02:42 |
| wallyworld_ | test_pillar_sharing | 02:42 |
| wallyworld_ | so TestProductSharingDetailsView etc extend the mixin | 02:43 |
| StevenK | wallyworld_: Ah ha! Thanks | 02:45 |
| wallyworld_ | np | 02:45 |
| wallyworld_ | the tests look like they could have some added | 02:45 |
| StevenK | Bah. | 03:00 |
| StevenK | I have it create a proprietary branch, and it dies creating an APA saying it already exists | 03:01 |
| wgrant | You shouldn't need to manually create APAs any more | 03:01 |
| StevenK | Heh, nice. Dropping the APA lines gives me +22, -23 | 03:04 |
| * StevenK will push the branch up and propose after lunch | 03:05 | |
| StevenK | Actually, no. Since my lunch has to cook, I'll put it on and then push the branch | 03:06 |
| StevenK | wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/branches-are-more-than-private/+merge/122436 | 03:20 |
| wallyworld_ | StevenK: i'd add the test to the subclass | 03:22 |
| wallyworld_ | if it's only applicable for products | 03:22 |
| wallyworld_ | i'd also just call the test view_data_model_branch , remove the word proprietary | 03:23 |
| StevenK | wallyworld_: branches are already tested by test_view_data_model, I was trying to be clear. | 03:24 |
| wallyworld_ | hmm. i'm not sure we need a separate test then. we dont' have a separate test for proprietary bugs | 03:25 |
| StevenK | wallyworld_: So, I can rename it to proprietary, create a bug as well and check that both of their information_types are golden? | 03:26 |
| wallyworld_ | do we need to? so long as the data model tests check that the json info type matches that of the artifact, aren't we ok? | 03:27 |
| wallyworld_ | ie is the existing test sufficient? | 03:27 |
| StevenK | wallyworld_: So the | 03:27 |
| StevenK | Sigh | 03:27 |
| wallyworld_ | i guess i'm asking, why doa special test for one specific info type | 03:28 |
| StevenK | wallyworld_: So the problem was that the existing tests create a bug and branch as USERDATA and then assert that is what is in the JSON. | 03:28 |
| wallyworld_ | maube should need to loop across all info types then | 03:28 |
| StevenK | wallyworld_: The UI was overriding all branches information_type to USERDATA -- so I'm creating a branch that is a type that isn't USERDATA and checking what's in the JSON. | 03:28 |
| StevenK | I could use PRIVATESECURITY just as well | 03:29 |
| wallyworld_ | yeah, understood | 03:30 |
| wallyworld_ | i guess i have a small issue with adding a new test just for one specific info type. we should have a general test that lops over all info types if we don't trust the test that's there | 03:30 |
| wallyworld_ | or change the info type to != USERDATA | 03:31 |
| wallyworld_ | as you suggest | 03:31 |
| wallyworld_ | that may be easiest | 03:31 |
| wallyworld_ | since it gives us a failing test before the code change, and a working test after the fix | 03:32 |
| StevenK | wallyworld_: Sorry, was noming. http://pastebin.ubuntu.com/1182844/ | 03:59 |
| wallyworld_ | np, let me look | 04:00 |
| wallyworld_ | StevenK: sure, but i think we don't even need a whole new test. just make the current data model test fail by changing the info type of the branch to PS or something other than UD, and the code fix makes everything ok again | 04:01 |
| StevenK | wallyworld_: Oh, HAH | 04:13 |
| StevenK | wallyworld_: I can't do it that way -- the branch is created as USERDATA and the JSON is populated on view creation so I can't transition it away, which would have been why I created a new test in the first place. | 04:14 |
| * StevenK sees if he can grab the branch before the view and transition there. | 04:15 | |
| wallyworld_ | can can change the makeArtifactGrantee method | 04:16 |
| StevenK | I can change it to create a PRIVATESECURITY branch, sure | 04:17 |
| wallyworld_ | and that will make the test fail without the code fix | 04:18 |
| wallyworld_ | so i think that's all you need | 04:18 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| StevenK | wallyworld_: http://pastebin.ubuntu.com/1182879/ | 04:23 |
| wallyworld_ | StevenK: i think that's ok. minimal changes, but the tests still fail without the code fix being applied | 04:25 |
| StevenK | And they do, yes. | 04:25 |
| wallyworld_ | cool. adding a new test in this case just didn't sit right weith me | 04:25 |
| wallyworld_ | StevenK: see, i even got you some LOC credit | 04:29 |
| StevenK | wallyworld_: Mercy buckets | 04:30 |
| StevenK | wallyworld_: It's not like I needed more. | 04:31 |
| StevenK | % loc-contributions 'Steve Kowalik' | 04:31 |
| StevenK | -3236 | 04:31 |
| wallyworld_ | well give some of yours to me then | 04:31 |
| wallyworld_ | :-P | 04:31 |
| StevenK | wallyworld_: I would if I could | 04:31 |
| === StevenK changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: 4.0*10^2 | ||
| === StevenK changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: ∞ | ||
| StevenK | That's better. | 04:37 |
| wallyworld_ | lol | 04:42 |
| wallyworld_ | i'd love to revisit out bug triage policy based on these numbers | 04:47 |
| wgrant | http://webnumbr.com/launchpad-critical-bugs :) | 04:49 |
| wallyworld_ | no, i meant i disagree with the triage policy | 04:50 |
| wgrant | I know, I was just showing you some even prettier numbers | 04:51 |
| * micahg stopped filing timeout bugs | 04:51 | |
| StevenK | wgrant: That user destroyed thier MP | 04:53 |
| StevenK | Which is unfortunate, I wanted to grab sinzui's testcase off it | 04:53 |
| wgrant | StevenK: I can forward the email if you wish | 04:54 |
| StevenK | wgrant: From Curtis? Please do | 04:54 |
| wgrant | This is why we shouldn't allow anybody to ever delete anything :) | 04:56 |
| StevenK | No, we need to congratulate him -- he managed to delete a Launchpad branch | 04:56 |
| wgrant | You have a good point... | 04:57 |
| StevenK | He is nothing but persistant | 05:10 |
| StevenK | He's put another branch up which actually fixes the issue, but doesn't include a test. | 05:10 |
| StevenK | wallyworld_: Is PopulateProjectSharingPolicies done? | 05:19 |
| wgrant | Yes, it can die | 05:20 |
| StevenK | stub: O hai, https://code.launchpad.net/~stevenk/launchpad/drop-unused-branch-function/+merge/122431 would love a review | 05:20 |
| wgrant | As of Friday all projects are created with either Public or Proprietary | 05:20 |
| StevenK | I'll kill it | 05:20 |
| wgrant | There's even a card for it | 05:20 |
| stub | StevenK: Applied happily to qastaging. Guess I should run it on production. | 05:39 |
| stub | staging is rather borked - empty db | 05:39 |
| StevenK | Haha, ouch | 05:40 |
| StevenK | stub: Let me lp-land it | 05:40 |
| StevenK | stub: Aren't we in the middle of backups? | 05:42 |
| stub | probably, but that doesn't matter for this | 05:42 |
| stub | That is only a problem for live index builds | 05:42 |
| StevenK | Right, okay. | 05:43 |
| StevenK | wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/destroy-populate-project-sharing-policies/+merge/122442 | 05:47 |
| wgrant | StevenK: +3? :( | 05:53 |
| StevenK | wgrant: Oh, bleh. | 05:55 |
| StevenK | And all of those 3 are imports that went from multi-line to single, so shush | 05:55 |
| wgrant | It was worth a try. | 05:55 |
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| wallyworld_ | wgrant: i just had a look at the accesspolicy code - are you stre the other delete methods just pass in ids? see for example def delete(cls, concrete_artifacts): | 06:44 |
| wgrant | wallyworld_: Natural keys, not necessarily primary keys | 06:46 |
| wallyworld_ | hmm. ok. seems a bit superfulous if i have the objects | 06:47 |
| wgrant | Yeah, but the inconsistency is a bit bad | 06:47 |
| wallyworld_ | i'll now have to unpack them just to apss them in | 06:47 |
| wgrant | Note that it's delete(concrete_artifacts), not delete(abstract_artifacts) | 06:47 |
| wgrant | One could argue that these shouldn't really be objects at all :) | 06:52 |
| wgrant | But mumble mumble | 06:52 |
| wallyworld_ | i agree. i prefer to delete using just ids | 07:18 |
| wgrant | Right, but it's a toss-up between the performance-based surrogate key and the natural key. | 07:20 |
| adeuring | good morning | 07:45 |
| === Peng_ is now known as Peng | ||
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| === almaisan-away is now known as al-maisan | ||
| === Ursinha_ is now known as Guest32164 | ||
| === al-maisan is now known as almaisan-away | ||
| ev | ah, staging is dead. That would explain my inability to do much of anything with the API. | 16:26 |
| czajkowski | hmm | 16:28 |
| czajkowski | getting it kicked | 16:28 |
| czajkowski | ev: people are on it and it's being restored | 16:29 |
| ev | yay | 16:29 |
| === salgado is now known as salgado-afk | ||
| === Ursinha is now known as Guest39611 | ||
| lifeless | o/ | 18:07 |
| === dpm is now known as dpm-afk | ||
| jml | hi | 18:15 |
| lifeless | jml: oh hi | 18:17 |
| lifeless | jml: did you review my fixtures branch ? | 18:33 |
| jml | lifeless: maybe? | 18:33 |
| * jml looks | 18:33 | |
| lifeless | jml: there is a class in there that wants to be free, pondering a new pypi project for it | 18:34 |
| jml | lifeless: yes, I reviewed. | 18:34 |
| lifeless | ahha so you did. Thanks | 18:35 |
| jml | lifeless: I'd wait until there was a project that wanted CallMany & didn't want anything else of fixtures | 18:35 |
| lifeless | jml: like testtools :P | 18:35 |
| jml | lifeless: huh, I guess so. | 18:46 |
| jml | lifeless: "Hard Facts" is a great read, btw. | 18:46 |
| lifeless | jml: it is, isn't it! | 19:01 |
| === cjohnston_ is now known as cjohnston | ||
| === salgado-afk is now known as salgado | ||
| lifeless | any reviewers around ? https://code.launchpad.net/~lifeless/python-oops-datedir-repo/bug-960775/+merge/122580 | 21:21 |
| lifeless | ev: o/ | 21:27 |
| lifeless | ev: will reply to your mail today | 21:27 |
| czajkowski | lifeless: we're down some due to USA being off today | 21:38 |
| lifeless | yeah | 21:40 |
| lifeless | I can still hope :) | 21:40 |
| czajkowski | true :) | 21:44 |
| czajkowski | lifeless: hows the little one? | 21:44 |
| lifeless | just had a growth spurt | 21:47 |
| lifeless | was eating massive amounts every couple of hours for 3 days | 21:47 |
| czajkowski | heh keeping ye busy I'm sure | 21:50 |
| lifeless | yah | 21:51 |
| lifeless | I was at kiwipycon in the weekend | 21:51 |
| lifeless | we could have done with more sleep :P | 21:51 |
| czajkowski | I was at a 2 day Irish wedding , my liver isn't speaking to me | 21:52 |
| lifeless | LOL | 21:55 |
| lifeless | any reviewers around ? https://code.launchpad.net/~lifeless/python-oops-datedir-repo/bug-960775/+merge/122580 <- StevenK | 22:36 |
| StevenK | wgrant is OCR today. :-) | 22:37 |
| lifeless | StevenK: its small and you're doing work already :P | 22:38 |
| StevenK | lifeless: I'm in the middle of a few things, I'll look at it after if someone else hasn't already grabbed it. | 22:38 |
| lifeless | OTOH so is wgrant I see | 22:38 |
| lifeless | StevenK: thanks!; I'll whinge at wgrant right now. | 22:39 |
| * lifeless whinges | 22:39 | |
| StevenK | Default state, isn't it? | 22:39 |
| lifeless | por moi? | 22:41 |
| wgrant | lifeless: 44+ except IOError, e: | 22:43 |
| wgrant | 45+ if e.args[0] == 'Empty OOPS Report': | 22:43 |
| wgrant | Really? | 22:43 |
| * cjwatson bangs the Python 3 compatibility drum a little | 22:47 | |
| cjwatson | (s/,/ as/) | 22:49 |
| lifeless | cjwatson: I might care if we deployed on !lucid | 22:50 |
| wgrant | neem is precise | 22:51 |
| wgrant | We don't deploy on <lucid | 22:52 |
| wgrant | so as is fine | 22:52 |
| lifeless | lucid is python 2.6 isn't it ? | 22:52 |
| lifeless | I thought as was 2.7 | 22:52 |
| lifeless | wgrant: this gets deployed on the various servers - e.g. everywhere. | 22:52 |
| cjwatson | 2.6 has as | 22:52 |
| cjwatson | LP uses 'except ... as' | 22:53 |
| wgrant | Right, we use it in lots of places in LP | 22:53 |
| wgrant | It's not new in 2.7 | 22:53 |
| cjwatson | Everywhere - I went through and fixed everything using the old style | 22:53 |
| wgrant | Ah, indeed | 22:53 |
| cjwatson | https://code.launchpad.net/~cjwatson/launchpad/new-style-except/+merge/112727 | 22:55 |
| lifeless | so sure, will change. | 22:56 |
| lifeless | cjwatson: everywhere in the main code tree; I guarantee lots of untouched places :) | 22:56 |
| lifeless | wgrant: as for the inspection, yes, really. | 22:56 |
| cjwatson | Well, yes, but enough that I also guarantee it will work for you | 22:56 |
| wgrant | lifeless: :( | 22:56 |
| cjwatson | Life's too short to figure out how to submit patches to everything else | 22:56 |
| lifeless | wgrant: lower layer signals that way | 22:56 |
| lifeless | cjwatson: sure, theres about 20 projects that have the same submission process as lp:launchpad :> | 22:57 |
| wgrant | lifeless: :( | 22:57 |
| lifeless | cjwatson: but I understand the overhead | 22:57 |
| cjwatson | And a bunch that don't | 22:57 |
| cjwatson | Also about 50% of the time reviewers seem faintly confused when I submit a patch to one of the other projects | 22:58 |
| lifeless | cjwatson: :( - thats sad, a little understandable, but sad. | 22:58 |
| lifeless | I probably need to beat that drum some more | 22:59 |
| cjwatson | Mostly about how to deal with landing | 22:59 |
| lifeless | cjwatson: ah, so thats more tractable | 23:00 |
| lifeless | wgrant: I can change the signalling, but honestly it doesn't seem worth a specific class | 23:01 |
| wgrant | lifeless: OK | 23:08 |
| === Ursinha` is now known as Ursinha | ||
| === Ursinha is now known as Guest21289 | ||
| === Guest21289 is now known as Ursinha | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!