| ralsina | mmcc: nice branch | 00:17 |
|---|---|---|
| JamesTait | Good morning all! :D | 08:03 |
| === eu is now known as Guest16925 | ||
| alecu | hello, all! | 11:44 |
| ralsina | hello alecu | 12:21 |
| ralsina | hello mandel as well I assume! | 12:21 |
| alecu | hola ralsina :-) | 12:22 |
| ralsina | alecu: good news mandel is going to the nux sprint | 12:25 |
| alecu | ralsina: that's great! has he already left for the sprint? ;-) | 12:31 |
| ralsina | alecu: it starts monday so I hope not! | 12:32 |
| * alecu is green with envy... | 12:32 | |
| alecu | I just love London on summer :-) | 12:32 |
| mandel | ralsina, alecu, hello, yes I was out with the dog for a few mins, he need to pee :P | 12:35 |
| mandel | and I'll go there if the people from the agency do answer my emails.. | 12:36 |
| mandel | alecu, I've been using your branch to test the generic preview idea, I think is great to start with, but what about encapsulating that in a vala class that extends generic view adds the info and exposes properties for the info we have to pass? | 12:37 |
| ralsina | mandel: I lost connection for a bit, so I don't know if this got through: if the agency takes too long, just do orbitz and ask for a refund | 12:40 |
| mandel | ralsina, yes, that is my idea.. they are not very good | 12:40 |
| ralsina | mandel: I would take the trains on saturday with my kindle, but that's just because I love trains :-) | 12:40 |
| mandel | ralsina, I'm done the deal of manchester-madrid by train, not that great.. | 12:41 |
| mandel | lunch time here | 12:49 |
| dobey | hrmm | 12:51 |
| alecu | ralsina: I'm looking at your branch that needs review. I see that most of the code being added touches code that already has tests, so I was wondering if you are able to add some? | 13:13 |
| alecu | ralsina: in the past we had no issues with submiting huge branches to FFe, if the "huge" in the branch was tests. | 13:13 |
| alecu | ralsina: also, since most of the branch is .ui changes, I think the tests won't make it grow so much. | 13:14 |
| ralsina | alecu: ok, let me think it through a bit. | 13:22 |
| DNX | hi guys. I'm unable to move a folder inside my Ubuntu One dir, after "mv" the folder apears again in the old place | 13:44 |
| DNX | some ideas? | 13:44 |
| DNX | if I dosconnect the daemon everithing is ok, but on connect it moves the folders on the original position | 13:47 |
| ralsina | looks like my internet is really flaky today | 13:49 |
| ralsina | alecu: doing the tests, somehow I missed where I had to add stuff. There is one bit that still won't have them (the change in the starting page logic) but that's much smaller and I will do a bug for it (mostly because I don'thave much coding tie for this today) | 13:49 |
| dobey | brb, need to reboot. X has gone a bit wonky | 13:52 |
| alecu | hey all, ralsina says his internet connection has gone down completely. | 13:54 |
| alecu | DNX: that's really weird. | 13:55 |
| alecu | rye: have you seen behaviour like DNX says above? | 13:55 |
| DNX | alecu, also I noticed that it generates some conflicts between these folders | 13:58 |
| rye | DNX: could you please check whether that folder already exists at that place @ https://files.one.ubuntu.com ? | 14:00 |
| rye | alecu: not really, but I was not testing for this | 14:01 |
| DNX | rye, yes, the folder has been correctly syncronized | 14:01 |
| rye | DNX: but it is missing at that location locally, right? | 14:02 |
| DNX | but something is wrong with these folders, I can't reproduce this situation again | 14:02 |
| DNX | rye, yes | 14:03 |
| rye | alecu: ^ looks like remote and local roots diverged | 14:06 |
| rye | alecu: so the folder is in fact there somehow at the server... | 14:07 |
| rye | DNX: what's the last update date for that folder on the server? | 14:07 |
| DNX | rye, 31 minutes ago | 14:08 |
| DNX | and my changes doesn't apear on the server :| | 14:11 |
| DNX | I'll try to move this folder outside Ubuntu One dir and then paste it here again | 14:12 |
| DNX | can I proceed or you need some other details? | 14:13 |
| rye | hm\ | 14:14 |
| dobey | alecu: so ralsina has no internet, and we're waiting for him to add more tests to that branch? :( | 14:14 |
| rye | alecu: i just found a folder on the server that was not present locally. Created the folder and renamed it locally and the one at the server has replaced the server-side folder with the empty local one. I feel that's not how it was supposed to happen | 14:15 |
| dobey | rye: that indeed sounds like a bug | 14:16 |
| rye | alecu: can you please check Move() checks that the destination does not exist already? | 14:16 |
| rye | alecu: because this bug #987767 suggests it does not for rest api and if it is using the same code path then for SD too | 14:17 |
| ubot5 | Launchpad bug 987767 in Ubuntu One Servers "[rest] Renaming a file into a folder overwrites the folder" [Undecided,Triaged] https://launchpad.net/bugs/987767 | 14:17 |
| alecu | rye: in the client, once the Move() command is created and scheduled in the action queue, no such checks are done. | 14:25 |
| alecu | rye: it's up to the sync state machine to decide that. | 14:25 |
| alecu | rye: so, I'll check that too. | 14:25 |
| rye | alecu: well, I am more worried about the server part | 14:35 |
| alecu | rye: in that case we should ask facundobatista or verterok | 14:35 |
| rye | facundobatista or verterok, is Move() operation checking that the destination does not already exist? | 14:38 |
| facundobatista | rye, isn't Move a "overwritting operation"? | 14:40 |
| alecu | facundobatista: for files, it is. | 14:40 |
| facundobatista | rye, locally you do "touch a; touch b; mv b a", this overwrites, in the server it should overwrite too | 14:41 |
| rye | facundobatista: for directory | 14:41 |
| facundobatista | rye, ah! don't know | 14:41 |
| rye | facundobatista: one directory was moved over another one w/o any error here | 14:41 |
| alecu | facundobatista: for directories, there are no unix semantics; most file managers ask you if you want to merge. | 14:41 |
| facundobatista | rye, alecu, how did you move one dir over other in the client? | 14:42 |
| dobey | "mv file directory" typically moves the file in the directory; the problem is that the dir doesn't exist locally on u1 | 14:42 |
| facundobatista | rye, alecu, need to pickup my kid from kinder, brb | 14:42 |
| dobey | and "mv directory file" will fail | 14:43 |
| alecu | also "mv directory directory2" moves it *inside* the second dir, not overwritting it. | 14:45 |
| dobey | yes | 14:45 |
| dobey | and "mv file directory file2 file3 directory2 directory3" will move all the previous arguments into directory3 | 14:46 |
| dobey | the problem here is that we aren't dealing with local files (because it didn't get synced for some reason) | 14:46 |
| rye | dobey: alecu / $ move blah.txt targetDirectory | 14:47 |
| rye | dobey: alecu in cmd_client makes blah.txt inside targetDirectory... | 14:48 |
| dobey | rye: yes; locally, if targetDirectory exists and is a directory, mv will move the file into it; if it doesn't exist, or is a file, mv will place it there | 14:48 |
| dobey | either way, there is clearly a bug in u1 if it overwrites a directory with a file | 14:49 |
| alecu | dobey: it seems to be overwriting a directory with a different directory | 14:50 |
| ralsina | dobey, alecu: pushing branch before the internet goes away again | 14:50 |
| alecu | ralsina: great, thanks! | 14:50 |
| dobey | great | 14:50 |
| dobey | ralsina: what about team call in 10 min? | 14:50 |
| dobey | ralsina: mumble, hangouts, or postpone? | 14:51 |
| ralsina | alecu: there are a couple of missing tests I would like to have for sso_wizard.py and a comment about a couple of flaky asserts that are commented | 14:51 |
| ralsina | alecu: I will file bugs for both | 14:51 |
| ralsina | dobey: postpone until tomorrow | 14:51 |
| alecu | ralsina: great, thanks | 14:51 |
| dobey | ok | 14:51 |
| ralsina | because I don't know how long I will have connection :-( | 14:51 |
| ralsina | alecu: pushed | 14:51 |
| rye | aha! | 14:52 |
| dobey | well if alecu can approve your branch, perhaps i can at least get that FFe done today; and possibly get the icons FFe done as well | 14:52 |
| ralsina | dobey: that would be awesome | 14:52 |
| alecu | ralsina: can you move the commented lines after "There is a problem here, these oscilate 0/1" to a different test method, and use that string as the skip reason? | 14:55 |
| rye | alecu: facundobatista dobey reproduced with cmd_client - if i prevent it from getting the target folder id the directory will freely overwrite anothe directory and SURPISE move blah.txt targetDirectory will make "targetDirectory" into file | 14:55 |
| rye | i mean that targetDirectory becomes a file with blah.txt contents | 14:55 |
| rye | So client can do weird things... | 14:55 |
| rye | but that's still not something DNX experienced, I was not getting any conflicts | 14:56 |
| ralsina | alecu: I can try if arnet lets me ;-) | 14:56 |
| mandel | ralsina, standup in mumble, right? | 14:57 |
| alecu | mandel, mmcc, briancurtin, thisfred: no mumble today: it's been moved for tomorrow | 14:59 |
| alecu | (since ralsina's connection is going haywire) | 14:59 |
| mandel | alecu, oh, thx fort the info | 14:59 |
| alecu | ralsina: if you prefer to fix that skip bit in a different branch I can approve like it is. | 15:01 |
| mandel | me | 15:01 |
| thisfred | me | 15:02 |
| alecu | me | 15:02 |
| briancurtin | me | 15:02 |
| dobey | me | 15:03 |
| mmcc | me | 15:04 |
| alecu | mandel: go! | 15:04 |
| mandel | DONE: Worked on the dash preview factory to detect that is that GenericPreview has an specific title then return a u1paymentpreview. Got to have the daemon running showing always the payment dummy preview for not present songs in the system. Played a little with nux and layouts. Sorted out flights etc.. for the DX sprint in london. | 15:04 |
| mandel | TODO: More on the preview UI work. Understand better nux to do some interesting stuff. Should be able to have a example preview working for tom. | 15:04 |
| mandel | BLOCKED: no | 15:04 |
| mandel | thisfred, please | 15:04 |
| mandel | hola? | 15:05 |
| briancurtin | thisfred | 15:05 |
| thisfred | DONE: u1db server noodling TODO: turn noodling into code BLOCKED: no NEXT: alecu | 15:05 |
| alecu | DONE: discussed search api details with server guys, and lens-dash interfacing with mandel. Coded a sample lens branch so mandel can move forward with dash ui. forgot about reviews, doing some now. | 15:05 |
| alecu | TODO: make lens use real server apis | 15:05 |
| alecu | BLOCKED: no | 15:05 |
| alecu | NEXT: briancurtin | 15:05 |
| briancurtin | DONE: some small windows testing, working on HTTPSServer implementation | 15:05 |
| briancurtin | TODO: fix squid test on 3, HTTPSServer | 15:05 |
| briancurtin | NEXT: dobey | 15:05 |
| dobey | DONE: icon magic, music store poking, file sso FFe, review sso FFe fix | 15:06 |
| dobey | TODO: release/package icon magic | 15:06 |
| dobey | BLCK: None. | 15:06 |
| mmcc | DONE: fixed sync indicator, fought with windows | 15:06 |
| mmcc | TODO: fseventsdaemon | 15:06 |
| mmcc | BLCK: no | 15:06 |
| mmcc | NEXT: no | 15:06 |
| alecu | NEXT: ralsina! | 15:06 |
| alecu | (as long as he is still connected) | 15:06 |
| alecu | Ok, time for comments | 15:07 |
| * mandel finds cpp ugly | 15:07 | |
| mandel | and I always forget the bloody ; | 15:07 |
| alecu | mandel: and how long does it take to compile? | 15:07 |
| alecu | mandel: a little less than "forever", right? | 15:08 |
| mandel | alecu, hehe yes, is kinda slow but the big tower can deal with it.. in london with the laptop is going to be a diff story | 15:08 |
| ralsina | apparently I am connected but I have no notes | 15:09 |
| ralsina | alecu: I will be pushing with references to the missing test bugs & the skip in a minute | 15:09 |
| briancurtin | do you need to twitter shame yourself? | 15:09 |
| alecu | mandel: distcc ftw! | 15:09 |
| ralsina | briancurtin: probably! | 15:09 |
| ralsina | mandel: kde invented a whole thing called icecream to help build large C++ projects on sprints | 15:10 |
| alecu | ralsina: I thought the romans invented icecream! | 15:10 |
| ralsina | alecu: well, the name is because at first it took so long they went out for icecream | 15:11 |
| ralsina | http://en.opensuse.org/Icecream | 15:11 |
| ralsina | it's like a communal distcc | 15:12 |
| thisfred | smells like socialism to me | 15:19 |
| ralsina | thisfred: typical germans | 15:21 |
| dobey | communicable distcc | 15:21 |
| thisfred | stdcc | 15:24 |
| mmcc | briancurtin: unless alecu is already reviewing this, can you take a look at: https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-sync-status/+merge/122974 | 15:24 |
| briancurtin | mmcc: sure, will look shortly | 15:24 |
| mmcc | thanks | 15:24 |
| alecu | mmcc: I had that tab opened, was about to review it shortly... | 15:25 |
| alecu | briancurtin: don't worry, I'll do it. | 15:26 |
| briancurtin | alecu: thanks | 15:26 |
| dobey | lunch time; bbiab | 15:33 |
| ralsina | mmcc: did you see mfoord's mail about the u1 mac client? | 15:33 |
| ralsina | mmcc: I think having no dock icon makes sense in general for us | 15:33 |
| mmcc | ralsina: yes. if we want to do it that way, it's a very minor change | 15:33 |
| ralsina | mmcc: just putting it out there for you to think about it. If you can reply to it, awesome+ | 15:34 |
| mmcc | ralsina: ok. | 15:34 |
| mandel | ralsina, mmcc, I think the dock icon should be seen when the control panel is opened, if it is not don't show it | 15:39 |
| mandel | also our interaction with the dock is quite bad | 15:40 |
| mmcc | mandel: yes, there's a bug about not re-opening the main window when the dock icon is clicked. we could solve that bug by not having a dock icon :) | 15:47 |
| mandel | mmcc, yes, I wonder what happens if a user has several spaces and does not have a way to know the cp is open | 15:48 |
| mmcc | however, we can either have the dock icon always or not at all. either the dock icon is always shown for as long as the controlpanel is running (even if the window is closed) or never… | 15:48 |
| mmcc | mandel, the status menu is shown in all spaces | 15:48 |
| mmcc | mfoord's suggestion was to be just like dropbox and skydrive, ie - just have the menu item | 15:49 |
| mandel | mmcc, yes, is a matter of sending the user to the right space if the cp is already opened | 15:49 |
| mmcc | mandel: sending them to the right space when? I'll have to test this, but I assume that when you do something that results in a window.raise_() , it'll do something sane so you can use the window… | 15:51 |
| alecu | mmcc: on your branch, the status_changed_handlers property can probably be removed, since it does not seem to be used anymore. | 15:51 |
| ralsina | mmcc: when activating by clicking on the menu thingie I guess | 15:52 |
| mmcc | alecu: it's used in tests… I couldn't convince myself that those tests were unnecessary, so I left it in. let me find where they are | 15:52 |
| mandel | mmcc, you have cp in space 3 and the go to the icon menu to launch it you should be sent there | 15:52 |
| mandel | ralsina, exactly that | 15:52 |
| ralsina | mmcc: and raise_ is half-buggy on windows and ubuntu, I would not expect it to be perfect on mac :-( | 15:52 |
| mmcc | ralsina: yes, on osx it's like "raise_() then show()" or something | 15:52 |
| ralsina | mmcc: exactly. And sometimes activate() | 15:53 |
| alecu | mmcc: I see that most tests directly access the underlying list (_status_changed_handlers). Only a few use the property... | 15:53 |
| alecu | dobey: I've approved ralsina's branch, so it should be landing soon. | 15:54 |
| ralsina | alecu: thanks! | 15:54 |
| alecu | ralsina: thank you for the tests :-) | 15:54 |
| ralsina | alecu: np, they had to be there, and arnet gave me time ;) | 15:55 |
| mmcc | alecu, yes in fact now that I look at it, the actual backend property is never used, and the tests that use the property are using the version from the MockBackend class, which is annoyingly near complete | 15:55 |
| alecu | mmcc: right! | 15:55 |
| ralsina | mmcc: so the mock is a copy of the thing? | 15:56 |
| mmcc | alecu - so I'm going to remove it from the real backend and tweak those tests that use the mock | 15:56 |
| * ralsina remembers why mock sucks | 15:56 | |
| mmcc | ralsina: well, at least for this particular bit, the real function is so small that the mock is basically the same (but missing an IPC call, so it's still useful) | 15:56 |
| alecu | ralsina: I think that's a custom mock, not the "mocker" module. | 15:56 |
| ralsina | ok | 15:56 |
| mandel | yes, mocker has been nearly killed in our code | 15:57 |
| alecu | ralsina: anyway, that was my first reaction too :-) | 15:57 |
| ralsina | we have a bunch of places where the fake is >= than the original | 15:57 |
| alecu | mandel: I nearly don't trust that statement. | 15:57 |
| ralsina | but better than not having a fake I guess | 15:57 |
| alecu | mandel: :-) | 15:57 |
| mandel | alecu, hehe at least the test we have been doing recently, I do no some places that are dominated by mocker | 15:58 |
| ralsina | mandel: I would pay actual money to get rid of it. Everytime I had to fix a mock test it was easier to rewrite it. | 15:58 |
| mandel | ralsina, maybe in another life when we have the time :) | 15:59 |
| alecu | mandel: maybe there is no other life, but a hell forever fixing mocker tests! | 16:00 |
| ralsina | THE HORROR | 16:00 |
| mandel | where all the bad kids go.. hehe | 16:00 |
| ralsina | "wrong number of calls to method flogMeWithAPineApple" for eternity | 16:00 |
| mmcc | better than C++ template type errors | 16:02 |
| ralsina | mmcc: when I coded for KDE I once got a two-page template error. It meant "there is one space too many to the left of your third >" or something similar. | 16:08 |
| mmcc | ralsina: nice! (wow) | 16:09 |
| mmcc | anyone know why this hasn't merged: https://code.launchpad.net/~mikemc/ubuntuone-fsevents-daemon/commserver-tests-2/+merge/122741 | 16:12 |
| mandel | let me check | 16:13 |
| ralsina | mmcc: looking... | 16:13 |
| mandel | mmcc, fixed :) | 16:13 |
| mandel | missing comment | 16:13 |
| mmcc | mandel, aha thanks. why doesn't it complain? | 16:13 |
| mandel | mmcc, the tarmac gods... dobey ? | 16:14 |
| mmcc | and do we need to toggle the status again to make it notice? | 16:14 |
| mandel | mmcc, AFAIK we don't but it would not do any harm | 16:14 |
| mandel | mmcc, did it plus an other +1 :P | 16:15 |
| mmcc | mandel: good. it's important that you approve of your own code :) | 16:15 |
| mandel | mmcc, I know hehehe | 16:16 |
| mandel | mmcc, I'v got a big ego :) | 16:16 |
| mmcc | I clearly don't know what to say to that | 16:20 |
| mandel | mmcc, is more in the latin meaning than the eng one, although they are close | 16:23 |
| mmcc | ping alecu, just pushed your suggestion: https://code.launchpad.net/~mikemc/ubuntuone-control-panel/fix-sync-status/+merge/122974 | 16:37 |
| alecu | mmcc: thanks | 16:37 |
| alecu | mmcc: done | 16:42 |
| mmcc | alecu, thanks | 16:42 |
| dobey | mandel: i presume you meant "commit message" rather than "comment" there? | 16:55 |
| mandel | dobey, yes, sorry | 16:55 |
| dobey | you didn't need to vote for that :) | 16:55 |
| mandel | dobey, having fun :) | 16:59 |
| mandel | well, rugby time, I'll catch you all tom! | 17:01 |
| ralsina | bye mandel! | 17:05 |
| * briancurtin lunch | 17:39 | |
| ralsina | dobey: want a rubberstam on https://code.launchpad.net/~dobey/ubuntuone-client-data/more-updates/+merge/123131 or are we supposed to do real code reviews? ;-) | 17:39 |
| dobey | ralsina: not yet | 17:40 |
| dobey | ralsina: found some annoyance i'm trying to fix | 17:40 |
| ralsina | dobey: ack | 17:41 |
| dobey | what's the right regex to compress multiple blank lines into a single blank line? | 17:41 |
| mmcc | dobey, is ".art" in that COPYING.art a standard naming convention? why not COPYING-ART.txt so e.g. OS X knows how to open it? | 17:42 |
| mmcc | just curious, really | 17:42 |
| dobey | mmcc: it's follows the common convention of using COPYING.lesser or COPYING.lib for the LGPL exceptions to the GPL, and such | 17:45 |
| mmcc | dobey: ah, ok | 17:45 |
| dobey | it's COPYING.icons in ubuntuone-client currently for example; but i figured .art would be better since this project may include more art :) | 17:45 |
| dobey | oh | 17:46 |
| dobey | mmcc: that reminds me. what was the icns creation tool you mentioned previously for osx? and is it open source? | 17:47 |
| mmcc | dobey: the one that apple ships is called iconutil, and a quick google scan says it is not open source. I wouldn't have expected it to be | 17:48 |
| dobey | damn | 17:48 |
| mmcc | why? | 17:49 |
| dobey | i was hoping it was; and written in a suitable language for running on other platforms | 17:49 |
| dobey | because png2icns doesn't support the @2x retina stuff | 17:49 |
| mmcc | oh, definitely not other platforms :\ It uses CoreFoundation stuff | 17:49 |
| dobey | ralsina: ok, now you can 'review' it :) | 17:51 |
| ralsina | dobey: ha | 17:51 |
| ralsina | dobey: there | 17:52 |
| dobey | ralsina: btw, looks like the new shares tab is in the omgubuntu 12.10 features preview video :) | 18:10 |
| ralsina | whoa | 18:13 |
| ralsina | nice :-) | 18:13 |
| ralsina | hope we had had another month to polish that one | 18:14 |
| dobey | heh | 18:14 |
| dobey | hey look at that. a green ball next to the ubuntuone-windows-installer build in jenkins | 18:15 |
| dobey | yay me! | 18:15 |
| mmcc | :) | 18:16 |
| * dobey waits for the beta1 release announcement so he can upload new sso | 18:17 | |
| * briancurtin back | 18:18 | |
| briancurtin | wasn't much of a lunch, more of a try to buy two boxes of sudafed (different types) and get denied because you could cook meth with it | 18:19 |
| dobey | blame iowa | 18:19 |
| mmcc | briancurtin: that's funny, last time I did that they just took my drivers license info. just like when you get codeine… | 18:20 |
| mmcc | also, bummer | 18:20 |
| briancurtin | mmcc: they did that too, but after the first scan it locks you out for X amount of days (which the cashier couldnt tell me X) | 18:20 |
| ralsina | briancurtin: bad idea buying sudafed in a porkpie hat. | 18:20 |
| briancurtin | at least i had a good comeback: i dont want that second box anyway, i'd rather use methlamine | 18:21 |
| briancurtin | (i watch too much Breaking Bad) | 18:21 |
| mmcc | bad timing - today was lab coat day at briancurtin's | 18:21 |
| ralsina | hahaha | 18:21 |
| dobey | man; waiting for the battery to die on my sansa fuze is very annoying | 18:23 |
| alecu | dobey: yay green balls! They beat blue any time! | 18:29 |
| === yofel_ is now known as yofel | ||
| dobey | brb | 18:36 |
| alecu | hmm.... should I get the new kindle fire hd, or a nexus 7? | 18:50 |
| ralsina | alecu: you hate kindles! | 18:53 |
| * ralsina is so getting the paper white | 18:53 | |
| * dobey is so not buying a tablet | 19:11 | |
| briancurtin | i kind of want a win8 tablet (seriously) | 19:11 |
| dobey | briancurtin: well i can have one for $40 apparently (just upgrade win7 to win8 on my dell duo) | 19:15 |
| dobey | mmcc, mandel: there are no merge proposals for https://code.launchpad.net/~mandel/ubuntuone-fsevents-daemon/jenkins-daemon-main, yet https://code.launchpad.net/~mikemc/ubuntuone-fsevents-daemon/mungeproj/+merge/122314 depends on it | 19:19 |
| mmcc | dobey: yes, we're aware of that. I talked with mandel yesterday and he says he needs to add some more tests to it before he proposes | 19:20 |
| dobey | ok | 19:20 |
| ralsina | dobey: I don't see the kindle as a tablet. I see it as a book. | 19:21 |
| ralsina | which is why I want the paper white, not the fire | 19:21 |
| briancurtin | anyone have a minute for a four line diff (+2/-2)? https://code.launchpad.net/~brian.curtin/ubuntuone-dev-tools/py3-exception-message/+merge/123151 | 19:25 |
| ralsina | briancurtin: sure | 19:25 |
| ralsina | briancurtin: global +1 | 19:27 |
| briancurtin | thanks ralsina | 19:27 |
| mmcc | man, it's not easy to tell what these IPC tests are actually testing | 19:40 |
| mmcc | I keep commenting out things that I think should break the tests, and they resist breakage! | 19:40 |
| ralsina | mmcc: delete! | 19:41 |
| mmcc | ralsina: :| - I think it'd be even harder to prove that they're useless… They're just not clear | 19:42 |
| mmcc | I was expecting to find a test case that would send a signal and check that it gets received without error, or at least a place to add one | 19:42 |
| mmcc | there's a test_remote_signals, but it patches emit_signal, so we only test that we call emit. Nothing is testing that the round trip is OK | 19:44 |
| mmcc | so I removed the patch to emit_signal, just to see what happened, and only a few of the tests failed :o | 19:45 |
| dobey | meh, and the launchpad ppa builders are being really slow right now :( | 19:45 |
| ralsina | dobey: happens every thursday | 19:48 |
| dobey | well, every thursday when there's a beta release, anyway | 19:50 |
| mmcc | oh duh, only the first test in the loop has to fail for the whole test case to fail | 19:51 |
| ralsina | alecu: locked himself out of his house, so he will only be back later tonight | 19:55 |
| ralsina | sorry, that explains alecu locked himself out :-) | 19:55 |
| dobey | tab complete strikes again! | 19:56 |
| dobey | meh | 20:12 |
| dobey | bah and now youtube videos are not playing on the youtube site itself, but the embedded videos on g+ play fine. wtf | 20:36 |
| ralsina | dobey: I get all youtube videos at 2x speed for a couple of weeks already | 20:38 |
| thisfred | saves a lot of time | 20:39 |
| ralsina | thisfred: kinda ruins the music | 20:39 |
| thisfred | ralsina, maybe it's the RIAA's new plot | 20:39 |
| thisfred | ralsina, you just have to think of everything the alvin and the chipmunks version | 20:40 |
| ralsina | thisfred: allow me to retort: yeeeech | 20:42 |
| dobey | have a good evening all! | 21:27 |
| mmcc | OK, time for me to go. If anyone feels like reviewing - this fixes the on_download_finished exception, and adds a test that'll hopefully help avoid that kind of thing in the future | 22:53 |
| mmcc | https://code.launchpad.net/~mikemc/ubuntuone-client/fix-signal-exceptions/+merge/123189 | 22:53 |
| mmcc | TIL more than I wanted to know about u1client's twisted IPC and tests | 22:53 |
| mmcc | that was a warmup, tomorrow: fix the IPC with the root daemon | 22:53 |
| mmcc | good night | 22:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!