/srv/irclogs.ubuntu.com/2012/09/13/#launchpad-dev.txt

StevenKwgrant: Hm, I wonder if we should error if authorized_size is null for ArchivePurpose.PPA00:36
wgrantStevenK: Or just enforce the quota iff authorized_size is set00:37
wgrantRather than iff it's a PPA00:37
StevenKwgrant: This isn'00:37
StevenKBleh00:37
=== matsubara-afk is now known as matsubara
StevenKI'm not sure about that bug, I'm looking at bug 96531700:38
_mup_Bug #965317: TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'  on +repository-size page <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/965317 >00:38
wgrantAh, so separate but related00:39
wgrantIf there's no quota then there's no quota, I guess00:39
wgranthttp://irclogs.ubuntu.com/2012/02/18/%23launchpad-dev.txt00:40
StevenKRight00:40
=== spm is now known as stevemci
=== stevemci is now known as spm
lifelesscan has review ? - https://code.launchpad.net/~lifeless/lp-dev-utils/ppr/+merge/12408400:45
lifelesssmall00:45
lifelesswgrant: ^00:47
lifelessStevenK: ^?01:08
StevenKlifeless: r=me01:11
lifelessthanks'01:11
=== StevenK changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: ∞
lifelesswgrant: test failures ~ critical?01:26
wgrantlifeless: Running the test suite outside X or xvfb-run is unsupported01:26
=== spm is now known as stevemci
wgrantSo that one is not critical01:26
=== stevemci is now known as spm
lifelessoh, I didn't notice that nuance.01:27
lifelesswhere was he running it ?01:27
wgrantAssuming you're talking about bug #102014601:27
_mup_Bug #1020146: lp.testing.layers.YUITestLayer tests fail in various ways without X <test-system> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1020146 >01:27
wgrantcanonistack, I assume01:27
lifelessI'd wontfix in fact, if its not a supported config01:31
wgrantNah01:31
wgrantIt should work01:31
lifelesshow?01:32
wgrantThere's no reason our test browser should need to use X01:32
StevenKBut it's not critical01:33
wgrantThat's why I made it not critical.01:33
rick_h_all of the webkit enabled browsers require x though I think phantomjs was working around it. Not sure if they got it done01:33
rick_h_it's how they're working, by using the webkit ui toolkits to load the pages01:34
wgrantRight01:34
wgrantBut nothing about this fundamentally requires X01:34
wgrantIt's just the library we happen to use atm01:34
lifelessalloftheones01:34
rick_h_so yea, phantomjs would be a good way to go: http://code.google.com/p/phantomjs/wiki/XvfbSetup01:35
rick_h_I've testsed trying to run with grover + phantomjs but it blows up horribly currently01:35
lifelesswgrant: so what was bug 739042 ?01:42
_mup_Bug #739042: DistroArchSeries:+index timeouts <timeout> <Launchpad itself:Fix Released by wgrant> < https://launchpad.net/bugs/739042 >01:42
wgrantlifeless: Terrible FTI that I fixed a few months back01:46
lifelessah cool01:47
wallyworldwgrant: looking at another web service exported collection - IBug.bug_tasks. It also just gives a list of dict values ie lp.bugs[5].bug_tasks.entries gives [{...}, {...}] so i'm yet to find a collection where one can get at objects01:47
wallyworldso i still can't see what the bug is wanting different to what we currently do elsewhere01:48
wallyworldor if it's possible/feasible01:48
wgrantwallyworld: Oh, why are you calling .entries?02:09
wallyworldto get the values in the Collection02:09
wgrantIterate :)02:09
wgrantAsking for the entries will get you the raw entries02:09
wgrantIn [3]: list(lp.bugs[5].bug_tasks)02:10
wgrantOut[3]: [<bug_task at https://api.launchpad.net/devel/launchpad/+bug/5>]02:10
_mup_Bug #5: Plone Placeless Translation Service metadata missing from po files <feature> <lp-translations> <Launchpad itself:Fix Released by daf> < https://launchpad.net/bugs/5 >02:10
wallyworldoh, ok. i didn't realise entries did that02:10
wallyworldand that i needed to iterate02:10
wallyworldthanks02:10
wgrantThe collection is an iterable of EntryResources02:11
wgrantIt also has a .entries attribute which is an iterable of the raw JSON representation of the entries02:11
wallyworldok. i didn't appreciate there was a difference, i thought .entries just have the values in the current batch02:12
lifelessheh, nice trap02:13
wallyworldyeah, i fell into it. i'm still no expert on our restful api02:14
lifelessis anyone/02:14
wallyworldStevenK: auditor client bb failure!02:25
StevenKStrange02:28
wgrantsinzui: Can we kill bug #450480?02:32
_mup_Bug #450480: Get PCI and USB vendor/product names from the "PCI ID Repository" project and from linux-usb.org respectively <hwdb> <regression> <Launchpad itself:Triaged> < https://launchpad.net/bugs/450480 >02:32
sinzuiI have not decided...02:33
sinzuimaybe you cane02:33
sinzuihelp02:33
sinzuiLeann does is not affected by the bug. She will not no if we fix it02:33
sinzuiIt is tempting to say that the unused feature is not a regression02:34
wgrantlifeless: Your last act on #579602 confuses me02:35
_mup_Bug #579602: cannot call getBranches on a source package using the API <api> <lp-code> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/579602 >02:35
sinzuiwgrant, I think can say wont fix, but what of the oopses...I don't think we can close them until the code is removed02:36
wgrantsinzui: Which OOPSes?02:37
sinzuiwgrant, https://bugs.launchpad.net/launchpad/+bugs?field.importance%3Alist=CRITICAL&field.tag=hwdb02:39
lifelesswgrant: me too02:40
wgrantsinzui: The other three must remain by ZOP02:40
wgrantsinzui: But the 450480 is a regression, not an oops02:41
sinzuiI agree02:41
sinzuiwgrant, as I suggested in the meeting, we can ignore them until we get the word that HWC has their replacement operational. There are about 31 bugs that can be closed with we remove the hwdb02:42
wgrantsinzui: Right, but I'm going to demote the regression since nobody cares02:43
sinzui+102:45
StevenKsinzui: I'm going to remove the Builder:+history timeout FF on prod with your blessing02:46
sinzuiSure. We can put it back if we are wrong02:47
lifelesswallyworld: are you still working on 681767 ?02:57
lifelessbug 681767 that is02:57
_mup_Bug #681767: Can't use relative URLs with launchpadlib.Launchpad - generates URI object that breaks wadllib <lp-foundations> <lazr.restfulclient:In Progress by wallyworld> < https://launchpad.net/bugs/681767 >02:57
wallyworldlifeless: i think that one was put on hold02:58
wallyworldsince my solution was rejected02:58
lifelesskk02:58
lifelessthanks02:58
lifelesssadface at the fix committed etc being images03:12
wgrantlifeless: Where?03:17
lifelessbug listings03:18
wgrantThey're not images03:18
lifelessoh, wtf then03:18
lifelessctrl-f won't find them03:18
wgrantDoes so :)03:18
lifelessmmm, I must have had a typo.03:18
lifelessweird.03:18
wgrantWorks for Triaged in Firefox at least03:18
lifelessah03:19
lifelessthe fix is funky03:19
lifelesstry this03:19
lifelesshttps://bugs.launchpad.net/~lifeless/?field.status%3Alist=FIXCOMMITTED03:19
lifelessctrl-F03:19
lifelessfix03:19
lifelessin firefox03:19
wgrantWorks03:19
lifelessand nope, commit doesn't either.03:20
lifelessunless I click in one of them03:20
lifelessthen it works03:20
wgrantWorks either way for me03:20
lifelessso, doesn't for me :)03:21
lifelessuntil I click in the page03:21
wgrantHuh03:21
lifelessdo you have match case enabled ?03:22
lifelesscause I did :(03:22
lifeless<- muppet03:22
wgranthaha03:22
lifelessUI could tell you03:23
wgrantIndeed03:23
lifeless'15 more hits if match case is turned off'03:23
lifelesswgrant: so - http://bugs.python.org/issue1638033 - what should the thing be set to to close in LP?03:27
lifelessits 'accepted closed' atm,03:27
lifelesssurely closed should mean LP puts it in a terminal state ?03:27
wgrantProbably03:28
wgrantBut I believe 'fixed closed' is what LP expects03:29
wgrantPerhaps they've changed03:29
lifelesswhat /is/ the python tracker ? RT ?03:29
wgrantRoundup03:30
lifelessah03:30
wgrantWe have a custom set of mapping tables for the Python Roundup in our codebase03:30
lifelessyay03:32
lifelesswell if you care - https://bugs.launchpad.net/launchpad/+bug/105017303:32
_mup_Bug #1050173: bugwatches set to accepted closed in roundup maps to 'fix committed' not 'fix released' <bugs> <bugtrackers> <bugwatch> <roundup> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1050173 >03:32
wgrantI'd say Python roundup03:32
wgrantI believe they're all different03:32
wgrantWe certainly have a custom status map for python03:32
lifelesstweaked03:34
wgrantThanks03:34
wgrantThere's 3 or 4 checkwatches criticals, so someone's likely to get around to touching that area soon03:34
lifeless\o/03:36
lifelesson the make lifeless' bug list clean effort ;)03:36
wgrantHeh03:36
wgrantWe should make more pages less terrible03:39
wgrantParticularly since that tends to involve making code shorter03:39
StevenKwallyworld, wgrant: https://code.launchpad.net/~stevenk/launchpad/deal-with-no-authorized_size/+merge/12409704:24
wgrantStevenK: Rejected due to invalid apostrophe use04:24
wallyworld+10004:24
StevenKWhat invalid apostrophe use ...04:24
wallyworldsigh04:24
wallyworldwhy don't people know grammar these days04:25
StevenKI just fixed it, so I'm playing innocent.04:25
wallyworld:-)04:25
wallyworldit's one of my pet peeves04:25
wgrantStevenK: Also, I'd prefer that you fixed policySpecificChecks  rather than checkArchiveSizeQuota, maybe04:25
wgrantStevenK: At least de-dupe the check04:25
wgrantIt may be best to remove the PPA guard around the checkArchiveSizeQuota check, I guess.04:26
StevenKwgrant: Why? There are other checks in checkArchiveSizeQuota.04:26
wgrantAfter checking on production that it won't impact the primary archive04:26
wgrantWe can apply the quota check to any archive with a quota set04:26
StevenKwgrant: Hmmmm04:28
StevenKwgrant: http://pastebin.ubuntu.com/1201917/ ?04:33
wgrantStevenK: You've changed the security rejection behaviour04:34
wgrantAlso, you might want to explicitly check if it's not None04:34
wgrantRather than if it's not 004:34
StevenKwgrant: is None, even04:35
wgrantWell, yes.04:35
wgrantthat04:35
StevenKwgrant: Changed? Sure, but I don't think it will impact anything.04:38
StevenKwgrant: And "SELECT id, name FROM archive WHERE authorized_size IS NOT NULL AND purpose <> 2;" == 46 on DF04:41
wgrantStevenK: It'll now reject security uploads to PPAs with a different message04:41
StevenKwgrant: PPAs do not have a security pocket?04:42
wgrantRight, they wouldn't have been accepted, but this might change the way they're rejected.04:42
StevenKSo I don't think it's a concern. It is certainly something to keep in mind when it's QA'd.04:43
StevenKwgrant: ^ Agree or disagree?04:47
wgrantStevenK: Have you checked the history of that method, to see why the guard was added?04:48
wgrantIt's possible it was incidental when the quota check was added04:49
wgrantBut it would be nice to check before we remove it04:49
StevenKwgrant: For checkArchiveSizeQuota? Because it was written only for PPAs.04:51
wgrantStevenK: But there's the opposite guard for the security pocket check04:51
StevenKBecause other archives have pockets, I guess04:52
wgrantRight04:52
wgrantIt may have been there for a reason04:52
wgrantOr it may not04:52
wgrantBut we should check before removing it04:52
StevenKThe else was added in r1566304:55
wgrantReadded, perhaps04:55
StevenK[r=wgrant][rollback=15658] Revert r15658, as uploads to -security will have their builds automatically failed. Update associated comments.04:55
wgrantcjwatson removed it04:55
wgrantAh yeah04:55
wgrantThen I readded it04:56
wgrantannotate before that04:56
wgrantAh, no, cjwatson reverted it, but I reviewed it?04:56
wgrantOdd04:56
wgrantThe else is a little over 5 years old04:57
wgrantI would remove it04:57
wgrantIt was added with the ubuntero PPA check04:58
StevenKYou mean, like I did? :-)04:58
wgrantYes04:58
wgrantBut with verification04:58
StevenKWhich we just did04:58
wgrantIndeed04:59
wgrantPush and I can approve :)04:59
StevenKwgrant: Diff updating. I attempted to destroy archive-views.txt, but I'm sad to say it defeated me.05:02
StevenKwgrant: And diff updated05:04
ajmitchhttps://code.launchpad.net/~ajmitch/launchpad/prerelease-backports/+merge/124100 for minimal change, if you want to comment05:08
StevenK8+ def test_insecure_does_not_approve_backports_before_release(self):05:08
StevenK10+ self.setHoaryStatus(SeriesStatus.CURRENT)05:08
StevenKUhhhh?05:08
StevenK:-)05:09
ajmitchlulwut05:09
StevenKYour two test cases are indentical05:09
ajmitchyeah, now I see that05:09
ajmitchI wasn't sure whether to even keep those since I'm not touching the uploadpolicy now05:10
StevenKIndeed05:10
* ajmitch was copying from the earlier tests in there, fwiw 05:10
ajmitchjust copied a bit too vigorously05:10
StevenKI was about to say something like that05:11
StevenKajmitch: So, you don't touch the uploadpolicy at all, which means the comments for the two tests is technically correct, but only because the policy doesn't check05:11
StevenKajmitch: bzr revert -r submit: lib/lp/archiveuploader/tests/test_uploadpolicy.py && bzr ci ?05:12
wgrantlifeless: Thoughts on my suggestion in bug #1050191?05:12
_mup_Bug #1050191: allocate-revision-karma.py is too slow to complete <branches> <karma> <lp-code> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1050191 >05:12
ajmitchright, I'd initially made the mistake of changing the approval policy & wrote the test05:12
StevenKRARGH05:12
StevenKIs the filename on neem pointless or something?05:12
* ajmitch commits & pushes05:14
StevenKBleh, I have a file with a current OOPS and the sha1 in the filename isn't the OOPS ID05:16
ajmitchStevenK: ok, less LOC added now :)05:17
StevenKajmitch: test_checkUpload_backports_development could do with a comment05:17
StevenKwgrant: Thanks for the +1, tossing at ec205:18
ajmitchok to plagiarise from the test above, or do you like to have the bug # in there as well?05:18
StevenKajmitch: Just plagiarise, no need for the bug number05:19
StevenKRight, so the oops id is 3607c5f44e382d14bd9ff678dbc51097, but the filename is OOPS-4f2364563d7a41ea4918845f2d86aec5.05:20
=== matsubara is now known as matsubara-afk
* ajmitch waits for the diff to update05:22
StevenKAh, so '?id%OOPS-' to search for. Sigh.05:22
wgrant?05:23
StevenKAh, so '?id%OOPS-' is the magic string to search for.05:23
wgrantWell05:24
wgrantI grep for the actual unique bit05:24
wgrantOh, you mean finding the web-accessible OOPS ID in a known file?05:24
StevenKI had the filename, but not the ID05:24
StevenKwgrant: Yeah05:25
wgrantI just search for OOPS- :)05:25
StevenKwgrant: I'm happy to approve ajmitch's MP, do you see any issues with it?05:26
wgrantIt's from New Zealand05:26
* ajmitch was expecting a comment like that05:26
StevenKOh, so, "This was written by a PHP developer." status => Rejected05:27
wgrantThat too05:27
ajmitchthe love I get in here05:27
wgrantajmitch: Have you discussed this with cjwatson?05:28
ajmitchonly in passing, not the submitted branch05:28
wgrantAh, I see TB discussion05:28
wgrantHave you considered the issue of autoapproval?05:28
ajmitchthey should land in unapproved05:29
ajmitchI'd considered it, made a change in uploadpolicy & then reverted once I clarified that they'll always be unapproved05:29
wgrantRight, only RELEASE and PROPOSED (and only in unstable series) get autoapproved05:29
wgrantI'd like to see an ack from Colin just in case, but otherwise that looks fine05:30
ajmitchok05:30
StevenKLet me approve it, with that note05:30
ajmitchI'll ping him later when he's hopefully around05:30
ajmitchthanks for the review05:30
ajmitchnot that the diff was overwhelming05:31
wgrantHeh05:31
StevenKwgrant: https://code.launchpad.net/~stevenk/launchpad/double-archivesub/+merge/12410205:56
wgrantStevenK: It already deals with it06:02
wgrantBy raising an exception06:02
StevenKwgrant: That isn't caught and ends up as an OOPS06:03
wgrantStevenK: Right, but you could catch it06:04
wgrantOr make it a 400 if it's an issue with the API06:05
StevenKwgrant: I could, I decided to follow the pattern that we have for bug/branch subscriptions06:06
wgrantIt looks like that can only happen over the API06:07
wgrantSo I would just annotate it with BAD_REQUEST06:07
StevenKhttps://oops.canonical.com/?oopsid=3607c5f44e382d14bd9ff678dbc51097 disagrees06:08
wgrantAh, indeed, missed the two browser callsites06:09
wgrantIn one case you want to crash06:10
wgrantIn the other you probably want to inform the user that they're insane06:10
wgrantAlternatively, in the latter ('activate') case you could call getAuthToken first06:10
wgrantOr catch the exception and call getAuthToken06:10
StevenKWe sort of06:11
StevenK        if self.request.form.get('activate') and not self.active_token:06:11
wgrantHm, then do you know how the exception happened?06:13
wgrantPerhaps the token was deactivated06:13
StevenKHm, perhaps06:13
* StevenK tries to remember where PersonArchiveSubscriptionView is hit from06:19
wgrantYou mean Person:+archivesubscriptions?06:19
wgrantOr one of the archive-specific views?06:19
StevenKI created an authtoken and then called deactivate on it and the UI says I have no tokens06:20
wgrantYou need a subscription06:21
wgrantThe UI shows subscriptions06:21
StevenKHm, Archive:+subscriptions is forbidden as an admin?06:23
wgrantYes06:23
wgrantAdmins don't hold launchpad.Append on IArchive06:23
wgrantIt's like launchpad.Special in that regard06:23
StevenKRight, now I have a subscription06:25
StevenKThen I set it to expired and it disappears from the UI again06:30
wgrantSure06:31
wgrantDoesn't necessarily mean it's not accessible06:31
wgrantIt's also possible that the token is somehow deactivated, but the sub is not06:31
StevenKOh, there's a seperate table for the token?06:31
wgrant(eg. a team sub was created, a token was issued, then the team sub was revoked, then a person sub was created, maybe?)06:31
wgrantyes06:31
wgrantSubscriptions can be for teams06:32
wgrantTokens can't be06:32
stubwgrant: is this index I see before me to replace an existing index, or in addition?06:32
wgrantstub: In addition06:32
stubwgrant: Why have status included then, as the preamble states it is indended for use when not filtering by status?06:33
wgrantstub: It's not necessary, but due to that order it also doesn't affect size/performance significantly.06:34
wgrantI can remove it if you want06:34
wgrantIt's not really useful until we have index-only scans, I guess06:34
wgrantcjwatson: What blockers remain to prevent the removal of delayed copies?06:49
adeuringgood morning07:38
stubwgrant: So that new index, is that status ever going to be used? We already have an alternative index on (archive, das, status, bpn)07:38
stubwgrant: Unless we need to use the four fields for ordering, but I don't think we ever want to do that.07:39
wgrantIndeed07:41
wgrantI might drop status07:41
wgrantstub: That's done07:46
stubok07:46
=== almaisan-away is now known as al-maisan
stubIs this the correct way for force the use of our patched pgbouncer in Depends: ? pgbouncer (>= 1.5.2-2+lp2, < 1.5.2-3)08:47
wgrantstub: You need two separate dependencies08:47
stubok, so don't just believe that builddeb worked :)08:48
stub1.5.2-2+lp2~23~lucid1 and 1.5.2-2+lp2~23~precise1 are the two interesting versions it needs to work with08:48
wgrantAlso, << rather than <08:48
stub  pgbouncer (>= 1.5.2-2+lp2), pgbouncer (<< 1.5.2-3),08:51
maxbIt might be more practical to make the patched pgbouncer "Provides: pgbouncer-lp" and depend on that, unless the patch is going to get upstreamed shortly08:51
wgrantThat won't work.08:51
wgrantDue to ~08:51
wgrantYeah08:51
wgrantI was about to suggest the Provides08:51
wgrantBut it will hopefully be upstream soonish08:52
wgrantFor the versioned Depends to work, you'd want pgbouncer (>= 1.5.2-2+lp2~), pgbouncer (<< 1.5.2-3~)08:52
wgrantBut the Provides is probably a better solution for now.08:52
stubSure about that twiddly after the 3?08:52
wgrantYes, otherwise eg. 1.5.2-3~lucid1 will satisfy your dep08:53
stuboh, guess so08:53
wgrantWhich you probably don't want08:53
* cjwatson adds a kanban card to have a look at ajmitch's MP a bit later09:43
cjwatsonwgrant: I have branches leading up to it all locally.  The main blocker is that bigjools raised a concern about the PCJ queue for PPAs being starved if e.g. we'd just run an auto-sync.09:44
cjwatsonwgrant: Which is arguably a blocker for removing the feature flag guarding the fix for bug 575450 (releasing that from beta), which will allow us to remove the synchronous +copy-packages mode and thereafter remove delayed copies.09:45
_mup_Bug #575450: Archive:+copy-packages nearly unusable due to timeouts <lp-soyuz> <ppa> <qa-ok> <timeout> <Launchpad itself:Triaged> < https://launchpad.net/bugs/575450 >09:45
wgrantcjwatson: Ah, right.09:46
wgrantI'd forgotten about the starvation issue09:46
cjwatsonwgrant: I'm not sure whether the proper fix is to bring up multiple cron jobs for PCJ processing, or to convert it all to celery.09:46
cjwatsonThe vague consensus seemed to be the latter, but also that celery was a bit untried.09:46
wgrantThat's one way of putting it09:47
cjwatsonI was due to try out celery for ProcessAcceptedBugsJob, when I get back to that ...09:47
wgrantIndeed09:47
wgrantadeuring: It looks like a recent private projects landing has broken buildbot. Can you investigate?09:50
=== al-maisan is now known as almaisan-away
rick_h_adeuring: ping11:13
rick_h_nvm, looks like wgrant already ping'd you on it11:13
adeuringmorning rick_h_11:13
rick_h_adeuring: sorry, was just going to see if you'd peeked at the buidbot breakage. Looks like it's breaking on a query around specification stuff that landed11:14
adeuringrick_h, wgrant: acutally, I did not notice...11:14
adeuringlooking now11:14
rick_h_adeuring: cool, thanks. Sorry for the dupe :)11:14
dpmhi launchpadders, could someone help me with a generic question on LP cronscripts? I'm trying to find out what it would take to move a script that currently talks to the DB to export translation data into the LP source tree. I'm told by jtv that the best way would be to turn the script's main code into a class derived from LaunchpadCronScript, but that I should double-check with other LP developers.11:20
dpmFor reference, the script is here: https://launchpad.net/lp-get-ul10nstats/trunk11:21
=== broder_ is now known as broder
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
=== _mup__ is now known as _mup_
=== micahg_ is now known as micahg
=== almaisan` is now known as al-maisan
=== jamestunnicliff_ is now known as jamestunnicliffe
=== heroux_ is now known as heroux
=== al-maisan is now known as almaisan-away
=== jcsackett changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: jcsackett | Firefighting: - | Critical bugs: ∞
mptAre there any prizes given for marking really old bugs as duplicates?13:52
czajkowskimpt: I'll give you cake13:54
czajkowskihow's that13:54
mptdeal :-)13:54
czajkowskiwin win :)13:54
czajkowskimpt: but you're not allowed to create new ones :)13:54
mptWhat would be the point of that? If they're new ones they're not really old ones13:55
mptoh, you mean you're limiting me to marking duplicates, not reporting bugs at all13:55
=== matsubara_ is now known as matsubara
dpm> hi launchpadders, could someone help me with a generic question on LP cronscripts? I'm trying to find out what it would take to move a script that currently talks to the DB to export translation data into the LP source tree. I'm told by jtv that the best way would be to turn the script's main code into a class derived from LaunchpadCronScript, but that I should double-check with other LP developers.14:04
dpm For reference, the script is here: https://launchpad.net/lp-get-ul10nstats/trunk14:04
=== wgrant_ is now known as wgrant
=== salgado` is now known as salgado
cjohnstonWhen trying to use lp-setup, I've tried many times now to run install-lxc.. I continue to get a Permission denied (publickey) error (http://paste.ubuntu.com/1202807/) each time I try.. any idea what is causing this?15:14
cjohnstonI've double checked my key and its correct15:21
cjohnstonhmm.. hmm.. appears as tho as somepoint I was logged out from bzr launchpad-login.. stand down all :-)15:32
=== lan3y is now known as Laney
cjohnstonok.. more hmm.. any chance that lpsetup changes my launchpad-login?16:05
czajkowskicjohnston: breaking things :)16:06
cjohnstonprobably16:06
cjohnstonjust not sure how :-(16:06
czajkowskisinzui: might you give cjohnston some pointers please16:07
sinzuiI have't use it16:07
cjohnstonNot quite sure why I'm importing the Yellow Squad key: http://paste.ubuntu.com/1202922/16:08
deryckjcsackett, hi.  I have a branch for review, but....16:09
deryckjcsackett, I'm about to lunch.  So don't mind waiting until I'm back if you need to chat interactively.16:10
jcsackettderyck: i don't mind looking now, i can put any questions in a comment.16:10
deryckjcsackett, awesome, thanks!  https://code.launchpad.net/~deryck/launchpad/use-specification-sharing-policy/+merge/12424016:11
deryckcatch you after lunch then.16:11
=== deryck is now known as deryck[lunch]
cjohnstonsinzui: I found the issue through the code.. you can pass --lpuser, but if you don't it defaults to your system user name.. :-/  /me wonders how many people have their system user name and lp name the same and if that should be the default or a required flag16:18
sinzuicjohnston, I agree. Lp chooses the user name from the first email address imported or sent from ubuntu SSO. There is little chance the system user will match the lp identity16:20
sinzuicjohnston, this may relate to benji's bug Bug #103460516:22
_mup_Bug #1034605: handle_lpuser_as_username does validate the given LP username <lpsetup:Triaged> < https://launchpad.net/bugs/1034605 >16:22
cjohnstonI don't think so.. from what I can tell, you can provide whatever username you want, and that bug is referencing checking to see if you mistyped your username.. whereas the issue I'm having that because I didn't know that I needed to provide a username, its picking what is a valid lp username, so his test would pass.. it just wouldn't be me16:24
cjohnstonI guess related, possibly, the same, I don't think so16:24
cjohnstonsinzui: should I talk to frankban_ about it, or someone else?16:26
=== matsubara is now known as matsubara-lunch
dpmtrying again...16:32
dpmhi launchpadders, could someone help me with a generic question on LP cronscripts? I'm trying to find out what it would take to move a script that currently talks to the DB to export translation data into the LP source tree. I'm told by jtv that the best way would be to turn the script's main code into a class derived from LaunchpadCronScript, but that I should double-check with other LP developers.16:32
dpm  For reference, the script is here: https://launchpad.net/lp-get-ul10nstats/trunk16:32
czajkowskidpm: poked elsewhere as well16:37
dpmthanks czajkowski16:37
mgzfallback would be an email to list, which would add the australians as an audience16:38
jcsackettdpm: assuming mgz's comment was at you, i agree with him. hit the launchpad-dev mailing list, and you'll get more attention.16:39
jcsackettdpm: or rather, you'll get attention with more direct knowledge on what you're doing. :-P16:39
jcsacketti would say though that we've done a lot of moving things *out* of the LP tree--what's the motivation to move this in?16:40
dpmjcsackett, I've been told that such scripts cannot live outside the LP tree, so it was disabled16:40
jcsackettdpm: that would be a good reason. :-P16:41
cjwatsonjcsackett: direct db access16:41
abentleyderyck[lunch]: Good morning.16:43
jcsackettso, dpm, i think step one is def to derive from LaunchpadCronScript.16:43
jcsacketti would still email the list though, so people who have done similar work can inform you of any potential gotchas.16:44
dpmjcsackett, yeah, that was what jtv recommended (LaunchpadCronScript), but he suggested to check with other devs whether that was still the recommended way to run such jobs (or if using celery tasks or any other technology is the preferred way in LP nowadays)16:46
jcsackettdpm: well, celery jobs and other job stuff is in my experience best meant for things that need to be jobs, but respond to real time events in the app.16:46
jcsackettlike merging accounts, for example.16:46
jcsackettif this is just a nightly script or similar, i think cron is still the place for it.16:47
jcsackettothers may of course have different opinions.16:47
jcsackettbut i don't think we've abandoned cron as a way of doing things.16:47
abentleyjcsackett: We do have Celery running one periodic task, but we haven't really migrated to Celery for everything yet.16:48
abentleyjcsackett: So I don't know whether we'll prefer to use Celery for that in the future.16:48
dpmjcsackett, it's currently a daily job, and it simply exports data automatically (i.e. it does not need to respond to anything), so I guess cron should be fine16:50
jcsackettdpm: i would think so.16:52
rick_h__jcsackett: ping17:21
jcsackettpong.17:22
rick_h__jcsackett: hey, do you know the details of the bug/stuff going aroud on the linking of the nav stuff in the table listing?17:22
rick_h__I'm hitting a failing test out of no where with an error that linkify_navigation isn't defined and it's kind of confusing. I thought I saw some of your squad doing something with that in MP that flew by17:23
jcsackettrick_h__: wallyworld__ addressed a broken link error i think, but i don't recall the details.17:23
jcsacketti assume you're rebuilt js?17:24
rick_h__jcsackett: yea, ah there's the branch.17:25
rick_h__jcsackett: ok thanks17:25
jcsackettrick_h__: yw.17:25
czajkowskimpt: with those duplicates you get a cookie not a cake17:29
=== matsubara-lunch is now known as matsubara
=== deryck[lunch] is now known as deryck
deryckabentley, hi there.17:38
abentleyderyck: I see that abel was working on fixing my test failure.  I don't see it in devel, but I'm assuming it's in ec2.17:39
deryckabentley, yeah, it's in ec2.  Should be in shortly, assuming it passes.17:40
abentleyderyck: I'm just digging into the privacy banner test failure, which appears to be from the same root cause.17:40
sinzuijcsackett, do you have time to review https://code.launchpad.net/~sinzui/launchpad/mailman-email-addresses/+merge/12427318:17
jcsackettsinzui: sure. :-)18:17
jcsackettsinzui: r=me. i love branches that delete doctests. :-)18:20
sinzuithank you jcsackett18:21
rick_h__jcsackett: branch your way if you have time: https://code.launchpad.net/~rharding/launchpad/lp_cache_update/+merge/12421718:28
rick_h__diff still updating though18:29
jcsackettrick_h__: one question: this dump to json utility only works for information types, and all the other info_type related stuff that's not tied to an artifact lives in registry. shouldn't it be there instead of app?19:01
rick_h__jcsackett: so if you know of a place in there to put it I'm happy to move it.19:03
rick_h__this is replacing the manual JSON stuff that was in each browser/xxxx.py19:03
rick_h__so it was in browser/product browser/bugtarget and going into browser/specification19:03
rick_h__since it was used in those places I defaulted to app/utilities19:04
jcsackettrick_h__: hm.19:04
rick_h__if no one minds it sitting in registry/enums I'm ok with it, or prefer a registry/utilities19:04
rick_h__it kind of didn't seem to fit so open to anything19:04
jcsacketti have no problem with enums, as its just a function to work with one of said enums.19:04
jcsackettbut registry utilities would be fine as well.19:04
jcsacketti just don't want a developer months from now to waste time figuring out if information type lives in app or registry.19:05
rick_h__jcsackett: right, understand. I've got no dog in the fight at all.19:05
jcsackettso, i'll mark this approved with the understanding you'll move that to either reg/enum or reg/util?19:05
rick_h__sounds like a plan to me, thanks19:05
jcsackettr=me then. :-)19:06
jcsackettother than that, nice cleanup. :-)19:06
=== ajmitch_ is now known as ajmitch
sinzuilifeless, do you have time to talk about escalated bugs20:50
czajkowskisinzui: you playing whack a bug today on bugs, you're so making progress on them :D20:50
sinzuiczajkowski, yes, but it wont last. A lot are trivial or dupes. I expect the pace to slow in about 4 weeks20:51
czajkowskithat's still a lot of weeks and a lot of bugs sinzui20:52
lifelesssinzui: I do. G+? Skype? IRC?20:52
sinzuiczajkowski, I will cheer when the bug critical bug count  drops to 254, 1 less than Purple left it in July 201120:53
sinzuilifeless, I want to try g+20:53
czajkowski:/20:54
lifelesssinzui: you or your canonical version should have an invite now20:54
=== gary_poster is now known as gary_poster|away
wallyworld__sinzui: do you have time for a quick pre-impl before the standup?21:51
sinzuijcsackett, https://bugs.launchpad.net/bugs/bugtrackers/alsa-mantis lists fadly and it is only visible to ~registry22:14
sinzuibug 210821 is still not fixes22:14
_mup_Bug #210821: bug tracker list shows inactive projects <404> <bugwatch> <lp-bugs> <qa-ok> <trivial> <Launchpad itself:Triaged> < https://launchpad.net/bugs/210821 >22:14
sinzuifixed22:14
lifelessczajkowski: why the sadface?22:29
czajkowskilifeless: the number in stats22:31
czajkowskilifeless: a year later and the number is down by 122:31
lifelessnot yet22:32
lifelesssinzui is looking forward to that point22:32
lifelessczajkowski: http://webnumbr.com/launchpad-critical-bugs22:33
czajkowskilifeless: aye he;s playing whack a mole on the bugs this week, it's interesting to follow.22:34
StevenKczajkowski: Not just sinzui.22:37
StevenKAll five of us have been pouring over the critical bug list this week.22:37
lifelessjam: around ?22:38
* lifeless doubts it22:38
czajkowskiStevenK: yes you have I just picked one and refere to the whole team, but yes it's a group thing22:38
czajkowskilifeless: I think he's utc +5 no?22:39
jelmeryeah, he should be asleep22:39
lifelessshould be :)22:39
StevenK+4, I think22:40
lifelessjelmer: have we published any bzr plugins to pypi ...22:40
jelmerlifeless: I think so. I know I have.22:40
lifelessI want to nuke sourcecode22:40
lifelessmeans letting bzr import plugins from eggs22:40
lifelessahha22:40
lifelesshttp://pypi.python.org/pypi?%3Aaction=search&term=bzr&submit=search22:41
StevenKAnd mailman22:41
lifelessjelmer: ^22:41
lifelessStevenK: one crime against nature at a time22:41
jelmerlifeless: I like the idea.22:42
jelmerlifeless: so, bzr-git and bzr-svn are on pypi. we were going to get rid of bzr-hg. bzr-loom is missing, as is loggerhead.22:43
lifelessand bzr-pqm and others22:43
jelmerbzr-pqm is in sourcecode?22:43
lifelessI was pinging jam to ask his view on pushing them up, and to get acls as we'll need to fix the dependencies, switch them to use distribute ('setuptools')22:43
lifelessjelmer: its used for ec2test, so we need it somewhereish22:43
jelmerlifeless: don't we have it in the Launchpad PPA? Or do you really want it as egg?22:44
* lifeless shrugs22:44
lifelessjelmer: http://rbtcollins.wordpress.com/2012/08/27/why-platform-specific-package-systems-exist-and-wont-go-away/22:44
lifelessjelmer: kindof like to setup lowest cost maintenance for the things we're maintaining22:45
jelmerlifeless: I've read it earlier :-)22:45
jelmerlifeless: I think that's the right approach, but bzr-pqm is also immutable enough that I wonder if it's worth worrying about at this point.22:46
lifelesssure, I'm not pushing hard for it, but it was in the working set that popped into mind22:46
jelmerFair enough.22:47
lifelesshuh22:50
lifelesslooks like 2.6 does it already22:50
lifelessat least under pip22:50
lifelessah, right, the virtualenv shoves it in the default search path22:51
lifelessso that provides an alternative22:51
lifelessgary_poster|away: if you come back, what would you say to a move to virtualenv+pip ?22:51
mwhudsonplease no22:52
lifelessmwhudson: details22:53
mwhudsonlifeless: well, one thing is "move to pip" from what?  buildout?22:53
lifelessyes22:54
mwhudsoni talked about this a little in my canonical-tech thread a bit22:54
mwhudsonpip is not very good software22:54
lifelessimagine I have no idea what you're talking about22:55
lifelessdesperately want to use pip22:55
mwhudsonsorry22:55
lifelessand you have to dissuade me22:55
lifelessThis is a lie, but will get you to tell me what you need to :)22:55
mwhudsonlifeless: was trying to find a citation22:56
mwhudsonlifeless: basically if you depend on packages a and b and a and b depend on _different_ versions of package c22:56
mwhudsonlifeless: pip's response is "pick one"22:56
mwhudsonlifeless: pip has no equivalent of buildout's allow-picked-versions = false22:57
sinzuiwallyworld__, is this the bug?22:57
sinzuiBug #86752922:57
_mup_Bug #867529: Dynamic loading comments load on top of page content <firefox> <javascript> <qa-untestable> <regression> <story-batched-comment-loading> <Launchpad itself:Triaged> < https://launchpad.net/bugs/867529 >22:57
lifelessok, assuming you're using the implicit dependency graph vs flatten and resolving to a single requirements doc like LP does with buildout (and can be done with pip too)22:57
wallyworld__sinzui: yes22:58
mwhudsonlifeless: and this is more anecdata than something i can be specific about is that upgrades are very difficult22:58
mwhudsonlifeless: so you want to make a new venv for each revno you deploy22:58
lifelessmwhudson: isn't that what -I -r versions.txt is for ?22:59
mwhudsonlifeless: but there is no equivalent of the egg cache in the pip world, so making a new venv will take as long as a "make build" in a completely new launchad tree22:59
lifelessright, because it doesn't use eggs. Some folk would call that an advantage ;)23:00
mwhudsonlifeless: i don't think there is any way to make pip check that versions.txt is complete23:00
lifelessmwhudson: how would you solve this for pip ?23:01
mwhudsonlifeless: i wouldn't use it23:01
lifelessOk.23:01
mwhudsonoh you mean, if i was to try to fix pip?23:01
mwhudsoni don't know23:01
lifelessHow would you solve this in a world where buildout is going away, upstream are still discussing the colour of the bikeshed, and you are relentlessly pragmatic :)23:01
mwhudsonlifeless: is buildout going away?23:03
mwhudsoni don't know23:03
mwhudsonembrace juju aggressively and move to debs (maybe using pypi-install liberally)?23:03
lifelessmwhudson: buildout: kindof, upstream have indicated that our LP specific tweaks are being removed in the next release.23:05
lifelessunless we port them, gary_poster|away has the details.23:06
mwhudsonah23:07
mwhudsonmmf23:07
mwhudsonthis is the relative-path stuff i guess23:08
lifelessSo we have a choice of investing in buildout, investing in pip, or investing in the heat death of the universe.23:08
mwhudsoni guess we don't actually get a choice about the latter23:08
mwhudsonlifeless: well, i don't want to impose my views on you over strongly23:09
mwhudsonbut we had a pip based deployment approached and it sucked23:09
mwhudsonand we now have a buildout one and it works well23:09
mwhudsonthe underlying tech is surely not all of that23:09
mwhudsonbut it is probably part of it23:09
lifelessmwhudson: totally unscientific: http://www.googlefight.com/index.php?lang=en_GB&word1=pip&word2=buildout23:10
lifelessIt may mean, for instance, that pip is hard to use so folk write about it more.23:10
sinzuiwallyworld__, bug 402915 is what you may have a fix for23:10
_mup_Bug #402915: Can no longer move a branch to another project using the UI <lp-code> <package-branches> <regression> <target-picker> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/402915 >23:10
mwhudsonlifeless: oh, pip is very popular no doubt23:10
mwhudsonlifeless: you can also play the game with python/php or jquery/yui23:10
lifelessindeed.23:11
StevenKwgrant: ComponentLookupError: ((<Person at 0xfda1810 person-name-100003 (Person-name-100003)>, <lp.services.webapp.servers.LaunchpadTestRequest instance URL=http://127.0.0.1>), <InterfaceClass zope.interface.Interface>, '+archivesubscriptions/16')23:18
StevenKwgrant: I thought I'd constructed it to what the ZCML said, but obviously not.23:18
wgrantThat's no view name23:18
wgrantThat's a path23:18
wgrantYou'll need to create a request with ['16'] as stepstogo23:19
elmoThat's no moon!23:19
StevenKHmm, still no failure23:28
StevenKwgrant: I need to grep through appserver logs?23:35
wgrantStevenK: No, you can see the request URL in the OOPS23:36
bigjoolsguten tag23:36
StevenKwgrant: Right, and that gives me the archive id and the user.23:39
wgrantStevenK: Right23:42
wgrantStevenK: So what would appserver logs give you?23:42
wallyworld__bigjools: your shift key broken?23:46
bigjoolswallyworld__: I don't believe in german capitalisation23:47
StevenKwgrant: Handily, neither the archive or person exist on DF23:47
wallyworld__bigjools: you don't have a choice if you want to write properly :-P23:48
bigjoolswallyworld__: I always have a choice23:49
wallyworld__same goes for writing English with poor grammar/spelling I guess23:50
bigjoolswallyworld__: there's choice vs ignorance23:53
bigjoolsI am mainly ignorant when it comes to German :)23:53
wgrantStevenK: That's why we have ops :)23:53
wallyworld__bigjools: i was just trolling23:54
bigjoolswallyworld__: I know, but I was chomping on the bait like a hooked fish23:54
wallyworld__yep, i reeled in a big one alright23:54
bigjoolsthat begs an obvious response23:55
wallyworld__i throw out the bait....23:55

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!