| === gary_poster is now known as gary_poster|away | ||
| lifeless | yay | 03:55 |
|---|---|---|
| lifeless | 10000 OOPS-4f236f15bf506c5061124374b4816633 Unknown | 03:55 |
| cjohnston | When someone gets a chance, could I please get some opinons on the wording changes in https://code.launchpad.net/~chrisjohnston/launchpad/part-essential/+merge/124559 - the reasoning why the change is being made is listed in the MP | 19:49 |
| czajkowski | cjohnston: please mail to the -dev list | 20:17 |
| czajkowski | cjohnston: irc really at the weekend isn't a good idea for getting feedback. | 20:18 |
| cjohnston | I know.. just posting it for if someone happens to be around and bored | 20:21 |
| cjohnston | lifeless: I'm not against it being removed.. I am just not sure that I'm up to snuff with the LP code to be the one to remove it.. there is a 'middle' registration level between attending and required that participation essential is getting.. if you want to remove participation essential from LP, I'm good with it.. I would just rather it happen much sooner than later | 20:55 |
| lifeless | the meetings system exists solely as a/the backend for summit | 20:55 |
| lifeless | if there is a mismatch, I think you should fix it | 20:55 |
| lifeless | I mean, you could have made participation essential a restricted field in LP | 20:56 |
| lifeless | so that only drivers could set it. | 20:56 |
| cjohnston | that would work for me as well... again, I am not sure how much success *I* would have with it.. :-) | 20:56 |
| lifeless | LP is straight forward to develop on | 20:57 |
| lifeless | there are occasional gotchyas, but that happens everywhere. The buggest hurdle I've seen folk have is just not trying at all. | 20:57 |
| cjohnston | or user is owner: | 22:54 |
| cjohnston | essential = BoolCol(notNull=True, default=False) | 22:54 |
| cjohnston | err | 22:55 |
| lifeless | cjohnston: moving the attribute from the Edit to Admin interfaces probably | 23:00 |
| lifeless | cjohnston: and dealing with any manual forms that show it specifically and should instead not | 23:01 |
| lifeless | cjohnston: probably a few hundred lines of diff once you track all the bits down. | 23:01 |
| lifeless | cjohnston: if you're talking about changing who can set it | 23:01 |
| lifeless | cjohnston: if you're talking about removing it, thats a little more complex, needs three patches: | 23:01 |
| lifeless | - one patch to make it a nullable column | 23:01 |
| lifeless | - one patch to drop all code references to it | 23:02 |
| lifeless | - one patch to drop the column | 23:02 |
| cjohnston | by edit admin you mean https://blueprints.launchpad.net/summit/+spec/uds-q/+edit ? | 23:02 |
| lifeless | no, configure.zcml / interfaces, within blueprints | 23:11 |
| lifeless | <!-- SpecificationSubscription --> | 23:11 |
| lifeless | <class class="lp.blueprints.model.specificationsubscription.SpecificationSubscription"> | 23:11 |
| lifeless | <allow | 23:11 |
| lifeless | interface="lp.blueprints.interfaces.specificationsubscription.ISpecificationSubscription"/> | 23:11 |
| lifeless | <require | 23:11 |
| lifeless | permission="launchpad.Edit" | 23:11 |
| lifeless | set_attributes="essential"/> | 23:11 |
| lifeless | currently only requires Edit on the subscription to set it as essential | 23:11 |
| lifeless | so you'd mov that to Admin, and write an adapter to grant launchpad.Admin to someone relevant to the spec (e.g. ubuntu driver, or spec owner, or whatevers). | 23:12 |
| cjohnston | is there an example adapter I could look at? | 23:19 |
| lifeless | dozens | 23:19 |
| lifeless | IIRC they are in 'security.py' somewhere in the tree. | 23:20 |
| cjohnston | so something like http://paste.ubuntu.com/1207923/ lifeless ? | 23:30 |
| lifeless | something like | 23:31 |
| lifeless | yes | 23:31 |
| lifeless | there is zcml to register them to | 23:31 |
| cjohnston | is that the ISpecificationSubscription? | 23:34 |
| lifeless | no, grep for the name of one of the example security adapters | 23:35 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!