=== gary_poster is now known as gary_poster|away [03:55] yay [03:55] 10000 OOPS-4f236f15bf506c5061124374b4816633 Unknown [19:49] When someone gets a chance, could I please get some opinons on the wording changes in https://code.launchpad.net/~chrisjohnston/launchpad/part-essential/+merge/124559 - the reasoning why the change is being made is listed in the MP [20:17] cjohnston: please mail to the -dev list [20:18] cjohnston: irc really at the weekend isn't a good idea for getting feedback. [20:21] I know.. just posting it for if someone happens to be around and bored [20:55] lifeless: I'm not against it being removed.. I am just not sure that I'm up to snuff with the LP code to be the one to remove it.. there is a 'middle' registration level between attending and required that participation essential is getting.. if you want to remove participation essential from LP, I'm good with it.. I would just rather it happen much sooner than later [20:55] the meetings system exists solely as a/the backend for summit [20:55] if there is a mismatch, I think you should fix it [20:56] I mean, you could have made participation essential a restricted field in LP [20:56] so that only drivers could set it. [20:56] that would work for me as well... again, I am not sure how much success *I* would have with it.. :-) [20:57] LP is straight forward to develop on [20:57] there are occasional gotchyas, but that happens everywhere. The buggest hurdle I've seen folk have is just not trying at all. [22:54] or user is owner: [22:54] essential = BoolCol(notNull=True, default=False) [22:55] err [23:00] cjohnston: moving the attribute from the Edit to Admin interfaces probably [23:01] cjohnston: and dealing with any manual forms that show it specifically and should instead not [23:01] cjohnston: probably a few hundred lines of diff once you track all the bits down. [23:01] cjohnston: if you're talking about changing who can set it [23:01] cjohnston: if you're talking about removing it, thats a little more complex, needs three patches: [23:01] - one patch to make it a nullable column [23:02] - one patch to drop all code references to it [23:02] - one patch to drop the column [23:02] by edit admin you mean https://blueprints.launchpad.net/summit/+spec/uds-q/+edit ? [23:11] no, configure.zcml / interfaces, within blueprints [23:11] [23:11] [23:11] interface="lp.blueprints.interfaces.specificationsubscription.ISpecificationSubscription"/> [23:11] permission="launchpad.Edit" [23:11] set_attributes="essential"/> [23:11] currently only requires Edit on the subscription to set it as essential [23:12] so you'd mov that to Admin, and write an adapter to grant launchpad.Admin to someone relevant to the spec (e.g. ubuntu driver, or spec owner, or whatevers). [23:19] is there an example adapter I could look at? [23:19] dozens [23:20] IIRC they are in 'security.py' somewhere in the tree. [23:30] so something like http://paste.ubuntu.com/1207923/ lifeless ? [23:31] something like [23:31] yes [23:31] there is zcml to register them to [23:34] is that the ISpecificationSubscription? [23:35] no, grep for the name of one of the example security adapters