| wgrant | StevenK: So, how far through the lazr.restful source have you been? | 01:03 |
|---|---|---|
| StevenK | wgrant: I've stared at exported() for a while and it still makes little sense | 01:03 |
| wgrant | StevenK: It adds annotations. But you need to look at what interprets those annotations | 01:04 |
| === lifeless_ is now known as lifeless | ||
| StevenK | wgrant: What does the interpreting? | 01:12 |
| wgrant | StevenK: Yes | 01:13 |
| StevenK | wgrant: While talking with lifeless I've been combing lazr.restful and still coming up with no dice | 01:25 |
| wgrant | I'll look shortly | 01:26 |
| * StevenK finds another bug | 01:27 | |
| StevenK | Dear AAPT, please DIAF | 01:31 |
| StevenK | Maybe my IPv4 connectivity out of Australia will work now | 01:31 |
| StevenK | wgrant: Are you going to request a deploy of oops-tools? | 01:42 |
| wgrant | StevenK: I need to talk to lifeless about how we deploy/release/whatever oops* | 01:49 |
| lifeless | hi | 01:49 |
| lifeless | you just ask bebops to do it | 01:49 |
| lifeless | there isn't a wiki page yet. | 01:49 |
| lifeless | Perhaps there should be | 01:49 |
| wgrant | lifeless: We need to release to PyPI first, or do they deploy from branches? | 01:50 |
| wgrant | lifeless: ^^ | 01:57 |
| lifeless | they deploy from branches, but please release to PyPI | 01:57 |
| lifeless | we should split oops-tools like we did auditor | 01:58 |
| lifeless | would make that better | 01:58 |
| wgrant | Split? | 01:58 |
| wgrant | Also, I think only you have PyPI privileges | 01:58 |
| wgrant | I'm not even sure I have an account | 01:59 |
| lifeless | wgrant: also I have some oops-tools stuff pending | 02:05 |
| lifeless | adding query capturing | 02:05 |
| lifeless | wgrant: split into django site and django app, and make the site internal only | 02:05 |
| wgrant | lifeless: Ah, right | 02:07 |
| StevenK | BLEH, bug 1020439 leads straight back into lazr.restful | 02:07 |
| _mup_ | Bug #1020439: AttributeError: 'NoneType' object has no attribute 'items' in +preview-diff <code-review> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1020439 > | 02:07 |
| lifeless | james_w: hi | 02:07 |
| lifeless | wgrant: get thyself a pypi user id | 02:08 |
| lifeless | wgrant: I've added stevenk for now | 02:08 |
| lifeless | wgrant: pypi thinks there is a wgrant btw, if its not you say so asap :) | 02:09 |
| wgrant | lifeless: Ah, that is me indeed. | 02:10 |
| wgrant | I see that I own oops-tools now | 02:11 |
| wgrant | Thanks | 02:11 |
| lifeless | give me a few hours to kick the tires on this query capturing | 02:11 |
| wgrant | Sure | 02:11 |
| wgrant | I'll be very happy when you get that done :) | 02:11 |
| wgrant | lifeless: I also need oops_datedir_repo | 02:12 |
| StevenK | wgrant: So, your choice, help with security_contact, or peer at OOPS-e8d958307abcc91627fcb35e08fff15e :-) | 02:12 |
| wgrant | StevenK: My only two options involve obscure lazr.restful? You are a cruel man. | 02:12 |
| wgrant | StevenK: What have you uncovered so far? | 02:13 |
| lifeless | wgrant: whats pending there ? | 02:13 |
| wgrant | lifeless: The same fix | 02:14 |
| StevenK | wgrant: For either? That I don't understand lazr.restful much :-( | 02:14 |
| lifeless | wgrant: gimme a hint | 02:15 |
| lifeless | wgrant: 0.0.18 is published on pypi already, and there is nothing else committed to trunk for datedir-repo | 02:16 |
| lifeless | btw, I realised you can meaningfully salt anonymiseip | 02:16 |
| lifeless | Its now in my todo list to add a salt option | 02:17 |
| wgrant | Ah, good :) | 02:17 |
| wgrant | Um, I approved the datedir-repo MP, maybe tarmac hasn't noticed | 02:17 |
| wgrant | Or there is no tarmac | 02:17 |
| lifeless | there is no tarmac | 02:17 |
| wgrant | python-oops-tools has one, so I thought there might be for datedir-repo | 02:17 |
| lifeless | the README notes this, the trunk branch URL tells you as well | 02:18 |
| lifeless | the owner of the branch is launchpad-pqm for tarmaced things | 02:18 |
| wgrant | Yes, but I didn't bother to check since oops-tools worked :) | 02:18 |
| lifeless | hah | 02:18 |
| lifeless | ok | 02:18 |
| lifeless | I see | 02:18 |
| lifeless | this is the prune SNAFU | 02:18 |
| wgrant | Right | 02:19 |
| lifeless | so, do the dance to do a 0.0.19 release of datedir-repo | 02:19 |
| lifeless | no need to wait for me, and look at the commits in the log for 0.0.18 and the rev after it to see how its done. | 02:19 |
| lifeless | For bonus points, write a damn tool to do releases. | 02:19 |
| wgrant | Heh | 02:20 |
| lifeless | then you'll want to do another patch to oops-tools | 02:21 |
| wgrant | To upgrade versions.cfg, right | 02:21 |
| lifeless | to bump the datedir-repo version | 02:21 |
| lifeless | wgrant: https://code.launchpad.net/~lifeless/python-oops-tools/timeline/+merge/125086 | 02:28 |
| lifeless | wgrant: out for abit | 02:29 |
| wgrant | lifeless: k | 02:29 |
| wgrant | lifeless: Your MP seems to lack a dep on timeline_django in setup.py | 02:48 |
| james_w | hi lifeless | 03:05 |
| wgrant | StevenK: So, those two lazr.restful issues | 03:41 |
| wgrant | StevenK: I know not much more about lazr.restful than you do | 03:41 |
| StevenK | wgrant: Heh, handy | 03:41 |
| * StevenK has moved onto bug 827244 for the moment | 03:42 | |
| _mup_ | Bug #827244: bug_filters related to teams are said "mutable" when they're not <api> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/827244 > | 03:42 |
| StevenK | wgrant: I'd go back to using as_of='1.0' except I'm stubborn and don't want security_contact in devel | 03:42 |
| lifeless | wgrant: django_timeline you mean ? | 03:42 |
| wgrant | lifeless: No, timeline_django | 03:43 |
| lifeless | oh erm | 03:43 |
| * wallyworld_ had fun watching bigjools and lifeless have a public belching competition at lunch. real classy | 03:44 | |
| lifeless | wgrant: thanks | 03:44 |
| lifeless | wgrant: we thought so | 03:44 |
| lifeless | bah | 03:45 |
| lifeless | wallyworld_: ^ | 03:45 |
| StevenK | Hahaha | 03:45 |
| StevenK | wgrant: Are you handing QA for r15973? | 03:47 |
| wgrant | StevenK: You're 38 seconds late | 03:47 |
| StevenK | Oh, sorry, I was looking at doing the QA for r15972 | 03:48 |
| wgrant | A good idea | 03:48 |
| wgrant | StevenK: Hm | 03:51 |
| wgrant | StevenK: For security_contact, did you try adding a version annotation of ('devel', dict(exported=False))? | 03:51 |
| wgrant | With QA done I'm poking around the source | 03:51 |
| wgrant | And that looks plausible | 03:51 |
| lifeless | wgrant: so, I think we'll definitely find it captures stuff it shouldn't from the openid auth module for django | 03:51 |
| lifeless | wgrant: i'm not sure where to start for neutering that | 03:52 |
| wgrant | lifeless: Indeed. | 03:52 |
| StevenK | wgrant: I did not | 03:52 |
| wgrant | lifeless: Personally I think capturing parameters is generally pretty insane. | 03:52 |
| lifeless | wgrant: yes, because no one ever does manual SQL. | 03:52 |
| StevenK | wgrant: So you think "('devel', dict(exported=False)), as_of='1.0'" ? | 03:52 |
| wgrant | StevenK: I forget if you can replace as_of itself with a version annotation, but yes, that should work | 03:53 |
| wgrant | lifeless: If they do that in Django apps then I will be sad. | 03:53 |
| StevenK | wgrant: Ah ha! | 03:56 |
| wgrant | StevenK: Are you still QAing that essential sub thing? | 03:56 |
| wgrant | Looks pretty trivial | 03:56 |
| wgrant | then we can deploy | 03:56 |
| wgrant | And private teams can be less slow | 03:57 |
| StevenK | wgrant: Trying to work out how, sadly | 03:57 |
| StevenK | I can still tick essential for ubuntu blueprints | 03:57 |
| lifeless | wgrant: so, should we land it, find out the issue, file a bug and comment out the hook ? | 03:57 |
| StevenK | So I'm trying to work out what the catch is | 03:57 |
| wgrant | lifeless: I'd comment out the middleware addit | 03:58 |
| wgrant | ion | 03:58 |
| lifeless | wgrant: and then have ops uncomment it ? | 03:58 |
| wgrant | I don't know :) | 03:59 |
| lifeless | wgrant: so the middle ware isn't what captures the data | 03:59 |
| wgrant | Safety on capturing SQL statements is an unresolved issue. | 03:59 |
| wgrant | True | 03:59 |
| lifeless | wgrant: its the timeline hooks that does it. | 03:59 |
| lifeless | which is what I was suggesting commenting out to disable | 03:59 |
| wgrant | timeline_django.filters.install_hooks? | 04:00 |
| lifeless | timeline_oops | 04:00 |
| StevenK | wgrant: Right, I don't get it. | 04:00 |
| lifeless | the one you listed does sanitisation for the stock django bits. | 04:00 |
| wgrant | StevenK: The subscriber can no longer tweak the flag | 04:00 |
| wgrant | StevenK: Or isn't meant to be able to | 04:00 |
| StevenK | wgrant: I can set it when I subscribe | 04:01 |
| wgrant | StevenK: what about afterwards? | 04:01 |
| lifeless | james_w: please be doing a release of timeline_django :) | 04:01 |
| wgrant | lifeless: Which bit is it that logs SQL to the timeline, then? | 04:01 |
| StevenK | wgrant: If I hit Update subscription I get 'Not allowed here' | 04:01 |
| wgrant | timeline_django_setup? | 04:01 |
| StevenK | Which is just awesome | 04:01 |
| wgrant | StevenK: Right, so that's hideous but the logical effect of the revision | 04:02 |
| wgrant | StevenK: Even if you don't change the flag? | 04:02 |
| lifeless | wgrant: the middleware | 04:02 |
| wgrant | The revision's commit message also doesn't match its content | 04:02 |
| StevenK | wgrant: I can't even see the page to change the flag | 04:02 |
| wgrant | 13:59:21 < lifeless> wgrant: so the middle ware isn't what captures the data | 04:02 |
| lifeless | wgrant: I'm saying disable the entire timeline when there is an issue | 04:02 |
| lifeless | wgrant: the timeline isn't in the oops by default | 04:02 |
| StevenK | wgrant: I also can't unsubscribe myself from the blueprint | 04:03 |
| lifeless | wgrant: middle ware -> hooks into django and adds to timeline; timeline hooks hook timeline into the oops | 04:03 |
| wgrant | Oh, disable the timeline from being included in the OOPS, I see | 04:03 |
| wgrant | StevenK: rofl | 04:03 |
| wgrant | StevenK: Revert revert revert | 04:03 |
| wgrant | And I can't deploy my private team fix :( | 04:03 |
| wgrant | lifeless: Right, makes sense now | 04:03 |
| StevenK | wgrant: Sorry | 04:04 |
| lifeless | wgrant: so, plush one on my mp ? | 04:04 |
| wgrant | lifeless: Do we want an I_ACKNOWLEDGE_THAT_I_AM_TERRIBLY_MISGUIDED flag in settings.py to enable it, perhaps? | 04:04 |
| wgrant | lifeless: Don't we want it disabled in trunk? | 04:04 |
| wgrant | That MP still has it enabled. | 04:04 |
| james_w | lifeless, the only change is your debugging aid? | 04:07 |
| lifeless | james_w: yes, which would be very useful for oops.c.c | 04:07 |
| james_w | lifeless, you can't debug the issue locally? | 04:08 |
| lifeless | wgrant: thats right, its safe enough for folk not running custom auth crazy | 04:08 |
| lifeless | james_w: nope, can't. | 04:08 |
| james_w | lifeless, you had a reproducer though? | 04:08 |
| lifeless | james_w: can't reproduce now | 04:08 |
| lifeless | james_w: driving me batty | 04:08 |
| james_w | ok | 04:08 |
| james_w | not tonight | 04:08 |
| james_w | maybe not tomorrow | 04:08 |
| wgrant | lifeless: Is it? | 04:08 |
| wgrant | lifeless: But our auth crazy is at the Apache level anyway | 04:08 |
| lifeless | wgrant: is it ? I don't think it is. | 04:09 |
| wgrant | Oh, you mean the /admin thing, yeah | 04:09 |
| wgrant | Maybe | 04:09 |
| lifeless | james_w: cool, let someone here know - purple or me - and we'll bump the dep in oops tools at that point. | 04:09 |
| james_w | lifeless, poke me tomorrow or the next day if I haven't | 04:11 |
| james_w | we're in a bit of a crunch | 04:11 |
| lifeless | ok | 04:11 |
| wgrant | lifeless: btw, this version-locked madness is madness | 04:12 |
| StevenK | wgrant: Revert landed as r15980 | 04:12 |
| wgrant | StevenK: Thanks | 04:13 |
| StevenK | wgrant: Shall we deploy up to r15971? | 04:13 |
| wgrant | We have little choice | 04:13 |
| wgrant | StevenK: Did the security_contact thing work? | 04:13 |
| StevenK | wgrant: It worked so well I put it up for review. https://code.launchpad.net/~stevenk/launchpad/export-security_contact-for-1.0/+merge/125092 | 04:14 |
| wgrant | I got an email right as you said that | 04:14 |
| wgrant | lifeless: I have a tested datedir-repo sdist -- can I have upload privs now? | 04:14 |
| wgrant | StevenK: This doesn't sound like it will fix the proejct creation script | 04:15 |
| wgrant | StevenK: As it's RO | 04:15 |
| wgrant | Right? | 04:15 |
| lifeless | wgrant: done | 04:16 |
| StevenK | I have no idea about the project creation script, the bug only talked about exporting it | 04:16 |
| wgrant | lifeless: Thanks | 04:17 |
| wgrant | StevenK: The bug description mentions it | 04:17 |
| lifeless | wgrant: so.. +1? | 04:20 |
| StevenK | wgrant: Sure, but it doesn't say that it has to be settable | 04:21 |
| wgrant | lifeless: k | 04:21 |
| wgrant | done | 04:21 |
| wgrant | StevenK: A project creation script presumably wants to set it | 04:21 |
| wgrant | lifeless: How do I add a new release on PyPI? | 04:22 |
| StevenK | wgrant: Let's leave it for now, I'll bring it up on the call | 04:22 |
| wgrant | I try to add a new file, but it lists the 0.0.18 tar.gz, so I'm not sure if it's adding a new release or not | 04:22 |
| wgrant | I'm also slightly nauseous from uploading to a totally insecure distribution mechanism | 04:22 |
| lifeless | wgrant: so, you make the release by doing | 04:24 |
| lifeless | setup.py sdist upload -s | 04:24 |
| lifeless | wgrant: gpg signed, ~= totally insecure | 04:24 |
| wgrant | OK, all the clients are totally insecure :) | 04:24 |
| wgrant | Now how do I auth... | 04:24 |
| lifeless | cat .pypirc | 04:26 |
| lifeless | [server-login] | 04:26 |
| lifeless | username:lifeless | 04:26 |
| lifeless | password: | 04:26 |
| wgrant | Oh cool | 04:27 |
| wgrant | It defaults to basic auth over unencrypted HTTP | 04:27 |
| lifeless | yup | 04:27 |
| wgrant | And I bet if asked to do HTTPS it doesn't actually check the cert | 04:28 |
| lifeless | patches... | 04:28 |
| wgrant | Yeah, no cert verification | 04:29 |
| wgrant | Ah | 04:31 |
| wgrant | Not that it really matters | 04:31 |
| wgrant | Since you can change your password through the web UI with just a cookie | 04:31 |
| StevenK | Yeah, security is for other frameworks | 04:32 |
| wgrant | I think it's uploaded | 04:33 |
| wgrant | I might need to go outside to breathe before I refresh the page, though | 04:33 |
| wgrant | The hash even matches | 04:34 |
| ajmitch | wgrant: or just take a drink every time there's some security thing that annoys you. pretty soon you won't care at all :) | 04:35 |
| StevenK | Hahaa | 04:35 |
| wgrant | They're not security things that annoy me, they're security things that are objectively wrong :) | 04:35 |
| StevenK | ajmitch: And after using LP for 15 minutes, wgrant gets admitted to hospital for alcohol poisioning | 04:35 |
| wgrant | LP is merely less than ideal | 04:36 |
| wgrant | Other things are trainwrecks :) | 04:36 |
| StevenK | Oh damn, I looked at a branch page wrong during initial scan | 04:39 |
| lifeless | bigjools: http://www.xtranormal.com/watch/7023615/watch_movie <- kick this one off next. | 04:44 |
| StevenK | wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/mute-when-not-allowed/+merge/125094 | 04:48 |
| StevenK | wgrant: I think bug 869351 and bug 1036882 are dupes. Possibly bug 816617 too | 04:52 |
| _mup_ | Bug #869351: UnknownRecipientError on +editstatus page when setting assignee, milestone, status, and commenting <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/869351 > | 04:52 |
| _mup_ | Bug #1036882: UnknownRecipientError OOPS updating series specific tasks <bugs> <email> <oops> <subscribers> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1036882 > | 04:52 |
| _mup_ | Bug #816617: UnknownRecipientError raised sending mail notification to bug subscriber <mail> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/816617 > | 04:52 |
| wgrant | StevenK: I believe they are probably dupes, yeah, but I didn't get around to digging farn enough into them on Monday to tell for sure | 04:56 |
| wgrant | Hmk | 04:57 |
| wgrant | I thought I duped 1036882 against 869351 on monday | 04:57 |
| wgrant | But apparently not | 04:57 |
| wgrant | Ah, and the OOPSes from the older two are gone | 04:58 |
| StevenK | Yeah | 04:58 |
| StevenK | Of course | 04:59 |
| wgrant | I think my diagnosis in 1036882 can reasonably apply to the other two | 04:59 |
| * wgrant dupes | 04:59 | |
| StevenK | I was about to, but sure | 04:59 |
| wgrant | Ah right | 05:00 |
| StevenK | wgrant: Your diagnosis of "I'm not sure why there was no reason." ? :-) | 05:00 |
| wgrant | I duped 925791 | 05:00 |
| wgrant | So there were 3 duplicates | 05:00 |
| wallyworld_ | StevenK: can you put the team name in the error message and maybe word it like the message just below in the code? | 05:00 |
| wgrant | Also, does LP prefer "can not" or "cannot"? | 05:01 |
| wgrant | I suspect the latter | 05:01 |
| wallyworld_ | +1 | 05:02 |
| wgrant | wgrant@lamuella:~/launchpad/lp-branches/devel$ bzr grep '\bcan not\b' | wc -l | 05:02 |
| wgrant | 77 | 05:02 |
| wgrant | I think we have a clear winner | 05:02 |
| wgrant | wgrant@lamuella:~/launchpad/lp-branches/devel$ bzr grep '\bcannot\b' | wc -l | 05:02 |
| wgrant | 1298 | 05:02 |
| StevenK | I wish bzr grep supported -c | 05:03 |
| wgrant | Don't make me go full UNIX on you | 05:03 |
| StevenK | wallyworld_: http://pastebin.ubuntu.com/1214202/ | 05:07 |
| lifeless | wgrant: so, you're doing the oops-tools repo dep upgrade? | 05:07 |
| lifeless | wgrant: or do you want me to ? | 05:07 |
| wallyworld_ | StevenK: thanks, s/muted, team/muted because team | 05:08 |
| StevenK | wallyworld_: http://pastebin.ubuntu.com/1214207/ | 05:09 |
| wgrant | lifeless: I guess some of the other deps need upgrading too | 05:09 |
| wallyworld_ | r=me, thanks | 05:09 |
| wgrant | lifeless: Since datedir-repo is at 0.0.15... | 05:10 |
| lifeless | maybe | 05:10 |
| lifeless | you'll get conflicts if they are incompatible | 05:10 |
| lifeless | or something | 05:10 |
| lifeless | jam: whats your pypi id ? | 05:38 |
| jam | lifeless: jameinel | 05:39 |
| lifeless | jam: I'd like to apply http://paste.ubuntu.com/1214228/ to bzr-pqm and do a release on pypi. | 05:40 |
| jam | lifeless: do we actually require launchpadlib? I thought it was a nicety, but for people who might use it on Windows it brings in a huge dependency set. | 05:41 |
| jam | Otherwise +1 | 05:41 |
| lifeless | jam: it selftest fails w/out it. | 05:41 |
| lifeless | jam: I don't recall if it fails to load at all w/out it. | 05:41 |
| jam | I know I used 'bzr pqm-submit' without it for a long time | 05:41 |
| jtv | wgrant: having some problems with “bzr bd” on maas… are you familiar with it? | 05:42 |
| jam | but certainly the lp- versions of the pqm commands probably require it | 05:42 |
| jam | (lpland, etc) | 05:42 |
| wgrant | jtv: Only vaguely. | 05:42 |
| wgrant | jtv: I gather you have some people who know bzr pretty well now, so they probably know it better than I | 05:42 |
| wgrant | But I can help if you need | 05:42 |
| jam | anyway, I won't block it, and people using bzr-pqm likely have launchpadlib around, there aren't many outside of lp people using pqm anyway. | 05:42 |
| StevenK | wgrant: I also do not get why ... (re: bug 1036882) | 05:42 |
| _mup_ | Bug #1036882: UnknownRecipientError OOPS updating series specific tasks <bugs> <email> <oops> <subscribers> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1036882 > | 05:42 |
| jam | lifeless: are you asking me to apply the patches, or you need pypi access, or just a review? | 05:43 |
| wgrant | StevenK: Have you been able to reproduce it locally? | 05:43 |
| lifeless | jam: I could move it to extras, but I'm not sure there is a good way to say 'bring it in for this command' other than splitting the package. | 05:43 |
| StevenK | wgrant: No, I've been reading the code | 05:43 |
| lifeless | jam: eyeball review, since I plan to commit, push, sdist upload register etc all at aonce. | 05:43 |
| jtv | wgrant: fwiw Julian is stumped. :) A patch fails to apply, and I get the impression it should. I suspect the fact that one of the paths has a double “.orig” in it. | 05:43 |
| lifeless | jam: so, say '+1' now,a nd then you can forget about it :) | 05:43 |
| jam | lifeless: so I'm hesitant about launchpadlib, but I understand and I can live with it for your +1 | 05:43 |
| StevenK | wgrant: All of the subscriber (as in zope subscriber) and the recipient fetching code | 05:43 |
| lifeless | jam: they can't currently pip install it anyhow, as its not on pypi at all :) | 05:44 |
| wgrant | StevenK: Have you set up the scenario described in the bug locally? | 05:44 |
| jtv | wgrant: the “---” file is maas-0.1+bzr702+dfsg.orig.orig/contrib/maas_local_settings.py | 05:44 |
| lifeless | jam: which this will at least solve; can fine tune later :> | 05:44 |
| lifeless | jam: thanks | 05:44 |
| StevenK | wgrant: No, that's my next step | 05:44 |
| StevenK | wgrant: So, create a bugtask and milestone, create a structural subscriber for the milestone and +editstatus? | 05:46 |
| wgrant | StevenK: Something like that. Possibly with a target change, or assignee change, or something like that | 05:46 |
| wgrant | The full circumstances should be described in the bug | 05:46 |
| StevenK | I was going to add those in, yes. | 05:46 |
| lifeless | jam: and there - http://pypi.python.org/pypi/bzr-pqm | 05:47 |
| lifeless | done | 05:47 |
| jam | lifeless: looks good | 05:53 |
| jam | thanks for doing the work | 05:53 |
| jam | this is part of 'get rid of sourcecode' ? | 05:53 |
| jam | launchpad guys, I get initial emails when someone submits a MP to lp:maas, however, I do not get comments on all MPs. I think I subscribed to the branch, is there a config I'm missing to get the followup emails? | 05:54 |
| lifeless | jam: its part 'get rid of inventory' | 05:54 |
| lifeless | jam: and part 'make it easier to get rid of sourcecode' | 05:54 |
| jam | lifeless: 'inventory' being things that aren't properly released yet? | 05:54 |
| lifeless | jam: we either need to switch to e.g. pip (something that doesn't use separate egg dirs per thing), or we need to teach bzrlib how to load plugins from eggs. | 05:55 |
| lifeless | jam: yup | 05:55 |
| lifeless | jam: 'fix committed' status | 05:55 |
| lifeless | jam: I mailed the list about the issue | 05:55 |
| jam | lifeless: 'pip install -Z' doesn't build a .zip/.egg file, I believe. Can't you set the 'not zip safe' flag somewhere in setup.py? | 05:56 |
| lifeless | jam: EPARSE | 05:56 |
| lifeless | jam: pip doesn't use egg directories at all, it installs into site-packages. | 05:57 |
| jam | lifeless: sorry, "easy_install -Z" then. The thing that creates eggs can do it by just updating .pth and then putting the files expanded on disk. | 05:57 |
| lifeless | ok, gotta run, taxi here. | 05:57 |
| jam | I used to have to do that for paramiko | 05:57 |
| jam | because otherwise py2exe couldn't bundle it. | 05:57 |
| jam | lifeless: catch you later. | 05:58 |
| jtv | wgrant: this “bzr bd” problem with maas is really bugging us. A patch fails to apply to a missing file, except the missing file seems to be in the branch as before. | 06:16 |
| jtv | An invocation of “dh get-orig-source” seems to be part of the problem. There seems to be no such command in dh. | 06:17 |
| StevenK | I strongly doubt it's dh | 06:18 |
| StevenK | dh is a debhelper wrapper | 06:18 |
| wgrant | Are you perhaps trying to use get-orig-source in a package that doesn't support get-orig-source? | 06:18 |
| wgrant | bzr bd is after my time, anyway | 06:19 |
| jtv | How would I tell whether the package supported it? There is a target of that name in debian/rules though. | 06:20 |
| wgrant | That is roughly the definition of supporting it. | 06:20 |
| StevenK | wgrant: http://pastebin.ubuntu.com/1214252/ and no failure :-( | 06:20 |
| wgrant | Not sure why it would be trying to call into dh | 06:20 |
| bigjools | the problem is when quilt is applying the patches | 06:20 |
| bigjools | beyind that I dunno | 06:20 |
| jtv | It doesn't find the file it's supposed to be patching. To be honest, I can't find it either. It's in the .orig tarball, but I don't see it unpacked anywhere. | 06:21 |
| StevenK | Is it deleted by the .diff.gz applying? | 06:23 |
| wgrant | maas hopefully doesn't have a diff.gz | 06:24 |
| StevenK | Or an .orig then | 06:24 |
| StevenK | It's just .tar.gz for native | 06:25 |
| jtv | How would I check these things? I see no files with any of those names in the packaging branch, fwiw. | 06:26 |
| wgrant | StevenK: I was alluding to the fact it is probably 3.0 (quilt), which cannot delete files from the orig.tar.gz | 06:26 |
| StevenK | Ah, I've been ignoring 3.0 (quilt) for being a crime against humanity | 06:26 |
| StevenK | wgrant: Ah ha, my save against BugTask:+editstatus doesn't hit the zope subscriber stuff | 06:27 |
| jtv | Well the file that's being patched is still in the .orig.tar.gz. | 06:29 |
| jtv | wgrant: I guess it's normal that, after the failed build, the build-area directory contains the .orig.tar.gz and the packaging branch, but not the contents of the .orig.tar.gz in unpacked form? | 06:34 |
| wgrant | jtv: I'm really not sure, sorry | 06:34 |
| jtv | Any idea who might know, that's available at this hour? | 06:34 |
| StevenK | wgrant: Hm, I thought passing form=foo to create_initialized_view() would call the save_action | 06:37 |
| wgrant | StevenK: Perhaps your action name is bad | 06:38 |
| wgrant | StevenK: Does the form appear to submit? | 06:38 |
| wgrant | jtv: Perhaps former bzr people may know | 06:38 |
| StevenK | Ah ha, view.errors | 06:38 |
| jtv | wgrant: thanks, I think I'll be able to dig some up soon! | 06:39 |
| StevenK | wgrant: The form submits, zope subscriber stuff fires, no error | 06:51 |
| wgrant | StevenK: Have you tried manually setting up the scenario on launchpad.dev? | 06:53 |
| wgrant | You could just have a bad test | 06:53 |
| StevenK | wgrant: http://pastebin.ubuntu.com/1214277/ | 06:54 |
| wgrant | StevenK: I can't always solve all your problems just by looking at a test of a strange view, sadly | 07:07 |
| wgrant | StevenK: Try it in a browser | 07:08 |
| StevenK | wgrant: I am doing so | 07:08 |
| StevenK | Trying to remember how to add a series task | 07:08 |
| wgrant | Target | 07:09 |
| StevenK | Don't I have to nominate? It's been so long since I've had to do stuff like this. | 07:10 |
| wgrant | Not if you're the driver | 07:10 |
| StevenK | Which I'm not | 07:11 |
| StevenK | Let me fix that | 07:11 |
| StevenK | wgrant: No OOPS | 07:13 |
| wgrant | You won't even see the link if you're not one of maintainer/driver/bugsupervisor | 07:13 |
| wgrant | Hmm | 07:13 |
| StevenK | I have a product, which I'm driving, a series, a milestone and a structsub for a random on the milestone | 07:13 |
| wgrant | StevenK: Do you have an appropriate event filter? | 07:15 |
| wgrant | StevenK: The problematic subscription on production was open/close only | 07:15 |
| StevenK | That isn't the default? | 07:15 |
| wgrant | StevenK: Not through the API, probably. | 07:17 |
| wgrant | Or through the method you called in the test | 07:17 |
| StevenK | Right, I'll check the filter | 07:18 |
| StevenK | Hm, how do I even express that as a filter? :-( | 07:21 |
| wgrant | StevenK: It's one of the root settings for the subscription | 07:23 |
| wgrant | StevenK: So it's not shown as a filter in the web UI | 07:24 |
| wgrant | It's one of the initial radio buttons | 07:24 |
| lifeless | jam: so yes, sourcecode/ | 07:26 |
| StevenK | Right, structsub edited | 07:28 |
| lifeless | jam: I can look into the zip unsafe flag if needed, but whats unsafe about bzr-pqm? Is it that 'bzr cannot load it from a zip' ? | 07:28 |
| jam | lifeless: right | 07:28 |
| jam | some other tool doesn't work properly with zip | 07:28 |
| jam | I think it also is needed for things that create extension modules. | 07:28 |
| jam | but I just defaulted to using it because py2exe doesn't work with eggs either. | 07:29 |
| StevenK | wgrant: Also no OOPS | 07:29 |
| wgrant | StevenK: :( | 07:29 |
| lifeless | jam: http://svn.python.org/projects/sandbox/trunk/setuptools/doc/formats.txt | 07:31 |
| lifeless | ``zip-safe`` and ``not-zip-safe`` | 07:31 |
| lifeless | ... | 07:31 |
| lifeless | --------------------------------- | 07:31 |
| lifeless | If neither file is present at installation time, EasyInstall defaults | 07:31 |
| lifeless | to assuming that the project should be unzipped. (Command-line options | 07:31 |
| lifeless | jam: it will still be unpacked to a .egg directory | 07:31 |
| lifeless | jam: which won't let bzr import it | 07:31 |
| jam | lifeless: if easy_install updates the .pth appropriately, I think it still works. | 07:31 |
| lifeless | jam: nope | 07:32 |
| jam | I'm not sure about path issues and easy_install, though. It gets a bit confusing with namespaces. | 07:32 |
| lifeless | jam: because we scan for plugins ourselves. | 07:32 |
| lifeless | jam: we need a custom path aware - including egg/pth - plugin loader, or we need to use pip for launchpad | 07:33 |
| jam | ah sure. I wonder if we could play games with bzrlib.plugin.__path__ | 07:33 |
| jam | or play games with BZR_PLUGIN_PATH | 07:33 |
| lifeless | syncing that with PYTHONPATH via heuristics makes me shudder | 07:33 |
| lifeless | jam: bzrlib.plugins.__path__ is set when set_plugins_path is called | 07:34 |
| lifeless | from get_standard_plugins_path | 07:34 |
| lifeless | and we nuke the default path entirely. | 07:35 |
| === almaisan-away is now known as al-maisan | ||
| jam | lifeless: and tbh I'm not really sure how sys.path interacts with bzrlib.plugin.__path__ and all that stuff. Namespaces were supposed to help with this, but it was never something we tried to do for bzr itself. | 07:36 |
| jam | btw, I didn't see an email about it | 07:36 |
| jam | or maybe it was in a thread I missed? | 07:36 |
| lifeless | haven't sent one | 07:37 |
| lifeless | I side tracked slightly onto that from reviewing bugs.l.n/~lifeless/?status=FIXCOMMITTED | 07:37 |
| jam | (9:55:23 AM) lifeless: jam: I mailed the list about the issue | 07:37 |
| jam | hence my confusion | 07:38 |
| jam | but np | 07:38 |
| wgrant | StevenK: Reproduces easily for me | 07:38 |
| wgrant | UnknownRecipientError: <Person at 0xf853a4c no-priv (No Privileges Person)><br /> | 07:39 |
| StevenK | wgrant: Holy crap | 07:39 |
| StevenK | wgrant: Nice work | 07:39 |
| lifeless | jam: about the fixcommitted issue :) | 07:39 |
| lifeless | jam: a week or so back | 07:39 |
| wgrant | StevenK: From a fresh dev DB, I created a new milestone hoary-updates. As no-priv I subscribed to it with default settings. Then, as name16 I went to https://bugs.launchpad.dev/ubuntu/hoary/+bug/2/+editstatus, set In Progress/High/name16/hoary-updates with a comment, then saved | 07:40 |
| lifeless | jam: apologies for adding confusion | 07:40 |
| wgrant | StevenK: Not sure how many of those details are actually necessary. I was just duplicating the changes from the OOPS before trying to minimise the test case | 07:40 |
| StevenK | wgrant: Ooooh, I've been doing it against products, not distros. That is probably very related ... | 07:40 |
| wgrant | StevenK: Potentially | 07:40 |
| lifeless | stub1: hi, around ? | 07:41 |
| stub1 | lifeless: yup | 07:41 |
| StevenK | wgrant: Are you going to keep digging, or shall I take your notes and dig in tomorrow? | 07:41 |
| lifeless | stub1: time for a brief catchup? | 07:41 |
| stub1 | lifeless: ok. I'll find my mike | 07:42 |
| adeuring | good morning | 07:42 |
| lifeless | adeuring: o/ | 07:42 |
| adeuring | hi lifeless! | 07:43 |
| wgrant | StevenK: Ahaa | 07:43 |
| wgrant | StevenK: It's the combination of milestoning and assigning to Me | 07:44 |
| lifeless | allenap: bug 847889 needs a release done. | 07:44 |
| _mup_ | Bug #847889: RabbitServerResources.tearDown is never called <rabbitfixture:Fix Committed by allenap> < https://launchpad.net/bugs/847889 > | 07:44 |
| lifeless | allenap: as you did the work, care to do the release too ? | 07:44 |
| wgrant | StevenK: that should let you fix the test | 07:44 |
| wgrant | StevenK: It probably works on products too | 07:44 |
| wgrant | StevenK: That's like two lines of diff -- can you try that now? | 07:44 |
| StevenK | wgrant: Hmm. No failure for me :-( | 07:49 |
| wgrant | StevenK: It doesn't actually have to be assigning Me, it can be any user | 07:49 |
| wgrant | But I suspect what's happening is that it's doing the assignee change first | 07:49 |
| wgrant | Which causes the recipients to be calculated | 07:49 |
| wgrant | And cached | 07:49 |
| wgrant | Then the milestone is changed, and it adds a new recipient | 07:50 |
| wgrant | But something's still cached | 07:50 |
| wgrant | So the recipient has no reason | 07:50 |
| StevenK | wgrant: I'm adding a series task, and then passing in form data with the milestone and assignee, and I don't get an OOPS | 07:51 |
| wgrant | StevenK: Can you pastebin the latest test? | 07:52 |
| StevenK | wgrant: http://pastebin.ubuntu.com/1214353/ | 07:53 |
| wgrant | StevenK: That's quite possibly erroring because there are mandatory fields missing | 07:54 |
| === stub1 is now known as stub | ||
| StevenK | wgrant: view.errors == [] | 07:55 |
| wgrant | StevenK: Reproduced on a fresh product with no series task and just setting assignee+milestone. But the subscription needs to be open/close only | 07:57 |
| lifeless | -> plane | 08:00 |
| mpt | sinzui, why did you tag bug 1052364 as "private-projects"? | 08:24 |
| _mup_ | Bug #1052364: Blueprint icons aren't as distinct as they could be <lp-blueprints> <private-projects> <ui> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1052364 > | 08:24 |
| czajkowski | mpt: there is work going on with them atm possibly | 08:26 |
| wgrant | It's unrelated | 08:27 |
| * wgrant untags | 08:27 | |
| wgrant | He did that in a batch of other taggings | 08:27 |
| StevenK | wgrant: Ah ha, so now the question remains of how to do that in a test. | 08:30 |
| StevenK | wgrant: I thought open/close was LIFECYCLE? | 08:36 |
| wgrant | StevenK: I think so | 08:38 |
| wgrant | But don't quite me on that unless you check the code first | 08:39 |
| StevenK | wgrant: If so, no error for me | 08:39 |
| wgrant | StevenK: In the test or web UI? | 08:39 |
| StevenK | The test | 08:39 |
| wgrant | Give me your latest version and I'll fix it | 08:39 |
| wgrant | Now I have a minimal case | 08:40 |
| StevenK | I swear I'm close. :-( | 08:40 |
| StevenK | wgrant: http://pastebin.ubuntu.com/1214400/ | 08:40 |
| wgrant | StevenK: Kill off the series | 08:41 |
| wgrant | No need for that | 08:41 |
| wgrant | Otherwise that looks pretty reasonable... | 08:41 |
| StevenK | wgrant: Done, but no evil traceback. I didn't think I needed to call render() or anything? | 08:43 |
| === dpm_ is now known as dpm | ||
| === al-maisan is now known as almaisan-away | ||
| === matsubara-afk is now known as matsubara | ||
| === almaisan-away is now known as al-maisan | ||
| === beuno_ is now known as beuno | ||
| === Guest70664 is now known as slank | ||
| === slank is now known as Guest79513 | ||
| === al-maisan is now known as almaisan-away | ||
| cjohnston | sinzui: ping | 14:28 |
| === abentley changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: abentley | Firefighting: - | Critical bugs: ∞ | ||
| sinzui | hi cjohnston | 14:29 |
| cjohnston | hey there.. did you see the comment about the participation essential stuff breaking unsubscribing/editing subscription? | 14:30 |
| sinzui | No | 14:32 |
| cjohnston | https://bugs.launchpad.net/launchpad/+bug/1052130 | 14:34 |
| _mup_ | Bug #1052130: Make assigning participation essential limited to certain groups of users <bad-commit-15972> <lp-blueprints> <qa-bad> <Launchpad itself:Fix Committed by chrisjohnston> < https://launchpad.net/bugs/1052130 > | 14:34 |
| sinzui | cjohnston, The branch will need to be rolled back. Another branch is needs that extends your branch and fixes the javascript | 14:34 |
| sinzui | I think there are two uses of the permission, but the zcml shows only one. | 14:35 |
| sinzui | cjohnston, We want to restore the launchapd.edit method so users can edit their subscriptions. We want the essential flag to be launchpad.Drive | 14:37 |
| sinzui | or we consider removing essential from Launchpad | 14:37 |
| cr3 | launchpadlib doesn't seem to be ported to python3 yet, any plans? | 14:40 |
| sinzui | no. barry abandoned it I think because the deps chain was hard | 14:42 |
| sinzui | I think there is some bad mojo in the gnome key/auth code that is ancient python | 14:43 |
| cjohnston | sinzui: I don't know what the response will be about removing it from LP.. personally, I'm not against it, though I really don't have time/ability to do the work since it needs to be done asap | 14:43 |
| sinzui | cjohnston, essential is used by many non-ubuntu projects. http://pastebin.ubuntu.com/1214916/ | 14:45 |
| sinzui | I will revert the branch now | 14:45 |
| czajkowski | wow | 14:45 |
| cjohnston | well, all of the LPC stuff is Summit too... so that could be considered mine for a lack of a better term.. I am curious though (and this is why I sent the email asking) what they use it for | 14:46 |
| sinzui | great | 14:46 |
| cjohnston | but the only feedback I got was that it is for Summit... there really isn't anything else (unless a group specifically has a use for) that it's used for | 14:47 |
| cjohnston | i.e. it doesn't really do anything in LP other than change the icon color | 14:48 |
| sinzui | cjohnston, StevenK already landed a branch to revert the change | 14:48 |
| cjohnston | ok | 14:49 |
| cjohnston | sinzui: so does this mean we can't even remove it since others are using it? | 14:50 |
| cjohnston | I mean, if you look at the 'help text' its pretty clear as to what it's for | 14:50 |
| sinzui | We would need to ask if they really need it. | 14:50 |
| sinzui | regardless, a branch to remove it has to change the javascript that was broken by your branch | 14:51 |
| cjohnston | So what it the best approach then for now to get my point across? go back to the text change? | 14:53 |
| sinzui | yes | 14:53 |
| cjohnston | then lifeless is going to leave me his comment again ;-) heh | 14:53 |
| sinzui | That is also true for Non-ubuntu brojects | 14:54 |
| abentley | rick_h_: I'm trying to make the change you wanted: http://pastebin.ubuntu.com/1215019/ But it says "yui: NOT loaded: function (Y) { | 15:42 |
| abentley | var tests = Y.namespace("lp.blueprints.addspec.test");" which looks wrong: http://pastebin.ubuntu.com/1215023/ | 15:42 |
| rick_h_ | abentley: looking | 15:50 |
| rick_h_ | abentley: sorry, missed that you hadn't created a module in the test file. Was more change than I originally thought. https://pastebin.canonical.com/74807/ | 16:03 |
| rick_h_ | abentley: and the comment in the requires array breaks the meta.js parser for the combo loader so moved it up. | 16:04 |
| rick_h_ | I've got a branch that uses an ast vs regex to parse into convoy, but never got the ok on it. | 16:04 |
| === matsubara is now known as matsubara-lunch | ||
| abentley | rick_h_: So this patch is meant as an alternative to my patch? | 16:06 |
| rick_h_ | abentley: yes, sorry I had pulled your branch down earlier to prep for my rename of registry/app stuff | 16:06 |
| rick_h_ | abentley: so this is a patch against what you had pushed up for review this morning | 16:06 |
| abentley | rick_h_: Okay, thanks. | 16:06 |
| rick_h_ | abentley: np, thanks for looking at the update | 16:07 |
| abentley | rick_h_: Are you landing move_into_utils right now? | 16:13 |
| rick_h_ | abentley: no, I've marked your branch as a pre-req and I'm waiting on your branch first | 16:13 |
| abentley | rick_h_: Okay, I'm going ahead then. | 16:14 |
| rick_h_ | abentley: cool, thanks | 16:14 |
| jcsackett | sinzui: you available to chat a bit? | 16:57 |
| sinzui | I am | 16:57 |
| * sinzui looks for headphones | 16:57 | |
| * jcsackett fires up g+ | 16:57 | |
| jcsackett | sinzui: hangout sent, whenever you're ready. | 16:58 |
| jcsackett | sinzui: bug 612387 | 17:00 |
| _mup_ | Bug #612387: Breadcrumb from PersonProduct active reviews page gives 404 <404> <lp-code> <Launchpad itself:Triaged> < https://launchpad.net/bugs/612387 > | 17:00 |
| === deryck is now known as deryck[lunch] | ||
| sinzui | jcsackett, https://bugs.launchpad.net/gdp/packaging | 17:05 |
| === matsubara-lunch is now known as matsubara | ||
| sinzui | https://bugs.launchpad.net/launchpad/+bug/573779 | 17:11 |
| _mup_ | Bug #573779: Site header does not accurately represent section <breadcrumbs> <lp-web> <Launchpad itself:Triaged> < https://launchpad.net/bugs/573779 > | 17:11 |
| === deryck[lunch] is now known as deryck | ||
| === matsubara is now known as matsubara-afk | ||
| === matsubara-afk is now known as matsubara | ||
| === abentley changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: ∞ | ||
| abentley | deryck: Please tell me this isn't doing what I think it's doing: http://pastebin.ubuntu.com/1215660/ | 21:07 |
| === Guest79513 is now known as slank | ||
| deryck | abentley, sorry, I had stepped away, looking now.... | 21:48 |
| abentley | deryck: It's more of an, "oh, god, blueprints are ugly" statement than a real question. | 21:50 |
| deryck | abentley, yeah, it's kind of off code. | 21:51 |
| deryck | odd, I meant | 21:51 |
| abentley | deryck: Yeah. Not generally a good idea to re-implement SELECT :-) | 21:52 |
| deryck | ha! yeah. | 21:53 |
| deryck | in a python loop no less. :) | 21:53 |
| jcsackett | sinzui: standup? | 22:07 |
| sinzui | jcsackett, sorry, will be there in a few minutes | 22:07 |
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!