[00:01] robert_ancell: apparently some details are in https://bugzilla.gnome.org/show_bug.cgi?id=684311 [00:01] Gnome bug 684311 in HighContrast and LowContrast "Please restore HighContrastInverse & LowContrast themes for 3.6" [Major,Resolved: wontfix] [00:05] sarnold, thanks === lifeless_ is now known as lifeless [01:48] alex-abreu: so what would the Amazon launcher even do? load amazon.com? [01:50] I have to admit I haven't tested the webapps stuff yet as I was waiting for it to show up in the normal repositories [02:06] jbicha: open amazon and give a direct access to the amazon webapp [02:09] why does the Design Team think we need a direct link to amazon.com on the default Ubuntu desktop? [02:10] no offense, but it sounds ridiculous to me [02:12] no offense taken, there was some discussions over it and that's what was decided as part of the default apps exposed to the user === alex-abreu is now known as alex-abreu|afk [03:59] smspillaz: I eventually went for brz3377 snapshot... [03:59] after duflu seemed to be ready to tag it 0.9.8.4 anyway :) [04:34] Good morning [04:50] seiflotfy, hey [04:55] seiflotfy, had a question about gnome-clocks crashing creating a TimeZone object, does it need a particular version of glib/g-i? [04:57] robert_ancell: yeah, it needs the new glib, I think this commit http://git.gnome.org/browse/glib/commit/?id=02f143c2d9fa [04:57] jbicha, ah, that's what I'm looking for [04:58] jbicha, did you intentionally not update? [04:58] I figure we should just upload since that glib will be coming anyway [04:58] robert_ancell: no, we shouldn't intentionally upload something that would be broken [04:59] I mean it probably has all of 6 users so far, but still [04:59] jbicha, well, it might risk missing a freeze otherwise [04:59] better to get it in earlier than later [05:00] I consider it a bugfix release [05:01] I would have just uploaded if the new version actually ran :) [05:02] jbicha, can you open bugs if you investigate an update bug it is blocked? I've opened bug 1052759 [05:02] Launchpad bug 1052759 in gnome-clocks "Update to 0.1.2" [Wishlist,Triaged] https://launchpad.net/bugs/1052759 [05:03] but is blocked that should say [05:03] ok, nautilus 3.5.92 in the ppa is waiting on the new glib too [05:03] jbicha, good, because I was about to look at that one [05:04] pitti: did you want to upload glib2.0 or are you swamped with Beta2Freeze? [05:04] hey jbicha [05:05] nobody asked me about it yet; I'm not exactly twiddling thumbs, but if nobody else can do it, I can have a look [05:05] pitti, also, is there a reason why we're pushing all the glib changes through debian? It's slowing everything down [05:05] robert_ancell: mostly to avoid building up a delta and having to merge again, and a courtesy to Debian [05:06] but we did have several Ubuntu specific uploads [05:06] I'm happy to upload straight to Ubuntu but I haven't been because of this sync. But it's slowed me down a number of times when it would just be updated in an hour after release [05:06] I just regularly merge them back [05:06] it's not "forbidden" to upload to Ubuntu [05:06] ok, will do that in the future [05:06] but it's causing more work in sum [05:07] (not terribly much, though) [05:08] robert_ancell: so if you can update glib, I'm happy to commit the diff to Debian after the upload; sounds ok? [05:08] pitti, yeah, but this is not a zero sum game so the bigger issue is the additional time lost to us compared to us updating it faster with everything else [05:08] pitti, sure [05:21] good morning [05:22] Mirv kk [05:22] bonjour didrocks [05:23] guten morgen pitti [05:27] didrocks, good morning! [05:27] hey larsu [05:29] didrocks, you'll do the gtk update? If so, the menu item patch doesn't apply anymore. I have attached a new one on bug #1039476 [05:29] Launchpad bug 1039476 in gtk+3.0 "gtk_menu_new_from_model doesn't support custom menu items" [Wishlist,In progress] https://launchpad.net/bugs/1039476 [05:33] larsu: ah, excellent, thanks a lot :) [05:33] you subscribed me to the bug, so should be fine! :-) [05:34] just wanted to make sure you're not doing the update before reading email ;) [05:34] didrocks, more importantly: I looked into porting indicator-evolution, but there's two problems: [05:34] (1) it's installing into the 3.4 plugin directory instead of the 3.6 one [05:35] (2) it's showing notification bubbles in addition to the messaging menu stuff, why? (there's a separate libnotify plugin already) [05:39] larsu: no, I'm digging on a big stack of emails to answers first TBH :) [05:40] larsu: I think (2) is not a regression [05:40] larsu: and it's like thunderbird [05:40] I agree it's not logicial [05:40] logical* [05:40] but it's the way design wanted it [05:40] design? Because they wanted different notifications from the ones in the other plugin? [05:41] (3) it doesn't build :( [05:45] larsu: (3) is because of the API change, right? [05:45] didrocks, no, "unknown type name 'GConfClient'" [05:45] ah, still using gconf :/ [05:46] should still build though, right? [05:46] Yeah, and then crash (unless it calls dbus_threads_init_default()) [05:47] larsu: I guess e-d-s was including gconf and configuring it for you, no? [05:47] larsu: if that's too much work, we can declare evolution-indicator dead and remove it [05:48] didrocks, yeah, I'd be fine porting it to libmessaging-menu, but I don't have time for porting it to 3.6 and gsettings (especially since I know nothing about evolution internals) [05:49] hm, including gconf-client.h directly works [05:50] I'm not joking about calling dbus_threads_init_default; if you use gconf and don't call that, you're going to get awkward memory corruption crashes in libdbus. [05:51] larsu: ok, let's remove it then [05:51] didrocks, alright, sorry :-/ [05:53] no worry larsu :) [05:53] cyphermox: FYI ^ So apart if you feel you have the time to port, we will drop evolution-indicator [06:01] larsu: catching up on email, seems robert_ancell did already the update [06:02] didrocks, interesting. Let me check how he resolved the issue with the patch [06:02] larsu: weird, he didn't, he just removed a patch [06:03] but it doesn't seem to be yours, right? [06:03] didrocks, no it's not, that one had to be removed [06:04] larsu: he didn't touch your patch at all [06:05] larsu: I have no diff [06:05] didrocks, do your tools error out when a patch can't be applied? [06:05] yep [06:06] larsu: look at your diff: http://paste.ubuntu.com/1214242/ [06:06] with the version in the package [06:06] http://bazaar.launchpad.net/~ubuntu-desktop/gtk/ubuntugtk3/revision/225#debian/patches/ubuntu_gtk_custom_menu_items.patch [06:06] that shows it, he updated it [06:06] grrrr, and yeah for listing things in the changelog :/ [06:07] * larsu feels for didrocks [06:07] larsu: thanks nevertheless and sorry you worked for nothing :) [06:07] let's close the bug [06:07] didrocks, I did it anyway in my jhbuild, I just wanted to save you guys some trouble [06:07] so no harm [06:07] larsu: thanks for noticing and pinging us :) [06:09] didrocks, just trying to get PS a better reputation around here :) [06:09] * larsu has a feeling it's a lost cause, though [06:09] larsu: you are on of the few! :-) [06:09] hehe [06:09] one* === Zdra is now known as xclaesse [07:35] didrocks, indicator-messages 12.10.3 is out. Wow, 1.5 days before a freeze, that's a new record! ;) [07:36] larsu: let's turn that this way: 1.5days in advance to the rest of PS team! Well done :) [07:36] larsu: updating now :) [07:36] thanks! [07:45] larsu: "oh, an updated NEWS file" [07:45] * didrocks gives a bonus point to larsu [07:46] awesome! I collect bonus points ;) [07:46] didrocks, shouldn't all bugs that are mentioned in the milestone be marked as fix released? Do I have to do that manually? [07:46] https://launchpad.net/indicator-messages/12.10/12.10.3 [07:46] larsu: for upstream ones, yes, for the package one, they will get closed automatically when I upload the package [07:47] :'( [07:47] larsu: yeah, closing the milestone should close them, I agree [07:47] larsu: basically, I have a script doing that for unity, maybe we should make it less unity-related and share it [07:47] larsu: all fix committed are -> fix released [07:47] the others are set to the next milestone [07:48] didrocks, that sounds exactly like what I need [07:48] larsu: let's figure that out for next release and after the beta freeze crazyness :) [07:48] didrocks, yeah no hurry [07:48] I'm half done anyway ;) [08:04] hey ho [08:11] TheMuso: hey, did you consider dropping the g-c-c recommends from mousetweak instead of dropping mousetweak from onboard? [08:13] good morning everyone [08:17] larsu: hey [08:17] didrocks, ya? [08:17] larsu: I have a different icon on the messaging menu and power indicator [08:17] larsu: isn't because of the gtk patch drop? [08:17] hey chrisccoulson :) [08:17] hi didrocks, how are you? [08:18] didrocks, power indicator is because of the dropped patch. What's the new icon on the messaging indicator? [08:18] larsu: screenshoting [08:18] chrisccoulson: busy busy, yourself? [08:21] didrocks, I fixed the battery icons in ubuntu-mono, but charles didn't like my patch and I must have overlooked his reply. Fixing it now [08:21] larsu: http://people.canonical.com/~didrocks/indicator-icons.png [08:21] larsu: sweet :) [08:21] didrocks, yeah, messaging menu now shows online status in the panel [08:21] the X means offline [08:22] larsu: ok, the icon looks weird, but well :) [08:22] larsu: you had an UIFe accepeted, right? [08:22] didrocks, I totally agree. Take it up with mpt ;) [08:22] didrocks, yeah, pretty busy [08:22] didrocks, yes [08:22] (uife) [08:22] larsu: excellent! uploading then :) [08:23] \o/ [08:23] larsu: tell me for ubuntu-mono once ready [08:24] didrocks, yep [08:33] didrocks: I turn off icons on my desktop to prevent accidental leaks ;-) [08:35] xnox: :) [08:37] didrocks, who maintains ubuntu-mono? [08:37] I wonder if I can just delete the battery icons that we're not using [08:38] also, we have the 000,020,040,060,080,100 charge statuses in ubuntu-mono, but we only need empty,low,good,full [08:38] I wonder which ones should be mapped to which [08:38] low == 020 or 040? good == 060 or 080? [08:42] larsu: I'm deep in unity issues TBH, so if we can keep the delta of changes low :) [08:43] larsu: it was design before who maintained it [08:43] but nobody anymore [08:43] larsu: maybe ask mpt for icon mapping? [08:43] didrocks, great :-/ I'll figure something out [08:44] larsu, ideally I'd prefer the fill to be to the nearest pixel :-) [08:45] mpt, we have icons that support 20% steps (which is probably close enough to nearest pixel for the panel), but they aren't used [08:45] larsu, can you fix g-p-m so that they are? [08:46] mpt, yeah, of course [08:47] larsu, what would be other ways of fixing it? [08:47] mpt, change the icon names so that we only use the 4 levels [08:47] mpt, but you already convinced me [08:48] mpt, the only problem will be upstream, which probably won't like our approach because they are using the empty,low,good,full scale [08:49] and we need a quick fix for beta2 to make the panel pull at least the icons from ubuntu-mono, but that's not a big deal === doko_ is now known as doko [08:54] pitti, would it be possible to have a look at the libsocialweb build failure? looks like an gobject incompatibility === dpm_ is now known as dpm === tkamppeter_ is now known as tkamppeter [09:41] Mirv: hey, just looking at bug #1052068 [09:41] Launchpad bug 1052068 in unity-scope-video-remote "[UIFe/FFe] Addition of Amazon details to the video preview" [Medium,New] https://launchpad.net/bugs/1052068 [09:41] do we have Amazon video results currently? [09:41] I can't seem to get the video lens to give me them if so [09:41] Laney, only for US users [09:42] Laney, the search backend does geo IP [09:42] oh, right [09:42] do british get Daily Mail reviews of the top YouTube video? =) [09:43] xnox, cool idea :) [09:43] davidcalle: is this new in Q? [09:44] I assume it sends search strings to an Ubuntu server? [09:45] Laney, results are not new, but details for the video are. Yes, it's videosearch.ubuntu.com [09:45] interesting [09:45] do you consider that users might want to disable that? [09:46] Laney, that's whay it's in a separate package and not in unity-lens-video, assuming, that users caring about *.ubuntu.com calls are able to remove a package. [09:48] Laney, you can also select the sources of the Lens in the filter and only have local files. [09:48] davidcalle: alright, that makes sense [09:49] Laney, by the way, do you want a screenshot or something of this specific previews? I can tweak the requests to get US results . [09:49] I wonder why I don't see video results on the home lens (is that the right terminology?) [09:50] davidcalle: it would be nice in future, but not required now [09:50] Laney, it is, and you will only see local results in the home, as you don't want anything you type in the home dash to be sent to servers. [09:50] davidcalle: Good. That's what I was hoping for [09:51] OK, thank you, I'm going to approve it [09:53] done [09:53] Laney, thank you [09:54] np [09:54] it has sharpened my thoughts around another FFe ;-) [09:55] didrocks, I have a merge request for ubuntu-mono up, but please wait for charles to confirm that these are indeed correct ;) [09:55] * larsu hates bulk renaming icons [09:57] mpt, the icon for "battery is empty" is the same as for "battery is missing". That's surely not the way it was intended, is it? [09:57] larsu, nope [09:58] mpt, who do I need to assign in lp to get an icon drawn? [09:58] larsu: does this fix the full battery while on mains power icon? [09:58] "There should also be (1) a generic battery icon, for use when a battery has been removed or when its charge level has not yet been determined." [09:59] larsu, ~jnick-tait [09:59] Laney, that's a indicator-power bug, the icon for battery-full and battery-full-charging are correct [10:00] mpt, thanks [10:00] k [10:02] Laney, is there a bug number already? Otherwise I'll file one, it's an easy fix [10:03] larsu: probably https://bugs.launchpad.net/ubuntu/+source/indicator-power/+bug/1048041 [10:03] Launchpad bug 1048041 in indicator-power "Power icon doesn't show it is charging when it's plugged in" [Undecided,Confirmed] [10:03] but I thought there was a better one with some discussion [10:04] hi [10:04] Laney, oh I misunderstood you then. This has been working for me for a while now... [10:04] I'll ping charles about it [10:04] there's a 1-click feature to setup PPAs, right? [10:04] if so, where can I find information? [10:04] I see a "full battery" icon, but no lightning bolt thingy [10:04] Laney, in quantal? [10:04] yeah [10:05] if you think it might have been fixed recently, I haven't restarted my session in a while [10:05] no it has been working for a couple of months for me [10:05] I'll assign charles, he wrote that code [10:05] ack [10:14] doko: can do, yes [10:56] glatzor, mvo: hey, how are you/ [10:57] glatzor, mvo: it seems bug 1042231 is an incompatibility with the PK API -- while PK's is said to be synchronous, sessioninstaller's is async [10:57] Launchpad bug 1042231 in sessioninstaller "InstallPackageNames should not return until the package has been installed" [Undecided,New] https://launchpad.net/bugs/1042231 [10:57] glatzor, mvo: would it be okay to make InstallPackageNames() and similar methods wait until completion, or would that break something else? [10:57] pitti, mvo: so, I seem to recall there was a 1-click way of setting up PPAs, but googling just shows opensuse stuff, so I might be mixing distros [10:58] rodrigo_: sounds like apturl [10:58] oh [10:58] * rodrigo_ googles [10:58] "apturl-gtk apt://pmount" [10:59] but that obviously needs some support in Firefox, not sure how that part works [10:59] to add a PPA though? [10:59] I think they can also be more complex to add PPAs [10:59] see manpage [10:59] well, firefox would just laucnh the app registered for that url, right? [10:59] ah yes [10:59] apturl apt+http://launchpad.net/~mvo/ppa?package=2vcard [10:59] look in apturl(8) [10:59] pitti, cool [10:59] oh, but [11:00] Warning: This is currently disabled because of security concerns. === MacSlow is now known as MacSlow|lunch [11:00] ah, right [11:00] a simple apt://packagename does work in firefox, though [11:11] Laney: No, because afaik onboard has a UI for GTK and QT, so its cross-desktop. [11:12] i see [11:12] should we pull mousetweaks in somehow? [11:26] Laney: We do already in the seeds. [11:27] And afaik g-c-c depends on mousetweaks as well. [11:27] TheMuso: Ah, that's great then. Thanks! [11:27] It recommends it, so it still seems curious to have the symmetric one too [11:31] hello pitti and mvo! [11:33] pitti, actually sessioninstaller should already wait until the action is done [11:34] before returning [11:34] I haven't tested it yet, but the bug says it doesn't === alex-abreu|afk is now known as alex-abreu [11:45] pitti, that is a nasty bug [11:46] pitti, the Api of the gtk3 progress dialog changed slightly and I missed to adpot sessioninstaller [11:48] pitti, the rygel ftbfs looks like a problem with new vala/gtk too [11:52] glatzor: so that means it's not meant to be async, and indeed was sync before, so fixing this is not likely to break anything else? [11:53] doko, did you try to build it with vala-0.18 instead of vala-0.16? or remove the vala stamps to force a c-code regeneration. [11:54] doko: sounds like a job for the desktop team [11:54] ricotz, no. could you check this? [11:55] robru: would you mind looking at it when you get some free time? ^ [11:56] doko, since 0.14 is the gnome 3.4 version it is probably some incompatibility with a newer "3.6" library, 0.15.x is the current branch === zyga_ is now known as zyga [12:00] doko, i am trying to build it with vala 0.18 [12:00] ok [12:00] pitti, sorry forget about you aren't in -desktop anymore [12:04] doko, no luck [12:05] pitti, sessioninstaller hasn't changed. it is just the aptdaemon.gtk3widgets.AptProgressDialog.run() method [12:05] didrocks: evolution-indicator is a huge mess, don't think I will have time to port to 3.6, switch to gsettings, fix up any other things that need porting [12:05] pitti, basically this should do the trick http://pastebin.ubuntu.com/1214681/ [12:05] pitti, but I will have a deeper look at it [12:05] sucks though, because now we don't have an indicator mechanism for those who use evolution [12:05] cyphermox: so, pulling the trigger? [12:06] glatzor: great, thanks! I'm afraid I don't know enough about these internals yet [12:07] yeah :( I'll look at the upstream code on free time and try to massage it back into shape, but it's not likely to be ready in two weeks ;) [12:07] * didrocks flushes [12:09] huge step backwards... taken. [12:09] sorry, I'm bitchy, didn't have water at home this morning :( [12:10] cyphermox: I'm making the evolution-indicator bugs invalid right now [12:10] ok [12:10] cyphermox: the good news is that you have more time to work on bug #1037669 [12:10] Launchpad bug 1037669 in evolution "gst-plugin-scanner and browser plugins are used when opening certain emails" [Undecided,New] https://launchpad.net/bugs/1037669 [12:10] ahah yeah ;) [12:11] I got a semi-helpful response on the upstream bug [12:11] larsu: do you know who is working on bug #1040259? [12:11] Launchpad bug 1040259 in unity-mail "FFE: libmessaging-menu transitions for quantal" [High,Fix released] https://launchpad.net/bugs/1040259 [12:12] didrocks, the respective maintainers. Everybody added their project there. I'll do liferea, seb said he'll do pidgin [12:12] pitti: do you still do SRU approvals? [12:12] cyphermox: no, I left the team some months ago [12:12] ok [12:13] larsu: ok, assigning to him then :) [12:13] didrocks, do you know when he's coming back? [12:13] otherwise I might just do it [12:13] larsu: next week [12:13] ah okay [12:15] tkamppeter: hey, are you working on bug #998156? [12:15] Launchpad bug 998156 in gtk+3.0 "GTK Print dialog sends broken custom page size attribute: "PageSize=Custom.Custom.x"" [High,In progress] https://launchpad.net/bugs/998156 [12:18] didrocks, I asked mkasik's opinion about the attached patch, but he hasn't answered yet [12:18] (he's the one doing printing in gtk) [12:19] larsu: ah, should we try it in quantal? or can you try to ping him again? [12:19] didrocks, I think the patch is not good enough for upstream, but it will do the job for a cycle if we don't get a real fix soon [12:19] the patch almost certainly works, it's just not doing the right thing [12:20] larsu: maybe not beta2 though? should we just fiddle it in after it? (so that easier to revert) [12:20] yeah let's do that [12:20] ok, gotcha :) [12:21] pitti, this bug must be around for ages === MacSlow|lunch is now known as MacSlow [12:30] doko: btw, you should be fine most GNOME components landed now [12:30] didrocks, ok, thanks [12:47] * mlankhorst makes a note going 170 km/h is not good for fuel economy [13:35] * didrocks hugs kenvandine [13:35] thanks :) [13:36] * kenvandine hugs didrocks [14:01] kenvandine: hi, ted said you might be one to review https://code.launchpad.net/~aacid/gtk/ubuntugtk3_nmenomic_patch/+merge/125169 === MacSlow is now known as MacSlow|errand [14:02] didrocks, what do you think about that ^^ [14:02] didrocks, are you doing a gtk upload today? [14:03] kenvandine: robert already did it [14:04] i think it looks safe, but i don't have time to test it today [14:04] kenvandine: agreed [14:04] * didrocks tries to find a victim… [14:04] Laney: got some gtk-quality time? :) [14:07] didrocks: yeah, will look soon [14:07] wrangling totem right now [14:07] Laney: thanks a lot! :) [14:08] Laney: ah, on the totem bug? excellent :) [14:08] yeah [14:08] shame we didn't take the new upstreams, would have made taking that patch easier [14:08] Laney: yeah, I know, but gstreamer 1.0… :/ [14:09] indeed [14:09] Laney: great :-) ping me if you have any question about the mnemonic patch thingie [14:10] sure, thanks tsdgeos! [14:10] tsdgeos, why does this bug only happen in nautilus? [14:11] your description implies it should happen on every context menu [14:11] larsu: good question [14:13] i don't have an answer though [14:14] larsu: ping me when there is some movement on ubuntu-mono btw :) [14:14] larsu: which maybe means i need some more research [14:14] but otoh i could not find any other mnemonic broken and the nautilus got fixed [14:15] didrocks, yeah, I'll ping charles to speed up the merge request [14:15] well, I guess I hust did :) [14:16] tsdgeos, yeah, it just feels a bit weird topatch gtk when only one application has the problem [14:16] and we already have more than enough patches in gtk ;) [14:16] it's not a new patch, but a change to the existing one [14:16] Laney: heh :) [14:16] oh, you're right [14:16] but yeah I agree that it is curious and we should understand the bug ... [14:17] * tsdgeos digs a bit more into it [14:22] xnox: can you look at bug #1051222? [14:22] Launchpad bug 1051222 in apport "hook /usr/share/apport/package-hooks/source_ubiquity.py crashed: during ubuntu-bug ubiquity execution " [Low,Triaged] https://launchpad.net/bugs/1051222 [14:23] * xnox looks [14:27] psivaa: please don't add rls-q-incoming task for things we are not supporting [14:27] psivaa: like indicator-weather [14:30] wow, is it me or glade scrollbar is totally broken? [14:30] didrocks, ok, was doing some batch processing to include the tag, sorry i dint know that it was not supported, [14:31] psivaa: well, cleaning the list of the desktop team with down to 3 incoming task [14:31] hi didrocks, I just woke up. what did you want me to look at? I was reading the scrollback and it looks like you decided that was invalid shortly after pinging me... ? [14:31] psivaa: in addition to be swamped by the PS team and other tasks, I try to make the release team an skaet's list happy [14:31] psivaa: so please, double check before adding additional work :) [14:32] robru: hum, not invalid IIRC, let me check [14:32] didrocks: maybe the invalid thing was something else, wasn't really clear to me what you wanted me to do ;-) [14:32] didrocks, sure will do, from now on [14:32] larsu: are we positive it only happens in nautilus? [14:32] the cairo-5c ftbfs is desktopish too. works in debian, so maybe needs an update for the new cairo version in quantal [14:32] psivaa: thanks :) [14:34] tsdgeos, it doesn't happen in totem, empathy, gnome-terminal [14:34] robru: rygel is FTBFS, can you look why and how to fix it? [14:34] robru: that was the request [14:34] (and it's not invalid :)) [14:34] larsu: do they have duplicate entries with the same accelerator in the popup menu [14:34] * tsdgeos tries to create a dummy menu from nothing with duplicate entries with same accelerator [14:35] didrocks: ok, I just woke up, give me a minute to have breakfast and then I will look ;-) [14:36] tsdgeos, I don't know, is that important? [14:36] robru: thanks :) [14:36] larsu: it is [14:37] didrocks: regarding the rls-q-incoming , kate asked us to tag anything that should be fixed this cycle from our list with it [14:37] didrocks: now, after our chat this morning, we have a better idea of the things that are interesting [14:38] gema: please don't include universe package in the desktop team list [14:39] gema: if we could fix all the ones in main and have nothing to do, yeah, the universe one will make sense [14:39] gema: but we are clearly away from that target [14:39] didrocks: ack [14:39] didrocks: if some slips, please feel free to remove, we have a lot of people ramping up at the moment and we may make this kind of mistake [14:39] didrocks: I rather err on the side of caution and over tag, than forget something important [14:40] didrocks: but we'll try our best [14:40] well, we need a way to make sure something gets reviewed to be RC even if it's not in main [14:40] gema: that's why I prefered to warn them :) [14:40] gema: so that they don't reproduce it [14:40] didrocks: ack [14:41] micahg: how do you propose we do that? [14:41] * micahg is just speaking out loud here, not a desktop specific issue [14:41] gema: maybe let's go to -release [14:41] micahg: ack [14:47] tsdgeos: I don't see two entries with 'r' as mnemonic in nautilus though [14:47] Laney: that's because nautilus seem to be a bit weird and creates all entries and then hides the one it doesn't need [14:48] for example i was using "P" that in my locale has "_Properties" and if you select a folder also has "Obre en nova _pestanya" [14:48] and even if you open the menu on a file that is not a folder, the "Obre nova _pestanya" one goes through that function [14:51] i'm trying to build an example [14:51] pleasea bear with me [14:56] Laney: see this example http://paste.ubuntu.com/1214935/ [14:56] it has two _S items [14:57] but only one of them is being added to the menu [14:57] with the old code [14:57] it doesn't trigger the Save one when pressing s [14:57] with my new one it does [14:58] because if you have a look at https://code.launchpad.net/~aacid/gtk/ubuntugtk3_nmenomic_patch/+merge/125169 what the first if does (an if that is not present in gtk) is bypass the check for visibility, sensitive, etc (the second part of the if) when it is an item that is handled by the global menu, but since it's not an item handled by the global menu we can't bypass those checks [14:59] Laney: did i make any sense there? [15:00] tsdgeos: yeah, I get it, thanks [15:01]