| mramm | Hey frank+everybody! | 08:33 |
|---|---|---|
| TheMue | Good morning, team. ;) | 08:36 |
| davecheney | TheMue: hello! | 08:37 |
| TheMue | davecheney: heya | 08:37 |
| Aram | morning TheMue. | 08:38 |
| Aram | TheMue: we renamed mstate to state yesterday and we broke the build. now you fix it. | 08:38 |
| TheMue | Aram: hi, mr mstate | 08:38 |
| TheMue | Aram: mark just told me, great news (the renaming) | 08:39 |
| mramm | Aram: are we letting frank fix everything now? I guess he is rested up and ready to go! | 08:40 |
| mramm | ;) | 08:40 |
| rog | TheMue: morning! | 08:56 |
| TheMue | rog: hello | 08:57 |
| rog | TheMue: we've been missing you! | 08:57 |
| TheMue | rog: i would like to be in lisbon too, but now i'll see how i can support your from here. | 08:59 |
| niemeyer | davecheney: Beautiful juju status: https://codereview.appspot.com/6551043 | 09:02 |
| davecheney | niemeyer: nice! | 09:03 |
| davecheney | all: should we do a google hangout/standup so we can all see frank | 09:04 |
| davecheney | as we have the nice big projector | 09:04 |
| davecheney | https://codereview.appspot.com/6547044 << go vet go | 09:07 |
| mramm | davecheney: Let's do that at 10:30 | 09:07 |
| fwereade | niemeyer, https://codereview.appspot.com/6551044 should be *almost* trivial, but I suddenly realised that we apparently had *no* name-validity checking in state, and that seemed like a Bad Thing | 09:09 |
| mramm | TheMue: Perhaps the best thing you can do right now is to catch up on the latest trunk, and look through the state changes for the last week or two | 09:10 |
| niemeyer | ls | 09:10 |
| TheMue | mramm: yep, just pulled it | 09:11 |
| mramm | it will be hard to merge you into the moment by moment state updates that are going on here | 09:11 |
| mramm | and there is a lot to catch up on | 09:11 |
| TheMue | mramm: i go through the mails and compare it to the current code to refresh my understanding :) | 09:11 |
| mramm | TheMue: sounds good | 09:12 |
| niemeyer | davecheney: Reproposed, please see if I got the cases you brought up or missed one | 09:28 |
| davecheney | niemeyer: kk | 09:29 |
| niemeyer | fwereade: Hmm.. in which sense.. please speak live when you have a moment :) | 09:30 |
| davecheney | niemeyer: one last one, "" | 09:31 |
| niemeyer | davecheney: Done | 09:33 |
| fwereade | niemeyer, and https://codereview.appspot.com/6552043 sits on top of the foregoing -- turns out I had missed a settings test from state :/ | 09:39 |
| niemeyer | fwereade: Reviewed | 09:39 |
| niemeyer | fwereade: The bottom on | 09:39 |
| niemeyer | e | 09:39 |
| niemeyer | ls | 09:41 |
| davecheney | # launchpad.net/juju-core/environs/dummy | 09:45 |
| davecheney | environs/dummy/environs.go:400: undefined: state.Initialize | 09:45 |
| davecheney | ^ is anyone working on this ? | 09:45 |
| fwereade | niemeyer, reproposed https://codereview.appspot.com/6551044 | 09:53 |
| niemeyer | fwereade: done | 10:35 |
| niemeyer | ls | 10:35 |
| niemeyer | davecheney: https://codereview.appspot.com/6547044/ done | 10:44 |
| davecheney | niemeyer: ty | 10:48 |
| TheMue | lunchtime | 10:54 |
| TheMue | enjoy the good seafood overthere, i've got to wait until a lunch with my parents in law on sunday ;) | 10:55 |
| niemeyer | fg | 11:05 |
| davecheney | rm | 11:13 |
| niemeyer | fwereade: https://codereview.appspot.com/6533052/ done | 11:15 |
| SpamapS | are you guys in Lisbon this week? | 11:56 |
| rog | davecheney: try again | 13:10 |
| davecheney | rog: lucky(~) % GOROOT=~/go.103 ~/go.103/bin/go tool vet -h | 13:18 |
| davecheney | Usage of vet: -printfuncs="": comma-separated list of print function names to check -v=false: verbose | 13:18 |
| davecheney | go tool vet: exit status 2 | 13:18 |
| davecheney | that's all ya get in 1.0.3 | 13:18 |
| davecheney | # launchpad.net/juju-core/charm | 13:24 |
| davecheney | ../charm/url.go:191: undefined: bson.SetZero | 13:24 |
| davecheney | FAIL launchpad.net/juju-core/state [build failed] | 13:24 |
| davecheney | ?? | 13:24 |
| davecheney | # launchpad.net/juju-core/state_test | 13:27 |
| davecheney | ./conn_test.go:64: undefined: D | 13:27 |
| niemeyer | SpamapS: Not sure if someone answered, but yes, we're in Lisbon | 13:32 |
| SpamapS | niemeyer: explains why you're all quiet in here for once. :) | 13:37 |
| === cmagina_ is now known as cmagina | ||
| niemeyer | SpamapS: :-) | 13:54 |
| davecheney | state_test.go:585: c.Assert(err, IsNil) | 13:56 |
| davecheney | ... value schema.error_ = schema.error_{want:"string", got:interface {}(nil), path:[]string{".", "type"}} ("type: expected string, got nothing") | 13:56 |
| niemeyer | davecheney: ? | 14:00 |
| fwereade | niemeyer, rog: https://bugs.launchpad.net/juju-core/+bug/1053419 | 14:03 |
| niemeyer | ls | 14:13 |
| davecheney | i think there might be a bug with environs/config.Configs | 14:39 |
| davecheney | that are backed by {m}state | 14:39 |
| davecheney | schema.error_ = schema.error_{want:"string", got:interface {}(nil), path:[]string{".", "type"}} ("type: expected string, got nothing") | 14:43 |
| davecheney | Aram: schema.error_ = schema.error_{want:"string", got:interface {}(nil), path:[]string{".", "type"}} ("type: expected string, got nothing") | 14:44 |
| niemeyer | Hey guys, can I get a review on this: https://codereview.appspot.com/6555043 | 15:08 |
| niemeyer | This is builddb | 15:08 |
| niemeyer | It'll certainly not work on trunk right now, but I'd like to get it in so we can keep it somewhat up-to-date eventually | 15:08 |
| * davecheney looks | 15:09 | |
| niemeyer | I was also stuck on the old state to get it to build MongoDB.. I want to move on now so I continue contributing to (m)state | 15:10 |
| davecheney | niemeyer: thank you, reproposed | 15:34 |
| davecheney | Aram: https://codereview.appspot.com/6541045 | 15:35 |
| niemeyer | davecheney: Looking | 15:35 |
| niemeyer | Trivial: https://codereview.appspot.com/6549044 | 15:37 |
| davecheney | niemeyer: +1, although while you have won the battle, you are probably loosing the way | 15:39 |
| davecheney | war | 15:39 |
| niemeyer | davecheney: Yeah, unfortunately :-) | 15:41 |
| niemeyer | Or fortunately, I guess.. moar tests | 15:41 |
| davecheney | # launchpad.net/juju-core/environs/dummy | 15:44 |
| davecheney | environs/dummy/environs.go:400: cannot use cfg.AllAttrs() (type map[string]interface {}) as type *config.Config in function argument | 15:44 |
| davecheney | ^ will fix this next | 15:44 |
| davecheney | niemeyer: Aram https://codereview.appspot.com/6541047 | 15:47 |
| davecheney | ^ trivial | 15:47 |
| niemeyer | davecheney: Sweet, LGTM | 15:47 |
| davecheney | # launchpad.net/juju-core/worker | 15:50 |
| davecheney | worker/environ.go:16: undefined: state.EnvironConfigWatcher | 15:50 |
| davecheney | worker/environ.go:21: select case must be receive, send or assign recv | 15:50 |
| davecheney | interesting | 15:50 |
| niemeyer | All: lp:~niemeyer/juju-core/old-state ... for eternity | 15:54 |
| * davecheney plays taps | 15:54 | |
| rog | Aram, niemeyer: https://codereview.appspot.com/6549045 | 16:39 |
| rog | niemeyer: next in line (almost exactly as it was in old state): https://codereview.appspot.com/6550047 | 17:11 |
| niemeyer | :w | 17:22 |
| === TheMue_ is now known as TheMue | ||
| === TheMue_ is now known as TheMue | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!