[08:33] Hey frank+everybody! [08:36] Good morning, team. ;) [08:37] TheMue: hello! [08:37] davecheney: heya [08:38] morning TheMue. [08:38] TheMue: we renamed mstate to state yesterday and we broke the build. now you fix it. [08:38] Aram: hi, mr mstate [08:39] Aram: mark just told me, great news (the renaming) [08:40] Aram: are we letting frank fix everything now? I guess he is rested up and ready to go! [08:40] ;) [08:56] TheMue: morning! [08:57] rog: hello [08:57] TheMue: we've been missing you! [08:59] rog: i would like to be in lisbon too, but now i'll see how i can support your from here. [09:02] davecheney: Beautiful juju status: https://codereview.appspot.com/6551043 [09:03] niemeyer: nice! [09:04] all: should we do a google hangout/standup so we can all see frank [09:04] as we have the nice big projector [09:07] https://codereview.appspot.com/6547044 << go vet go [09:07] davecheney: Let's do that at 10:30 [09:09] niemeyer, https://codereview.appspot.com/6551044 should be *almost* trivial, but I suddenly realised that we apparently had *no* name-validity checking in state, and that seemed like a Bad Thing [09:10] TheMue: Perhaps the best thing you can do right now is to catch up on the latest trunk, and look through the state changes for the last week or two [09:10] ls [09:11] mramm: yep, just pulled it [09:11] it will be hard to merge you into the moment by moment state updates that are going on here [09:11] and there is a lot to catch up on [09:11] mramm: i go through the mails and compare it to the current code to refresh my understanding :) [09:12] TheMue: sounds good [09:28] davecheney: Reproposed, please see if I got the cases you brought up or missed one [09:29] niemeyer: kk [09:30] fwereade: Hmm.. in which sense.. please speak live when you have a moment :) [09:31] niemeyer: one last one, "" [09:33] davecheney: Done [09:39] niemeyer, and https://codereview.appspot.com/6552043 sits on top of the foregoing -- turns out I had missed a settings test from state :/ [09:39] fwereade: Reviewed [09:39] fwereade: The bottom on [09:39] e [09:41] ls [09:45] # launchpad.net/juju-core/environs/dummy [09:45] environs/dummy/environs.go:400: undefined: state.Initialize [09:45] ^ is anyone working on this ? [09:53] niemeyer, reproposed https://codereview.appspot.com/6551044 [10:35] fwereade: done [10:35] ls [10:44] davecheney: https://codereview.appspot.com/6547044/ done [10:48] niemeyer: ty [10:54] lunchtime [10:55] enjoy the good seafood overthere, i've got to wait until a lunch with my parents in law on sunday ;) [11:05] fg [11:13] rm [11:15] fwereade: https://codereview.appspot.com/6533052/ done [11:56] are you guys in Lisbon this week? [13:10] davecheney: try again [13:18] rog: lucky(~) % GOROOT=~/go.103 ~/go.103/bin/go tool vet -h [13:18] Usage of vet: -printfuncs="": comma-separated list of print function names to check -v=false: verbose [13:18] go tool vet: exit status 2 [13:18] that's all ya get in 1.0.3 [13:24] # launchpad.net/juju-core/charm [13:24] ../charm/url.go:191: undefined: bson.SetZero [13:24] FAIL launchpad.net/juju-core/state [build failed] [13:24] ?? [13:27] # launchpad.net/juju-core/state_test [13:27] ./conn_test.go:64: undefined: D [13:32] SpamapS: Not sure if someone answered, but yes, we're in Lisbon [13:37] niemeyer: explains why you're all quiet in here for once. :) === cmagina_ is now known as cmagina [13:54] SpamapS: :-) [13:56] state_test.go:585: c.Assert(err, IsNil) [13:56] ... value schema.error_ = schema.error_{want:"string", got:interface {}(nil), path:[]string{".", "type"}} ("type: expected string, got nothing") [14:00] davecheney: ? [14:03] niemeyer, rog: https://bugs.launchpad.net/juju-core/+bug/1053419 [14:13] ls [14:39] i think there might be a bug with environs/config.Configs [14:39] that are backed by {m}state [14:43] schema.error_ = schema.error_{want:"string", got:interface {}(nil), path:[]string{".", "type"}} ("type: expected string, got nothing") [14:44] Aram: schema.error_ = schema.error_{want:"string", got:interface {}(nil), path:[]string{".", "type"}} ("type: expected string, got nothing") [15:08] Hey guys, can I get a review on this: https://codereview.appspot.com/6555043 [15:08] This is builddb [15:08] It'll certainly not work on trunk right now, but I'd like to get it in so we can keep it somewhat up-to-date eventually [15:09] * davecheney looks [15:10] I was also stuck on the old state to get it to build MongoDB.. I want to move on now so I continue contributing to (m)state [15:34] niemeyer: thank you, reproposed [15:35] Aram: https://codereview.appspot.com/6541045 [15:35] davecheney: Looking [15:37] Trivial: https://codereview.appspot.com/6549044 [15:39] niemeyer: +1, although while you have won the battle, you are probably loosing the way [15:39] war [15:41] davecheney: Yeah, unfortunately :-) [15:41] Or fortunately, I guess.. moar tests [15:44] # launchpad.net/juju-core/environs/dummy [15:44] environs/dummy/environs.go:400: cannot use cfg.AllAttrs() (type map[string]interface {}) as type *config.Config in function argument [15:44] ^ will fix this next [15:47] niemeyer: Aram https://codereview.appspot.com/6541047 [15:47] ^ trivial [15:47] davecheney: Sweet, LGTM [15:50] # launchpad.net/juju-core/worker [15:50] worker/environ.go:16: undefined: state.EnvironConfigWatcher [15:50] worker/environ.go:21: select case must be receive, send or assign recv [15:50] interesting [15:54] All: lp:~niemeyer/juju-core/old-state ... for eternity [15:54] * davecheney plays taps [16:39] Aram, niemeyer: https://codereview.appspot.com/6549045 [17:11] niemeyer: next in line (almost exactly as it was in old state): https://codereview.appspot.com/6550047 [17:22] :w === TheMue_ is now known as TheMue === TheMue_ is now known as TheMue