allenap | jam: I think Tarmac only checks the "revision approved at" that appears when you mark the overall mp as approved; it doesn't check that individual votes are up to date. | 10:40 |
---|---|---|
jam | allenap: ah, that would make more sense to what I've seen. But it was one of those voodoo not sure-what-triggers-x so covering my backside | 10:41 |
jam | thanks for the heads up | 10:41 |
jam | ffs... | 10:42 |
allenap | jam: Totally; we all went through exactly the same learning exercise :) | 10:42 |
jam | it just happened again. I guess I have to watch out for the MP to be updated before I vote approved. | 10:42 |
allenap | jam: I think once the revision appears in the "Unmerged revisions" list, you can mark it approved and it'll be okay. | 10:43 |
allenap | But I can't remember if that list is updated by long-poll. If it is, it may be that the status widget doesn't know about it, and thus approves the revision when the page was first loaded. | 10:44 |
jam | interesting | 10:44 |
jam | yeah, may want to reload before approving after doing a push. | 10:44 |
jam | could certainly be what happened, I just always waited till after the push, but not necessarily for the page to reveal it. | 10:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!