| didrocks | btw, I think that people noticed the merger is stuck? | 07:26 |
|---|---|---|
| om26er | davidcalle, Hey! | 08:31 |
| om26er | you may want to take a look at bug 1056814 | 08:31 |
| ubot5 | Launchpad bug 1056814 in unity-lens-video (Ubuntu) "unity-lens-video crashed with UnicodeEncodeError in progress_zg_events(): 'ascii' codec can't encode character u'\xe4' in position 35: ordinal not in range(128)" [Medium,Confirmed] https://launchpad.net/bugs/1056814 | 08:31 |
| davidcalle | om26er, hey! | 08:32 |
| davidcalle | om26er, looking at it and wishing we could have moved it to py3 this cycle... Thanks | 08:33 |
| om26er | davidcalle, thank you :) | 08:33 |
| === mmrazik is now known as mmrazik|afk | ||
| === MacSlow is now known as MacSlow|lunch | ||
| === mmrazik|afk is now known as mmrazik | ||
| davidcalle | om26er, hey again, I'm wondering about https://bugs.launchpad.net/unity-lens-photos/+bug/1049090, why have you removed [UIFe] from the title? | 12:40 |
| ubot5 | Ubuntu bug 1049090 in OEM Priority Project quantal "The shortcut Super + P of photo lens is conflict to Video out hotkey" [High,Confirmed] | 12:40 |
| om26er | davidcalle, sorry about that, I thought it was too late for that and did we get a response from design on that? | 12:42 |
| om26er | its actually a oem-priority to get that fixed | 12:42 |
| davidcalle | om26er, yeah, everything is ready, design, doc and translators have acked. | 12:43 |
| om26er | davidcalle, added back the tag | 12:43 |
| davidcalle | didrocks, ^^^are we waiting on someone else or is it ok for you? | 12:43 |
| om26er | bug 1049090 | 12:43 |
| ubot5 | Launchpad bug 1049090 in OEM Priority Project quantal "[UIFe] The shortcut Super + P of photo lens is conflict to Video out hotkey" [High,Confirmed] https://launchpad.net/bugs/1049090 | 12:43 |
| om26er | davidcalle, so whats the new key for photo lens? | 12:44 |
| davidcalle | om26er, thanks, it wasn't an issue for me, just wanted to know :) | 12:44 |
| davidcalle | om26er, Super+C | 12:44 |
| om26er | and what does C stand for :O | 12:44 |
| davidcalle | Camera :P | 12:44 |
| didrocks | davidcalle: I'll backport it | 12:45 |
| didrocks | davidcalle: it will be uploaded today | 12:45 |
| didrocks | davidcalle: what's the task on the shopping lens? | 12:46 |
| didrocks | ah changing the shortcut as well | 12:46 |
| davidcalle | didrocks, I've a branch to remove the keyboard shortcut, it doesn't need one | 12:46 |
| didrocks | ok, please do and propose it :) | 12:46 |
| didrocks | Mirv: ^ | 12:46 |
| davidcalle | didrocks, the MP is done I think, let me check | 12:47 |
| didrocks | davidcalle: can you send the link here | 12:47 |
| Mirv | davidcalle: this one? https://code.launchpad.net/~davidc3/unity-lens-shopping/remove-keyboard-shortcut/+merge/128008 | 12:49 |
| davidcalle | didrocks, https://code.launchpad.net/~davidc3/unity-lens-shopping/remove-keyboard-shortcut/+merge/128008 | 12:49 |
| davidcalle | Mirv, yes | 12:49 |
| didrocks | Mirv: not sure if the shopping lens has the merger in TBH | 12:50 |
| didrocks | Mirv: approved the branch :) | 12:50 |
| didrocks | davidcalle: thanks! | 12:50 |
| Mirv | thanks, both d:s | 12:50 |
| didrocks | davidcalle: can you add the downstream tasks for both on the bug report please? | 12:50 |
| davidcalle | didrocks, sure | 12:50 |
| didrocks | Mirv: I'm taking care of the photo lens | 12:50 |
| Mirv | sil2100 actually has the shopping packaging on his computer, but I poked him about this so that it'll be included in today's release | 12:54 |
| jono | didrocks, want to come on our marathon hangout for an interiveW? | 12:55 |
| jono | internview | 12:55 |
| jono | interview | 12:55 |
| * jono can't type | 12:55 | |
| * jono can't type | 12:55 | |
| didrocks | jono: can do! maybe rather tomorrow morning (when all you guys will be almost passing out :)) as today is desktop infrastructure and we are pushing unity 6.8? | 12:59 |
| jono | didrocks, no worries! | 13:00 |
| didrocks | mhall119: indeed, I will have a "full night of sleep" :) | 13:00 |
| didrocks | but thinking about you guys, no worry :) | 13:00 |
| mhall119 | didrocks: :P | 13:01 |
| === MacSlow|lunch is now known as MacSlow | ||
| === yofel_ is now known as yofel | ||
| === dpb_ is now known as Guest91546 | ||
| sil2100 | Trevinho: hi! How's the crash fixes going? Merges submitted? | 15:09 |
| * sil2100 in the bus right now | 15:09 | |
| sil2100 | didrocks: any problems with the releases so far? | 15:11 |
| didrocks | sil2100: some with dconf | 15:11 |
| didrocks | sil2100: and you not diffing configure.ac | 15:11 |
| sil2100 | In what package? | 15:12 |
| sil2100 | Bamf I'm sure I diffed... | 15:12 |
| didrocks | the shopping lens | 15:12 |
| didrocks | depped on the new libunity | 15:13 |
| sil2100 | Ok, about that really sorry, since it was all in a hurry, grrr - yes, this change I didn't bzr merge -c from the previous ubuntu branch... | 15:14 |
| sil2100 | Since I recreated it from 0 in a few minutes with the new tarball :/ | 15:15 |
| sil2100 | We even prepped checklists for thimgs like that, not to forget anything, but it all was useless when doing in a hurry, I apologise about that | 15:16 |
| sil2100 | *things | 15:16 |
| toabctl | Cimi, can you comment/merge https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 please? | 15:20 |
| sil2100 | I blame the buses ;p But I also could have just made cp the whole debian directory instead | 15:20 |
| Cimi | toabctl: thx, I read and forgot to reply! | 15:21 |
| Cimi | toabctl: anyway, why you did modify the tests as well? | 15:21 |
| toabctl | Cimi, the test program looked very ugly. | 15:21 |
| toabctl | Cimi, it's just cosmetic | 15:21 |
| toabctl | Cimi, oh. I just realized that I proposed both commits. I can recreate the merge request with only the memory leak fix, if you want | 15:22 |
| didrocks | sil2100: no worry, but rigor rigor rigor please :/ | 15:22 |
| didrocks | sil2100: this should be automatic after 6 months of practice already… | 15:23 |
| Cimi | toabctl: the if is redundant in the destroy notify | 15:24 |
| sil2100 | I know I know! This time I assure you - if I only I didnt do it so hastily before going out, I would certainly notice the change, since now its no way not to when we do everything step by step | 15:26 |
| sil2100 | So this will hopefully *not* happen again in normal working conditions | 15:26 |
| sil2100 | I feel so ashamed because we worked so hard this week to get this formalized in our team and it all went to waste with the shopping packaging ;p | 15:27 |
| Cimi | toabctl: I am checking with our glib expert | 15:27 |
| toabctl | Cimi, you mean in destroy_private() ? g_slice_free() already checks for NULL? | 15:27 |
| Cimi | toabctl: destroy notify never get null | 15:28 |
| toabctl | Cimi, ah. ok. I can remove the if-statement | 15:29 |
| toabctl | Cimi, what do you want to check? and who's the glib expert? | 15:30 |
| Cimi | toabctl: ryan lortie | 15:30 |
| Cimi | desrt on freenode | 15:31 |
| toabctl | ok | 15:31 |
| toabctl | Cimi, just let me know what I should change on the branch | 15:31 |
| Cimi | sure | 15:32 |
| === salem_ is now known as _salem | ||
| sil2100 | popey I'm running as fast as I can :)! | 15:46 |
| === _salem is now known as salem_ | ||
| toabctl | Cimi, thanks | 15:47 |
| === dandrader is now known as dandrader|afk | ||
| * sil2100 is taking a taxi now | 15:57 | |
| sil2100 | didrocks: just wait 5 more minutes! | 15:58 |
| didrocks | ok, thanks :) | 15:58 |
| sil2100 | I have REALLY bad timing! | 15:58 |
| === dandrader|afk is now known as dandrader | ||
| sil2100 | Launching pc! | 16:05 |
| didrocks | launching? | 16:33 |
| didrocks | no unity tarball still? | 16:33 |
| toabctl | charles, is there something to do for https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 ? | 16:48 |
| toabctl | charles, would be cool to provide debug symbols in an extra debian package for the scrollbar. | 16:49 |
| davidcalle | mhr3, could you have a quick look at https://code.launchpad.net/~davidc3/unity-lens-videos/fix-1056814/+merge/128073 ? | 17:18 |
| davidcalle | didrocks, is it too late for video lens cherrypicking? utf-8 related crash. | 17:19 |
| didrocks | davidcalle: urgh, really? :/ | 17:19 |
| didrocks | is it new? | 17:19 |
| davidcalle | didrocks, no, but I'm discovering it, it's a regression from a few weeks ago apparently. | 17:20 |
| didrocks | davidcalle: I will really mandate automated testing when you get issues like this | 17:20 |
| mhr3 | davidcalle, the first should be uri, that shouldn't need encoding | 17:21 |
| davidcalle | didrocks, I'm discovering this part of the code. I will update myself on automated testing next cycle :/ | 17:22 |
| didrocks | mhr3: can you review it then? | 17:22 |
| mhr3 | although zg isn't really forcing uris to be properly encoded uris | 17:22 |
| davidcalle | mhr3, yeah, but the bug report is about the uri not being correctly encoded | 17:22 |
| didrocks | davidcalle: if you can do the needed change in ack from mhr3 in the coming 3 minutes, I'll upload it :) | 17:22 |
| mhr3 | meh, ack :) | 17:22 |
| davidcalle | didrocks, mhr3, thanks, om26er pinged me about it this morning but I couldn't access my own computer until know. | 17:24 |
| davidcalle | now* | 17:24 |
| mhr3 | lenses are getting messy, libunity should do more than it does | 17:24 |
| didrocks | well, the video lens is still messy, I type the exact string of files name and it can't find them | 17:26 |
| mhr3 | cause it's searching in ~/Videos only | 17:26 |
| toabctl | didrocks, if I want to add a -dbg package for the overlay-scrollbar, is bzr branch lp:~ubuntu-desktop/ayatana-scrollbar/ubuntu the right place to start a branch? | 17:26 |
| didrocks | mhr3: no, I see it at first glance | 17:26 |
| didrocks | toabctl: right, but why do you want to do that? | 17:27 |
| davidcalle | didrocks, odd, it's using locate. | 17:27 |
| didrocks | mhr3: I see it in the first panel, with no search | 17:27 |
| mhr3 | didrocks, yes, the no-search results are populated by zg query | 17:27 |
| didrocks | like sliders.blablabla | 17:27 |
| didrocks | ah | 17:27 |
| didrocks | that's weird | 17:27 |
| mhr3 | i think we should sru it to do things properly | 17:27 |
| didrocks | or not consistent :) | 17:27 |
| didrocks | yeah | 17:27 |
| toabctl | didrocks, because of https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 . maybe there will be other problems in the future and then it's nice to have the symbols araound. | 17:28 |
| didrocks | toabctl: we do have symbols in ubuntu | 17:28 |
| didrocks | toabctl: we don't need -dbg packages | 17:28 |
| toabctl | didrocks, hm. how to get the ??? resolved, then? | 17:29 |
| didrocks | toabctl: https://wiki.ubuntu.com/DebuggingProgramCrash | 17:30 |
| didrocks | mhr3: davidcalle: uploaded | 17:30 |
| davidcalle | mhr3, to be consistent, Zeitgeist could index all your files *cough* | 17:30 |
| davidcalle | didrocks, thanks! | 17:31 |
| didrocks | davidcalle: yw :) | 17:31 |
| davidcalle | mhr3, kidding :) | 17:31 |
| didrocks | davidcalle: is there any reason why the search doesn't include Zeitgeist? | 17:31 |
| * didrocks sees mhr3 becoming a green hulk :) | 17:31 | |
| mhr3 | davidcalle, yea... no :P | 17:32 |
| mhr3 | it's a log, not an index | 17:32 |
| mhr3 | indexer* | 17:32 |
| davidcalle | didrocks, the logic has changed this cycle, zg results were in a Recently viewed category in Precise. Now, it's merged, but the search hasn't been added. Would be great indeed. | 17:34 |
| toabctl | didrocks, cool. thanks! | 17:34 |
| didrocks | davidcalle: can be a SRU I guess, yep | 17:34 |
| didrocks | toabctl: yw :) | 17:34 |
| mhr3 | hmm, that reminds me, design often wants something changed visually but forget to tell us how the behaviour should change to deal with that visual change | 17:35 |
| toabctl | didrocks, how does this work? do you build all packages without optimization and upload the packages to ddebs with the dbgsym suffix? | 17:35 |
| didrocks | toabctl: we build all package with debug symbols (but optimisations also, it's separate) | 17:36 |
| didrocks | packages* | 17:36 |
| didrocks | then, we strip the symbols in another files | 17:36 |
| didrocks | (pkgbinarymangler is doing that) | 17:36 |
| didrocks | and upload that in the separate archive (to not double the size of the index) | 17:36 |
| toabctl | didrocks, that's full automatic? without any -dbg stuff in debian/control files? | 17:37 |
| didrocks | toabctl: yeah, all packages in ubuntu go throught that | 17:38 |
| didrocks | toabctl: we just have another package installed in the chroot | 17:38 |
| didrocks | and hooking that | 17:38 |
| didrocks | toabctl: you can install it yourself: pkg-create-dbgsym | 17:38 |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === dandrader is now known as dandrader|lunch | ||
| toabctl | Cimi, charles : I updated the bug report and the branch for the overlay-scrollbar. please review again: https://code.launchpad.net/~toabctl/ayatana-scrollbar/fix-mem-leak-bug-1058205/+merge/127059 | 18:26 |
| charles | toabctl: cool! | 18:26 |
| charles | toabctl: I was just looking at that too, we're doing a lot of unnecessary work in the hijacked-dispose callback | 18:26 |
| charles | which was what caused Priv to get called while the widet was being disposed | 18:27 |
| toabctl | charles, the DestroyNotify callback definitly fixes a mem leak. So imho that's a must. | 18:27 |
| charles | I was just about to offer that on top of your patch | 18:27 |
| charles | toabctl: agree | 18:27 |
| charles | toabctl: but allocating memory and setting it in a widget's qdata in that widget's dispose function... not good | 18:28 |
| charles | IMO we need two fixes here | 18:29 |
| charles | toabctl: also, thanks for the test program you submitted to demonstrate the leak. I wish all leak reports were this good | 18:29 |
| toabctl | charles, agree. allocating mem in a dispose function is bad. | 18:30 |
| toabctl | charles, I just wanted to port d-feet to Gtk3. Then I ended at the scrollbar while searching for mem leaks :-) | 18:31 |
| toabctl | charles, btw: there seems to be another leak (reported by valgrind for the same program). but I don't understand it: http://paste.ubuntu.com/1260522/ | 18:32 |
| * charles looks | 18:36 | |
| charles | toabctl: I think that's a false positive | 18:37 |
| charles | toabctl: or rather, it's something that's happening deep inside the dependencies that we can't control | 18:38 |
| charles | toabctl: http://sourceware.org/bugzilla/show_bug.cgi?id=2314 | 18:38 |
| ubot5 | sourceware.org bug 2314 in libc "nss_parse_service_list leaks a tiny amount of memory" [Minor,Resolved: wontfix] | 18:38 |
| toabctl | charles, ah. thanks! | 18:40 |
| charles | Cimi, toabctl: https://code.launchpad.net/~charlesk/ayatana-scrollbar/lp-1058205/+merge/128087 | 18:48 |
| toabctl | charles, what about the CI comment for your branch? all links are just 404.... | 19:07 |
| charles | toabctl: CI is having a hard day :) | 19:08 |
| charles | toabctl: alesage is looking at it | 19:08 |
| alesage | toabctl, on it, a few min | 19:08 |
| toabctl | alesage, cool. | 19:08 |
| toabctl | charles, how to get the fix into 12.10? do you do a new release? or should the patch be provided in debian/patches? | 19:09 |
| charles | that's up to the packager. I didn't check when the last ayatana-scrollbar release was, they may patch or they may release | 19:11 |
| charles | toabctl: ^ | 19:11 |
| === dandrader|lunch is now known as dandrader | ||
| toabctl | charles, I'll ask didrocks. he did the last upload. | 19:14 |
| toabctl | charles, thanks for the help! | 19:15 |
| charles | toabctl: seb128's on it | 19:15 |
| toabctl | charles, ok | 19:15 |
| === salem_ is now known as _salem | ||
| === _salem is now known as salem_ | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!