| === matsubara is now known as matsubara-afk | ||
| jtv | roaksoax: what do I need to do in order to get my tx-tftp fix into the ubuntu package? | 03:20 |
|---|---|---|
| roaksoax | jtv: if you want you can file a bug against the package in ubuntu and attach the patch, and I'll take care of it | 03:25 |
| jtv | Thanks. | 03:25 |
| roaksoax | jtv: you working todya? | 03:26 |
| jtv | Nope. | 03:26 |
| roaksoax | :) | 03:26 |
| roaksoax | good.. it's been a long weekend for all | 03:27 |
| jtv | Not for me. Major internet outage last night. :( | 03:28 |
| jtv | I added the Ubuntu package to the bug. And now, I must run! | 03:29 |
| roaksoax | jtv: awesome thansk | 03:29 |
| allenap | jelmer: Are you around today? | 09:58 |
| jelmer | allenap: ish | 10:15 |
| jelmer | allenap: how are you? | 10:15 |
| allenap | jelmer: Holding up :) You? I was wondering if one of the blues is around to take a second look at https://code.launchpad.net/~andreserl/maas/maas_fix_constraints_arch_mapping/+merge/128338. | 10:16 |
| jelmer | allenap: holding op too :) | 10:18 |
| * jelmer looks | 10:18 | |
| jelmer | allenap: Sorry, I'm not sure either | 10:25 |
| jelmer | allenap: the API does seem like the wrong place to be doing this sort of mapping | 10:25 |
| allenap | jelmer: Okay, I'll leave it as is, and see if John or Martin want to comment. Thanks :) | 10:25 |
| jelmer | allenap: but I don't think I am familiar enough with this part of the code to give a useful comment | 10:25 |
| jelmer | allenap: okay; sorry I couldn't be of more help | 10:26 |
| allenap | jelmer: No worries, thanks for looking. | 10:26 |
| allenap | Afternoon | 13:47 |
| roaksoax | allenap: still around? | 16:13 |
| allenap | roaksoax: Yeah, hi. | 16:13 |
| roaksoax | allenap: thanks for the review, addressing your comments :) | 16:13 |
| allenap | Cool, ta. | 16:14 |
| roaksoax | allenap: comments make sense to you? http://paste.ubuntu.com/1264110/ | 16:15 |
| allenap | roaksoax: Yeah, they're good. | 16:25 |
| roaksoax | allenap: and I also wnat to wait for the blue squad comments on it since i think they didn't forsee the change of the arch including subarch in maas | 16:29 |
| roaksoax | and juju passing only arch | 16:29 |
| roaksoax | allenap: https://code.launchpad.net/~andreserl/maas/fix_ipmi_command_execution/+merge/128358 | 16:29 |
| allenap | roaksoax: Fwiw, I normally only resubmit a merge proposal when I've made a mistake with, say, the prerequisite branch, or the proposal is unrecognisable from before. Ordinarily I just push the changes and ping or comment to alert the reviewer to take another look. | 16:31 |
| allenap | Although what you did makes sense, it doesn't seem to be the norm. | 16:32 |
| roaksoax | ok :) | 16:32 |
| roaksoax | thanks for the advice | 16:33 |
| allenap | roaksoax: Have a good evening, I'm off now. | 17:03 |
| roaksoax | allenap: you do as well | 17:03 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!