/srv/irclogs.ubuntu.com/2012/10/07/#launchpad-dev.txt

=== Ursinha is now known as Ursinha-afk
=== Ursinha-afk is now known as Ursinha
=== Ursinha is now known as Ursinha-afk
=== maxb_ is now known as maxb
wgrantwallyworld_: Morning22:42
wallyworld_hello22:42
wgrantwallyworld_: Not sure if you saw, but we both landed testfixes yesterday morning22:43
wgrantWe should probably revert one of them22:43
wallyworld_yes :-( i wish you had let me do it22:43
wallyworld_we should get a deployment done first perhaps to clear the backlog22:45
wgrantWell, I waited 10 hours after the initial failure so decided you were probably doing something more weekendy during the weekend :P22:45
wgrantWe probably don't have webops until the UK wakes up22:45
wallyworld_i did it before i went to bed. you can't expect me to do it during the night22:45
wallyworld_i did it when i woke up22:45
wallyworld_it wasn't your issue to fix22:45
wgrantHm?22:45
wgrantBuild failures are *everyone*'s issue to fix22:45
wgrantThat's why they block landings22:46
wallyworld_sure, but i caused it so i was fixing22:46
wgrantAnd I had a one-liner trivial fix that would mean you wouldn't have to care, so I thought I'd help you out and unbreak it22:47
wgrantSorry22:47
wallyworld_me too.  i did check and i didn't see anyone else landing anythng22:48
wallyworld_so we sort of did it at the same time.22:49
wgrantYeah, you were only about half an hour later22:49
wgrantYour fix is a little more comprehensive, but I think mine is more in the style that we've used elsewhere.22:49
wgrantI'm not sure which wins22:49
wallyworld_i reverted the caching because it can have unintended issues22:50
wallyworld_but the one liner may be worth sticking with22:50
wgrantRight22:50
wallyworld_i do dislike how we put sql inside properties22:50
wgrantTo be completely correct we'd also need to invalidate on deletions and milestone retargetings22:50
wgrantBut I think those are probably OK to not care about here22:51
wallyworld_yeah22:51
wallyworld_my solution means that everything else except my use case uses the old way22:51
wallyworld_there's a bigger design issue here though22:52
wallyworld_which is out of scope for right now22:52
wallyworld_so, we need to divvy up the bvm removal work22:52
wallyworld_bvp22:52
wgrantThere's actually not that much to remove22:53
wgrantprivate_bugs needs to go too22:53
wgrantI forget if StevenK's here this week22:53
wallyworld_not sure22:53
StevenKI was going to slaughter private_bugs22:53
StevenKIt's next week I'm off22:53
wgrantAh, right22:53
wallyworld_holiday?22:54
StevenKI'll be in Adelaide from Wednesday until the following Monday22:54
wgrantWow, Deployment-Ready is looking a bit sad22:54
wallyworld_wineries :-)22:54
wgrantSo, BVP and private_bugs are already limited to well-isolated chunks of code.22:57
wgrantWe'll want one person on each, I suspect22:58
wgrantAnd then a cleanup pass afterwards, particularly around BranchNamespace and co22:58
StevenKRight22:58
StevenKprivate_bugs can't die completly22:58
StevenKFor API compat :-(22:58
wgrantIndeed22:59
wgrantBut it becomes 'private_bugs = None'22:59
wgrantEr, False, I guess22:59
wallyworld_wgrant: i qa-ed that last remaining bug so we can deploy. i assume everyone's back on board this week?23:01
wgrantwallyworld_: Pretty much, though I suspect we'll have no APAC today23:02
wallyworld_too bad23:02
StevenKIt's the fly-home-from-London usual bug23:04
StevenKYou leave on Saturday afternoon and land Monday morning23:04
wgrantOuch23:11
wgrantLots of new bugs23:11
StevenKOMG, private_bugs is everywhere23:16
bigjoolsmorning daylightsaverers23:16
wgrantStevenK: Shouldn't be23:17
wgrantStevenK: In FileBugGuidedView, a few bits in the Product model and forms23:17
wgrantHm, maybe one bit in person as a precursor to the commercial-owning check?23:17
wgrantYeah23:17
StevenK% bzr st | wc -l23:18
StevenK1123:18
StevenKSo far23:18
StevenK 10 files changed, 20 insertions(+), 268 deletions(-)23:18
StevenKlib/lp/bugs/scripts/bugimport.py:        # If the product has private_bugs, we force private to True.23:19
StevenKwgrant: ^23:19
StevenKFor example23:19
wgrantOh right, that one23:19
wgrantI never quite worked out what to do with that23:19
wgrantbut still23:20
wgrantwgrant@lamuella:~/launchpad/lp-branches/devel$ bzr grep -l private_bugs | grep -v -E '/(tests|doc|stories)/' | grep -v ^database | wc -l23:20
wgrant923:20
wgrantThere's not much there23:20
wgrantbigjools: Are you glad your curtains are unfaded, and your cows remain undistressed?23:21
* bigjools blinks23:21
bigjoolsdo I detect a hint of resentment of DST ...23:22
wgrantDST is stupid, but the classical arguments against it are too :)23:22
bigjoolsFWIW I wish we had it here23:22
wgrantAw23:23
* wallyworld_ likes DST too23:23
bigjoolssun comes up at 5:20am and sets at nearly 6pm.  Would make more use of evening light.23:23
wallyworld_anyone know how to debug a unity launcher fu? ever since latest update, i can't some some apps eg konsole23:24
bigjoolsalthough at 38c like it was yesterday, hiding in my  basement makes no difference :)23:24
StevenKwgrant: Given I just ripped out the only use of private_project in lib/lp/bugs/model/tests/test_bug.py, I guess one of TestBugPrivateAndSecurityRelatedUpdatesP{rivate,ublic}Project can die too23:25
wgrant38!?23:25
wgrantIt never gets to 38 in October there, does it?23:26
wallyworld_it does with global warming23:26
bigjoolslol23:26
StevenKIt hit 34 here last week23:26
wgrantIt was 18 here :P23:26
bigjoolsI wonder why when temps are below averge nobody ever goes "global cooling!"23:27
wallyworld_because there's a monotonic, systemic warming going on23:27
bigjoolswrong, temps constaint globally for 10+ years23:28
bigjoolsconstant*23:28
wallyworld_my data is bigger than your data23:28
bigjoolsleave it zipped23:29
StevenKI think I'm done.23:39
StevenK 19 files changed, 32 insertions(+), 524 deletions(-)23:39
wgrantPlausible23:39
StevenKwgrant: private_bugs still appears 79 times in the tree -- it still has to be eradicated from database/, it's still in IProduct, and lots of tests that play with private bugs use private_bugs in their function name.23:40
wgrantYeah23:41
StevenKI may have deleted too much, but that's why we have version control.23:42
StevenKwallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/death-to-private_bugs/+merge/12839823:56
wgrantStevenK: Looking23:57
wgrantNote that we shouldn't land this quite yet, until we've confirmed that everything has both set23:58
wgranteg. newyork is still not done23:58
StevenKOh sure23:58
StevenKI was going to throw it at ec2 test and see how much carnage there is.23:58
StevenKWho's killing BVP?23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!