=== Ursinha is now known as Ursinha-afk === Ursinha-afk is now known as Ursinha === Ursinha is now known as Ursinha-afk === maxb_ is now known as maxb [22:42] wallyworld_: Morning [22:42] hello [22:43] wallyworld_: Not sure if you saw, but we both landed testfixes yesterday morning [22:43] We should probably revert one of them [22:43] yes :-( i wish you had let me do it [22:45] we should get a deployment done first perhaps to clear the backlog [22:45] Well, I waited 10 hours after the initial failure so decided you were probably doing something more weekendy during the weekend :P [22:45] We probably don't have webops until the UK wakes up [22:45] i did it before i went to bed. you can't expect me to do it during the night [22:45] i did it when i woke up [22:45] it wasn't your issue to fix [22:45] Hm? [22:45] Build failures are *everyone*'s issue to fix [22:46] That's why they block landings [22:46] sure, but i caused it so i was fixing [22:47] And I had a one-liner trivial fix that would mean you wouldn't have to care, so I thought I'd help you out and unbreak it [22:47] Sorry [22:48] me too. i did check and i didn't see anyone else landing anythng [22:49] so we sort of did it at the same time. [22:49] Yeah, you were only about half an hour later [22:49] Your fix is a little more comprehensive, but I think mine is more in the style that we've used elsewhere. [22:49] I'm not sure which wins [22:50] i reverted the caching because it can have unintended issues [22:50] but the one liner may be worth sticking with [22:50] Right [22:50] i do dislike how we put sql inside properties [22:50] To be completely correct we'd also need to invalidate on deletions and milestone retargetings [22:51] But I think those are probably OK to not care about here [22:51] yeah [22:51] my solution means that everything else except my use case uses the old way [22:52] there's a bigger design issue here though [22:52] which is out of scope for right now [22:52] so, we need to divvy up the bvm removal work [22:52] bvp [22:53] There's actually not that much to remove [22:53] private_bugs needs to go too [22:53] I forget if StevenK's here this week [22:53] not sure [22:53] I was going to slaughter private_bugs [22:53] It's next week I'm off [22:53] Ah, right [22:54] holiday? [22:54] I'll be in Adelaide from Wednesday until the following Monday [22:54] Wow, Deployment-Ready is looking a bit sad [22:54] wineries :-) [22:57] So, BVP and private_bugs are already limited to well-isolated chunks of code. [22:58] We'll want one person on each, I suspect [22:58] And then a cleanup pass afterwards, particularly around BranchNamespace and co [22:58] Right [22:58] private_bugs can't die completly [22:58] For API compat :-( [22:59] Indeed [22:59] But it becomes 'private_bugs = None' [22:59] Er, False, I guess [23:01] wgrant: i qa-ed that last remaining bug so we can deploy. i assume everyone's back on board this week? [23:02] wallyworld_: Pretty much, though I suspect we'll have no APAC today [23:02] too bad [23:04] It's the fly-home-from-London usual bug [23:04] You leave on Saturday afternoon and land Monday morning [23:11] Ouch [23:11] Lots of new bugs [23:16] OMG, private_bugs is everywhere [23:16] morning daylightsaverers [23:17] StevenK: Shouldn't be [23:17] StevenK: In FileBugGuidedView, a few bits in the Product model and forms [23:17] Hm, maybe one bit in person as a precursor to the commercial-owning check? [23:17] Yeah [23:18] % bzr st | wc -l [23:18] 11 [23:18] So far [23:18] 10 files changed, 20 insertions(+), 268 deletions(-) [23:19] lib/lp/bugs/scripts/bugimport.py: # If the product has private_bugs, we force private to True. [23:19] wgrant: ^ [23:19] For example [23:19] Oh right, that one [23:19] I never quite worked out what to do with that [23:20] but still [23:20] wgrant@lamuella:~/launchpad/lp-branches/devel$ bzr grep -l private_bugs | grep -v -E '/(tests|doc|stories)/' | grep -v ^database | wc -l [23:20] 9 [23:20] There's not much there [23:21] bigjools: Are you glad your curtains are unfaded, and your cows remain undistressed? [23:21] * bigjools blinks [23:22] do I detect a hint of resentment of DST ... [23:22] DST is stupid, but the classical arguments against it are too :) [23:22] FWIW I wish we had it here [23:23] Aw [23:23] * wallyworld_ likes DST too [23:23] sun comes up at 5:20am and sets at nearly 6pm. Would make more use of evening light. [23:24] anyone know how to debug a unity launcher fu? ever since latest update, i can't some some apps eg konsole [23:24] although at 38c like it was yesterday, hiding in my basement makes no difference :) [23:25] wgrant: Given I just ripped out the only use of private_project in lib/lp/bugs/model/tests/test_bug.py, I guess one of TestBugPrivateAndSecurityRelatedUpdatesP{rivate,ublic}Project can die too [23:25] 38!? [23:26] It never gets to 38 in October there, does it? [23:26] it does with global warming [23:26] lol [23:26] It hit 34 here last week [23:26] It was 18 here :P [23:27] I wonder why when temps are below averge nobody ever goes "global cooling!" [23:27] because there's a monotonic, systemic warming going on [23:28] wrong, temps constaint globally for 10+ years [23:28] constant* [23:28] my data is bigger than your data [23:29] leave it zipped [23:39] I think I'm done. [23:39] 19 files changed, 32 insertions(+), 524 deletions(-) [23:39] Plausible [23:40] wgrant: private_bugs still appears 79 times in the tree -- it still has to be eradicated from database/, it's still in IProduct, and lots of tests that play with private bugs use private_bugs in their function name. [23:41] Yeah [23:42] I may have deleted too much, but that's why we have version control. [23:56] wallyworld_, wgrant: https://code.launchpad.net/~stevenk/launchpad/death-to-private_bugs/+merge/128398 [23:57] StevenK: Looking [23:58] Note that we shouldn't land this quite yet, until we've confirmed that everything has both set [23:58] eg. newyork is still not done [23:58] Oh sure [23:58] I was going to throw it at ec2 test and see how much carnage there is. [23:59] Who's killing BVP?