wgrantStevenK: https://code.launchpad.net/~wgrant/launchpad/demolish-bvp/+merge/12861000:01
StevenKwgrant: lib/lp/code/browser/tests/test_branch.py the lp.code.enums import should be shrunk00:04
wgrantAh, and there were two ordering issues that appear to not have been my fault00:04
wgrantBut those were the only format-imports complaints00:05
wgrantAnd they are now fixed00:05
StevenKwgrant: I don't think you need the _is_private_team helper00:06
StevenKPeople are implicity public, so if self.private: should be fine00:06
wgrantWe usually check both00:07
StevenKwgrant: Looks great.00:10
=== matsubara is now known as matsubara-afk
=== _mup__ is now known as _mup_
wgrantOh good04:48
wgrantMy new terrible version of retry-depwait is 30% faster than the old one04:49
wgrantDespite my version considering several times more builds than it needs04:49
StevenKHow is still terrible?04:49
wgrantIt does just about no filtering in the core looptuner query04:49
wgrantSo it doesn't exclude obsolete series etc. until inside the main loop04:50
StevenKThat should be easy to be fix04:50
StevenKBut this is Soyuz04:50
bigjoolsthat old code is older than wgrant04:57
StevenKJust about04:58
StevenKwallyworld__, wgrant: https://code.launchpad.net/~stevenk/launchpad/sanity-check-bugwatch-bug-id/+merge/12862504:58
wallyworld__StevenK: can has comment inthe test as to what consistutes a valid/invalid bug number?05:41
wallyworld__maybe it's clear, but not from just looking at the diff05:42
wallyworld__s/bug number/bug url perhaps05:42
StevenKwallyworld__: http://pastebin.ubuntu.com/1268760/05:44
wallyworld__cool. thanks05:45
StevenKwallyworld__: Thanks05:45
StevenKwallyworld__: I was expecting a query about the usage of re.sub, TBH :-)05:46
wallyworld__why? seems ok to me05:46
StevenKwallyworld__: "Why are you doing it that way, that's terrible" etc :-)05:49
wallyworld__well, it's concise and it works, so meh05:49
wallyworld__and there's a comment in the test05:49
adeuringgood morning07:47
wgrantTest results: demolish-bvp => devel: SUCCESS08:48
StevenKAfter how many hours?08:51
wgrantThis was the third run today08:52
wgrantAdded sampledata... broke tests that depended on IDs of new stuff08:52
StevenKI just merged devel into mine, that was horrible08:53
dpmhi all, who can edit the VCS source for vcs-imports? I was looking at why translations weren't being imported from upstream's e-d-s and it seems it's because the VCS import is still set to SVN instead of git - could someone help me with editing the upstream source branch on https://code.launchpad.net/~vcs-imports/evolution-data-server/trunk ?10:13
maxbdpm: Members of ~vcs-imports - what would you like changed?10:17
wgrantdpm: You'll need to create a new import if the VCS has changed10:17
maxbIndeed - shall I rename the old one out of the way?10:18
dpmmaxb, if you could do that, that'd be great, thanks!10:19
maxbRenamed to old-svn-trunk and set to 'Merged' status so that it doesn't show up in the default branch listings10:20
maxbGo ahead and create a new import10:20
dpmmaxb, hm, how do I actually create a new import (I'm not a member of ~vcs-imports)?10:24
cjwatsondpm: https://help.launchpad.net/VcsImports10:25
dpmthanks cjwatson10:26
maxbhttps://code.launchpad.net/evolution-data-server , "Import a branch"10:26
maxbdpm: Under the new system of vcs import creation, the branch owner will be you or a team you are a member of if you select it - if you want the new import back at lp:~vcs-imports/evolution-data-server/trunk for consistency, let me know when you've created it and I'll move it over.10:30
dpmmaxb, https://code.launchpad.net/~dpm/evolution-data-server/trunk - if you could move it over to ~vcs-imports, that'd be great10:34
dpmthanks maxb10:39
cjwatsonIs there any pattern in Launchpad for a Job type that allows newly-created jobs to preempt existing ones in the middle of a long run of many jobs?11:53
cjwatsonThe usual iterReady implementations seem to compute the whole list of ready jobs up-front, which won't allow preemption.11:54
cjwatsonI could turn the relevant iterReady implementation into a generator and have it suck jobs out of the DB in batches or something, but it seems a bit ad-hoc and I was wondering if there was anything pre-existing for this11:55
wgrantcjwatson: I know of nothing like that already11:58
cjwatsonwgrant: OK, thanks :-/12:03
cjwatsonWould it be ridiculously OTT to glue in a looptuner?12:04
wgrantI don't think a looptuner's too useful or feasible there12:05
cjwatsonWhy infeasible?12:06
cjwatsonDoesn't really know the operation times, I suppose12:06
wgrantRight, and particularly with rabbitmq, it's reasonably important that if a job gets aborted then only that job gets aborted12:06
wgrantWhat benefit would a looptuner provide?12:06
cjwatsonNot having to pick a hardcoded chunk size12:06
wgrantThe operations will frequently fail. I'm not sure they can be sensibly batched like that.12:08
cjwatsonThey're already batched ...12:08
cjwatsonprocess-job-source (eventually) calls iterReady, gets a list of however many ready jobs there are back12:08
cjwatsonAll at once12:09
cjwatsonSo, OK, not so much batched as one giant batch12:09
cjwatsonBut failure is handled at the level of individual jobs anyway12:10
cjwatsonIt doesn't propagate out to the level of whatever calls iterReady12:10
wgrantRight, it doesn'12:11
wgrantt chunk AFAIK12:11
wgrantSo no point to a looptuner12:11
wgrantWe usually use a looptuner to get small transaction lengths without committing 1000x more often than necessary12:11
cjwatsonIt doesn't chunk at the moment, but in order to allow preemption in the middle of a few thousand jobs that arrived all at once, it needs to12:12
cjwatsonOr at least I don't see how to do that otherwise12:13
wgrantIs there likely to be a significant performance issue if you were to simply query for the head of the queue each time a job was needed?12:18
wgrantI'm not sure how terrible these queries tend to be12:18
=== frankban changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: frankban | Firefighting: - | Critical bugs: ~280
cjwatsonwgrant: Not too sure how I would tell.  All I can divine from logs is that it's usually sub-second12:27
tumbleweedfrankban: care for an easy one? https://code.launchpad.net/~stefanor/launchpad/retry-cancelled-build/+merge/12868313:19
frankbantumbleweed: sure13:20
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: frankban, rick_h | Firefighting: - | Critical bugs: ~280
tumbleweedfrankban: thanks. Would you mind landing it for me?14:03
frankbantumbleweed: yes, in a minute14:06
frankbantumbleweed: done14:24
tumbleweedfrankban: thanks again14:25
=== frankban changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: rick_h | Firefighting: - | Critical bugs: ~280
sinzuijcsackett, what bug are you looking at now?17:17
jcsackettsinzui: i'm exploring bug 994561 and bug 1007124 as they seem related. was reading through the code and going to ping you for thoughts in a few.17:18
_mup_Bug #994561: IndexError: string index out of range <dkim> <email> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/994561 >17:18
_mup_Bug #1007124: Incorrect padding <dkim> <email> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1007124 >17:18
jcsacketthappy to chat now though if you're free.17:18
=== deryck is now known as deryck[lunch]
=== deryck[lunch] is now known as deryck
=== slank` is now known as slank
tumbleweedto QA bug 1016337, I'd need a working PPA builder on a staging environment. Should I just not bother to QA it?19:39
abentleyrick_h_: Could you please review https://code.launchpad.net/~abentley/launchpad/private-product-listings/+merge/128800 ?19:39
rick_h_abentley: sure thing19:43
rick_h_abentley: are the conflicts listed anything to worry about?19:44
abentleyrick_h_: I don't think so.19:45
abentleyrick_h_: Okay, yeah, there's a problem-- I've modified code that's been deleted, and DB columns I've used have been renamed.19:48
rick_h_abentley: so _information_type is getting renamed back in my branch I sent to ec2 land this morning19:49
abentleyrick_h_: Okay, this is because of the rollback.19:49
rick_h_abentley: right19:49
rick_h_but yea, should we hold on this until abel finishes his update then?19:50
abentleyrick_h_: Yeah.  I'd normally mark his branch as a prerequisite, but it's not clear what his work-in-progress branch is.19:54
rick_h_abentley: ok, we'll catch up in the morning and I can look it over then.19:55
=== rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On call reviewer: - | Firefighting: - | Critical bugs: ~280
=== ccxCZ_ is now known as ccxCZ
* StevenK stabs OOPS pruning.21:37
StevenKClearly, I need to take a copy of the OOPS file to have any hope of reading them after linking them to a bug.21:37
lifelessStevenK: recent or old ?21:38
StevenKlifeless: https://bugs.launchpad.net/launchpad/+bug/956339 comment 121:38
_mup_Bug #956339:   IntegrityError: new row for relation "codeimport" violates check constraint "valid_vcs_details"  <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/956339 >21:38
lifelessStevenK: so old21:38
StevenKlifeless: Given neem has OOPSes back to 2012-06-12, I don't buy it.21:41
lifelessStevenK: we had that bug which wgrant fixed recently21:42
lifelessStevenK: where we were only keeping references made w/in the first 24 hours21:43
StevenKMmmm, I've been trying to recall how long the fix has been on neem.21:44
wgrantI think there may be another pruning bug21:45
wgrantBut it's not quite so bad, I don't think21:45
wgrantAnd I don't know what it is yet21:45
wgrantStevenK: When you run into a case from the last month or so, let me know and I will fix it.21:46
StevenKwgrant: Does the 24th of November count? :-)21:46
StevenKEr, September21:46
StevenKwgrant: bug 956339 comment 121:47
_mup_Bug #956339:   IntegrityError: new row for relation "codeimport" violates check constraint "valid_vcs_details"  <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/956339 >21:47
lifelessdid we have it deployed then? I thought it was a couple days later ;)21:48
wgrantIt was Sep 24 itself21:49
wgrantInteresting timing :)21:49
StevenKYeah, great. It's pruned the one OOPS again.21:50
wgrantWell, should be pretty easy to work out21:50
wgrantFind things that create codeimports21:50
wgrantLook at DB constraint21:51
wgrantSee how those codepaths could violate the DB constraint21:51
StevenKI did, on the day I linked that OOPS.21:51
StevenKIt looked pretty sane to me.21:51
wgrantStevenK: It may be useful to note that the most recent OOPS was not in fact from +new-import, but from +setbranch22:00
wallyworld_sinzui: StevenK: wgrant: jcsackett: mumble keeps hanging for me again, will keep trying22:04
=== matsubara is now known as matsubara-afk
StevenKNo OOPS mentioning ArchiveSubscriptionError either :-(23:47
StevenKwgrant: So I think what is probably happening is the valid_absolute_url call in the CHECK CONSTRAINT is failing, but I have no proof23:53

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!