MCR1 | didrocks: Hi :) Got 3 minutes ? | 07:09 |
---|---|---|
didrocks | MCR1: not really, already late for a meeting TBH… | 07:09 |
didrocks | I'm sure sil2100 or Mirv or upstream can help you :) | 07:10 |
MCR1 | didrocks: ok, no stress, thx-. | 07:10 |
MCR1 | duflu: Hi :) Have you seen bug 1067534 ? | 07:12 |
ubot5 | Launchpad bug 1067534 in Unity ""Show desktop" plug-in actually works with Unity when ensured that it is loaded after unityshell" [Undecided,New] https://launchpad.net/bugs/1067534 | 07:12 |
MCR1 | I swear it will be the last showdesktop related fix for a while ;) | 07:13 |
MCR1 | smspillaz: Are you here ? | 07:15 |
bschaefer | MCR1, heey sorry still have a broken unity haha | 07:16 |
MCR1 | bschaefer: Now I can tell you, that you should go to sleep, haha :) | 07:16 |
bschaefer | MCR1, yeeah | 07:17 |
MCR1 | Which time do you have now ? | 07:17 |
bschaefer | umm a bit after midnight | 07:17 |
bschaefer | not to bad | 07:17 |
bschaefer | and on that note, im off to bed. | 07:18 |
bschaefer | MCR1, hopefully Ill get my unity up and running tomorrow (most of the problems are fixed now) | 07:18 |
MCR1 | I hope so too as you are my main Unity testing connection ;) | 07:18 |
MCR1 | sil2100, Mirv, Trevinho: Anyone here who has 3 minutes ? | 07:20 |
MCR1 | om26er: Hi :) Unity bugmaster is needed ! | 07:23 |
om26er | lol | 07:23 |
duflu | MCR1: Haven't looked yet. Too many emergencies today :( | 07:23 |
om26er | MCR1, hey | 07:23 |
duflu | (emergencies for developers, not for the 12.10 release :) | 07:24 |
MCR1 | duflu: Ok, thx - but it is easy - you would understand it in 1 minute... | 07:24 |
=== alan_g is now known as alan_g|afk | ||
=== alan_g|afk is now known as alan_g | ||
MCR1 | om26er: I fixed bug 1067534 and it would be nice if you could take a look and confirm the fix if possible... | 07:25 |
ubot5 | Launchpad bug 1067534 in Unity ""Show desktop" plug-in actually works with Unity when ensured that it is loaded after unityshell" [Undecided,New] https://launchpad.net/bugs/1067534 | 07:25 |
om26er | MCR1, just wondering, do minimize window previews work with this as well? | 07:28 |
MCR1 | You mean the Alt-Tab ones ? | 07:28 |
om26er | i.e. if a window is minimized does its preview appear in alt-` ? | 07:28 |
om26er | yeah | 07:28 |
MCR1 | I will check it, but they should. | 07:28 |
MCR1 | because they will still use the Unity code... | 07:29 |
MCR1 | but I will re-check that to make sure | 07:30 |
* om26er wonders if there was a show-desktop plugin in compiz why was it redone inside Unity | 07:30 | |
om26er | + I agree show desktop fade currently is Meh... | 07:31 |
MCR1 | om26er: I do not change any default behavior, just add the possibility to use showdesktop | 07:31 |
MCR1 | om26er: The test needs 3 minutes, because I have to reapply my fixes... | 07:32 |
MCR1 | om26er: Minimized window previews still work, just tested. :) | 07:34 |
om26er | MCR1, i am building your branches and see how it goes, will tell you in a bit | 07:36 |
MCR1 | om26er: As far as I know the internal fadetodesktop function had to be written because of the window previews in the Switcher... | 07:37 |
MCR1 | om26er: Thanks a lot. | 07:37 |
MCR1 | om26er: You will see show desktop sliding windows for the first time running with Unity-3d then... 8-) | 07:38 |
Trevinho | MCR1: need anything? :) | 07:58 |
Mirv | MCR1: I guess the need went by already? :) | 08:06 |
=== yofel_ is now known as yofel | ||
MCR1 | om26er: I have added test cases to the bug report :) | 08:20 |
om26er | MCR1, just saw, compiz have build now unity will | 08:20 |
MCR1 | Trevinho: Yes - could you make sure that my new fixes go to Precise as well, because otherwise there might be minor regressions for users who made showdesktop manually start after unityshell ? | 08:23 |
MCR1 | Trevinho: We now prevent the use of showdesktop together with unityshell, but we just have to ensure it is loaded after unityshell :) | 08:24 |
didrocks | this kind of setting doesn't change the load plugin order | 08:25 |
didrocks | it's only if you load ccsm | 08:25 |
didrocks | and remove/readd a plugin | 08:25 |
MCR1 | didrocks: It works perfectly though. | 08:26 |
didrocks | MCR1: maybe if you remove/add a plugin, but if you added it before, like as you said in precise | 08:26 |
didrocks | and the plugin is in the order before the unityshell one | 08:26 |
didrocks | this change won't impact anything | 08:26 |
didrocks | the plugin won't be loaded after | 08:27 |
didrocks | you will have to go to ccsm | 08:27 |
didrocks | and remove/readd a plugin | 08:27 |
MCR1 | didrocks: Yes - this is exactly what you have to do to enable showdesktop :) | 08:27 |
didrocks | MCR1: this won't fix for people in precise who already enabled it | 08:27 |
MCR1 | didrocks: Before it would not work - now it does | 08:27 |
MCR1 | didrocks: but they can fix it then by disabling and re-enabling | 08:28 |
didrocks | how it wouldn't work? | 08:28 |
didrocks | yeah | 08:28 |
MCR1 | didrocks: it simply would not work at all | 08:28 |
* didrocks just has an horrible doubt about the fix, suddently | 08:28 | |
didrocks | lte me check something | 08:28 |
MCR1 | I have added test cases | 08:29 |
didrocks | MCR1: did you try with the cube? | 08:29 |
MCR1 | didrocks: See here: https://bugs.launchpad.net/unity/+bug/1063171/comments/8 | 08:30 |
ubot5 | Ubuntu bug 1063171 in unity (Ubuntu Quantal) ""Fade to Desktop" and "Show desktop" plug-ins should be automagically disabled and hidden in CCSM if the Ubuntu Unity Plugin is enabled" [Undecided,In progress] | 08:30 |
* didrocks remembers of all the drama on bug #711561 | 08:30 | |
ubot5 | Launchpad bug 711561 in unity (Ubuntu) "Compiz won't allow Desktop Cube plugin to load with unity" [Wishlist,Fix released] https://launchpad.net/bugs/711561 | 08:30 |
didrocks | finally the fix was to https://code.launchpad.net/~alanbell/unity/removelargedesktopdependency/+merge/93687 | 08:30 |
MCR1 | didrocks: but this was a dependency change, no ? | 08:31 |
MCR1 | didrocks: I am doing a requirement "after" change. | 08:31 |
MCR1 | *just | 08:31 |
MCR1 | I have tested everything in 99 ways. No breakage nowhere - do not worry. :) | 08:32 |
didrocks | MCR1: just try with your previous fix (the one which is in SRU0) to have cube enabled please :) | 08:32 |
MCR1 | I have the cube enabled and it works | 08:32 |
MCR1 | also with my new fixes | 08:33 |
MCR1 | recent Unity and Compiz trunk | 08:33 |
MCR1 | I even have the most recent fix duflu made (cube top and bottom caps transparency) | 08:34 |
didrocks | MCR1: ok, and it was working with your previous fix as well? | 08:34 |
didrocks | MCR1: just the "+feature" one | 08:34 |
MCR1 | didrocks: I can ensure that everything works, yes | 08:34 |
davidcalle | Mirv, didrocks, are we still open for SRU0? | 08:35 |
didrocks | MCR1: please do :) | 08:36 |
* didrocks let Mirv answering | 08:36 | |
MCR1 | didrocks: ? | 08:36 |
didrocks | 10:34:58 MCR1 | didrocks: I can ensure that everything works, yes | 08:37 |
didrocks | -> please ensure it works with the SRU0 version :p | 08:37 |
didrocks | only the +feature one | 08:37 |
MCR1 | didrocks: Hmm, I currently do not have Precise here, just Quantal... | 08:38 |
didrocks | MCR1: I mean on Quantal | 08:38 |
om26er | MCR1, it seems i broke my install somehow | 08:38 |
om26er | by install compiz from source | 08:38 |
om26er | now i only have a desktop background :/ | 08:38 |
didrocks | MCR1: on quantal, try your +feature thingy (not the latest proposal, the previous one) | 08:38 |
didrocks | MCR1: and try to enable cube | 08:38 |
MCR1 | om26er: Oh sh*t, sorry for causing troubles - but I am sure that my changes did not cause that | 08:39 |
MCR1 | didrocks: Aye Aye, sir :) | 08:39 |
om26er | yeah ofcourse your changes are unrelated, i should build compiz more often ;-) | 08:39 |
didrocks | MCR1: thanks :) | 08:39 |
MCR1 | om26er: You could have changed just the xml files (3 lines) to test it :-[ - I should have told you that probably... | 08:40 |
sil2100 | davidcalle: what's up? | 08:40 |
* MCR1 has now disabled and re-enabled the cube and is sure it works 8-) | 08:43 | |
MCR1 | didrocks: Done. No regressions. | 08:43 |
didrocks | MCR1: ok, thanks! | 08:43 |
davidcalle | sil2100, heya. https://bugs.launchpad.net/unity-lens-photos/+bug/1058061 & https://bugs.launchpad.net/unity-lens-videos/+bug/1066957 Both fixes are already in trunk for the two lenses. | 08:43 |
ubot5 | Ubuntu bug 1058061 in unity-lens-photos (Ubuntu) "/usr/lib/unity-lens-photos/unity-lens-photos:TypeError:<module>:__init__:__init__:_get_accounts_for_service:constructor" [Undecided,New] | 08:43 |
ubot5 | Ubuntu bug 1066957 in Unity Videos Lens "[SRU] Default lenses results should appear above the shopping category" [Medium,In progress] | 08:43 |
Mirv | davidcalle: not really, everything packaged :) | 08:45 |
sil2100 | davidcalle: is it high-priority? | 08:45 |
Mirv | davidcalle: open for SRU-1, though! | 08:45 |
sil2100 | davidcalle: if it is, and also relatively safe, we can cherry-pick it and distro patch... | 08:45 |
Mirv | of course, it all depends on criticality | 08:45 |
sil2100 | But let Mirv decide ;) | 08:45 |
Mirv | davidcalle: is it the new video-lens commit? the package was done before it | 08:46 |
davidcalle | Mirv, sil2100, the first one is a random dbus crash for the Photos lens, which is quite frequent in errors.ubuntu.com and has been fixed by a release team member. It's high priority. | 08:47 |
Mirv | davidcalle: ok, we haven't been handling photo lens yet | 08:47 |
Mirv | regarding sru-0 | 08:47 |
Mirv | I'm cherry-picking the content order thing, as it was supposed to be done similar to the other lenses | 08:49 |
davidcalle | Mirv, about the video lens one, it's not high priority and there is a related fix by mhr3 in the SRU list I think, which makes it less visible. | 08:49 |
davidcalle | Mirv, but if you are ok with cherry picking it for sru-0, it's great | 08:50 |
Mirv | davidcalle: it's not marked high but it's pretty much wanted anyhow | 08:51 |
Mirv | didrocks: I'm updating the video lens packaging branch with the cherry pick soonish | 08:58 |
didrocks | Mirv: ok | 08:58 |
MCR1 | didrocks: The only regression I could possibly think of is that someone already has enabled showdesktop in CCSM although it does not work - I am not 100% sure what happens, but I will test this low-probability case also to make 1000% sure | 08:58 |
davidcalle | Mirv, thanks! | 08:59 |
MCR1 | didrocks: Probably Compiz/Unity will start normally and the conflict will just be visible to the user if he changes the showdesktop/fadedesktop settings in CCSM, but I'll check that case to make sure | 08:59 |
didrocks | MCR1: please ensure :) | 09:00 |
tsdgeos | Trevinho: added a test to https://code.launchpad.net/~aacid/unity/launcher_selection_changed_fix_1067358/+merge/129923 | 09:15 |
Trevinho | tsdgeos: looking | 09:23 |
MCR1 | didrocks: I tested the low-probability case also now :) - with success - if the plug-in showdesktop or fadedesktop is already enabled and then conflicts with unityshell after the update it will be ignored until the user changes his settings in CCSM - disabling and re-enabling will lead to a dialogue explaining the situation... | 09:23 |
didrocks | MCR1: excellent, thanks! | 09:23 |
MCR1 | didrocks: But ideally my new fix should go to SRU as well now... | 09:24 |
didrocks | MCR1: would be SRU1 | 09:24 |
MCR1 | didrocks: ok. | 09:24 |
tsdgeos | Trevinho: i'm not ultra happy with the way i "fake" the closing of the quicklist, but getting the quicklist to emit that ubus message meant lots of modifications of the existing code, so i went the "faking" way, i can try to make the needed modifications for the quicklist to send that message if you prefer | 09:24 |
Trevinho | tsdgeos: if you think it's a cleaner design, ok... For trunk it's better if we add the best code we can, for Q even not the cleanest solution is ok, until is working and tested | 09:26 |
MCR1 | didrocks: Do you know the showdesktop plug-in and its functionality ? | 09:27 |
Trevinho | tsdgeos: about the test... ProcessMessages can also stay as an TestLauncherController member function (so it is not lost between tests), and rename as ProcessUbusMessage... or smomething... | 09:27 |
didrocks | MCR1: sorry no, and TBH I'm really busy with serious upgrade issues right now | 09:27 |
tsdgeos | Trevinho: problem is, i need a way to get to the quicklist from the launchercontroller, which probably means making the _quicklist of LauncherIcon accessible via a function, not sure if we want that | 09:27 |
didrocks | with things we support officially | 09:27 |
MCR1 | didrocks: sure. Best wishes that everything works clean and without troubles from me ;) | 09:28 |
didrocks | thanks :) | 09:28 |
Trevinho | tsdgeos: about the tests | 09:29 |
Trevinho | 94+ ASSERT_EQ(last_selection_change, "Dash Home"); | 09:29 |
Trevinho | 98+ ASSERT_EQ(last_selection_change, "Ubuntu One"); | 09:29 |
Trevinho | They're correct until someone would not change the .desktop files we have by default in our testing launcherModel... Overall in the tests I've also tried not to be directly connected to that... Instead I think you should just compare these strings with the selected icon's text you expect to have there | 09:29 |
Trevinho | tsdgeos: it should be trivial to do, just ensure that the icon in the model that should be selected matches that text | 09:29 |
tsdgeos | ok | 09:29 |
tsdgeos | ok, fixed strings and the processmessages function | 09:36 |
tsdgeos | let's see how ugly is to get to the quicklist to close it from there | 09:36 |
jokerdino | hey devs, how do i restart unity inside unity.cmake without using subprocess? | 09:39 |
Trevinho | jokerdino: inside cmake? | 09:40 |
jokerdino | hm yes. | 09:40 |
Trevinho | jokerdino: mh, I just run unity in a shell.. | 09:40 |
jokerdino | i am putting back unity --reset and was wondering if i really have to subprocess unity | 09:40 |
jokerdino | http://paste.ubuntu.com/1284694/ | 09:41 |
didrocks | jokerdino: just call the function to start it, there is one :) | 09:41 |
jokerdino | the process_and_start_unity() ? | 09:41 |
didrocks | jokerdino: well, the current code should be fine | 09:42 |
didrocks | you call your code in the optoin | 09:42 |
mhr3 | didrocks, didn't you have lots of concerns about compiz and resetting dconf? | 09:42 |
didrocks | don't exit, then you have run_unity() which is called | 09:42 |
jokerdino | hm alright then. thanks! | 09:42 |
didrocks | mhr3: good catch! jokerdino: what I did before is to stop unity/compiz first | 09:43 |
didrocks | mhr3: because resetting the keys below compiz's feet isn't a good idea | 09:43 |
didrocks | jokerdino: ^ | 09:43 |
jokerdino | so, we stop unity / compiz? | 09:43 |
didrocks | jokerdino: so please do test that a lot, with changing plugins key (like adding new plugin, reset that) | 09:43 |
didrocks | if you don't want to stop unity/compiz | 09:43 |
didrocks | and see if the changes are picked | 09:43 |
jokerdino | yeah, i am going to compile from source and see how it goes :) | 09:44 |
didrocks | like, compiz doesn't roll back on shutdown | 09:44 |
didrocks | :) | 09:44 |
jokerdino | ok will get back when in doubt | 09:44 |
tsdgeos | Trevinho: updated to include the non-fake quicklist closing, what do you think? https://code.launchpad.net/~aacid/unity/launcher_selection_changed_fix_1067358/+merge/129923 | 09:51 |
jokerdino | didrocks: before i get to compiling, can you please check if i am sane enough? http://paste.ubuntu.com/1284718/ | 09:55 |
didrocks | jokerdino: it does look sane to me, just ensure about the "changing keys under compiz feet" | 09:57 |
jokerdino | i put in a killall compiz before resetting unity. | 09:57 |
jokerdino | but i'll test it out just in case | 09:58 |
Trevinho | tsdgeos: llooks good | 09:59 |
Trevinho | tsdgeos: approved | 10:00 |
tsdgeos | Trevinho: oki, i'll create the 6.0 one now | 10:00 |
Trevinho | tsdgeos: thansk | 10:02 |
=== mmrazik is now known as mmrazik|afk | ||
tsdgeos | Trevinho: here it comes https://code.launchpad.net/~aacid/unity/launcher_selection_changed_fix_1067358_for_6.0/+merge/130080 | 10:32 |
Trevinho | cool, approved | 10:41 |
=== mmrazik|afk is now known as mmrazik | ||
=== MacSlow is now known as MacSlow| | ||
=== MacSlow| is now known as MacSlow|lunch | ||
=== _salem is now known as salem_ | ||
=== MacSlow|lunch is now known as MacSlow | ||
=== dandrader is now known as dandrader|afk | ||
=== dandrader|afk is now known as dandrader | ||
tar-dingens | hi | 13:16 |
tar-dingens | i am using unity on ubuntu 12.10 with the fglrx driver on an amd radeon hd 5450 | 13:16 |
tar-dingens | i have tearing when moving windows but only in a small area in the top left | 13:16 |
tar-dingens | i can avoid this tearing when enabling tear free desktop in the catalyst control center but this makes some animinations really slow and laggy | 13:16 |
tar-dingens | for example the unity preview feature | 13:16 |
tsdgeos | Trevinho: so continuing to scratching my itches i've created https://code.launchpad.net/~aacid/unity/fix_panek_title_escaping_1067357/+merge/130111 that fixes the problem with the data of UBUS_LAUNCHER_SELECTION_CHANGED already being escaped and the double escaping made stuff like "d&inici" appear instead of "d'inici" | 13:32 |
tsdgeos | Trevinho: how would you suggest to unit test that? | 13:33 |
Trevinho | tsdgeos: unfortunately we don't have unit test for the panel yet... You can create one if you want, or use Autopilot | 14:00 |
Trevinho | tsdgeos: ah, one thing... Since you're there... I think that we actually should remove this: bold_label << "<b>" << _panel_title << "</b>"; | 14:01 |
Trevinho | the anel should be wrong only if the font is bold | 14:01 |
Trevinho | I think we're wrong in forcing this | 14:02 |
Trevinho | tsdgeos: also... | 14:02 |
Trevinho | 21- glib::String escaped(g_markup_escape_text(_panel_title.c_str(), -1)); | 14:02 |
Trevinho | This is wrong, tough... or if there's a maximized window with a special char, or an app name with a special key that won't work | 14:02 |
tsdgeos | Trevinho: i moved that up | 14:03 |
Trevinho | tsdgeos: ah, yeah... sorry, I thought you were adding that on the ubus callback | 14:03 |
Trevinho | sorry | 14:03 |
tsdgeos | well, i could "unescape" the ubus stuff | 14:03 |
tsdgeos | but i didn't find the unescape function | 14:04 |
tsdgeos | Trevinho: you sure i should mix the <b> thing with my fix? | 14:05 |
Trevinho | tsdgeos: well, since you're changing that function... | 14:05 |
tsdgeos | ok | 14:06 |
Trevinho | tsdgeos: however probably, even if it could lead to some code duplication just adding the unescaping inside OnLauncherKeyNavEnded and OnLauncherSelectionChanged could leave the refresh title cleaner, so we're sure the escaping is always done... | 14:09 |
tsdgeos | Trevinho: agreed, but do you know if there's a unescaping function? i couldn't find it | 14:09 |
Trevinho | isn't g_markup_escape_text working there? | 14:13 |
Trevinho | ahhh, wait... sorry | 14:15 |
didrocks | popey: do you have any news of the FTBFS in staging fixing? Nux is still in FTBFS state and makes unity FTBFS | 14:26 |
* popey looks | 14:29 | |
mhr3 | fginther, seems like this irc works better atm :) | 15:15 |
fginther | mhr3 indeed | 15:15 |
mhr3 | fginther, so what's up? | 15:15 |
fginther | mhr3, I migrated the auto merger for lp:unity-lens-videos/remote-videos-scope-trunk to a new jenkins job and it picked up a rather old MP of yours: | 15:16 |
fginther | https://code.launchpad.net/~mhr3/unity-lens-videos/fix-1058097/+merge/126956 | 15:16 |
fginther | mhr3 it failed due to a config issue on the builder host. But before I re-approve, I just want to check to see if this is still a valid MP | 15:16 |
* mhr3 tries to open | 15:18 | |
mhr3 | launchpad freezes | 15:19 |
davidcalle | mhr3, fginther, this fix is in distro, somehow. | 15:19 |
mhr3 | damn, i can't even access my mail | 15:20 |
amithkk | Hey | 15:22 |
davidcalle | mhr3, fginther, distro and trunk. Doesn't seem valid anymore. | 15:22 |
amithkk | https://code.launchpad.net/~amith/unity/unity-reset-fix/+merge/130146 | 15:22 |
amithkk | I've asked for a merge review | 15:22 |
amithkk | All the intendation errors have been fixed | 15:23 |
mhr3 | fginther, right, there's some merge mixup in that branch, but it was landed already | 15:23 |
fginther | mhr3, davidcalle. I agree. | 15:24 |
jokerdino | didrocks: can you take a look at the merge request? https://code.launchpad.net/~amith/unity/unity-reset-fix/+merge/130146 | 15:33 |
jokerdino | i accidentally fixed the weird indentation. is that alright? | 15:33 |
didrocks | jokerdino: yeah, I saw it, it looks good (and great for the identation fix) :) it just need the automated tests now | 15:34 |
jokerdino | okay. i'll write the tests now. :) thanks! | 15:34 |
didrocks | jokerdino: otherwise, all looks good to me! good work :) | 15:34 |
didrocks | jokerdino: just ensure that it's well tested with changing a lot of keys and getting reset called (with changing plugins list for instance) | 15:35 |
jokerdino | okay. i'll take a look at the current tests and use it as a template :) | 15:35 |
didrocks | as compiz has a history to not like changing the config under its feet :) | 15:35 |
didrocks | :) | 15:35 |
didrocks | good luck! | 15:35 |
amithkk | didrocks: happens with custom plugins | 15:35 |
jokerdino | okay noted. also didrocks, should unity --reset reset to the default compiz plugis? | 15:35 |
didrocks | jokerdino: yeah, I think so | 15:35 |
didrocks | jokerdino: like some people are lost by enabling a conflicting plugin in ccsm | 15:35 |
didrocks | and no more unity | 15:35 |
jokerdino | ok, in that case, we need to do add a couple more lines then. | 15:36 |
amithkk | \o/ | 15:36 |
didrocks | so reset should give the supported configuration back | 15:36 |
amithkk | one more doubt didrocks | 15:36 |
didrocks | yes? ;) | 15:36 |
amithkk | in the lines with | 15:36 |
amithkk | if options.reset_icons: | 15:37 |
amithkk | reset_launcher_icons () | 15:37 |
amithkk | shouldnt it be if options.reset-icons | 15:37 |
amithkk | so that it follows the other args? | 15:37 |
amithkk | didrocks: --^ | 15:38 |
didrocks | one sec :) | 15:38 |
didrocks | amithkk: the option is --reset-icons | 15:38 |
didrocks | then, it's translated to options.reset_icons by optparse | 15:38 |
amithkk | I see | 15:39 |
didrocks | because you can't have: var-like-that in python | 15:39 |
amithkk | ooh I never know that | 15:39 |
amithkk | \o/ | 15:39 |
amithkk | Thanks | 15:39 |
didrocks | you learn it soon enough and hardly normally :-) | 15:39 |
didrocks | yw! | 15:39 |
MCR1 | didrocks: because we are talking about Compiz and plug-ins here, do you have 3 minutes to take a look at a 3 line fix ? | 15:43 |
didrocks | MCR1: still configuration change? :p | 15:43 |
MCR1 | no, still showdesktop stuff :P | 15:44 |
didrocks | MCR1: I hardly have the time to once again build and test compiz today TBH :p | 15:44 |
didrocks | I can give you my opinion though :) | 15:44 |
MCR1 | you do just need your logic - it is tested already by me and om26er | 15:44 |
MCR1 | bug 1067534 | 15:44 |
ubot5 | Launchpad bug 1067534 in Unity ""Show desktop" plug-in actually works with Unity when ensured that it is loaded after unityshell" [Undecided,New] https://launchpad.net/bugs/1067534 | 15:44 |
MCR1 | the branches fixing it are linked :) | 15:45 |
MCR1 | https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1067534/+merge/130001 and | 15:45 |
MCR1 | https://code.launchpad.net/~mc-return/unity/unity.merge-fix1067534/+merge/129999 | 15:46 |
MCR1 | didrocks: Short description: Makes showdesktop plug-in work with Unity-3d for the first time :) | 15:46 |
didrocks | MCR1: it looks good to me, but I don't ack branch I don't test :) | 15:46 |
MCR1 | didrocks: ok, thx a lot. | 15:48 |
didrocks | yw ;) | 15:49 |
=== dandrader is now known as dandrader|lunch | ||
davidcalle | sil2100, Mirv, about the Photos lens SRU, is it on track? Should I do anything to help? | 15:58 |
sil2100 | davidcalle: not sure how Mirv, but from what I know up until now we didn't really take care of the photo lens - Mirv ^ ? | 15:59 |
balloons | ping thomi | 16:14 |
om26er | aint that too early for him ? | 16:18 |
balloons | it's hard to know early from late :-) | 16:18 |
ahayzen | Hi, anyone know how to close the Unity.MusicPlayer in Python 3 correctly as I am getting errors back the second time I open? Many thanks, Andy | 16:37 |
andyrock | Mirv, ping | 16:42 |
sil2100 | andyrock: I think Mirv is EOD already | 16:44 |
andyrock | sil2100, ok thank you... :) | 16:44 |
andyrock | sil2100, https://bugs.launchpad.net/unity/+bug/1067742 | 16:44 |
ubot5 | Ubuntu bug 1067742 in Unity "Failing make check test: TestUnitySettings.FormFactorChangedSignal_Extern_OtherKeys" [Undecided,New] | 16:44 |
andyrock | can you reproduce it? | 16:44 |
sil2100 | andyrock: looking | 16:45 |
andyrock | it's a failing test | 16:45 |
sil2100 | andyrock: I remember having some problems, but I'll check now, one moment | 16:46 |
andyrock | yeah there is a crash in Launcher.DNDsomethig | 16:46 |
andyrock | *thing | 16:46 |
andyrock | can't remember the name atm | 16:46 |
popey | andyrock, is there a way to trigger it for that specific test? if I run "make check" it segfaults after a load of tests | 16:47 |
andyrock | popey, you can do ./test/test-gtest --gtest_filter="..." | 16:47 |
andyrock | in you build directory | 16:47 |
andyrock | *your | 16:47 |
popey | where ... is the name of the test andyrock ? | 16:49 |
andyrock | yup | 16:49 |
andyrock | something like that | 16:49 |
andyrock | TestLauncher.* | 16:49 |
popey | k | 16:50 |
* sil2100 is building | 16:51 | |
popey | andyrock, do you mean ./tests/test-gtest-something? dbus/service/xless? | 16:53 |
andyrock | yup | 16:53 |
popey | which? :) | 16:54 |
popey | there's three there | 16:54 |
andyrock | which test do you want to run? | 16:54 |
=== dandrader|lunch is now known as dandrader | ||
popey | I don't know, you're asking me to reproduce an issue :) | 16:54 |
om26er | th th th ? | 16:54 |
sil2100 | ;) | 16:54 |
sil2100 | 26%... | 16:55 |
andyrock | popey, sil2100 /tests/test-gtest --gtest_filter="TestUnitySettings.FormFactorChangedSignal_Extern_OtherKeys" | 16:55 |
andyrock | :) | 16:55 |
popey | there is no such file tests/test-gtest | 16:55 |
popey | thats my point, there's ./tests/test-gtest-dbus ./tests/test-gtest-service and ./tests/test-gtest-xless | 16:56 |
andyrock | mmm do you have google-mock installed? | 16:58 |
popey | yes | 16:58 |
popey | bah | 16:58 |
popey | lemme try again | 16:58 |
andyrock | this is weird | 16:59 |
popey | no, its my fault | 16:59 |
andyrock | that command works for me | 16:59 |
sil2100 | andyrock: I'm still building the source eh | 16:59 |
sil2100 | 53% | 16:59 |
andyrock | sil2100, i think that popey get the crash in TestLauncher.* | 17:00 |
popey | andyrock, http://paste.ubuntu.com/1285411 | 17:00 |
andyrock | because | 17:00 |
popey | bah | 17:00 |
popey | typo | 17:00 |
andyrock | he did | 17:00 |
andyrock | cmake .. | 17:01 |
andyrock | and make check | 17:01 |
popey | andyrock, http://paste.ubuntu.com/1285413 | 17:01 |
andyrock | so the launcher can't find the assets | 17:01 |
andyrock | popey, cool the test is ok | 17:01 |
andyrock | popey, i need to ping Mirv tomorrow | 17:01 |
popey | andyrock, I do get segfaults tho | 17:02 |
popey | andyrock, http://paste.ubuntu.com/1285416 | 17:02 |
andyrock | popey, yeah your PKGDATADIR is not correctly setted | 17:03 |
popey | O RLY | 17:03 |
andyrock | i think that make install | 17:03 |
andyrock | should fix2 your | 17:03 |
andyrock | "fix" | 17:03 |
andyrock | issue | 17:03 |
andyrock | of course unity should not crash if the launcher can't fint the png assets | 17:04 |
* popey tries | 17:04 | |
sil2100 | popey: oh | 17:04 |
sil2100 | I always run cmake -DCMAKE_INSTAL_PREFIX=/usr ../ | 17:04 |
popey | and -j256 yeah? | 17:06 |
andyrock | ahahh | 17:06 |
popey | :þ | 17:06 |
sil2100 | I only have 4 :( | 17:06 |
sil2100 | ;p | 17:06 |
andyrock | sil2100, https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1062287 | 17:12 |
ubot5 | Ubuntu bug 1062287 in unity (Ubuntu) "Week 40 - The device launcher icon does not appear in the launch" [Undecided,New] | 17:12 |
andyrock | that manual test has been removed in unity trunk and 6.0 | 17:12 |
popey | thanks andyrock will get it removed | 17:12 |
popey | their test database is not up to date, will sync it | 17:13 |
andyrock | popey, ah ok :) | 17:13 |
andyrock | om26er, ping | 17:25 |
om26er | andyrock, hey | 17:26 |
andyrock | om26er, https://bugs.launchpad.net/unity/5.0/+bug/1036231/comments/15 | 17:27 |
ubot5 | Ubuntu bug 5 in Launchpad itself "Plone Placeless Translation Service metadata missing from po files" [Low,Fix released] | 17:27 |
andyrock | ubot5 is wrong :) | 17:27 |
om26er | andyrock, yeah, what about that comment ? | 17:28 |
om26er | andyrock, is that possible for you to work on a fix for precise? | 17:28 |
andyrock | om26er, are you really sure that bugs affects unity/5.0 too? | 17:28 |
andyrock | i don't have a precise machine ATM | 17:29 |
om26er | well it should afaik it has been there since launcher was resizable,, | 17:29 |
* om26er tries | 17:29 | |
om26er | yeah definitely there | 17:30 |
om26er | its not that important, i just saw it was a one liner so though we should backport | 17:31 |
andyrock | yeah i'll backport it :) | 17:32 |
andyrock | thank you | 17:32 |
MCR1 | Trevinho: Thanx 4 approving my branches, but it seems now Jenkins has problems - I think they need re-approval (E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/a/atk1.0/libatk1.0-data_2.5.91-0ubuntu1_all.deb: 404 Not Found [IP: 91.189.92.184 80]) | 17:43 |
=== dandrader is now known as dandrader|afk | ||
=== dandrader|afk is now known as dandrader | ||
=== alecu_ is now known as alecu | ||
=== salem_ is now known as _salem |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!