| karni | Finished a bad ass action bar hack for the 'now playing' item. Something to some folks on stack overflow said "impossible". impossible reads "I'm-possible" | 02:20 |
|---|---|---|
| karni | I think patricia will be happy with this. | 02:20 |
| karni | /s/patricia/Patricia | 02:20 |
| karni | damn. overheated my laptop with eclipse and yt music in background :/ Not the first time.. | 02:35 |
| karni | oh well.. I guess I should call it a day. | 02:36 |
| karni | Night all! | 02:37 |
| === mmcc_ is now known as mmcc | ||
| === jamesh_ is now known as jamesh | ||
| === yofel_ is now known as yofel | ||
| mandel | morning all! | 08:06 |
| JamesTait | Good morning all! :-D | 08:36 |
| gatox | good morning! | 11:03 |
| karni | Good morning o/ | 11:31 |
| gatox | karni, hi! | 11:32 |
| karni | hiya gatox o/ | 11:32 |
| gatox_ | back | 12:10 |
| === gatox_ is now known as gatox | ||
| gatox | light went off for a second | 12:11 |
| ralsina | hello *.*! | 12:21 |
| gatox | ralsina, hi | 12:21 |
| karni | :) | 12:21 |
| alecu | ralsina: that sounded sooo DOS. | 12:23 |
| alecu | hello all, too! | 12:23 |
| karni | For a second, I thought it was a face ^.^`! | 12:24 |
| gatox | alecu, hello | 12:25 |
| ralsina | alecu, mvo: quick mumble? | 12:26 |
| alecu | ralsina: any time | 12:26 |
| mvo | ralsina: in 4 minutes? just need to look for my headset and tea | 12:27 |
| ralsina | mvo: sure! | 12:27 |
| alecu | 4 minutes sounds like the right tea brewing time! | 12:29 |
| mandel | he.. | 12:30 |
| ralsina | alecu: can you hear me? | 12:31 |
| mandel | ok, time for my lunch :) | 12:39 |
| === mandel is now known as mandel|lunch | ||
| ralsina | alecu: so that was not very informative, want to cntinue the call? You sounded like you had somethingimportant to say :-) | 12:51 |
| dobey | hmm | 13:09 |
| alecu | ralsina: pong | 13:24 |
| alecu | ralsina: just wanted to discuss deadlines | 13:24 |
| alecu | ralsina: shall we mumble again? | 13:24 |
| ralsina | alecu: you are invited to the next call | 13:24 |
| ralsina | alecu: no, check your calendar, we have a hangout right now :-) | 13:24 |
| alecu | ouch | 13:25 |
| ralsina | alecu: we can discuss that right after | 13:25 |
| === m_conley_away is now known as m_conley | ||
| joshuahoover | ralsina: are we still doing the usual weekly call at 15:00 utc today or is that changing? | 13:45 |
| rye | ralsina: ActivationTimeoutError - i have logs but I don't see syncdaemon erroring out being unable to create socket or something (if it actually does that) - how can I debug this? | 13:47 |
| karni | joshuahoover: Client Engineering (old Desktop +) has a call at 3 UTC, yes | 13:47 |
| joshuahoover | karni: thanks :) | 13:47 |
| karni | :) | 13:47 |
| ralsina | joshuahoover: that call is still there yes | 13:51 |
| ralsina | alecu, mvo: mumble again? | 13:51 |
| alecu | ralsina: sure | 13:51 |
| mvo | ralsina: sure, | 13:52 |
| rye | i guess i see a bug | 14:07 |
| dobey | rye: plausible | 14:08 |
| rye | so if 53001 port is unavailable for syncdaemon, the latter will not start, not quite the bug I am seeing but it should be noted somewhere | 14:19 |
| dobey | 53001? | 14:22 |
| alecu | dobey: that's on windows and mac | 14:30 |
| dobey | oh is that the ipc port? | 14:31 |
| balloons | is anyone about who could help figure out why my plan doesn't see my extra storage beyond the initial 5 gig? | 14:32 |
| dobey | balloons: the canonical plan? cancel and resubscribe to the canonical plan, and it should fix it | 14:33 |
| balloons | dobey, yes | 14:33 |
| balloons | dobey, huzzah | 14:33 |
| balloons | lol.. I didn't realize I could manually add it back | 14:34 |
| balloons | d'oh.. ty | 14:34 |
| dobey | sure :) | 14:34 |
| rye | alecu: we don't re-select port if it is taken. Well, haven't seen any cases when this was actually preventing U1 from working though | 14:35 |
| === mandel|lunch is now known as mandel | ||
| mandel | rye, I see that you sent an email asking to foward the apple email to certain people and you did not include my email, is that on purpose? | 14:37 |
| chaselivingston | mandel: oops, probably not. i bet ralsina just overlooked your name in the list | 14:38 |
| mandel | oh, ok :) | 14:38 |
| chaselivingston | rye: can you update that rt? | 14:38 |
| rye | chaselivingston: yep | 14:39 |
| ralsina | mandel: I was not expecting you to care much about mac dev. this cycle, that's all | 14:40 |
| mandel | ralsina, ok, I was just wondering.. but I guess I have dash written all over my forehead then ;-) | 14:40 |
| ralsina | mandel: I am getting a branding iron that says dash for the sprint | 14:41 |
| mandel | hahaha | 14:41 |
| rye | chaselivingston: mandel, done | 14:41 |
| chaselivingston | ralsina, mandel: that sounds painful... | 14:41 |
| mandel | rye, thx! | 14:41 |
| ralsina | chaselivingston: only when you use it! | 14:41 |
| briancurtin | ralsina: we can give mandel a new girlfriend: http://www.shoppingwithles.com/wp-content/uploads/2012/05/Mrs-Dash.jpg | 14:42 |
| chaselivingston | ralsina: i'm staying away from you at the sprint ;) | 14:42 |
| briancurtin | (safe for work, obv) | 14:42 |
| dobey | lol | 14:42 |
| mandel | lol | 14:42 |
| mandel | briancurtin, I expected a NSFW though .. | 14:42 |
| mandel | specially when working from home hehe | 14:42 |
| rye | ralsina: mandel, have you ever seen a failure for a tcp listening socket to be set up but the connections being blocked? | 14:43 |
| mandel | rye, is that on windows or mac? | 14:43 |
| gatox | ralsina, do we have the team meating in 15'? | 14:44 |
| dobey | gatox: yes | 14:44 |
| gatox | dobey, thx | 14:44 |
| dobey | mvo: hey, are you going to UDS? | 14:44 |
| ralsina | rye: sounds like a firewall issue | 14:45 |
| rye | mandel: that's on mac, ralsina/mandel do you want to see the logs? I don't really know where to look further except adding the debug statements | 14:46 |
| mvo | dobey: yes | 14:46 |
| mandel | rye, please, I might be able to deduce something | 14:46 |
| dobey | ralsina: ^^ i guess mvo might need to attend some specific sessions for the team? :) | 14:47 |
| ralsina | dobey: yes, we have been talking about the sprint before UDS but we also need to discuss that | 14:48 |
| mvo | ok | 14:48 |
| dobey | ah | 14:48 |
| mandel | mvo, are you in copenhaguen next week then? | 14:49 |
| mvo | mandel: yes, for the first days | 14:50 |
| mandel | mvo, I'll be there from tuesday to friday, we should meet at some point, I suppose we are attending the same things | 14:50 |
| mvo | mandel: sounds great, we overlap tuesday and parts of wednesday :) | 14:51 |
| mandel | mvo, awesome! will somehow ping you when I'm there | 14:51 |
| mandel | rye, the log for the exceptions are missing, right? | 14:52 |
| mandel | rye, the interesting thing is that if you look at the sd logs it does not go further than: 2012-10-11 10:13:28,437 - ubuntuone.SyncDaemon.OffloadQueue - DEBUG - Using temporary file: 'd:\\temp\\tmpfa0oa2' | 14:53 |
| mandel | rye, I wonder if there is an exception wither when starting the ipc or any other part and the event that states that everything is ready is never sent to the state machine | 14:54 |
| mandel | rye, then, you or course have time outs when trying to connect from the control panel and sd does nothing | 14:54 |
| mmcc | hey folks. | 14:55 |
| mmcc | mandel: rye are you guys talking about windows or mac? I can't tell. | 14:56 |
| mandel | mmcc, in this case, windows, but I guess is a bug that can happen in mac too | 14:56 |
| mmcc | mandel: what is the bug? | 14:56 |
| mandel | mmcc, control panel has activation errors due to timeputs | 14:57 |
| mandel | sorry, timeouts | 14:57 |
| mandel | mmcc, something like the following: SyncDaemonClientConnectionError: ('Could not connect to the syncdaemon ipc.', ActivationTimeoutError()) | 14:57 |
| mmcc | ok. so syncdaemon isn't starting up or the IPC is blocked, right? | 14:58 |
| mmcc | remember that on darwin, we use unix domain sockets for the IPC so we avoid firewall issues. no TCP. | 14:59 |
| rye | mandel: i wonder what should be printed next - is this the part where IPC is created? | 14:59 |
| mandel | rye, hm.. we can always check with a working sd logs :) | 14:59 |
| mandel | rye, mmcc, last time I saw that was an exception in main before the state machine started, the app keep running because the twisted reactor does not end but is doing nothing | 15:00 |
| mandel | no ipc, no file monitor watching etc.. | 15:00 |
| dobey | mumble | 15:01 |
| dobey | ralsina: ? | 15:01 |
| rye | mandel: after that tunnel process is started - that's for sure, can subprocess.Popen hang? | 15:01 |
| ralsina | sorry guys, a bit late, going there now | 15:02 |
| mandel | rye, how is popen used, could be that the buffers of stdout and stderr are full and block | 15:03 |
| mandel | rye, form the docs: Warning This will deadlock if the child process generates enough output to a stdout or stderr pipe such that it blocks waiting for the OS pipe buffer to accept more data. Use communicate() to avoid that. | 15:04 |
| mandel | do I make sense? | 15:04 |
| rye | mandel: right, but the tunnel process logs show that it is started and the output is quite small there | 15:04 |
| mandel | rye, it is one of the possible cases.. | 15:04 |
| rye | it still hangs somewhere. If it can't create socket because something is already there it will simply say "Another instance is running" | 15:05 |
| mandel | rye, well, the socket is created by sd, so if it was not created you get the time out | 15:05 |
| mandel | rye, else | 15:05 |
| rye | mandel: but SD will complain | 15:05 |
| mandel | rye, in which case? | 15:07 |
| rye | mandel: in case socket is already taken | 15:07 |
| mandel | rye, yes, if the port is already taken we will change it, right alecu? | 15:07 |
| rye | mandel: control panel will try to communicate and get the failure but SD will definitely say | 15:07 |
| rye | mandel: nope | 15:07 |
| mandel | rye, no really, it will look for a new one and control panel will know the new port | 15:08 |
| rye | mandel: nope, will say "Another instance is already running" and quit | 15:09 |
| mandel | rye, hm.. well cleary that is not the case atm | 15:10 |
| mandel | rye, give me some mins, we are on a meeting | 15:10 |
| mmcc | brb, coffee time | 15:35 |
| mandel | alecu, dude, when he talks he sounds like a dude! | 15:35 |
| alecu | mandel: you should definitely check out that movie. | 15:36 |
| alecu | mandel: it will set up the tone for your vacations | 15:36 |
| gatox | mandel, don't trust in the movies that alecu watch! | 15:36 |
| mandel | alecu, does look very good | 15:37 |
| mandel | alecu, this one confused me a lot: http://www.youtube.com/watch?v=u_UGl60FHtg&feature=related | 15:37 |
| mandel | gatox, we have similar tastes.. although I usually find most of them funny when they are not hehe | 15:37 |
| ralsina | mandel: http://en.wikipedia.org/wiki/Brokedown_Palace | 15:39 |
| mandel | ralsina, yes, I have seen that.. is the only thing I'm scared of | 15:40 |
| mandel | I will also try to sneak a monkey to europe :) | 15:41 |
| ralsina | mandel: you afraid of "meet a captivating Australian man, who calls himself Nick Parks (Daniel Lapaine). He befriends the girls and uses romantic charm to gain their trust. He claims he works for a software company.." | 15:41 |
| mandel | ralsina, I always fall for captivating australian software eng ;) | 15:41 |
| mandel | ralsina, new line for the employee manual -> Will manuel find it funny? If yes, don't say it | 15:42 |
| mandel | hehehe | 15:42 |
| ralsina | mandel: I'll tell james ;-) | 15:42 |
| dobey | ok, need to get lunch. bbiab | 15:45 |
| JoseExposito | urbanape, do you know if this is a U1 patch? http://bazaar.launchpad.net/~ubuntuone-ios-client-team/ubuntuone-ios-files/trunk/view/head:/Dependencies/oauthconsumer/Categories/NSMutableURLRequest%2BParameters.m#L40 | 16:03 |
| karni | I'm going to get lunch as well. | 16:05 |
| mmcc | hey briancurtin , running from source on windows I get a ton of this: http://paste.ubuntu.com/1287180/ does that look familiar? | 16:08 |
| mmcc | I was testing the systray sync menu on windows, since it'll probably still use the qt implementation and we should make sure it works before your impending release (And I have code to fix it) | 16:09 |
| briancurtin | mmcc: some other u1 processes are probably still running. shutting down u1cp after its tarted everything up doesnt cleanly shut everything else down | 16:09 |
| mandel | ok, I need to go to the airport, catch you all tom! | 16:10 |
| briancurtin | mmcc: i tend to use ProcExp from sysinternals to show process trees of what is running, which is especially helpful in this case where a python script is running that was started by python-script.py which was started by python.exe which was started inside cmd.exe | 16:10 |
| * mmcc googles procexp | 16:12 | |
| briancurtin | process explorer is the full name, but i believe its procexp.exe | 16:13 |
| briancurtin | mmcc: http://technet.microsoft.com/en-us/sysinternals/bb896653 is where to find it | 16:13 |
| urbanape | JoseExposito: how do you mean? | 16:14 |
| urbanape | It was not written by the U1 folks, no | 16:14 |
| mmcc | briancurtin: thanks! | 16:15 |
| JoseExposito | urbanape, I ask about the TODO | 16:20 |
| JoseExposito | with the new OAuthConsumer the PUT queries fails | 16:21 |
| JoseExposito | and it looks like this patch solve the problem | 16:21 |
| JoseExposito | but I think that fails with ShareKit (I'm trying to add share in Facebook, Twitter... features) | 16:21 |
| * gatox lunch | 16:24 | |
| === gatox is now known as gatox_lunch | ||
| mmcc | brb, baby watch for a few minutes | 16:29 |
| ralsina | lunch break for me | 17:10 |
| briancurtin | lunch as well | 17:17 |
| * karni is back | 17:19 | |
| === gatox_lunch is now known as gatox | ||
| mmcc | do we have a client-eng mailing list yet? | 17:44 |
| mmcc | I have an email about music client integration that maybe doesn't have to go to everyone in ubunet | 17:44 |
| dobey | we don't | 17:44 |
| dobey | ralsina: should we set one up? | 17:44 |
| dobey | ugh, flights suck. | 17:45 |
| mmcc | dobey: suck how? you have to do a multi-hop from a small airport or something? | 17:46 |
| dobey | the return flight options are all awful. | 17:47 |
| dobey | to leave in the afternoon, i'd have to get a 13+ hour layover in atlanta | 17:47 |
| dobey | for reasonable layover, have to leave early :-/ | 17:48 |
| chaselivingston | dobey: ouch. i'm flying through atlanta, but i don't think my layover is that bad | 17:48 |
| dobey | chaselivingston: heh, we'll it's just the return flight that's horrible. flying to lhr is fine; leave at like 4:30, spend a couple hours in atl, and get to london at noon on sunday | 17:49 |
| mmcc | 13 hours in Atlanta, just enough time to go to the Coke museum! | 17:49 |
| dobey | but the returns are awful | 17:49 |
| chaselivingston | mmcc: you've got a point! | 17:49 |
| dobey | mmcc: i don't think it's open at midnight | 17:50 |
| dobey | the 13 hour layover is overnight | 17:50 |
| chaselivingston | dobey: ooohhh.... | 17:50 |
| mmcc | dobey: ouch. that *is* bad. besides, the coke museum was mostly a joke. Interesting but IIRC underwhelming | 17:51 |
| dobey | so instead, will have to get up insanely early, and hopefully can get there on public transit, rather than a $200 taxi ride | 17:52 |
| mmcc | OK so I'm just going to send this to ubunet-discuss and people who don't care about macs or client stuff can just ignore | 17:56 |
| dobey | hmm | 18:10 |
| chaselivingston | mmcc: great thoughts, would love to chat with you more about this when you begin working on it | 18:15 |
| mmcc | chaselivingston: OK, but note that aside from adding a symlink to ~/U1/ to ~/.ubuntuone/Purchased… , you may have just seen all of me working on it | 18:16 |
| chaselivingston | mmcc: haha, gotcha. didn't know if you were still pondering other ideas or not | 18:17 |
| mmcc | chaselivingston: I am pondering, but probably not during work hours. I kind of like the local DAAP server idea for getting iTunes to work, but i'm not going to spend any time on it until they release the next iTunes, because it might be a total waste | 18:18 |
| chaselivingston | mmcc: gotcha. that's supposed to be coming this month, no? | 18:18 |
| mmcc | soon, yeah. not sure exactly | 18:18 |
| chaselivingston | mmcc: are you suggesting we add some of that info from that wiki page to our faq's? | 18:19 |
| mmcc | chaselivingston: That can be up to you. It might be useful but you don't want 500 FAQ answers to things people aren't actually asking… | 18:21 |
| mmcc | chaselivingston: use that info however you want | 18:21 |
| chaselivingston | mmcc: sure, makes sense. thanks | 18:21 |
| dobey | hmm | 18:24 |
| dobey | so the itunes problem explains why banshee was so problematic | 18:24 |
| dobey | meh, how to get rid of warnings about WindowsError being undefined on !win32 | 18:28 |
| dobey | brb, gotta run for a few | 18:33 |
| mmcc | hmm, syncdaemon doesn't seem to be handling changes in the purchased music folder too well. | 18:37 |
| mmcc | if you drag something from ~/U1/ to ~/.ubuntuone/ , things go wrong. does this look familiar to anyone: http://paste.ubuntu.com/1287456/ | 18:38 |
| karni | mmcc: Is it even writable by default? I see 755 here, but I have probably changed it before. | 18:38 |
| karni | mmcc: ~/.ubuntuone/ isn't synced by default. I assume this operation would simply remove those files from U1. I see it failed to delete it, though. | 18:40 |
| mmcc | karni: interesting, let me look. it's 755 for me | 18:41 |
| karni | Aha, so same. | 18:41 |
| mmcc | karni: I'm testing with a synced ~/.ubuntuone -- I have two purchased songs in there | 18:41 |
| karni | mmcc: Maybe verterok can have something to say about that tritcask problem. | 18:41 |
| karni | mmcc: You have them in ~/.ubuntuone/Purchased.. or ~/.ubuntuone/ directly? | 18:42 |
| karni | mmcc: U1 doesn't support nested UDFs, and ~/.ubuntuone/Purchased from Ubuntu One is by default a UDF. | 18:42 |
| mmcc | karni: in ~/ubuntuone/Purchased…, where they were put by the system. I was messing around with adding other files in there too | 18:42 |
| karni | Right. | 18:42 |
| karni | FWIW, it _should_ handle that no problem. It is, in the end, a regular UDF. | 18:43 |
| karni | mmcc: How did you get those red underlines in your paste? | 18:43 |
| karni | I like that. | 18:43 |
| mmcc | karni: set the type to 'python traceback' | 18:44 |
| mmcc | those red boxes are it saying it doesn't know how to parse that as a traceback | 18:44 |
| karni | mmcc: aha :) | 18:44 |
| mmcc | man, we've got some grep-hostile code… in one file, it's 'ignored_paths', in the other the same list is 'ignore_paths' | 18:46 |
| karni | mmcc: I've read (part of) a book called "Clean code". It's never too late to fix those type of problems. Same goes to renaming variables/fields/methods to something more meaningfull than it is now. :) | 18:52 |
| karni | It encourages me to do some refactorings that others may find (somewhat?) useless, while I'm confident the code reads much, much better. | 18:53 |
| mmcc | karni: good point - definitely something to consider. there is definitely a scale from 'fine -> bitch about it on irc -> actually spend time on a branch to improve it'. | 18:56 |
| karni | mmcc: totally agreed | 18:56 |
| karni | mmcc: Hopefully I'll be hands on it soon myself as well :) | 18:57 |
| mmcc | karni: hands on what? | 18:57 |
| karni | mmcc: or not. I meant desktop client code. and I recalled our "re-focus" | 18:57 |
| mmcc | karni: oh yeah. look in the mirror for that "DASH" that ralsina just shaved in all our eyebrows | 18:58 |
| karni | mmcc: heh :) yeah | 18:58 |
| karni | mmcc: Nicely done with the wiki/ideas regarding purchased UDF problems. | 18:59 |
| mmcc | karni: thx, sadly no great answers | 19:00 |
| verterok | mmcc, karni: which tritcask problem? | 19:09 |
| karni | 20:38 < mmcc> if you drag something from ~/U1/ to ~/.ubuntuone/ , things go wrong. does this look familiar to anyone: http://paste.ubuntu.com/1287456/ | 19:09 |
| karni | verterok: ↑ | 19:10 |
| * verterok looks | 19:10 | |
| verterok | karni: thx | 19:10 |
| karni | I'm not saying it is tritcask, I just thought your expertise in the field may help :) | 19:10 |
| karni | Because I saw tritcask at the end of traceback. | 19:10 |
| verterok | karni: yes, indeed looks weird | 19:11 |
| verterok | karni, mmcc: might be related to https://bugs.launchpad.net/ubuntuone-client/+bug/1064486 | 19:11 |
| ubot5 | Ubuntu bug 1064486 in Ubuntu One Client "EOFError in tritcask _deserialize - .hint and .data disagree on key availability" [High,Confirmed] | 19:11 |
| verterok | mmcc: isn't the same exact error, but it's the same code path | 19:12 |
| mmcc | verterok: interesting. looking | 19:12 |
| verterok | mmcc: I have it in my todo queue, sadly wasn't able to work on that yet :( | 19:13 |
| mmcc | verterok: bummer. I'm looking at the dump_metadata output now | 19:17 |
| verterok | mmcc: you get the same error in a consistent way? | 19:21 |
| mmcc | verterok: let me try again, I'll see | 19:21 |
| verterok | mmcc: if you do, could try deleting the .hint files | 19:22 |
| mmcc | verterok: no, not reproducible. now it handles the delete correctly. I also noticed that I was dragging to ~/.ubuntuone/ not ~/.ubuntuone/Purchased…, so delete is the right action... | 19:27 |
| alecu | hey all, ralsina just twitted that his irc is down while he manages to fix a dependency issue: http://pastebin.ubuntu.com/1287551/ | 19:27 |
| gatox | hey everyone..... ralsina says that he is not being able to join because.... some link.. that i can't paste.... because i can't open twitter in this machine neither | 19:27 |
| gatox | everyone is having an awesome connectin in argentina | 19:28 |
| gatox | jejeej | 19:28 |
| dobey | heh | 19:31 |
| dobey | alecu: wtf; quassel seems to have had a linking problem when it was built | 19:31 |
| verterok | mmcc: ok, still a weird error | 19:31 |
| verterok | mmcc: FWIW, move between UDF is actually a delete + create | 19:32 |
| mmcc | verterok: right, but ~/.ubuntuone isn't a UDF, the subdir is… | 19:33 |
| verterok | yes | 19:34 |
| verterok | it will just delete the file | 19:34 |
| dobey | oh right | 19:41 |
| dobey | so anyone have any ideas how to avoid pyflakes complaining about things like WindowsError being undefined on linux? | 19:41 |
| briancurtin | dobey: ugh, WindowsError. i would hope there is some disable/enable label for it? | 19:43 |
| dobey | briancurtin: pyflakes doesn't have enable/disable comments support | 19:47 |
| briancurtin | ah yeah that's lint | 19:47 |
| dobey | and yeah, there are lots of ugly disable/enable comments for pylint already :-/ | 19:48 |
| dobey | well i can define WindowsError as a class on !win | 19:50 |
| mmcc | ugh, can't reproduce either of the weird syncdaemon errors I saw today. what a waste of time | 19:51 |
| mmcc | here's the other one, us interpreting a move to trash as a create in trash (which isn't a UDF): http://paste.ubuntu.com/1287634/ | 19:54 |
| dobey | just was hoping to find some way to avoid defining a class | 20:02 |
| dobey | hrmm | 20:03 |
| dobey | briancurtin: is WindowsError still a thing in py3 even? | 20:03 |
| briancurtin | dobey: it will be a thing for a long time due to backwards compat, but PEP 3151 removed the need to actually use it | 20:04 |
| briancurtin | so yeah it's still there in 3 | 20:05 |
| dobey | briancurtin: i guess it's still necessary to use it in py 2 though? | 20:05 |
| briancurtin | dobey: yep, the exception reorganizing was only applied in 3.3 | 20:05 |
| dobey | bother :-/ | 20:05 |
| gatox | ok people..... eod here! see you tomorrow! | 20:08 |
| dobey | grrr | 20:09 |
| dobey | maybe i could make a pyflakes patch to ignore undefined warnings in platform-specific code | 20:12 |
| rockstar | dobey, the normal way I did that was just put a single line with the undefined token name, and then a comment like # Shut up, pyflakes | 20:14 |
| dobey | rockstar: i think you're referring to the "redefinition of unused" warning when doing try/except imports? | 20:15 |
| rockstar | No, the undefined token. So if there's an implicit token somewhere, you just put a single line with that token in it. We did it all the time in Launchpad. | 20:16 |
| dobey | that works for something that's defined but not used, but i don't think it works for undefined things; you'd need to actually define the thing | 20:17 |
| dobey | and i'm actually trying to avoid doing that, since i'd rather have pyflakes do the right thing :) | 20:18 |
| mmcc | hey, I still need a 2nd review for this https://code.launchpad.net/~mikemc/ubuntuone-client/find-logging-conf/+merge/130036 - briancurtin it is probably an easy one for you since we talked about it already | 21:02 |
| briancurtin | mmcc: i'll look | 21:02 |
| mmcc | thx | 21:02 |
| karni | I'll look as well! :) | 21:02 |
| karni | My day. | 21:02 |
| mmcc | karni: if you want to, sure - but it already has one review from earlier | 21:03 |
| mmcc | and it's a pretty simple branch | 21:03 |
| * karni nods | 21:03 | |
| * karni learns! | 21:03 | |
| mmcc | or, you could review that and briancurtin could review this one from last month, that caused so much pain: https://code.launchpad.net/~mikemc/ubuntuone-control-panel/remote-folders-fix/+merge/126037 | 21:04 |
| karni | mmcc: do you test stuff in a vm? | 21:05 |
| briancurtin | find-logging-conf looks alright, and yeah i need to look at remote-folders-fix | 21:05 |
| mmcc | karni: yes, for windows and linux. I use a macbook running osx as my main system and keep VMs for the others | 21:06 |
| karni | mmcc: specific ubuntu version? 12.04 LTS? | 21:06 |
| briancurtin | karni: i use windows and test any windows stuff straight on the machine, but do any ubuntu stuff in a quantal vm | 21:06 |
| mmcc | karni: I am using 12.04, yes, but mainly because that was the latest when I set things up. other people have many versions laying around | 21:07 |
| karni | Thanks guys | 21:07 |
| mmcc | karni: also, don't forget to set up shared folders (that's what virtualbox calls it anyway) so you don't have to use BZR to move things between host & vm, which is such a pain | 21:08 |
| karni | mmcc: yup, good point | 21:08 |
| karni | mmcc: could you tell me a bit more about + config_logs = os.path.join(os.path.dirname(__file__), os.path.pardir, | 21:09 |
| karni | 44+ os.path.pardir, 'data', CONFIG_LOGS) | 21:09 |
| karni | mmcc: notably, why is os.path.pardir twice in there | 21:09 |
| dobey | well, i guess i'll do the simple/ugly hack fix for now | 21:09 |
| mmcc | karni: sure. the path we want is <project root>/data/logging.config, and the file we're in (aka __file__) is <project root>/ubuntuone/syncdaemon/config.py, so we use dirname to get "<project root>/ubuntuone/syncdaemon/" then add "../../data/logging.conf" to get what we want | 21:10 |
| briancurtin | karni: os.path.pardir == ".." | 21:11 |
| karni | briancurtin: right, Google that. wanted to make sure I'm not missing anything :) thanks! | 21:11 |
| karni | mmcc: Thank you :) | 21:11 |
| karni | briancurtin: /s/Google/Googled ;) | 21:11 |
| mmcc | karni: you bet | 21:11 |
| karni | mmcc: Nicely done. I haven't run that yet, but it's a confident +1. Would you like me to run the test suite this time as well? (I know I should, I'm just heads down hacking) | 21:13 |
| briancurtin | i just ran it and can confirm it works here | 21:13 |
| karni | briancurtin: snaptastic, thank you! | 21:13 |
| briancurtin | np | 21:14 |
| mmcc | yeah I think we're good :) I ran it here on mac & win. | 21:14 |
| briancurtin | karni: one thing our team does (not sure if all do) is if you're the second approver on an issue, set the status up at the top to approved. i just did it so nothing more to do. it just saves time of having mmcc have to go back and remember to do it | 21:15 |
| karni | briancurtin: aha, I'll remember that! We used to do it on our own when we thought a satisfactory review count was performed. | 21:16 |
| karni | Noted :) | 21:16 |
| karni | Do you guys usually request at least two reviewers? | 21:16 |
| karni | I think whoever will review my next branch will hate me for its size :| | 21:16 |
| briancurtin | unless it's really trivial we do two. if it's something with one or two lines then it's fine to just do one | 21:17 |
| * karni nods | 21:17 | |
| mmcc | karni: yeah, two is the custom. and a while back we all promised to keep branches to < some number of lines (was it 500 or 1000? I forget) | 21:17 |
| * karni scratches on the back of his head | 21:18 | |
| karni | yeah, about that.. ;) | 21:18 |
| briancurtin | i had some huge branches for SSO porting and tried to break them up into about 500 lines, so i just had branch1, branch2 (depends on branch1), etc | 21:18 |
| karni | Anyways. I'll do my best not to do large branches again. | 21:18 |
| briancurtin | karni: keep on doing what you're doing if it works for you | 21:18 |
| briancurtin | plus who's to say we're right? we can certainly take parts of all of the teams being merged here | 21:19 |
| karni | Those things you guys said, they are sound. I like it. | 21:20 |
| karni | Although I can imagine it's sometimes hard to limit branch size. | 21:20 |
| mmcc | yeah, those diff-size guidelines were definitely python-centric too… "keep them small" for some reasonable value of small, is the goal to shoot for, that's all | 21:20 |
| karni | Cearly Java is way more verbose than python, but reviewing 1k+ is a pain, I know. | 21:21 |
| karni | Not to mention more.. | 21:21 |
| dobey | it's very hard to limit branch size when you change an SVG for example :) | 21:23 |
| dobey | but hey, here is some awesome: https://code.launchpad.net/~dobey/ubuntuone-dev-tools/run-with-flakes/+merge/130432 | 21:24 |
| karni | Interesting commit message for good start. /me reads | 21:25 |
| dobey | it's the beginning of the end of pylint | 21:26 |
| karni | dobey: I know what it stands for, have never used it though ;) | 21:26 |
| karni | oh, pyflakes will replace pylint, cool | 21:27 |
| dobey | yes, we agreed a few weeks ago that we need to move off pylint, and just move everything to pyflakes | 21:27 |
| dobey | for the clients anyway | 21:27 |
| dobey | probably should help the server guys do the same soon enough | 21:27 |
| karni | dobey: could you tell me a bit more about this line: USE_PYFLAKES="1" $PYTHON bin/u1lint | 21:29 |
| karni | Looks like a constant as well as invocation of bin/u1lint | 21:29 |
| karni | Sorry you have to hold my hand. | 21:29 |
| dobey | karni: defines environment variable to tell u1lint to run pyflakes instead of pylint | 21:29 |
| dobey | it's a shell script, not java :) | 21:30 |
| mmcc | yes karni, prepare for a delightful mess of technologies to learn - two versions of python, shell scripts, buildout config files (maybe you get to avoid that)… maybe makefiles even! | 21:31 |
| * karni likes shell scripts | 21:31 | |
| karni | mmcc: I'm eager to learn :) | 21:31 |
| briancurtin | mmcc: it looks like there is one more tiny merge conflict, like 26 of your diff on remote-folders-fix. locally i just removed the connect_file_sync line so there's "ui.switcher..." followed by "is_processing" | 21:32 |
| mmcc | briancurtin: really? huh. looking… | 21:32 |
| briancurtin | mmcc: i feel like *i* should fix that after causing this to continue on so long...but i wouldnt know how to navigate lp/bzr to contribute to a personal branch (if thats even possible?) | 21:32 |
| mmcc | briancurtin: the conflict doesn't show up in the mp. should it? | 21:34 |
| karni | dobey: assert(app) simply checks app is != None, yeah? | 21:34 |
| dobey | karni: yeah, and keeps pyflakes from reporting app as being unused | 21:35 |
| briancurtin | nah it shows up when i branch u1cp trunk then merge your branch on top. doing that shows what tarmac is going to do (at least in a roundabout way) | 21:35 |
| mmcc | briancurtin: ok, let's see here… | 21:35 |
| mmcc | I thought I did that when I fixed the conflict with roberto's branch | 21:35 |
| dobey | mmcc: just merge trunk into your branch, fix conflicts, and push back to lp | 21:35 |
| mmcc | dobey: yeah, that's what I did. and I didn't think trunk had changed in this part since… | 21:36 |
| karni | dobey: +1 | 21:36 |
| dobey | thanks karni | 21:37 |
| karni | np | 21:38 |
| mmcc | huh, yep there it is | 21:38 |
| === m_conley is now known as m_conley_away | ||
| dobey | ugh; storm moving in apparently. wondering why it was so dark already :( | 21:39 |
| mmcc | oh mandel's branch fixing the account info and double-overlay thing added this conflict | 21:40 |
| mmcc | well, I fixed the conflict and pushed it. I can confirm that the remote folders page works, but I still see two loading overlays | 21:48 |
| mmcc | I don't think my conflict resolution change should've affected that though | 21:48 |
| mmcc | :( | 21:48 |
| mmcc | brb | 21:48 |
| dobey | well, time to roll. later all | 21:49 |
| karni | laterz dobey | 21:57 |
| mmcc | man karni, you sure do keep the hacker's schedule… | 22:17 |
| briancurtin | mmcc: autofolder = amazing | 22:17 |
| briancurtin | also remote-folders tests passed, running IRL now | 22:18 |
| mmcc | briancurtin: I know, right? huuuuge improvement | 22:18 |
| briancurtin | it took a while to kick in and i was about to just say ah well it doesnt work, i'll just stick to deleting every email...then suddenly i got the notifications and it was on | 22:18 |
| briancurtin | love it | 22:18 |
| karni | mmcc: :) | 22:24 |
| karni | You guys use Thunderbird? | 22:25 |
| karni | Or pine :D? | 22:25 |
| karni | (kidding, although I have nothing against using pine) | 22:25 |
| karni | I use GMail, but I never checked if/how well it handles imap. | 22:26 |
| karni | Player finally looks like player. Working on surfacing play queue. | 22:28 |
| briancurtin | karni: i use thunderbird | 22:29 |
| karni | aha | 22:29 |
| briancurtin | how are you using gmail? as an imap client that pulls canonical email into your personal one? | 22:30 |
| briancurtin | or does the canonical google apps setup now support gmail? | 22:30 |
| karni | briancurtin: I have a 'work gmail account' where I pull canonical mail via pop3, yes. Separate from my personal gmail. | 22:31 |
| briancurtin | ah, i kind of like that | 22:31 |
| karni | briancurtin: It's a pain if you want to privately use google docs and open docs links from work mail, though. However, if you don't use docs privately much, you can sign in first to your canonical docs account, and that solves the problem. | 22:32 |
| karni | briancurtin: I have two pinned tabs (plus some more) which hold my mkarnicki@ and michal.karnicki@, the latter pulling canonical mail | 22:32 |
| mmcc | that sounds insane :) | 22:33 |
| karni | Thanks to being able to sign in to more than one account in GMail. | 22:33 |
| mmcc | I use Apple's mail.app, but it's not great… | 22:33 |
| karni | mmcc: :) | 22:33 |
| mmcc | anyway, I have to run… be back for a bit later. | 22:33 |
| karni | mmcc: Later man o/ | 22:33 |
| karni | oh look, there's the play queue :) | 22:34 |
| briancurtin | mmcc: i'll have to save investigation for tomorrow, but the remote-folders-fix doesn't work on windows :/ tests pass, but IRL it just hangs getting information at the "Syncing the cloud to your computer" page | 22:50 |
| briancurtin | i'm out of here. see you tomorrow karni and mmcc (and anyone else who's hiding) | 23:02 |
| karni | Good night, briancurtin ! | 23:02 |
| karni | Adding song playing indicator in the play queue. | 23:23 |
| karni | Hooking up prev/next/queue play logic. | 23:51 |
| karni | And no, I don't know why I'm talking to myself :D | 23:53 |
| === lifeless_ is now known as lifeless | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
