gary_poster | The eagle, by which I mean the excessively large branch I worked on for a day or two, has landed, by which I mean it has moved to the review queue. | 02:13 |
---|---|---|
gary_poster | night all. | 02:13 |
Makyo | Goodnight! | 02:15 |
bac | hi goodspud | 12:21 |
goodspud | bac, he matey. Sorry, was in a meeting | 12:30 |
bac | goodspud: np, just have a question about charm store layout | 12:31 |
goodspud | bac, go for it. Do you want to ask over g+? | 12:31 |
bac | goodspud: charm-store-layout-guide.pdf -- is that cog supposed to be an active control or just decoration? | 12:32 |
bac | hopes for the latter b/c i don't know where it would lead | 12:33 |
goodspud | bac, it's definitely decoration. | 12:34 |
bac | goodspud: thanks for confirming | 12:34 |
goodspud | Trying to create a different look for "configure charm" mode compared to the rest of the interfaces in the panel | 12:34 |
gary_poster | tveronezi, hi. any questions about my review? Have you connected with goodspud about reconciling the difference between your approach to filtering service units and the one in the mockup? As I said, I think I prefer what you have now, but maybe the mockup's approach is more compelling for a reason I don't realize yet; and your approach would need to be skinned if we took it, I suspect (orange buttons etc.) | 12:40 |
* gary_poster is not really here, and will depart in just a minute or two | 12:40 | |
tveronezi | gary_poster: We want the buttons. The mockup is outdated. The card I am working on covers the new style for these buttons. | 12:41 |
tveronezi | gary_poster: I am checking the review now. | 12:42 |
goodspud | garyp_poster, Matt supplied tveronezi with the assets for the buttons yesterday | 12:42 |
goodspud | er, gary_poster | 12:42 |
gary_poster | :-) awesome, thx both | 12:42 |
hazmat | g'morning | 13:29 |
hazmat | teknico, frankban would you guys be up for looking at websockets + tls on the backend? | 13:30 |
teknico | hazmat, sure | 13:32 |
hazmat | teknico, i'd be happy to do a g+ on background | 13:33 |
frankban | hazmat: cool, juju-ui? | 13:33 |
hazmat | sounds good | 13:33 |
hazmat | 2m, i should grab some coffee | 13:33 |
frankban | sure | 13:33 |
hazmat | frankban, teknico present | 13:37 |
hazmat | goodspud, this is the end. | 13:37 |
hazmat | goodspud, there's a nice brewdog nearish the office in camden | 13:38 |
hazmat | goodspud, how'd the release party go? | 13:38 |
goodspud | hazmat, almost the end | 13:39 |
goodspud | hazmat, stop it... I'll get all emotional | 13:39 |
goodspud | hazmat, release party was quite lame... no free drinks and fairly unorganised | 13:40 |
hazmat | frankban, teknico http://pastebin.ubuntu.com/1289340/ | 13:45 |
hazmat | txws, autobahn ws, and the twisted branch | 13:49 |
hazmat | http://twistedmatrix.com/trac/ticket/4173 | 13:51 |
hazmat | juju/lib/websockets.py | 13:54 |
hazmat | juju/lib/constants.py | 13:54 |
tveronezi | goodspud: can you check this comment? https://codereview.appspot.com/6724059/diff/1/app/templates/service-header.partial#newcode15 ? It is about the color of the tab label (units, constraints, charm, relation) when the panel is active. Whats the color code of it? | 14:00 |
hazmat | ls | 14:04 |
hazmat | http://paste.ubuntu.com/1289375/ | 14:04 |
hazmat | http://paste.ubuntu.com/1289376/ | 14:04 |
hazmat | https://github.com/MostAwesomeDude/txWS | 14:07 |
hazmat | http://autobahn.ws/python | 14:13 |
hazmat | https://github.com/tavendo/AutobahnPython/tree/master/examples/websocket/echo_site | 14:14 |
hazmat | https://github.com/tavendo/AutobahnPython/blob/master/autobahn/autobahn/resource.py | 14:15 |
bac | goodspud: ping | 14:16 |
goodspud | bac, helloo | 14:17 |
goodspud | tveronezi, I'll check it now. Just having a meeting with Jovan | 14:17 |
benji | since the WIP space is full, I can help anyone with their ongoing work that needs it | 14:18 |
benji | if there are no takers I'll work on a slack task, perhaps "YUI doc extraction and html gen" | 14:20 |
goodspud | tveronezi, a highlighted/selected tab should be #dd4814, otherwise it is #292929 | 14:23 |
_mup_ | Bug #292929: transmission 1.34 inhibits hibernation by default <Transmission:Fix Released> <transmission (Ubuntu):Fix Released> < https://launchpad.net/bugs/292929 > | 14:23 |
hazmat | anyone looking for tasks? | 14:25 |
* hazmat switches into review mode | 14:26 | |
hazmat | benji, your tweak branch is based on gary's or is it really that big.. | 14:27 |
benji | hazmat: it's really that big; ignoring whitespace it is 500 lines smaller, but I didn't see much use in pastebin-ing that diff since we're doing the inline-comment thing | 14:28 |
bac | goodspud: i've sent you some pm to avoid polluting the channel | 14:28 |
* hazmat digs into gary's branch | 14:33 | |
Makyo | What do we want the potential relation names to be in the UI? Currently, it's like 'puppetmaster:juju-info → puppet:juju-info', but that's pretty wordy. I'd say just 'juju-info', but sometimes the names are different, like mysql:db -> mediawiki:slave | 14:43 |
hazmat | Makyo, if its ambigious we need the qualified form | 14:51 |
Makyo | So the first? | 14:52 |
hazmat | Makyo, juju-info is rarely needs to be qualified. | 14:52 |
Makyo | hazmat, I suppose that was a poor example. The choices for that relation are juju-info or puppetmaster. | 14:52 |
hazmat | Makyo, yes, the first as in service_name:rel_name -> svc_name:rel:name | 14:53 |
Makyo | hazmat, Alright | 14:53 |
hazmat | Makyo, i'm of partial mind to disable subordinate rel selection between services that can/share a normal relation, but its premature for that atm | 14:54 |
hazmat | ie. puppet and puppetmaster shouldn't really have a subordinate puppet:juju-info relation.. there are valid use cases though.. so we can wave off on it for now. | 14:54 |
hazmat | and support all ambigious endpoints | 14:54 |
Makyo | Alright, we'll discuss that in the future, then. | 14:55 |
hazmat | er.. different valid use cases that particular example is an example of why its a bad idea. | 14:55 |
=== frankban_ is now known as frankban | ||
tveronezi | brb | 15:39 |
bac | benji: i would be happy to lead the meeting but my camera isn't working. don't people want to see their leader's face? | 15:49 |
benji | heh | 15:50 |
benji | bac: I think we'll survive. | 15:50 |
bac | benji: maybe its for the best. you won't be able to see me rolling my eyes | 15:52 |
benji | heh | 15:52 |
bac | bcsaller, benji, frankban, goodspud, Makyo, teknico, hazmat, tveronezi: meeting in one minute | 15:59 |
hazmat | bac, bcsaller, benji, goodspud, Makyo, teknico, tveronezi 2m to standup | 15:59 |
hazmat | ;-) | 15:59 |
hazmat | 1m then | 15:59 |
gary_poster | tveronezi, should I look at branch or is someone else doing it? | 17:29 |
tveronezi | hi gary_poster... hazmat is doing it. | 17:30 |
gary_poster | great tveronezi thx | 17:30 |
tveronezi | thk. | 17:30 |
hazmat | gary_poster, i've been looking over your branch, i'm wondering if we can simplify a bit about the whole base id bit | 17:31 |
gary_poster | hazmat simplifications +1. what do you have in mind? | 17:31 |
hazmat | by changing the browser backend | 17:31 |
gary_poster | not sure what that means yet | 17:31 |
hazmat | gary_poster, returning qualified ids aka store_url with revision id in search results, and accepting those as input params to get the json out | 17:31 |
gary_poster | oh you mean in charm id | 17:32 |
gary_poster | I mean charm store | 17:32 |
hazmat | so json urls would be owner/series/name-revision/json | 17:32 |
gary_poster | and then we could standardize on charm.load() | 17:32 |
gary_poster | +1 hazmat | 17:32 |
gary_poster | I'd suggest getting this branch landed and doing that separately hazmat | 17:33 |
gary_poster | but I'm eager to do it | 17:33 |
hazmat | gary_poster, k, working on it now.. just rippling it through the queue pipeline bits, your branch looks good besides that, i'm time boxed on implementing this for another 30m. | 17:33 |
gary_poster | ok cool hazmat | 17:33 |
gary_poster | I'll check back later and if you are done with it I'll see if I can rip out the pertinent bits relatively quickly | 17:34 |
gary_poster | ttyl | 17:34 |
Makyo | bcsaller, reproposed right as your review came through, sorry...will add the title to the next proposal after. | 19:26 |
Makyo | ...title to the menu. | 19:26 |
* Makyo lunches. | 19:30 | |
hazmat | benji, most of the app seems to have issues with the tweak env branch | 19:46 |
benji | hazmat: I just noticed your email. Darn. I guess our test coverage isn't quite where we would like it. | 19:47 |
benji | I'll see what I can do. | 19:47 |
bac | i'm seeing failures on one test in trunk. anyone else? | 20:03 |
bac | benji, hazmat: ^^ ?? | 20:04 |
* benji looks | 20:04 | |
benji | bac: 100% pass for me (197 tests) | 20:09 |
bac | hmm | 20:09 |
bac | i suspected my environment was suspect | 20:09 |
bac | the tests that check the Y value of the tooltips are failing for me b/c the values are no longer integers | 20:09 |
bac | 209.332 does not match 209.187 | 20:10 |
bac | i guess i'll hold off on my testfix bandaid | 20:10 |
hazmat | bac, i think Makyo's branch has a fix for that | 20:17 |
hazmat | which is in review | 20:17 |
hazmat | rounding error | 20:17 |
hazmat | benji, yeah.. svc details views we can add some more tests now.. the env view i'd like to discuss next week about strategies we can use to do better testing on it | 20:18 |
hazmat | benji, its a little disappointing that none of the service tests failed | 20:27 |
tveronezi | bac, hazmat, benji.... it failt for chrome only. | 20:27 |
tveronezi | failt/fails | 20:27 |
tveronezi | it runs fine with chromiun. | 20:28 |
bac | tveronezi: do the tests all pass in firefox? | 20:28 |
* hazmat wonders if chromium in quantal is horribly still outdated | 20:28 | |
tveronezi | hold on... | 20:28 |
bac | tveronezi: there was a firefox-specific failure before | 20:29 |
hazmat | Makyo's fix for it looks good.. | 20:29 |
hazmat | - tooltip.get('boundingBox').getY().should.equal(originalY - 10); | 20:29 |
hazmat | + Math.floor(tooltip.get('boundingBox').getY()) | 20:29 |
hazmat | + .should.equal(Math.floor(originalY - 10)); | 20:29 |
tveronezi | wow... firefox is worst... it gives [16:29:41.663] SyntaxError: invalid regular expression flag 1 @ http://localhost:8084/test/:48 | 20:31 |
tveronezi | hazmat: should I do anything special to land my branch? "lbox submit" is the only thing I should do, right? Will it point to the good trunk? | 20:36 |
hazmat | tveronezi, bzr info should show where it will submit | 20:37 |
tveronezi | sweet... it is the good one. tkx! | 20:37 |
tveronezi | ops nop... bad one. | 20:38 |
hazmat | hmm | 20:39 |
hazmat | tveronezi, perhaps you need to update ~/.bazaar/locations.conf ? | 20:41 |
hazmat | er.. never mind | 20:41 |
tveronezi | the proposal is the good one (-for=lp:juju-gui) but the parent is bzr+ssh://bazaar.launchpad.net/~juju-gui-peeps/juju-gui/trunk/ | 20:42 |
bac | hazmat: yeah, that test fails in chromium-quantal but passes on precise | 20:47 |
hazmat | Makyo, the same border shadow drag / attachpoint issue seems also to present to a lesser dergree on the top | 20:47 |
Makyo | hazmat, Between newly created services? | 20:49 |
hazmat | Makyo, yes | 20:50 |
Makyo | hazmat, will investigate. | 20:50 |
hazmat | i was playing around with two different hadoop services, since they have by far the most ambigious relations | 20:50 |
Makyo | hazmat, alright, cool. Will play around with those specifically. | 20:52 |
Makyo | hazmat, have a second to show me how you have them arranged? Screenshot or hangout. | 20:52 |
hazmat | Makyo, let's hang.. juju-ui | 20:56 |
hazmat | hard time reproducing atm | 20:58 |
* bac walks dog. will be around later. happy travels everyone. | 21:13 | |
hazmat | signing off.. safe travels to all | 22:03 |
SpamapS | hazmat: see you on the flip side | 22:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!