[02:13] The eagle, by which I mean the excessively large branch I worked on for a day or two, has landed, by which I mean it has moved to the review queue. [02:13] night all. [02:15] Goodnight! [12:21] hi goodspud [12:30] bac, he matey. Sorry, was in a meeting [12:31] goodspud: np, just have a question about charm store layout [12:31] bac, go for it. Do you want to ask over g+? [12:32] goodspud: charm-store-layout-guide.pdf -- is that cog supposed to be an active control or just decoration? [12:33] hopes for the latter b/c i don't know where it would lead [12:34] bac, it's definitely decoration. [12:34] goodspud: thanks for confirming [12:34] Trying to create a different look for "configure charm" mode compared to the rest of the interfaces in the panel [12:40] tveronezi, hi. any questions about my review? Have you connected with goodspud about reconciling the difference between your approach to filtering service units and the one in the mockup? As I said, I think I prefer what you have now, but maybe the mockup's approach is more compelling for a reason I don't realize yet; and your approach would need to be skinned if we took it, I suspect (orange buttons etc.) [12:40] * gary_poster is not really here, and will depart in just a minute or two [12:41] gary_poster: We want the buttons. The mockup is outdated. The card I am working on covers the new style for these buttons. [12:42] gary_poster: I am checking the review now. [12:42] garyp_poster, Matt supplied tveronezi with the assets for the buttons yesterday [12:42] er, gary_poster [12:42] :-) awesome, thx both [13:29] g'morning [13:30] teknico, frankban would you guys be up for looking at websockets + tls on the backend? [13:32] hazmat, sure [13:33] teknico, i'd be happy to do a g+ on background [13:33] hazmat: cool, juju-ui? [13:33] sounds good [13:33] 2m, i should grab some coffee [13:33] sure [13:37] frankban, teknico present [13:37] goodspud, this is the end. [13:38] goodspud, there's a nice brewdog nearish the office in camden [13:38] goodspud, how'd the release party go? [13:39] hazmat, almost the end [13:39] hazmat, stop it... I'll get all emotional [13:40] hazmat, release party was quite lame... no free drinks and fairly unorganised [13:45] frankban, teknico http://pastebin.ubuntu.com/1289340/ [13:49] txws, autobahn ws, and the twisted branch [13:51] http://twistedmatrix.com/trac/ticket/4173 [13:54] juju/lib/websockets.py [13:54] juju/lib/constants.py [14:00] goodspud: can you check this comment? https://codereview.appspot.com/6724059/diff/1/app/templates/service-header.partial#newcode15 ? It is about the color of the tab label (units, constraints, charm, relation) when the panel is active. Whats the color code of it? [14:04] ls [14:04] http://paste.ubuntu.com/1289375/ [14:04] http://paste.ubuntu.com/1289376/ [14:07] https://github.com/MostAwesomeDude/txWS [14:13] http://autobahn.ws/python [14:14] https://github.com/tavendo/AutobahnPython/tree/master/examples/websocket/echo_site [14:15] https://github.com/tavendo/AutobahnPython/blob/master/autobahn/autobahn/resource.py [14:16] goodspud: ping [14:17] bac, helloo [14:17] tveronezi, I'll check it now. Just having a meeting with Jovan [14:18] since the WIP space is full, I can help anyone with their ongoing work that needs it [14:20] if there are no takers I'll work on a slack task, perhaps "YUI doc extraction and html gen" [14:23] tveronezi, a highlighted/selected tab should be #dd4814, otherwise it is #292929 [14:23] <_mup_> Bug #292929: transmission 1.34 inhibits hibernation by default < https://launchpad.net/bugs/292929 > [14:25] anyone looking for tasks? [14:26] * hazmat switches into review mode [14:27] benji, your tweak branch is based on gary's or is it really that big.. [14:28] hazmat: it's really that big; ignoring whitespace it is 500 lines smaller, but I didn't see much use in pastebin-ing that diff since we're doing the inline-comment thing [14:28] goodspud: i've sent you some pm to avoid polluting the channel [14:33] * hazmat digs into gary's branch [14:43] What do we want the potential relation names to be in the UI? Currently, it's like 'puppetmaster:juju-info → puppet:juju-info', but that's pretty wordy. I'd say just 'juju-info', but sometimes the names are different, like mysql:db -> mediawiki:slave [14:51] Makyo, if its ambigious we need the qualified form [14:52] So the first? [14:52] Makyo, juju-info is rarely needs to be qualified. [14:52] hazmat, I suppose that was a poor example. The choices for that relation are juju-info or puppetmaster. [14:53] Makyo, yes, the first as in service_name:rel_name -> svc_name:rel:name [14:53] hazmat, Alright [14:54] Makyo, i'm of partial mind to disable subordinate rel selection between services that can/share a normal relation, but its premature for that atm [14:54] ie. puppet and puppetmaster shouldn't really have a subordinate puppet:juju-info relation.. there are valid use cases though.. so we can wave off on it for now. [14:54] and support all ambigious endpoints [14:55] Alright, we'll discuss that in the future, then. [14:55] er.. different valid use cases that particular example is an example of why its a bad idea. === frankban_ is now known as frankban [15:39] brb [15:49] benji: i would be happy to lead the meeting but my camera isn't working. don't people want to see their leader's face? [15:50] heh [15:50] bac: I think we'll survive. [15:52] benji: maybe its for the best. you won't be able to see me rolling my eyes [15:52] heh [15:59] bcsaller, benji, frankban, goodspud, Makyo, teknico, hazmat, tveronezi: meeting in one minute [15:59] bac, bcsaller, benji, goodspud, Makyo, teknico, tveronezi 2m to standup [15:59] ;-) [15:59] 1m then [17:29] tveronezi, should I look at branch or is someone else doing it? [17:30] hi gary_poster... hazmat is doing it. [17:30] great tveronezi thx [17:30] thk. [17:31] gary_poster, i've been looking over your branch, i'm wondering if we can simplify a bit about the whole base id bit [17:31] hazmat simplifications +1. what do you have in mind? [17:31] by changing the browser backend [17:31] not sure what that means yet [17:31] gary_poster, returning qualified ids aka store_url with revision id in search results, and accepting those as input params to get the json out [17:32] oh you mean in charm id [17:32] I mean charm store [17:32] so json urls would be owner/series/name-revision/json [17:32] and then we could standardize on charm.load() [17:32] +1 hazmat [17:33] I'd suggest getting this branch landed and doing that separately hazmat [17:33] but I'm eager to do it [17:33] gary_poster, k, working on it now.. just rippling it through the queue pipeline bits, your branch looks good besides that, i'm time boxed on implementing this for another 30m. [17:33] ok cool hazmat [17:34] I'll check back later and if you are done with it I'll see if I can rip out the pertinent bits relatively quickly [17:34] ttyl [19:26] bcsaller, reproposed right as your review came through, sorry...will add the title to the next proposal after. [19:26] ...title to the menu. [19:30] * Makyo lunches. [19:46] benji, most of the app seems to have issues with the tweak env branch [19:47] hazmat: I just noticed your email. Darn. I guess our test coverage isn't quite where we would like it. [19:47] I'll see what I can do. [20:03] i'm seeing failures on one test in trunk. anyone else? [20:04] benji, hazmat: ^^ ?? [20:04] * benji looks [20:09] bac: 100% pass for me (197 tests) [20:09] hmm [20:09] i suspected my environment was suspect [20:09] the tests that check the Y value of the tooltips are failing for me b/c the values are no longer integers [20:10] 209.332 does not match 209.187 [20:10] i guess i'll hold off on my testfix bandaid [20:17] bac, i think Makyo's branch has a fix for that [20:17] which is in review [20:17] rounding error [20:18] benji, yeah.. svc details views we can add some more tests now.. the env view i'd like to discuss next week about strategies we can use to do better testing on it [20:27] benji, its a little disappointing that none of the service tests failed [20:27] bac, hazmat, benji.... it failt for chrome only. [20:27] failt/fails [20:28] it runs fine with chromiun. [20:28] tveronezi: do the tests all pass in firefox? [20:28] * hazmat wonders if chromium in quantal is horribly still outdated [20:28] hold on... [20:29] tveronezi: there was a firefox-specific failure before [20:29] Makyo's fix for it looks good.. [20:29] - tooltip.get('boundingBox').getY().should.equal(originalY - 10); [20:29] + Math.floor(tooltip.get('boundingBox').getY()) [20:29] + .should.equal(Math.floor(originalY - 10)); [20:31] wow... firefox is worst... it gives [16:29:41.663] SyntaxError: invalid regular expression flag 1 @ http://localhost:8084/test/:48 [20:36] hazmat: should I do anything special to land my branch? "lbox submit" is the only thing I should do, right? Will it point to the good trunk? [20:37] tveronezi, bzr info should show where it will submit [20:37] sweet... it is the good one. tkx! [20:38] ops nop... bad one. [20:39] hmm [20:41] tveronezi, perhaps you need to update ~/.bazaar/locations.conf ? [20:41] er.. never mind [20:42] the proposal is the good one (-for=lp:juju-gui) but the parent is bzr+ssh://bazaar.launchpad.net/~juju-gui-peeps/juju-gui/trunk/ [20:47] hazmat: yeah, that test fails in chromium-quantal but passes on precise [20:47] Makyo, the same border shadow drag / attachpoint issue seems also to present to a lesser dergree on the top [20:49] hazmat, Between newly created services? [20:50] Makyo, yes [20:50] hazmat, will investigate. [20:50] i was playing around with two different hadoop services, since they have by far the most ambigious relations [20:52] hazmat, alright, cool. Will play around with those specifically. [20:52] hazmat, have a second to show me how you have them arranged? Screenshot or hangout. [20:56] Makyo, let's hang.. juju-ui [20:58] hard time reproducing atm [21:13] * bac walks dog. will be around later. happy travels everyone. [22:03] signing off.. safe travels to all [22:42] hazmat: see you on the flip side