| davecheney | wrtp: where are you ? | 07:35 |
|---|---|---|
| davecheney | come to the big cloud room | 07:35 |
| wrtp | in the cloud room with the others | 07:35 |
| wrtp | davecheney: ok | 07:35 |
| wrtp | davecheney: what's up? | 07:35 |
| davecheney | reviewing hte hundreds of bugs in py juju | 07:35 |
| wrtp | will be over in a mo, if i can work out which is the "big cloud room" :-) | 07:36 |
| niemeyer | fwereade: | 07:42 |
| niemeyer | """ | 07:42 |
| niemeyer | When jujud has already opened the log file, and then panics, we just | 07:42 |
| niemeyer | lose the panic output. So I think we do need this... | 07:42 |
| niemeyer | """ | 07:42 |
| niemeyer | fwereade: Why would we lose? That's not what append does, AFAIK | 07:42 |
| fwereade | niemeyer, I just checked, and the output is nowhere to be seen -- and that fits with my intuition, that 2 things should probably not open the same file for writing | 07:42 |
| fwereade | niemeyer, am I being stupid? | 07:43 |
| niemeyer | fwereade: AFAIK, the reason for O_APPEND in *nix is precisely to handle that | 07:43 |
| fwereade | niemeyer, hum, ok | 07:44 |
| fwereade | niemeyer, I will try to figure out what I got wrong, and get back to you | 07:51 |
| niemeyer | fwereade: If it's going to take too long, we can just move forward.. I expected it to be straightforward, though, and it's very handy to not have two files with the same name in the same directory.. we'll always have to type the extension otherwise | 07:53 |
| fwereade | niemeyer, well, I did submit already, but I will see if I can figure out what I did wrong all the same :) | 07:53 |
| fwereade | niemeyer, (ok, I can't figure out what I did wrong, but I clearly did -- using the same file works perfectly... sorry) | 08:21 |
| davecheney | agent_test.go:294: c.Assert(string(data), Not(Equals), "spurious") | 09:31 |
| davecheney | ... obtained string = "spurious" | 09:31 |
| davecheney | ... expected string = "spurious" | 09:31 |
| davecheney | o_O! | 09:31 |
| niemeyer | davecheney: Type | 09:32 |
| niemeyer | davecheney: Hmm.. whhaaa | 09:32 |
| niemeyer | davecheney: Oh, | 09:32 |
| niemeyer | davecheney: Not(Equals) | 09:32 |
| davecheney | fair enough | 09:34 |
| davecheney | that is a bit unhelpful | 09:34 |
| davecheney | i'll fix it | 09:34 |
| davecheney | wrtp: GOMAXPROCS=81 go test .../cmd/jujud will fail with an auth error very reliably for me | 09:55 |
| davecheney | bootstrap_test.go:129: c.Assert(err, Equals, expectErr) | 09:59 |
| davecheney | ... obtained = nil | 09:59 |
| davecheney | ... expected *errors.errorString = &errors.errorString{s:"unauthorized access"} ("unauthorized access") | 09:59 |
| davecheney | wrtp: http://paste.ubuntu.com/1304534/ | 10:00 |
| davecheney | wrtp: https://codereview.appspot.com/6767053 | 10:46 |
| davecheney | looking good in stress testing | 10:46 |
| wrtp | cool | 10:46 |
| davecheney | wrtp: now looking at https://bugs.launchpad.net/juju-core/+bug/1064142 | 10:52 |
| fwereade | davecheney, thank you, I've peered at that a couple of times and been totally unable to figure out what was actually happening in the ackground | 10:58 |
| davecheney | fwereade: np, i'll come an nag you if I am confused | 10:59 |
| fwereade | mramm, s/Availability/Available/ | 12:16 |
| fwereade | mramm, s/principle/principal/ | 12:24 |
| TheMue | fwereade: +1 | 12:24 |
| fwereade | mramm, I don't appear to have edit rights, that's the only reason I'm hassling you | 12:25 |
| Aram | fwereade: please share the link to the google doc. | 12:27 |
| fwereade | Aram, https://docs.google.com/a/canonical.com/document/d/1cm_JDMmk-uA15nSUf5Wz8icbBb4AmCOB-hoJZUfcgsE/edit# | 12:28 |
| Aram | thanks | 12:28 |
| fwereade | davecheney, where did you guys go, and should I be there? | 13:38 |
| davecheney | most people went to carbo load | 13:42 |
| davecheney | fwereade: https://bugs.launchpad.net/juju-core/+bug/1071320 | 14:12 |
| davecheney | ^ has been happening for a while | 14:12 |
| davecheney | i am investigating now | 14:12 |
| davecheney | (manly as I have no idea how to fix the previous issue) | 14:12 |
| fwereade | davecheney, that aaaaaaaaaaaaaaaaaaa one? I hopefully assigned it to rogpeppe this morning | 14:13 |
| fwereade | davecheney, interesting to see the panic on reset though | 14:13 |
| davecheney | yeah, that is common for most of our tear down tests | 14:13 |
| davecheney | it's not a concern | 14:13 |
| fwereade | davecheney, ah, ok | 14:13 |
| fwereade | davecheney, so the panics come after the failures in aram's problem? and are therefore not a cause of it? | 14:14 |
| davecheney | yes | 14:19 |
| fwereade | davecheney, ty, that is good to know | 14:21 |
| davecheney | fwereade: https://codereview.appspot.com/6781043 | 15:12 |
| davecheney | ^ possible fix for aaa race | 15:12 |
| fwereade | davecheney, I don't understand how https://codereview.appspot.com/6781043 works... but then I don't think I understood the original failure either :/ | 15:32 |
| fwereade | davecheney, rogpeppe may be a better reviewer... | 15:32 |
| davecheney | fwereade: i belive that the hook is exiting before we even start the logger | 15:50 |
| davecheney | but I am trying to understand that bad fd error better | 15:50 |
| davecheney | logically thre is a chance logger.stop could be called before logger.run is scheduled | 15:50 |
| davecheney | or the process could complete and exit before logger.run is scheduled | 15:51 |
| fwereade | davecheney, ah, ok | 15:51 |
| davecheney | the key in that proposal is it mitigates the problem | 15:52 |
| davecheney | doesn't fix it | 15:52 |
| davecheney | but mititgates it to a point that I was only able to reproduce the issue very infreqently | 15:53 |
| davecheney | at which case other failures are taking precidence | 15:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!