| === yofel_ is now known as yofel | ||
| === eu is now known as Guest92071 | ||
| gatox | good morning! | 11:20 |
|---|---|---|
| karni | Good morning! | 11:36 |
| gatox | karni, hi | 11:51 |
| karni | hi gatox | 11:52 |
| gatox | karni, do you have time for a review? :D it's a qt related branch, i don't know if you feel confident with that, but you can ask me anything anyway | 11:54 |
| karni | gatox: Sure, I can try having a look at it in a moment :) Throw the MP at me. | 11:54 |
| gatox | karni, https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/new-share-design/+merge/131397 thanks! | 11:55 |
| karni | gatox: maximum size, <height>16777215</height> - where did that value come from :)? | 12:08 |
| gatox | karni, that is just the default size in qt for maximum.... i enable the other property so it set that to that value that it means: as big as its needed | 12:09 |
| gatox | the designer set that i mean | 12:09 |
| karni | oh ok | 12:10 |
| gatox | karni, you will see it in some files | 12:10 |
| karni | gatox: what is the <bool>true</bool> within <property name="frame"> ? | 12:15 |
| karni | Man this XML is pretty verbose. | 12:16 |
| gatox | karni, yap..... that's what happend when you use the designer | 12:17 |
| karni | gatox: thix XML comes from the designer? Has it been modified manually as well? | 12:17 |
| * gatox preffers to write the ui in code.... | 12:17 | |
| karni | Or can I just skip it and assume designer did write. | 12:17 |
| gatox | karni, is 100% designer | 12:18 |
| karni | gatox: I don't mind both, but when in XML - I write it by hand as well :) | 12:18 |
| karni | gatox: k | 12:18 |
| karni | haha, omg ;) <string><html><head/><body><p>Search Results</p></body></html></string> | 12:18 |
| karni | 272+PUBLISH_FILE = _('Publish file') | 12:20 |
| karni | 273+PUBLISH_THESE_FILES = _('Publish these files:') | 12:20 |
| karni | gatox: I don't see why first line would not include ':' but the other would :) Just a super tiny detail. | 12:20 |
| * karni reads on | 12:20 | |
| karni | gatox: What's the -1 here? item.setSizeHint(FILE_NAME_COL, QtCore.QSize(-1, 35)) | 12:23 |
| gatox | karni, because they are used for different things...... PUBLISH_FILE is just the text for a button, and PUBLISH_THESE_FILES is a label at the start of a list of files that can be shared | 12:23 |
| karni | gatox: ah, cool | 12:23 |
| karni | gatox: The hardcoded '2' worries me, could we have a constant making it clear what it means? 386+ self.ui.stacked_widget.setCurrentIndex(2) | 12:25 |
| gatox | karni, yes.... we can set some constants for the differents layout in the stackedlayout.... could you add that as a comment? | 12:26 |
| karni | yep | 12:26 |
| karni | gatox: And, what's the -1 in item.setSizeHint(FILE_NAME_COL, QtCore.QSize(-1, 35)) ? | 12:26 |
| gatox | karni, that is to specified that we want the size to be a minimum width and a height of 35 | 12:28 |
| karni | cool | 12:29 |
| karni | gatox: +1 with a comment | 12:35 |
| gatox | karni, awesome.... thx! i'll fix that right now | 12:38 |
| gatox | karni, about the v | 12:38 |
| gatox | increment = 2 if current == 0 else 1 | 12:38 |
| gatox | karni, if you execute the control panel..... in the popup that appear in the share tabs you will see now the follow items: "Search for: foobar"..... "Publish these files:".... and the list of files | 12:39 |
| gatox | that increment what it do is to avoid the focus to be placed on the second element (Publish these files:) because that is just there to give a tip to the user, not to allow that item to be selected | 12:40 |
| gatox | karni, here is a live example: http://youtu.be/x7b3Z2r7SRQ | 12:40 |
| gatox | at 0:05 | 12:40 |
| karni | gatox: aha, so upon clicking a file on that list, it gets published | 12:45 |
| karni | gatox: and 'current' is? | 12:45 |
| gatox | karni, 1) yes....... 2) current is the current index of the item who has the focus before processing the key event | 12:46 |
| karni | gatox: Also, I've seen the clip already - very nice! :) | 12:46 |
| gatox | karni, thx..... and the version in the branch is nicer | 12:46 |
| gatox | karni, that was the first try | 12:46 |
| karni | gatox: In that case, I would go for something more meaningful like: headerLines = 2 if focusedIndex == 0 else 1. It conveys more meaning through the code. But I'll leave it up to you. | 12:48 |
| gatox | karni, +1 to focused_index..... not sure about headerLines... because that actually sets the next_index for any item in the list, not just related to the header | 12:50 |
| gatox | i can call it next_index | 12:50 |
| gatox | and give 2 and 1 a proper constant name | 12:50 |
| gatox | so is going to be more readable | 12:50 |
| gatox | what do you think? | 12:51 |
| karni | gatox: aah, you're right. (about any next item) | 12:58 |
| gatox | karni, ok.... i'll do those changes | 12:58 |
| karni | gatox: list_offset maybe :)? | 12:58 |
| karni | Does that make sense? | 12:58 |
| karni | or it means something else? | 12:58 |
| karni | It may, I may not be understanding this part exactly :) | 12:58 |
| gatox | karni, ahhhhh yes..... list_offset is better, because we are not setting the next_item, we are incrementing it | 12:59 |
| karni | gatox: perfect :) | 12:59 |
| karni | gatox: I understand it can be difficult to give names to 2 and 1, but it would be good. In any case, renaming "increment" and "current" is a good step forward already :) Thanks. | 13:00 |
| gatox | karni, yes, i'll try to use my creativity there jeje | 13:01 |
| karni | :) | 13:02 |
| gatox | karni, the branch has been updated with the constants...... just to let you know | 13:35 |
| * karni has a look :) | 13:35 | |
| gatox | karni, probably launchpad is not updated yet tough | 13:36 |
| karni | gatox: /me looks at the commit diff :) | 13:36 |
| gatox | :P | 13:36 |
| gatox | briancurtin, just in time when i needed a second review! \o/ | 13:37 |
| gatox | briancurtin, jejeje hi! | 13:37 |
| briancurtin | hi gatox, what's the review? i'll take a look | 13:37 |
| gatox | briancurtin, jeje sorry to bother you so early :P https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/new-share-design/+merge/131397 | 13:38 |
| karni | gatox: The code reads much, much better now :) FWIW, I'd personally /s/AVOID_SECOND_ITEM/{DOUBLE|TWO}_ITEM_OFFSET && /s/NORMAL_INCREMENT/{SINGLE|ONE}_ITEM_OFFSET, but I don't want to be PITA, so +1 from me :) | 13:41 |
| briancurtin | gatox: i'll start looking at it | 13:43 |
| karni | gatox: FYI, Have you seen that Ubuntu One Auto Pilot commet on this? https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/search-shared-files/+merge/131019 | 13:43 |
| gatox | karni, if you think is best i don't have any problem to change it...... i choose that..... because now if you read the code is something like: "avoid second item if focus index is equal to 0 else normal increment" | 13:43 |
| === m_conley_away is now known as m_conley | ||
| mmcc | Morning, folks | 13:44 |
| karni | gatox: I just don't think 'avoid' fit's there well linguistically (is there such a word :D?) but hey, I'm not the native speaker here :) | 13:44 |
| karni | morning briancurtin, mmcc! | 13:44 |
| karni | gatox: I like this tab with new features. Very neat. | 13:44 |
| gatox | karni, me neither :P | 13:45 |
| gatox | karni, me neither about not being a native speaker :P | 13:45 |
| karni | Yeah, I got that ;D | 13:45 |
| gatox | karni, yes..... i just saw the auto pilot comment..... annnndddddddd..... i think launchpad or tarmac or something hates me..... if you take a look at the file..... it says ALL TEST PASS!..... but it fails anyway....... | 13:45 |
| karni | uh :S | 13:46 |
| mmcc | gatox, did you already notice those two pep8 errors buried at the end? | 13:56 |
| mmcc | we should probably have the test scripts print a header for the style checkers… | 13:56 |
| gatox | mmcc, ahhhhh totally miss that..... i thought that part was just part of the clean message | 13:57 |
| gatox | s | 13:57 |
| mmcc | yep, it's really buried | 13:57 |
| gatox | mmcc, thx about that | 13:57 |
| dobey | hey all | 13:57 |
| karni | hi dobey | 13:57 |
| mmcc | gaotx, you're welcome! :) | 13:58 |
| mmcc | morning dobey | 13:58 |
| dobey | gatox: there are pep8 errors | 13:58 |
| gatox | dobey, yes, mmcc already mention it | 13:58 |
| dobey | ah | 13:59 |
| gatox | dobey, mmcc, mmmm also.... the pep8 version of the script we are using seems to be old..... because that is not mandatory anymore | 13:59 |
| dobey | gatox: it's whatever is in quantal | 13:59 |
| dobey | man this cold needs to gtfo already | 14:14 |
| gatox | dobey, hehe here i'm trying to survive with the air conditioner..... too hottttt | 14:16 |
| mmcc | still sick? bummer. get well soon dobey. | 14:16 |
| gatox | dobey, ahhhhh that kind of cold | 14:16 |
| gatox | jeje | 14:16 |
| dobey | i'll see your air conditioner problem, and raise you a hurricane. | 14:17 |
| mmcc | oh yeah, are you in the path? or too far south? | 14:17 |
| gatox | dobey, oops.. :S | 14:18 |
| dobey | mmcc: well i don't think we'll get a direct hit this time, but plenty of wind/rain from the outskirts of the giganticane | 14:18 |
| mmcc | that's good - good luck… | 14:19 |
| mmcc | I checked Pittsburgh forecasts just for old times' sake - sounds like they're in for a ton of rain even that far out. | 14:20 |
| dobey | yeah. that nor'easter moving in up that way doesn't help either | 14:24 |
| rockstar | me | 15:01 |
| briancurtin | me | 15:01 |
| karni | um.. DST shit | 15:01 |
| karni | I thought it was in 1 hour hehe | 15:01 |
| karni | me | 15:01 |
| mmcc | me | 15:01 |
| rockstar | Oh, I didn't even notice we had DST rollback… I love technology. | 15:01 |
| dobey | me | 15:01 |
| karni | It's 4PM here :) | 15:02 |
| dobey | oh right. no wonder i feel even worse today | 15:02 |
| gatox | me | 15:02 |
| rockstar | I think that's it, right? | 15:03 |
| rockstar | Everyone else is unavailable? | 15:03 |
| karni | I think so, let's go ahead. | 15:03 |
| rockstar | TODO: continue work on the v2 api iOS work | 15:03 |
| rockstar | BLOCKED: No | 15:03 |
| rockstar | NEXT: briancurtin | 15:03 |
| briancurtin | DONE: setting up VMs and testing, also setup Q on my laptop | 15:04 |
| briancurtin | TODO: reviews, test XP and 7 with the new installer | 15:04 |
| briancurtin | NEXT: karni | 15:04 |
| karni | DONE: Reviews, e-mail catch-up, consulting sync with Derek (community) | 15:04 |
| karni | TODO: Was away on Friday. Continue previous work, shuffle + repeat | 15:04 |
| karni | BLOCKED: No. | 15:04 |
| karni | NEXT: mmcc | 15:04 |
| mmcc | DONE: reviews, testing pyobjc — TODO: same — BLOCK: no — NEXT: dobey | 15:04 |
| dobey | DONE: reviews | 15:04 |
| dobey | TODO: preparing next stable branches | 15:04 |
| dobey | BLCK: None. | 15:04 |
| dobey | gatox: go | 15:04 |
| gatox | DONE: | 15:04 |
| gatox | Propose and fixed a couple of branches for the new design and functionalities in the Share tab in control panel. Couple of reviews. Start working in the failing test in tarmac | 15:04 |
| gatox | TODO: | 15:04 |
| gatox | Figure it out why it is failing in tarmac. | 15:04 |
| gatox | BLOCKED: | 15:04 |
| gatox | No | 15:04 |
| gatox | comments? | 15:06 |
| gatox | eom? | 15:06 |
| karni | eom | 15:06 |
| dobey | gatox: you mean s/tarmac/nightlies/ in your standup? | 15:12 |
| gatox | yap..... that | 15:13 |
| * gatox lunch | 15:13 | |
| === gatox is now known as gatox_lunch | ||
| dobey | ugh, this hurricane sucks | 15:27 |
| dobey | so cold. | 15:27 |
| karni | " are backuped photos and files stored on a remote server.?? " umm.. :} | 15:28 |
| dobey | i should get some lunch. bbiab | 15:52 |
| === gatox_lunch is now known as gatox | ||
| gatox | dobey, is there any way to debug this as is running in nightlies? | 16:11 |
| gatox | dobey, ah sorry.... lunch....... let me know when you are back | 16:11 |
| mmcc | changing locations, back in a little bit… | 16:59 |
| briancurtin | gatox: two comments on that new-share-design branch. running IRL/tests right now | 17:41 |
| gatox | briancurtin, ack | 17:43 |
| gatox | briancurtin, will modified that | 17:45 |
| gatox | briancurtin, done | 17:48 |
| dobey | gatox: you can build the nightlies sources locally i guess | 17:50 |
| dobey | gatox: in a chroot with pbuilder or sbuild, i mean | 17:50 |
| dobey | gatox: or you can use bzr dailydeb and pbuilder or sbuild to build the recipe locally | 17:51 |
| gatox | dobey, ok.... i'll try that..... because this is not going anywhere like this..... thx dobey !! | 17:51 |
| dobey | sure | 17:53 |
| dobey | anyone know anything about userContent.css in firefox? | 18:18 |
| mmcc | nope, sorry… | 18:20 |
| dobey | it would probably be faster for me to get a patch deployed to launchpad, than it would be to figure out how to use it | 18:21 |
| mmcc | what are you trying to fix? | 18:21 |
| dobey | the font size for launchpad.net/+apidoc | 18:22 |
| mmcc | ah. | 18:25 |
| mmcc | speaking of the LP api, what's a good project to look at for examples of how to use the api? (for instance, how to get a list of active bugs for a given project) | 18:28 |
| mmcc | I've been meaning to make the bzr zsh completion function actually useful | 18:28 |
| mmcc | you know, in that copious free time | 18:28 |
| dobey | well, there's bzr of course; and lp:lptools | 18:30 |
| dobey | and tarmac | 18:30 |
| dobey | lptools may or may not be great. it's sort of a jumble of stuff right now and not particularly well organized | 18:30 |
| gatox | mmcc, there is a python lib to interact with launchpad.... but i don't know how much it supports | 18:31 |
| mmcc | is that lptools or a different thing? | 18:31 |
| dobey | launchpadlib | 18:32 |
| dobey | gatox: it supports everything in the 1.0 at least i'm sure; or at least, most everything | 18:32 |
| mmcc | ah, ok | 18:33 |
| dobey | i'm actually writing a script right now; which is why the +apidoc page is annoying me | 18:33 |
| gatox | dobey, cool........ mmcc someone even made a Unity Lens to interact with launchpad from the dash..... | 18:33 |
| briancurtin | gatox: quick review to fix a failing share-related test: https://code.launchpad.net/~brian.curtin/ubuntuone-control-panel/fix-file_path-construction/+merge/131966 | 18:33 |
| gatox | briancurtin, on it! | 18:33 |
| mmcc | thanks guys. So I'm guessing most people using bzr use bash, judging by the bash-completion builtin command :) | 18:36 |
| ask4ubuntu | how can i completely remove my ubuntu one account from the server? | 18:36 |
| chaselivingston | ask4ubuntu: Hi, could you submit the form at http://one.ubuntu.com/support/contact so we can get some more information from you? | 18:36 |
| dobey | it's really annoying that the element inspector thing in firefox doesn't have a "save these changes to usercontent.css" button | 18:36 |
| gatox | briancurtin, +1 | 18:42 |
| briancurtin | gatox: thanks, i noticed it when testing your branch. looks like your tests pass, testing IRL now | 18:42 |
| gatox | briancurtin, i don't know if i already told you this, this branch has been updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/new-share-design/+merge/131397 | 18:43 |
| gatox | briancurtin, awesome, thx | 18:43 |
| briancurtin | ah yeah i saw you updated | 18:43 |
| gatox | briancurtin, ahhh cool | 18:43 |
| * mmcc goes to lunch… | 18:54 | |
| briancurtin | anyone have a way to get past this without actually fixing it right now? https://pastebin.canonical.com/77395/ i can't test any of these branches and would rather not hold that up | 19:01 |
| dobey | briancurtin: not sure, but i'd start by avoiding syncing of all extra shares/folders to that machine as a start; quitting syncdaemon, destroying metadata, and trying again | 19:19 |
| === m_conley is now known as m_conley_away | ||
| gatox | briancurtin, if you have some free slot for reviews, please: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/share-indicator/+merge/131973 | 19:40 |
| briancurtin | gatox: i'll add it to my list after i finish new-share-design and a few other things | 19:43 |
| gatox | briancurtin, yes, no rush..... thx | 19:43 |
| gatox | eod here! see you tomorrow people | 20:15 |
| dobey | yay script | 20:31 |
| mmcc | gatox, so this branch https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/share-indicator/+merge/131973 -- does it remove displaying incoming shares altogether? How does the user see incoming share requests now? (aside from in their email) | 20:42 |
| mmcc | I am especially curious because I'm working on the equivalent version for the mac menu | 20:42 |
| mmcc | Oh I guess I missed him… | 20:45 |
| briancurtin | yeah gatox signed off about 30 min ago | 20:45 |
| mmcc | d'oh | 20:45 |
| mmcc | I'll just add a comment to the mp then | 20:46 |
| dobey | hmm | 21:02 |
| dobey | in general, i think having a bunch of menu items that all open the same thing, but to a different tab, is probably a bad idea anyway | 21:04 |
| mmcc | hm | 21:06 |
| mmcc | well, the thing that went away was a list of shares where each menu item sent you to the web page to accept that share… | 21:07 |
| mmcc | (went away in that branch) | 21:07 |
| karni | mmcc: Does the u1cp know about non-yet-accepted shares? It doesn't, does it? | 21:15 |
| mmcc | karni: at least in the menu code, it *can* know about them, but only if the syncdaemon has them in its current shares list… the menu doesn't refresh the SD's shares list from the server | 21:17 |
| mmcc | the folders tab is another story | 21:17 |
| dobey | and winds are picking up here; so i should probably head off | 21:18 |
| dobey | later all | 21:18 |
| karni | take care dobey .. | 21:18 |
| karni | chaselivingston: I'm listening to the interview with you from supportops (or something) :) | 21:19 |
| mmcc | karni - the CP does show the not-yet-accepted shares in the folders tab, and it calls refresh_volumes before that, which *does* appear to refresh the list of shares (along with other stuff) from the server | 21:23 |
| karni | mmcc: Oh. Can you accept the share from within u1cp? I thought it was e-mail only. | 21:24 |
| karni | This is strange, I'm almost sure they don't show up in the u1cp before you click the accept link in the e-mail :) | 21:25 |
| karni | Things changed around that lately? | 21:25 |
| mmcc | karni - it sure looks like you should be able to, but I haven't tried it, and I got the same impression as you | 21:25 |
| mmcc | er, I mean I thought they were email only also, but the code looks like it thinks it gets a full list | 21:26 |
| mmcc | let me try something… | 21:26 |
| karni | mmcc: Share with me ;) | 21:26 |
| briancurtin | great, now SD doesnt even start via u1cp. | 21:50 |
| mmcc | briancurtin from source? let me know if I can help | 21:53 |
| briancurtin | mmcc: i think it has to do with my metadata problem or something. ready to just delete everything again and start over | 21:58 |
| briancurtin | could also be the 110 failing tests | 21:58 |
| mmcc | briancurtin yow. | 21:59 |
| briancurtin | i think i need to make jenkins louder when it fails | 21:59 |
| briancurtin | i think its really just three failures, as the same thing happens over 100 times | 22:00 |
| mmcc | might be running out of battery here in a minute… looks like I'll be back later tonight. | 22:24 |
| mmcc | Wish I'd known the un-accepted shares list was always empty before I wrote all those tests for that stuff | 22:24 |
| === mmccphone_ is now known as mmccphone | ||
| mmccphone | Laptop just died, stuck away from plug for another 20 min. Will come back tonight | 22:37 |
| === mmccphone_ is now known as mmccphone | ||
| Kruko | hi, ubuntu one crashes when i try to install it on ubuntu 12.04 LTS | 23:01 |
| Kruko | right after i enter in my password | 23:02 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!