| === m_conley is now known as m_conley_away | ||
| mandel | hello people!!! how is everything going? | 02:57 |
|---|---|---|
| mandel | mmcc, hello, is everything working? | 03:02 |
| mandel | or do we have any crazy problems? | 03:03 |
| briancurtin | mandel: no crazy problems that i know of | 03:12 |
| karni | mandel: yo, going good! | 03:27 |
| karni | Tons of work done, good day (Wednesday ;P). TODO: add genre to queue, create playlist+add to playlist UI, share the apk! | 04:16 |
| karni | 5 AM here, /me disappears | 04:17 |
| gatox | good morning | 11:20 |
| gatox | back again :P | 11:21 |
| ralsina_ | Bonjour! | 13:21 |
| briancurtin | hola | 13:21 |
| dobey | eh | 13:22 |
| gatox | ralsina_, hi | 13:23 |
| ralsina_ | So, is the house on fire already? | 13:23 |
| gatox | dobey, i almost get this thing to work..... it was raising the window if minimized..... but i touch something and is not working now...... | 13:24 |
| gatox | found it | 13:28 |
| dobey | gatox: was it actually opening a second instance? :) | 13:30 |
| dobey | ralsina_: sort of; read your e-mail? :) | 13:30 |
| gatox | dobey, yes..... that was another problem that i was defining the signal in the wrong way.... now i'm looking why sometimes raise the windows when it is minimized..... and other times just make the icon jump | 13:31 |
| ralsina_ | dobey: the "Design v implementation" thread? | 13:31 |
| dobey | ralsina_: yes | 13:31 |
| ralsina_ | dobey: am reading it | 13:32 |
| dobey | gatox: well, for me, i get neither of those. the icon stays still and the window stays minimized | 13:32 |
| gatox | dobey, nono.... i'm working in a new fix right now | 13:32 |
| dobey | gatox: great, let me know when to test :) | 13:33 |
| gatox | dobey, of course | 13:33 |
| ralsina_ | gatox: so, you are making the u1cp socket do something? | 13:35 |
| gatox | ralsina_, yap.... something really simple | 13:35 |
| gatox | ralsina_, i have a branch for that..... i'm just finishing with the part the always brings the window to the top | 13:35 |
| ralsina_ | gatox: that's always tricky | 13:36 |
| ralsina_ | gatox: there is code to do it in systray.py IIRC | 13:36 |
| gatox | ralsina_, yes, i'm doing the same: activateWindow() | 13:36 |
| gatox | ralsina_, but.... i'm seeing that sometimes restore the windows as it was..... and other times just make the icon in the launcher jump..... and i'm trying to figure it out why | 13:37 |
| ralsina_ | gatox: doesn't actually bring it to the top on all platfoms though because of focus stealing prevention | 13:37 |
| ralsina_ | gatox: if there is another window with kbd focus, you can't bring it to the top | 13:37 |
| gatox | ahhhh | 13:38 |
| gatox | ralsina_, well..... at least the icon jumping in that case is good enough | 13:38 |
| ralsina_ | yep, as good as it gets, really. | 13:38 |
| ralsina_ | unless there is a way I don't know, of course | 13:38 |
| gatox | dobey, if you can review this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/socket-communication/+merge/132409 that should do it....... ralsina_ that the branch that do the socket communication.... just in case you want to take a look at it | 13:41 |
| gatox | just removed the commented line | 13:42 |
| ralsina_ | gatox: taking a look | 13:44 |
| briancurtin | chaselivingston: would you mind working your magic to get logs from this person? https://bugs.launchpad.net/ubuntuone-client/+bug/1073404 | 13:48 |
| ubot5 | Ubuntu bug 1073404 in Ubuntu One Client "No Syncing at all with Windows Client (Windows 8 but could affect other Windows Versions)" [Undecided,New] | 13:48 |
| chaselivingston | briancurtin: sure, i'll add a comment | 13:49 |
| chaselivingston | briancurtin: ta da | 13:50 |
| briancurtin | chaselivingston: ah, easy enough | 13:51 |
| gatox | dobey, i didn't see that you were blocking this branch: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/new-share-design/+merge/131397 | 13:51 |
| gatox | dobey, do you still have some concers about that? i think that improves the ux a lot | 13:51 |
| chaselivingston | briancurtin: yeah, not too bad | 13:51 |
| dobey | gatox: yes, the language changes are a concern | 13:52 |
| gatox | dobey, did you see the last email of parrino? | 13:52 |
| dobey | gatox: yes, and i replied asking for the rationale, and explained why it is bad :) | 13:53 |
| * gatox starts to worry when he sees a lot of branch blocked..... :S | 13:53 | |
| gatox | dobey, parrino answered to your email | 13:56 |
| ralsina_ | gatox: you really need to document the "protocol" for communicating with a running u1cp | 14:00 |
| gatox | ralsina_, right there in the code? | 14:01 |
| ralsina_ | dobey: the change from "publish" to "share" is old news | 14:01 |
| ralsina_ | gatox: long comment perhaps | 14:01 |
| gatox | ralsina_, ack! will do right now | 14:01 |
| === m_conley_away is now known as m_conley | ||
| gatox | ralsina_, so..... we should move on with "Share a file" as it is, right? | 14:01 |
| ralsina_ | gatox: yes | 14:01 |
| dobey | ralsina_: old or not, i didn't even know about it until now; and it's still problematic :( | 14:02 |
| ralsina_ | dobey: if you can mail me your concerns I will be happy to address them | 14:02 |
| ralsina_ | dobey: sorry about making you repeat yourself | 14:02 |
| gatox | dobey, could you please unblock this 3 branches then? https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/share-indicator/+merge/131973 - https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/new-share-design/+merge/131397 - https://code.launchpad.net/~diegosarmentero/ubuntuone-client/menu-new-options/+merge/132106 | 14:02 |
| dobey | gatox: no, because the language is still wrong, even according to the latest mail. | 14:03 |
| ralsina_ | ok, get final copy approval from Roberta | 14:03 |
| ralsina_ | or... wait. | 14:03 |
| ralsina_ | let's clarify things :-) | 14:03 |
| ralsina_ | dobey: what language, specifically? | 14:03 |
| gatox | not following here...... as i understand "share" is ok | 14:04 |
| * ralsina_ has a 'can't leave for a week' feeling | 14:04 | |
| dobey | well, even if we use 'share' every, it's not just 'share' | 14:04 |
| dobey | we must differentiate correctly what is being shared | 14:04 |
| dobey | but still, the language doesn't clarify *how* which is a problem :-/ | 14:05 |
| gatox | i really don't understand...... this is following the same convention that we are using since a while ago.... as the design documents specified..... and we already have implemented in the client and running in the users machines | 14:07 |
| ralsina_ | dobey: the whole "share vs publish" thing we had is broken. It's share. We share by giving you a hard-to-guess URL you give people. We share folders by sending emails. Sure, we are inconsistent on how it's done, but both are "share". | 14:09 |
| dobey | the inconsistency is exactly the problem | 14:13 |
| dobey | but whatever | 14:13 |
| dobey | who should i assign all the bugs and questions to when users have problems with it? | 14:13 |
| ralsina_ | dobey: the team, and we'll reply | 14:14 |
| ralsina_ | dobey: or to me, if you want. | 14:15 |
| ralsina_ | dobey: I don't mind explaining that, just like the 10 we got about removing devices. It's like one a month :-) | 14:15 |
| dobey | any more than 0 is a problem :) | 14:16 |
| dobey | and having to continually explain it over and over is not a solution | 14:16 |
| ralsina_ | dobey: sure. But I think, in my opinion, this improves the product enough that getting half a dozen users confused is not a reason to not have it. | 14:17 |
| ralsina_ | dobey: compromises, and all that. | 14:17 |
| dobey | i doubt it's half a dozen that will be confused | 14:17 |
| ralsina_ | dobey: sure, I am making up numbers. We also don't know how many never find out that you can share/publish. When we added the new tabn in u1cp there were posts with titles like "u1 adds file sharing" | 14:18 |
| ralsina_ | dobey: because they never saw the context menu, and never found the feature | 14:18 |
| dobey | if we simply removed support for sharing folders. it would be much better | 14:19 |
| ralsina_ | dobey: it would be *simpler*. Not sure about better. But we are not removing it. | 14:20 |
| gatox | sooooo..... about the branches? | 14:29 |
| * gatox don't want to be annoying.... but it seems that they shouldn't be blocked | 14:29 | |
| ralsina_ | gatox: relax a little please :-) | 14:30 |
| gatox | okok :P | 14:31 |
| dobey | ugh, and still have the trailing cough and nastiness of a waning chest cold :( | 14:34 |
| mmcc | good morning folks. Hi ralsina! | 14:37 |
| ralsina_ | Aló mmcc! | 14:37 |
| briancurtin | weird...ubuntu_sso.constants not being compiled/generated | 14:39 |
| dobey | briancurtin: it's only built during setup.py install time | 14:40 |
| briancurtin | which we don't do on windows | 14:40 |
| mmcc | briancurtin - I just hit that yesterday. are you seeing this when running py2exe? | 14:40 |
| gatox | mmcc, hi | 14:40 |
| briancurtin | mmcc: i didnt notice when running py2exe (maybe i missed a warning/error), but i did when running the resulting installer | 14:41 |
| gatox | mmcc, i replied to your need fixing here: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/share-indicator/+merge/131973 that is already fixed in another branch i proposed | 14:41 |
| mmcc | briancurtin- dobey's recent lint-roller branch changed a 'import constants' to __import__() , which py2app didn't pick up - maybe py2exe has the same issue? | 14:42 |
| briancurtin | yep, just noticed that 1 second ago | 14:42 |
| briancurtin | could be it | 14:42 |
| dobey | hmm | 14:42 |
| mmcc | :D . yeah I had to add ubuntu_sso.constants to setup's includes… that fixed it for me | 14:42 |
| mmcc | gatox, looking now | 14:43 |
| briancurtin | although i think its kind of odd that it even worked before | 14:43 |
| ralsina_ | briancurtin: you may have had it installed | 14:43 |
| briancurtin | ah, yeah probably | 14:43 |
| dobey | sigh | 14:46 |
| mmcc | gatox, +1 on share-indicator then. | 14:49 |
| mmcc | brb, making coffee | 14:49 |
| gatox | mmcc, awesome! thx | 14:49 |
| ralsina_ | gatox, mmcc, dobey, briancurtin, mvo, joshuahoover: client-eng call in 3 minutes in mumble | 14:57 |
| gatox | ack | 14:57 |
| ralsina_ | who am I missing who's around today? | 14:57 |
| rockstar | ralsina_, didn't expect you today. | 14:57 |
| ralsina_ | karni if you are here | 14:57 |
| karni | ralsina_: Im at grantparents, cant attend the call. Will send you and email update. | 14:57 |
| rockstar | (I'm already in mumble) | 14:57 |
| ralsina_ | and rockstar of course | 14:57 |
| ralsina_ | sorry guys, I don'thave my notepad handy :-) | 14:58 |
| ralsina_ | rockstar: I will drop by next tuesday too | 14:58 |
| dobey | thursday | 14:58 |
| rockstar | Our team is eleventy billion people big now. It's understandable to forget people. :) | 14:58 |
| ralsina_ | thursday yes. Stupid english language ;-) | 14:59 |
| dobey | tuesday, thursday, share, publish; they're all the same, right? | 14:59 |
| ralsina_ | dobey: *this close*, you old troll ;-) | 14:59 |
| dobey | heh :) | 14:59 |
| dobey | gatox: some needs fixing issues on new-share-design | 15:06 |
| gatox | dobey, ack | 15:07 |
| mvo | ralsina_: I'm in a uds session currently, but I can skip this one and try to find a quiet place to join | 15:19 |
| dobey | mvo: no worries | 15:22 |
| ralsina_ | mvo: don't worry | 15:22 |
| ralsina_ | mvo: we can talk when you come back from uds | 15:23 |
| mmcc | is there a common known cause for a "ROOT_MISMATCH" error, like trying to use two user accounts on one system or something? I'm asking for a support question. The only thing I know of is to delete the syncdaemon metadata and start over, is that all we can do? | 15:25 |
| chaselivingston | mmcc: there is an faq for ubuntu an windows, but not sure how to do it for mac | 15:26 |
| mmcc | chaselivingston ack - I'm trying to answer your email :) | 15:26 |
| chaselivingston | mmcc: haha, thanks | 15:26 |
| mmcc | chaselivingston - the metadata is in ~/Library/Application Support/ubuntuone/ on macs | 15:27 |
| mmcc | I think for that error, also removing the SSO credentials from the keychain is probably not required. | 15:27 |
| chaselivingston | mmcc: ok cool, can you assign that ticket back to nobody and i'll reply? | 15:30 |
| ralsina_ | mmcc: ROOT_MISMATCH means you logged in with one account, then removed the device then logged in with another, there is no other way to cause it AFAIK | 15:31 |
| mmcc | ah, thanks ralsina_. | 15:35 |
| mmcc | so what will SD do if the user has stuff in ~/U1/ (that's from the earlier account) and starts a new SD with no metadata? do a local rescan and treat them all as added files, I guess? | 15:36 |
| ralsina_ | mmcc: right, will merge the contents of both accounts on the new one | 15:37 |
| mmcc | ralsina_ ok, will add that to the reply | 15:37 |
| mmcc | chaselivingston I replied via email, do you need me to re-assign it or does RT take care of that? | 15:42 |
| chaselivingston | mmcc: still need to reassign it so i'll see any further replies | 15:42 |
| mmcc | ok, here we go | 15:43 |
| dobey | ok, i need to get some lunch; bbiab | 15:52 |
| * gatox lunch | 16:14 | |
| === gatox is now known as gatox_lunch | ||
| === beuno is now known as beuno-lunch | ||
| === beuno-lunch is now known as beuno | ||
| dobey | gatox_lunch: did you see my comment on socket-comms branch? i am getting 2 instances of control panel with it | 17:26 |
| gatox_lunch | dobey, doing what? that is not happening here | 17:27 |
| dobey | gatox_lunch: running cp from that branch, opening another terminal from the same branch, and running it from there a second time with the first instance still running (with or without --switch-to arg) | 17:28 |
| dobey | weird, now it's not doing it | 17:28 |
| dobey | wtf | 17:28 |
| dobey | but it's not raising/focusing/switching tabs either | 17:28 |
| === gatox_lunch is now known as gatox | ||
| gatox | dobey, ok..... now i'll make the video.... i thought that wasn't necessary....... | 17:29 |
| gatox | dobey, are you sure you have everything up to date? | 17:29 |
| dobey | yes | 17:30 |
| dobey | and now it is opening multiple instances again | 17:42 |
| gatox | dobey, this is what i see: http://youtu.be/YI79cjfdMKQ | 17:43 |
| * mmcc has hit a bug in py2app regarding namespace packages. Ronald has already replied to my report, but in the meantime I'm going to have to really hack this so it'll copy a file in as a post-processing step… | 17:43 | |
| gatox | dobey, and http://youtu.be/hYUWCAT0cE0 | 17:43 |
| dobey | and now it's not; wtrf | 17:43 |
| dobey | gatox: it doesn't help that your launcher isn't always visible | 17:51 |
| dobey | gatox: but i'm not saying it doesn't work for you. i'm saying it doesn't work for me | 17:51 |
| dobey | so me seeing it work for you doens't help me really | 17:51 |
| gatox | dobey, yes....... but what i mean, is that maybe something is not working properly on your computer | 17:54 |
| dobey | doesn't | 17:54 |
| dobey | gatox: it's not working properly on either of my computers | 17:54 |
| dobey | which means it probably isn't going to work properly on a great number of peoples' computers | 17:54 |
| gatox | dobey, the only thing that i can think of.... is that for some reason the socket communication is failing for you | 17:59 |
| gatox | we can add a try-except there to avoid opening multiple instances when it fails.... but the part that doesn't give the focus to control panel is going to keep not working for those cases | 18:00 |
| dobey | it doesn't work as is | 18:00 |
| gatox | dobey, this branch has been updated: https://code.launchpad.net/~diegosarmentero/ubuntuone-control-panel/new-share-design/+merge/131397 | 18:00 |
| dobey | even when --switch-to does work for me | 18:00 |
| gatox | dobey, some reason i explained above | 18:01 |
| dobey | gatox: yes. but if it's not working for me, it's not going to work for most people either. | 18:01 |
| gatox | s/some/same | 18:01 |
| dobey | gatox: there is nothing special about this computer; it's a new quantal isntall, with ppa:ubuntuone/nightlies | 18:02 |
| gatox | dobey, i'm pretty sure that sending messages via socket is what is failing for you..... but i don't know why.... | 18:02 |
| dobey | gatox: well, --switch-to sometimes does switch the tab; but the window doesn't get focus or anything | 18:03 |
| mmcc | I'm about to try that branch on my precise install, just to see if we can triangulate here | 18:03 |
| dobey | basically the experience is no better than it already was | 18:03 |
| gatox | mmcc, please | 18:04 |
| mmcc | hm. I think we've broken switch-to somehow… I am seeing the second invocation of CP make the window visible, but not with key focus, and it is ignoring switch-to | 18:09 |
| gatox | mmcc, how are you doing it? | 18:10 |
| mmcc | what's worse, even when running just one instance of CP, I'm seeing it switch back to the folders tab after showing the tab I specify in switch-to | 18:10 |
| mmcc | I think this might be related to ralsina's change from a while back that switches to the folders tab after the credentials are found | 18:11 |
| mmcc | If your machine is fast enough you might not notice that it shows the tab you want while it's loading before going to the folders tab anyway | 18:12 |
| ralsina_ | everything is my fault ;-) | 18:12 |
| mmcc | gatox, I have no idea why it works correctly for you. maybe it's not ralsina's fault and there's a change you don't have? | 18:12 |
| dobey | oh right, virtualbox is broken by default on 12.10 :( | 18:12 |
| * gatox does a merge with trunk just in case | 18:13 | |
| mmcc | no, looks like all of trunk is in this branch | 18:14 |
| dobey | well, i was running it without merging into trunk; just branching gatox's branch directly | 18:14 |
| gatox | mmcc, nop..... merged with trunk and keep working here.... | 18:14 |
| dobey | but it's clearly not working right | 18:14 |
| gatox | mmcc, if it's not much trouble.... can you make a short video so i can see exactly what are you seeing? | 18:14 |
| gatox | or you dobey ^ | 18:15 |
| mmcc | gatox, what were you using to record? I don't have a mac screen recorder handy but maybe a linux one will work inside the vm | 18:17 |
| gatox | mmcc, kazam in linux | 18:17 |
| ralsina_ | EOD for me. I will read my email, so you know how to contact me if you need me. If you don't see you all next week! | 18:18 |
| gatox | ralsina_, bye.... enjoy | 18:19 |
| mmcc | bye ralsina_ - have fun | 18:19 |
| mmcc | awesome, I got a video of just the mouse pointer | 18:33 |
| dobey | gotta run a few errands. brb | 18:37 |
| gatox | dobey, mmcc i think i found a hackish way to force the focus and the raising | 18:45 |
| dobey | gatox: hackish how? | 19:17 |
| dobey | gatox: and how is it currently doing? is there no window.getFocus(timestamp=0) call you can do? | 19:18 |
| gatox | dobey, no.... you can grab the focus from another applicatoin..... you can grab the focus inside your application, but not steal it from other apps not related to yours | 19:19 |
| gatox | dobey, i'll propose this change now..... and test it if it's ok for you | 19:19 |
| dobey | gatox: eh? qt itself has no control over whether or not the app itself actually gets focus; that's all the window manager's doing, based on a timestamp | 19:20 |
| karni | Evening folks o/ | 19:21 |
| * karni was on national holiday today, visiting family, etc | 19:21 | |
| dobey | karni: are you coming or going? :) | 19:23 |
| karni | dobey: I was greeting :) hehe. I want to send an e-mail update to roberto (and maybe squeeze in some hacking while my family is busy ;P) | 19:23 |
| gatox | dobey, try now please | 19:24 |
| dobey | hehe | 19:24 |
| dobey | gatox: with that, the window moves, but still doesn't get focus | 19:26 |
| gatox | dobey, no, the focus part i don't think that is going to be possible to be resolve..... but at least u1-cp should appear in front of any other window | 19:27 |
| dobey | gatox: it raises, and moves the window; but i think i'd rather just not have it raise, if it's going to move as well | 19:27 |
| gatox | dobey, is going to move if the application is already open..... but this will ensure that is going to be raise even if it is minimized | 19:28 |
| mmcc | well, here's a bug I'm kind of surprised no one noticed yet - string translations are thoroughly broken on osx | 19:29 |
| mmcc | I guess that's next | 19:30 |
| dobey | mmcc: broken? | 19:30 |
| dobey | mmcc: should just always be english | 19:30 |
| mmcc | dobey, really? CP appears translated on linux for me… | 19:30 |
| mmcc | by broken I mean that it ignores your language setting and is always just english. are you saying that's what we're expecting for osx? I just never tested it until today… | 19:31 |
| dobey | mmcc: right, because we use gettext on linux | 19:31 |
| dobey | mmcc: we don't support translations on windows currently; i'd imagine we won't for osx either | 19:32 |
| mmcc | huh, ok. I'll make it a wishlist bug | 19:32 |
| dobey | qt itself doesn't use gettext; so making the translations work on mac/win will be quite a bit of work | 19:32 |
| gatox | dobey, we could do something like this: http://paste.ubuntu.com/1324578/ ..... i'm going to propose that..... i think it is the best solution | 19:32 |
| mmcc | dobey, I'm not sure it'd be that much work, we should be able to just ship the strings in the bundle and point gettext at them (although I haven't quite gotten that working yet after 5 minutes in the console, so maybe I'm wrong) | 19:33 |
| dobey | gatox: hold on, lets not do that | 19:33 |
| dobey | mmcc: well, on osx it might be easier than on win | 19:34 |
| mmcc | dobey maybe. my impression is it should be the same on both - just need to have a way to tell gettext where to find the files, and then ship the files in your bundle/installer | 19:35 |
| karni | rockstar: Around? | 19:35 |
| mmcc | there appears to be a way to point gettext at an arbitrary directory, but again I haven't gotten it working yet. will just braindump into this bug and move on… | 19:35 |
| gatox | dobey, i just proposed..... why not?? i think with that combination is the best behavior possible | 19:35 |
| dobey | is that what skype does? | 19:36 |
| karni | Guys, do you think we should allow enqueuing the same song in the play queue multiple times? say, songs: [A, B, C, D, A, X, Y, Z, A] ? | 19:36 |
| * karni is talking about the music app for Android | 19:36 | |
| dobey | karni: if the user wants to do that, i don't see why not | 19:36 |
| karni | dobey: Shucks ;] I realized only today I keep the "now_playing" column in Songs table, rather tha PlaylistSongs ;< ;) (Queue is a specific playlist) | 19:37 |
| karni | dobey: I agree with you. | 19:37 |
| * karni was looking for someone who'd say "no" ;D | 19:37 | |
| dobey | gatox: proposed as in pushed it in your existing branch? | 19:38 |
| gatox | dobey, yes.... i mean that | 19:38 |
| dobey | heh | 19:39 |
| dobey | it doesn't seem to work | 19:40 |
| dobey | or at least, it only does anything when the window is minimized, which doesn't help i guess | 19:41 |
| gatox | dobey, ok..... when it is not minimized..... is going to bring it to the front when another applicatoin DOESN'T have the keyboard focus..... if another app has the keyboard focus, is going to just make the icon jump in the launcher | 19:43 |
| dobey | there has to be some way to do the right thing in qt | 19:44 |
| gatox | mmmmm we might start playing with the winID..... and try to raise the running u1-cp from the one being executed before it exits..... | 19:45 |
| gatox | not sure if that will work..... but..... | 19:45 |
| dobey | hrmm | 19:47 |
| gatox | dobey, mmmmm..... i think..... that maybe we should need to write platform specific code using some os api to do that....... i can't find anyway to do it directly from qt | 19:52 |
| gatox | dobey, i've done it in c++ on windows....... using the windows api.... | 19:53 |
| dobey | bah, the qt documentation lies | 19:53 |
| mmcc | ok, so if I can use pyobjc to get the current preferred language (OS X doesn't set LANG for you), then adding translation support is just a couple lines of code. I addd that to the bug and that's it for now | 19:58 |
| dobey | + argv = ['ubuntuone-installer', '/usr/bin/ubuntuone-control-panel-qt'] | 20:06 |
| dobey | gatox: ^^ what the heck? | 20:06 |
| gatox | dobey, that's for the tests | 20:07 |
| dobey | gatox: i know it's the tests, but why is 'ubuntuone-installer' in there? | 20:07 |
| dobey | gatox: and why a full path string for the control panel? | 20:07 |
| gatox | dobey, i could add anything there..... because the first two values for those tests are actually being ignored..... | 20:08 |
| gatox | dobey, for those tests we want everything from [2:] | 20:08 |
| dobey | right | 20:09 |
| gatox | dobey, i don't have any problem if you want me to change that....... | 20:09 |
| gatox | i was just clarifying that are dummy values | 20:09 |
| dobey | gatox: i'd change them to at least be more reasoanble dummy values. 'ubuntuone-installer' should probably be python or something; it's easier to type, and not something we've dropped :) | 20:10 |
| gatox | dobey, ack....... changing it | 20:11 |
| dobey | and i'd at least remove the /usr/bin/ if only to make the test slightly more readable/cross-platform friendly (even if it is ignored) | 20:11 |
| rockstar | karni, I am now. | 20:11 |
| karni | rockstar: Do you think we should allow enqueuing the same song in the play queue multiple times? say, songs: [A, B, C, D, A, X, Y, Z, A] ? | 20:12 |
| rockstar | karni, we do on the web player. | 20:12 |
| karni | rockstar: I agree with dobey, there's no reason we shouldn't. At the same time, is it usually intentional or a mistake to enqueue the same song on the play queue I wonder. | 20:12 |
| karni | rockstar: Right. Shit, I placed the now_playing column in the wrong table. | 20:12 |
| karni | Looks like I'll have to move it to the PlaylistSongs table from the Songs table. | 20:13 |
| karni | rockstar: I was laughing today when I saw more than one "now_playing" indicator on the play queue (same song, enqueued multiple times). | 20:13 |
| karni | It would be too easy to disallow enqueuing same song ;) | 20:14 |
| dobey | really, the play queue (or playlist, or whatever similar thing) should just be a list of song ids, like [song1_id, song2_id, …] and it shouldn't matter if they repeat or not | 20:15 |
| karni | dobey: I agree. And it is in my case. | 20:16 |
| karni | Just persisting state in the wrong place ;) | 20:16 |
| gatox | dobey, branch updated | 20:16 |
| * briancurtin lunch | 20:21 | |
| gatox | ok..... eod here........ see you tomorrow people! | 20:56 |
| dobey | later all | 21:31 |
| === m_conley is now known as m_conley_away | ||
| mmcc | hmm, I'm getting multiple instances of control panel launched from my menu. I'm building with diego's socket-comm branch… maybe I need to update it? | 22:48 |
| mmcc | that's weird, now it's working correctly and all I did was add a print and rebuild the app | 22:53 |
| mmcc | ok, pyobjc menu works when packaged in the main app and run directly. now just need to change CP to run the menu at startup and not kill syncdaemon on quit, and we're in good shape. definitely took longer than expected, ran into some tools bugs along the way | 23:03 |
| mmcc | I'm done for today. will wrap this up tomorrow | 23:03 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!