[11:56] bcsaller: good morning. When you have time, please ping me. I need to check with you about the aggregation card. It is already implemented, but I need to check about how it would we enable the debugging mode of this thing. Tkx. [12:15] morning [12:53] bac, hi, did you already start work on #1074298? [12:53] <_mup_> Bug #1074298: charm panel search results page should match visual design < https://launchpad.net/bugs/1074298 > [12:53] teknico: no, last night there were no open spots [12:54] bac, would you like to pair on it? [12:55] teknico: sure, but i warn you my internet has been really bad. but we can try. [12:55] i'm doing a trivial branch to fix a problem in the Makefile but will be ready to start in a little bit, teknico [12:55] bac, ok, great, I'll get something for lunch in the meantime [13:05] bac: tkx for taking some time to review my branch. :) [13:05] tveronezi: np. very nice work. [13:12] Bring me your tired, your poor, your huddled masses yearning for reviews [13:21] * benji stumbles in from the other room. [13:21] lol [13:23] bac, for your Makefile branch, trying to figure out how to dupe what you did. I guess you manually cleaned out app/assets/sprite without running make clean? Or is there another way to trigger the situation? [13:23] dupe the initial problem I mean [13:23] make clean [13:23] make [13:23] touch some png [13:23] make [13:23] boom [13:23] wfm. will try again [13:23] oh, touch some png. [13:23] did you do the touch? [13:23] no will try that [13:23] yes, that triggers the target [13:24] yeah makes sense [13:24] it seemed trivial enough to self review [13:24] boom! [13:25] agree bac [13:25] I thought you didn't so I was looking at it [13:25] if you were already merging it then I'll move on [13:25] oh, sorry. [13:25] it is merged [13:25] oh cool [13:25] moving on then :-) [13:25] thanks [13:25] too bad we have this problem with claiming reviews [13:25] y [13:26] make [13:26] oops [13:26] anyway, irc is the best we have afaik [13:29] gary_poster: do you have a min? [13:29] frankban, yes [13:29] hi jovan2, mattuk1972: i landed a branch yesterday with the two radius button styling for 'deploy' and 'cancel' in the charm panel. take a look please. [13:30] gary_poster: I'm in juju-ui hangout [13:30] ok [13:30] hi bac, will do. [13:31] bac: they don't really bear enough relation to the suru style imo -they almost look like a straight line edge [13:31] jovan2, mattuk1972: if you think it needs tweaking perhaps you can play with the values using the interactive CSS editor in chromium [13:31] mattuk1972, bac, can also do that with you [13:32] frankban, hangouts is unhappy... [13:32] gary_poster: i don't understand what you mean [13:32] bac, do it in hangout. share screen [13:32] gary_poster: :-/ [13:33] mattuk1972: i'm free to do a screen sharing hangout if you have a moment [13:33] frankban, going to try restarting. after that will try reinstalling [13:34] bac: I'm in the hangout === gary_poster|away is now known as gary_poster [13:34] hopefully in the right one [13:41] mattuk1972: ok, i'll join now [13:42] mattuk1972: you still there? if so can you paste the url you're using [13:42] https://plus.google.com/hangouts/_/409819056ea1551523432ac63f4df4a6feaa5922?hl=en-US [13:48] tveronezi, you have plenty of reviewers for the filter-buttons branch, right? IOW, I can't help there? [13:49] gary_poster: its done already. Mayko and bac did it. Thanks. [13:49] awesome [13:50] gary_poster: I will move the card to the ui review lane. [13:50] great [13:54] * gary_poster thinks that the html5 placeholder behavior is annoying [13:54] * gary_poster thinks it is less confusing if the text disappears on focus [13:55] * gary_poster came to this conclusion when using another site last night [13:55] * gary_poster returns to regularly scheduled programming [13:59] branches that need reviews: [14:00] I need two reviews of this one: https://codereview.appspot.com/6814089/ [14:00] Makyo needs two of https://codereview.appspot.com/6782063/ . I will do one. [14:00] World ^^^ [14:04] * benji looks at https://codereview.appspot.com/6814089/ [14:06] ty :-) [14:07] gary_poster: looking at Makyo branch [14:08] thanks frankban . When I merge trunk tests fail, fwiw. Trying to remember which charms are subordinate also :-) [14:09] http://jujucharms.com/charms?sub=1 [14:10] frankban, I think the branch has bitrotted enough (over a week in review queue) that we need Makyo to polish it up, thngs are noty quite working for me [14:11] I'm going to halt my review for now with that note [14:12] gary_poster: makes sense, so, I won't proceed, and back to my branch after a launchpad review! [14:12] frankban, sounds good. [14:24] bac, can I move "Makefile broken" card to done done? [14:24] yes [14:24] thx [14:29] jovan2, mattuk1972 we have a goal of cards staying in one lane for no more than 24 hours. I recommend that for the design cards, but I [14:29] 'm thinking more of the UX review cards [14:30] it would be great to have those resolved one way or the other by the time of our call in 1.5 hours [14:30] We have five cards waiting for you, which actually fills up the WIP limit--which is arbitrary, but indicative of a blockage [14:31] hi gary_poster, will take a look at them in 2 ticks [14:31] thanks much jovan2 [14:41] gary_poster can you confirm that this is what is what I should be looking at: http://15.185.168.174:8080/ if there is no other link in the kanban card? [14:42] jovan2, correct (the more human friendly spelling for the same thing is http://uistage.jujucharms.com:8080/ ) [14:43] slightly more human-friendly, anyway :-) [14:48] bcsaller: do you have a minute to g+? [14:48] tveronezi: yeah, sorry I didn't get back right away [14:48] I'll hop on g+ now [14:49] ok... tkx. [14:50] gary_poster: I'm done with reviewing your branch. [14:50] gary_poster: Not sure what I should be looking at for the card Charm Panel Full Screen - it doesn't look any different to how it was before. I must be missing something… [14:56] bac: i had a play with the css and ill mail you [14:56] mattuk1972: great [14:59] thanks mattuk1972 [15:04] thanks benji [15:05] my pleasure [15:05] jovan2, the charm panel used to be a popup [15:05] before my branch [15:05] now it fills the right hand side [15:05] if you don't have any issues with it, I guess we can mark it as a victory :-) [15:06] unless you object, I'll do so [15:09] gary_poster, yes, sure, that's a victory! For now…. I thought by Full Screen you might have meant the full charm store! Which would have been a really great advance since yesterday! [15:10] lol [15:10] especially without UX and visual design :-) [15:10] thanks [15:11] gary_poster: I know you like to keep one step ahead if possible :) [15:11] lol true [15:11] benji, bac, lp2kanban needs to be taught about our two-review policy [15:12] it is trying to drag cards from reviewing to UX review after a single review [15:12] I guess I'll make a slack card [15:12] mmm [15:24] gary_poster: the card about indicator - can u shed some light? is that the "growl" type notification? [15:24] looking [15:26] mattuk1972, I think so. bcsaller made that card (I looked at its "history"). bcsaller, could you elaborate on those two cards you made so that jovan2 and mattuk1972 have a better idea of what we are requesting? [15:26] I think it relates to the notification wireframes here -https://docs.google.com/a/canonical.com/file/d/0BwQq-CeM0YioZGV5TS1sU3hvaFU [15:28] gary_poster, mattuk1972: Sure I can make some notes, the jist is the view all notification page isn't designed and I don't think we had final design for the menu now as it relates to the new charm panel, so both need to be discussed. [15:28] gary_poster: in regards to the charm panel -im not sure the fade out to close works that well? [15:29] mattuk1972, maybe I don't have privileges but I get "Sorry, the page (or document) you have requested does not exist." from that link [15:29] bcsaller: cool - will get onto that next [15:29] mattuk1972, cool, that's why we ask for your feedback. :-) slide up? slide right? [15:30] (the fade out is easiest to code so it's a good starting point in case it is OK visually :-) ) [15:43] gary_poster: seems some things in the visual design are no longer in the charm store? like the view sorter? show me all/recent/favourites? [15:45] things like the scroll bar design and font size/weight/colour and line spacing are all very different? [15:45] also the divider between cells and the cell colour? [15:45] and the position of the button and where the text should wrap [15:46] is there something you want me to do for review of these? [15:46] mattuk1972, depends on what it is. Remember we do things bit by bit also. Right now the only thing that is in that branch is converting it into a full right side panel instead of a popup. So in the case of the view sorter, I think you are talking about the drop-down. We didn't do that initially both because of time and because of lack of confidence in direction. I made a bug for the second part and talked to Jo [15:46] van about it yesterday. Bug is 1074296. [15:46] mattuk1972, since it is fresh on your mind, let's have a quick call [15:47] sure [15:47] I think we have everything coming along, but if we missed something, I should make another bug [15:47] mattuk1972, https://plus.google.com/hangouts/_/409819056ea1551523432ac63f4df4a6feaa5922?hl=en-US [15:59] bac bcsaller benji frankban jovan2 Makyo teknico tveronezi call in 1 [16:24] jovan2: do you have a minute to talk about the filter buttons? https://plus.google.com/hangouts/_/47a7aab138b3ca13a291c18caa947ae158f3d995?authuser=0&hl=en-GB [16:27] Oops, restart for updates, back in a bit. [16:33] lunch... brb. [16:39] gary_poster, oh, there was actually one more thing: [16:39] ok [16:40] gary_poster, can you please move that card from backlog into prototyping for me? [16:40] gary_poster, it's kind of hard finding it among the vast backlog sea :-) [16:41] :-) teknico I moved it to "ready to code" [16:42] I think we might be full even though it doesn't look like it [16:42] gary_poster, uhm, I cannot see it, which one is it? [16:43] teknico, bug 1074424 [16:43] <_mup_> Bug #1074424: Make GUI charm able to configure user & password for the rapi-rollup branch < https://launchpad.net/bugs/1074424 > [16:43] gary_poster: my card was automatically moved to UX review... but I think the correct path is 'active reviewing' and then UX review, right? [16:44] gary_poster, that one? user and password? something escapes me... [16:44] frankban, right. I'm hoping I might have just fixed it by renaming the columns [16:44] moving those back [16:45] teknico right sorry, was too quick, one sec [16:45] gary_poster: for UX reviews, hangout + screen share with mattuk1972? [16:46] teknico, bug 1074410 [16:46] <_mup_> Bug #1074410: Need juju GUI charm that connects to improv < https://launchpad.net/bugs/1074410 > [16:46] where I said it would be, now [16:46] :-) [16:46] gary_poster, thanks (you may have it some kanban bug, it said you moved this one earlier too, but then moved the other one) [16:47] s/have it/have hit/ [16:47] frankban, we are still shaking that out. Jovan also does reviews then. Why don't you try what you said and report back if it seemed to work well. The alternate approach is to just move the card to the UX lane and ask them to look at it without you [16:49] but then you need to make sure you clarify what they need to do [16:49] gary_poster, oh, and then I'll need the other card in misc for learning the tools, shall I make it? [16:49] teknico, put it in slack please, and +1 [16:50] gary_poster, will do [16:50] thank you [16:53] gary_poster: doesn't the second option require the branch to be already merged? [17:04] frankban, it usually is [17:05] that's why it is after "landing" [17:05] gary_poster: aha! ;-) [17:05] but I would prefer to have it earlier [17:05] as you expected [17:06] then our review period would require four reviews before landing though. oof [17:10] gary_poster: so, right now, if a fix is requested by UX we should 1) create another card, another branch, 2) hack 3) new review/UX review? [17:11] frankban, yes. if they specifically requested the branch, getting the review earlier probably makes sense. [17:15] new branch up for review: https://codereview.appspot.com/6821088 [17:36] anyone remember which days we did not have dinner provided in Copenhagen? [17:36] benji, frankban and bac both have notes on this [17:39] benji, coudl you please make a bug for your branch under review? [17:39] Makyo, I made bug for your firefox work and linked it to card [17:39] benji, you can ask me to make your bug too if you want :-P [17:40] gary_poster: I thought I asked lbox to make one. I will now ask you to make one. [17:40] :-) ok [17:40] * benji will soon be delegating all work to software or gary_poster [17:40] :-) [17:40] maybe it is in MP but not card... [17:40] nope [17:42] benji: here are my notes: http://pastebin.ubuntu.com/1334735/ [17:42] frankban: thanks [17:43] benji, heh, your MP comments don't really help the reviewer figure out what the heck to do :-P um...I'm copying over the text from Matt's original MP... [17:44] gary_poster: yeah, I felt bad writting that, but I didn't really know what else to say; I should have worked harder [17:45] updated in MP; transferring to bug... [17:49] frankban: do you remember how much the 2 zoner to/from the airport was? [17:49] I seem to recall 45 DKK [17:49] benji, you'll need a receipt for that I think [17:50] (I was burned on that in Montreal, for a lot more $$) [17:50] gary_poster: I might have one; are they worried that we walked and pocketed the money instead? [17:50] benji, or perhaps it is a business/legal requirement, since these reimbursements are not taxed? Not sure [17:51] but that was my guess [17:52] benji: 2 zones -> 24, 3 zones -> 36 ... and unfortunately I pay taxes on these reimbursements :-( [17:53] frankban: they you should expense the taxes, and then expense the taxes on the tax expenses, and then expense those taxes [17:53] * benji should start an international tax consultancy [17:54] benji: :-) [17:55] taxed on reimbursements: :-( I got concerned about that a while ago because of the high amount of money I was shelling out for ec2. In America we are not being (double) taxed for that money, according to the tax consultant we used. [18:00] gary_poster: If I were expensing as much on EC2 as you were, I wouldn't be concerned with the taxes as much as the DEA thinking that I was laundering an entire south-american country's economy through EC2 [18:00] lol [18:01] gary_poster: I need to change my consultant... and maybe my country :-) [18:01] :-) [18:01] gary_poster: expenses filed [18:01] cool benji, thanks. I will review all of those today [18:02] bcsaller: https://codereview.appspot.com/6821090 please take a look when you have some time. [18:02] tveronezi: yeah [18:04] frankban, I vote New Zealand (but you know that already) [18:06] heh [18:18] * benji downloads the Quantal ISO [18:18] benji: didn't you have one in your goody bag? [18:19] bac: ooh! I do. Thanks. [18:19] * bac is looking at his on the desk [18:21] Did my upgrade through the updates center. Took a while, and totally taxed the machine. Ah well. [18:22] Makyo: i did too. even found a bug, which i reported directly to mvo when i ran into him in the airport [18:23] turns out it doesn't like you plopping directories into /etc/apt/sources.d. tries to open them as files. [18:28] Ah :/ [18:38] * benji starts to upgrade with fear and trepidation. [18:59] brb... [19:32] * benji restarts into Quantal. [19:39] as always, some of my settings have been reverted to the default, but things appear to be working [19:42] benji: is your machine ready and able to do a quick hangout? i've got a layout problem i'd like some help on for just a bit. [19:42] bac: I think so [19:42] * benji tries to figure out how to launch firefox. [20:06] gary_poster: hey, you have a moment? [20:06] gary_poster: your presense is requested at https://plus.google.com/hangouts/_/b2ccac118e89d6e06b6e85a0dca260988e8a8d98?pqs=1&hl=en&authuser=0# [20:06] bac, y [20:06] gary_poster: could you join ^^ [20:07] grr, why does alt-tab not work [20:23] wfm [20:29] gary_poster, #1074336 has a card already, in Subdivide 7 [20:29] <_mup_> Bug #1074336: Environment view service menu has non-functional "unit" option < https://launchpad.net/bugs/1074336 > [20:29] Want me to link? [20:30] Makyo, mind if I just delete it in backlog? I kind of regard the backlog as a big trash pit. :-) I think hazmat wants to garden it later though [20:31] gary_poster, Sure, whatever works :) [20:31] (I actually don't care which one we delete, but it is ready to code) [20:31] cool thanks [20:39] benji, looking at your branch. So...where are you on the goals of the yui doc work? You and I are both diligently commenting on the option-type functions, like line 23 of https://codereview.appspot.com/6821088/diff/1/app/views/environment.js?column_width=80 [20:39] We are using a yuidoc "trigger" of /** [20:39] but yuidoc will never pick up on these [20:40] we're doing them because the linter complains otherwise [20:40] AIUI [20:40] gary_poster: I thought the yuidoc branch was merged [20:40] it is, benji [20:40] I must be talking past you [20:40] alongside you [20:40] in cross directions [20:41] gary_poster: hangout [20:41] benji, I'm talking about the philosophy of commenting these things [20:41] ? [20:41] k [20:41] juju-ui if it is available [20:41] it is [20:42] hanging out [20:42] gary_poster: I hear treadmill but I don't see you [20:47] * bac done. [20:50] gary_poster: I lost you. [21:05] bcsaller: do you have a minute for another pre-implementation chat? [21:05] tveronezi: yes, I'll hop on g+ [21:06] tveronezi: oops, occupied it looks like, we can open another [21:06] ok... on it... [21:27] gary_poster, What was the bad behavior you were seeing from subordinate services? (That broken test took a while, sorry, will make a card) [21:28] Makyo, on call [21:29] gary_poster, np [21:58] Makyo, hey. So, I added a subordinate, and it went to 0, 0 and never moved out. Then when I tried to make relationships they were tied to 0, 0 [21:58] (relationships from the subordinate) [21:59] if you can't dupe trivvially I'm happy to try and write up a recipe [21:59] though I am at my EoD [22:08] gary_poster, Sorry, stepped away. I can reproduce, but I get that in trunk. Was just curious. Will play around with it. Have a good evening :) [22:09] Makyo, oh ok [22:09] wondered about that but did not check [22:09] mm... [22:10] so I guess you can reload the page after adding a subordinate to TEST YOUR [22:10] oops, fun with caps lock etc [22:10] ...to test your branch [22:10] I'll look at it tomorry [22:10] have a good evening [22:10] Yeah, it seems to be a event-not-binding thing, but only for subordinates. I'll keep poking. Ciao