| gatox | bye all! | 00:05 |
|---|---|---|
| === mmcc_ is now known as mmcc | ||
| JamesTait | Good morning all! :) | 09:27 |
| ralsina_ | good morning! | 11:22 |
| gatox | good morning! | 11:32 |
| ralsina_ | Hola gatox! | 11:36 |
| gatox | ralsina_, hey! how are you? | 11:36 |
| ralsina_ | gatox: having fun at work! | 11:37 |
| gatox | jeje | 11:37 |
| ralsina_ | gatox: ok, not fun, just catching up with email :-) | 11:37 |
| karni | Good morning o/ | 12:13 |
| gatox | karni, hi | 12:14 |
| karni | hi gatox :) | 12:14 |
| ralsina_ | good morning karni! | 12:14 |
| karni | Hello ralsina_, how's it going? | 12:14 |
| ralsina_ | karni: trying to start to work... | 12:15 |
| karni | ralsina_: :) Back from holiday? | 12:15 |
| ralsina_ | karni: well, I still have tomorrow off | 12:15 |
| karni | aha! :) | 12:15 |
| ralsina_ | but working today | 12:15 |
| * karni nods | 12:16 | |
| ralsina_ | karni, gatox: any branches that need reviews? | 12:16 |
| gatox | ralsina_, nop.... just getting up to date with c++, unity and nux lately | 12:16 |
| karni | ralsina_: Not currently, no :) | 12:17 |
| ralsina_ | gatox: need aspirins? They sell nice 500 pill bottles here | 12:17 |
| gatox | ralsina_, jejee | 12:17 |
| karni | Updating the music library with recent changes to music API v2 | 12:17 |
| ralsina_ | karni: cool | 12:18 |
| ralsina_ | karni: I saw some mails about missing assets and such, need me to ask someone about them? | 12:18 |
| karni | ralsina_: I'll ask patricia if she knows about anyone being assigned to it. If not, I'll ping you. | 12:19 |
| ralsina_ | karni: cool | 12:20 |
| ralsina_ | karni: also, not sure if I answered your email, but your vacation request, there should be no problem at all | 12:20 |
| karni | ralsina_: ah, thank you | 12:20 |
| === mmcc_ is now known as mmcc | ||
| karni | ralsina_: I sent you an e-mail. Could you fwd it as a manager, to make it formal :)? All info included. | 12:34 |
| ralsina_ | karni: no problem | 12:34 |
| karni | Thanks! | 12:34 |
| karni | ralsina_: oh, you could Cc me as well heh :) (if you haven't sent it yet) | 12:38 |
| ralsina_ | karni: haha, sure | 12:38 |
| ralsina_ | karni: done | 12:41 |
| karni | Thanks ralsina_ ! | 12:41 |
| === mpt_ is now known as mpt | ||
| dobey | ralsina_: btw, is meeting in 1 hr or 2? | 14:01 |
| ralsina_ | dobey: calendar says 2 | 14:02 |
| dobey | ralsina_: that's what i said on monday, but for some people it says in 1 hr apparently. and we've been having the standup 1 hr from now all week | 14:03 |
| ralsina_ | dobey: I am lost as to what time 1hr from now is for our western folks | 14:04 |
| karni | dobey: ralsina_: This is interesting. Google Calenda tells me Oct 29 - Nov 2 the stand up was 16:00. Before, and *after* (so now) it's back to 17:00 | 14:04 |
| karni | wtf.. | 14:04 |
| ralsina_ | everyone shift-f5 :-) | 14:04 |
| karni | Still same (even ctrl+f5, not sure which one it is in chromium) | 14:05 |
| karni | ralsina_: srsly, I have had the standup at 16:00 for just two weeks. Super weird. | 14:05 |
| karni | dobey: It tells me back 17:00 now, although I still see 16:00 Oct 20 - Nov 2 | 14:06 |
| karni | Confusing. | 14:06 |
| karni | Maybe someone changed it accidentally. Or what not. | 14:06 |
| ralsina_ | Alejandro has bad internet issues. let's have just a standup today, and I will popup just for the call tomorrow | 14:07 |
| karni | okey | 14:07 |
| dobey | ralsina_: 1hr from now for california is ~7am | 14:08 |
| dobey | will be ~8am for rockstar | 14:08 |
| ralsina_ | dobey: ugh | 14:08 |
| ralsina_ | so, 2h from now | 14:08 |
| ralsina_ | so it's at least livable | 14:08 |
| karni | yeah | 14:09 |
| dobey | ok | 14:09 |
| * karni feels sorry for mmcc having had standup at 7 am | 14:09 | |
| dobey | in 2h with call tomorrow sounds good | 14:09 |
| * dobey sort of glad alecu is having net issues then :) | 14:10 | |
| dobey | have to be somewhere in ~2.5 hrs | 14:10 |
| karni | ralsina_: You guys won't be able to comment on ~ubuntuone-android-hackers owned branches, will you? | 14:17 |
| ralsina_ | karni: probably not | 14:17 |
| ralsina_ | karni: dobey probably can though, he has super-launchpad-powers | 14:17 |
| karni | ralsina_: reassign to ubuntuone-hackers ? | 14:17 |
| ralsina_ | karni: even better | 14:17 |
| karni | ralsina_: super powers dont count! :) | 14:17 |
| karni | ok | 14:17 |
| dobey | oh | 14:18 |
| dobey | karni: add ~ubuntuone-hackers to ~ubuntuone-android-hackers | 14:19 |
| dobey | ralsina_: not quite superpowers; only demi-super-powers :) | 14:19 |
| karni | dobey: circular dependency - won't that be just plain strange.. ? | 14:19 |
| ralsina_ | dobey: like "nice-powers"? | 14:19 |
| gatox | everyone....... if anyone is having problems trying to run unity from sources let me know.... i've fight with that.... and i win! jeje (alecu's suggestion) | 14:19 |
| karni | dobey: now that I'm part of client engineering, I don't think branches belonging to ubuntuone-android-hackers are appropriate. | 14:20 |
| karni | gatox: gj :) | 14:20 |
| dobey | karni: hrmm; maybe we should do some rearranging at the sprint then | 14:21 |
| karni | ralsina_: dobey: uh oh! even better, ubuntuone-client-engineering | 14:21 |
| ralsina_ | karni: yes | 14:21 |
| ralsina_ | dobey: oh yes we should | 14:21 |
| karni | dobey: ubuntuone-android-hackers (and ubuntuone-ios-client-team) are becoming obsolete, I think | 14:21 |
| dobey | karni: even better would be to move all the main branches under ubuntuone-control-tower; and have tarmac manage them | 14:21 |
| ralsina_ | dobey: groups are even messier thn before | 14:21 |
| karni | ralsina_: dobey: should we set up a 'private' wiki on what to discuss on the sprint, so we dont' loose track? | 14:21 |
| dobey | karni: let's not do anything with them until next week then | 14:22 |
| karni | dobey: sure. I'll just move one branch. | 14:22 |
| ralsina_ | karni: good idea. Go ahead, volunteer Michal! :-) | 14:22 |
| dobey | karni: there is a wiki page already; we could add it there :) | 14:22 |
| karni | ralsina_: consider it done :) | 14:22 |
| karni | dobey: you're right, I'll do that | 14:22 |
| jgdx | What does "getting information, please wait" really mean? | 14:30 |
| ralsina_ | jgdx: literally, it's trying to connect to another process or a server to get information. | 14:31 |
| jgdx | ralsina_: thanks! Can that process take over 10 minutes or shall I assume something has gone wrong? | 14:32 |
| karni | ralsina_: gatox: dobey: Okey guys. This is a merge proposal into an experimental branch. I apologize for the diff size, let's blame it first on me, then the re-org. I don't expect one person to review it all, but it should give you a picture on what I am working with. And I had to finally commit to start throwing sensible-size MPs next. https://code.launchpad.net/~ubuntuone-client-engineering/ubuntuone-android-music/v2-playback-and-misc/+merge/133488 | 14:32 |
| ralsina_ | jgdx: something has gone wrong, it should take a couple of seconds or so | 14:32 |
| jgdx | ralsina_: roger, thank you. | 14:33 |
| ralsina_ | karni: the going rate is one pint every 100 lines above 1000. | 14:33 |
| ralsina_ | karni: j/k | 14:33 |
| gatox | karni, yay! | 14:33 |
| ralsina_ | karni: but whoa, dude | 14:33 |
| karni | ralsina_: 'going rate' sounds really bad x) | 14:33 |
| karni | ralsina_: I understand if you bash me. That's the last time this happens, I promise :3 | 14:34 |
| ralsina_ | http://www.businessdictionary.com/definition/going-rate.html | 14:34 |
| ralsina_ | karni: it's ok, it happens. Once :-) | 14:34 |
| karni | ralsina_: comission? ouch! x) | 14:35 |
| karni | Yeah I promise to be a good boy regarding diff size from now on. | 14:36 |
| karni | So, while I don't expect anything close to thorough review, if you notice something interesting when skimming it, feel free to ask. As the MP message mentions, there are some TODO's and XXX's left in the code as its WIP. | 14:40 |
| gatox | karni, i'll review it in a few hours if that is ok.... | 14:42 |
| karni | gatox: More than okey. If you decide do read through it all, you're pretty hardcore. Don't do it, you may loose your eyes ;P | 14:43 |
| gatox | jejeje | 14:43 |
| karni | (and I don't mean code style, but the monitor! :) ) | 14:43 |
| karni | /s/monitor/screen | 14:43 |
| === m_conley_away is now known as m_conley | ||
| briancurtin | mumble? | 15:00 |
| dobey | briancurtin: just standup today; and it's in 1hr from now | 15:00 |
| briancurtin | ah | 15:00 |
| dobey | briancurtin: we'll have the team call tomorrow | 15:03 |
| mmcc | Hi folks, so the google calendar is right for the meeting time after all? | 15:17 |
| karni | mmcc: Now, to me, it is. | 15:19 |
| karni | gatox: What's the stand up time for you in calendar? What was it last week? | 15:19 |
| gatox | karni, let me check...... i usually just remember :P | 15:20 |
| gatox | karni, 12:00 ART last week....... 13:00 ART today | 15:21 |
| karni | hah, so it wasn't just me | 15:22 |
| ralsina_ | let's sincronize our watches! ;-) | 15:26 |
| ralsina_ | And let's have the team call in ... 24:34 hours from ..... now. | 15:26 |
| dobey | karni: well, ART doesn't have DST :) | 15:28 |
| dobey | karni: so that makes sense for it to change for the .ar people at least :) | 15:28 |
| karni | dobey: I don't track when time changes in Poland (although usually a friend mentions it). I am just puzzled the meeing was moved back 1 hours for two weeks, and is back at 5 am in my calendar now :) | 15:29 |
| karni | dobey: Actually, if they don't have DST, it should never change for them, only for us. | 15:32 |
| ralsina_ | even if we had in .ar DST now would be a horrible time to put it in effect. You know, it being almost summer ;-) | 15:32 |
| karni | :D | 15:32 |
| ralsina_ | karni: it depends on who created the event | 15:32 |
| ralsina_ | karni: it follows *his* DST changes. | 15:33 |
| karni | ralsina_: I think we should cancel DST in Poland (like they did in Russia or Ukraine.. can't remember) | 15:33 |
| karni | ralsina_: That would make sense. | 15:33 |
| ralsina_ | we once cancelled 2 days before the time it was to start, and broke debian. What other country can claim to have broken a linux distro? | 15:33 |
| karni | hahaha | 15:34 |
| dobey | ralsina_: btw, calendar also shows that you have a call with cristian at the same time as the team call today :) | 15:57 |
| ralsina_ | dobey: yes, that has been there for 3 weeks ;-) | 15:58 |
| dobey | ah; just noticed it now, when i added that calendar to evo :) | 15:58 |
| dobey | anyone else want to review https://code.launchpad.net/~jbicha/ubuntuone-control-panel/dont-show-in-gnome-system-settings/+merge/133398 as well? | 16:00 |
| gatox | me | 16:00 |
| karni | me | 16:00 |
| rockstar | me | 16:00 |
| dobey | me | 16:00 |
| briancurtin | me | 16:00 |
| dobey | alecu, mmcc, mvo? | 16:01 |
| mmcc | me | 16:01 |
| ralsina_ | me | 16:01 |
| ralsina_ | alecu is down | 16:01 |
| ralsina_ | go gatox | 16:02 |
| gatox | DONE: | 16:02 |
| gatox | All branches landed. Get Nux and Unity to compile in my machine (some troubles with the steps in the wiki), and run unity from sources. Keep getting up to speed with C++ and nux. | 16:02 |
| gatox | TODO: | 16:02 |
| gatox | Keep studying and preparing the things for the trip. | 16:02 |
| gatox | BLOCKED: | 16:02 |
| gatox | No | 16:02 |
| gatox | karni, go | 16:02 |
| karni | DONE: Proposed merge to experimental U1M v2 branch. With ralsina, poked design about art assets. Two support tickets. Hacking on the music lib. | 16:02 |
| karni | TODO: Still working on the music lib update. | 16:02 |
| karni | NEXT: rockstar | 16:02 |
| rockstar | DONE: Killed a slew of unused code paths in iOS music app; ran pre-sprint errands | 16:02 |
| rockstar | TODO: Continue reducing tech debt in iOS | 16:02 |
| rockstar | BLOCKED: Nein | 16:02 |
| rockstar | NEXT: dobey | 16:02 |
| dobey | DONE: 4.0.0 packages in beta/stable PPAs, bug #1076123 | 16:02 |
| dobey | TODO: bugs, prepare for sprint | 16:02 |
| dobey | BLCK: None. | 16:02 |
| ubot5 | Launchpad bug 1076123 in dmedia (Ubuntu Raring) "Remove desktopcouch from Ubuntu archives" [Undecided,Fix released] https://launchpad.net/bugs/1076123 | 16:02 |
| dobey | briancurtin: go | 16:02 |
| briancurtin | DONE: updated installer to QA, setup laptop with unity/nux (build fails, but at least it "works"), look into SD not starting on windows | 16:03 |
| briancurtin | TODO: bug #1074391, also look into the WindowsError that is sometimes appearing for files being left open in other processes | 16:03 |
| briancurtin | NEXT: mmcc | 16:03 |
| ubot5 | Error: Launchpad bug 1074391 could not be found | 16:03 |
| mmcc | DONE: found issues with PB IPC, worked around | 16:03 |
| mmcc | TODO: build app, land some branches for cocoa menu | 16:03 |
| mmcc | BLOK: no | 16:03 |
| mmcc | NEXT: ralsina_ | 16:03 |
| ralsina_ | DONE: climbed eiffel tower (on the inside) TODO: finish catching up. BLOCKED: no NEXT: mmcc or mvo | 16:03 |
| gatox | ralsina_, nice "done task"! jeje | 16:04 |
| ralsina_ | EOM then | 16:07 |
| * gatox lunch | 16:09 | |
| === gatox is now known as gatox_lunch | ||
| briancurtin | ralsina_: i'm waiting to hear back about the installer from QA - while you're here, just to double check, this would be version 4.0.0? | 16:10 |
| dobey | ok, have to run for a while; lunch and some errands, may take a little longer than usual but hopefully not too long | 16:13 |
| dobey | bbiab | 16:13 |
| mmcc | oh, forgot a note for the meeting - I'm off tomorrow. | 16:14 |
| ralsina_ | briancurtin: right, 4.0.0 | 16:18 |
| karni | Hey guys, just to contrast the size of my previous MP, let's start with this 3 liner ;) https://code.launchpad.net/~ubuntuone-client-engineering/ubuntuone-music-java-library/update-stream-paths/+merge/133512 | 16:36 |
| karni | briancurtin: mind a review :) ? ↑ | 16:36 |
| karni | I think its our review day today. | 16:37 |
| briancurtin | karni: yep, it's my review day so i'm up | 16:37 |
| karni | kewl :) | 16:37 |
| briancurtin | although i'll review 3-liners any day | 16:37 |
| briancurtin | :) | 16:37 |
| karni | hehehe ;> | 16:37 |
| briancurtin | karni: i dont have the code for this, but is the URL in the test available anywhere as a constant? i see in StreamingClient.java you have API_PATH, but in the test you hardcode the URL - is there anything that could be common between the two? | 16:46 |
| karni | briancurtin: So, this is interesting. First, I plan to remove the host from hardcoded urls. Second, I hardcoded the URL to actually *test* if my constants and methods generate the proper url. If I used a constant (which would contain a typo), and the test would pass, the test would fail to exercise what it should. Is my incorrect by thinking like that? | 16:48 |
| briancurtin | karni: yeah that makes sense, just wanted to get a feel for why its done that way | 16:49 |
| briancurtin | looks alright to me, approved | 16:49 |
| karni | briancurtin: If I removed the host (which is actually clutter in the tests), I believe I could find a place for constant holding '/api/music/v2/songs/', yes. That should be an easy refactor though. Will keep that in mind. | 16:49 |
| karni | briancurtin: Sure! Thanks :) | 16:50 |
| karni | gatox_lunch: Here's a three liner, to ease on your rage after going through ???+ lines of XML and Java ^O^ https://code.launchpad.net/~ubuntuone-client-engineering/ubuntuone-music-java-library/update-stream-paths/+merge/133512 | 16:51 |
| ralsina_ | Nice talking to you guys, I am back on vacation, will be around for tomorrow's call | 17:11 |
| mmcc | bye ralsina_, see you in london | 17:12 |
| karni | Bye ralsina_ o/ | 17:15 |
| === gatox_lunch is now known as gatox | ||
| gatox | karni, looking | 17:17 |
| gatox | karni, +1 | 17:19 |
| karni | gatox: tnx :) | 17:19 |
| dobey | hmm | 17:39 |
| dobey | didn't take as long as i thought that would; yay | 17:39 |
| gatox | karni, ping | 17:49 |
| karni | gatox: pong! | 17:49 |
| karni | pif paf! | 17:49 |
| karni | What up :) | 17:49 |
| gatox | karni, jejej ....... i'm reviewing your branch..... i have a question | 17:50 |
| karni | gatox: oh :D go ahead! | 17:50 |
| gatox | karni, it has been a while since i don't code in Java...... i'm seeing this: private abstract class DownloadSongTask extends AsyncTask<Void, Void, Void> { | 17:50 |
| gatox | is that ok??... Void is recognized or should be: void | 17:50 |
| mmcc | briancurtin: since it's your review day, care to revisit https://code.launchpad.net/~mikemc/ubuntuone-control-panel/remote-folders-fix/+merge/126037 ? I just checked for conflicts and it looks clean… | 17:50 |
| karni | gatox: so, a null value in Java is null. Void is an *object* corresponding to null, but in the object world | 17:52 |
| gatox | karni, ahhhhh ok | 17:52 |
| karni | gatox: This means that this AsyncTask takes no arguments, passes on no progress, and returns nothing from the doInBackground | 17:52 |
| karni | gatox: But since arguments are required by the abstract class, you just pass in Void | 17:53 |
| gatox | karni, cool..... thx for explaining | 17:53 |
| briancurtin | mmcc: yep, i'll take a look | 17:53 |
| karni | gatox: pleasure! throw any Java questions at me, I'm aware folks on U1 team haven't coded in it recently/never | 17:55 |
| beuno | karni, did you know verterok did java for a living before joining Canonical? | 17:55 |
| beuno | :) | 17:55 |
| beuno | :p | 17:56 |
| gatox | karni, this was the last thing i did: http://quickdb.googlecode.com/ then..... as it says there: Delayed until the release of NINJA-IDE Version 1.0 (a python ide)..... and i never go back jejee | 17:56 |
| karni | beuno: I meant client-engineering ;) How do you have eyes on so many channels! | 17:57 |
| karni | beuno: Yes. And he wrote u1-java-storage-protocol :) | 17:57 |
| beuno | I have the dictionary on highlight | 17:58 |
| karni | hahahahahhah | 17:59 |
| * karni bursts in laughter :) | 17:59 | |
| karni | The whole dictionary, right ;)? | 17:59 |
| karni | gatox: Cool :) Something like hibernate. But self made, less enterpriseish, and cooler :) | 17:59 |
| gatox | karni, jejeje something like that...... i wanted to do something like hibernate, but we a really fast learning curve | 18:01 |
| gatox | but with | 18:01 |
| karni | yep : | 18:01 |
| karni | :) | 18:01 |
| gatox | i never release the latest version...... i turn completely to the python side jejeje | 18:02 |
| karni | gatox: You're just quicker there than I'll be ;) | 18:03 |
| gatox | karni, going back to your branch: https://code.launchpad.net/~ubuntuone-client-engineering/ubuntuone-android-music/v2-playback-and-misc/+merge/133488 at line 2885 you have a whole function commented | 18:05 |
| gatox | should that be removed? | 18:05 |
| karni | gatox: sorry, should have left a comment it's just a debug method. It's safe to be in the experimental branch, will never get to a development branch/trunk. But thank you for noticing. | 18:06 |
| gatox | ok | 18:06 |
| gatox | karni, line 3456 is commented code too........ is that useful for later? | 18:07 |
| karni | gatox: will remove :) | 18:08 |
| gatox | karni, awesome! now i feel useful! jejee | 18:08 |
| === mmcc_ is now known as mmcc | ||
| gatox | karni, ok.. it's a +1 from me..... the only things i found are the one i asked you about here | 18:10 |
| karni | gatox: Thanks man, I appreciate :)!! | 18:12 |
| gatox | :D | 18:12 |
| gatox | does anyone know if mandel is still alive? | 18:22 |
| dobey | if he's in thailand, i guess he's more alive than we are ;) | 18:26 |
| gatox | jejejeje | 18:26 |
| briancurtin | ha | 18:26 |
| gatox | dobey, i'm afraid that an elephant might eat him | 18:27 |
| gatox | you know..... they don't eat meat.... but they could make an exceptionn for mandel | 18:27 |
| mmcc | anyone else seeing problems pushing branches to lp? I can load web pages from bazaar.launchpad.net, but I'm getting ssh errors trying to push… | 18:32 |
| dobey | mmcc: btw, PB == perspective broker, not protocol buffer :) | 18:37 |
| mmcc | dobey: yeargh. I keep doing that | 18:38 |
| mmcc | I'm just going to start making up new names for it | 18:38 |
| dobey | parental bias | 18:39 |
| mmcc | thanks for fixing the bug | 18:39 |
| gatox | need to leave....... bbl! | 19:18 |
| karni | o/ gatox | 19:18 |
| * gatox is putting everthhing in order before travel | 19:18 | |
| gatox | jeje | 19:18 |
| karni | Out for late lunch | 19:20 |
| * briancurtin lunch | 19:28 | |
| === yofel_ is now known as yofel | ||
| dobey | brb | 19:35 |
| mmcc | so for the Q vm we need for NUX at the sprint, do I want to create a fresh VM or copy my precise VM and upgrade the copy? any downsides to that? | 19:35 |
| briancurtin | mmcc: not that im the best person to answer this, but i dont think it would matter | 19:58 |
| alecu | hello, all! | 20:09 |
| * alecu is back after some serious connectivity issues | 20:09 | |
| alecu | mmcc: in my experience, a clean install is usually better | 20:10 |
| mmcc | alecu: ok, good to know | 20:10 |
| briancurtin | has anyone else gone through the unity/nux setup yet? im pulling it up again, but was getting some build failures relating to some logging code, wasn't sure if i was missing something or if trunk is just broken (which is apparently to be expected...) | 20:16 |
| mmcc | pretty sure gatox has | 20:17 |
| mmcc | oh, never mind | 20:17 |
| mmcc | I will soon, waiting for my windows VM to copy off my laptop to make space | 20:17 |
| dobey | briancurtin: gatox was getting those same errors; not sure how he fixed it | 20:19 |
| briancurtin | i thought it sounded familiar | 20:20 |
| dobey | gotta run again; another appointment. bbiab | 20:39 |
| karni | yeah btw I'm back | 21:02 |
| briancurtin | if anyone has time for a very short review, could use a look here: https://code.launchpad.net/~brian.curtin/ubuntuone-control-panel/is_link-bytes/+merge/133559 -- it doesn't include tests because the tests would really go inside ubuntuone-client, and there apparently are no tests as it stands for that function anyway | 21:16 |
| karni | briancurtin: looking | 21:18 |
| karni | briancurtin: +1. Tag 1076485 -- what's this, bug number? | 21:20 |
| mmcc | hey, I'm trying to upload a build and the status is hung -- syncdaemon.log shows I'm getting continuous TRY_AGAIN errors from the protocol layer… anyone familiar with this? | 21:22 |
| mmcc | I can access the web site just fine | 21:22 |
| briancurtin | karni: yeah it's a bug number, it's https://bugs.launchpad.net/ubuntuone-control-panel/+bug/1076485 which was found by QA while testing the latest build for release | 21:24 |
| ubot5 | Ubuntu bug 1076485 in Ubuntu One Control Panel "Error after resyncing a folder" [Undecided,In progress] | 21:24 |
| karni | briancurtin: tnx | 21:25 |
| briancurtin | i just forgot to todo the --fixes on the actual change | 21:25 |
| karni | np, you can mark that on the merge proposal or the branch itself | 21:25 |
| briancurtin | ah, cool | 21:25 |
| dobey | back | 21:54 |
| karni | Damn it. I can't come up with a name for a class. | 22:04 |
| karni | dobey: Help me out :) I have a class ResultListener which has onStart, onSuccess<?>, onFailure, onFinish. The ? is the type of request result, the argument which onSuccess(.) is called with. I'd like to have a similar class, but for requests that do not return a result (onSuccess called based on response code). | 22:05 |
| karni | I can't come up with a better name than SilentRequestListener or NoResultRequestListener, both sound funny. | 22:06 |
| karni | I could rename the current one to ResultRequestListener, and have the argument-less one named RequestListener. | 22:07 |
| karni | dobey: briancurtin: What you guys think :) ↑ | 22:07 |
| briancurtin | NullRequestListener? | 22:08 |
| briancurtin | eh, maybe that makes it seem like it does null requests | 22:08 |
| karni | yeah, but I see you exactly get what I mean | 22:09 |
| karni | Now that I came up with it after speaking out loud, I think ResultRequestListener and RequestListener isn't a bad idea. | 22:09 |
| dobey | i guess i don't understand exactly | 22:09 |
| karni | Maybe I needed a rubber duck. | 22:10 |
| dobey | if they listen to responses, why aren't they FooResponseListener? | 22:10 |
| karni | dobey: I have a class, ResultListener, which has 4 methods. One of them is onSuccess(T a), where T is the parametrized type of the class. Say, RequestListener<String> | 22:10 |
| karni | dobey: ArtistRequestListener extends RequestListener<Artist> | 22:11 |
| karni | abstract void onSuccess(.) becomes: void onSuccess(Artist artist) { .. } | 22:11 |
| karni | When I update a playlist, I'm only interested in onSuccess() being called. Initially I just passed in Void type (something like an object corresponding to null/None) | 22:12 |
| mmcc | karni: how different is the new "silent" class? does it just have onSuccess with no parameterized type? | 22:12 |
| karni | then you have onSuccess(Void v) where you ignore v. looks a little strange. | 22:12 |
| karni | mmcc: exactly. void onSuccess() | 22:12 |
| mmcc | ah, I see. is getting rid of the Void type the only motivation for the new class? I'm no java expert but a Void there sounds ~ok to me | 22:13 |
| karni | I think I'll go with ResultRequestListener (although it sounds like a listener of "result request", which isn't all that bad..) | 22:13 |
| karni | mmcc: :)) | 22:14 |
| karni | k, thanks guys! | 22:14 |
| karni | mmcc: Yeah, only motivation for the code to read better. And not confuse the library users (developers) | 22:14 |
| karni | "oh what's that void doing in here?" | 22:14 |
| karni | You can do nothing with void, but it looks like it won't cost me much to refactor. | 22:15 |
| mmcc | how difficult is it to make a type synonym in Java? "typedef EmptyResponseData Void" or whatever? | 22:19 |
| mmcc | it'd be less confusing without adding extra classes to read… | 22:19 |
| karni | mmcc: It's actually a very simple, abstract class - https://pastebin.canonical.com/78031/ | 22:20 |
| mmcc | although I don't have strong feelings on this, like I said I'm not familiar with what the style is in Java | 22:20 |
| karni | mmcc: Your suggestion wasn't bad, one of the reasons I started that way :) I just didn't like this noise on the library interface side. | 22:21 |
| karni | mmcc: That pasted is actually already the parameterless request (returning no result, just simple onSuccess() callback) | 22:21 |
| mmcc | karni: fair enough. and there's plenty of IDE support for navigating class hierarchies in Java anyway, right… | 22:21 |
| karni | mmcc: To make an alias, you have to define a public class with a new name that extends the class you want to alias. Ehhh Java ;) | 22:22 |
| karni | yeah | 22:22 |
| mmcc | oh well, that totally sinks my idea. no improvement at all! | 22:22 |
| karni | :) | 22:23 |
| === m_conley is now known as m_conley_away | ||
| mmcc | I was thinking CPP or Haskell's 'type' keyword… it'd be "type EmptyResponseData = Void" | 22:25 |
| karni | mmcc: It's typedef in c++, right? | 22:26 |
| dobey | yes | 22:26 |
| dobey | well; could be a lot of things in C++ really, depending on how you do it :) | 22:27 |
| mmcc | karni: yes. although I was thinking CPP == /usr/bin/cpp | 22:27 |
| karni | mmcc: /usr/bin/cpp != g++ ? What's that :)? | 22:28 |
| karni | oh, the C preprocessor | 22:28 |
| mmcc | karni: yep | 22:28 |
| karni | Anyone up for a review? It's actually pretty easy, most of commit 30 was IDE supported refactor (read: boring) https://code.launchpad.net/~ubuntuone-client-engineering/ubuntuone-music-java-library/playlist-args-and-request-refactor/+merge/133587 | 22:59 |
| dobey | later all, have to run and get some stuff done before sprint | 23:02 |
| briancurtin | karni: i'll have a look | 23:02 |
| karni | briancurtin: Thanks :) | 23:02 |
| karni | later dobey | 23:02 |
| briancurtin | karni: you're missing a commit message on that one | 23:03 |
| karni | briancurtin: How do you mean? | 23:03 |
| karni | briancurtin: "Set commit message" ? | 23:03 |
| briancurtin | karni: yeah, but maybe your project doesn't use that? i'm used to it for other u1 projects where we use that for release notes, i think | 23:04 |
| karni | briancurtin: This is used by tarmac, isn't it? When I get code reviews, I used to simply push that MP to trunk. | 23:04 |
| karni | briancurtin: oh. I could start using that. | 23:04 |
| briancurtin | karni: yeah i think tarmac wont land the branch without a commit message | 23:04 |
| karni | Yes, I think that's correct. | 23:04 |
| briancurtin | karni: its not a big deal, i dont think. in fact i approved your other MP without even looking for that | 23:05 |
| mmcc | wow, I thought I was running out of space on this SSD - turns out I had 50 GB of core dumps in /cores | 23:05 |
| briancurtin | wow | 23:05 |
| karni | briancurtin: I have nothing against doing that, to go along other U1 projects. It'll force me to make smaller MPs so that I can describe them ;) | 23:05 |
| karni | mmcc: o_O | 23:05 |
| mmcc | yeah, I thought those got cleared out after a while, I guess no | 23:06 |
| mmcc | t | 23:06 |
| mmcc | anyway, plenty of space for a new VM! | 23:06 |
| karni | briancurtin: Do you write commit messages in past tense or present? "Made ... optional." or "Make .. optional." ? | 23:06 |
| * karni reads u1-servers log | 23:07 | |
| mmcc | karni: I usually do present tense. It's what the branch is doing… that said, as long as it's a clear, full sentence, the tense is not a big deal | 23:07 |
| karni | heh, very mixed I see | 23:07 |
| karni | mmcc: Got it :) | 23:07 |
| karni | briancurtin: I've set the commit message. | 23:10 |
| briancurtin | karni: cool, looking | 23:11 |
| karni | I decided to make it rather general. While this software is in heavy development, I'd have to be too detailing in those commit messages.. | 23:11 |
| briancurtin | karni: i approved that MP | 23:34 |
| briancurtin | and with that, i'm taking off. see everyone tomorrow | 23:34 |
| mmcc | I'm heading out now too - I won't be working but I'll look in occasionally tomorrow morning while I pack. | 23:42 |
| karni | Take care mmcc | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!