[11:49] <bac> morning mattuk1972
[11:49] <mattuk1972> hey
[11:50] <mattuk1972> bac: hey
[11:50] <bac> mattuk1972: did you ever get a chance to look at those cance/deploy buttons and decide if the latest tweaks are acceptable?
[11:50] <mattuk1972> i need to try and grap head of visual
[11:50] <mattuk1972> grap even
[11:50] <mattuk1972> grab
[11:50] <mattuk1972> !
[11:51] <mattuk1972> because he's the one we have to get it past
[11:51] <bac> mattuk1972: ok, cool.  i've got a card for it in UX review and get asked about it daily... :)
[11:51] <mattuk1972> ill make sure i pass it by him
[11:51] <mattuk1972> im sorry
[11:51] <mattuk1972> he's hard to pin down
[11:51] <bac> no prob.  gary bugs me.  i bug you.
[11:51] <mattuk1972> :-)
[11:52] <mattuk1972> was just going through the main charm store page and theres a bit of feedback (as usual)
[12:03] <frankban> bac: if you have time, could you please take a look at https://codereview.appspot.com/6827066? mostly CSS stuff.
[12:05] <frankban> mattuk1972: hi, I have a branch in review re charm confing panel, needing UX review. Do you want me to send screenshot, or do you prefer to wait for the branch to be landed and then review in staging?
[12:27] <mattuk1972> frankban: screenshot should be fine
[12:27] <frankban> mattuk1972: cool, thanks
[12:44] <bac> frankban: yes
[12:45] <frankban> bac: thanks
[12:47] <bac> frankban: in your MP description you say you followed the wireframe.  is that accurate or did you use the visual design document?
[12:47] <bac> charm-store-configure-layoutguide.pdf
[12:48] <frankban> bac: both
[12:50] <frankban> I used the png for measurements and the pdf for colors, sizes, etc...
[13:02] <bac> frankban: cool
[13:06] <mattuk1972> bac: store_front_review.pdf uploaded in char store folder of visual design
[13:06] <bac> mattuk1972: ok
[13:08] <gary_poster> mattuk1972, hi.  will you be around for today's retrospective call (right after the kanban call)?  we have a topic to discuss best ways to coordinate around designs and assets. If you can be there I'll put that first (after the kanban bits) so you can bow out after
[13:09] <mattuk1972> sure
[13:09] <gary_poster> ty
[13:14] <bac> frankban: nice function documentation!
[13:18] <mattuk1972> frankban: is that 16px text in the text fields? e.g. cassandra
[13:20] <frankban> mattuk1972: yes
[13:22] <mattuk1972> I think it should be 14. its just too huuuuuge? the text seems to line oddly in the vertical?  sometimes its really close to the top and sometimes to the bottom?
[13:23] <mattuk1972> frankban: also the cancel and confirm buttons should be the same size really
[13:28] <frankban> mattuk1972: for 14px, no problem, for the buttons, you mean the width?
[13:28] <mattuk1972> frankban: ya
[13:29] <frankban> ok, noted
[13:30] <mattuk1972> frankban: also everything should left align to the same place - at the moment the title and buttons and content all align diferently
[13:31] <mattuk1972> frankban: everything should be 10px in from the single grey pixel line div.
[13:34] <frankban> mattuk1972: ok, everything with 10px left padding. ah! but in the charm detail panel the padding is 12px everywhere. mattuk1972: I think we should go one way or the other
[13:47] <mattuk1972> frankban: its 12 pixel from my original design where the measurement was taken from the edge of the charm panel - it seems like the measurement here is being taken from the grey single pixel line. also in my original design this was a two pixel line anyway
[13:48] <mattuk1972> frankban: so that makes it 10 px
[13:49] <frankban> mattuk1972: ok
[13:49] <mattuk1972> frankban: sorry to be a nitpicker
[13:50] <bac> hi, i'm seeing this conversation late.  the charmstore_assets_guide.pdf has 11px on the left, mattuk1972 and frankban
[13:50] <frankban> mattuk1972: :-) np
[13:51] <bac> is that wrong or not taking a border into effect?
[13:51] <bac> would be nice to see it standardized and abstracted into a LESS variable
[13:52] <mattuk1972> i was just trying to give the measurement from how i thought it was being taken
[13:52] <frankban> bac: less variable, agreed
[13:52] <mattuk1972> in my original layout guide i gave it as 12px not taking border into effect
[13:52] <mattuk1972> sorry for any confusion
[13:54] <frankban> mattuk1972: so, I will change it to 10px border excluded
[13:55] <mattuk1972> there is a slight issue in that the two px border isnt there - i was trying to give the panel an inset look that i think is lost now
[13:58] <gary_poster> tveronezi, I just gave a follow-up review.  Things are looking good to me.  I only have one non-trivial suggestion, and hopefully it is pretty easy one way or the other.
[13:59] <tveronezi> gary_poster: g+?
[13:59] <gary_poster> sure
[14:02] <frankban> mattuk1972: we should make another card for the 2 pixel border IMHO. I am going to do that if you agree.
[14:02] <mattuk1972> frankban: sure
[14:03] <frankban> bac: I am fixing the branch you are reviewing introducing the padding-left variable for the charm panel
[14:03] <frankban> mattuk1972: cool
[14:03] <bac> frankban: ok
[14:03] <bac> frankban: review sent
[14:04] <bac> nothing surprising in it
[14:06] <frankban> bac: thanks. re: the config file... in my browser it is part of the vcollapsible, actually collapses and the chevron works well
[14:06] <frankban> :-/
[14:07] <bac> frankban: i'm using chrome on quantal
[14:07] <frankban> bac: me too
[14:07] <frankban> bac: cache?
[14:08] <bac> frankban: so you collapse 'server settings' and the button goes away?
[14:08] <bac> perhaps i described it poorly
[14:08] <frankban> bac: yes
[14:08] <bac> frankban: i will try clearing cache
[14:16] <mattuk1972> bac: frankban: garyposter: the use config file ux has never been properly looked at imo. Jovan is going to take a look at it to figure it out correctly.
[14:17] <bac> mattuk1972: that would be great
[14:17] <mattuk1972> shall i ask him to make a card?
[14:25] <benji> bcsaller: do you have any pointers on how the d3 world does testing?
[14:26] <benji> I keep finding things about blood tests for vitamin levels.
[14:27] <gary_poster> heh
[14:27] <bcsaller> benji: ha, I'm not sure what to tell you, they have unit tests in the code base that are pretty good, but our more specific tests don't really translate to how those work
[14:28] <bcsaller> for things like the env view I think we end up with lots of calls to simulate like we have now. At the unit test level I've tried to make the framework refactor a little more testable
[14:28] <bcsaller> (and tested)
[14:31] <bac> hi mattuk1972, i'm looking at store_front_review and have some questions.
[14:31] <mattuk1972> yup
[14:32] <mattuk1972> want to do a call?
[14:32] <gary_poster> frankban, you still need a second review for charm-config-panel, yeah?  starting it, so stop me if not necessary :-)
[14:32] <bac> the cell height comment is confusing.
[14:32] <frankban> bac: pushed fixes per UX review, and also LESS variable to set all the charm panel views to 10px left padding. still seeing that ugly config file behavior?
[14:32] <bac> 70px when a one line description?  what if there are multi-lines?  i'm not sure how that could even be handled in css
[14:32] <frankban> gary_poster: yes I do, thanks!
[14:32] <gary_poster> cool, wlecome
[14:32] <frankban> gary_poster: and just pushed fixes per UX review
[14:33] <gary_poster> got it, pulled
[14:33] <mattuk1972> bad, a fixed cell height no matter what text - not nice to resize
[14:33] <mattuk1972> the cell
[14:34] <mattuk1972> bac not bad
[14:34] <mattuk1972> ...
[14:34] <bac> bad bac!
[14:34] <mattuk1972> lol
[14:34] <gary_poster> :-)
[14:35] <bac> and what if there is a long description mattuk1972?  we have no control over it as it is provided by charm authors
[14:35] <mattuk1972> two line and then … i guess
[14:35] <mattuk1972> much like my email prog
[14:36] <bac> we can do a *minimum* of 70px, which will cover the one line case but i think it'd be nicer to see it grow than have text truncated.
[14:36] <benji> we might, almost, be at the point where most browsers can do ellipsis correctly
[14:36] <bac> let me play with it
[14:37] <bac> benji: just automatically?  or does something need to be specified?
[14:37] <benji> bac: it is automatic.  I know that recent FF and Chrome support it, I would hope IE does by now too
[14:37] <benji> bac: text-overflow: ellipsis;
[14:38] <bac> frankban: i'm seeing the proper collapsing now.  the animation is crazy slow
[14:38] <mattuk1972> cell grow bad - a fixed structure helps to scan tabular info
[14:38] <bac> benji: cool
[14:39] <gary_poster> collapsing: weird, quite fast for me
[14:40] <bac> gary_poster: ok.  must be my odd environment
[14:40] <bac> chrome over x
[14:40] <gary_poster> bac, that doesn't mean we should ignore it
[14:40] <gary_poster> oh
[14:40] <gary_poster> well maybe it does then :-P
[14:40] <frankban> bac: fast for me too. maybe you are looking at the position, so you can not catch the speed, it's quantal mechanics 
[14:41] <benji> bac: yep, it looks like all major browsers support ellipsis correctly now.  I have waited so long for this day.
[14:41] <benji> I need to get out more.
[14:41] <gary_poster> :-)
[14:41] <mattuk1972> hehe
[14:42] <bac> gary_poster: i think i am going to work on monday and take it as a swap day later.
[14:42] <gary_poster> bac, cool.  (me too)
[14:42] <gary_poster> day after Thanksgiving is just too convenient
[14:43] <benji> gary_poster: how many days do we need to reserve for the Christmas shutdown?  I seem to recall it being four.
[14:43]  * gary_poster looks
[14:43]  * benji wonders where gary_poster looks for these things.
[14:48] <bac> benji: it is only the canonical calendar
[14:48] <gary_poster> benji, I search in myriad wonderful places until I find what I want :-P
[14:48] <gary_poster> bac, to what do you refer?  I was just very proud to have found https://docs.google.com/a/canonical.com/file/d/0ByrI0-OYdkUEMzA4OTk2MWYtNmVhNC00ZTAxLWI1YTItNTg5ODQ1NWRlNTcx/edit?hl=en_US
[14:48] <gary_poster> which shows what I suspected:
[14:49] <gary_poster> we get Friday Dec 28 off generally
[14:49] <gary_poster> so in the US we need to reserve three days for Christmas holidas, benji
[14:49] <gary_poster> oh wait, no, 4
[14:49] <gary_poster> 24, 26, 27, 31
[14:50] <bac> gary_poster: launchpad team google cal shows the span.  but doesn't show the 28th as free
[14:51] <bac> it also doesn't show the 24th as being closed
[14:51] <gary_poster> right, that was the important part that I vaguely remembered
[14:51] <bac> so yours wins!
[14:51] <gary_poster> :-)
[14:56] <mattuk1972> bac: the visual design manager he's says the buttons are good to go : -) he said marc s may pick up on the curve but as long as we have a good reason why they are this way it should be good
[14:56] <gary_poster> yay!
[14:56] <mattuk1972> woop
[14:56] <gary_poster> :-)
[14:56] <bac> excellent
[14:57] <benji> Sanity prevails.
[14:58] <gary_poster> frankban, approved as is.  looks great
[14:59] <frankban> gary_poster: cool thanks
[15:01] <gary_poster> teknico, no rush, but I'm in hangout from calendar
[15:02] <teknico> gary_poster, getting there
[15:02] <gary_poster> cool
[15:15] <tveronezi> gary_poster: quick g+?
[15:16] <gary_poster> tveronezi, on another call sorry :-0
[15:16] <gary_poster> :-) I mean
[15:16] <tveronezi> ok.
[15:19] <tveronezi> gary_poster: I just want to discuss the "bootstrap" thing. Just want to let you know that if we use that, the "aliases" (the "use" key in "modules.js") wont work. I will need to specify the requirements one by one. I dont know what to do now.
[15:19] <tveronezi> gary_poster: ping me when you have time.
[15:19] <gary_poster> tveronezi, ok, will try to do it asap
[15:58] <gary_poster> bac bcsaller benji frankban jovan2 Makyo mattuk1972 teknico tveronezi call in 2 in juju-ui
[15:59] <gary_poster> tveronezi, sorry; I'm there now if you want to try and squeeze something in; otherwise maybe afterwards would be good
[16:01] <gary_poster> Makyo starting
[16:21] <bac> jovan2: the first 'Deploy' button could be re-labeled 'Configure' as it leads to the configure panel.
[17:08] <Makyo> bcsaller, can I request you as a reviewer on the firefox thing, whenver's convenient?  I'm messing with drawing relations, figure you should be in on that,.
[17:08] <bcsaller> Makyo: sounds good, I'll look at it after some food
[17:09] <Makyo> Cool, thanks.
[17:17] <gary_poster> OK, I might be back...
[17:52] <tveronezi> gary_poster: g+?
[17:53] <gary_poster> tveronezi, ok if you don't mind occasional distractions for me
[18:52] <bac> benji: wrt to wrapping and ellipsis, i added text-overflow: ellipsis as you suggested
[18:52] <benji> did we settle on tags or multiple review requests to keep up with who was reviewing what?
[18:52] <bac> but it isn't overflowing and ellipsising.  it is just spilling into the next <li>
[18:53] <benji> bac: what browser?
[18:53] <bac> benji: tags separated by vertical space
[18:53] <benji> heh
[18:53] <bac> chrome
[18:53] <bac> benji: and hunter suggested i remove the fan blades to see if it speeds up.
[18:53] <bac> if it does, then they will replace the blades
[18:53] <benji> bac: oh, you need "white-space: nowrap" too
[18:54] <bac> rinse, repeat
[18:54] <benji> that's... odd
[18:55] <benji> do they occasionally make blades that are way too heavy?
[18:55] <bac> the way i figure it, a bad motor could speed up if you remove perfectly good blades
[18:56] <bac> so it seems to be a non-conclusive test
[18:56] <bac> if the motor does not speed up then it is a bad motor
[19:24] <benji> Makyo: I was going to review your branch, but I can't find it.  ("Cannot remove subordinate relations")
[19:30] <bac> benji: do you have a sec for a call?
[19:30] <benji> bac: sure
[19:47] <Makyo> benji, lp:~makyo/juju-gui/remove-sub-rels
[19:47] <benji> Makyo: thanks
[19:51] <benji> Makyo: is there a reitveld review or MP?
[19:52] <Makyo> Ah, sorry. https://codereview.appspot.com/6782063/
[19:53] <bac> benji: http://danbeam.org/ellipsis/yui/
[19:53] <benji> bac: cool
[20:12]  * bac walkies.  bbiab.
[20:49] <gary_poster> tveronezi, your branch has been fully blessed :-)
[20:49] <tveronezi> tak! :)
[20:49] <tveronezi> thanks! I mean! :)
[20:49] <gary_poster> I thought you were turning Danish on us!
[20:49] <gary_poster> Makyo, trying to quickly give you a review before a call in 11 minutes so you can land replace-service-module...
[20:54] <Makyo> gary_poster, Thanks:)
[20:54] <gary_poster> :-)
[20:56] <gary_poster> Wow, Makyo, FF is now completely usable for me on both new desktop and 3 year old laptop: congrats!
[20:56] <gary_poster> Chrome still faster
[20:56] <gary_poster> but the difference in FF is huge
[21:02] <gary_poster> approved Makyo, witgh trivial comments
[21:04] <Makyo> gary_poster, Thanks.  I know there's still room to improve FF, but that may come with other branches.  Will take care of comments, etc.
[21:04] <gary_poster> cool thx
[21:22]  * tveronezi brb
[21:32]  * tveronezi back