| frankban | hi all, is the staging server broken? | 11:19 |
|---|---|---|
| frankban | morning bac | 12:06 |
| bac | hi frankban | 12:06 |
| bac | good weekend? | 12:06 |
| frankban | bac: yes thanks | 12:06 |
| frankban | bac: unfortunately the staging server seems broken | 12:07 |
| bac | oh, perhaps i can help! | 12:08 |
| bac | seems mighty dead | 12:08 |
| bac | frankban: trunk has a file with conflict markers checked in. | 12:10 |
| bac | i'll find and fix it | 12:10 |
| frankban | bac: thanks | 12:10 |
| bac | frankban: it was not a conflict in trunk as i suspected but just a conflict in the checked out copy on the server. | 12:17 |
| bac | it should be back in a second | 12:17 |
| frankban | bac: cool | 12:18 |
| bac | still dead | 12:19 |
| frankban | bac: Uncaught ReferenceError: GlobalConfig is not defined | 12:25 |
| bac | frankban: any ideas what could be causing that? | 12:34 |
| bac | separately, there is some problem with the rapi-rollup branch getting bad response from LP | 12:34 |
| bac | when the cronjob does a 'bzr pull' | 12:35 |
| frankban | bac: it seems that assets (e.g. yui.js) cannot be found | 12:35 |
| frankban | (sometimes) :-/ | 12:36 |
| bac | frankban: modules.js:1ReferenceError: Strict mode forbids implicit creation of global property 'GlobalConfig' | 12:38 |
| bac | so where should it be coming from? | 12:38 |
| frankban | bac: I guess GlobalConfig is created in yui.js | 12:39 |
| bac | modules.js looks to have a new directive "ignoreRegistered = true" | 12:39 |
| bac | i wonder if that is involved | 12:39 |
| frankban | bac: locally it works | 12:40 |
| bac | yep | 12:41 |
| bac | frankban: i adde a 'var' in front of GlobalConfig in modules.js and it works | 12:48 |
| bac | it looks like a 'use strict' may have been inserted somewhere that was preventing GC from implicitly being created | 12:49 |
| bac | i made the change locally on the server, so it may fall over when the cronjob runs again | 12:49 |
| jovan2 | hi guys - is there a mailing list for our juju-gui team? I've a couple of use cases I'd like to share. | 13:14 |
| frankban | bac: back from lunch, I also see artifacts at the bottom of the page, it seems the slider isn't rendered correctly anymore, do you see the same? | 13:48 |
| bac | frankban: yes, i see that | 13:50 |
| frankban | bac: I think that also causes (in some way) the central part of the body to exceed the width | 13:51 |
| frankban | tveronezi: morning, I am having troubles with some kind of cache when I change templates. The browser does not show changes unless I run "make clean" and "make server" again. and "appcache-force" doesn't help. Any ideas? | 13:53 |
| frankban | oh, today is really a monday... | 13:53 |
| tveronezi | Hi frankban. I think you need to clean the browser cache. | 13:54 |
| tveronezi | I have the same problem, but cleaning the cache (ctrl+shift+del) does the job. | 13:55 |
| frankban | tveronezi: and then check "Empty the cache", right? | 13:57 |
| frankban | tveronezi: did that, without effect | 13:58 |
| tveronezi | frankban... oh... you need to run the "make debug" instead of make server also. | 13:58 |
| frankban | tveronezi: ah! | 13:58 |
| tveronezi | otherwise you will use the compressed version of our app. | 13:59 |
| bac | frankban: i suspect the problems we're seeing on uistage are due to the minimization work that landed recently. | 14:11 |
| frankban | cool, and now yui.yahooapis.com does not work... | 14:11 |
| bac | tveronezi: can you look at the staging server | 14:11 |
| frankban | bac: yes, locally with make debug it works well | 14:11 |
| bac | there are weird layout artifacts. | 14:11 |
| bac | tveronezi: there had been a conflict with config.js and i may have resolved it incorrectly | 14:12 |
| bac | frankban: can you replicate staging locally by not using debug? | 14:12 |
| bac | by that i mean the problems we're currently seeing on staging | 14:12 |
| frankban | bac: I can replicate the artifact at the bottom of the page, I cannot replicate the GlobalConfig error. and cannot double check now because yui.yahooapis.com is darn slow | 14:14 |
| frankban | bac: ok, double checked: I confirm: artifacts using "make server", everything ok using "make debug" | 14:15 |
| tveronezi | bac, frankban... I will check that... | 14:15 |
| bac | jovan2: we have a launchpad team with a mailing list. you can join the team at https://launchpad.net/~juju-gui-peeps and then subscribe to the mailing list. | 14:42 |
| jovan2 | thanks bac | 14:43 |
| jovan2 | bac: I think somebody needs to allow me to view that page, would that be Gary or Kapil? | 14:45 |
| bac | jovan2: yeah, i see it is a private team. kapil is the owner | 14:46 |
| jovan2 | hazmat: can you add me to https://launchpad.net/~juju-gui-peeps please? | 14:47 |
| frankban | mattuk1972 or jovan2: do you have time for a quick UX review (just a screenshot) for my branch: replace bootstrap icons with our assets in the charm panel | 14:52 |
| mattuk1972 | frankban: sure | 14:53 |
| mattuk1972 | frankban: just email it along | 14:54 |
| jovan2 | frankban: yes please | 14:54 |
| frankban | mattuk1972, jovan2: thanks, email sent | 14:58 |
| mattuk1972 | cool | 14:58 |
| mattuk1972 | frankban: gets a big thumbs up from me - nice one | 15:00 |
| jovan2 | frankban: looks good to me | 15:02 |
| frankban | mattuk1972, jovan2: great, thanks | 15:03 |
| frankban | bac: do you have time for a review? | 15:25 |
| bac | frankban: sure, just a minute | 15:30 |
| frankban | bac: thanks, for when you are ready: https://codereview.appspot.com/6819131 | 15:31 |
| bac | frankban: looking at it now | 15:37 |
| bac | even tagged your card! | 15:37 |
| teknico | oh right, forgot to do that :-) | 15:40 |
| frankban | bac: thanks | 15:43 |
| bac | frankban: i cannot get your branch to run locally | 15:44 |
| bac | Y.juju is undefined | 15:44 |
| bac | this is with 'make debug' | 15:44 |
| frankban | bac: :-/ | 15:44 |
| bac | trying trunk now | 15:44 |
| bac | tveronezi: did you get a chance to look at the possible minimization problems? i cannot get trunk to load now. | 15:47 |
| tveronezi | bac, frankban: I know what is going on... | 15:47 |
| tveronezi | bac, frankban: the system does not load the slider-base.css file. we need to add it manually. I am trying to figure out how to load it automatically. | 15:48 |
| bac | tveronezi: there are other problems. running server i get an error trying to define 'app' | 15:49 |
| bac | mean to say, there is an error in the line 'app = new Y.juju.App' as Y.juju is undefined | 15:49 |
| frankban | bac: trunk runs well for me locally. could you please check if all the resources from the web are correctly loaded? | 15:51 |
| tveronezi | bac, frankban: this last one I cannot reproduce... bac can we talk after the meeting? | 15:53 |
| bac | frankban: using the 'network' tab i don't see any failures to load. is there somewhere else i can look? | 15:55 |
| frankban | bac: no AFAIK. my only remaining suggestion is to clean the browser cache, then run "make clean" and then "make debug". | 15:57 |
| bac | frankban: i've done all of those. :( | 15:58 |
| bac | meeting | 16:00 |
| frankban | bac: just did the same thing, and it works... weird | 16:00 |
| bac | teknico: hangout? | 16:01 |
| bac | jovan2: hangout | 16:02 |
| jovan2 | on my way | 16:02 |
| === jovan2_ is now known as jovan2 | ||
| tveronezi | bac... one sec.... | 16:25 |
| bac | staging should be working now and updates at :00,15,30,45 | 16:30 |
| bac | frankban: i still cannot get my local env to work. so i can't do your review until after my lunch and your EOD | 16:31 |
| jovan2 | bcsaller: hi, if cs is abbr for charm store, what is the abbr for Local charm? | 16:32 |
| frankban | bac: no problem, I will land it tomorrow morning, or later if everything is fine | 16:33 |
| bcsaller | jovan2: local:... | 16:33 |
| bcsaller | so local:series/name | 16:34 |
| jovan2 | bcsaller: thanks. Another: if user loads a local config file, should they be able to then amend any settings as well? | 16:35 |
| bcsaller | jovan2: local: implies a local repository, an on disk collection of directories of charms | 16:35 |
| bcsaller | local: for a different user might be different, but the charm series/name-rev should still be unique in the environment | 16:36 |
| jovan2 | bcsaller, I was thinking of the config settings for any charm, you have the option to load a config file. | 16:36 |
| bcsaller | thats different, those are settings applied to the charm, same as the web form now but stored in a file | 16:37 |
| bcsaller | not tied to the notion of local or not, a file of settings could work with any type of charm | 16:37 |
| jovan2 | bcsaller, ok so that's different, understood. But should a user be able to amend settings *after* loading a config file? | 16:38 |
| jovan2 | bcsaller, currently they load a config file but then don't see the individual fields any more. | 16:38 |
| bcsaller | jovan2: yes, config settings can be changed at any time as far as the system is concerned, for some charms it might not make sense but thats not something we know | 16:38 |
| jovan2 | bcsaller, ok so when we allow a user to load a config settings file we should still display the fields with the values from the file, but still allow the use to edit individual fields? | 16:39 |
| bcsaller | yes | 16:40 |
| jovan2 | bcsaller, thanks. | 16:40 |
| * tveronezi lunch | 17:10 | |
| * tveronezi back | 17:28 | |
| jovan2 | bcsaller: when you said earlier that a user could ssh with a unit name, is the unit name the same as the unit ip address in this case? | 17:43 |
| bac | jovan2: no, you use 'juju ssh wordpress/1' to get to a unit | 17:45 |
| bac | juju maps it to the ip address | 17:45 |
| bac | doh | 17:45 |
| * tveronezi brb... | 17:55 | |
| * tveronezi back | 18:08 | |
| Makyo | Could use a few reviews, if folks have time/energy. Charm panel border: https://codereview.appspot.com/6812107 Click subordinate relation indicator to toggle relation visibility (was remove sub rels): https://codereview.appspot.com/6782063/ | 18:30 |
| tveronezi | bcsaller: do you have a minute for a pre-impl call? | 18:39 |
| bcsaller | tveronezi: sure do | 18:39 |
| bcsaller | on g+ | 18:39 |
| tveronezi | ok | 18:39 |
| bcsaller1 | tveronezi: sorry about that, it froze up | 18:42 |
| === bcsaller1 is now known as bcsaller | ||
| bac | tveronezi: i suspect a new 'use strict' that you introduced is causing the definition of GlobalConfig to fail. it looks like inserting a 'var' in both places it is defined is all that is required. | 18:49 |
| tveronezi | bac: g+? | 18:53 |
| bac | tveronezi: nah, i'm having a hard time reproducing it, even with a fresh checkout. but, i have seen it locally and on staging, so let's keep it in mind. | 18:54 |
| tveronezi | bac: I think you are right. I am just surprised I didnt see it locally. It should break in production mode because after merging the css files, the resulting file will have the "use strict". The point is that the "GlobalConfig" has no "var" declaration, so it should break the application for me too. We definitely have a problem... I will check it again... | 18:59 |
| tveronezi | s/css/js | 18:59 |
| bac | tveronezi: thanks | 19:00 |
| tveronezi | bac: It seems we are loading GlobalConfig twice. Can you make this change https://pastebin.canonical.com/78235/ ? | 19:08 |
| bac | tveronezi: i can but i can no longer reproduce the problem. | 19:10 |
| tveronezi | bac: so strange... I see the issue there. I mean, I see the GlobalConfig being declared twice. Well... I think I will commit this change in my next branch. Unless we can reproduce it again. | 19:12 |
| bac | tveronezi: and what about 'var GlobalConfig'? | 19:13 |
| bac | tveronezi: also if you wanted to do a branch with just those fixes we could push it through under the 'testfix' rules, i think. | 19:14 |
| tveronezi | When we run the minimifier, it merges all the variables in a single declaration. So, the resulting var is something like... | 19:15 |
| tveronezi | var juju_config={..., ,GlobalConfig={...,GlobalConfig={... | 19:15 |
| tveronezi | bac: ok... I will create a branch for that. | 19:16 |
| bac | tveronezi: i'd like to use a package from the gallery ('gallery-ellipsis'). i thought some of the tools would find it and suck it in if i just referenced it in a requires | 20:26 |
| bac | ... in a requires section. that doesn't seem to be true. can you give me some advice. | 20:26 |
| tveronezi | Where do you declare it? "modules.js"? | 20:27 |
| tveronezi | bac ^ | 20:27 |
| bac | tveronezi: nope. i was looking at how gallery-markdown was used. not declared in modules.js. | 20:29 |
| bac | modules.js does not reference any third party or gallery stuff | 20:29 |
| tveronezi | bac: hmmm... Let me check it. I had some problems with the "gallery-markdown" too. | 20:30 |
| bac | tveronezi: i saw you added it to 'reqs' in the merge-files script | 20:30 |
| tveronezi | bac: probably "'gallery-ellipsis" has the same problem. | 20:30 |
| bac | i tried that too and it didn't work | 20:30 |
| tveronezi | bac: our yui assets dont include 'gallery-ellipsis'. At least I didn find it. Is it from yui? | 20:34 |
| bac | tveronezi: it is in the yui gallery, like markdown | 20:34 |
| bac | tveronezi: http://yuilibrary.com/gallery/show/ellipsis | 20:35 |
| tveronezi | bac: Markdown is not there too. If you add 'gallery-ellipsis' to the "utils.js" file (for example), the system will call... | 20:42 |
| tveronezi | bac: http://yui.yahooapis.com/combo?gallery-2012.10.31-20-00/build/gallery-markdown/gallery-markdown-min.js&gallery-2012.10.31-20-00/build/gallery-ellipsis/gallery-ellipsis-min.js | 20:42 |
| tveronezi | bac: thanks for helping me to understand why 'gallery-markdown' is not working too. :) | 20:43 |
| bac | tveronezi: i want to use it in charm-panel.js and have added it there. i don't see it getting loaded from yahooapis | 20:46 |
| tveronezi | bac: that is strange... again. I see it being loaded. I swear! :) | 20:57 |
| bac | tveronezi: ok, i'll poke at it more tomorrow. thanks. | 20:57 |
| * Makyo dogwalk. | 21:50 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!