/srv/irclogs.ubuntu.com/2012/11/13/#juju-gui.txt

bachi frankban 12:01
frankbanhi bac 12:01
bacfrankban, i see your sprite branch is now on staging.12:01
frankbanbac: I am seeing the behavior you described there12:01
bacfrankban, oh, it seems to work for me!12:02
frankbanbac: lol 12:02
bacfrankban, but i now see that the up/down chevrons have a white background, not transparency, so they look funny on the grey background.  have you seen that?12:02
frankbanthat's crazy bac, I also see the problem you described in the review (the chevron in the menu bar is still the old one)12:03
frankbanbac: it seems that the old index.html is being served by staging12:04
bachmm12:04
bacbrowser cache?12:04
frankbanbac: cleaned, mabybe the html cache manifest?12:06
frankbanbac: could you please try to run "make appcache-force" in staging, and then restart the server?12:06
bacfrankban, i did a make clean, is that sufficient?12:09
baccheck it out now12:10
bacfrankban, i did appcache-force/restart12:13
frankbanbac: now it works, thanks, and you are right, the chevrons are not transparent12:13
baci think clean should wipe out the appcache manifest but it does not12:13
bacfrankban, glad we're all seeing the same thing now12:14
frankbanbac: maybe we should run  appcache-force each time we update staging. We can clean the cache and the app data each time, but not our users.12:15
bacfrankban, yes, i think it should be part of the clean target and we should just run make clean12:15
frankbanbac: re the chevrons, they are transparent in the assets and in the sprite :-/12:17
bacoh12:21
bacfrankban, will you also follow up with the designers regarding chevron up and down?12:22
frankbanbac: you mean, the reversed directions?12:23
frankbanbac: re the chevrons, locally I have the sprite with a transparent backgorund, in staging the sprite is not transparent12:24
frankbanbac: white background in staging :-/ it seems we should fix how we deploy staging.12:25
frankbantveronezi: any idea on why the sprite's background in staging is not transparent?12:28
tveronezifrankban: I am trying to see what is the problem... just a sec. :)12:29
frankbantveronezi: cool thanks12:30
tveronezifrankban: I didn't get the problem. Is it something related to the header? It does not use the "sprite". It uses a regular image. I found this trick to make transparent backgrounds, but I dont see it in our code. http://css-tricks.com/snippets/css/transparent-background-images/12:46
frankbantveronezi: it is related to the chevrons_(up|down) in the charm panel. they have a white background in staging, they are transparent locally. they use the sprite. Inspecting the code, it seems that the sprite in staging is not transparent12:48
frankbantveronezi: to see those, you might want to clear your browser cache12:49
tveronezifrankban: hmmm... they look the same to me... http://ubuntuone.com/3ukBtOlhcydsB8VtlZtKha  http://ubuntuone.com/1QpOBke8x9ah5A9BkTj0CZ12:57
frankbantveronezi: I am referring to the charm description view. Open the charm panel, select a charm, you should see chevrons on each section of the description.13:00
gary_posterhey all13:07
tveronezifrankban... hmmm. I see the problem in both local and staging. I need to check the sprite generation. 13:07
frankbantveronezi: cool13:07
gary_posterteknico, hey.  how go charm tests?  You about ready with a branch?  or would it be good to have someone to pair with?13:07
* gary_poster reviews13:10
gary_posterI am reviewing Makyo's bug 1077006 branch13:10
_mup_Bug #1077006: Charm panel left border should be 2px as per UX design <juju-ui:Triaged> < https://launchpad.net/bugs/1077006 >13:10
benjiIRC works better when you turn on your client.13:10
gary_posterwords to live by13:11
hazmatg'morning13:27
bacgary_poster, matt's branch has two reviews.  both frankban and i tagged the card before starting.13:29
bacmorning hazmat.  i had to poke uistage a bit yesterday and today.  i think we need to update the cronscript to 'make appcache-force' before restarting the gui13:32
hazmatbac, k, i'll take care of it13:33
bachazmat, i also changed the cron to run every fifteen minutes as that is what most people thought was happening.  it was actually only run every 30 minutes.13:33
hazmatbac, where is the cron now?13:34
hazmati don't see it in crontab for ubuntu or root?13:34
hazmatjust added make appcache-force to cron script13:35
bachazmat, 'crontab -l' and 'crontab -e' is what i used13:35
hazmatah.. ic13:35
bacas ubuntu13:35
hazmatbac are you sure re 30m?13:36
bachazmat, previously it was 15,3013:36
* hazmat discards some faulty gray matter13:37
bacoh, sorry, it was 15,4513:37
gary_posterbac cool thx.  Forgot about that.  In somewhat related issue, I am seeing problems in my local instance having to do with some images that are being rendered below where they are supposed to: http://ubuntuone.com/6wirTIHiK40RGV3ahJ3a7G13:38
gary_posterI have done make appcache-force13:38
gary_posterand cleared cache13:38
gary_posterI saw some discussion of problems in log from yesterday13:38
gary_posterbut no resolution13:38
gary_posterI also see "Waiting for yui.yahooapis.com"13:39
gary_posterLooks like we are getting css and that is taking awhile13:40
gary_posterbac, frankban, tveronezi you all were talking about this yesterday I think ^^^ .  any hints?13:41
gary_posterThis link is taking 15 seconds: http://yui.yahooapis.com/combo?3.7.3/build/widget-modality/assets/skins/sam/widget-modality.css&3.7.3/build/widget-stack/assets/skins/sam/widget-stack.css&3.7.3/build/panel/assets/skins/sam/panel.css&3.7.3/build/overlay/assets/skins/sam/overlay.css13:44
gary_posterheh, for a 30413:44
tveronezigary_poster: The quick resolution was to use the debug mode in the demo server;  The css stuff will be fixed by my next branch; 'gallery-markdown' and 'gallery-ellipsis' are not available in our static yui files, so we still need to download those from yuilibs.13:45
bacgary_poster, we had that problem on staging yesterday13:45
bacuse of gallery-ellipsis is not in trunk yet13:45
bactveronezi, i still cannot get it to download13:45
gary_posterbac, ack thanks.  tveronezi thanks.  how did this get in trunk--what did we miss?13:46
bacgary_poster, if you'd like to pair i'd appreciate it13:46
gary_posterbac ok cool, fire up a hangout13:46
bacgary_poster, one issue is the combined file has 'use strict' at the top.  GlobalConfig is not defined with 'var' and that causes a failure.13:46
baceasy fix is to add 'var' in two modules.js and modules-debug.js13:47
bac s/two//13:47
gary_posterbac oh ok cool13:47
bacour story for grabbing everything so we serve it up ourselves is not fully done i think13:47
bacmaking hangout13:47
* bac installing plugin13:48
* bac getting tea13:48
tveronezibac: I can download those css files. http://ubuntuone.com/6vHKb78Lq8MFTQEAuWqxkf . If I add galery-ellipsis to the charm-panel.js, it adds the ellipsis to the yuilib url... http://yui.yahooapis.com/combo?gallery-2012.10.31-20-00/build/gallery-markdown/gallery-markdown-min.js&gallery-2012.10.31-20-00/build/gallery-ellipsis/gallery-ellipsis-min.js 13:57
* teknico is back from lunch14:01
teknicogary_poster, nope, still struggling with it, would very much like to pair14:01
teknicogary_poster, I already got some help from frankban, but am open to pair with anyone14:01
gary_posterteknico, ack.  benji or frankban ^^^ ?14:02
teknico("it" being setting up charm tests)14:03
benjigary_poster/teknico: I certainly can.  I have started a card already this morning, however.14:03
gary_posterbenji, how far along are you on that one, then?  and/or will it be done soon? :-)14:04
benjigary_poster: probably not "soon", I was trying to figure out the roll in/out transitions for the charm panel; if we switch to ripping out the fade and making it just disappear, that would be quicker14:05
gary_posterbenji, suggestion open to your veto: just make it disappear, make a low priority bug for the roll-in/roll-out, and move to helping Nicola.  wdyt?14:06
benjigary_poster: that's fine14:07
gary_postercool thank you.  teknico ^^^ benji will join you soon14:07
teknicogary_poster, great, thanks14:07
benjiwait, wait, wait... did we completely break our development story?14:48
benjido I have to run make every time I change a JS file now?14:48
frankbanbenji: are you using "make debug"?14:49
benjifrankban: no, should I?14:49
frankbanbenji: it seems so.14:49
benjihmm14:50
benjiI am displeased.14:51
* teknico on school run, back in half an hour14:56
benjigary_poster: the charm panel fade removal is very simple, but I figured that at least you should take a glance: https://codereview.appspot.com/685404314:58
benjiit took much longer than it should because I was sabataged by the new default of minimizing JS14:58
benji(we should revisit that, it is stupid)14:58
gary_posterbenji approved14:59
benjicool, landing15:00
benjire. review approval message: lol15:01
benjiteknico: what's up?  how can I help?15:01
tveronezibenji: it seems the rev 239 breaks the charm search panel. 15:13
benjitveronezi: is rev 239 the branch I just laned?15:14
tveroneziYes. I cant see the panel now.15:14
* benji answers his own question: "yes"15:15
benjitveronezi: in what way does it break?15:16
frankbanbenji, tveronezi: confirmed, also in staging, the panel doesn't show up15:16
tveronezibenji: I click in the icon and nothing happens. If I revert one revision, it works again.15:16
benjitveronezi: which icon?15:16
tveronezibenji: charm search. http://ubuntuone.com/4nn1DSpQsT2GW7U45hHOmf15:17
benjihmm, I wonder why it worked in my branch; reverting15:18
benjiI wonder what the best way to reviert is given lbox15:19
* benji settles on "uncommit"15:19
* benji realized that it doesn't do what he thought it would do.15:19
benjitveronezi and frankban: fix comitted; thanks for the heads-up15:31
* teknico is back15:31
frankbanbenji: was it the opacity?15:32
teknicobenji, sorry, was afk15:32
benjifrankban: here is the fix: http://paste.ubuntu.com/1355684/15:32
benjiteknico: so, what can I do to help?15:35
teknicobenji, hangout?15:35
benjiteknico: sure, yours or mine?15:36
teknicobenji, emily's: https://tinyurl.com/see-emily-code15:36
benji??15:36
teknico:-)15:36
teknicobenji, frankban set that up for pairings15:37
gary_posterbac bcsaller benji frankban hazmat jovan2 Makyo mattuk1972 teknico tveronezi call in 215:58
tveronezigary_poster: i need to restart... I will back in a sec.16:00
gary_posterok16:00
Makyobenji, lp:~makyo/juju-gui/remove-sub-rels - https://codereview.appspot.com/6782063/16:10
benjiMakyo: thanks; I'll take a look right away16:11
gary_posterearly lunch biab16:25
Makyomattuk1972, ping16:28
mattuk1972hey16:28
mattuk1972makyo, hey16:28
Makyomattuk1972, bug #1077006 is in staging - it's the inset left border on the charm panel.  Have a second to take a look at it and see if it meets design?16:29
_mup_Bug #1077006: Charm panel left border should be 2px as per UX design <juju-ui:Fix Released by makyo> < https://launchpad.net/bugs/1077006 >16:29
mattuk1972makyo, its almost there - its kind of odd how if it appears on a dark colour its lighter than the dark16:31
mattuk1972it cuts off a px where it ends too16:32
mattuk1972might have to rethink the colour i sent you16:32
Makyomattuk1972, dark colour as in the header where it says 'precise', or when you click deploy and it shows the charm name?16:33
MakyoAnd end as in down at the bottom?16:33
mattuk1972yes to all of that16:33
frankbantveronezi: I see the old friend "Uncaught ReferenceError: GlobalConfig is not defined " when I run "make server" in your branch16:33
mattuk1972maybe ill have to rethink that16:34
mattuk1972graphic device16:34
frankbantveronezi: "make debug" works well...16:34
mattuk1972it really works on this light grey spaces but mess up on dark16:34
tveronezifrankban: whats your browser? 16:35
frankbanchromium16:35
frankbantveronezi: cache cleaned, appcache forced.16:35
tveroneziprecise?16:35
frankbanquantal16:35
tveroneziok... let me check that...16:36
frankbantveronezi: sure16:36
Makyomattuk1972, Alright.  I'll look into the dark space borders.  It's currently just an internal drop-shadow on the panel border, but that can be covered up, I suppose.16:36
Makyotveronezi, ditto here, Chrome and FF on Quantal16:36
mattuk1972makyo, can it just be a bit darker? or more opaque? or multiply the colour underneath?16:37
frankbantveronezi: I think bac solved that issue in staging addign a "var" before GlobalConfig somewhere (maybe in module.js)16:37
Makyomattuk1972, Yeah, that's what I'll be looking into.16:37
mattuk1972makyo, are they the new simpler svg assets I'm seeing in staging? because they are rendering way nicer for me16:39
Makyomattuk1972, Yep, plus some FF specific improvements.16:39
tveroneziMakyo, frankban: I simply cannot reproduce it here. I've tried everything: chrome, chromium and ff in precise and quantal. It works fine. Actually, it could never fail because the resulting combined file creates  declaration like... var juju_config = {...}, GlobalConfig={...}, ...   16:44
tveroneziMakyo, frankban: I dont know what is going on.16:45
benjiteknico: I am done with my code review.  How can I help you on the charm?16:45
tveroneziMakyo, frankban: I will commit the var chang bac did... 16:45
tveroneziMakyo, frankban: can you pull and try it again, please?16:47
Makyotveronezi, I'm seeing it request things from /assets/... rather than /juju-ui/assets/... which was a change we made a while back for the horizon integration.  Might be something to talk to frankban / teknico about16:47
teknicobenji, I'll push on some more, and pester you again once I hit the next roadblock :-)16:48
frankbanMakyo, tveronezi: yes, the 'juju-ui' prefix must be restored. I already added a note to my review.16:48
tveroneziMakyo, frankban: This is something related to the server.js. There is a comment about this change.16:48
benjiteknico: ok; I'll look for something else to work on then16:48
Makyotveronezi, ah, alright.16:50
Makyotveronezi, This is what I'm seeing in the minified JS: var juju_config={consoleEnabled:!0,serverRouting:!1,html5:!0,container:"#main",viewContainer:"#main",transitions:!1,charm_store_url:"http://jujucharms.com/",socket_url:"ws://localhost:8081/ws"};GlobalConfig=16:50
MakyoGetting a semicolon rather than a comma.16:50
tveroneziMayko: oh!16:51
tveroneziMayko: I still dont get why this thing is working for me.16:51
tveroneziMayko: Did you pull it again?16:54
frankbantveronezi: I didn't get the reason why the prefix cannot be preserved16:54
frankbantveronezi: now make server works for me16:55
tveronezifrankban: I need a diferent prefix, otherwise I cant get the "lib/server.js" line 77 to work.16:55
MakyoPulled, but it was cached.  Works now, tveronezi 16:57
frankbantveronezi: ok, but why that cannot be 'server.get('/juju-ui/assets/stylesheets/:file' ... or something? 16:58
tveronezifrankban: because if I do this, a request to "/juju-ui/assets/stylesheets/:file" goes to the line 46 instead of the line 77.17:01
jovan2bcsaller: hi, what's the opposite of Expose? Unexpose? i.e. the action to undo an Expose.17:09
bcsallerjovan2: yes, unexpose17:09
tveronezifrankban: forget what I just said. It is working with the link you proposed. 17:09
bcsallerbut it can also be though of as "exposed: true||false"17:09
frankbantveronezi: isn't it possible to make the server parse '/juju-ui/assets/stylesheets/:file' and '/juju-ui/assets/all-third.js' before '/juju-ui/'? I know that your solution is easier, but it could generate troubles when integrating juju-gui in other projects, e.g. jaas17:10
frankbantveronezi: oh, cool17:10
tveronezifrankban: so, we should start the urls with "juju-ui" right?17:11
frankbantveronezi: exactly17:11
frankbanthe static urls17:11
tveronezifrankban: do you see the same problem in the lines 70-71-72? It is from another branch.17:12
frankbantveronezi: do you mean " server.get('/assets/all-third.js'"?17:12
tveronezifrankban, yeap.17:13
tveroneziI will try to change those in a sec.17:13
tveronezifrankban ^17:13
frankbantveronezi: yes, that should be fixed as well, feel free to do that in your current branch or to make another card17:13
frankbantveronezi: so, to fully understand the problem: express tries to match all urls in order, if the first doesn't match, it proceeds to the second and so on. at the end, it raises a 404. Am I right? 17:15
tveroneziMakyo, frankban: thanks for this nice catch.17:15
tveronezifrankban: yeap.17:16
frankbantveronezi: cool.17:17
tveronezibcsaller: It would be nice if you could check this solution. https://codereview.appspot.com/6853044/diff/1/lib/server.js It is part of the css stuff. frankban and Makyo are already reviewing it, but It would be nice to see if you approve what I did for this particular file, or if you have another alternative.17:18
bcsallertveronezi: I can take a look soon17:19
jovan2bcsaller: the number of subordinates is shown on a service block in the graph view - is this number of subordinate services or units?17:19
bcsallerjovan2: I believe its the number of services that subordinate is related to, I can check17:23
jovan2bcsaller: a related question - how many subordinates might be typical? and maximum?17:24
bcsallerjovan2: 0 is quite common, if they are using them in their deployment 1-3 would be in the normally expected range, there isn't a hard max, but you'll quickly tax your machines if you use too many 17:25
bcsallerjovan2: It looks like that number is the count of services related to that subordinate, which makes sense 17:26
bcsallerfor example "how many things are related to this monitoring service"17:26
jovan2bcsaller: I guess you are looking at the subordinate block? I'm looking at the little chart icon on the left-hand side of a normal service block.17:27
bcsallerthe little 'chart' (and why is that a chart looking thing anyway?) is on the subordinate 17:28
bcsallernormal services don't have them17:28
jovan2bcsaller: see slide 2: https://docs.google.com/a/canonical.com/file/d/0BwhxhFfxY6uqY0FGaDh5RHFMUzA/edit17:29
jovan2bcsaller: I believe the chart-like thingy is supposed to indicate monitoring17:30
bcsallerjovan2: we don't have any monitoring, also these wireframe you linked seem to predate the visual design work, that chart widget is the block hanging off a subordinate service now17:31
bcsallerjovan2: I put one up at http://uistage.jujucharms.com:8080/17:32
bcsallerpuppet 17:32
bcsallerthe sparkline is some sort of aspirational element that makes no sense here 17:32
jovan2bcsaller: Ok I see what you've done, but see the second to last slide in the wireframes.17:34
bcsallerjovan2: Ahh, you're saying that normal services should show a count if/when they have subordinates running as well17:35
jovan2bcsaller: right17:35
bcsallerstill shouldn't be a sparkline ;)17:35
bcsallerbut yeah, I don't know if there is a card for that yet17:35
jovan2bcsaller: I think Nick thought subordinates could only be for monitoring purposes. If this is not so, can you give more examples please?17:38
jovan2bcsaller: if you could email me that would be great, I have to go soon.17:38
bcsallerpuppet is a good example, but they can be used in many ways. Sometimes with framework charms they represent the application itself, so for example, if its a django or rails charm, the users application might be the subordinate17:39
bcsallerdepending on how the charm was authored it might be the app is a custom charm and the web framework is the subordinate, we don't require it to be any one way. And we don't know about how that is structured 17:39
bcsallerjovan2: do you need more?17:40
jovan2bcsaller: thanks, that's good for now. I might some more questions tomorrow :)17:41
bcsallernp, have a good one17:41
bacMakyo, i looked at staging with firefox and dragging lines around had no perceptible lag.  moving service boxes is pretty laggy, though.  acceptable, i'd think, but noticeable.17:56
Makyobac, Yeah.  It's still just a speed increase, not a fix.  Accessing node attributes in FF is very slow.17:59
gary_posterMakyo, big +1 on your fix for bug 1076413 that you asked for review on.18:05
_mup_Bug #1076413: Intermittently, svg content div is too wide by 1 pix <juju-ui:Fix Released> < https://launchpad.net/bugs/1076413 >18:05
Makyo\o/18:06
tveroneziMakyo: The application seems normal in ff. I see no difference from the chromium version.18:46
* tveronezi lunch brb18:46
Makyotveronezi, Alright, thanks.18:46
* tveronezi back19:00
gary_posterhazmat, in juju-ui.  no rush19:00
gary_posterbcsaller, including yours, their are five remaining environment view refactoring cards, right?20:25
gary_posterthere20:25
bcsallersounds right20:25
gary_postercool bcsaller thanks.  I'm sending out a note highlighting them to everyone.  They are not specced in the bugs, so I will ask everyone to contact you.  If the Europeans can start one, it might be nice to spec one out with writing, or confer with me on a hangout and see if I can do it after a discussion. Per discussion with Kapil, I'm also going to say that (1) we have through next week to get these landed and (2) ea20:29
gary_posterch one should be landed with tests.  I'd like to verify with you if any of the cards are blocked; and if any of them are arguably optional from one perspective or another, without causing significant ugliness/pain.20:29
gary_posterI'd be happy to do that here or in a hangout20:29
bcsallerstill might be premature, there are no examples yet, still working on that 20:29
gary_posteroh ok20:29
gary_postercan anyone help accelerate that with you bcsaller?  I don't know about your experience with pair programming, but with a good combination it really can be a big benefit.20:31
bcsallermakyo and I did ok during the sprint, not sure though20:32
gary_posterok, leave it up to you bcsaller, though am worried about timeline and the ability of others to help swarm.20:33
* gary_poster needs to get children from school20:34
gary_posterbiab20:34
bcsallergary_poster: I still have the prototype from the sprint which I'm porting to the new framework, so that could possible be a starting point, but I'd rather finish what I have 20:34
bcsallerok, ttyl20:34
MakyoAnyone experienced YUI node.simulate(event) saying "Uncaught TypeError: Cannot read property 'sourceEvent' of null" before?20:38
MakyoThis merge didn't even touch that line, and it's breaking.20:38
bcsallerMakyo: Haven't seen that one but I often have unrelated changes break tests20:54
gary_posterno20:59
MakyoOops, was a d3 thing.  d3.mouse was expecting d3.event to be defined.  Easy to get around for testing by saying d3.event = {};21:19
* tveronezi brb21:42
* tveronezi back21:54
* Makyo dogwalks22:34

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!