| daker | cjohnston: mhall119 review plz https://code.launchpad.net/~daker/loco-team-portal/djdt-support/+merge/134741 | 20:34 |
|---|---|---|
| cjohnston | My only thought would be do we need it in the code? | 20:48 |
| daker | what do you mean ? | 20:49 |
| mhall119 | daker: when I use it, I make a separate debug_settings.py file | 20:49 |
| mhall119 | but I think it's okay like this | 20:50 |
| cjohnston | I'm just not sure that everyone running in debug would want it | 20:50 |
| mhall119 | the only down-side to this approach is that you can't get Django's debug output on error, without also getting the toolbar | 20:50 |
| cjohnston | Or even that everytime I'm running in debug I would want it | 20:50 |
| mhall119 | ^^ what cjohnston said | 20:50 |
| daker | add an other var USE_DJDT ? | 20:51 |
| mhall119 | so maybe instead of DEBUG, create another ENABLE_DEBUG_TOOLBAR variable in settings | 20:51 |
| mhall119 | or that | 20:51 |
| daker | :) | 20:51 |
| * cjohnston didn't know what DJDT was :-P | 20:52 | |
| daker | Django debug toolbar | 20:53 |
| cjohnston | I figured it out when I looked at the code | 20:53 |
| daker | hhh | 20:53 |
| daker | mhall119: is it ok if DEBUG and ENABLE_DEBUG_TOOLBAR: ? | 20:53 |
| mhall119 | doesn't matter what the other variable is called | 20:53 |
| cjohnston | I'm good with those two, but agree with mhall119 | 20:54 |
| mhall119 | ENABLE_DEBUG_TOOLBAR is at least descriptive | 20:54 |
| daker | well in django they use : USE_* | 20:54 |
| mhall119 | ok, then USE_DEBUG_TOOLBAR | 20:57 |
| daker | mhall119: done | 21:07 |
| mhall119 | daker: approved | 21:11 |
| mhall119 | cjohnston: any objection to it now? | 21:11 |
| daker | thanks | 21:12 |
| daker | mhall119: last on plz https://code.launchpad.net/~daker/loco-team-portal/fix.menu/+merge/134749 | 21:42 |
| cjohnston | mhall119: why did you change it back to approved? | 22:33 |
| daker | change it to merge since it has been merged | 22:35 |
| cjohnston | I assume he saw mine | 22:35 |
| cjohnston | and changed it | 22:35 |
| cjohnston | daker: want to check out my new project? | 22:36 |
| daker | haha | 22:36 |
| daker | shoot | 22:36 |
| cjohnston | http://reports.qa.ubuntu.com/smoke/quantal/ | 22:36 |
| daker | ssssslllllooowwww | 22:38 |
| cjohnston | uh huh | 22:38 |
| cjohnston | >5k db queries | 22:39 |
| daker | O.o | 22:40 |
| cjohnston | one of the things I gotta do is figure out how to fix that | 22:41 |
| daker | ouch | 22:53 |
| cjohnston | it was originally written 'quickly' I guess to perform some math functions that are pretty bad to the db | 22:54 |
| daker | opening profiles http://i.imgur.com/zECK6.png | 23:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
