[20:34] cjohnston: mhall119 review plz https://code.launchpad.net/~daker/loco-team-portal/djdt-support/+merge/134741 [20:48] My only thought would be do we need it in the code? [20:49] what do you mean ? [20:49] daker: when I use it, I make a separate debug_settings.py file [20:50] but I think it's okay like this [20:50] I'm just not sure that everyone running in debug would want it [20:50] the only down-side to this approach is that you can't get Django's debug output on error, without also getting the toolbar [20:50] Or even that everytime I'm running in debug I would want it [20:50] ^^ what cjohnston said [20:51] add an other var USE_DJDT ? [20:51] so maybe instead of DEBUG, create another ENABLE_DEBUG_TOOLBAR variable in settings [20:51] or that [20:51] :) [20:52] * cjohnston didn't know what DJDT was :-P [20:53] Django debug toolbar [20:53] I figured it out when I looked at the code [20:53] hhh [20:53] mhall119: is it ok if DEBUG and ENABLE_DEBUG_TOOLBAR: ? [20:53] doesn't matter what the other variable is called [20:54] I'm good with those two, but agree with mhall119 [20:54] ENABLE_DEBUG_TOOLBAR is at least descriptive [20:54] well in django they use : USE_* [20:57] ok, then USE_DEBUG_TOOLBAR [21:07] mhall119: done [21:11] daker: approved [21:11] cjohnston: any objection to it now? [21:12] thanks [21:42] mhall119: last on plz https://code.launchpad.net/~daker/loco-team-portal/fix.menu/+merge/134749 [22:33] mhall119: why did you change it back to approved? [22:35] change it to merge since it has been merged [22:35] I assume he saw mine [22:35] and changed it [22:36] daker: want to check out my new project? [22:36] haha [22:36] shoot [22:36] http://reports.qa.ubuntu.com/smoke/quantal/ [22:38] ssssslllllooowwww [22:38] uh huh [22:39] >5k db queries [22:40] O.o [22:41] one of the things I gotta do is figure out how to fix that [22:53] ouch [22:54] it was originally written 'quickly' I guess to perform some math functions that are pretty bad to the db [23:54] opening profiles http://i.imgur.com/zECK6.png