| === Guest84948 is now known as rogpeppe | ||
| === rogpeppe is now known as rogpeppe1 | ||
| === rogpeppe1 is now known as rogpeppe2 | ||
| === rogpeppe2 is now known as rogpeppe3 | ||
| === rogpeppe3 is now known as rogpeppe | ||
| === mattuk1972_ is now known as mattuk1972 | ||
| hazmat | frankban, looking over the notifications.. why the Y.timer (gallery-timer) instead of just Y.later? | 12:19 |
|---|---|---|
| hazmat | this is for the pause functionality when hovering? | 12:20 |
| frankban | hazmat: for the doc, Y.later does not seem to have pause functionality | 12:21 |
| frankban | hazmat: heh | 12:21 |
| hazmat | frankban, no worries, just trying to keep track of our gallery modules | 12:21 |
| frankban | hazmat: cool | 12:21 |
| * frankban lunches | 12:31 | |
| === jovan2_ is now known as jovan2 | ||
| benji | gary_poster: I just remembered to put in my sick day for Monday. | 13:34 |
| gary_poster | ack | 13:35 |
| bac | gary_poster: hey i'm now seeing the favicon in chromium but only on the tab, not in the address bar. is that what you see? #notreallyobsessed | 13:37 |
| gary_poster | yes bac | 13:37 |
| bac | oh | 13:38 |
| bac | well itfm then | 13:38 |
| bac | er, iwfm | 13:39 |
| gary_poster | bac, that's the way other sites work for me on chrome too. | 13:45 |
| gary_poster | benji, approved fwiw. :-) | 13:45 |
| benji | now I can begin the psycological healing | 13:46 |
| gary_poster | lol | 13:54 |
| * tveronezi brb | 13:58 | |
| * tveronezi back | 14:17 | |
| teknico | benji, weird, I got the email from rietveld with your answers to reviews, but I don't see your changes on launchpad: https://code.launchpad.net/~benji/charms/precise/juju-gui/second/+merge/134370 | 14:30 |
| benji | teknico: hmm, that is weird; let me look at the lbox log, maybe it pushed it to the wrong place | 14:30 |
| benji | teknico: lp:~juju-gui/charms/precise/juju-gui/trunk looks fine to me | 14:33 |
| teknico | benji, indeed, so it's just some miscommunication between rietveld and launchpad | 14:35 |
| benji | teknico: oh, I know what it is: I did not push the review changes to the branch. I never do in this new, lboxy world. Since you are interested in seeing them, I will push them now. | 14:36 |
| benji | pushed | 14:37 |
| teknico | benji, oh, ok, thanks, I was just wondering whether something had gone haywire (sp?) | 14:37 |
| teknico | benji, uhm, I understand pushing the latest revision from bzr, but what do you mean exactly by "pushing the review changes to the branch"? doesn't rietveld do that automatically? | 14:40 |
| benji | teknico: not according to the log (I did an "lbox submit", "propose" probably does push to the branch) | 14:44 |
| teknico | ah, lbox, right | 14:45 |
| * hazmat runs an errand, bbiab | 14:54 | |
| gary_poster | hery tveronezi . Why does the old line 38/39 approach in https://codereview.appspot.com/6856070/diff/9001/test/test_app.js?column_width=80 not work anymore again? Also, one test is failing reliably and others seem more fragile in your branch | 15:10 |
| gary_poster | And in an urelated note, the tests are mutating the URL again | 15:11 |
| gary_poster | so that you end up on localhost:8084 instead of localhost:8084/test | 15:11 |
| gary_poster | (And "Environmenton excellent provider" is at the top of the page) | 15:11 |
| gary_poster | but all those last notes are from trunk as well | 15:11 |
| gary_poster | tveronezi, failing test in your branch is in relation notifications: "should generate messages about one-party relations" | 15:13 |
| gary_poster | Looks like it is a bad space removal: | 15:13 |
| gary_poster | expected 'Relation with endpoint1 (relation type "relation1") was created' to equal 'Relation with endpoint1 (relation type"relation1") was created' | 15:13 |
| tveronezi | gary_poster: We cannot know the order of the tests. YUI loads the dependencies asynchronously. | 15:13 |
| tveronezi | gary_poster: It wasnt failing yesterday. I will check it again. | 15:14 |
| gary_poster | tveronezi, that's why we were using "done" | 15:14 |
| tveronezi | "done" gives timeout sometimes. | 15:14 |
| benji | it sounds like we need some URL assertions in whatever test that is | 15:15 |
| gary_poster | so you mean if I revert your branch to the previous approach in test_app.js it will intermittently fail tveronezi ? | 15:15 |
| gary_poster | (as an example) | 15:15 |
| tveronezi | gary_poster: yeap. | 15:16 |
| gary_poster | tveronezi, why is that different in your branch? I have not seen that fragility in the trunk | 15:16 |
| gary_poster | at least I don't think I have :-P | 15:16 |
| tveronezi | gary_poster: In fact, we should change all the tests. We should wrap the tests with the "YUI().use" call in order to have the Y object in order to follow the YUI application principle discussed in previous branches. | 15:19 |
| gary_poster | tveronezi, that's a reasonable argument. I would expect that to go in a separate branch (and possibly after team discussion, since it is a pretty big change) rather than changing things piecemeal here. I guess you are saying that these particular tests were the most fragile, and they need to be changed in order for your branch to be successful. I wish I understood why that these changes are necessary for this bran | 15:24 |
| gary_poster | ch. Do you know? | 15:24 |
| tveronezi | gary_poster: I've figured out why the tests are broken. It is due to a last minute attempt to make "prep" and "lint" happy. I've removed a white space by mistake. | 15:25 |
| tveronezi | gary_poster: I have a meeting now... I will be back in one hour. | 15:26 |
| gary_poster | ok | 15:30 |
| gary_poster | tveronezi, approved, with reservations noted and a small suggestion. | 15:42 |
| gary_poster | benji, teknico there is a "setup tests for Juju GUI charm" in Active review on kanban. We can move that to done-done, right? | 15:48 |
| benji | gary_poster: oh, yep; thanks | 15:49 |
| gary_poster | cool, race you | 15:49 |
| teknico | gary_poster, oh, right | 15:49 |
| gary_poster | I dunno who won, but I did it :-) | 15:49 |
| teknico | this seems useful as far as YUI optimizations are concerned, title notwithstanding: http://speakerdeck.com/yaypie/when-not-to-use-yui | 15:53 |
| benji | I won: I didn't do anything and you moved it for me. ;) | 15:53 |
| gary_poster | :-) | 15:54 |
| teknico | then it's a tie! | 15:54 |
| benji | teknico: I'm only part way through, but we should all look at that slide deck | 15:56 |
| teknico | benji, yeah, it's quite startling | 15:56 |
| benji | The part about YUI.Base using 2k per instance may be very important for us if we are representing thousands of units. | 15:57 |
| hazmat | tveronezi, gary_poster the yui loader takes an option on the async loading | 15:57 |
| gary_poster | hazmat, ah yes, that rings a bell | 15:58 |
| hazmat | http://yuilibrary.com/yui/docs/api/classes/Loader.html | 15:58 |
| hazmat | async defaults to true | 15:58 |
| gary_poster | the change he made is still a reasonable one though, I think. But it would be better to talk about itbevore we go down that road | 15:58 |
| gary_poster | bac benji frankban hazmat jovan2 Makyo teknico tveronezi call in 2 | 15:58 |
| teknico | benji, and it partly explains YUI's bad placement in speed comparisons like http://jsperf.com/js-mvc-frameworks-models/3 | 15:58 |
| benji | hazmat: I muted your keyboard. ;) | 16:02 |
| hazmat | benji, danke ;-) | 16:03 |
| hazmat | benji, re 2k per instance, that's why we're using the lazy their | 16:03 |
| hazmat | there | 16:03 |
| * benji buys hazmat some cherry brown switches for his keyboard for Christmas. | 16:03 | |
| benji | mmm, makes sense | 16:04 |
| hazmat | benji, cherry red atm | 16:06 |
| hazmat | hmm.. actually cherry blue.. the brown's would sound nice though.. stealth mode | 16:07 |
| bac | but i just refactored the picker! :( | 16:12 |
| gary_poster | ben is on a bus with spotty wifi | 16:17 |
| gary_poster | his review email disappeared for some reason | 16:18 |
| gary_poster | but it is here: | 16:18 |
| gary_poster | https://codereview.appspot.com/6858045/ | 16:18 |
| gary_poster | hazmat, ^^^ | 16:18 |
| hazmat | gary_poster, aha.. | 16:18 |
| hazmat | gary_poster, cool, thanks | 16:18 |
| hazmat | gary_poster, odd about the lack of lp email | 16:18 |
| hazmat | gary_poster, oh. its the wrong merge target | 16:19 |
| gary_poster | bac benji frankban hazmat Makyo teknico tveronezi if you have some time, bcsaller would like reviews of https://codereview.appspot.com/6858045/ . Two people can do the more thorough review, but he'd be interested in broader, bigger picture reviews too | 16:20 |
| gary_poster | This is the environment view refactoring | 16:20 |
| hazmat | actually pls hold off on that for a few.. | 16:20 |
| hazmat | the diff is bad | 16:20 |
| gary_poster | it is supposed to show a pattern for writing the environment view and for writing environment view tests | 16:20 |
| gary_poster | ok cool hazmat. you contacting him or fixing it? | 16:21 |
| hazmat | gary_poster, yeah.. on the phone | 16:21 |
| gary_poster | cool | 16:21 |
| benji | k | 16:21 |
| hazmat | gary_poster, so he's go no network access atm.. i'm going to just resubmit with the correct parent | 16:22 |
| gary_poster | cool thanks hazmat | 16:23 |
| benji | The UI is very brittle regarding font sizes; upsizing the font by one unit (by pressing control +) breaks the layout. | 16:54 |
| hazmat | benji, all these absolute sizes are badness.. | 16:56 |
| benji | yep | 16:57 |
| hazmat | gotta think about ems and relatives | 16:57 |
| gary_poster | hey Makyo, do bac and bcsaller know that you are waiting on their reply to move lp:~makyo/juju-gui/adding-subordinates ? | 17:01 |
| Makyo | gary_poster, I just wanted bcsaller to check on the test, but I suppose anyone can okay that. I tried pinging him yesterday, but flaky internet got the best of us. | 17:03 |
| Makyo | That's https://codereview.appspot.com/6856067/diff/5001/test/test_environment_view.js if anyone would like to take a quick peek. | 17:04 |
| Makyo | Dog's being a brat, going to take him for a quick walk and hope that helps. | 17:08 |
| bac | Makyo: +1 on the test | 17:27 |
| Makyo | bac, thanks. If it's good with you, I'll land. | 17:27 |
| bac | sure | 17:27 |
| * Makyo -> doctor | 19:01 | |
| hazmat | the env refactor is at https://codereview.appspot.com/6842084/ | 19:27 |
| hazmat | had some troubles on the initial propose | 19:27 |
| benji | hazmat: that is the branch that Ben wants many people to peruse, right? | 19:34 |
| hazmat | benji, it is | 19:34 |
| benji | cool, I'll do that | 19:34 |
| hazmat | benji, awesome thanks.. | 19:34 |
| hazmat | i'm hoping he'll be around in the next hr to correct the mp himself.. but that at least gives a nice review diff | 19:35 |
| hazmat | man tty.js is pretty sweet | 19:48 |
| bac | ubuntu + mbp + bulging battery = very low untethered work time | 20:30 |
| * gary_poster here with less tooth than before | 20:37 | |
| bac | yikes | 20:40 |
| * bac dog walk. bbiab. | 20:40 | |
| * benji recommits to flossing more often. | 20:46 | |
| benji | gary_poster: is bug 1078978 up for grabs? It looks fun. | 20:56 |
| _mup_ | Bug #1078978: CSS is not minified in static deployment <juju-gui:Triaged> < https://launchpad.net/bugs/1078978 > | 20:56 |
| benji | hmm, it may be blocked on bug 1078910 though | 20:59 |
| _mup_ | Bug #1078910: development server is unnecessarily complicated and different from production delivery <juju-gui:Triaged> < https://launchpad.net/bugs/1078910 > | 20:59 |
| gary_poster | benji, I don't think one has to be solved before the other, but could be wrong | 21:04 |
| benji | gary_poster: I would at least need to base my branch on the branch for 1078910, right? Wait, maybe not... enough minimization is in the trunk that I can base it on that, right? | 21:05 |
| gary_poster | but yes, they are up for grabs. benji, https://code.launchpad.net/~tveronezi/juju-gui/change-requires-param ought to be landed, or massaged and landed, before that. If you could take that it would be helpful, and would set you up for the rest | 21:06 |
| gary_poster | do you want to have a call? | 21:06 |
| benji | gary_poster: sure | 21:06 |
| gary_poster | I didn't have laughing guess, but I am numb, so my speech might be at least mildly amusing | 21:06 |
| gary_poster | gas | 21:06 |
| benji | I'll take what I can get. | 21:07 |
| gary_poster | :-) | 21:07 |
| gary_poster | ok juju-ui looks empty | 21:07 |
| Makyo | Ugh, sorry, awful traffic. Back. | 22:19 |
| gary_poster | have a great rest of week, weekend, and Thanksgiving where appropriate, everyone! | 22:23 |
| === gary_poster is now known as gary_poster|away | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!