=== Guest84948 is now known as rogpeppe === rogpeppe is now known as rogpeppe1 === rogpeppe1 is now known as rogpeppe2 === rogpeppe2 is now known as rogpeppe3 === rogpeppe3 is now known as rogpeppe === mattuk1972_ is now known as mattuk1972 [12:19] frankban, looking over the notifications.. why the Y.timer (gallery-timer) instead of just Y.later? [12:20] this is for the pause functionality when hovering? [12:21] hazmat: for the doc, Y.later does not seem to have pause functionality [12:21] hazmat: heh [12:21] frankban, no worries, just trying to keep track of our gallery modules [12:21] hazmat: cool [12:31] * frankban lunches === jovan2_ is now known as jovan2 [13:34] gary_poster: I just remembered to put in my sick day for Monday. [13:35] ack [13:37] gary_poster: hey i'm now seeing the favicon in chromium but only on the tab, not in the address bar. is that what you see? #notreallyobsessed [13:37] yes bac [13:38] oh [13:38] well itfm then [13:39] er, iwfm [13:45] bac, that's the way other sites work for me on chrome too. [13:45] benji, approved fwiw. :-) [13:46] now I can begin the psycological healing [13:54] lol [13:58] * tveronezi brb [14:17] * tveronezi back [14:30] benji, weird, I got the email from rietveld with your answers to reviews, but I don't see your changes on launchpad: https://code.launchpad.net/~benji/charms/precise/juju-gui/second/+merge/134370 [14:30] teknico: hmm, that is weird; let me look at the lbox log, maybe it pushed it to the wrong place [14:33] teknico: lp:~juju-gui/charms/precise/juju-gui/trunk looks fine to me [14:35] benji, indeed, so it's just some miscommunication between rietveld and launchpad [14:36] teknico: oh, I know what it is: I did not push the review changes to the branch. I never do in this new, lboxy world. Since you are interested in seeing them, I will push them now. [14:37] pushed [14:37] benji, oh, ok, thanks, I was just wondering whether something had gone haywire (sp?) [14:40] benji, uhm, I understand pushing the latest revision from bzr, but what do you mean exactly by "pushing the review changes to the branch"? doesn't rietveld do that automatically? [14:44] teknico: not according to the log (I did an "lbox submit", "propose" probably does push to the branch) [14:45] ah, lbox, right [14:54] * hazmat runs an errand, bbiab [15:10] hery tveronezi . Why does the old line 38/39 approach in https://codereview.appspot.com/6856070/diff/9001/test/test_app.js?column_width=80 not work anymore again? Also, one test is failing reliably and others seem more fragile in your branch [15:11] And in an urelated note, the tests are mutating the URL again [15:11] so that you end up on localhost:8084 instead of localhost:8084/test [15:11] (And "Environmenton excellent provider" is at the top of the page) [15:11] but all those last notes are from trunk as well [15:13] tveronezi, failing test in your branch is in relation notifications: "should generate messages about one-party relations" [15:13] Looks like it is a bad space removal: [15:13] expected 'Relation with endpoint1 (relation type "relation1") was created' to equal 'Relation with endpoint1 (relation type"relation1") was created' [15:13] gary_poster: We cannot know the order of the tests. YUI loads the dependencies asynchronously. [15:14] gary_poster: It wasnt failing yesterday. I will check it again. [15:14] tveronezi, that's why we were using "done" [15:14] "done" gives timeout sometimes. [15:15] it sounds like we need some URL assertions in whatever test that is [15:15] so you mean if I revert your branch to the previous approach in test_app.js it will intermittently fail tveronezi ? [15:15] (as an example) [15:16] gary_poster: yeap. [15:16] tveronezi, why is that different in your branch? I have not seen that fragility in the trunk [15:16] at least I don't think I have :-P [15:19] gary_poster: In fact, we should change all the tests. We should wrap the tests with the "YUI().use" call in order to have the Y object in order to follow the YUI application principle discussed in previous branches. [15:24] tveronezi, that's a reasonable argument. I would expect that to go in a separate branch (and possibly after team discussion, since it is a pretty big change) rather than changing things piecemeal here. I guess you are saying that these particular tests were the most fragile, and they need to be changed in order for your branch to be successful. I wish I understood why that these changes are necessary for this bran [15:24] ch. Do you know? [15:25] gary_poster: I've figured out why the tests are broken. It is due to a last minute attempt to make "prep" and "lint" happy. I've removed a white space by mistake. [15:26] gary_poster: I have a meeting now... I will be back in one hour. [15:30] ok [15:42] tveronezi, approved, with reservations noted and a small suggestion. [15:48] benji, teknico there is a "setup tests for Juju GUI charm" in Active review on kanban. We can move that to done-done, right? [15:49] gary_poster: oh, yep; thanks [15:49] cool, race you [15:49] gary_poster, oh, right [15:49] I dunno who won, but I did it :-) [15:53] this seems useful as far as YUI optimizations are concerned, title notwithstanding: http://speakerdeck.com/yaypie/when-not-to-use-yui [15:53] I won: I didn't do anything and you moved it for me. ;) [15:54] :-) [15:54] then it's a tie! [15:56] teknico: I'm only part way through, but we should all look at that slide deck [15:56] benji, yeah, it's quite startling [15:57] The part about YUI.Base using 2k per instance may be very important for us if we are representing thousands of units. [15:57] tveronezi, gary_poster the yui loader takes an option on the async loading [15:58] hazmat, ah yes, that rings a bell [15:58] http://yuilibrary.com/yui/docs/api/classes/Loader.html [15:58] async defaults to true [15:58] the change he made is still a reasonable one though, I think. But it would be better to talk about itbevore we go down that road [15:58] bac benji frankban hazmat jovan2 Makyo teknico tveronezi call in 2 [15:58] benji, and it partly explains YUI's bad placement in speed comparisons like http://jsperf.com/js-mvc-frameworks-models/3 [16:02] hazmat: I muted your keyboard. ;) [16:03] benji, danke ;-) [16:03] benji, re 2k per instance, that's why we're using the lazy their [16:03] there [16:03] * benji buys hazmat some cherry brown switches for his keyboard for Christmas. [16:04] mmm, makes sense [16:06] benji, cherry red atm [16:07] hmm.. actually cherry blue.. the brown's would sound nice though.. stealth mode [16:12] but i just refactored the picker! :( [16:17] ben is on a bus with spotty wifi [16:18] his review email disappeared for some reason [16:18] but it is here: [16:18] https://codereview.appspot.com/6858045/ [16:18] hazmat, ^^^ [16:18] gary_poster, aha.. [16:18] gary_poster, cool, thanks [16:18] gary_poster, odd about the lack of lp email [16:19] gary_poster, oh. its the wrong merge target [16:20] bac benji frankban hazmat Makyo teknico tveronezi if you have some time, bcsaller would like reviews of https://codereview.appspot.com/6858045/ . Two people can do the more thorough review, but he'd be interested in broader, bigger picture reviews too [16:20] This is the environment view refactoring [16:20] actually pls hold off on that for a few.. [16:20] the diff is bad [16:20] it is supposed to show a pattern for writing the environment view and for writing environment view tests [16:21] ok cool hazmat. you contacting him or fixing it? [16:21] gary_poster, yeah.. on the phone [16:21] cool [16:21] k [16:22] gary_poster, so he's go no network access atm.. i'm going to just resubmit with the correct parent [16:23] cool thanks hazmat [16:54] The UI is very brittle regarding font sizes; upsizing the font by one unit (by pressing control +) breaks the layout. [16:56] benji, all these absolute sizes are badness.. [16:57] yep [16:57] gotta think about ems and relatives [17:01] hey Makyo, do bac and bcsaller know that you are waiting on their reply to move lp:~makyo/juju-gui/adding-subordinates ? [17:03] gary_poster, I just wanted bcsaller to check on the test, but I suppose anyone can okay that. I tried pinging him yesterday, but flaky internet got the best of us. [17:04] That's https://codereview.appspot.com/6856067/diff/5001/test/test_environment_view.js if anyone would like to take a quick peek. [17:08] Dog's being a brat, going to take him for a quick walk and hope that helps. [17:27] Makyo: +1 on the test [17:27] bac, thanks. If it's good with you, I'll land. [17:27] sure [19:01] * Makyo -> doctor [19:27] the env refactor is at https://codereview.appspot.com/6842084/ [19:27] had some troubles on the initial propose [19:34] hazmat: that is the branch that Ben wants many people to peruse, right? [19:34] benji, it is [19:34] cool, I'll do that [19:34] benji, awesome thanks.. [19:35] i'm hoping he'll be around in the next hr to correct the mp himself.. but that at least gives a nice review diff [19:48] man tty.js is pretty sweet [20:30] ubuntu + mbp + bulging battery = very low untethered work time [20:37] * gary_poster here with less tooth than before [20:40] yikes [20:40] * bac dog walk. bbiab. [20:46] * benji recommits to flossing more often. [20:56] gary_poster: is bug 1078978 up for grabs? It looks fun. [20:56] <_mup_> Bug #1078978: CSS is not minified in static deployment < https://launchpad.net/bugs/1078978 > [20:59] hmm, it may be blocked on bug 1078910 though [20:59] <_mup_> Bug #1078910: development server is unnecessarily complicated and different from production delivery < https://launchpad.net/bugs/1078910 > [21:04] benji, I don't think one has to be solved before the other, but could be wrong [21:05] gary_poster: I would at least need to base my branch on the branch for 1078910, right? Wait, maybe not... enough minimization is in the trunk that I can base it on that, right? [21:06] but yes, they are up for grabs. benji, https://code.launchpad.net/~tveronezi/juju-gui/change-requires-param ought to be landed, or massaged and landed, before that. If you could take that it would be helpful, and would set you up for the rest [21:06] do you want to have a call? [21:06] gary_poster: sure [21:06] I didn't have laughing guess, but I am numb, so my speech might be at least mildly amusing [21:06] gas [21:07] I'll take what I can get. [21:07] :-) [21:07] ok juju-ui looks empty [22:19] Ugh, sorry, awful traffic. Back. [22:23] have a great rest of week, weekend, and Thanksgiving where appropriate, everyone! === gary_poster is now known as gary_poster|away