| === Ursinha_ is now known as Ursinha | ||
| === yofel is now known as Guest73835 | ||
| === almaisan-away is now known as al-maisan | ||
| === al-maisan is now known as almaisan-away | ||
| === Guest73835 is now known as yofel | ||
| === mrs_poolie is now known as cinerama | ||
| === cinerama is now known as mrs_poolie | ||
| === mrs_poolie is now known as cinerama | ||
| === cinerama is now known as mrs_poolie | ||
| StevenK | wgrant: https://code.launchpad.net/~stevenk/launchpad/re-enable-workermonitor/+merge/136072 | 23:13 |
|---|---|---|
| wgrant | StevenK: Why? | 23:16 |
| StevenK | mrs_poolie: \o/ | 23:16 |
| StevenK | wgrant: To close a critical and have less disabled tests? | 23:17 |
| wgrant | StevenK: I mean, what's the justification for just increasing the timeout? | 23:17 |
| wgrant | Why should these things take a minute? | 23:17 |
| wgrant | (it's a trick question; no test can ever be allowed to run for a minute) | 23:17 |
| mrs_poolie | hi StevenK :) | 23:18 |
| StevenK | wgrant: Well, I'm not sold on 60, I was just seeing if increasing the timeout would stop the tests failing -- given 20 seems bad, I wasn't sure about 30. | 23:18 |
| wgrant | Ah, they run subprocesses, I see | 23:19 |
| StevenK | And it's a timeout, it isn't supposed to take that long, that's when we give up and fail the test, no? | 23:19 |
| wgrant | Your __all__ is missing a comma | 23:19 |
| wgrant | Otherwise good | 23:19 |
| StevenK | Ah, so it is | 23:20 |
| StevenK | wgrant: Can haz approve? | 23:23 |
| wgrant | Done | 23:23 |
| StevenK | Hmm, kanban actually logged me out | 23:25 |
| bigjools | mrs_poolie: nice nick! | 23:39 |
| mrs_poolie | hi bigjools | 23:40 |
| bigjools | mrs_poolie: fyi, the Ghiardelli chocolate did *not* last long | 23:40 |
| mrs_poolie | bigjools: lol. we still have lots here. going to give some away | 23:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!