[00:05] <nigelb> mrs_poolie: lol. epic nick there :)
[01:10] <lifeless> mrs_poolie: \o/
[01:11] <mrs_poolie> hi lifeless
[01:11] <lifeless> mrs_poolie: back in Sydney ?
[01:15] <mrs_poolie> lifeless: yes, we have been for about a week. just doing my normal rounds as fire-putter-outter this week
[01:19] <lifeless> cool
[01:51] <StevenK> wgrant: https://code.launchpad.net/~stevenk/launchpad/archive-edit-dependencies-oops/+merge/136075
[01:56] <wgrant> StevenK: I'd suggest not hardcoding those components
[01:56] <wgrant> eg. I can probably set contrib without an API OOPS
[01:56] <wgrant> It seems like you could create the SimpleTerm at runtime given the current component.
[01:56] <StevenK> Ah, right
[01:57] <StevenK> wgrant: Do you object to the wording?
[01:58] <wgrant> Yes, but I'm not sure there's much better, so it'll do
[02:04]  * StevenK tosses up between "if default_value not in (None, multiverse):" or "if default_value and default_value != multiverse:"
[02:17] <StevenK> wgrant: Diff updated
[03:13] <bigjools> halp: I have a recipe for raring that's ending up in quantal: https://code.launchpad.net/~julian-edwards/+recipe/maas-daily
[03:14] <bigjools> oh hang on, I bet it's matsubara's stuff
[03:28] <StevenK> Bloody hell, what is the point of mentioning OOPSes in bugs if they get pruned anyway.
[03:57] <wgrant> StevenK: Which?
[03:58] <StevenK> wgrant: https://bugs.launchpad.net/launchpad/+bug/1007131 comment 1
[03:58] <_mup_> Bug #1007131: MalformedHunkHeader: Malformed hunk header.  Does not match format. '<!--\r <bzr> <oops> <Launchpad itself:Triaged> < https://launchpad.net/bugs/1007131 >
[03:59] <wgrant> StevenK: Hm, the ones from 2012-11-05 got pruned?
[04:00] <StevenK> wgrant: Yup
[04:03] <StevenK> Not that they're incredibly helpful
[04:07] <StevenK> I have this feeling that it was a short read or something, but I'm still struggling to figure out how it was called
[04:19] <StevenK> wgrant: Can haz review again?
[04:25] <wgrant> StevenK: Looking
[04:26] <wgrant> StevenK: Done
[04:27] <StevenK> wgrant: I changed the docstring for the method -- I can move that down to be just before the if block if you wish?
[04:27] <wgrant> Ah, I guess the docstring isn't too far away, so it's probably fine
[04:28] <StevenK> ~ 20 lines
[04:28] <StevenK> or so
[05:17] <StevenK> Bleh, I can't work out how bzrlib.patches works
[05:17] <StevenK> I have a diff that gets to raise MalformedHunkHeader, because of a bug that is setting a header from the file to be '<!--'
[05:40] <StevenK> OH
[05:41] <StevenK> It looks like it does not love dos line endings, and manages to skip most of the file
[08:31] <adeuring> good morning
[09:00] <czajkowski> Aloha
=== adeuring1 is now known as adeuring
=== almaisan-away is now known as al-maisan
=== al-maisan is now known as almaisan-away
=== benji changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On-call reviewer: benji | Firefighting: - | Critical bugs: ~170
=== lan3y is now known as Laney
=== gary_poster|away is now known as gary_poster
[14:31] <deryck> jcsackett, ping for standup
[14:56] <rick_h_> adeuring: what branch did you need looked at?
[14:56] <adeuring> rick_h_: justr a second; need to write the mp...
[14:56] <rick_h_> ah ok cool
[14:57] <adeuring> rick_h_:  https://code.launchpad.net/~adeuring/launchpad/bug-1056881-2/+merge/136194
[15:07] <rick_h_> adeuring: r=me
[15:07] <adeuring> rick_h_: thanks!
[15:09] <abentley> rick_h_:
[15:15] <sinzui> benji, , do you have time to review https://code.launchpad.net/~sinzui/launchpad/redirect-201/+merge/136198
[15:15] <benji> sinzui: I should in the next hour or so; on a call now
=== matsubara is now known as matsubara-lunch
[16:15] <jcsackett> benji: do you have time to review https://code.launchpad.net/~jcsackett/launchpad/blueprints-in-ui-not-specification-2/+merge/136213 after sinzui's?
[16:16] <benji> jcsackett: sure
[16:16] <jcsackett> benji: thanks.
[16:16] <benji> np
[16:36] <benji> Why did I recieve a notice about a juju-gui mailing list that is (now) disactivated?
[16:36] <benji> Why am I talking about it in this channel?
=== deryck is now known as deryck[lunch]
[17:35] <czajkowski> rick_h_: wow you're busy :)
[17:39] <rick_h_> czajkowski: bwuhahaha, it's why I do deploys. I look so busy when I flood the bug mails
[17:39] <czajkowski> lol
=== matsubara-lunch is now known as matsubara
=== deryck[lunch] is now known as deryck
=== yofel_ is now known as yofel
=== _mup__ is now known as _mup_
=== lifeless_ is now known as lifeless
=== benji___ is now known as benji
[21:39] <sinzui> benji, Do you have time to review https://code.launchpad.net/~sinzui/launchpad/team-without-admin/+merge/136274
[21:40] <benji> sinzui: sure; I'll look at it now.
[21:42] <benji> I know understand why people like inline commenting in code review apps.  After using it for a few months, doing reviews without it is irritating.
=== benji changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On-call reviewer: - | Firefighting: - | Critical bugs: ~170
[23:14] <wgrant> StevenK, sinzui: Using a team CTE gets that person search down from 2100 to 220 on DF
[23:15] <wgrant> Most of the remaining time is in the email search, as expected, but it's probably not worth eliminating