| === Makyo is now known as Makyo|out | ||
| === _mup__ is now known as _mup_ | ||
| gary_poster | frankban, approved your canonicaladmin days, thank you. Starting on review of the charm branch now | 13:19 |
|---|---|---|
| frankban | gary_poster: cool thanks! | 13:24 |
| gary_poster | welcome :-) | 13:24 |
| * bac fights with chinstrap over new ssh keys | 13:32 | |
| hazmat | morning | 13:47 |
| gary_poster | morning | 13:49 |
| gary_poster | review done frankban | 14:32 |
| frankban | thanks gary_poster | 14:33 |
| teknico | gary_poster, frankban, do you have some time for talking about static file serving? | 14:36 |
| benji | gary_poster: I would like a consult re. image assets when you get a chance, I have learned of some new, complicating factors | 14:38 |
| gary_poster | teknico, I'm supposed to have another call in a sec but could start now | 14:38 |
| gary_poster | ack benji | 14:39 |
| benji | I am going to go make a protein shake in the meantime. | 14:39 |
| gary_poster | teknico, juju-ui? | 14:39 |
| teknico | gary_poster, ok | 14:39 |
| === Makyo|out is now known as Makyo | ||
| * bac reviewing frankban's branch | 14:50 | |
| frankban | thanks bac | 14:50 |
| Makyo | frankban, thanks for the tip on imports. | 15:07 |
| Makyo | Ditto, gary_poster, will prowl through the PEP | 15:08 |
| gary_poster | cool | 15:08 |
| gary_poster | bac bcsaller benji jovan2 Makyo call in 1 | 15:29 |
| bac | rt | 15:29 |
| gary_poster | (the rest of us are already there :-) ) | 15:29 |
| gary_poster | benji, actually you ready now? | 16:20 |
| gary_poster | juju-ui | 16:20 |
| benji | gary_poster: I wasn't, but am now; coming over. | 16:23 |
| gary_poster | cool | 16:23 |
| bac | gary_poster, hazmat: does 'improv' have some inherent meaning or is that just what the script is named? i'm concerned about exposing the name in the charm docs as if it means something. let me know if i'm missing something. | 18:31 |
| hazmat | bac, we can change the name.. it was improv theater inspired ;-) | 18:31 |
| hazmat | bac, simulator.py ? | 18:32 |
| bac | hazmat: no, i don't think the script needs to be changed. i just don't think our docs should assume anyone else knows what the heck it is | 18:32 |
| bac | e.g.: this from the conf template: description "Juju API improv" | 18:33 |
| bac | benji: would you have time/interest in reviewing my branch today? | 20:15 |
| benji | bac: I have both. Which one? | 20:17 |
| bac | benji: the one in review! :) | 20:17 |
| benji | oh, I see it on the board | 20:17 |
| benji | :) | 20:17 |
| Makyo | gary_poster, call? | 20:31 |
| gary_poster | y Makyo 1 sec | 20:32 |
| Makyo | gary_poster, np | 20:32 |
| bac | thanks benji | 20:42 |
| benji | bac: my pleasure | 20:42 |
| bac | benji: when did we switch to 'one var'? | 20:43 |
| bac | i like the idea...just missed it | 20:43 |
| benji | bac: you know what; we may not have officially switched yet; I ran the idea by several people and they all liked it, but I have to remember now if I pushed it through 100% (this was just before I got sick) | 20:45 |
| bac | benji: yeah, i don't recall discussing it. i think for a list of single-line declarations i'd be fine with not repeating 'var'. when they span pages, though, i find it really irritating. | 20:46 |
| bac | so if we had to have a simple rule, i'd go with 'one per' | 20:46 |
| benji | bac: s/pages/lines/ ? | 20:47 |
| bac | yes, i meant lines but it is even worse when they are *pages* (such as my code you dinged) | 20:47 |
| benji | :) | 20:48 |
| benji | bac: the reason I wanted to add vars is that it enables a sane and consistent object literal style; I'll figure out the current status of that and email the list shortly | 20:54 |
| benji | bac: here is the mail I sent out last week: https://lists.launchpad.net/juju-gui-peeps/msg01483.html | 21:01 |
| benji | If I had been thinking about it, this is something we should have discussed today on the call. | 21:01 |
| benji | Interesting, I don't see the style guide changes in trunk. I wonder if someone reverted it. | 21:02 |
| * bac eods -- have a good weekend. | 21:05 | |
| Makyo | Walking dog before the clouds roll in, back in a few | 21:11 |
| gary_poster | EoD for me too | 21:20 |
| gary_poster | Have a good weekend | 21:20 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!