| === slank is now known as slank_away | ||
| === Ursinha-afk is now known as Ursinha | ||
| === Ursinha is now known as Ursinha-afk | ||
| lifeless | bigjools: if they paste the error they are having they might get help! | 01:16 |
|---|---|---|
| bigjools | lifeless: well, quite :) | 01:17 |
| adeuring | good morning | 08:50 |
| deryck | Morning, all. | 10:57 |
| rick_h_ | morning deryck | 12:04 |
| rick_h_ | adeuring: do you have time to do a hangout on this zcml fun please? | 12:04 |
| adeuring | rick_h_: sure | 12:04 |
| rick_h_ | adeuring: woot! all the product tests passed. So back to my own new tests and making this work. Thanks! | 12:59 |
| adeuring | rick_h_: welcome :) | 12:59 |
| === Ursinha-afk is now known as Ursinha | ||
| sinzui | jam, mgz: I don't understand the issue with this import to help the user. Can you help? https://answers.launchpad.net/launchpad/+question/215746 | 13:16 |
| === yofel_ is now known as yofel | ||
| === rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On-call reviewer: rick_h | Firefighting: - | Critical bugs: ~170 | ||
| rick_h_ | adeuring: can you please review this branch we chatted about then since I'm OCR? https://code.launchpad.net/~rharding/launchpad/changing_maintainer_1077841/+merge/137849 | 14:25 |
| adeuring | rick_h_: sure | 14:26 |
| rick_h_ | thanks | 14:26 |
| adeuring | ricr=me | 14:30 |
| sinzui | rick_h_, do you have time to review https://code.launchpad.net/~sinzui/launchpad/cleanup-merged-people-1/+merge/137700 | 14:34 |
| rick_h_ | sinzui: will do after call | 14:42 |
| === slank_away is now known as slank | ||
| rick_h_ | sinzui: r=me | 15:27 |
| sinzui | thank you rick_h_ | 15:28 |
| adeuring | rick_h_: could you please review this mp: https://code.launchpad.net/~adeuring/launchpad/bug-1086043/+merge/137882 ? | 15:43 |
| rick_h_ | sure thing adeuring | 15:44 |
| adeuring | htanks! | 15:44 |
| === matsubara is now known as matsubara-lunch | ||
| mattyw | I'm having a go at fixing bugs in loggerhead. I'm trying to run serve-branches but all I get from my browser is: The resource could not be found. Anyone able to offer a couple of minutes to help me work out what I'm doing wrong? | 15:56 |
| rick_h_ | mattyw: when I last ran it I could only get it to work against a single branch and not against a direcotry of them | 15:58 |
| mattyw | rick_h_, from within my loggerhead source directory I do ./serve-branches (no args) correct? I believe that should give me one branch | 16:00 |
| rick_h_ | ok, what I had to do to get it working was install it as a bazaar plugin, and then use bzr serve --http | 16:05 |
| rick_h_ | mattyw: https://code.launchpad.net/~rharding/loggerhead/yui3.7.1 is the branch I had going to work on YUI update there and I had to go that plugin route to get it to run/verify | 16:07 |
| rick_h_ | adeuring: one question and one comment fix on your MP | 16:09 |
| rick_h_ | adeuring: your tests pass though, so maybe I'm mis-understanding things which is why you didn't have to move the displayname to the new interface as well? | 16:10 |
| * adeuring is looking | 16:10 | |
| adeuring | rick_h_: I am pretty sure that displayname will be needed to fix bug 1086057. But the bug listings do not show the displyname; the series's name is needed in the call of canonucal_url() | 16:12 |
| _mup_ | Bug #1086057: Users with an artifact grant for a bug related to a private product can't view the bug page. <Launchpad itself:Triaged> < https://launchpad.net/bugs/1086057 > | 16:12 |
| adeuring | rick_h_: but for now, I'd like to keep displayname protected by lp.View -- simply because it is not needed in the bug listing | 16:14 |
| rick_h_ | adeuring: right, so you moved displayname in the zcml from one block to the other. Then you moved name into IProductSeriesLimitedView, but not displayname | 16:14 |
| rick_h_ | adeuring: ah ok gotcha | 16:14 |
| === gary_poster is now known as gary_poster|away | ||
| mattyw | rick_h_, thanks that seems to work | 16:14 |
| adeuring | rick_h_: argh, yes, no I get the oddity. let me check again | 16:15 |
| adeuring | rick_h_: milestone.displayname needs lp.LimitedView for bug listing page, but productseries.displayname is not needed there... As said, I'll probably have to use lp.LimitedView for productseries.dispalyname in my next brnach | 16:18 |
| rick_h_ | adeuring: right ok. so r=me just wanted to dbl check there | 16:18 |
| rick_h_ | zcml turning my brain to mush today | 16:19 |
| adeuring | rick_h_: thanks. YOur question made sense -- it was probably not the best idea to change the permission for two different classes in one branch ;) | 16:19 |
| === gary_poster|away is now known as gary_poster | ||
| james_w | rick_h_, hi, would you take a look at the extra revisions on https://code.launchpad.net/~james-w/python-oops-tools/recent-oopses/+merge/137055 please? | 16:25 |
| james_w | they are to fix the tarmac test failure under python2.6 | 16:25 |
| sinzui | rick_h_, do you have time to review https://code.launchpad.net/~sinzui/launchpad/revision-karma-2/+merge/137906 | 16:29 |
| * sinzui looks at james_w's branch | 16:30 | |
| james_w | thanks sinzui | 16:30 |
| sinzui | ah, I see. r-=me | 16:30 |
| sinzui | james_w, r=me. | 16:31 |
| james_w | sinzui, merci | 16:31 |
| rick_h_ | sinzui: sure thing looking | 16:36 |
| rick_h_ | sinzui: r=me | 16:44 |
| sinzui | thank you rick_h_ | 16:44 |
| === matsubara-lunch is now known as matsubara | ||
| === deryck is now known as deryck[lunch] | ||
| === almaisan-away is now known as al-maisan | ||
| mattyw | rick_h_, me again, I thought I'd look into this bug https://bugs.launchpad.net/loggerhead/+bug/358293. But I can't seem to even find the search box displayed anywhere. | 17:26 |
| _mup_ | Bug #358293: Search field is too narrow <trivial> <ui> <loggerhead:Triaged> < https://launchpad.net/bugs/358293 > | 17:26 |
| rick_h_ | mattyw: hmm, wonder if it's not displayed in a single branch view | 17:28 |
| === al-maisan is now known as almaisan-away | ||
| mattyw | rick_h_, hmmm, looks like this is what I see https://bugs.launchpad.net/loggerhead/+bug/1075907 | 17:33 |
| _mup_ | Bug #1075907: Loggerhead - serving two directories from parent <loggerhead:Confirmed> < https://launchpad.net/bugs/1075907 > | 17:33 |
| rick_h_ | mattyw: right | 17:34 |
| rick_h_ | sinzui: forced another build-not build | 17:37 |
| sinzui | oh, so did I | 17:42 |
| rick_h_ | heh, crush the buildbot! | 17:42 |
| === deryck[lunch] is now known as deryck | ||
| === Ursinha is now known as Ursinha-afk | ||
| === Ursinha-afk is now known as Ursinha | ||
| wgrant | deryck: Hi, did the definitional issue that I raised last night get sorted out before we announced private projects were out of beta? | 20:09 |
| wgrant | I suspect we've released a definition of privacy that we can't support. | 20:09 |
| wgrant | Specifically, AIUI we say that series and milestones are private from people who can only see a bug, when that's impossible. | 20:09 |
| === rick_h_ changed the topic of #launchpad-dev to: http://dev.launchpad.net/ | On-call reviewer: - | Firefighting: - | Critical bugs: ~170 | ||
| deryck | hi wgrant. It's not landed yet, but abel has a branch nearly done. Should be landing during his tomorrow. | 20:29 |
| wgrant | Ah, great. | 20:29 |
| deryck | wgrant, thanks for catching that and letting us know. | 20:30 |
| wgrant | It just reveals some details of milestones and series? | 20:30 |
| deryck | yeah | 20:30 |
| deryck | well, and a list 403s | 20:30 |
| wgrant | I mean, how does the fix fix it? | 20:30 |
| deryck | wgrant, that was the yeah, and then I thought you meant something else. sorry. :) | 20:31 |
| wgrant | Right :) | 20:31 |
| wgrant | Thanks | 20:31 |
| deryck | wgrant, we fix it with limited view to reveal the name of the milestones and series. | 20:31 |
| === gary_poster|away is now known as gary_poster | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!