| soren | jodh: (Moving here, as it's not really on topic for #launchpad) So what are the current requirements for (current) upstart? | 12:16 |
|---|---|---|
| jodh | soren: wrt the kernel version '2.6.24' according to Keybuks top-level README. The PPA environment appears to provide 2.6.24-32-xen. Upstart is built and run in many other environments and we've never seen the test failures currently seen when attempting to build lp:upstart in a PPA env. | 12:20 |
| jodh | soren: so that kernel version _may_ be problematic although I do not understand how the kernel version could cause the failure we're seeing. | 12:21 |
| soren | jodh: Do older versions fail in the same way? Did the environment change? | 12:21 |
| jodh | soren: older versions of what? We have never been able to build lp:upstart in a PPA env sadly, due to the issue outlined. | 12:23 |
| soren | jodh: Oh, I thought it was a new issue. | 12:24 |
| soren | jodh: Wow, so upstart has never built in PPA's? Ever? | 12:24 |
| soren | https://launchpadlibrarian.net/124769395/buildlog_ubuntu-quantal-amd64.upstart_1.5-0ubuntu9_BUILDING.txt.gz | 12:26 |
| jodh | soren: correct - I was the first to try it I believe some months back and have been trying to work out what the problem is. | 12:30 |
| jodh | soren: no - not the ubuntu build, the build of lp:upstart. | 12:31 |
| xnox | soren: it does build, but cannot run/pass upstream test-suite. But the reason why we want to build in the ppa is to have daily-builds and test-suite runs. | 12:33 |
| soren | xnox: Doesn't the Ubuntu build run the test suite? | 12:36 |
| xnox | soren: it does, but not on every upstream commit & we are doing a lot of upstream development this cycle. | 12:37 |
| soren | xnox: I don't follow. So the upstream test suite is run by the Ubuntu builds and these Ubuntu builds work in PPA's, but not "upstream" builds. Am I correct so far? | 12:40 |
| xnox | soren: not quite. | 12:41 |
| xnox | soren: lp:ubuntu/upstart is quite modified from lp:upstart. When we merge lp:upstart into lp:ubuntu/upstart and upload into the ubuntu archive, non-virt distro builders build it / ran the test-suite and all is fine. | 12:42 |
| xnox | soren: but when we upload just lp:upstart into the ppa (without ubuntu specific modifications) it builds, but the test-suite hangs the virt PPA. | 12:43 |
| * xnox is now not sure if that's what you meant or not. | 12:43 | |
| soren | I think so. | 12:44 |
| soren | I'm just a wee bit surprised that we have one version that works and another that doesn't (which is a pretty good starting point for pinpointing the problem if it can't be done by simple code inspection), yet instead of fixing the problem we're replacing the build infrastructure to avoid it. | 12:46 |
| soren | Not my call, obviously, but I'm just concerned that the issue causing this failure is going to come bite me in the behind one day. | 12:48 |
| jodh | soren: We are surprised too | 13:27 |
| jodh | soren: is there any plan to upgrade the PPA env environment to atleast lucid? | 13:28 |
| soren | jodh: I have no idea. | 13:28 |
| * soren is not involved with Launchpad | 13:28 | |
| soren | Sorry if I gave that impression. | 13:28 |
| jodh | soren: ok. so back to #launchpad? :-) | 13:33 |
| xnox | jodh: I am looking at the multiple directories support and upstart does cleanly support multiple conf sources, but the libnih option parsing just uses the last one passed. | 13:53 |
| xnox | jodh: so the question I have, is do we want syntax similar to: | 13:54 |
| xnox | --configdir dir1 --configdir dir2 | 13:54 |
| xnox | or | 13:54 |
| xnox | --configdir dir1:dir2 | 13:54 |
| xnox | in the first-case libnih should get support for building up a nih_list of options, in the latter case proper : splitting and escaping validation needs to be done. | 13:55 |
| xnox | it is a bit moot, since --user (or whatever option we will use for user sessions) will default to a list of xdg-config environment variables with fallbacks. | 13:56 |
| xnox | fallbacks to default xdg locations.... | 13:56 |
| jodh | xnox: I'd prefer '--confdir dir1 --confdir dir2' | 13:59 |
| xnox | jodh: ack. | 13:59 |
| xnox | jodh: i will look into tricking libnih to build a nih_list from those. | 14:00 |
| jodh | xnox: this is possible with nih by utilising an NihOptionSetter. See ignored_events_setter() in initctl.c for an example. | 14:00 |
| jodh | xnox: nih will 'visit' each argument, and call the provided setter function each time. | 14:00 |
| xnox | jodh: should it be --configdirs dir1 --configdirs dir2, cause currently --configdir dir1 --configdir dir2 results in dir2 being used by upstart. | 14:00 |
| jodh | xnox: so all you need to do is create a NihListEntry list and add the paths to it. | 14:00 |
| xnox | jodh: interesting. Let me look that up. | 14:01 |
| jodh | xnox: it should be '--confdir' as that is the current option name. | 14:01 |
| xnox | ok. | 14:01 |
| jodh | xnox: so yes, in the simplistic case, "the last option wins", but if you use a setter function, you have full control. | 14:01 |
| === marrusl_ is now known as marrusl | ||
| xnox | jodh: it's just feel uneasy changing the meaning of current command line arg parsing. | 14:02 |
| xnox | s/feel/feels/ | 14:03 |
| xnox | hence the argument to support both --confdir & --confdirs. | 14:03 |
| xnox | but that can be confusing. | 14:03 |
| jodh | xnox: we're not changing the current behaviour though: '--confdir /foo/bar' should still continue to work. | 14:03 |
| xnox | jodh: '--confdir /foo/bar --confdir /bar/foo' today vs in future is changing, unless we reverse the confsource list (e.g. the last one has highest priority, i.e. first in the confsource list) | 14:05 |
| xnox | that should work. | 14:05 |
| jodh | xnox: well from the Upstart perspective nobody should be even using --confdir let alone specifying it multiple times :-) We could always add in a --traditional flag maybe but I'm not convinced its worth it. | 14:09 |
| jodh | xnox: what we could do is only use the new behaviour if --user is specified and document clearly in init(8) the impact using --user has on --confdir. | 14:10 |
| xnox | jodh: well we should have been erroring out on passing multiple confdirs, but we cannot turn the time back. | 14:10 |
| xnox | jodh: the "backwards" compatible way is to then list --confdir /etc/xdg/upstart --confdir /etc/xdg/xdg-ubuntu/upstart --confdir ~/.config/upstart | 14:11 |
| jodh | xnox: that's not how nih works by default. To do that, every option would need to have a setter which just shouldn't be necessary. | 14:11 |
| xnox | this way it looks good to me ( the ignorant) LTR speaker. | 14:12 |
| jodh | xnox: you forgot ~/.init :) | 14:12 |
| xnox | jodh: the impact difference is that in the past only the jobs in the last confdir were used, but now the unique onces in the previous dirs will also be used. | 14:13 |
| xnox | jodh: but that does not help with the environment variable. | 14:13 |
| xnox | jodh: what priority UPSTART_CONFDIR has? =) | 14:14 |
| xnox | and XDG_CONFIG_HOME? =) | 14:14 |
| jodh | xnox: we have (attempted to) document this behaviour here: https://wiki.ubuntu.com/FoundationsTeam/Specs/RaringUpstartUserSessions#Configuration_Files_for_User_Jobs | 14:20 |
| jodh | xnox: although I've never heard of UPSTART_CONFDIR :) | 14:21 |
| xnox | * CONFDIR_ENV: | 14:22 |
| xnox | * | 14:22 |
| xnox | * If this environment variable is set, read configuration files | 14:22 |
| xnox | * from the location specified, rather than CONFDIR. | 14:22 |
| xnox | * | 14:22 |
| xnox | * Value is expected to be the full path to an alternative job | 14:22 |
| xnox | * configuration directory. | 14:22 |
| xnox | **/ | 14:22 |
| xnox | #ifndef CONFDIR_ENV | 14:22 |
| xnox | #define CONFDIR_ENV "UPSTART_CONFDIR" | 14:22 |
| xnox | #endif | 14:22 |
| xnox | =)))))))))))))))))))))))))))))) | 14:22 |
| xnox | jodh: blame says 1284.1.1 james.h =))))) | 14:22 |
| jodh | xnox: that was added for testing and is not a documented "external". | 14:25 |
| xnox | jodh: shows up in the gtk-docs I generated locally ;-) | 14:27 |
| xnox | jodh: what does CONFFILE "/etc/init.conf" used for? | 14:27 |
| xnox | is it in the case when upstart is used as sysvinit compat mode only? and /etc/init.conf bootstraps that and that's it | 14:28 |
| xnox | ? | 14:28 |
| soren | jodh: Well, what I wanted to discuss was about upstart, not Launchpad. Hence the move here. But meh. | 14:31 |
| jodh | xnox: init.conf is not used at all right now. | 14:31 |
| xnox | jodh: sure, but it's loaded as a conf source by default =) | 14:32 |
| jodh | xnox: ignore it. | 14:32 |
| xnox | =)))) | 14:32 |
| xnox | jodh: "Currently, PID 1 looks for a users Job configuration files in directory $HOME/.init/. This behaviour will be retained." | 15:13 |
| xnox | as in the PID 1 will continue to parse those, or will the usersession upstart parse those at the highest priority? | 15:14 |
| xnox | jodh: and the override file will only "work" next to the job file. | 15:17 |
| xnox | e.g. ~/.config/upstart/foo.override will not override /etc/xdg/upstart/foo.conf, but /etc/xdg/upstart/foo.override will override /etc/xdg/upstart/foo.conf | 15:18 |
| jodh | xnox: that sentence is certainly ambiguous. Certainly only the Session Inits should be considering ~/.init for enhanced sessions. I think we should document ~/.init as deprecated, but honour it for now as being the first directory to search. | 15:20 |
| jodh | xnox: well, we want the user to be able to disable a system job, so ~/.config/upstart/foo.override should override /etc/xdg/upstart/foo.conf. I think it would be highly beneficial if you added some more detail to the spec on this to make it totally clear. We can discuss tomorrow if you like with stgraber? (currently trying to get something finished by COB :) | 15:22 |
| xnox | So the order is: --confdir ; ~/.init ; xdg_config_home; for each in xdg_config_dirs | 15:22 |
| xnox | first one wins. | 15:22 |
| xnox | jodh: no. I disagree, because ~/.config/upstart/foo.conf will be treated higher priority than /etc/xdg/upstart/foo.conf | 15:23 |
| xnox | jodh: but the system administrator may want to override that job for all users in /etc/xdg/upstart/foo.override | 15:23 |
| jodh | xnox: yes. ok, well lets add some more use cases to the spec and discuss tomorrow? | 15:24 |
| xnox | jodh: and the user may want to temprorarly over-override ~/.config/upstart/foo.conf with ~/.config/upstart/foo.override, regardless whether /etc/xdg/upstart/foo.* exist or not. | 15:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!