=== Makyo is now known as Makyo|out [10:13] uh oh, uistage is broken [10:14] I just landed a branch, but it's only doc changes, it shouldn't have broken it [10:48] teknico: working on it, it's not your branch [10:48] frankban, great, thanks [11:30] frankban, it worked :-) [11:31] teknico: yes indeed, it was just a missing reference in modules.js [11:32] yep === rogpeppe1 is now known as rogpeppe [13:00] thank you for fixing uistage et al, frankban [13:04] gary_poster: welcome [13:13] gary_poster: is "needs retrospective" the right tag for when you want to discuss some details of that card during our Friday's call? [13:13] I mean: "class of service" -> "needs retrospective" [13:13] goodspud, hi. I have a local lunch meeting at the time of the unit and service view meeting. mm, benji or bac, you have experience with those pages. Are you willing and able to attend a meeting at 1630-1700UTC and then report back to the group with minutes as I describe in "Engineer responsibilities" at the end of https://docs.google.com/a/canonical.com/document/d/1GevzPVClAJaGX7YHG6SmdX2geGvR7uXc4xnuc7VY3t4/edit [13:13] # ? [13:14] Specifically: [13:14] Engineer keeps minutes of the questions received, the input given, the decisions made, and the outstanding engineer-related questions and action items. [13:14] Engineer sends minutes to Juju GUI team and design team. [13:14] Engineer is responsible for getting the answers to each outstanding question from the meeting, or explicitly getting someone else to take over for that question. If someone else takes responsibility, this hand-off is sent to the Juju GUI team and the design team. The same goes for action items. [13:14] If an engineer is still on the hook for an answer or action item when a new meeting is called, they should consider themselves volunteered for the next meeting. [13:14] frankban, yes [13:14] gary_poster: cool thanks [13:15] gary_poster: yes [13:15] welcome [13:15] thanks bac, I'll add you to the invitation [13:15] i like the coercion of that last point. [13:15] way to light a fire [13:15] heh [13:16] I'll bring snacks along to the meeting [13:16] :) [13:16] :-) [13:23] benji, out of pur nosy curiosity, any progress on getting the production tests to pass? I'm very curious as to what the resolution will be [13:24] yep, I am down from approximately eight billion failures to 2 [13:24] benji, lol, excellent [13:24] they both appear to be of different classes of failures, so they will probably require different fixes, but I feel pretty good about it [13:26] cool, benji, thanks for overview. once you get it working I'm thing that the default test target ought to test the production story, so we all are testing the end result by default. we'd keep the previous test target as a way to debug. wdyt? [13:27] teknico, approved Friday, no worries [13:27] that's reasonable; if the tests were not so slow I would suggest running them both (or all three?), but that is not the case [13:27] right [13:27] I know! we could parallelize them with lxc! [13:27] wait, no... [13:29] lol [13:38] bcsaller, could you update kanban board to reflect your current progress please? [13:38] gary_poster: done [13:39] thanks bcsaller [13:41] bcsaller, what's next after ultra-mega? [13:42] hazmat: panzoom is in progress, put it on the board [13:42] one of the smaller ones to sort out remaining issues [13:42] part way through it after yesterday [14:14] gary_poster, thanks [14:14] welcome [14:18] in the code we have README and HACKING files, while in the charm we have README.txt , does anyone care about the extension? [14:23] I usually add it, but don't care a lot. teknico, you available for a quick call on another topic (Makefile fun)? [14:24] gary_poster, in five minutes? [14:24] teknico, I have another meeting in 5 minutes :-) can do it in 35 [14:24] gary_poster, ok, I'll hop on right away then [14:24] ok thanks [14:39] bac, what happens if the kanban active lanes are full and lp2kanban needs to put a card there? [14:40] teknico: i'd be really surprised if that is handled gracefully. [14:40] bac, I guess we'll find out soon enough ;-) [14:40] teknico: yes, should be interesting. put on your eye protection! [14:42] bac, and earplugs too, for good measure! === Makyo|out is now known as Makyo [15:17] uhm, nothing happened [15:29] bac bcsaller benji frankban goodspud hazmat jovan2 Makyo teknico call in 1 [15:31] bac goodspud starting [15:31] coming right there === gary_poster is now known as gary_poster|away === gary_poster|away is now known as gary_poster [16:28] hazmat, bac - use the team hangout for the meeting [16:30] goodspud: ok [17:46] could anyone please review https://codereview.appspot.com/6929057 ? no rush, I am near my EOD. Anyway, charm tests work again. [17:53] frankban, taking a look. [17:54] thanks Makyo [19:30] gary_poster, login stuff fwiw in lp:~hazmat/juju/rapi-login [19:31] * hazmat moves on to annotation support [19:31] hazmat awesome thanks. we should switch to that from rollup? [19:31] gary_poster, no.. i need to do some testing, i'll merge it into rollup after i get annotation support going [19:31] cool [19:31] gary_poster, there are a couple of unit tests, but i'd like to do an end to end test with the gui & charm [20:17] sounds good [21:28] bac, benji, bcsaller, I'm reviewing all three cards up for review (only one left). teknico's and Makyo's still need a second review, if you are willing and able. [21:28] k [21:29] I can take one as well, tell me which you want benji and I'll take the other [21:29] gary_poster: ok. i will in a bit. i just put my shoes on so the dogwalk cannot wait. [21:29] benji bcsaller bac I suggest you coordinate using the tags on the kanban cards. put your nick on the one you plan to do or are doing [21:30] I don't especially want one (or any), bcsaller; have at it [21:30] thanks all [21:30] :-) [21:47] Makyo, I take it the target-specific variables didn't have the characteristics we were hoping for? Maybe they were evaluated anyway? [21:48] (lloking at https://codereview.appspot.com/6873071/diff/1/Makefile) [21:48] looking [21:58] gary_poster, Correct. Additionally, the variable containing the target name contained the current target (which changed as make worked through the dependency tree) [21:58] Makyo, yeah I saw that second one. Too bad target specific variables are not lazy, but I guess that makes sense [21:59] in the context of other make decisions, I mean [22:00] gary_poster, yeah. Additionally the env var solution fits with the other release patterns, i.e.: PROD=1 make tarball [22:00] yeah, I thought of that. I'm mostly just going to be asking for comments explaining why we have to do this stuff. [22:01] gary_poster, okay. [22:01] gary_poster, additionally, found out that bzr ls without the -V option lists all files in the directory (but still contacts the parent branch to do so), so the later instances of that translated neatly to find commands. [22:02] Makyo, cool, though we need to exclude editor effluvia from them at the least [22:02] gary_poster, okay. Wasn't before, but that's a good addition. [22:02] Makyo, it did, because we were using bzr ls [22:03] and we don't commit editor effluvia [22:03] gary_poster, bzr ls without the -V option would include those files. -V wasn't used in those latter two instances. [22:03] ah! [22:03] suck [22:03] But that is a good addition for omitting. [22:03] well, then yes, please make it better :-) [22:03] \o/ [22:03] :-) [22:09] benji, for the charm, I'd like to be able to make a release file without uploading it. you removed the phony target to do so. Am I correct in assuming that you don't object to adding it back as long as we have a use case? [22:12] gary_poster: ah, I hadn't reallized that was a use case; sure add it back [22:13] cool thanks [22:13] I would love for us to have tests of the Makefile; I claim that we need a card to that end [22:15] benji, make a slack card to show us how we coudl do it please [22:16] we could do that in the charm too fwiw [22:16] though granted it would be nicer and more appropriate in the code itself [22:20] Makyo, reviewed: "Land with changes" :-) [22:20] running to get son from acting class... [22:20] gary_poster, thanks :) [22:25] gary_poster: i'm back but looks like all the reviews are taken [22:48] Going to lay down for a bit.